From patchwork Mon Jun 12 22:03:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 106915 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp164238vqr; Mon, 12 Jun 2023 15:16:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ70IZR5jGcFab13CX6hoF+h7iicNFPQFvT1ykBQbIxvxlQk4jPETdxTPMMpR9Uoqi5Hq6Ix X-Received: by 2002:a05:6a20:7491:b0:111:997d:d224 with SMTP id p17-20020a056a20749100b00111997dd224mr12411428pzd.19.1686608215495; Mon, 12 Jun 2023 15:16:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686608215; cv=none; d=google.com; s=arc-20160816; b=Z4wUuIMz0TxjDbe52fjnxCdA9wu7IMPlR+86f3ul03V4ABiYad0DdLMGBTKf35LVUG g3UzCU5GNxzwXfPeNQIWJEf33YXePkGVcmf3oVRRTePC+ULbvezHZBPEnP7GBpq14uTA jngPPzkS67AcQSyZ/ut3a4/RW/J4SUl0CLHiSIQo2YQcn9ShJL8nDWrEyjSDjfJygJo1 wnUZj5J54ybny4HwSzvxhs0q3dt9/U5bamR5JAFmWKThn5Q19WtcWB/hp6EG6khxf2Qw 5Mz7wYNtzY3mbB1VTra4V5ICFR6XgfvEmHfLdL+kMou12BX11ldazCmq1bbCnzvkGPWv IGvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=InFrTlz85dhUoJ9iyzM0RjKcmxjjE0VoysF4YLPizzQ=; b=fa4w4VgZatW/PMM98BBC0tuKZrV5+4VjguOJzxbS4ZOCB03GXfiyvcTVpJq6GBkNMR KtWz3XOaAFqhE3+q0kC5LpW9BG4q9bV1l7BQLV1kXtz1ga45iCnETHkYGI5cz/zFn0uh YWvIiL2ttp3t/vSnwDPQHDF1CjmG6i+/l6DSVgURdT4o+KEowzj39jfyzArnIag7gX1S HceZE+xwByEzp0JT6HyCEi6p5t4L1rntc+f7fH9AaNKPvNb3U9CyY2sNs98v+QJj/Q9s 7KXFlqfDvkUz7K+O6xzSoteD/ReciSm7k+NZNkQ44QTXtyfSyag4+62dDfzPevxZpAMJ zNig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=EjOn7ojz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h15-20020a63384f000000b0054294720d57si7379526pgn.617.2023.06.12.15.16.43; Mon, 12 Jun 2023 15:16:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=EjOn7ojz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238328AbjFLWDf (ORCPT + 99 others); Mon, 12 Jun 2023 18:03:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233166AbjFLWDd (ORCPT ); Mon, 12 Jun 2023 18:03:33 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB328E7E for ; Mon, 12 Jun 2023 15:03:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686607410; x=1718143410; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=HOyuQFngdneJCdfSjNA/K4eevMiAXCxbNP4WWdAC2rE=; b=EjOn7ojzcAtek7F37ANKMHrSZSVySkuVg8dUznFGsn0DFKRec/M/mVch oR5v7mN/1ysFttduWvBLkeC0Vp1dfEZy1EuR1bJURABcTbUvRuP63x+R5 k2E+32mURJtfBFvR11mxrCQBmM9fNHhNqL2iisu4Jr2alyNRvkTufdWVF XUh/+ReMZDE+KTsK2eyCinCyUkoWLlcT0LI8tDx6nvye8IXu4kBksiJzw Id16tb/A/zOPDCbR4lDzrlkeXhj/xSNkF+1KS06jvvsmwHBOoDVywlnci Lv4GdwJMPHH3SYGBgWfSdEoGAn4UIxXtbKUyigUIMQgA2EVpHHYyHL5j8 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="444550188" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="444550188" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2023 15:03:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="958183347" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="958183347" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga006.fm.intel.com with ESMTP; 12 Jun 2023 15:03:29 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id C4861357; Tue, 13 Jun 2023 01:03:37 +0300 (EEST) From: Andy Shevchenko To: linux-kernel@vger.kernel.org Cc: Dave Hansen , Andy Shevchenko Subject: [PATCH v1 1/1] signal: Use %*ph for printing hexdump of a small buffer Date: Tue, 13 Jun 2023 01:03:34 +0300 Message-Id: <20230612220334.44177-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768536895919464728?= X-GMAIL-MSGID: =?utf-8?q?1768536895919464728?= The kernel already has a helper to print a hexdump of a small buffer via pointer extension. Use that instead of open coded variant. In long term it helps to kill pr_cont() or at least narrow down its use. Signed-off-by: Andy Shevchenko --- kernel/signal.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/kernel/signal.c b/kernel/signal.c index b5370fe5c198..6be2df76f0b4 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -1259,18 +1259,17 @@ static void print_fatal_signal(int signr) pr_info("potentially unexpected fatal signal %d.\n", signr); #if defined(__i386__) && !defined(__arch_um__) - pr_info("code at %08lx: ", regs->ip); { + unsigned char insn[16]; int i; + for (i = 0; i < 16; i++) { - unsigned char insn; - - if (get_user(insn, (unsigned char *)(regs->ip + i))) + if (get_user(insn[i], (unsigned char __user *)(regs->ip + i))) break; - pr_cont("%02x ", insn); } + + pr_info("code at %08lx: %*ph\n", regs->ip, i, insn); } - pr_cont("\n"); #endif preempt_disable(); show_regs(regs);