From patchwork Mon Jun 12 21:23:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 106904 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp153171vqr; Mon, 12 Jun 2023 14:54:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5dcLXRVVNuWkPi+wHk9uzVEmqvCXtxJE5E/q9N723XvjxPLL0CGhjBTEUl6qX/YLprlo6S X-Received: by 2002:a05:6a20:2d29:b0:10c:8e0f:7b1b with SMTP id g41-20020a056a202d2900b0010c8e0f7b1bmr10474100pzl.59.1686606874082; Mon, 12 Jun 2023 14:54:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686606874; cv=none; d=google.com; s=arc-20160816; b=b3wOz8yV6r13OZGrpKKvuUV4Z9PUzMEFN7D2773ruOZNPSnAnHehGvbxqgwNw+s16y 1Cm17DN3ARAO+pEu0pfMMEDWK2iyUd/FT/Y2ve+7sjlPTd+8oE4TyEzXtuel8t6tblQe JTsQGLaVDNnwJE4o9+loegdMCnK0QdLtZD1xckebGDIhi7JumeUbkQ+c1lG704sfRj4d 4VDYQsp4B0AW9fFkXz71WvbnH+jmhFN9AvyisPo8rz1JN5u500HjCIUMEK2Zw/AY045I kQiFWgr82HiawzkllToUBYlHYNb4a6vJzDw77GPNqLt4JJajUsJfx8H0qSr03wPQr+rO EnAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=q6IMgiV9u6FWmmEAoKFb/Pk8CXS0BwUoEbhzpJMSbXU=; b=L5wNkcCkK7H99T7TS++5QCRMUF91MysrP6tVNn4Ymc1ZhBQgc+S9v0kxBNhxF+0ktQ CeAhpwDxORbnvwLGqO1XpgD9peleZEcYuRmPZF3IKQhirfaq/OlrRsUcAKBM7AL7GZkq gS2pW5EUi6O6ZfBYOXqbxOgi7QbUnmjiOLX3eDvOJdjRFEltTf6TbWtS4cHsl4tHEg6G 0Fi8elsKfnwKTd0Y6Rd88vcdmakXBfnDsCSPNLvegCsb79GePVucK1hwFp8zN9JgmIGj pAPuapz9p1quWFeS6bmyfTbyrIwlHrLRMUu5zNbfw7y3xIdiktsY9Zle3j4DG2Z+hZxU AWqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=F6ntnhE3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p9-20020a639509000000b0052868a865d4si7407628pgd.553.2023.06.12.14.54.21; Mon, 12 Jun 2023 14:54:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=F6ntnhE3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237876AbjFLVZr (ORCPT + 99 others); Mon, 12 Jun 2023 17:25:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239061AbjFLVZY (ORCPT ); Mon, 12 Jun 2023 17:25:24 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DBE010EB for ; Mon, 12 Jun 2023 14:23:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686605011; x=1718141011; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=OnJIaM6mT/0GSvLlclpAypaShpM1x4qhu+renP9R2l8=; b=F6ntnhE3FWIL9X9D2UpCRhDiFP8LmqvXbopQKVJVhMWirTIReZbWTYkD jSWFta9+x73qUF/etA+PmnGccaiCCAvgCJpbYyTfeZr8flHfIDC+lJr/4 Na8z8dId058+TRlsrRcKxOfK9+f2RfUh0/VYH98kBLSwlkVsuObTFb2yc FRVUbeCIdfor0tXCP3auqxLMdaQ5xcO1cEN7S9+klxARitJmScWjFZKM8 XcyCpZ6/2saCd75+l1WgC22UmusQalIJnUYYdHLstfBwtdGJUgCUX1TMv RenIz1vUfVYP6XkQ5CrUHiNFOJ8AAcsM/kuhLhbr8xL4Ga82InOFIOwPo A==; X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="444542960" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="444542960" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2023 14:23:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="705539158" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="705539158" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga007.jf.intel.com with ESMTP; 12 Jun 2023 14:23:29 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id DF037357; Tue, 13 Jun 2023 00:23:37 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Benson Leung , Guenter Roeck Subject: [PATCH v1 1/1] platform/chrome: cros_ec_spi: Use %*ph for printing hexdump of a small buffer Date: Tue, 13 Jun 2023 00:23:36 +0300 Message-Id: <20230612212336.4961-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768535489349091379?= X-GMAIL-MSGID: =?utf-8?q?1768535489349091379?= The kernel already has a helper to print a hexdump of a small buffer via pointer extension. Use that instead of open coded variant. In long term it helps to kill pr_cont() or at least narrow down its use. Signed-off-by: Andy Shevchenko --- drivers/platform/chrome/cros_ec_spi.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_spi.c b/drivers/platform/chrome/cros_ec_spi.c index 21143dba8970..3e88cc92e819 100644 --- a/drivers/platform/chrome/cros_ec_spi.c +++ b/drivers/platform/chrome/cros_ec_spi.c @@ -104,13 +104,7 @@ static void debug_packet(struct device *dev, const char *name, u8 *ptr, int len) { #ifdef DEBUG - int i; - - dev_dbg(dev, "%s: ", name); - for (i = 0; i < len; i++) - pr_cont(" %02x", ptr[i]); - - pr_cont("\n"); + dev_dbg(dev, "%s: %*ph\n", name, len, ptr); #endif }