From patchwork Mon Jun 12 20:24:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 106805 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp118094vqr; Mon, 12 Jun 2023 13:33:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7T4jgCX0bM+9/1kbKxVm+BTC1FSMjbDggho28ydDiAnf4Q1PHNV1ByK+TUS5ux4Zb/d75m X-Received: by 2002:a05:6a00:2451:b0:650:154:8ad with SMTP id d17-20020a056a00245100b00650015408admr12709902pfj.11.1686602020169; Mon, 12 Jun 2023 13:33:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686602020; cv=none; d=google.com; s=arc-20160816; b=Wq2p1LQq7HXNCG3b0oDmVhJxFmyxA/SVWSsdjjqCeZwwGZ/lttQwdKykaB4KIG6CFD uiQHCtomJm1zkld0BJnvwauYQ4FPc7/l7n6vnV8QA89rz0k4YV8cLG4r2adH47RY2gwW PdnI8RJSJL5NGvBPTKt+Nr7ikpNqle+xRrXJXbHMKOdnsZB2StTd/M+9eFcdiXQediOZ N4aQr/+J17Lha7bw+yzDHoUGYMsRkCedLlPfjfWaU2AZWFF3HQk7XoQre11chEqRCfie 8WR5aMbCawucMuLrsMfSmIFfKZuQHFzolq7stY0pCC+zoI8vRowOTENXRnoih4Ccwv21 hXXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-transfer-encoding :content-id:mime-version:subject:cc:to:from:organization :dkim-signature; bh=S42fl/HoNEU97xotwFSAjJfWCsSnH9zjSpzpvH3McME=; b=xdyK9UpfimMTpCXuuuXxqJL/jxI2oykHEsq70WjhCC3Gi7Ayr4n87qFesBBqEcyG03 ji0XNl0/F3aCIqiTY1is4d0OyPnpb1J8HUYHqGYVayxeoOeroq0i2NgEjspKZcTPGqGS KST1lhwj/cMjOXx/rODAI+m3RlXQGK4s/vvKij04E8XfkcAuGpceIQBUE5nx7OJybDpj KnZxuMvU7EPj6yXyetwNFAEyluRDDGjYJ+aIi/5PLAvoUoA8foVstb9y+k5Dj9v9vdti l1KijoETy9dCkW5S8VpODqRHjNMXW0bckK3FPF67q804ZNxII8/K+UCUYFI/he30ECSX zOHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XbGvS7DF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bs66-20020a632845000000b0054b4670f5e0si2828886pgb.39.2023.06.12.13.33.24; Mon, 12 Jun 2023 13:33:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XbGvS7DF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237637AbjFLUZj (ORCPT + 99 others); Mon, 12 Jun 2023 16:25:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237325AbjFLUZ2 (ORCPT ); Mon, 12 Jun 2023 16:25:28 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 177E6171F for ; Mon, 12 Jun 2023 13:24:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686601481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=S42fl/HoNEU97xotwFSAjJfWCsSnH9zjSpzpvH3McME=; b=XbGvS7DFB81vZcz9I4UhVIyY1v6qVH0rgmyNhMTUl/OQdwuz7bbfJsjLYoNnOV7hyiN4zy M9GIMSoybOrhMHsNzDtyv9Vb05sSRx5vBvXLacRWAJjJYVxdkrXYgiZ4Qd2+Aebx8XmNIe TJ/kuwTUdTAFCS9qEQkLS43tfiZefFw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-139-xzVXP3XYOhqICv2yzeVXDA-1; Mon, 12 Jun 2023 16:24:38 -0400 X-MC-Unique: xzVXP3XYOhqICv2yzeVXDA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 230618037AA; Mon, 12 Jun 2023 20:24:37 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id A51B12956; Mon, 12 Jun 2023 20:24:34 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells To: Jens Axboe , David Hildenbrand , kernel test robot cc: dhowells@redhat.com, Christoph Hellwig , Andrew Morton , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Lorenzo Stoakes , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org Subject: [PATCH v2] block: Fix dio_bio_alloc() to set BIO_PAGE_PINNED MIME-Version: 1.0 Content-ID: <545462.1686601473.1@warthog.procyon.org.uk> Date: Mon, 12 Jun 2023 21:24:33 +0100 Message-ID: <545463.1686601473@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768518113192334131?= X-GMAIL-MSGID: =?utf-8?q?1768530399950781597?= Fix dio_bio_alloc() to set BIO_PAGE_PINNED, not BIO_PAGE_REFFED, so that the bio code unpins the pinned pages rather than putting a ref on them. The issue was causing: WARNING: CPU: 6 PID: 2220 at mm/gup.c:76 try_get_folio This can be caused by creating a file on a loopback UDF filesystem, opening it O_DIRECT and making two writes to it from the same source buffer. Fixes: 1ccf164ec866 ("block: Use iov_iter_extract_pages() and page pinning in direct-io.c") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-lkp/202306120931.a9606b88-oliver.sang@intel.com Signed-off-by: David Howells cc: Christoph Hellwig cc: David Hildenbrand cc: Andrew Morton cc: Jens Axboe cc: Al Viro cc: Matthew Wilcox cc: Jan Kara cc: Jeff Layton cc: Jason Gunthorpe cc: Logan Gunthorpe cc: Hillf Danton cc: Christian Brauner cc: Linus Torvalds cc: linux-fsdevel@vger.kernel.org cc: linux-block@vger.kernel.org cc: linux-kernel@vger.kernel.org cc: linux-mm@kvack.org Reviewed-by: Christoph Hellwig Reviewed-by: David Hildenbrand --- Notes: ver #2) - Remove comment on requiring references for all pages. fs/direct-io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/direct-io.c b/fs/direct-io.c index 14049204cac8..5d4c5be0fb41 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c @@ -414,8 +414,8 @@ dio_bio_alloc(struct dio *dio, struct dio_submit *sdio, bio->bi_end_io = dio_bio_end_aio; else bio->bi_end_io = dio_bio_end_io; - /* for now require references for all pages */ - bio_set_flag(bio, BIO_PAGE_REFFED); + if (dio->need_unpin) + bio_set_flag(bio, BIO_PAGE_PINNED); sdio->bio = bio; sdio->logical_offset_in_bio = sdio->cur_page_fs_offset; }