From patchwork Mon Jun 12 13:19:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 106586 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2583172vqr; Mon, 12 Jun 2023 06:19:53 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ55+2OebJXPcH3EL2ZLnCyEhEVG8fqA0HBDMUlh8IOGdfV8JfDZC3ra7a1XZfcEGiJcCU1P X-Received: by 2002:a2e:8401:0:b0:2aa:3cee:c174 with SMTP id z1-20020a2e8401000000b002aa3ceec174mr2608034ljg.13.1686575993248; Mon, 12 Jun 2023 06:19:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686575993; cv=none; d=google.com; s=arc-20160816; b=TqeoTAuaaHkWrvb8us7asiU1OQc+2mRs0xStU6Na03oHADzLFECwCTkTb1TNrDXjQh RJ/KHuFO+9S5fYTjh55tDCnAhlrtR8KnQZC6QxttL6O+PtmmK2Z2w0UhHfV1j/m2kz67 AGaRbkAFtrm405dhcMuZjrNC0T9eijdAMDNLNtNNCwV9hsgkB0nqLA1una3UKRCe1GuX tQ1JQMFYpp//kXZVz+DVNJoVr0eCP9f2ejUueLU4mrPFSQo4FMvolafIySKlUEfmLPoq jZkR/+DDWUYzoZFgo/FqfG1J8nSOT7JD7P7Agm5RvN54GkMy6SQfjyAQVpfymf1V50tg 6Oyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:message-id :mime-version:subject:to:date:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=RYOG2wwZL5/CKTQuUZjYiE5cjDB49lSSJpOYuJXCG20=; b=uisIKONsXirrsxzmmCYZ0ow73RHDkD10KPS4oKwM1Sp9dzJKDKEBuX0ulmCBn/Vqhl IIok+QVmufJPYuL7g81NVLfjILkrcyZtvqZVhOrS8XnhKtRVjk5VWcScr73/PueGJYNM trl0WoUONFLdKwKvFjORfGfMMc6GPdC5GMyqa1Lwc+DNENvI3/ZnqGUNmvBxQXSNO8Wl rs0zc4LOcKB8SozmZ7S9KBJCwEGHfpX85pRJnjnYlc6k2J7Wgi8uvIe6i0UaT79j8Sz+ puFlq4sQr4HAa1ygyvhXuTgafavVEirIy0gdhJJwb/gWNm9QAC8J3D/X/GRdLe747Yl4 cMxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=ckCf6pxA; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id j15-20020a50ed0f000000b00516a103a5afsi1735578eds.659.2023.06.12.06.19.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 06:19:53 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=ckCf6pxA; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E51FD385842A for ; Mon, 12 Jun 2023 13:19:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E51FD385842A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1686575987; bh=RYOG2wwZL5/CKTQuUZjYiE5cjDB49lSSJpOYuJXCG20=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=ckCf6pxAR1BlGrtrGmwUYgdvvPwkJNYzWe6vIjaZcFj9h8ZKXk1i1NQ6zH4izhfUc 06X8mmbk5vRPwhOVmLgslINTEF6EfGHU96huOQeWHIU29R0bfslVxgBKrJx3IiuBSQ 1lGVpZdW4zvvLlT9npwD7FODNEetDSIaIt43ueXM= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 12BFB3858D32 for ; Mon, 12 Jun 2023 13:19:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 12BFB3858D32 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4032022853 for ; Mon, 12 Jun 2023 13:19:03 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2C776138EC for ; Mon, 12 Jun 2023 13:19:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id LDGTCUcbh2ScfgAAMHmgww (envelope-from ) for ; Mon, 12 Jun 2023 13:19:03 +0000 Date: Mon, 12 Jun 2023 15:19:02 +0200 (CEST) To: gcc-patches@gcc.gnu.org Subject: [PATCH] Fix disambiguation against .MASK_STORE MIME-Version: 1.0 Message-Id: <20230612131903.2C776138EC@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768503108324759386?= X-GMAIL-MSGID: =?utf-8?q?1768503108324759386?= Alias analysis was treating .MASK_STORE as storing a full vector which means we disambiguate against decls of smaller than vector size. That's of course wrong and a similar issue was fixed for DSE already. The following makes sure we set the size of the access to unknown and only constrain max_size. This fixes runtime execution FAILs of gfortran.dg/matmul_2.f90, gfortran.dg/matmul_6.f90 and gfortran.dg/pr91577.f90 when using AVX512 with full masked loop vectorization on Zen4. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed to trunk sofar. * tree-ssa-alias.cc (call_may_clobber_ref_p_1): For .MASK_STORE and friend set the size of the access to unknown. --- gcc/tree-ssa-alias.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gcc/tree-ssa-alias.cc b/gcc/tree-ssa-alias.cc index 79ed956e300..b5476e8b41e 100644 --- a/gcc/tree-ssa-alias.cc +++ b/gcc/tree-ssa-alias.cc @@ -3072,6 +3072,9 @@ call_may_clobber_ref_p_1 (gcall *call, ao_ref *ref, bool tbaa_p) ao_ref lhs_ref; ao_ref_init_from_ptr_and_size (&lhs_ref, gimple_call_arg (call, 0), TYPE_SIZE_UNIT (TREE_TYPE (rhs))); + /* We cannot make this a known-size access since otherwise + we disambiguate against stores to decls that are smaller. */ + lhs_ref.size = -1; lhs_ref.ref_alias_set = lhs_ref.base_alias_set = tbaa_p ? get_deref_alias_set (TREE_TYPE (gimple_call_arg (call, 1))) : 0;