From patchwork Mon Jun 12 10:45:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 106518 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2520498vqr; Mon, 12 Jun 2023 04:38:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4mOldPk0UBwvuSbOcYyEi7+SI+3jaL2n4twPBuqxrO44MqBLXVpbUkgZL0oVm1os3M/Rdd X-Received: by 2002:a17:902:e752:b0:1af:fbb6:23b7 with SMTP id p18-20020a170902e75200b001affbb623b7mr7360145plf.3.1686569904331; Mon, 12 Jun 2023 04:38:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686569904; cv=none; d=google.com; s=arc-20160816; b=g8TK5x1iTPVnkQojxhRyiKiC5COgZiJ0SCsKSIwPnRNU2Yp95ZEu6xg++5roXccYup 8VgQbMOo+/f41ZDognYLTMe/KcOyHeFoK+ShSBbqPQfIK+bWughrRlJsBrfBmm2vQW+k 9Hyp2KbSnGbODo0J1de8XjtVgO7CmjM/gSDzPSYs1oiCJeOUCNDgWr68hyasSwg9yAZc 2EnEGrXQe58aY4ZEE391hqVUzqWXpXhinUkXChSL2Ke+LsONJlvCSbqSuSOpMqgKEC76 j448NWcClx8wSH8/19DKhvh5cNr9FFInvBKrl7q0mil1T+n2OBB93lAJVL8R1HnPn+wl nBtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=s7r+UwPZrFwZ8U4ULo3LRAMxaqXDUK6fDgiHGSSK4Do=; b=Cqxb7SGiIbPl/dPP7M7cZoWRG+h8MSL8pPnhOnDZhNRD6TTA5TU2lt+xVrExrekO1I cAOuWFQhvMYpojo1XMPAKRXXl0XjStpMOcuL7tBqT6JNXPMWJl6Nu3nj+BgBvg376a7N 31YLs/l2vXUvSuAdTB3XkNZQkojdqJ6Kj/FwOo3NGbw7m9WGwphgpd17mSDWtBEjNyEt ADlhJYRTmFUrVi3X4hAs35BquTXEcnP8mystpP1niHf8v+BIC9yMxdAMDOOILSerQb3P Q4+NPDpMxn2A4PJ8sKMbjJrZcfvXOxKmGh7SO13HXBBcartcat7SPJ1CKH4GtKBCwgnG rj5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=i06u1gEY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e8-20020a170902ef4800b001ab18eacb8csi6863943plx.526.2023.06.12.04.38.11; Mon, 12 Jun 2023 04:38:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=i06u1gEY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237240AbjFLK6A (ORCPT + 99 others); Mon, 12 Jun 2023 06:58:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236952AbjFLK5e (ORCPT ); Mon, 12 Jun 2023 06:57:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2D8E59D2; Mon, 12 Jun 2023 03:45:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 70BA062418; Mon, 12 Jun 2023 10:45:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0036FC4339B; Mon, 12 Jun 2023 10:45:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686566731; bh=U7K8PnSDrmyymIFt6bT08pkz1Ns5zBOLh78eoHWTYGs=; h=From:To:Subject:Date:In-Reply-To:References:From; b=i06u1gEYX2bd4j+uPzysbIxDaAwT6/CTUZOpnTs1UyXa7/5s7cUOEwUqZ3dlGz3O4 jFNXbxogq3HUsHaG8qzS2pUjFsLZ0pwm34sHEhWINSBx3x3GHErV87Ysw0Qytwbwe8 fFUrKe3sgWnKHIxnfLIjIUsPaN3Sh8LJvyjX55+rRGLxXbSB1eObzfgCW6lRFnH3r+ h9bCABGuEIoV6ij5WT16QU8p0vaVIMpWRciWV/eJdOCZn29lSLhV+99EbZsWG/Pglk 4MesuWDQf7yKM7JEJ5xr1+7Gp2JHA67EJFTynNQZaj0+fP9ZhYPuRC0fRqK+SN0Ale ksZ9p+qMIL1gg== From: Jeff Layton To: Christian Brauner , Al Viro , Brad Warrum , Ritu Agarwal , Arnd Bergmann , Greg Kroah-Hartman , Ian Kent , "Tigran A. Aivazian" , Jeremy Kerr , Ard Biesheuvel , Namjae Jeon , Sungjong Seo , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Ruihan Li , Sebastian Reichel , Alan Stern , Suren Baghdasaryan , Wolfram Sang , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, autofs@vger.kernel.org, linux-efi@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org Subject: [PATCH v2 1/8] ibmvmc: update ctime in conjunction with mtime on write Date: Mon, 12 Jun 2023 06:45:17 -0400 Message-Id: <20230612104524.17058-2-jlayton@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230612104524.17058-1-jlayton@kernel.org> References: <20230612104524.17058-1-jlayton@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768496724051880948?= X-GMAIL-MSGID: =?utf-8?q?1768496724051880948?= POSIX says: "Upon successful completion, where nbyte is greater than 0, write() shall mark for update the last data modification and last file status change timestamps of the file..." Signed-off-by: Jeff Layton --- drivers/misc/ibmvmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/ibmvmc.c b/drivers/misc/ibmvmc.c index cbaf6d35e854..d7c7f0305257 100644 --- a/drivers/misc/ibmvmc.c +++ b/drivers/misc/ibmvmc.c @@ -1124,7 +1124,7 @@ static ssize_t ibmvmc_write(struct file *file, const char *buffer, goto out; inode = file_inode(file); - inode->i_mtime = current_time(inode); + inode->i_mtime = inode->i_ctime = current_time(inode); mark_inode_dirty(inode); dev_dbg(adapter->dev, "write: file = 0x%lx, count = 0x%lx\n", From patchwork Mon Jun 12 10:45:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 106515 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2519956vqr; Mon, 12 Jun 2023 04:37:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7XQR7/o0aFynZGHGAexeVN+KLuxcBiW49xU3bZ3114yeEFnecESM+KkNEGvT4YoATTSMIZ X-Received: by 2002:a2e:b04e:0:b0:2b1:d19a:f190 with SMTP id d14-20020a2eb04e000000b002b1d19af190mr2383668ljl.49.1686569837239; Mon, 12 Jun 2023 04:37:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686569837; cv=none; d=google.com; s=arc-20160816; b=D4EWu2+74yfkL4Ao4SJXzBXqmoc7dJnmpeohv2TwU6FHqopWQOPQoo9bjQHsshtipd 2qRaxcy6Bxtluf4ocwm3U9mse5yF3GURUPDSVxittxB9EutYnDl09vTYSMfllxjEsKKL HopBrFWgtDdQtUY7HHoSQKEVY0S0MDG5TKTDcd/cc0HfGxDdrywYjCxrH/hdb7ZrpK4X 86vlaRgA4lVqBzR4emKJgXwngLdHosx8fed5AD96yMKHXGFFpqvFJiX7Pfzkl0LQ1I08 knsoDFDOFTaQziY9xKlFLPKHdQqAWKZmebWbmCJ7/WzSKzkyskEXcVatQvybf93nLZy/ 1suw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=WoPFaVrUyLtvDUYrmLRbP00rLsfd8L8iM4ueLeVPS5c=; b=dloDOwNisXA2RTKeZ+U7LuoIxQoOo25rOCbPEw3kI7v5joNtu94yu1FsX7JU+uZHja 02kIUSvqCV7lMRK7avOtccAnjBgx7H5lZlU+4w0FD8L7jd4h5TqI7lFFteXoxXqQex88 sNGw9afBD6I5K2/swmGSCbEsNZPmyxKMIaVOANdrt4nuR9NcVAkIBIzsHGS/H7SU0YFW UPxzCgtNFR+vL/RZw7w4CztXIRmh//+bsOZvevxUpmG7/jTrH9I2TPRtsXMqlyxkuFMq RcmRNleb4mN6J+gTu/8UzwIisGV8ISI69zY7Hed2FVfDn7bBn2BTJydzWVFoWo0tV8oq Y7WA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XNPqT5xC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o10-20020a17090611ca00b0096f560fb6absi1758581eja.822.2023.06.12.04.36.52; Mon, 12 Jun 2023 04:37:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XNPqT5xC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236989AbjFLK6P (ORCPT + 99 others); Mon, 12 Jun 2023 06:58:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236960AbjFLK5g (ORCPT ); Mon, 12 Jun 2023 06:57:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26DB8E572; Mon, 12 Jun 2023 03:45:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A2DD162450; Mon, 12 Jun 2023 10:45:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2AB4FC433D2; Mon, 12 Jun 2023 10:45:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686566735; bh=f+sv9c83YeZdEFyBLfaVXVS9uGARTf71K6hxZfrcSr4=; h=From:To:Subject:Date:In-Reply-To:References:From; b=XNPqT5xCR/WjIlqL84s4wlNFJCgGYAqKwg9zWLKMlluT43pgIvq6UYpc7QjKUhuWL nVIrZgjKf9Le2yKWvchiJV4LBbC0ljP1qKKTZdnKa3LICWwFNHz7sMCYSAO1yPGWJc ixIaxMQwn51TByDyIFIJ4whm3OajAgo0a8S2bf51eFvXRyczHtk84FQpWxkDHAGszp 9PgkQIWwHJTlHW8C02GLU7kZQHk3jA/g7J+XX7rjLsmWIk6SAhbZ3n7MsZXHbQi8fq 1BN620+hBAnd5L8CGYKibFXxe0Hxle4OVCsDLjX9mMgrdf+RzkMkt3m7jsKCrQeUGe l++bREhCo36qQ== From: Jeff Layton To: Christian Brauner , Al Viro , Brad Warrum , Ritu Agarwal , Arnd Bergmann , Greg Kroah-Hartman , Ian Kent , "Tigran A. Aivazian" , Jeremy Kerr , Ard Biesheuvel , Namjae Jeon , Sungjong Seo , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Ruihan Li , Sebastian Reichel , Alan Stern , Suren Baghdasaryan , Wolfram Sang , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, autofs@vger.kernel.org, linux-efi@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org Subject: [PATCH v2 2/8] usb: update the ctime as well when updating mtime after an ioctl Date: Mon, 12 Jun 2023 06:45:18 -0400 Message-Id: <20230612104524.17058-3-jlayton@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230612104524.17058-1-jlayton@kernel.org> References: <20230612104524.17058-1-jlayton@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768496653507923392?= X-GMAIL-MSGID: =?utf-8?q?1768496653507923392?= In general, POSIX requires that when the mtime is updated that the ctime be updated as well. Add the missing timestamp updates to the usb ioctls. Signed-off-by: Jeff Layton --- drivers/usb/core/devio.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index fcf68818e999..1268d313a8df 100644 --- a/drivers/usb/core/devio.c +++ b/drivers/usb/core/devio.c @@ -2640,21 +2640,21 @@ static long usbdev_do_ioctl(struct file *file, unsigned int cmd, snoop(&dev->dev, "%s: CONTROL\n", __func__); ret = proc_control(ps, p); if (ret >= 0) - inode->i_mtime = current_time(inode); + inode->i_mtime = inode->i_ctime = current_time(inode); break; case USBDEVFS_BULK: snoop(&dev->dev, "%s: BULK\n", __func__); ret = proc_bulk(ps, p); if (ret >= 0) - inode->i_mtime = current_time(inode); + inode->i_mtime = inode->i_ctime = current_time(inode); break; case USBDEVFS_RESETEP: snoop(&dev->dev, "%s: RESETEP\n", __func__); ret = proc_resetep(ps, p); if (ret >= 0) - inode->i_mtime = current_time(inode); + inode->i_mtime = inode->i_ctime = current_time(inode); break; case USBDEVFS_RESET: @@ -2666,7 +2666,7 @@ static long usbdev_do_ioctl(struct file *file, unsigned int cmd, snoop(&dev->dev, "%s: CLEAR_HALT\n", __func__); ret = proc_clearhalt(ps, p); if (ret >= 0) - inode->i_mtime = current_time(inode); + inode->i_mtime = inode->i_ctime = current_time(inode); break; case USBDEVFS_GETDRIVER: @@ -2693,7 +2693,7 @@ static long usbdev_do_ioctl(struct file *file, unsigned int cmd, snoop(&dev->dev, "%s: SUBMITURB\n", __func__); ret = proc_submiturb(ps, p); if (ret >= 0) - inode->i_mtime = current_time(inode); + inode->i_mtime = inode->i_ctime = current_time(inode); break; #ifdef CONFIG_COMPAT @@ -2701,14 +2701,14 @@ static long usbdev_do_ioctl(struct file *file, unsigned int cmd, snoop(&dev->dev, "%s: CONTROL32\n", __func__); ret = proc_control_compat(ps, p); if (ret >= 0) - inode->i_mtime = current_time(inode); + inode->i_mtime = inode->i_ctime = current_time(inode); break; case USBDEVFS_BULK32: snoop(&dev->dev, "%s: BULK32\n", __func__); ret = proc_bulk_compat(ps, p); if (ret >= 0) - inode->i_mtime = current_time(inode); + inode->i_mtime = inode->i_ctime = current_time(inode); break; case USBDEVFS_DISCSIGNAL32: @@ -2720,7 +2720,7 @@ static long usbdev_do_ioctl(struct file *file, unsigned int cmd, snoop(&dev->dev, "%s: SUBMITURB32\n", __func__); ret = proc_submiturb_compat(ps, p); if (ret >= 0) - inode->i_mtime = current_time(inode); + inode->i_mtime = inode->i_ctime = current_time(inode); break; case USBDEVFS_IOCTL32: From patchwork Mon Jun 12 10:45:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 106504 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2508565vqr; Mon, 12 Jun 2023 04:16:23 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ52VQM8hf6lXsZZDR/XQXvr4W4shX9ZddQaQa2XTFEUcGLXXhRzROurn/BTNan204IrTUFm X-Received: by 2002:a05:6808:19a5:b0:398:342a:f491 with SMTP id bj37-20020a05680819a500b00398342af491mr4475565oib.34.1686568583176; Mon, 12 Jun 2023 04:16:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686568583; cv=none; d=google.com; s=arc-20160816; b=JjqVAzCy0ZyDNacOCRapWLTYOIlJ9jN1EL2w4a7SHX1Px5SwuOMLrEp3ZQHVlUpdqn k2vQKknXgI+Tluqs8/B8ONXFiisoHhfCrdQK4hbX/t6ji/rUOaqZNHzzaTlhkiHRFf0q uqlgYaUvqdu2Vjji+KdYd74yfPzbHZbKNCtCSK/AYG1fPPXGI2uAmCM2awpMDKYuG/y0 uvn5paFXFmxyXjvPox+UtMQn/TZ6nDSvObjdXm8xwTjOizYy6TMb0c7+r/bGJvwSu5nu ixZJnrPsEN+UUbJXVV/o2gVpyMu7a78z/sFbPOgsqMe5MHjk5J+S0Ld0naHBEMsLnno8 QCfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=3MjDvwzK4mu9jxSf97gvBFK/y6YdeFO8Sr9n3S/PTvQ=; b=X0LuXiukyFXTLpgAGI+jNSdR7uNlh1mfLuKuQawObfP/ubNl2ZZFg03+aVDZi2So5I oyIkPk/YAL+xN0UeQy1zCGYJIAWAnjBsBtpJn/OfnzrA8+6W1E77NKsg3kVAsc5VGVQ7 btKqiUOTxR+1b9AXypWFLo8m52uXavFtWLenN9q3REnTYsog1fuW4FOwdDcvea9fbBIg iCXdonI5hvZOn7LL9gxGBdHWyKk2xho3+jY0KIEGa7olFVve9S++3COSskFUzEDD6tk9 X/YXgMeYXs9llLyuLLtm2XIBV/9idxmmYQOqOzMCG6vWuJK18wNyVzASoJiH0mtkXlkK ZjnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VNA1yc1Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h7-20020a17090a710700b0025c038134aasi68450pjk.163.2023.06.12.04.16.09; Mon, 12 Jun 2023 04:16:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VNA1yc1Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237036AbjFLK6E (ORCPT + 99 others); Mon, 12 Jun 2023 06:58:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237094AbjFLK5h (ORCPT ); Mon, 12 Jun 2023 06:57:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40316E576; Mon, 12 Jun 2023 03:45:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C90E9615CB; Mon, 12 Jun 2023 10:45:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53A4BC433A8; Mon, 12 Jun 2023 10:45:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686566738; bh=8dWgF0uA6APXTiliajrD56DAKjnBaeRdxdQyPjiYPP0=; h=From:To:Subject:Date:In-Reply-To:References:From; b=VNA1yc1YyUY8iRFte4FmbUVtUf3xLJi9hXnJ6eWRWnAhBF+pd7YKghWhRecMCbgZ7 yr57R+PZlxmUOpKdY6vogdgf5Gr4klr4agBTonta+PtTNZoD86j0g27zvORW3eK9OK ckKAln6kq/vdGBqDPxe0AphUUeibkpmZMvXEy35ssAkNPNlLtCWCucxt0cbrWCXW9/ a+Glo0O8+HA/jny1S2QTYqeGAXtduUlAp2ea5Gda6IIdGCnuOB1R0PcM6OVZvKiBvR LUcA7rvDLDnW/kSTwRPVhk1jLDA13CgKbUj/bA6NF07G9p+lglD/zt4af6w3SGbIYA guYVuHpahZfuw== From: Jeff Layton To: Christian Brauner , Al Viro , Brad Warrum , Ritu Agarwal , Arnd Bergmann , Greg Kroah-Hartman , Ian Kent , "Tigran A. Aivazian" , Jeremy Kerr , Ard Biesheuvel , Namjae Jeon , Sungjong Seo , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Ruihan Li , Sebastian Reichel , Alan Stern , Suren Baghdasaryan , Wolfram Sang , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, autofs@vger.kernel.org, linux-efi@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org Subject: [PATCH v2 3/8] autofs: set ctime as well when mtime changes on a dir Date: Mon, 12 Jun 2023 06:45:19 -0400 Message-Id: <20230612104524.17058-4-jlayton@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230612104524.17058-1-jlayton@kernel.org> References: <20230612104524.17058-1-jlayton@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768495338375023307?= X-GMAIL-MSGID: =?utf-8?q?1768495338375023307?= When adding entries to a directory, POSIX generally requires that the ctime also be updated alongside the mtime. Signed-off-by: Jeff Layton Acked-by: Ian Kent --- fs/autofs/root.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/autofs/root.c b/fs/autofs/root.c index 6baf90b08e0e..93046c9dc461 100644 --- a/fs/autofs/root.c +++ b/fs/autofs/root.c @@ -600,7 +600,7 @@ static int autofs_dir_symlink(struct mnt_idmap *idmap, p_ino = autofs_dentry_ino(dentry->d_parent); p_ino->count++; - dir->i_mtime = current_time(dir); + dir->i_mtime = dir->i_ctime = current_time(dir); return 0; } @@ -633,7 +633,7 @@ static int autofs_dir_unlink(struct inode *dir, struct dentry *dentry) d_inode(dentry)->i_size = 0; clear_nlink(d_inode(dentry)); - dir->i_mtime = current_time(dir); + dir->i_mtime = dir->i_ctime = current_time(dir); spin_lock(&sbi->lookup_lock); __autofs_add_expiring(dentry); @@ -749,7 +749,7 @@ static int autofs_dir_mkdir(struct mnt_idmap *idmap, p_ino = autofs_dentry_ino(dentry->d_parent); p_ino->count++; inc_nlink(dir); - dir->i_mtime = current_time(dir); + dir->i_mtime = dir->i_ctime = current_time(dir); return 0; } From patchwork Mon Jun 12 10:45:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 106507 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2518752vqr; Mon, 12 Jun 2023 04:35:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7kS6bGraH0DaDybD4q9WDWvNtAqeoZ7DiGTKGGYzuLR/d767Qi86rjVHYL1rcMQ65/cJT4 X-Received: by 2002:a17:906:ef07:b0:96f:7b4a:2904 with SMTP id f7-20020a170906ef0700b0096f7b4a2904mr9542356ejs.3.1686569699762; Mon, 12 Jun 2023 04:34:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686569699; cv=none; d=google.com; s=arc-20160816; b=EdSsG/J67UOBhCAjsVovc4sEUUO4e15yLOFzjJPH8gkzX91H53wVBziI1m9CgKfDvG 25Wrbf10JC0//ZfbWN5CTg+Em3acQrgqv+fIiRvgC8uNo66O85q61ezrf1r4ucPsPoxg fONrECpLza4ZCG6xbDMkdY3ZvUZcm+8AZw7qH3c8NAr7dxaW8RR8+cvui50Dj/2L5k/F GgaClR5I/SY/l+iEfCEO/LrmpzUWYJBa/483IbI2kwJJui+aal9zHwlXGsuC6utf5l7F TyD5KYtH2fRGND7yvIuu6SnL4C4hY4Ce5ngvXx2Bsm/lN2KIEKq1ZvYKDyPh/7tROs2c A6tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=2tBSpJm8b1r98X8Ny1VVYst3rSSPOUDaEaXGyCCko9k=; b=pfnvaFI5/5u7K1XzjCAOUB5ZAMhfPazqCiHWRHcMkXf21+COfflHSMMyLJ7itjyxrQ q6vooyFGUxByXv1i3MU84MNCAhgZrxGhEU/C0JrsxXw1sgnbi6WD0PJOI8hlWpNgZ8v+ ICfS46SvTRI8xVDSkxz8gib5/5n+zWYq4A/tjc8TmZzJcvqsai2O6zgao1QB4Py179zg EaDeKfaFgpbAXs+x3GIXlm5SyBixwh7CkQmF/l40qrQXg34a3SAg2RQkMFC6FEsQnStA TkyGlXw7iwdD2FD9bE0prWXRIoT/i6nlSkKfpqmOLvU+N7rXJmXG6n5I3XFskXFspDBv MiCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oZstYoY1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a27-20020a170906245b00b00978923794d4si2021741ejb.554.2023.06.12.04.34.35; Mon, 12 Jun 2023 04:34:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oZstYoY1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237324AbjFLK6H (ORCPT + 99 others); Mon, 12 Jun 2023 06:58:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236875AbjFLK5i (ORCPT ); Mon, 12 Jun 2023 06:57:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68F63E579; Mon, 12 Jun 2023 03:45:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F239862450; Mon, 12 Jun 2023 10:45:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C4EAC433EF; Mon, 12 Jun 2023 10:45:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686566741; bh=aJO98WciVZrVlZcCKv5j2euy0SAQyZ/0j96e4FBSwR4=; h=From:To:Subject:Date:In-Reply-To:References:From; b=oZstYoY1+IwPBj84Mr1zP4YDtRIv3werVGAJ2+b6CsAytp4SAJPSGU+zc4JlpYmBP i0I0UZNtMxsP37aH5z4pL54IcZZ1yygHjAAFPKpFU9x2lRdApQdrTuBFVjz/WeesZ7 C3h04CZRRWYbEH7sB4n6OEWq6BaO6VbnwTsQzY8j062H/Fz0/sgsOt4zwb1ayIP6fZ 7cG77M+iHxmvYKtuE/PcT/tB175OdEWjDJjk/JilIiutctTDWoidSZHK1hO15R4iQz 14MIjGOy5mac9sUGgBUCVdt16OnQDBpiwG4wJs6H+LwyCTwvuMy4yWgpjzdVRTkyEd 39wCWXoZtMX3Q== From: Jeff Layton To: Christian Brauner , Al Viro , Brad Warrum , Ritu Agarwal , Arnd Bergmann , Greg Kroah-Hartman , Ian Kent , "Tigran A. Aivazian" , Jeremy Kerr , Ard Biesheuvel , Namjae Jeon , Sungjong Seo , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Ruihan Li , Sebastian Reichel , Alan Stern , Suren Baghdasaryan , Wolfram Sang , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, autofs@vger.kernel.org, linux-efi@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org Subject: [PATCH v2 4/8] bfs: update ctime in addition to mtime when adding entries Date: Mon, 12 Jun 2023 06:45:20 -0400 Message-Id: <20230612104524.17058-5-jlayton@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230612104524.17058-1-jlayton@kernel.org> References: <20230612104524.17058-1-jlayton@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768496509167988702?= X-GMAIL-MSGID: =?utf-8?q?1768496509167988702?= When adding entries to a directory, POSIX generally requires that the ctime be updated alongside the mtime. Signed-off-by: Jeff Layton --- fs/bfs/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c index 040d5140e426..d2e8a2a56b05 100644 --- a/fs/bfs/dir.c +++ b/fs/bfs/dir.c @@ -294,7 +294,7 @@ static int bfs_add_entry(struct inode *dir, const struct qstr *child, int ino) dir->i_size += BFS_DIRENT_SIZE; dir->i_ctime = current_time(dir); } - dir->i_mtime = current_time(dir); + dir->i_mtime = dir->i_ctime = current_time(dir); mark_inode_dirty(dir); de->ino = cpu_to_le16((u16)ino); for (i = 0; i < BFS_NAMELEN; i++) From patchwork Mon Jun 12 10:45:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 106528 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2521827vqr; Mon, 12 Jun 2023 04:40:56 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6jDbLXlO5GcdyOWOhMPhYgsMPk2dMjv5GjHU+XywH/BErdfATOa6GVycEBpV0mzq36bYAb X-Received: by 2002:a17:90b:164c:b0:259:c73:65e6 with SMTP id il12-20020a17090b164c00b002590c7365e6mr7994308pjb.23.1686570055766; Mon, 12 Jun 2023 04:40:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686570055; cv=none; d=google.com; s=arc-20160816; b=ptNmw+f6ofnE347RXTqWqhYB1reWn54H2WCU2OSaifKcw0ybXa0p+dUi5BIy0Mgomx eP0i58FIXG1kEDIvbX5+6sOuUBWOHC5K/kec8VPL3/0/skQgixd3ey/Iil1P9jr5r0q/ e5DpZb3elCiApA505901TWJOmPHJH0b4GAq2VksZqHxMmEfnR23Cv9XBecy++es8MZb6 4oVtcjhBHxLVWirABdmDJ5yYZ29astQWG7OS+DNBfzqPYJE+Po/JmIVMBCyp3hMJaipj qTpqx+3q8j1wObcwFbStq7rPYkP2VJIbMCzQgzMrjtkO+0sAkhhJybrMwHHnhffJ0yqX 7bpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=olnisT5RNHX3U6GIJlguTirU8ljssZU5DdlBm1La5NE=; b=qm6zMzewh4TK7KvLNWG1B6ZsivsTugUTuz8v4WfHbrhxa81xGH9WAM7A9cZPaDxZXY cXq7sYLW3zVsOvHP1KToluLp0f2OiR/vi3mfv0pnuoIMI6cs3kGF0pYC3+GRwrCwWnuD rxJURl3GBb3TDWfdB0kW9H53DIt1RejdkCkVCfHjyqIEAHP0uH1QYVYzXpkIlZJBS5eL e+vYUjcyRgSz3Zr4/9yDJo9Du/z/mmoUTOvZQPtMjq8//OZk2QU6d8BIqPk87tGv3cNr jH3a8EO1eXIl4cgB7vIeOfS8VNAmmmJY+4tE3Dp6e8Am6JrmaI5JUIDLEBCV9lKv9Wu/ 3HTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Sv98hIAW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g15-20020a17090a578f00b0025653dc2881si3092092pji.23.2023.06.12.04.40.41; Mon, 12 Jun 2023 04:40:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Sv98hIAW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236889AbjFLK6L (ORCPT + 99 others); Mon, 12 Jun 2023 06:58:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236903AbjFLK5j (ORCPT ); Mon, 12 Jun 2023 06:57:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EA3EE57D; Mon, 12 Jun 2023 03:45:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 23BE962418; Mon, 12 Jun 2023 10:45:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5433C433D2; Mon, 12 Jun 2023 10:45:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686566744; bh=9ZN85s2F3/oEy5pkv6yI4Tv5XU9EfGqK4A7t1kaGRdY=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Sv98hIAW85F4HBftzDcqOyvM/R3EukSSckezqktp1nVmTUG16TJv0cTmZ7SZqrheb d4IypswNbwiWEDy/oOarsubCsCA3ax3zQ3H9iLKzVTYSmCKzyXYNS/5sahPEso7cuj 2VuMf+UQPbv18bzClnCD63+Vm3dpGSjDADvHTxD0cbM7bauFma36sYcKjJBaAT7/JB bPGjUyszcMJqtojtlNPoeTxFbjM4KhWRNKx0efDE8UgBAAQbbgtog1Y5rePrnTS841 IkhITd1epcN0mh1bQ6Jk4cLEMA1nMm2CbuaTOSCBgqEts5gyguTJNTvyuSzqq9k91F PZ1odKwWKFr2A== From: Jeff Layton To: Christian Brauner , Al Viro , Brad Warrum , Ritu Agarwal , Arnd Bergmann , Greg Kroah-Hartman , Ian Kent , "Tigran A. Aivazian" , Jeremy Kerr , Ard Biesheuvel , Namjae Jeon , Sungjong Seo , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Ruihan Li , Sebastian Reichel , Alan Stern , Suren Baghdasaryan , Wolfram Sang , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, autofs@vger.kernel.org, linux-efi@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org Subject: [PATCH v2 5/8] efivarfs: update ctime when mtime changes on a write Date: Mon, 12 Jun 2023 06:45:21 -0400 Message-Id: <20230612104524.17058-6-jlayton@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230612104524.17058-1-jlayton@kernel.org> References: <20230612104524.17058-1-jlayton@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768496883159184359?= X-GMAIL-MSGID: =?utf-8?q?1768496883159184359?= POSIX says: "Upon successful completion, where nbyte is greater than 0, write() shall mark for update the last data modification and last file status change timestamps of the file..." Add the missing ctime update. Signed-off-by: Jeff Layton --- fs/efivarfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/efivarfs/file.c b/fs/efivarfs/file.c index d57ee15874f9..375576111dc3 100644 --- a/fs/efivarfs/file.c +++ b/fs/efivarfs/file.c @@ -51,7 +51,7 @@ static ssize_t efivarfs_file_write(struct file *file, } else { inode_lock(inode); i_size_write(inode, datasize + sizeof(attributes)); - inode->i_mtime = current_time(inode); + inode->i_mtime = inode->i_ctime = current_time(inode); inode_unlock(inode); } From patchwork Mon Jun 12 10:45:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 106511 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2519064vqr; Mon, 12 Jun 2023 04:35:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4vOsrw1CPFdxSgU4W7XAiQdT1MWQJ0JPWoDun1SJb7OkuLB3CMbfWv+8i1jLQ8okU0HIBF X-Received: by 2002:a17:907:60cd:b0:982:26c4:e4b0 with SMTP id hv13-20020a17090760cd00b0098226c4e4b0mr613382ejc.6.1686569734638; Mon, 12 Jun 2023 04:35:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686569734; cv=none; d=google.com; s=arc-20160816; b=Vv4cVPOBQ/VpOn8+LSJzjIXpCDSsNe75BP6Eld51znvEN5RDCAGyK1Hm7tMoKQQJFH foCoTb/uxHRHhjpXJqxpgIk7xOLG8XnbQVBuyK1P0u9ghL7fe1AC598NvATdY5F1Yynt JnPrIhwxUk8d3pbKskg8vH3JaS/fdaJ42GzheVzE6IhZlXtpYom+Kr7fOJiMBqIXq+8C qfKC2dnZ9LQV3xBWdg23d5IZ7PNW2CVEEWb8PP4TLe9c5n6EXbb/Mn40OxcKv2E+AmFr oPgJ/Z0r9VizGQDn+X5Hvg85L8MMNONfMBdREDYiYc78tQ6nQeASFTQvBLRmYI7Smy5h 4TGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=gPRIbnOALIb34gsRS7QluPkFrWq0RUT8ihjbsG9WAy8=; b=HaoIFUPS0INIAkvemE6wWJzioHkTTz5Z4cpfzaquqRCYtQQ6UNzBO/0qn0s0S09P2F sDQnPcrRQZ+FKfUdgfzvaRG37d5TbO2Ge78oIBr5paEnEix6Yh37ZsiqFUupH+37doeG CQQkSb91zicdaOaeIRvPc7QheDjsqpj9RN5jS7E5Qtx6AR1/s5UgUJIIX4lQ0qzrAdOg lm2HRoRmLeBunO2tq6xke/mvHzMmCrJFZ0FGH0DlIytgrTax3g1vf/ZmbA9wsyKmlSBL 4a6vQFMhweitbSfcGtDKnW/MC625qe/yOVqY8/u+rbvq26uUJzP1BjFexiPPnBGH7Z7g DRUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oz4WHLbO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p9-20020a170906784900b009764ebf5fb7si4900321ejm.665.2023.06.12.04.35.05; Mon, 12 Jun 2023 04:35:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oz4WHLbO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236935AbjFLK6Y (ORCPT + 99 others); Mon, 12 Jun 2023 06:58:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237104AbjFLK5q (ORCPT ); Mon, 12 Jun 2023 06:57:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C820B127C4; Mon, 12 Jun 2023 03:45:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4D3C562418; Mon, 12 Jun 2023 10:45:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDF9EC4339B; Mon, 12 Jun 2023 10:45:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686566747; bh=KX7S7KoBIOHdIFvOtciMzqUF0ZVLgZ3kkDz1+nuzm5g=; h=From:To:Subject:Date:In-Reply-To:References:From; b=oz4WHLbO2jQN18Ove6Yj01Q8O4ys1wPwCmlNiLDNkmgWHI4GseN0zZLHEM92GYoGu boxFJi841L5bbyrUSD3RGup9DgX4l4qriaT0pGf+w6tErLMj+72DpzQ0vSvdMBFlbu KXSDAZv890DWx+cavMPVeGecLZIAIS0tENSJ08AMARyzUalS9uU1veHX9UzzI6FQoK GQ5IcM6JEkKLV02OZ7r4bZ+rjgcKQTK9aoJXpooAwIGA1rf40OBNSpEW02hvFu/dDK 7SNhtVCZvEX/ybEeXtinwolY6QwBsyPmrCP8B9kIeImVk/kMoxXe8UPrCWqnyVaGqr GlER8Exgmr4Sg== From: Jeff Layton To: Christian Brauner , Al Viro , Brad Warrum , Ritu Agarwal , Arnd Bergmann , Greg Kroah-Hartman , Ian Kent , "Tigran A. Aivazian" , Jeremy Kerr , Ard Biesheuvel , Namjae Jeon , Sungjong Seo , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Ruihan Li , Sebastian Reichel , Alan Stern , Suren Baghdasaryan , Wolfram Sang , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, autofs@vger.kernel.org, linux-efi@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org Subject: [PATCH v2 6/8] exfat: ensure that ctime is updated whenever the mtime is Date: Mon, 12 Jun 2023 06:45:22 -0400 Message-Id: <20230612104524.17058-7-jlayton@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230612104524.17058-1-jlayton@kernel.org> References: <20230612104524.17058-1-jlayton@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768496545887241963?= X-GMAIL-MSGID: =?utf-8?q?1768496545887241963?= When removing entries from a directory, the ctime must also be updated alongside the mtime. Signed-off-by: Jeff Layton --- fs/exfat/namei.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/exfat/namei.c b/fs/exfat/namei.c index e0ff9d156f6f..d9b46fa36bff 100644 --- a/fs/exfat/namei.c +++ b/fs/exfat/namei.c @@ -817,7 +817,7 @@ static int exfat_unlink(struct inode *dir, struct dentry *dentry) ei->dir.dir = DIR_DELETED; inode_inc_iversion(dir); - dir->i_mtime = dir->i_atime = current_time(dir); + dir->i_mtime = dir->i_atime = dir->i_ctime = current_time(dir); exfat_truncate_atime(&dir->i_atime); if (IS_DIRSYNC(dir)) exfat_sync_inode(dir); @@ -825,7 +825,7 @@ static int exfat_unlink(struct inode *dir, struct dentry *dentry) mark_inode_dirty(dir); clear_nlink(inode); - inode->i_mtime = inode->i_atime = current_time(inode); + inode->i_mtime = inode->i_atime = inode->i_ctime = current_time(inode); exfat_truncate_atime(&inode->i_atime); exfat_unhash_inode(inode); exfat_d_version_set(dentry, inode_query_iversion(dir)); @@ -979,7 +979,7 @@ static int exfat_rmdir(struct inode *dir, struct dentry *dentry) ei->dir.dir = DIR_DELETED; inode_inc_iversion(dir); - dir->i_mtime = dir->i_atime = current_time(dir); + dir->i_mtime = dir->i_atime = dir->i_ctime = current_time(dir); exfat_truncate_atime(&dir->i_atime); if (IS_DIRSYNC(dir)) exfat_sync_inode(dir); @@ -988,7 +988,7 @@ static int exfat_rmdir(struct inode *dir, struct dentry *dentry) drop_nlink(dir); clear_nlink(inode); - inode->i_mtime = inode->i_atime = current_time(inode); + inode->i_mtime = inode->i_atime = inode->i_ctime = current_time(inode); exfat_truncate_atime(&inode->i_atime); exfat_unhash_inode(inode); exfat_d_version_set(dentry, inode_query_iversion(dir)); From patchwork Mon Jun 12 10:45:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 106522 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2520882vqr; Mon, 12 Jun 2023 04:39:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ695ENyz5zcbWuQdA+hscPi2bOp81DXM/sA/L6/gSgeJvgzivFhgg1N4LWr7JxbBaFFVADb X-Received: by 2002:a2e:9819:0:b0:2b3:31c1:c747 with SMTP id a25-20020a2e9819000000b002b331c1c747mr106261ljj.24.1686569948620; Mon, 12 Jun 2023 04:39:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686569948; cv=none; d=google.com; s=arc-20160816; b=sPwYoEYzPhUZ1IJhZ0GX7VyxSTeFKYR/NZ+fttyWPJQKi6DDIZrdwKcs+/oeKMx2Iq XKeuX/NP1JGUfObtXxDPfc0UzjY8J+1TdC/TPhNnMilT9sRTjo0SBE46514vBA3VYBN0 NxXNVhu3nUQIZO4azB6UA9FD/PI6bs8SVhXWj0iGONRQPR+8Kh2u4bkgPeLZKEPV8rWU aeGMeMpQKRI5T70dxS294rcqkIErDk/GEIoS8ZTbkfzRT0Kg/VOoSemS8Rigbf+jBr+f lOm8gLlgC1EdUU955dnVRPbEKOWpB7g4pgE3gsv5S2bflE6ypenXMyRGqMH23pytWJEL axBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=JuNV+CQwepKGIJeWA8a776g2taozDvHNKotyENNnh2c=; b=Zb57q4FKstVCIRFi5iSDBmlRMxiBVGrs4U4bexWmeYM99I/X3zWZsto7HFAXu8JVRd kDgTvm99+e7uZbug2pvBSaAXa+uwo0mfQR4MlPY+rNxWcikiQXfEckIJUQ2PTJlanqzV GP/oUYibsHajMNJpTkaK6DXmmrDnyZPN88qI2gXWY8SHbduSUo217Gjg5K7VxwoemQZl GdKtTJt4nXxBi08/8B/D+wbZtl5TN0gFCH0FkBuzQbTAQhy3s0LOApOVdoNqH9iCe6Bu FhSn0INg8pxqwlUpVZujhMmv18IZrzCMCqgFFWdQsprUm7fIqc44D0iSwxNvK8y/rmHr tm4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LmmZkhNy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r11-20020aa7cfcb000000b0051456f61f7dsi5737888edy.457.2023.06.12.04.38.41; Mon, 12 Jun 2023 04:39:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LmmZkhNy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236651AbjFLK7G (ORCPT + 99 others); Mon, 12 Jun 2023 06:59:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236646AbjFLK5u (ORCPT ); Mon, 12 Jun 2023 06:57:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69FD759D1; Mon, 12 Jun 2023 03:45:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7A6D862451; Mon, 12 Jun 2023 10:45:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03C7EC4339C; Mon, 12 Jun 2023 10:45:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686566750; bh=wKObH6RqfDSKn8NJ5P1Az5k/GApq/hL/pKFLfNG4hQ4=; h=From:To:Subject:Date:In-Reply-To:References:From; b=LmmZkhNyD5zDhN30iflITZjik39GhWUe9Zp2752cKSdJF2l1rVLjseSvmT8FZAnUW Tt+Rk6fBUYPjKCd4SxlgSiLiIF8+vtYo5Sb5QtZpNg3apDbKEGO4QI+cdJ3s+yXJw9 Bi8/f7AqA8ESRTQKcBuEh6nTtDgtKi4wFVDK8wQLx0Zo25LDolbf5jZMc1ZTwyb7pe 0dKP/F7COKkhUtTASLHTMB7PzYC874EBAcrWbqIGcZW5hdEJiHjrXkVqvdBBmZWCPM ITZ9AnpeSKjuXFRWezYx5SYvEEwPZRK+EnpN6qR/ONpj6ISjGT7cQvL7MV0db9dJMg f0/ADoTJDBpSw== From: Jeff Layton To: Christian Brauner , Al Viro , Brad Warrum , Ritu Agarwal , Arnd Bergmann , Greg Kroah-Hartman , Ian Kent , "Tigran A. Aivazian" , Jeremy Kerr , Ard Biesheuvel , Namjae Jeon , Sungjong Seo , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Ruihan Li , Sebastian Reichel , Alan Stern , Suren Baghdasaryan , Wolfram Sang , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, autofs@vger.kernel.org, linux-efi@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org Subject: [PATCH v2 7/8] apparmor: update ctime whenever the mtime changes on an inode Date: Mon, 12 Jun 2023 06:45:23 -0400 Message-Id: <20230612104524.17058-8-jlayton@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230612104524.17058-1-jlayton@kernel.org> References: <20230612104524.17058-1-jlayton@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768496769977709282?= X-GMAIL-MSGID: =?utf-8?q?1768496769977709282?= In general, when updating the mtime on an inode, one must also update the ctime. Add the missing ctime updates. Signed-off-by: Jeff Layton --- security/apparmor/apparmorfs.c | 7 +++++-- security/apparmor/policy_unpack.c | 11 +++++++---- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c index db7a51acf9db..c06053718836 100644 --- a/security/apparmor/apparmorfs.c +++ b/security/apparmor/apparmorfs.c @@ -1554,8 +1554,11 @@ void __aafs_profile_migrate_dents(struct aa_profile *old, for (i = 0; i < AAFS_PROF_SIZEOF; i++) { new->dents[i] = old->dents[i]; - if (new->dents[i]) - new->dents[i]->d_inode->i_mtime = current_time(new->dents[i]->d_inode); + if (new->dents[i]) { + struct inode *inode = d_inode(new->dents[i]); + + inode->i_mtime = inode->i_ctime = current_time(inode); + } old->dents[i] = NULL; } } diff --git a/security/apparmor/policy_unpack.c b/security/apparmor/policy_unpack.c index cf2ceec40b28..48a97c1800b9 100644 --- a/security/apparmor/policy_unpack.c +++ b/security/apparmor/policy_unpack.c @@ -86,10 +86,13 @@ void __aa_loaddata_update(struct aa_loaddata *data, long revision) data->revision = revision; if ((data->dents[AAFS_LOADDATA_REVISION])) { - d_inode(data->dents[AAFS_LOADDATA_DIR])->i_mtime = - current_time(d_inode(data->dents[AAFS_LOADDATA_DIR])); - d_inode(data->dents[AAFS_LOADDATA_REVISION])->i_mtime = - current_time(d_inode(data->dents[AAFS_LOADDATA_REVISION])); + struct inode *inode; + + inode = d_inode(data->dents[AAFS_LOADDATA_DIR]); + inode->i_mtime = inode->i_ctime = current_time(inode); + + inode = d_inode(data->dents[AAFS_LOADDATA_REVISION]); + inode->i_mtime = inode->i_ctime = current_time(inode); } } From patchwork Mon Jun 12 10:45:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 106501 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2507012vqr; Mon, 12 Jun 2023 04:13:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4UJz4gsrwDuWMHNltdT3soduRT4yuzWZYaXcIYILpk7khuPB6R13hEoOjQu3bbHOAxEVRz X-Received: by 2002:a05:6a00:807:b0:656:e7a2:5362 with SMTP id m7-20020a056a00080700b00656e7a25362mr10883472pfk.16.1686568430380; Mon, 12 Jun 2023 04:13:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686568430; cv=none; d=google.com; s=arc-20160816; b=vi9kHa7LBc+SWD5tIZrDMBdX82kLJBfSeFibQcFU40AEul2xZrGW+WmuB/r1Ohkopd GmLMSgcQaUhb8Ce+GZss+GqUwWYioWtkVIO0G4veamW8sQNws8oxpIQGt5dVv2fj7dn7 Vc5BSsLJV4r/0qYK7CkE31dFnK7/2cdyCnjBYfQ5DDGJ7CN4XwoHFWBosrxyclWTNonZ k7+ldCHdnZwfTjEVooplN0ud9kzEm02mVB6eSoy+xWAYuMKd3e7TacBKZswXj7YmKTcm xNL6zMAYgW2plyqgEDdNX14xJdeKhrRozbvjHihC2OOr5l09jhalkfrP3Z7QFzp9vSmt O8jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=mfgvF3USLrLM58hEQTthmuf1ML45ry+tAJXJCUKDyMg=; b=kQoBHY79IG++Zy14lXSFV097URjiBRZRrvEmR07BJTLUPLRnTcZIC32b2E8rjCjm+r 1csfDfI44qxvsGJHTvZkfUsXQ9hXyJhBTr+GlWM1j6Hw7vyXes3IdWaGAn7N/LAfYUt7 ygKCB5fy5xk40FC8d0mJWcpLaHc4dn1D4e6dwdR1qzHDWJQdbsMjYgyk07ze1LKf56NA TD94O+OvAkq++JHBZWVnkEi4r3OwtUZJBBqZsMUkkK1SzwoRBT6QGZXYYwUjEtRtgffk IGhL5P24kaTr1JNGByx/pyfHzoIcrPB3HsRlU7RB1epi8dQuhQz9cxZl0gVAN17CRhjC ugDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=q+YkQNa3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n6-20020aa79846000000b006629fe7edffsi6556163pfq.315.2023.06.12.04.13.37; Mon, 12 Jun 2023 04:13:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=q+YkQNa3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236825AbjFLK7L (ORCPT + 99 others); Mon, 12 Jun 2023 06:59:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236256AbjFLK5w (ORCPT ); Mon, 12 Jun 2023 06:57:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 186026EAB; Mon, 12 Jun 2023 03:45:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A1A6D62451; Mon, 12 Jun 2023 10:45:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E347C433D2; Mon, 12 Jun 2023 10:45:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686566754; bh=n83nlEjKdfIOBmYidDyhQMkFJfDZwR7ta+gYJd+TVCQ=; h=From:To:Subject:Date:In-Reply-To:References:From; b=q+YkQNa328pMVFsA2bRAmz5UMjgF+DnvTPqv88BK4VXVNKMksbd7Idlt4Ynx5ayzp 0mpe940TUN7nIlv6rm8JohB1cnuug/RTPS8ZSK+Gqpfo935WqDt6AQW29cfrzEWyI0 hntdqRNzxTdjhNixoS4zPOB7ooqWzN4tqKdIHQzS3XjVL+czdUWoPRcWhg6kxtbJ6I Cr9pv+DlyR4FK0jjAjwunzAxUmuLz2ahMFQjJr+odeexqZ9ZZh/jTAkvwuE5rDARGz WM34MHMRkkLBu8ZnBc5JXo2/ZX2kgl5ccHEvr2qcjhgn1OBiH3soWsvGTwYWhRxGiM bCPjv8pHoyx6w== From: Jeff Layton To: Christian Brauner , Al Viro , Brad Warrum , Ritu Agarwal , Arnd Bergmann , Greg Kroah-Hartman , Ian Kent , "Tigran A. Aivazian" , Jeremy Kerr , Ard Biesheuvel , Namjae Jeon , Sungjong Seo , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Ruihan Li , Sebastian Reichel , Alan Stern , Suren Baghdasaryan , Wolfram Sang , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, autofs@vger.kernel.org, linux-efi@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org Subject: [PATCH v2 8/8] cifs: update the ctime on a partial page write Date: Mon, 12 Jun 2023 06:45:24 -0400 Message-Id: <20230612104524.17058-9-jlayton@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230612104524.17058-1-jlayton@kernel.org> References: <20230612104524.17058-1-jlayton@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768495178247769580?= X-GMAIL-MSGID: =?utf-8?q?1768495178247769580?= POSIX says: "Upon successful completion, where nbyte is greater than 0, write() shall mark for update the last data modification and last file status change timestamps of the file..." Add the missing ctime update. Signed-off-by: Jeff Layton --- fs/smb/client/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/smb/client/file.c b/fs/smb/client/file.c index df88b8c04d03..a00038a326cf 100644 --- a/fs/smb/client/file.c +++ b/fs/smb/client/file.c @@ -2596,7 +2596,7 @@ static int cifs_partialpagewrite(struct page *page, unsigned from, unsigned to) write_data, to - from, &offset); cifsFileInfo_put(open_file); /* Does mm or vfs already set times? */ - inode->i_atime = inode->i_mtime = current_time(inode); + inode->i_atime = inode->i_mtime = inode->i_ctime = current_time(inode); if ((bytes_written > 0) && (offset)) rc = 0; else if (bytes_written < 0)