From patchwork Mon Jun 12 09:22:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 106361 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2460177vqr; Mon, 12 Jun 2023 02:33:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7cszdZJn3SVSx3BKY+g+yN+39lpAxJ0akA7VMEz62SAgLgm4CYSE++4Y7xM3jQvwUklYuu X-Received: by 2002:a05:6808:23c8:b0:39c:9173:31f1 with SMTP id bq8-20020a05680823c800b0039c917331f1mr4657897oib.28.1686562392944; Mon, 12 Jun 2023 02:33:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686562392; cv=none; d=google.com; s=arc-20160816; b=LfAVnfYlbaWVwnrnVwSqPnCzt3dZQLraqGw/Q/J6Qtlg8AU4AJUYUZFkiBtpiXErDO a0kwbiFrNoRe0rnZDqtjyi0XnKHzy0Uwu2hRh6rUXwVMFlX1TgFUzukbLpgPqmGWoBcX ZeOLK/SGViDnAI3QJ3UbhH/YTKEWhTPL9LxqKG2tGv7SIDeTrba3Gt0XFxQns2GHx1M1 nk8KATvuXfVyBo10mV4EHSEfk1nlpLJi1niwY9N01AjuSc63u98FuvT83THj3Iw0TEsD nMfkY/RCOB5GYIdCOFakftWUY/OMsoo3y75i1GBgw9PLKHXYg57cF84F3ADVUcvGTl6W smhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=aokZ02DTWb9itSjNmX3GX1bnlGBgRvBPpzBUwT1r8Ks=; b=SE+awTbCycu2Nc6EU2SqjGcv7BwnsFJuCa5lzA8kHnziC1yIAJRVSnkG5K5PaWt4mc XNME8hLa3ua/eNfSIJhHcyUHa2gkta/xuyv9a5MDWUwnPpbwe96XxbX8zjsla74Lt5lF HtXawAW4TAoF/VKpwEaT9IVco5G8e3Vr0x78j0V0QZkA1+DinOLPwg3tw8+ufBKsYnjU DKmbyQ1DEQ8S6UQDcKNTuOS2tmMEfEHXoTE95GrrLF5i6tG5bMnAXzIRKMo0xDGEo4Bv g4ZMa5B9iGWS+Hw2/iGi+BzX0D81BDFyVj8TNMiKKv7pqPLRbQ0E92aScnhWQ/FRqlys VTFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zgaXR068; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y5-20020a17090a86c500b00253695cadcasi8443544pjv.180.2023.06.12.02.32.59; Mon, 12 Jun 2023 02:33:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zgaXR068; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234767AbjFLJ3F (ORCPT + 99 others); Mon, 12 Jun 2023 05:29:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229942AbjFLJ2Z (ORCPT ); Mon, 12 Jun 2023 05:28:25 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BAE54C17 for ; Mon, 12 Jun 2023 02:22:52 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2b203360d93so47330091fa.3 for ; Mon, 12 Jun 2023 02:22:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686561771; x=1689153771; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aokZ02DTWb9itSjNmX3GX1bnlGBgRvBPpzBUwT1r8Ks=; b=zgaXR068y2KvRcu+CefSXblQauZN/5694hY3v3A7mOv8L2XDoiACIFYh0En2bjFWO7 elrV6OhqE7pubIBMZnNEpe3US8kk7cx7qjr/U3dOsamyYot1184AjFRQr74Nu3xec5pp 4EmEIYb+GCt1S83vlEWaJor7gMzYeFdsu50yEG6n0Blk2gFifRyCFnPAdDUNNCU4CrJl NES3HC0wKGdRVeaa7i557J1WaXaISlJNWJLOO8+jV5VGT0Uo2gVx12TYt9qDZsKLF3jJ nBLzxypmxW1pNtaab38uryMBiz8WRkg0DEA56Bi4B+Ei1fn0Vewaymmg3YWbwf1v7unA ymcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686561771; x=1689153771; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aokZ02DTWb9itSjNmX3GX1bnlGBgRvBPpzBUwT1r8Ks=; b=jutd9qkejQROF84ktZIUifOdvqtEE+cXhnTp7dzRt8fH862C9fbS8GhSTdTUot/e2W ufdDusOseyyTkNcdNyVi4oPwNP+9m6Etcaj9WApI4jUCTRvlRrdH3TgARuEe60uaylf4 IiZEXvFG355RgR8KfDcYFTx6wMpzrYffkuTUonxd7ro1ReGj2kmMuGHuyoFvPVMj84i3 69dt2EQQF5HP2X/JwtiBiBYCL62i0fziViNXfNdfPN2pNOStTcPL6UIHRKkE6/pdbbcA mMFO4hDNKj5CnjBxfptBCYSxA77S+CJBs06KXHYDP7DyyMlHuhPkEoVwXAb7gNsQ+PlA 861Q== X-Gm-Message-State: AC+VfDx5dR/eoAgHkdqes3WYqHUuaITvXmG/ihgzCEscLIvXpAtxJ0Gq gxNvopK4uDys8VesfsTTzfnp+w== X-Received: by 2002:a05:651c:22a:b0:2af:2441:f709 with SMTP id z10-20020a05651c022a00b002af2441f709mr2312656ljn.29.1686561770934; Mon, 12 Jun 2023 02:22:50 -0700 (PDT) Received: from [192.168.1.101] (abyj190.neoplus.adsl.tpnet.pl. [83.9.29.190]) by smtp.gmail.com with ESMTPSA id o20-20020a2e7314000000b002adc2fe3fc8sm1681722ljc.4.2023.06.12.02.22.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 02:22:50 -0700 (PDT) From: Konrad Dybcio Date: Mon, 12 Jun 2023 11:22:47 +0200 Subject: [PATCH 1/2] clk: qcom: rcg2: Introduce read-only RCG2 ops MIME-Version: 1.0 Message-Id: <20230612-topic-rcg2_ro-v1-1-e7d824aeb628@linaro.org> References: <20230612-topic-rcg2_ro-v1-0-e7d824aeb628@linaro.org> In-Reply-To: <20230612-topic-rcg2_ro-v1-0-e7d824aeb628@linaro.org> To: Bjorn Andersson , Andy Gross , Michael Turquette , Stephen Boyd Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Stephan Gerhold , Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1686561768; l=1865; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=3gIA9vzv7N0fpwHj2dbt5ZFR2hwXZW2370PjU3vkRU0=; b=/QuvsvHHTCcXI2H4Y3Vl48qEwTbc+OqDpUK9QFPMGjfNXa4lqdxBVWHNLyqKbv6mkQe9Xoc0t SRRPfn5u4jmAHeAyOv/Oz3gazVUBpjYJv2DCh5qsADr/ZIRk9wy3zIF X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768488847511687949?= X-GMAIL-MSGID: =?utf-8?q?1768488847511687949?= Some clocks are physically part of a clock controller block (e.g. GCC), but are under no circumstances supposed to be touched from HLOS/APSS, as another subsystem manages them, and trying to alter its configuration may (and likely will) wreck total havoc over whatever the clock is attached to. Add read-only ops for RCG clocks. This allows us to peak at the rates (and other configuration parameters) of such clocks without the risk of messing up half of the SoC due to an erroneous CCF call. Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/clk-rcg.h | 1 + drivers/clk/qcom/clk-rcg2.c | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/drivers/clk/qcom/clk-rcg.h b/drivers/clk/qcom/clk-rcg.h index e6d84c8c7989..4b4ff156539f 100644 --- a/drivers/clk/qcom/clk-rcg.h +++ b/drivers/clk/qcom/clk-rcg.h @@ -170,6 +170,7 @@ struct clk_rcg2_gfx3d { extern const struct clk_ops clk_rcg2_ops; extern const struct clk_ops clk_rcg2_floor_ops; extern const struct clk_ops clk_rcg2_mux_closest_ops; +extern const struct clk_ops clk_rcg2_ro_ops; extern const struct clk_ops clk_edp_pixel_ops; extern const struct clk_ops clk_byte_ops; extern const struct clk_ops clk_byte2_ops; diff --git a/drivers/clk/qcom/clk-rcg2.c b/drivers/clk/qcom/clk-rcg2.c index e22baf3a7112..71de1cd8d45b 100644 --- a/drivers/clk/qcom/clk-rcg2.c +++ b/drivers/clk/qcom/clk-rcg2.c @@ -518,6 +518,14 @@ const struct clk_ops clk_rcg2_mux_closest_ops = { }; EXPORT_SYMBOL_GPL(clk_rcg2_mux_closest_ops); +const struct clk_ops clk_rcg2_ro_ops = { + .is_enabled = clk_rcg2_is_enabled, + .get_parent = clk_rcg2_get_parent, + .recalc_rate = clk_rcg2_recalc_rate, + .get_duty_cycle = clk_rcg2_get_duty_cycle, +}; +EXPORT_SYMBOL_GPL(clk_rcg2_ro_ops); + struct frac_entry { int num; int den; From patchwork Mon Jun 12 09:22:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 106362 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2460219vqr; Mon, 12 Jun 2023 02:33:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5AcsxgcRJXPyRllO3C9OuwJw3AX7xZMLapK1WT4DQ63d3zS+/e20/fRFqySiOCfDbylLfl X-Received: by 2002:a17:90b:4c49:b0:256:23f:abc5 with SMTP id np9-20020a17090b4c4900b00256023fabc5mr7027641pjb.10.1686562399685; Mon, 12 Jun 2023 02:33:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686562399; cv=none; d=google.com; s=arc-20160816; b=BjxmJMV0xt0tNzJ4kON/mKj1C9GoZej/YtXWF7qMoKHBmeXgbzLginNZAAwqch39+b XEOCtkUgoltrWI97XMV7Mxsj+qbLTbabSpC9yEr5VOgvh5mfJB5nbluEJ/JvUGpmeyTw X+w4ELu7LUJ7Z8iJIJrBiR5sCvRNi7NtEhV8s1oWWsWn1XMRya4NT722cgYT8Omk/N8B QgeZqikqCzys3IDqSTBrCIypD+jOfkw/PPVZjSTK53iHYMOLSc2ypBihBVnoF1JXpOUQ RXf6u1vvg9vaKgunoytuVKKCNnAi1YuJiX0FpDV9PgNEb2H42DSLDJTh533hHCiMKc53 2ITQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=wF7kJNEVNClZhr22GJ39Mf3qOuL6Q0VFjYnT8ReRfhE=; b=kzbAdaUWA4lgKp8xppJPkaNoqab+fPYm5hXAsoBjL0gDbCMh2rc8sLgBliYeKlYcyk hWMVJnh6iPZrVbscobRy0P8XhoBQvw6tJoU7ZvsR8IT3XDTlCQozGBTsnz7yfLficlCl qe2uuh9DywWl6mVMTMlD5bI9CMgAzDjv8ShggOm83ojKr0+ASOXxuHStBCXApBD+AKUH YFSQpBewhcKlDZMufW42AmQIaNe4ffPjwEjHvMuPCCZuai3zMH02eHNgjZQ0DIiQvaXd NvnuzxNT1jzIoXRwpuYyhM/HBOZ4JX8/c6m1iGvdrj0Sr3IUvGE+j5p26p0Zse7cSFAn p0fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TQFyRQ9d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bk13-20020a17090b080d00b0025bdfe1b9e0si1618794pjb.75.2023.06.12.02.33.02; Mon, 12 Jun 2023 02:33:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TQFyRQ9d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231874AbjFLJ3L (ORCPT + 99 others); Mon, 12 Jun 2023 05:29:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230497AbjFLJ20 (ORCPT ); Mon, 12 Jun 2023 05:28:26 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 966AE4C1A for ; Mon, 12 Jun 2023 02:22:53 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2b1c910ee19so46819981fa.3 for ; Mon, 12 Jun 2023 02:22:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686561772; x=1689153772; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wF7kJNEVNClZhr22GJ39Mf3qOuL6Q0VFjYnT8ReRfhE=; b=TQFyRQ9dCAAjzWOD1qlKjLIaGuoxP8JtMlaRrMdhIDuLRK4jGXpvd9VWW5vx2qTjIS IgZLOVYLfGkuntkIxDONGBdGyukhQOKTQmYYsLh6KJvYOtOMEaC0oDUQ4TeQllmB9DSM 1TzEhCcbitB1S1jqEYzXDhZK370PA2R3KJV++NAO93DIWdcAszS+iaCEEAxw1tcDm7H7 mJ3naSjr4iUs1S/w7yidyLrpmVQyer7mjnZsSGAneL767HuG0AOWbx6jTgPk1QCfDYUv NV/wwsgN7wXiJhI9YdNMImRO+Q7nHpXyWashbxmUNzs1qz2q4TAHosQq1BUxtgizWvKX HqVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686561772; x=1689153772; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wF7kJNEVNClZhr22GJ39Mf3qOuL6Q0VFjYnT8ReRfhE=; b=Lj+sfg31RUoe6WTAhMXKPtYysODBw+XfMpkxo7cdJfE8hcgK/BOES7M2Pc+IS2cVJr 3d41S6MbA7bq3HueDj+vkRjV33wC+LdDc9cwP1r3KoWmKyf9n4IKpes1KPJogR4+BCyt jv6iXCzJ0FN1jybPd4Ump+ysPF5Sj/qyfwpnY2VsKfKTy5TMxiMJ/fPj211sppO3EWAM e8aDZBY0kdNVn85GzwN1W4TWmqVWnqw4Bya0l9FFNIO1jp1UhL4w8Q/xKqVJbvy6Y8ij 3C6+UggzgX03xDpZkfe/wkV+tw8gfYditK5j+5qwDEOq5iEnirJnhM3cEc5LlGr/tbYY UMsw== X-Gm-Message-State: AC+VfDw2IDT/dJ8c34NhGBCh9MgFfhsBiBjkgen8+1MfKu79s3NmtLwy JlnwOsHXV/tOTRuKXVXBm8+yiw== X-Received: by 2002:a2e:8719:0:b0:2b1:e65a:a1d3 with SMTP id m25-20020a2e8719000000b002b1e65aa1d3mr2200583lji.40.1686561771994; Mon, 12 Jun 2023 02:22:51 -0700 (PDT) Received: from [192.168.1.101] (abyj190.neoplus.adsl.tpnet.pl. [83.9.29.190]) by smtp.gmail.com with ESMTPSA id o20-20020a2e7314000000b002adc2fe3fc8sm1681722ljc.4.2023.06.12.02.22.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 02:22:51 -0700 (PDT) From: Konrad Dybcio Date: Mon, 12 Jun 2023 11:22:48 +0200 Subject: [PATCH 2/2] clk: qcom: gcc-msm8996: Use read-only RCG ops for RPM bus clocks MIME-Version: 1.0 Message-Id: <20230612-topic-rcg2_ro-v1-2-e7d824aeb628@linaro.org> References: <20230612-topic-rcg2_ro-v1-0-e7d824aeb628@linaro.org> In-Reply-To: <20230612-topic-rcg2_ro-v1-0-e7d824aeb628@linaro.org> To: Bjorn Andersson , Andy Gross , Michael Turquette , Stephen Boyd Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Stephan Gerhold , Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1686561768; l=1415; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=ciUM7VVqmyaHUus+1v7jieLBfQZSXfrd5Ukd9qFyQXo=; b=34ZFn6hCgCgNYS/VVRxB/dsQm8stj9nIrROWY7b0B1M6RqHvB/A+SpcLbyv4XA5qQ4vbLebmW giUvvTAi9p0BcxEhM4uBTY9UCEv86kBgUMnYvr0BMrglAgg99c9oOtL X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768488854500435525?= X-GMAIL-MSGID: =?utf-8?q?1768488854500435525?= The config/periph/system NoC clocks are wholly controlled by the RPM firmware and Linux should never ever alter their configuration. Switch them over to read-only ops to avoid that. Fixes: b1e010c0730a ("clk: qcom: Add MSM8996 Global Clock Control (GCC) driver") Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/gcc-msm8996.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/gcc-msm8996.c b/drivers/clk/qcom/gcc-msm8996.c index 5e44d1bcca9e..588e3b67657a 100644 --- a/drivers/clk/qcom/gcc-msm8996.c +++ b/drivers/clk/qcom/gcc-msm8996.c @@ -264,7 +264,7 @@ static struct clk_rcg2 system_noc_clk_src = { .name = "system_noc_clk_src", .parent_data = gcc_xo_gpll0_gpll0_early_div, .num_parents = ARRAY_SIZE(gcc_xo_gpll0_gpll0_early_div), - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_ro_ops, }, }; @@ -284,7 +284,7 @@ static struct clk_rcg2 config_noc_clk_src = { .name = "config_noc_clk_src", .parent_data = gcc_xo_gpll0, .num_parents = ARRAY_SIZE(gcc_xo_gpll0), - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_ro_ops, }, }; @@ -306,7 +306,7 @@ static struct clk_rcg2 periph_noc_clk_src = { .name = "periph_noc_clk_src", .parent_data = gcc_xo_gpll0, .num_parents = ARRAY_SIZE(gcc_xo_gpll0), - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_ro_ops, }, };