From patchwork Fri Jun 9 19:28:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Indu Bhagat X-Patchwork-Id: 105785 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1135087vqr; Fri, 9 Jun 2023 12:28:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Paz1lGFW7c+zhj6s3Q5svLqcW6q4ACJe2RzBu3lLr+G1T7PuFPmOxO631oY1ntpc2oVRz X-Received: by 2002:a17:906:9b8d:b0:974:e755:9fde with SMTP id dd13-20020a1709069b8d00b00974e7559fdemr2747451ejc.19.1686338924917; Fri, 09 Jun 2023 12:28:44 -0700 (PDT) Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id kj14-20020a170907764e00b0097456527b1asi865630ejc.37.2023.06.09.12.28.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jun 2023 12:28:44 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=G7k87sjR; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 282D3385700D for ; Fri, 9 Jun 2023 19:28:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 282D3385700D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1686338923; bh=HRLFbHaVqMH5I8WqhF978/DhNufUJK5U8Lzn1fAE1XQ=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=G7k87sjRbPSxxo3aPlnU4X/y5DmOyYoZHxDXcMnh9JXmZ521BrLFM8fUtjTt++x3Y OMsMKMaNawTyelA0+8SeHbMwAPNaKumehVf8cI8uA2xTuCs/++Xfj1FNWAmkhuozO9 EoLEPGs2XD+kZxl+BEQQV9vXj9Wa+y1QyB5vt1LY= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 63B633858D35 for ; Fri, 9 Jun 2023 19:28:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 63B633858D35 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 359IENPg019311 for ; Fri, 9 Jun 2023 19:28:33 GMT Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3r2a6rffqf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 09 Jun 2023 19:28:33 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 359IZ0DE010513 for ; Fri, 9 Jun 2023 19:28:32 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2048.outbound.protection.outlook.com [104.47.73.48]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3r2a6tkgbd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 09 Jun 2023 19:28:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kbfMtkP1k+YfpTt7iZN0PEvQTZC5AI//QwgrlcPL+dYUimjC64nCp5EnXhMKK3YY9bCc4Tfo0JQOXVvR+yDrosiZrGbjbJsY1Lzc7mRecr8DvFu8yOU2NGyGatqny9vbHHzhmjEoNgdpklU8ZJ7Z0+UAJeISC6S1+Pd2P+qPPze5b4TchbuwW169fcIxJbhhTWSND3IwJVXlgEIQeBvLiPhBLg7h2iJYnOhwEDJ5+l6MQxUwN7wHYfrtH9J7/5B82arNLitlsE73JGmjrrCd6rKSsCctOxc24IXKV4zgxdMdQ5ihuRz9wYbsnt8cfAeJ07zka8drPXCnhdCZOkd9Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HRLFbHaVqMH5I8WqhF978/DhNufUJK5U8Lzn1fAE1XQ=; b=L+6Fq5bR7YwswIqKGeWRW+/mX7pAc5wxsrvOXcr08bbgszuuS0GjNA8T9Kypze6xS8Mtg3jOkoZMCs1ERuC3cywgKX13o0bNv3WRSeyj/DbjpNgDJ3gysdsVYQgqETWC/Av2NjewzdlR1TNehu3f3/wQ7O9U0N4x81OZsru6uWRAuBj8NKuSA+Jwc5RwsFvWq+xiQLMucRLX5lrBYv8FnsOLgy5zqi0awBlkQeGNtmpzFk+Ep3+4qxjYW09ctzKY+7XEMssvLcJ2ntbuYJC/xvFnIQhjWopgwBf7K6AxV7rVNCl6g/GpjTSig2JSim4lYp2f6rgWkVXF+e6MAx9OyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by MN6PR10MB7423.namprd10.prod.outlook.com (2603:10b6:208:46c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.27; Fri, 9 Jun 2023 19:28:27 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44%4]) with mapi id 15.20.6455.028; Fri, 9 Jun 2023 19:28:27 +0000 To: binutils@sourceware.org Cc: Indu Bhagat Subject: [COMMITTED] libsframe: fix sframe_find_fre for pltN entries Date: Fri, 9 Jun 2023 12:28:21 -0700 Message-Id: <20230609192822.2471957-1-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.39.2 X-ClientProxiedBy: MW4PR04CA0186.namprd04.prod.outlook.com (2603:10b6:303:86::11) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|MN6PR10MB7423:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f00e2b9-dd81-4d70-019e-08db691fb304 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1pcIZUqPfmDIim9iTOtgBj07K4cPaquk60TwHkcq3F2sKL/Q3ijC7+nl4O4xoO5ztwMLNME4uPX/0ZyddnSb6/vYfIxsDjvV+b17DX4qsC5JRtUfC5PLVEDpw5b9C7WgW67/9BF3sGBzaTfQ+QlHMEypJIOGZ/liJ17H9ynL4HztYZVnkztZVr6Nc2VZu57KsoX/7gGmLIyAzrfBnQWKxt0n/Y22MQ9o6NY5M1IEt407sUlr0ymCwKIglE64gKlSBDaXB/zFvFenIVp1JFpLuDczWV51tdbN0yksiB769vR01vaO0gcsoAuq5XZWPnrMUmvCjpPpMceEZXSujCcNMRCanfb3c1h7rASOANZPNWET40lsDw1DzQnwzdtawppbVwSckHYoYKqYVF0yBNmf8yPx0uVAAWdb2ZXv9Bjd9M3OKtj+r3sjPnRtHSVMRNEZVQSal2dL/55yUThALQJIgAfnArbvcaCvNrxkckFZ5lq9jpYb0vtFDb/p3Th0RuLJG1L+GpOrd7lGEhhLNQn3Dib+zq+wR+CJdnoxEEwMNVArynnafPTSkKpS102fU/Vx X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(366004)(346002)(376002)(136003)(396003)(451199021)(36756003)(1076003)(26005)(5660300002)(107886003)(186003)(6512007)(6506007)(41300700001)(8676002)(2616005)(8936002)(478600001)(4326008)(66946007)(83380400001)(66476007)(66556008)(6666004)(6486002)(38100700002)(6916009)(2906002)(316002)(86362001)(44832011); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: u08LYv3fb5OnEgYDo4d9+w6sX7mwxqA4ryPWIU1z9kgoOeFSBfWg6XJzT7SRgonYqM9gjU64FvDkPmxOl5WzCfIHJoYj1LFwBrYzyXi1F/TjoF8xWhs2TuJZvOrF+w2QH/u6O8e2nYNZtmW0LZ1+17n+oVqn+xnw3XEPGyZRir549FhLMUBYyF7BKiI2aeLLygRnbjkBU9++BSHfL+Oze6d72eDz9t7XkVdQLKMGp3m6HCu8L4MHWG++N4qLRiAPa0FxUnr9McO4jN2EMK5QfqTaNxshtpVeMVI7PbGMSiin3W/uGELlsM1/CVj2eC7y92pq6vvrJwN6/X8/g4VmFWx5XWexQb83SvC70QA1uJX5OpQ9OxGTHkC264DoZd8Hp/CReKbb2mPt8CNiZ4VGNIatJLL4UufzW+kyYlIl55vjdJtQr4WhiAMB18xurr9Eoz0p6SKdjoEd9EF0I78Y0DgsqwKtZHLxQrKlr2wUOPIfcs5ZabUFJrUFvbr9dq0H6bsruXOQmalgL8yc4StvgRuqVEaVFxxguXBfA86Fuc6iPoMnBhrVXhIRidSEQhRbV51ffW7Qx62+CB0heL9x8XREoFZ8wpbi2ZTPoZMTkraIv3WRZXmHDCpP3qEO/lcVFpaW2FFMbSVPe+TZL4O5MbYUzblOFo2qKc7oE46ZwZYETHleK0nT0JdJzqd1YdaS3YxXI4qNMOTYDZ9qEShPfiG+jghhZ8vimbFANiKLTNzVpXSNJ6z5zgbjQf35jze2wqfE4iq+Vc+twnDvGerpxqx3Hs3y3a05rAjU/TQs9I4Gg1hWDPv9ci6QOXqhn6g4h9YSZwDl2gX6NaHC4O6WBxLPdYoF2DbVJBi70hY4fynLp6EtZYbRKNzN44hfvpCN4NCOOIoSl3w7yfIXqG8HZTyR2R/YDiHgKCGgjUGIusxYcJTEkNJbsj903SHS2nrgt4i7X1MNkp3wCd+sU8Ab2kCBA44A8SgJHANg42oNAjVR0TSD7jGPSA+H+a7vsfGb4QYAKYXXVW896Bp4P7j+lUX36NCpdpQbAxfQkA+tkhmqNtalnyajVYp4l6TeCS/F0gJxZqZhVfldXSYL1SU3ny8L3toRzkzex4p/cXvHdSB9hbsOloO5dSQ8y8AoBMnzhwR2m/D+VIFWu/P/asLpy8xCtoho5I8bxfjStVAbwvK6qYbo3IRhn6/amJFRhd1DBOo+7WLeabbYPtdwD2z6H9xF1H9+p+tGAlf3Zjw1H88okK4KonzB7jo1HGRhWfu4mgM9CQ9xxMSHN+pPcIHsc88LE8e5kXaQ5j2xKOvC6ujuEx99X8V83W1NZUdC/EVBCZqFBbjsoZ5BlbEMwmdXuBUOHexqvj8TI98IhXhm/mfL71ff0sy3tuAOiBwETuFWdiK+O8v/F+n6yYfRPfcHxfQ/kCXyUrlwrYV/+Y3JqpyMoBqkrZEE5hxheqkvxAp7N2BmHz14JKg580IGhLu8RLK91Tnpu+FinHykOkaQX01kugXpOFmwzeHpaWQNHlCIcuO3CHBz1rKJ/qvkR9NN6Bw2hYgo+qSIo/hDuSZoy9bNLHAbJRNS/BSLYItIwLxh X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: DO0qxJUAp/8/8g4L3gwIc8pJ1Ao3OsdQ/0Gbqbjk633BFcVA9hH/pH2RUnIPrwNmpWAo0IhfEkXyWsmb24M3pwJEvqe0yUKXy1ZEchPpsqESXEhy1eEM1TUPukNK9zbstJO9Z0yef5cW0J14A0P9AkTglKG/CC5ilZOvbd/xwjNaj+XmwFjuVZbCOjqJ1WZ0EIHAcDbVOiIv1DUVgqFIAlXsOmiB9amoSyFUhvsK5zWivLfDqGxSmvK0lOiA4KrIBqm9Dgl2NIgcGtcxOFRP7gnv3prU9z8+GnmgC40jAftvBUBoBFPLjn3olkUzObo0WmJOHIjQl/6pCGDfJfLDsjx3SqAYWVWEt1Vj/I4KC4asVfMnCGto8KBiEdLEurAM+V2DWpVeM43s/UNEMbaqCuHk3zkyNr/LZHq9XSnLURyOwdx4c0hKalgid0I7R0vYItpDPr2WziLYIc/0KADgq2PCcLd6DjrAd8csaglk7OXMFLxD7+spvNEQYuLzbeA8maeUCsFhNAkIgcexx0RiauyJlqbEoeZ5L14n50Daok/i8BUm5lw7b5LZlffoOkhRI/Wh8MYQn/Uap6To77HJXp2mKTeQW4At6121CW+ysmJR+apths9+lPH0JNNukn67TviWj7HjqNoXKbUufRnsh289wTe/6qTjoknfNnfEzlLVUrWrPeCxF4MMsWL/fiLrdhPLW3ESCxPyRUFHodrZxJ6H6JqmuxyffrHLdCXBhW8e2pk0n7CuPF3iSXMYTt7f X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f00e2b9-dd81-4d70-019e-08db691fb304 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2023 19:28:27.2662 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u8hBKqN0R5lqlG0OBOMCZjBFN4zYjtE6qd/YFoWUcrBWYsRq+flgfwwh7/gz+2IVFWhaUFqIMZuNWaHy6G+5ew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR10MB7423 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-09_14,2023-06-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 mlxscore=0 bulkscore=0 phishscore=0 mlxlogscore=788 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306090163 X-Proofpoint-ORIG-GUID: SbGp8EQExWrFIoGnx1VlYNRI56-rQPjT X-Proofpoint-GUID: SbGp8EQExWrFIoGnx1VlYNRI56-rQPjT X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Indu Bhagat via Binutils From: Indu Bhagat Reply-To: Indu Bhagat Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768254524648449447?= X-GMAIL-MSGID: =?utf-8?q?1768254524648449447?= To find SFrame stack trace information from an FDE of type SFRAME_FDE_TYPE_PCMASK, sframe_find_fre () was doing an operation like, (start_ip_offset & 0xff) >= (pc & 0xff), etc. This is buggy and needs correction. The mask 0xff should be 0xf (to work for a pltN entry of size say, 16 bytes). At this time, the size of the pltN entry is implicitly assumed to be 16 bytes by libsframe. In next version of the SFrame format, we can encode this information explicitly in the SFrame FDE. For now, we should fix the code to at least behave correctly for the generated code and the generated SFrame stack trace information for the pltN entries on x86_64. libsframe/ * sframe.c (sframe_find_fre): Correct the bitmask used for SFrame FDEs of type SFRAME_FDE_TYPE_PCMASK. --- libsframe/sframe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libsframe/sframe.c b/libsframe/sframe.c index a5f4a7f6519..7308a45ce88 100644 --- a/libsframe/sframe.c +++ b/libsframe/sframe.c @@ -1066,7 +1066,7 @@ sframe_find_fre (sframe_decoder_ctx *ctx, int32_t pc, /* FIXME - the bitmask should be picked per ABI or encoded in the format somehow. For AMD64, the pltN entry stub is 16 bytes. */ if (fde_type == SFRAME_FDE_TYPE_PCMASK) - bitmask = 0xff; + bitmask = 0xf; fres = ctx->sfd_fres + fdep->sfde_func_start_fre_off; func_start_addr = fdep->sfde_func_start_address;