From patchwork Fri Jun 9 09:21:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eugenio Perez Martin X-Patchwork-Id: 105482 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp821105vqr; Fri, 9 Jun 2023 02:34:31 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6LPwoBmbfuClfP9kAtfFyqdub4iNVGx2Z9SToasF7dXwyqLgzja1rrkfocFvrc0xCG08Iy X-Received: by 2002:a05:6a00:1c83:b0:64d:42b9:6895 with SMTP id y3-20020a056a001c8300b0064d42b96895mr5225533pfw.5.1686303270897; Fri, 09 Jun 2023 02:34:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686303270; cv=none; d=google.com; s=arc-20160816; b=RwlnF6OVtwyQFXBw6oNKt1Cpqy52vGzqau2Dj48A5kaEzaEkn3NtgAxL55lc42zYA/ 5lafRGypNoIczRpPEwGzxYY5M8mFkUR32NW8JG8A/Y3c4WlOcL4j4hz3y51gG6Y64xve bkNArE59bYNh0/E2aVSxCf59KUzA4p44Sp03CNCVmK3bdtCYeBruue+Lf/8NCe2d7BCU r7u1gdmESocuY33Aq1064KRXoEibCL2pJ/DUkLXRC8Gu2q9JZo/2O+VFwVMZ1tFCQq9y 9A8PnmoWCe345Hw0MXtveq+MiJBOfkHj1M8DeT4WnWM10r7nJz6gS8uYhLCU/dMiXYQH B8+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=yrvz2NuuJ8t+PjTH8hQDFouZJRAvGRd7mM5s6NiOOaU=; b=wddtTbwfOsklukWkcQc3pk9qmzcVD7RVzRR8yBsJ7ahvdcBLg9Oj8YHch03PvMhYHn vtN3vNtci4+4QNbw1q/hZ+GXoOrQglaf6A3fR4oT9tnbHVOTv2BLT6VDllGHUxJMgomA loSPUwmpRcajNQ9+qsR7prBqiIt32GlEyjSKkfhpSB/Yu0oW4rym2W/ULjjehKiwDYyM KeO8Z9yRl2dN7FGcagi7Y7bERB/psgFn/ld65y8sVSsBQvywjJ0XBWl+WsfgIQn4YahA ahyJHVCF3P9OJzs6SXBy0g7quJ+r/2+W/6mgT5ZPoO31JYdvSMRCZ85fcIrYeLAKaWTM FpuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VEulbuZS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a18-20020aa78e92000000b0066023827cf2si2261108pfr.31.2023.06.09.02.34.18; Fri, 09 Jun 2023 02:34:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VEulbuZS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241537AbjFIJ31 (ORCPT + 99 others); Fri, 9 Jun 2023 05:29:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241464AbjFIJ27 (ORCPT ); Fri, 9 Jun 2023 05:28:59 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A9193C3F for ; Fri, 9 Jun 2023 02:22:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686302500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yrvz2NuuJ8t+PjTH8hQDFouZJRAvGRd7mM5s6NiOOaU=; b=VEulbuZSenqb41bfbWhG5LSAnkrDQxkv+G06R0rA4DQvEJocA7GFOw2zlKwzwbM3bvHa48 tVcFzpc0eE6DKGi00AGSTrwFo7koBHiIgTPhlYh3lWjo20TW/k1ZKhHXJ2HlRjoHn2zNNy RrKg5qyuTcZwSpvSuVlamYgA2AfnL/I= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-333-jjshG5t0OBG9vTCK3FCePw-1; Fri, 09 Jun 2023 05:21:37 -0400 X-MC-Unique: jjshG5t0OBG9vTCK3FCePw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 405448028B2; Fri, 9 Jun 2023 09:21:36 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.193.246]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2C101202696C; Fri, 9 Jun 2023 09:21:33 +0000 (UTC) From: =?utf-8?q?Eugenio_P=C3=A9rez?= To: mst@redhat.com, Jason Wang Cc: Zhu Lingshan , virtualization@lists.linux-foundation.org, "Gonglei (Arei)" , longpeng2@huawei.com, Lei Yang , Parav Pandit , Gautam Dawar , Dragos Tatulea , Laurent Vivier , linux-api@vger.kernel.org, Liuxiangdong , linux-kernel@vger.kernel.org, alvaro.karsz@solid-run.com, Shannon Nelson , Stefano Garzarella , Cindy Lu , si-wei.liu@oracle.com, Harpreet Singh Anand Subject: [PATCH v2 1/4] vdpa: add VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK flag Date: Fri, 9 Jun 2023 11:21:24 +0200 Message-Id: <20230609092127.170673-2-eperezma@redhat.com> In-Reply-To: <20230609092127.170673-1-eperezma@redhat.com> References: <20230609092127.170673-1-eperezma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768217138316314306?= X-GMAIL-MSGID: =?utf-8?q?1768217138316314306?= This feature flag allows the driver enabling virtqueues both before and after DRIVER_OK. This is needed for software assisted live migration, so userland can restore the device status in devices with control virtqueue before the dataplane is enabled. Signed-off-by: Eugenio Pérez Acked-by: Shannon Nelson --- include/uapi/linux/vhost_types.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/uapi/linux/vhost_types.h b/include/uapi/linux/vhost_types.h index c5690a8992d8..4889e6d70b15 100644 --- a/include/uapi/linux/vhost_types.h +++ b/include/uapi/linux/vhost_types.h @@ -165,5 +165,9 @@ struct vhost_vdpa_iova_range { #define VHOST_BACKEND_F_SUSPEND 0x4 /* Device can be resumed */ #define VHOST_BACKEND_F_RESUME 0x5 +/* Device supports the driver enabling virtqueues both before and after + * DRIVER_OK + */ +#define VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK 0x6 #endif From patchwork Fri Jun 9 09:21:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eugenio Perez Martin X-Patchwork-Id: 105495 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp830114vqr; Fri, 9 Jun 2023 02:59:01 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4E/MHhG9bcafBzWNDCK3omOqjRJb4/0fC7CajdC56cJtB0MxtCYIxcjlQILsd7Bs8pJNnB X-Received: by 2002:a05:6358:c02f:b0:129:c6d0:20ac with SMTP id ez47-20020a056358c02f00b00129c6d020acmr706685rwb.31.1686304741544; Fri, 09 Jun 2023 02:59:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686304741; cv=none; d=google.com; s=arc-20160816; b=Av3TSCXF7D5jOKs8GRDx8vk1lYzder5k9oMEoIP0GL9od1TBjmjhkewmN7Bqu/4h+J yHrrEmk9bRIEoTgjb1zNdyo3oKZPiLH7Ko8hdun0ymre97XOC1ULR3Y7V+vw56q2MU9j 2ww8AEczeLSK5ZvkOFYNi/QaIsnVDtKjAhVH35ZfzeyN62gxLLRqTES/hqaQULzgWUwQ HghhlmFGcxEu5OKsV5OAGsCDkvlMPGL3aZVvgCCZSMQq16rYWnVqMaMBTZMlvsLQaJzP Ax3eYRUokNaTEL1uwtJ6w6qKM+uOd4mRxTTFddjKArZZUt/qFBYZtOFSJAyAUIKpXHJE TifQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=BSYu94PSBBeau34XT4dGzInntObCc6c7/xjwJmmjNHA=; b=LizBdkEWnGh4VsEwo5cgszbTOQS2F9b+4S1HI+94jtA6wS4tkTC+1fN/8bOqZQAizl JHzlabjGPkacJJfUGCk0JlHbvu81IWltA9xR9swpqYVS5/nk9hQ6L4L+03fBW7mOR0iU tI5xFQ4uMU7hpcu+oUVe0L2lK6IGC88LVygUIQUA1CLxbFcvwpZ2H4nstwWWSLyDxiCy kiAlhJrhREnwPHSl5Tn9aIiksjMxMLYpQSmwbkNsl8MKSZBFYrm9jVHBPL6W5yKBklyT mu0gL1Q9g7pQ4ZXrz1dDO4S4EuLA8NU2Qd3iOe26noT17MUq2Ybsm4s3zBcVIqwPaKlK KK8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HQJlwRNS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r21-20020a632b15000000b0051b32aa267asi2348619pgr.671.2023.06.09.02.58.48; Fri, 09 Jun 2023 02:59:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HQJlwRNS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241131AbjFIJbi (ORCPT + 99 others); Fri, 9 Jun 2023 05:31:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241474AbjFIJbQ (ORCPT ); Fri, 9 Jun 2023 05:31:16 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F0376EAE for ; Fri, 9 Jun 2023 02:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686302700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BSYu94PSBBeau34XT4dGzInntObCc6c7/xjwJmmjNHA=; b=HQJlwRNSDdOttwjngS6GaFluxSjDRTLzruecnjXuDkI7NQ7ZXgP83FNk7WT2sgKJRtQLhJ iKsDY2kyxYdI6N1qc/p9tdcrnT/sgTasBG6ez6SpPN9nrjIeW/kLpWwLxWjNlkdT4XnELh vwFV2s1B4jFmyJMeF6sHuRDjk6Krvtg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-625-xyILRbHZOBWmGloccysoMQ-1; Fri, 09 Jun 2023 05:21:40 -0400 X-MC-Unique: xyILRbHZOBWmGloccysoMQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9B03985A5A8; Fri, 9 Jun 2023 09:21:39 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.193.246]) by smtp.corp.redhat.com (Postfix) with ESMTP id 86DD420268C6; Fri, 9 Jun 2023 09:21:36 +0000 (UTC) From: =?utf-8?q?Eugenio_P=C3=A9rez?= To: mst@redhat.com, Jason Wang Cc: Zhu Lingshan , virtualization@lists.linux-foundation.org, "Gonglei (Arei)" , longpeng2@huawei.com, Lei Yang , Parav Pandit , Gautam Dawar , Dragos Tatulea , Laurent Vivier , linux-api@vger.kernel.org, Liuxiangdong , linux-kernel@vger.kernel.org, alvaro.karsz@solid-run.com, Shannon Nelson , Stefano Garzarella , Cindy Lu , si-wei.liu@oracle.com, Harpreet Singh Anand Subject: [PATCH v2 2/4] vdpa: accept VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK backend feature Date: Fri, 9 Jun 2023 11:21:25 +0200 Message-Id: <20230609092127.170673-3-eperezma@redhat.com> In-Reply-To: <20230609092127.170673-1-eperezma@redhat.com> References: <20230609092127.170673-1-eperezma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768218680734076196?= X-GMAIL-MSGID: =?utf-8?q?1768218680734076196?= Accepting VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK backend feature if userland sets it. Signed-off-by: Eugenio Pérez Acked-by: Shannon Nelson --- drivers/vhost/vdpa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index bf77924d5b60..a3204406b73d 100644 --- a/drivers/vhost/vdpa.c +++ b/drivers/vhost/vdpa.c @@ -680,7 +680,8 @@ static long vhost_vdpa_unlocked_ioctl(struct file *filep, return -EFAULT; if (features & ~(VHOST_VDPA_BACKEND_FEATURES | BIT_ULL(VHOST_BACKEND_F_SUSPEND) | - BIT_ULL(VHOST_BACKEND_F_RESUME))) + BIT_ULL(VHOST_BACKEND_F_RESUME) | + BIT_ULL(VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK))) return -EOPNOTSUPP; if ((features & BIT_ULL(VHOST_BACKEND_F_SUSPEND)) && !vhost_vdpa_can_suspend(v)) From patchwork Fri Jun 9 09:21:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eugenio Perez Martin X-Patchwork-Id: 105483 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp821277vqr; Fri, 9 Jun 2023 02:34:56 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4orlrmKm4nXAZLRSNKUoB822aYNd+guz7pEMKagT9jVvqSgSA1AQ/wnKa2AmNvaOcalC5x X-Received: by 2002:a05:6a20:e616:b0:118:5d5a:f26d with SMTP id my22-20020a056a20e61600b001185d5af26dmr739400pzb.59.1686303295765; Fri, 09 Jun 2023 02:34:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686303295; cv=none; d=google.com; s=arc-20160816; b=W+0ZYArAJG5EJwkUcgBEKEalAJ0Rdr61yqL5jq+gFp5l8+EtLowhedaxWMGXUPHq2s dirnGxjW4Tf2dcH9otAnBAvvU8CFHMnZfQ8LC4PO7q/MPJEsK4+I5Q+FkHV1BNK2wnMH z4NR0ZKc/QZ77akrt1GDyiHXv5CLgMoLPV4QbCArq9A6JwDkYvem5VPYOF+G8mEbIrdk jLvc1yPKI/hLD1dCH1UEBADfebXtIbnLSUx6+9Dk2e0bRUzKOT4uS5+8JTSINU1p5Vhf KOddCc/w3iP3QV86uToXlslRfoXNd5kA4o3n44XI9a8LfcCVZ3d5KbzM++EClBncGIPz HNkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1rO6a+xdfZtWaePxR/QAzOglehE9/nz9AmfIDcLwU6A=; b=f/9dE1QiyKTwyX9EwH3VNhtGCgRcL8zYJSMee5wvc3B6FRpVMlbdLNnrIjxoLjSZVN YUe3HYMjSXJKYJ2uFvcebPCixb8PJS+xwmVq6FeocHVWyiiHklNSCTIYeM05WBjAyPKp fZXzFQ6HHqUMd7tKYxS1VEcHN8IP74J7mML6FlgHDxsBq7Eldl0jirc9yakMQUX79MT1 XGzi6PJr0yVjiVrwzNl45fOHed3laPeVRFfUn+hqQZ0U+59TG8Q2cTknJwur71KQvJBo pbX72Bh7RVu1uRLlSKFnn94tSselPG2O3w+KHW+1ys4gXYQ3V1vNeYKCayfmuq3c2r7l lyUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FMJyqKVs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w2-20020a637b02000000b0054290efc1d8si2406804pgc.504.2023.06.09.02.34.43; Fri, 09 Jun 2023 02:34:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FMJyqKVs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241619AbjFIJ3i (ORCPT + 99 others); Fri, 9 Jun 2023 05:29:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241592AbjFIJ3V (ORCPT ); Fri, 9 Jun 2023 05:29:21 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E27F3C0F for ; Fri, 9 Jun 2023 02:22:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686302511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1rO6a+xdfZtWaePxR/QAzOglehE9/nz9AmfIDcLwU6A=; b=FMJyqKVsnJYHf9jH0K8He2OMghhLsTfuSQy+outElY2QV86c5+Px5FOg8vdhdda1mF6IaU BRxM+LD48wUeEPbk6hDto+P0FNVtb/qdiBiTnNJoBktV7q8RQD4xSIzgm62t5vaS23UhZF A4CIvDdUSRbnWBhhflCGjbjD1j05z/g= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-230-UYkEzIZQPV62AftoqrzJjw-1; Fri, 09 Jun 2023 05:21:45 -0400 X-MC-Unique: UYkEzIZQPV62AftoqrzJjw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 01DBF802355; Fri, 9 Jun 2023 09:21:43 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.193.246]) by smtp.corp.redhat.com (Postfix) with ESMTP id E24BF202696C; Fri, 9 Jun 2023 09:21:39 +0000 (UTC) From: =?utf-8?q?Eugenio_P=C3=A9rez?= To: mst@redhat.com, Jason Wang Cc: Zhu Lingshan , virtualization@lists.linux-foundation.org, "Gonglei (Arei)" , longpeng2@huawei.com, Lei Yang , Parav Pandit , Gautam Dawar , Dragos Tatulea , Laurent Vivier , linux-api@vger.kernel.org, Liuxiangdong , linux-kernel@vger.kernel.org, alvaro.karsz@solid-run.com, Shannon Nelson , Stefano Garzarella , Cindy Lu , si-wei.liu@oracle.com, Harpreet Singh Anand Subject: [PATCH v2 3/4] vdpa: add get_backend_features vdpa operation Date: Fri, 9 Jun 2023 11:21:26 +0200 Message-Id: <20230609092127.170673-4-eperezma@redhat.com> In-Reply-To: <20230609092127.170673-1-eperezma@redhat.com> References: <20230609092127.170673-1-eperezma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768217164881094793?= X-GMAIL-MSGID: =?utf-8?q?1768217164881094793?= This operation allow vdpa parent to expose its own backend feature bits. Next patches introduce a feature not compatible with all parent drivers: the ability to enable vq after driver_ok. Each parent must declare if it allows it or not. Signed-off-by: Eugenio Pérez Acked-by: Shannon Nelson --- drivers/vhost/vdpa.c | 12 ++++++++++++ include/linux/vdpa.h | 4 ++++ 2 files changed, 16 insertions(+) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index a3204406b73d..e1abf29fed5b 100644 --- a/drivers/vhost/vdpa.c +++ b/drivers/vhost/vdpa.c @@ -403,6 +403,17 @@ static long vhost_vdpa_get_features(struct vhost_vdpa *v, u64 __user *featurep) return 0; } +static u64 vhost_vdpa_get_backend_features(const struct vhost_vdpa *v) +{ + struct vdpa_device *vdpa = v->vdpa; + const struct vdpa_config_ops *ops = vdpa->config; + + if (!ops->get_backend_features) + return 0; + else + return ops->get_backend_features(vdpa); +} + static long vhost_vdpa_set_features(struct vhost_vdpa *v, u64 __user *featurep) { struct vdpa_device *vdpa = v->vdpa; @@ -742,6 +753,7 @@ static long vhost_vdpa_unlocked_ioctl(struct file *filep, features |= BIT_ULL(VHOST_BACKEND_F_SUSPEND); if (vhost_vdpa_can_resume(v)) features |= BIT_ULL(VHOST_BACKEND_F_RESUME); + features |= vhost_vdpa_get_backend_features(v); if (copy_to_user(featurep, &features, sizeof(features))) r = -EFAULT; break; diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h index db1b0eaef4eb..0e652026b776 100644 --- a/include/linux/vdpa.h +++ b/include/linux/vdpa.h @@ -208,6 +208,9 @@ struct vdpa_map_file { * @vdev: vdpa device * Returns the virtio features support by the * device + * @get_backend_features: Get parent-specific backend features (optional) + * Returns the vdpa features supported by the + * device. * @set_driver_features: Set virtio features supported by the driver * @vdev: vdpa device * @features: feature support by the driver @@ -358,6 +361,7 @@ struct vdpa_config_ops { u32 (*get_vq_align)(struct vdpa_device *vdev); u32 (*get_vq_group)(struct vdpa_device *vdev, u16 idx); u64 (*get_device_features)(struct vdpa_device *vdev); + u64 (*get_backend_features)(const struct vdpa_device *vdev); int (*set_driver_features)(struct vdpa_device *vdev, u64 features); u64 (*get_driver_features)(struct vdpa_device *vdev); void (*set_config_cb)(struct vdpa_device *vdev, From patchwork Fri Jun 9 09:21:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eugenio Perez Martin X-Patchwork-Id: 105491 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp828181vqr; Fri, 9 Jun 2023 02:53:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6PhfWdfkWOfxZk763OXu43FFR4PNP/7nCHSUUeoTi0GSE/MZ9UfUx0oi9/0R2MNIuXy/8Z X-Received: by 2002:a17:902:c40e:b0:1b0:7123:6ee8 with SMTP id k14-20020a170902c40e00b001b071236ee8mr1078735plk.61.1686304413945; Fri, 09 Jun 2023 02:53:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686304413; cv=none; d=google.com; s=arc-20160816; b=KJNtDui9xcFfsb4lzQRPxvAdzlaJeELQrVCU7QqdtYfuynP/spnoSjaINYuz6a3hFB 00lLIfXzRjcF0Fu2DyAuUJZ38FdUKX6gr9ZjHZl75FdR3lShpL+BaO6ZYEWybXNYLpOa bQTYj0PRR8ZPUQM1kZCNk+Ar+5qsld+RWmSnuW3rUion879UfsUytWYrb1q3UIExGsKj 5wpghLuNyLqU1Ts/DDybOqbRIqcoj7A1w6OXi39Qz9I2RYSVnvitwQyrS6raIBw8/bq+ AxsDSxWcKzSAZXf4DlJ3VRLa95krjDJYqmKGk3LkQg47UrDSyd7NiL0rBlwHn2ejxXKs mYsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ECFSkBPZk6Hf9wW6u18xsllOKumXr/NSdBh2uJ9ps7g=; b=CN+hzEjmw3BlSrjx4xHOhZl5M/h1dFRWsSnqVwWkYQgd62isYi6rwWUTYAclDNLobR yCMP2VW/8awhpG8jEvX+kj9Ynp3fX6Vbw55kGboxXhD7lKs3ft63gQVO0RUdsh7VvkDL kg/DfqoUrW2m/xevfGU76pUP8wZz1EGR6jz1m0Cj5I3M6iaALtrRIEDTKUIJ82jJM7Ki kQwAC9WMvTAtYdnye7muD/SLCXDFdFsZ9rD2Jp8NyNlL9OEVoBDyeWiPvuyhKv82DxCd +5nRfg+vWKzLpM8xAS/KGBLWxxTmFPrGuTJaAgZOck5wYB+i0FEYrRE+t3qlP0T6nKdH Oz/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=O3IF61vP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u17-20020a170902e5d100b001b243a20f0fsi2479915plf.504.2023.06.09.02.53.20; Fri, 09 Jun 2023 02:53:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=O3IF61vP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241606AbjFIJ3O (ORCPT + 99 others); Fri, 9 Jun 2023 05:29:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241592AbjFIJ2u (ORCPT ); Fri, 9 Jun 2023 05:28:50 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04CE86A49 for ; Fri, 9 Jun 2023 02:22:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686302510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ECFSkBPZk6Hf9wW6u18xsllOKumXr/NSdBh2uJ9ps7g=; b=O3IF61vPH48SitPOY0YhEBM16FELK7vCrGd/fd7y+F/LCfgJKlVd3TIt7sEba+BZAC6fpV 5S+/rAY6s6kzgIdJZqGP3XgCd+apV73N2nAiAuaTLI4uXFSAltwMPFUAdtT3gVMzWF11qv tz4FsQpUBWbRimmHIyaNMpTMW4aAWzA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-497-r4toiCbLPEavcdV3x29TIg-1; Fri, 09 Jun 2023 05:21:47 -0400 X-MC-Unique: r4toiCbLPEavcdV3x29TIg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5BF45101A593; Fri, 9 Jun 2023 09:21:46 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.193.246]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4888A20268C6; Fri, 9 Jun 2023 09:21:43 +0000 (UTC) From: =?utf-8?q?Eugenio_P=C3=A9rez?= To: mst@redhat.com, Jason Wang Cc: Zhu Lingshan , virtualization@lists.linux-foundation.org, "Gonglei (Arei)" , longpeng2@huawei.com, Lei Yang , Parav Pandit , Gautam Dawar , Dragos Tatulea , Laurent Vivier , linux-api@vger.kernel.org, Liuxiangdong , linux-kernel@vger.kernel.org, alvaro.karsz@solid-run.com, Shannon Nelson , Stefano Garzarella , Cindy Lu , si-wei.liu@oracle.com, Harpreet Singh Anand Subject: [PATCH v2 4/4] vdpa_sim: offer VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK Date: Fri, 9 Jun 2023 11:21:27 +0200 Message-Id: <20230609092127.170673-5-eperezma@redhat.com> In-Reply-To: <20230609092127.170673-1-eperezma@redhat.com> References: <20230609092127.170673-1-eperezma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768218337138360662?= X-GMAIL-MSGID: =?utf-8?q?1768218337138360662?= Start offering the feature in the simulator. Other parent drivers can follow this code to offer it too. Signed-off-by: Eugenio Pérez Acked-by: Shannon Nelson --- drivers/vdpa/vdpa_sim/vdpa_sim.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c index d343af4fa60e..76d41058add9 100644 --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c @@ -18,6 +18,7 @@ #include #include #include +#include #include "vdpa_sim.h" @@ -410,6 +411,11 @@ static u64 vdpasim_get_device_features(struct vdpa_device *vdpa) return vdpasim->dev_attr.supported_features; } +static u64 vdpasim_get_backend_features(const struct vdpa_device *vdpa) +{ + return BIT_ULL(VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK); +} + static int vdpasim_set_driver_features(struct vdpa_device *vdpa, u64 features) { struct vdpasim *vdpasim = vdpa_to_sim(vdpa); @@ -733,6 +739,7 @@ static const struct vdpa_config_ops vdpasim_config_ops = { .get_vq_align = vdpasim_get_vq_align, .get_vq_group = vdpasim_get_vq_group, .get_device_features = vdpasim_get_device_features, + .get_backend_features = vdpasim_get_backend_features, .set_driver_features = vdpasim_set_driver_features, .get_driver_features = vdpasim_get_driver_features, .set_config_cb = vdpasim_set_config_cb, @@ -770,6 +777,7 @@ static const struct vdpa_config_ops vdpasim_batch_config_ops = { .get_vq_align = vdpasim_get_vq_align, .get_vq_group = vdpasim_get_vq_group, .get_device_features = vdpasim_get_device_features, + .get_backend_features = vdpasim_get_backend_features, .set_driver_features = vdpasim_set_driver_features, .get_driver_features = vdpasim_get_driver_features, .set_config_cb = vdpasim_set_config_cb,