From patchwork Fri Jun 9 08:15:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 105378 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp790490vqr; Fri, 9 Jun 2023 01:18:56 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4qEqWYtddqOqBch9dRvLIpJgjaNmIKeO9e6Kg1hNbKeT6znH5kwFh4D9A9lNZfD8T1egYd X-Received: by 2002:a05:6a20:4426:b0:106:92a:37ae with SMTP id ce38-20020a056a20442600b00106092a37aemr4762863pzb.30.1686298735787; Fri, 09 Jun 2023 01:18:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686298735; cv=none; d=google.com; s=arc-20160816; b=z341iSqWqYETncNq+9hrEHiGJ2RWyPXsiP1gUGmn+y6eFGcJ11Rz/HdoI8vpy32N+d nOharDRLQJMRCIuNup41m3uoSIuYeGkUYfoMCo/vztAH3pEuzuOyQngMgZI1sXMvcLZg XU8Dtrkaxm0KmVUhFtX/NK0F9AtkjYwTddDZhghmtBEyw+3hPS2P8d/FVOBklw4pJ7/e t7knXl6LbU9bPaz5wobRFAqYSmmEleWjsErcMnOQCvtgZ2dfBPQ2OiP697Z0Es2Elc2c DHxl72y9nQdxX6s8AE90xTfeDsInIM0U7a4kQVvEHTsWEgX0dGbTzKbnHo4tORKqy+wB mSVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=no1GEevzvXodm7g+of3lOV2t7HQkBqeRz2KyKjoJ8w0=; b=LDA9q8TcXh3q0M0cB6ruvORXLlZJK8km8kRUmJUKKlEX0lxBWiOjt/9hkZoCRxRJrq SGOB0RNchkS+rAup+5tiFVCbliHHltYCyOUDei4casp9+9sYL7TUgVNwgWAgFJNuJn1m JcPKxxytqdlCN4mU4H5qyvvkF3IxAMXmiVKx/7Xrsg1PchQKuBQOxHYCHeyFiWhlZjMS 3AuM5G4L/gARohSgEvJM2bMJZv8KiCIh0jP1dMQrvwzo8jX9xJS/GyKfJUtUUv8YeZXl jiqkErx9bKALjAG3WIgOJi3H3TcZ1GmQVNT7+B7K5VZDZUuFotA2E1n/BS/QzpBOXW7S 5xmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=G28YEgrg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o9-20020a639209000000b0054294720d55si2341180pgd.262.2023.06.09.01.18.40; Fri, 09 Jun 2023 01:18:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=G28YEgrg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239622AbjFIIQM (ORCPT + 99 others); Fri, 9 Jun 2023 04:16:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240079AbjFIIQI (ORCPT ); Fri, 9 Jun 2023 04:16:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80FBE1FEC; Fri, 9 Jun 2023 01:16:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1E83561300; Fri, 9 Jun 2023 08:16:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 032BBC433D2; Fri, 9 Jun 2023 08:16:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686298566; bh=fhq7UqggYiVg/1COUBVntIvsMJLXIEfwBDhAv2lnM2Y=; h=From:To:Cc:Subject:Date:From; b=G28YEgrgn2lu1p5R3l5ckjxag/p3SQF3AL/dQ4H0P6yHYvymEjeqjKHwgbwZFshiN +DXRcLNePGWkV2wjJrnBHW0MM2SjvfQviBwCjzKym9TF3W1fFrDGOlsAIZf0oxG0X2 JduFSfbl4efpACPpq+1j3w3mxIgKZSwNXjF0npmmIhimGZ0oHhqqgwU0SUIuc6aqUY RpTDqVcnOHAALa+eJ96oS6nDhDofPv2I180Bg2Cgcr3lOvUH2USV88C7EKjrE1mQbF ZxENFHAnMcnAEwFfUFxp90ulbJWi+u/dGJqYWdRIYk8M4PBWi/UKr2msYHnMTexwws EfQr+wvYaOZzQ== From: Arnd Bergmann To: Krzysztof Kozlowski , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd Cc: Arnd Bergmann , Josh Poimboeuf , Alim Akhtar , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] clk: samsung: add CONFIG_OF dependency Date: Fri, 9 Jun 2023 10:15:49 +0200 Message-Id: <20230609081559.915867-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768212383514586896?= X-GMAIL-MSGID: =?utf-8?q?1768212383514586896?= From: Arnd Bergmann When CONFIG_OF is disabled, build testing on x86 runs into a couple of objtool warnings from functions that unconditionally call panic() but have no __noreturn annotation: vmlinux.o: warning: objtool: exynos3250_cmu_isp_probe+0x17: samsung_cmu_register_one() is missing a __noreturn annotation vmlinux.o: warning: objtool: exynos7885_cmu_probe+0x16: exynos_arm64_register_cmu() is missing a __noreturn annotation vmlinux.o: warning: objtool: exynos850_cmu_probe+0x16: exynos_arm64_register_cmu() is missing a __noreturn annotation vmlinux.o: warning: objtool: exynosautov9_cmu_probe+0x16: exynos_arm64_register_cmu() is missing a __noreturn annotation The objtool analysis is correct, and this could be addressed by just returning success whenever CONFIG_OF is disabled to let all that code be eliminated, but since the driver is no use without CONFIG_OF, just add that as a dependency. It will still get compile tested on all architectures since CONFIG_OF is enabled in allmodconfig and most randconfig builds. Cc: Josh Poimboeuf Signed-off-by: Arnd Bergmann --- drivers/clk/samsung/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig index c07bb50513bfe..76a494e95027a 100644 --- a/drivers/clk/samsung/Kconfig +++ b/drivers/clk/samsung/Kconfig @@ -2,6 +2,7 @@ # Recent Exynos platforms should just select COMMON_CLK_SAMSUNG: config COMMON_CLK_SAMSUNG bool "Samsung Exynos clock controller support" if COMPILE_TEST + depends on OF select S3C64XX_COMMON_CLK if ARM && ARCH_S3C64XX select S5PV210_COMMON_CLK if ARM && ARCH_S5PV210 select EXYNOS_3250_COMMON_CLK if ARM && SOC_EXYNOS3250