From patchwork Fri Jun 9 06:09:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 105287 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp739955vqr; Thu, 8 Jun 2023 23:10:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7errGKIhRTIz1Tt61Wp/BlMXG59e4UDRceim/aB9oDiQsCX7vkrHn8nSADvOtVs9ROV2qv X-Received: by 2002:a17:907:320a:b0:974:52e6:93cb with SMTP id xg10-20020a170907320a00b0097452e693cbmr727824ejb.50.1686291045429; Thu, 08 Jun 2023 23:10:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686291045; cv=none; d=google.com; s=arc-20160816; b=Q/T7FL1Jmgu2iQRnyBj1ajnxB/0q8pzmz7GKh1jZrPWqwJKlG8JGGbIyuDQ3lTMvu5 YODNUy5T0kuzDRsLeZfEbXVShDPj4L93OWUQRWpGOc9NSz67xB6yK28UpcHG0N17XCL3 H1L0jm+fD4aFnzfqSx/vrscTFR4AfRH9gioCdNZQNyzOvzURPXQcwDVz1M8Z8exuQVgS aWB89GwpPJiCPlGne3AckELe4eiN/lniHQO3v8y/n0XrW6f/MPoAsTYv7JwdGdbIfAIx b3UgoXP/IAzkgUOvW1hvcmkVckjqHT/fYJluP+I/bGGa9coQ2xDevv/I78cC/4yuucz8 CCvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=AyYrIn46zFrD8bGBd/UZTstgLD7yZ7/BXsKymhSMQUI=; b=BR66frHcqbfb468R+JjkQz/gxQPu9mPBhNz0z1Q8DuM5OYqN2D6aU3RvTDSxbQa7bj ZWStbvgJZ2fT2c2M7hrw7QcoXoBqocyWflmTemJ8jjM4Q9gJ0dP2LoSmoQJa3p24uyIx 15AbmBicLsR3mzQYDQ7yYVNRKyPPsGlpmbgV0QVZ1B+hdrPhkpZNP6p/mFcf326YodI+ l3+eUJlC8yQXXXbgnwVCqY7ZvXL2wIxl7XV0NrZmyD839857zOZm/dJRbV473hldUNXJ NsHUQAOLsLCTcIaYpAjXiDsTuZsbzJOc89pBePqifVqmzNdNHAdeeatUb3aWdhH+44nf refA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=qftKUR9w; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id d23-20020a1709064c5700b00977cdda057bsi901732ejw.337.2023.06.08.23.10.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 23:10:45 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=qftKUR9w; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 54DCC3857726 for ; Fri, 9 Jun 2023 06:10:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 54DCC3857726 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1686291044; bh=AyYrIn46zFrD8bGBd/UZTstgLD7yZ7/BXsKymhSMQUI=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=qftKUR9wycMz+dLNntFuclOjcqNPqSjFIRAvPtSieODXdE2uN2/KzBM2O8ShaW5e7 DS6FOafJb5+0YE15WLCGG+LB/COfuXmZC5GW++Jiahr99baiGEoA+NJp584nQrJdid J9SFVl256NH9qlwKCXFA8d2IJfxmHNscL8wq4BD0= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id D76C83856956 for ; Fri, 9 Jun 2023 06:10:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D76C83856956 Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-64d57cd373fso1031340b3a.1 for ; Thu, 08 Jun 2023 23:10:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686291003; x=1688883003; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AyYrIn46zFrD8bGBd/UZTstgLD7yZ7/BXsKymhSMQUI=; b=fUCTKCH5SUbw6mOyVje/ceglpf5PQJ4lgeiBLpJeGrGFYlEuJ4Ep802encTM1P3EIn e3rrNurRwzWEZQSobHhWgLfkKnqCQlHFuMc2KyAgZcTrC2f0xElvQ6IP8di1tcQR6une zURBjlXSzqj6khG2dhOiaE8ZKCeFld3kItV2FwoS9d8adJPLghmCuV3sfFHurXWMcHLP IS6Mtv4CwP9j0swq7F61WWhZ9xOjbuaT7BcwFk335/jOXOsv2SABMC6oM+08Wb/SDWLb E+oJ1BaZkqHn1BWwHh9dYaYNWy/gotJYmfIMd+Hoyl6tCkXETZQCyeNyd/ZwU9H7ysGP iGGg== X-Gm-Message-State: AC+VfDx+cimGF+vFvHozGgZjBhNrU+2gazsU/hjHFS1QYoJHF/QYEJs1 /PKUJb/qFhcZEwjfGATWq1iSX6JKixk= X-Received: by 2002:a05:6a20:3d24:b0:117:19d1:8385 with SMTP id y36-20020a056a203d2400b0011719d18385mr1014765pzi.20.1686291003362; Thu, 08 Jun 2023 23:10:03 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:659a:55cb:34f7:eeff]) by smtp.gmail.com with ESMTPSA id s22-20020a63e816000000b00519c3475f21sm2185931pgh.46.2023.06.08.23.10.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 23:10:01 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 63A271142C73; Fri, 9 Jun 2023 15:39:57 +0930 (ACST) Date: Fri, 9 Jun 2023 15:39:57 +0930 To: binutils@sourceware.org Subject: readelf/objdump remember_state memory leaks Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3034.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768204319434375092?= X-GMAIL-MSGID: =?utf-8?q?1768204319434375092?= * dwarf.c (display_debug_frames ): Do free invalid remember_state. diff --git a/binutils/dwarf.c b/binutils/dwarf.c index 8a20bf2a349..4f695bf2bca 100644 --- a/binutils/dwarf.c +++ b/binutils/dwarf.c @@ -9823,12 +9823,14 @@ display_debug_frames (struct dwarf_section *section, { warn (_("Invalid column number in saved frame state\n")); fc->ncols = 0; - break; } - memcpy (fc->col_type, rs->col_type, - rs->ncols * sizeof (*rs->col_type)); - memcpy (fc->col_offset, rs->col_offset, - rs->ncols * sizeof (*rs->col_offset)); + else + { + memcpy (fc->col_type, rs->col_type, + rs->ncols * sizeof (*rs->col_type)); + memcpy (fc->col_offset, rs->col_offset, + rs->ncols * sizeof (*rs->col_offset)); + } free (rs->col_type); free (rs->col_offset); free (rs);