From patchwork Fri Jun 9 03:03:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: sunliming X-Patchwork-Id: 105256 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp680092vqr; Thu, 8 Jun 2023 20:08:09 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7GUY58uVMaZcWbCvA/9MTW9DA1M90efV4i1XEFNg2xLQHOFhiqIKp57G5iW6XwdHd3qz5z X-Received: by 2002:a05:6870:b782:b0:1a0:2fd5:116a with SMTP id ed2-20020a056870b78200b001a02fd5116amr232975oab.16.1686280088813; Thu, 08 Jun 2023 20:08:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686280088; cv=none; d=google.com; s=arc-20160816; b=GtZiETgj/wT2O1uFR3dCsY8PEQF9tb3ASKs+CDHL5nhoY+YDX8lE5dz42rKvDVom/y Xwcrcub9zKtgRntjvXdRjVhAj9/IPlZUSfvt/hsHitqq7wXrVqbHh29Fd87oS5GroZOv 09GjUWqdfnqqhYatsrk6gS7n8V9r8xG+aLIlJXRCk//ssNqo3yTP4jfPaIiIRWsQq0Oo VO2dSiXiOcn2IAf/JlggKkhljRnvKVVu7wHwD26fujqvkWuxgYuGuWeQS8GKwQ9EcT3m v7Z0H3ucqbblpAh2qIHPdY8bv0n7/ZBht9souWau6UaxoY4KzQevwhOuPC/u+EYqxJal AEuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=PcKARLPblfhsOqgdK39JcUbv8MjDLZ8IvMWHzSBNScQ=; b=ofO6n+hbtmsavNqgoIJp6jCY5kA3bj4FVb1OP+HqYiMiXte70llcUWZlc1gPtFfpxt mFPhuyRvZfzODZ0xqlZ8ZiKor/dJOkl4xVtjUF9TTAmAJ7GP8mJW3SflhiQ4L7RXGdbS cYOesewoM+lBlBmN2hJyRybs0g0N4LoIpIt94vlx+NpsoTOe3I5cErWO1khcmrCpIimP pxuj7bNflZEQaoWc+0aVuuRzoxODYD7yxigr1nDKnaWkZGWmbhepiDBXuzmkqp8DyWEd Qm5Zo5Fxg3uRCbV03D7pCYGn4KR4zGpnaNqdTRKUvLnIQnPtZj6CCLOfmieHKLUD3xQk 72fg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 24-20020a631258000000b00543c8ad57f3si1840610pgs.82.2023.06.08.20.07.54; Thu, 08 Jun 2023 20:08:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238021AbjFIDEb (ORCPT + 99 others); Thu, 8 Jun 2023 23:04:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237892AbjFIDEW (ORCPT ); Thu, 8 Jun 2023 23:04:22 -0400 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7B4230E8; Thu, 8 Jun 2023 20:04:20 -0700 (PDT) Received: by mail-pf1-f194.google.com with SMTP id d2e1a72fcca58-653f9c7b3e4so1022860b3a.2; Thu, 08 Jun 2023 20:04:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686279860; x=1688871860; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PcKARLPblfhsOqgdK39JcUbv8MjDLZ8IvMWHzSBNScQ=; b=NmRQRMaxM0+7angDvMYYf6yLkZ4m6S9gu+3FQujEUmAoGSOylV6PKKh4c6Rr5Ez0Ny 1ExgMMZLKcL9CadORIpPXlumnAbIvuv5ONAGDtHzrJLy2zEhypmD1W6TMXKmaZ8ji/fI WWNpC10Qzj9NC9zatuV/mWDG8K1OttCaZNgDtqoIoLg8Vssrvr5/8B4Hq5x4Nalcxjp+ EXbfVTPYw/WguXryW26gKXYIwxsoDYzsx3f2Afxz+w8Scx23YXKi64wkshHXbJrrSaLv HuIjjNBG6vGCUYEN4fCbU8RGrGf3EBH20ytxke/lrGB0UciQ+5l1uCoY44kKutqAr5bD b3ug== X-Gm-Message-State: AC+VfDwK6hQWaxghY80Aexe3BgH55bvVUtiDFrSwSRCfFfW8/tAHBfmC vWJC2jD+LBqr5sfogUVWmw== X-Received: by 2002:a05:6a00:1a4e:b0:662:b5de:27f6 with SMTP id h14-20020a056a001a4e00b00662b5de27f6mr52364pfv.17.1686279860393; Thu, 08 Jun 2023 20:04:20 -0700 (PDT) Received: from localhost.localdomain ([116.128.244.169]) by smtp.gmail.com with ESMTPSA id a16-20020a62bd10000000b0065ecdefa57fsm1713778pff.0.2023.06.08.20.04.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 20:04:20 -0700 (PDT) From: sunliming To: mhiramat@kernel.org, beaub@linux.microsoft.com, rostedt@goodmis.org, shuah@kernel.org Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kelulanainsley@gmail.com, sunliming Subject: [PATCH v2 1/3] tracing/user_events: Fix incorrect return value for writing operation when events are disabled Date: Fri, 9 Jun 2023 11:03:00 +0800 Message-Id: <20230609030302.1278716-2-sunliming@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230609030302.1278716-1-sunliming@kylinos.cn> References: <20230609030302.1278716-1-sunliming@kylinos.cn> MIME-Version: 1.0 X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768192830303169462?= X-GMAIL-MSGID: =?utf-8?q?1768192830303169462?= The writing operation return the count of writes whether events are enabled or disabled. This is incorrect when events are disabled. Fix this by just return -ENOENT when events are disabled. Signed-off-by: sunliming --- kernel/trace/trace_events_user.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c index 1ac5ba5685ed..92204bbe79da 100644 --- a/kernel/trace/trace_events_user.c +++ b/kernel/trace/trace_events_user.c @@ -1957,7 +1957,8 @@ static ssize_t user_events_write_core(struct file *file, struct iov_iter *i) if (unlikely(faulted)) return -EFAULT; - } + } else + return -ENOENT; return ret; } From patchwork Fri Jun 9 03:03:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: sunliming X-Patchwork-Id: 105258 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp682023vqr; Thu, 8 Jun 2023 20:14:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ43I4O4rzIKWDFW9M4h2axQ5AXSPQj7bMeueYoKBdyBJmw9Th26gyXrqtI+IAdjq8P81fr5 X-Received: by 2002:a05:6a20:e185:b0:10b:ebf3:839 with SMTP id ks5-20020a056a20e18500b0010bebf30839mr38467pzb.34.1686280468634; Thu, 08 Jun 2023 20:14:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686280468; cv=none; d=google.com; s=arc-20160816; b=SpSD7bCph/v03ASjkc8lj/zo5SxiK0/xD1KpQ6WbXmiN7AfOVOJqF70oLWVKVNWMQr oa9E78c4z5yOU39VPNHQW06UrDlxTYGDx2qfnPa+xGTX1VmL/oMyWUo63p+4z+9+LqVc 7oKYeY7i6u1i1oGiqj0AgIUXFzWfWWDH1c4217HEJ5ub5QgH2KyaRqMMVIUgqES4wAr3 oPoQtIffm7tsFFRK4qvuNAxQykMFUwD0SxsLBg8WKULjrfnc0vZQFlAZVljfz1PPGpyS FL0pX03z2Dl6U8V/RGyGrxXRdUN2E0CBaEd72bXEFMsvC9c2O7vad4Ga7Y6UWmZmNncn 1VSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=UwLBYM4w/H7KoFqtcB4hQtAsyswAe46iM2ztf4QLeWA=; b=Qbx/QThrloDwZ78vLhUEB6yW/Np1JImeRSoWjJdJ0M7aIumF85DmYnfi82Wq/HToqD KDy2f92r0Js0iJkEINhLtS52rDU+HqMqA6GtXsEJHAvrEgzY8UvczVgQsVtV6o97AOnJ H6jfvHJcaGVumVnwEPcgw1Yh7sXeDP+sCdyn/XKl73NkK+e+C30eo18GQHmwZRnyED1J FeQAQmoL5mf+uWLrW/rJSVaf3JphfzOMtN0L7usfpAyANGleq3nySi7hg1yWrMUPBLqJ NGauNFBx/wj7gQw3AF0cCGCylRUzencfMoQR8t2mNO2dbvZ8qZx78ET1tZIwCz/vi3Ab 8tOQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kt11-20020a170903088b00b001afe1f44c02si1960114plb.60.2023.06.08.20.14.16; Thu, 08 Jun 2023 20:14:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238184AbjFIDEt (ORCPT + 99 others); Thu, 8 Jun 2023 23:04:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238017AbjFIDEk (ORCPT ); Thu, 8 Jun 2023 23:04:40 -0400 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 042AA3585; Thu, 8 Jun 2023 20:04:29 -0700 (PDT) Received: by mail-pf1-f196.google.com with SMTP id d2e1a72fcca58-652a6bf4e6aso1078029b3a.2; Thu, 08 Jun 2023 20:04:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686279868; x=1688871868; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UwLBYM4w/H7KoFqtcB4hQtAsyswAe46iM2ztf4QLeWA=; b=lROOdt4xdms5cZbvzHzFnZkxK6pVtpJOXC4vWbX4c7myvkCGJlA+QPFHi59nkES2X2 Wuej1GPd9SAJv0szFXo2I11+BhdzoON5OciEEvv09hECo67sslsHkZOP47BnL0++JXCp HEYIUR/hzUYwsXBYLprdQkScF1+EUn2cNLR6Z0I1yJkK1h5tpXrToxt5tWDkmGfHWyfZ qsqiLK5aCbSJiqV/f4EqwVF5fNv5gtMLzbcYYoFrZdgXHy77+b5fd9FuGmOYLZlXuuc/ IZjpIQub6S790/FH+s9JqGVS/q2gpJ8CHBZ7ugq6KhYyjH4nmoip0Dc44+Wvj6Dl+Sqe f3SQ== X-Gm-Message-State: AC+VfDxylAOKg8KNhQj2Xemlhpip4kmZlCzIATCCWHSQTP/GnfUAAOBj GURT6BGgqjhlvF0lcIG8hQ== X-Received: by 2002:a05:6a00:1254:b0:663:83ad:4809 with SMTP id u20-20020a056a00125400b0066383ad4809mr24615pfi.27.1686279868257; Thu, 08 Jun 2023 20:04:28 -0700 (PDT) Received: from localhost.localdomain ([116.128.244.169]) by smtp.gmail.com with ESMTPSA id a16-20020a62bd10000000b0065ecdefa57fsm1713778pff.0.2023.06.08.20.04.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 20:04:27 -0700 (PDT) From: sunliming To: mhiramat@kernel.org, beaub@linux.microsoft.com, rostedt@goodmis.org, shuah@kernel.org Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kelulanainsley@gmail.com, sunliming Subject: [PATCH v2 2/3] selftests/user_events: Enable the event before write_fault test in ftrace self-test Date: Fri, 9 Jun 2023 11:03:01 +0800 Message-Id: <20230609030302.1278716-3-sunliming@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230609030302.1278716-1-sunliming@kylinos.cn> References: <20230609030302.1278716-1-sunliming@kylinos.cn> MIME-Version: 1.0 X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768193228589933508?= X-GMAIL-MSGID: =?utf-8?q?1768193228589933508?= The user_event has not be enabled in write_fault test in ftrace self-test, Just enable it. Signed-off-by: sunliming --- tools/testing/selftests/user_events/ftrace_test.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/testing/selftests/user_events/ftrace_test.c b/tools/testing/selftests/user_events/ftrace_test.c index abfb49558a26..d33bd31425db 100644 --- a/tools/testing/selftests/user_events/ftrace_test.c +++ b/tools/testing/selftests/user_events/ftrace_test.c @@ -373,6 +373,10 @@ TEST_F(user, write_fault) { ASSERT_EQ(0, ioctl(self->data_fd, DIAG_IOCSREG, ®)); ASSERT_EQ(0, reg.write_index); + /* Enable event */ + self->enable_fd = open(enable_file, O_RDWR); + ASSERT_NE(-1, write(self->enable_fd, "1", sizeof("1"))) + /* Write should work normally */ ASSERT_NE(-1, writev(self->data_fd, (const struct iovec *)io, 2)); From patchwork Fri Jun 9 03:03:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: sunliming X-Patchwork-Id: 105259 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp682068vqr; Thu, 8 Jun 2023 20:14:36 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5McTVKWIYabW0U41znT11SsU8XDhnezBnUMGRKQX7BILxppcxt9DGCiUXkNsnhJ0obXzDz X-Received: by 2002:a05:6808:1446:b0:398:50f1:ad19 with SMTP id x6-20020a056808144600b0039850f1ad19mr392530oiv.39.1686280476552; Thu, 08 Jun 2023 20:14:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686280476; cv=none; d=google.com; s=arc-20160816; b=A/yGio/J2c9OD+HMUlGAcMh4+0tFv4UBmLwLEeOj4b7B/AfpiN3XVMHRBGa8y+V8nf OT+Bdkd+maOkFGS7+FvSuxXtdz9ue6yqvEZq+/aSc/QpHnoV9vs5UNApG6VWoxrncoZS Jl++785mxfBLgZmKabmI7pchI7665c3yySt5SyJlPQtJ7Bq1uyKCx91QzhEZDUVd0OQE +8oYoavhCFSIKZIeKDj1Be+hK8SNzNGIwSB1ghzQF3xLHTD8K5aRVK/B3woXALDoe5iN du7z4Z73ayF2MLgZMOgkf56XrQy3REzyK6U9C6dG5jI89zzhyNChAZdXOY5JTIxb4FHo 00Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ETnK27P5xF7JUmROEHyWwtf42DA9xFAclMKuefb0oy8=; b=mhc1RvwMyk94pAcqs3GBN5MHDObColp2wE6aM7gQWrrU10mR80YeELBrtJoWuglQl1 8HBFpOVqOVilPB6URtC9YLnmlTGqjppnXATh9sba6sSCp6D7Ptn/hJUu+ToUJbpId1oy K7cAmjJWzBKm9syUtJdePTE8sfrYciWYvPJHQEKfqDlhEcnUz9RquNcUJLKTS/6PtFa1 e23XFxwxrSgN0IgyiF0rHJL5uzIK+VuAyvXx64URxRj6wyj0FHxvzBpVv8EvnsdvqZUO zN3VFeBpPv3PpfSnu3YGmK19XE/bQWuQPwq/ie+gC5KAhCFIRRwbQ0zyA3iXDHyx+9H9 aBCg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t3-20020a170902bc4300b001ae38227983si2003259plz.199.2023.06.08.20.14.23; Thu, 08 Jun 2023 20:14:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238305AbjFIDFU (ORCPT + 99 others); Thu, 8 Jun 2023 23:05:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238228AbjFIDEz (ORCPT ); Thu, 8 Jun 2023 23:04:55 -0400 Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14A6D30C3; Thu, 8 Jun 2023 20:04:34 -0700 (PDT) Received: by mail-ot1-f65.google.com with SMTP id 46e09a7af769-6b16cbe4fb6so287553a34.1; Thu, 08 Jun 2023 20:04:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686279873; x=1688871873; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ETnK27P5xF7JUmROEHyWwtf42DA9xFAclMKuefb0oy8=; b=cdwAT6tcq0pwv2adOHav6DgMtseybTtV9/JAEXAgO+FmLlX2sxpQIz6xL/MnP20E4j P28pSrHwoT/HmFuxOkdKGrrDk62OWnS6OfwQtATbN5xEbR2PwncJ6xz5WUYYK852Fr+0 fAPCjsMkQvwvks7REpWhDf5K7YOJ1gV5Skox9W5uoXnXmhi3C3+JoYotU0Yk04gvQAAr qYnJvcJuYkYZhnbRZVwiEO9a7MEW/Ddnj3qemRQODXfin2UbYNthz12jC4M5pLAbnMsf +zqAaQO6C1+w358Dwfvoc2bVAhOCHhprSUWso6/zcWiQuxSzGJcFd/tu9sHruUAWupEC curw== X-Gm-Message-State: AC+VfDyt0qHcUDb1JevCGavg4+M8UmJtTnncexSXBP99sgL3dlwwetqY VCFLAHSKG7SKArqW7gcwgw== X-Received: by 2002:a9d:7858:0:b0:6ab:3367:795b with SMTP id c24-20020a9d7858000000b006ab3367795bmr257752otm.12.1686279873419; Thu, 08 Jun 2023 20:04:33 -0700 (PDT) Received: from localhost.localdomain ([116.128.244.169]) by smtp.gmail.com with ESMTPSA id a16-20020a62bd10000000b0065ecdefa57fsm1713778pff.0.2023.06.08.20.04.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 20:04:33 -0700 (PDT) From: sunliming To: mhiramat@kernel.org, beaub@linux.microsoft.com, rostedt@goodmis.org, shuah@kernel.org Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kelulanainsley@gmail.com, sunliming Subject: [PATCH v2 3/3] selftests/user_events: Add test cases when event is disabled Date: Fri, 9 Jun 2023 11:03:02 +0800 Message-Id: <20230609030302.1278716-4-sunliming@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230609030302.1278716-1-sunliming@kylinos.cn> References: <20230609030302.1278716-1-sunliming@kylinos.cn> MIME-Version: 1.0 X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768193236985301863?= X-GMAIL-MSGID: =?utf-8?q?1768193236985301863?= When user_events are disabled, it's write operation should be fail. Add this test cases. Signed-off-by: sunliming --- tools/testing/selftests/user_events/ftrace_test.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/testing/selftests/user_events/ftrace_test.c b/tools/testing/selftests/user_events/ftrace_test.c index d33bd31425db..cf52789bafda 100644 --- a/tools/testing/selftests/user_events/ftrace_test.c +++ b/tools/testing/selftests/user_events/ftrace_test.c @@ -297,6 +297,10 @@ TEST_F(user, write_events) { io[0].iov_base = ®.write_index; io[0].iov_len = sizeof(reg.write_index); + /* Write should fail when event is not enabled */ + ASSERT_EQ(-1, writev(self->data_fd, (const struct iovec *)io, 3)); + ASSERT_EQ(ENOENT, errno); + /* Enable event */ self->enable_fd = open(enable_file, O_RDWR); ASSERT_NE(-1, write(self->enable_fd, "1", sizeof("1")))