From patchwork Thu Oct 27 03:21:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pin-yen Lin X-Patchwork-Id: 11529 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a40e:b0:83:7221:86ba with SMTP id ck14csp204100dyb; Wed, 26 Oct 2022 20:27:41 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5hKgmAJSf3iJCvj2+8SWJosfHqNhwnqEdEbHFuTyT1vfM83ZNx7b5AVktY5vl8Ggpcsyui X-Received: by 2002:a17:906:dac9:b0:780:ab6f:591f with SMTP id xi9-20020a170906dac900b00780ab6f591fmr40290896ejb.77.1666841261362; Wed, 26 Oct 2022 20:27:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666841261; cv=none; d=google.com; s=arc-20160816; b=npsK2jkUb6UfwXKUL8DZGoSGE+WFiZ55okp3TpsHYlzlVdF2ZvNvhSPKe9tdB8YvgP FxBbphQefDPs3AKvs5cGUrMagpaehcNx66ZJsmgf4ikX4npk2YD3xF80jb7acgd4Vjy0 Ab4kyVK9HftxHIyneKekUlkONH/RsSemV7loGkidOAULXI8hHTMov1EmvzX/TuNDTnSi i0uAbOWJ822Srsj35657Xz1PXbNZAELdSxC5BRHuVheaV4Pncox8n2p8SWQaC8QXmiz9 zZNxF3SaLk6iU8HG94eeyRM6KR9yy5JBfFADHyFPbLz49xMw8KwdABtz0lWyD5wNH61u BmxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=CAdp5j8ulbSqSMP5WhQQ65OXGcxKYysV58XuMaNjzUY=; b=qDoXSwE4veZxT+vcnsBFVkwfyjo9KH+rwG+7w9Bnfliht9PxgQdqfIEKaa0AgI80ya PAPrVMUYerfDt7f4NNFNHAFk9f2T02grpM9oG2IMe6zrEIcQSHeym/EaRKqDopSHmTLO /k+QyVsqlyTWoS0qPzEBSAB7SNL2uwVQ7u3ijGPj/2Cc3PDaFDVn/0Hrr5TRwbhDdSW+ GZ9iFu9Ky8jHFqbas4lyDbbbBFBeeQk1P42d0YBdML4Gxg386qF/oCjNSb3Cqx7ARnUx R79ZanolP3YUbHiDQWtDnXX61QOqU/ttlyGPPeixt3F/pAXZxYt9g+XQ2hrQEy3B46nK YiZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=gy3HWQyv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y18-20020a056402271200b0045cba2d74c3si415759edd.541.2022.10.26.20.27.17; Wed, 26 Oct 2022 20:27:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=gy3HWQyv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229551AbiJ0DWW (ORCPT + 99 others); Wed, 26 Oct 2022 23:22:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233553AbiJ0DWR (ORCPT ); Wed, 26 Oct 2022 23:22:17 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DACCB8FD72 for ; Wed, 26 Oct 2022 20:22:12 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id d59-20020a17090a6f4100b00213202d77e1so4991710pjk.2 for ; Wed, 26 Oct 2022 20:22:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CAdp5j8ulbSqSMP5WhQQ65OXGcxKYysV58XuMaNjzUY=; b=gy3HWQyvWny4e6D1XXtgdsCcjIx6Rzbj2W5EZH2Iy54P7OmKCs88Rlz49SuKony4Jf opZrpoerdjb//gzLAO5Ny+kSF1OSL3hdDDJOqLyHlHs3JfNCDsD3pDo6ZZMEZTZfWyT+ 0QYIUMsF3UdyP9syDq9uDbz0SQqub8LVZBve4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CAdp5j8ulbSqSMP5WhQQ65OXGcxKYysV58XuMaNjzUY=; b=iCCfan5Y55rdyHXvQAdY8DMzTeR8MSIiIv3BO9ofC7CXVYGX6wAxUjy+Ig26Muhl1K KgmR5s6zfRfSVw8z24OwHUnJPHCvc1EexsKsqIK5ohU3z8pQXbkQwCtYSV2sh3FieONY aApZ3Kv69jYZAKNeJmda2aa5Ns1t9wpaSoOMzD/wWr85XoegVEDghHP0WHG9uulhMas7 WcbngljMj1XOfDFjdIW/zIxHrP6cLOqz8DDdXqWbo+jH5rEW4BxvFxQWLRSWq4eT5Z8U j9P/+5O6U9YhrjqvkCsjz5u6CWul/MFAMXVpr2G8oaQqtIslplCUIckAjfjeaxCrBn8L WYMQ== X-Gm-Message-State: ACrzQf2Y2R5AcVwc8pibg2Ehwn5NQArFJvRtbNyOxUDvKEVgvsVbMcBs qWqCYftY7zCSA1RyHbKnrgYjTA== X-Received: by 2002:a17:902:708a:b0:183:88dd:1d36 with SMTP id z10-20020a170902708a00b0018388dd1d36mr45241452plk.166.1666840932382; Wed, 26 Oct 2022 20:22:12 -0700 (PDT) Received: from treapking.tpe.corp.google.com ([2401:fa00:1:10:3790:5571:53c5:e671]) by smtp.gmail.com with ESMTPSA id y129-20020a633287000000b00464aa9ea6fasm62884pgy.20.2022.10.26.20.22.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 20:22:11 -0700 (PDT) From: Pin-yen Lin To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , AngeloGioacchino Del Regno Cc: Pin-yen Lin , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH] drm/bridge: it6505: Fix return value check for pm_runtime_get_sync Date: Thu, 27 Oct 2022 11:21:49 +0800 Message-Id: <20221027032149.2739912-1-treapking@chromium.org> X-Mailer: git-send-email 2.38.0.135.g90850a2211-goog MIME-Version: 1.0 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747809742585114569?= X-GMAIL-MSGID: =?utf-8?q?1747809742585114569?= `pm_runtime_get_sync` may return 1 on success. Fix the `if` statement here to make the code less confusing, even though additional calls to `it6505_poweron` doesn't break anything when it's already powered. This was reported by Dan Carpenter in https://lore.kernel.org/all/Y1fMCs6VnxbDcB41@kili/ Fixes: 10517777d302 ("drm/bridge: it6505: Adapt runtime power management framework") Signed-off-by: Pin-yen Lin Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/bridge/ite-it6505.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c index b929fc766e24..21a9b8422bda 100644 --- a/drivers/gpu/drm/bridge/ite-it6505.c +++ b/drivers/gpu/drm/bridge/ite-it6505.c @@ -2699,7 +2699,7 @@ static void it6505_extcon_work(struct work_struct *work) * pm_runtime_force_resume re-enables runtime power management. * Handling the error here to make sure the bridge is powered on. */ - if (ret) + if (ret < 0) it6505_poweron(it6505); complete_all(&it6505->extcon_completion);