From patchwork Wed Jun 7 14:39:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jerome Neanne X-Patchwork-Id: 104545 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp253237vqr; Wed, 7 Jun 2023 07:47:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6tM+sqZV9w6gVRKVRlrstyG9oEx+vE+qgjBIpctjfoQBsovVL6RYZo9qqbkhUHy6rLwxuB X-Received: by 2002:a05:6a00:414d:b0:646:f971:b179 with SMTP id bv13-20020a056a00414d00b00646f971b179mr8308133pfb.16.1686149243997; Wed, 07 Jun 2023 07:47:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686149243; cv=none; d=google.com; s=arc-20160816; b=vf6vP163qSjtilxi0Fhk27l4nYHSM3DX6IwSw19K4+HnGMaP3SINZba/PVIxIlu1Sh WMnUDIpD8G7OLzBFgusqwXBMS9hvrwf+i4WR5SW2gZEs6rrlTgiZIpVbljUOGDatJLki YM9yDhCT5YLofrSPNVTfKYmeBmZjxlr02DkGVRgSCC+WvydSrqaO+4Tayr4CpgrEF4pR D1XQgica4guO4PHGp7ZfLNzMCVo7P7+RvH/EmV5UY8BIqHXSx2ueD60A7VxrANP+CVmx otjxxO5bFvWgqsahfWIinTUE5B6G9igCQZGduWZsfIITLI4SpAgAfDeFeYo0Qurh5rwz 55nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=CrxwmFyl84EkZ99Fi7aHWrEf0BVcmyyx2qC7ribbpYE=; b=KQ9NsCkTYrPKU/szuIA0zn2wLunstedAxJFHCgbaamV/24cljjXyzbEtO2tzhxoAvL nUJ9kHsLMBwSGqFFmS7elhAV0Ceg/q74KrK4Skbh22GiChDS3N3A1lXnIz32lsYgtgYf UmRQ3k/tZshV1zUtd0HcPcGBU17YXeePYRs37GD3vPtIG6XTSWzsmncGoPDHqi6GfxeK 0ga6KzZ5LMkP4xUjh2sB0JlwC+eQ9NVP5TRCaUHNIxZdwbOSSupyV6gIvsMM6BIjZnqq NrnoLB/25KkW/3528PVWRc9Ng3hezkM5246q8bIib0TLsxjs8rg/9MDZhxDcvgyYVHz4 jFXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20221208.gappssmtp.com header.s=20221208 header.b="MD1yb/zV"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t20-20020a639554000000b0053413a82947si8793174pgn.447.2023.06.07.07.47.11; Wed, 07 Jun 2023 07:47:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20221208.gappssmtp.com header.s=20221208 header.b="MD1yb/zV"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241146AbjFGOjs (ORCPT + 99 others); Wed, 7 Jun 2023 10:39:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241134AbjFGOjn (ORCPT ); Wed, 7 Jun 2023 10:39:43 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A802172E for ; Wed, 7 Jun 2023 07:39:39 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3f7353993cbso5816185e9.0 for ; Wed, 07 Jun 2023 07:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1686148778; x=1688740778; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CrxwmFyl84EkZ99Fi7aHWrEf0BVcmyyx2qC7ribbpYE=; b=MD1yb/zVjYTK/SBHZWnmyzNL3CZtADL/Cb+joQntGmNA5DQRSNcfUqx7F04lFIOkam uXLLRhYQPetJk9Ib42IvyBqwSMRaRbsFr9OovLT+hE93Swav2FmZT/z0RClccRLI2cKg 58wyTZfGCOMuK0DyHmgUd9jqQ3biFBkIvB4Wn/9IuMIyUn4onqccKquketS1kA8vFzf0 Fq5r7CfjBxEl8LQAu9lemU+CNT30F6E6NuVWyrxkpVz5iXqHAL0+Zd+PjV7JGe39cXnu ce3N/sNOBT5MwBplvOD8kjniiyGFEOkBX/hUUjUrVvLKWZZTk6D7Wat8xC8IRQPMv2aP d6Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686148778; x=1688740778; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CrxwmFyl84EkZ99Fi7aHWrEf0BVcmyyx2qC7ribbpYE=; b=cRF98L4OV0sd1pLlwAURB9mgf+0dqYN/or96nQuLobLPnqTOGR709/C/gQUIIYrOon OWps1R9FBR53iV9s89mUi7RJ9UMbUS6LpDI4EdsBzNZIBiJt9c55QQDPj7FP6yNVXBOz fZQQtMt2THq97hRDeQxd9Vpcd6EsVzFgaxCe/xfR4vANxo5evTMnP0x2Vh940egc9oBf PqaQfTS5AhPvZbJfA16P3PeBTd84+XKcb9i2aVAbKwxB63Dav/fRZWtuo1lJ7EGPgS98 nb5ahiMamjmJzM7kZtghC/tIVpSEcZSFdkOIDVoansZQAv7gViwgUvFutqhDQZ3YbCvl JAWQ== X-Gm-Message-State: AC+VfDx43T+wmGt5lXg4yiAlGgTVsLdpjCXeZzVY/rNelBNx5PhY+HqS EsDdrg/uoXrN39q/FaSk6vyMxs/vzvNcKJ/3ZVJIw/8O X-Received: by 2002:a7b:c845:0:b0:3f7:2b61:4c98 with SMTP id c5-20020a7bc845000000b003f72b614c98mr4340657wml.13.1686148777845; Wed, 07 Jun 2023 07:39:37 -0700 (PDT) Received: from [127.0.1.1] (192.201.68.85.rev.sfr.net. [85.68.201.192]) by smtp.gmail.com with ESMTPSA id 24-20020a05600c021800b003f7ea771b5dsm2380720wmi.1.2023.06.07.07.39.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 07:39:37 -0700 (PDT) From: Jerome Neanne Date: Wed, 07 Jun 2023 16:39:31 +0200 Subject: [PATCH v5 1/2] gpio: tps65219: add GPIO support for TPS65219 PMIC MIME-Version: 1.0 Message-Id: <20230511-tps65219-add-gpio-support-v5-1-ebb94281c854@baylibre.com> References: <20230511-tps65219-add-gpio-support-v5-0-ebb94281c854@baylibre.com> In-Reply-To: <20230511-tps65219-add-gpio-support-v5-0-ebb94281c854@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Tony Lindgren , Lee Jones Cc: khilman@baylibre.com, msp@baylibre.com, francesco@dolcini.it, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org, Jonathan Cormier , Jerome Neanne X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1686148775; l=8835; i=jneanne@baylibre.com; s=20230511; h=from:subject:message-id; bh=7Z2jhHXDBqlqeVh9K6h13IPtJSbJ7CGix7zSNhqQauk=; b=RLNM5Gff7cjuJMhzrrbQGWXvFFYNMmc8/z/nsb1ypN5Eqq2KeRUcKuM4dV39JbfL1Zg4hSge/ UgAOfSM0DfqDvVDYYCiMX/0Y1g1FJ3ZsKQWU8j9XeLEfynSCU0ikHO5 X-Developer-Key: i=jneanne@baylibre.com; a=ed25519; pk=5rvbqNoG+28jQjC9/50ToY7TgKWf9rJukuCI8b6jkUo= X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768055629677699810?= X-GMAIL-MSGID: =?utf-8?q?1768055629677699810?= Add support for TPS65219 PMICs GPIO interface. 3 GPIO pins: - GPIO0 only is IO but input mode reserved for MULTI_DEVICE_ENABLE usage. - GPIO1 and GPIO2 are Output only and referred as GPO1 and GPO2 in spec. GPIO0 is statically configured as input or output prior to Linux boot. it is used for MULTI_DEVICE_ENABLE function. This setting is statically configured by NVM. GPIO0 can't be used as a generic GPIO (specification Table 8-34). It's either a GPO when MULTI_DEVICE_EN=0 or a GPI when MULTI_DEVICE_EN=1. Datasheet describes specific usage for non standard GPIO. Datasheet: https://www.ti.com/lit/ds/symlink/tps65219.pdf Co-developed-by: Jonathan Cormier Signed-off-by: Jonathan Cormier Reviewed-by: Linus Walleij Signed-off-by: Jerome Neanne Reviewed-by: Andy Shevchenko --- MAINTAINERS | 1 + drivers/gpio/Kconfig | 16 ++++ drivers/gpio/Makefile | 1 + drivers/gpio/gpio-tps65219.c | 185 +++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 203 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c0cde28c62c6..d912b7465e84 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -15398,6 +15398,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git F: arch/arm/configs/omap2plus_defconfig F: arch/arm/mach-omap2/ F: drivers/bus/ti-sysc.c +F: drivers/gpio/gpio-tps65219.c F: drivers/i2c/busses/i2c-omap.c F: drivers/irqchip/irq-omap-intc.c F: drivers/mfd/*omap*.c diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 5521f060d58e..047af064335d 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -1440,6 +1440,22 @@ config GPIO_TPS65218 Select this option to enable GPIO driver for the TPS65218 chip family. +config GPIO_TPS65219 + tristate "TPS65219 GPIO" + depends on MFD_TPS65219 + default MFD_TPS65219 + help + Select this option to enable GPIO driver for the TPS65219 chip + family. + GPIO0 is statically configured as either input or output prior to + Linux boot. It is used for MULTI_DEVICE_ENABLE function. This setting + is statically configured by NVM. GPIO0 can't be used as a generic + GPIO. It's either a GPO when MULTI_DEVICE_EN=0 or a GPI when + MULTI_DEVICE_EN=1. + + This driver can also be built as a module. If so, the module will be + called gpio_tps65219. + config GPIO_TPS6586X bool "TPS6586X GPIO" depends on MFD_TPS6586X diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile index 20036af3acb1..7843b16f5d59 100644 --- a/drivers/gpio/Makefile +++ b/drivers/gpio/Makefile @@ -160,6 +160,7 @@ obj-$(CONFIG_GPIO_TN48M_CPLD) += gpio-tn48m.o obj-$(CONFIG_GPIO_TPIC2810) += gpio-tpic2810.o obj-$(CONFIG_GPIO_TPS65086) += gpio-tps65086.o obj-$(CONFIG_GPIO_TPS65218) += gpio-tps65218.o +obj-$(CONFIG_GPIO_TPS65219) += gpio-tps65219.o obj-$(CONFIG_GPIO_TPS6586X) += gpio-tps6586x.o obj-$(CONFIG_GPIO_TPS65910) += gpio-tps65910.o obj-$(CONFIG_GPIO_TPS65912) += gpio-tps65912.o diff --git a/drivers/gpio/gpio-tps65219.c b/drivers/gpio/gpio-tps65219.c new file mode 100644 index 000000000000..7b38aa360112 --- /dev/null +++ b/drivers/gpio/gpio-tps65219.c @@ -0,0 +1,185 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * GPIO driver for TI TPS65219 PMICs + * + * Copyright (C) 2022 Texas Instruments Incorporated - http://www.ti.com/ + */ + +#include +#include +#include +#include +#include +#include + +#define TPS65219_GPIO0_DIR_MASK BIT(3) +#define TPS65219_GPIO0_OFFSET 2 +#define TPS65219_GPIO0_IDX 0 +#define TPS65219_GPIO_DIR_IN 1 +#define TPS65219_GPIO_DIR_OUT 0 + +struct tps65219_gpio { + struct gpio_chip gpio_chip; + struct tps65219 *tps; +}; + +static int tps65219_gpio_get_direction(struct gpio_chip *gc, unsigned int offset) +{ + struct tps65219_gpio *gpio = gpiochip_get_data(gc); + int ret, val; + + if (offset != TPS65219_GPIO0_IDX) + return GPIO_LINE_DIRECTION_OUT; + + ret = regmap_read(gpio->tps->regmap, TPS65219_REG_MFP_1_CONFIG, &val); + if (ret) + return ret; + + return !!(val & TPS65219_GPIO0_DIR_MASK); +} + +static int tps65219_gpio_get(struct gpio_chip *gc, unsigned int offset) +{ + struct tps65219_gpio *gpio = gpiochip_get_data(gc); + struct device *dev = gpio->tps->dev; + int ret, val; + + if (offset != TPS65219_GPIO0_IDX) { + dev_err(dev, "GPIO%d is output only, cannot get\n", offset); + return -ENOTSUPP; + } + + ret = regmap_read(gpio->tps->regmap, TPS65219_REG_MFP_CTRL, &val); + if (ret) + return ret; + + ret = !!(val & BIT(TPS65219_MFP_GPIO_STATUS_MASK)); + dev_warn(dev, "GPIO%d = %d, MULTI_DEVICE_ENABLE, not a standard GPIO\n", offset, ret); + + /* + * Depending on NVM config, return an error if direction is output, otherwise the GPIO0 + * status bit. + */ + + if (tps65219_gpio_get_direction(gc, offset) == TPS65219_GPIO_DIR_OUT) + return -ENOTSUPP; + + return ret; +} + +static void tps65219_gpio_set(struct gpio_chip *gc, unsigned int offset, int value) +{ + struct tps65219_gpio *gpio = gpiochip_get_data(gc); + struct device *dev = gpio->tps->dev; + int v, mask, bit; + + bit = (offset == TPS65219_GPIO0_IDX) ? TPS65219_GPIO0_OFFSET : offset - 1; + + mask = BIT(bit); + v = value ? mask : 0; + + if (regmap_update_bits(gpio->tps->regmap, TPS65219_REG_GENERAL_CONFIG, mask, v)) + dev_err(dev, "GPIO%d, set to value %d failed.\n", offset, value); +} + +static int tps65219_gpio_change_direction(struct gpio_chip *gc, unsigned int offset, + unsigned int direction) +{ + struct tps65219_gpio *gpio = gpiochip_get_data(gc); + struct device *dev = gpio->tps->dev; + + /* + * Documentation is stating that GPIO0 direction must not be changed in Linux: + * Table 8-34. MFP_1_CONFIG(3): MULTI_DEVICE_ENABLE, should only be changed in INITIALIZE + * state (prior to ON Request). + * Set statically by NVM, changing direction in application can cause a hang. + * Below can be used for test purpose only. + */ + + if (IS_ENABLED(CONFIG_DEBUG_GPIO)) { + int ret = regmap_update_bits(gpio->tps->regmap, TPS65219_REG_MFP_1_CONFIG, + TPS65219_GPIO0_DIR_MASK, direction); + if (ret) { + dev_err(dev, + "GPIO DEBUG enabled: Fail to change direction to %u for GPIO%d.\n", + direction, offset); + return ret; + } + } + + dev_err(dev, + "GPIO%d direction set by NVM, change to %u failed, not allowed by specification\n", + offset, direction); + + return -ENOTSUPP; +} + +static int tps65219_gpio_direction_input(struct gpio_chip *gc, unsigned int offset) +{ + struct tps65219_gpio *gpio = gpiochip_get_data(gc); + struct device *dev = gpio->tps->dev; + + if (offset != TPS65219_GPIO0_IDX) { + dev_err(dev, "GPIO%d is output only, cannot change to input\n", offset); + return -ENOTSUPP; + } + + if (tps65219_gpio_get_direction(gc, offset) == TPS65219_GPIO_DIR_IN) + return 0; + + return tps65219_gpio_change_direction(gc, offset, TPS65219_GPIO_DIR_IN); +} + +static int tps65219_gpio_direction_output(struct gpio_chip *gc, unsigned int offset, int value) +{ + tps65219_gpio_set(gc, offset, value); + if (offset != TPS65219_GPIO0_IDX) + return 0; + + if (tps65219_gpio_get_direction(gc, offset) == TPS65219_GPIO_DIR_OUT) + return 0; + + return tps65219_gpio_change_direction(gc, offset, TPS65219_GPIO_DIR_OUT); +} + +static const struct gpio_chip tps65219_template_chip = { + .label = "tps65219-gpio", + .owner = THIS_MODULE, + .get_direction = tps65219_gpio_get_direction, + .direction_input = tps65219_gpio_direction_input, + .direction_output = tps65219_gpio_direction_output, + .get = tps65219_gpio_get, + .set = tps65219_gpio_set, + .base = -1, + .ngpio = 3, + .can_sleep = true, +}; + +static int tps65219_gpio_probe(struct platform_device *pdev) +{ + struct tps65219 *tps = dev_get_drvdata(pdev->dev.parent); + struct tps65219_gpio *gpio; + + gpio = devm_kzalloc(&pdev->dev, sizeof(*gpio), GFP_KERNEL); + if (!gpio) + return -ENOMEM; + + gpio->tps = tps; + gpio->gpio_chip = tps65219_template_chip; + gpio->gpio_chip.parent = tps->dev; + + return devm_gpiochip_add_data(&pdev->dev, &gpio->gpio_chip, gpio); +} + +static struct platform_driver tps65219_gpio_driver = { + .driver = { + .name = "tps65219-gpio", + }, + .probe = tps65219_gpio_probe, +}; +module_platform_driver(tps65219_gpio_driver); + +MODULE_ALIAS("platform:tps65219-gpio"); +MODULE_AUTHOR("Jonathan Cormier "); +MODULE_DESCRIPTION("TPS65219 GPIO driver"); +MODULE_LICENSE("GPL"); From patchwork Wed Jun 7 14:39:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jerome Neanne X-Patchwork-Id: 104561 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp263331vqr; Wed, 7 Jun 2023 08:02:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7n/3sULz5XBdmBUD0DDNYQ1Eyos8Ijw1g43cfbMB8uTEelh42b2c/OjQ0KL0KUVsQ0LHkx X-Received: by 2002:a17:903:444:b0:1b1:d39e:28bb with SMTP id iw4-20020a170903044400b001b1d39e28bbmr2239869plb.34.1686150168951; Wed, 07 Jun 2023 08:02:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686150168; cv=none; d=google.com; s=arc-20160816; b=Z4tBVT+aiAnqoGJ3nIltSAPy0ndr42xU7z77FvLWNeji6RMFp677sz/jQ7ChdDRljs zwERSj+rsyn87bn+XzsvxSadci6oReYrQvJpWJ1LqVsmnPSC+uSVmo5e+SPb5hQXi8n1 bAoaYU8TNFibxptrnImVR2zHAW8sW8L/R4q7eb4yB76a1AA4zXEwL4YatyWbGr8N1gEK 119pWdba+ynVO/vnZZPctLMTPVrCGr0u/fPa7dVuSQ2hhvqzQZUBSLknzmwQfM2R2Qxf hwisADbKRYq15zp+uUkZTZASzdUAGILCyEJMVHVrhm8CT+xAswH2TRVGvFvj5WNcf8Mn 5pAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=Oi5cyxzC3+NP4WFp104cxanaFNMsvwaBhA2yhJz87ao=; b=WmhPQ4X55JTAskNL41IpHFI+abQe4A2VzCHvub78iOnm7wDa7rThfGCoOcfwEowelm vuzrxqqSi2wkn/U1g9sdao7Oli+EaEKBjxO76edt8a02sboNAzSteVa4Q+AwEtmx4w4l Xgc6l0rnV/ORMKtRPsH/n3nGyJjK8GenVDe9KeN7gxp1bb+cnQ813fqVMg2Nonkwk0YX DazgRSJs9GNsMGHWzUNSFn2no4RpO07VJkhGaQ/RjfH9YZZfJTIJ3L1GoSgdIaSHChWe 76me3DyEBo0l/iqT7aI02LePnmxdiFBiV6Y4OdYsmJGTz96aRWjdKd3Rdtpf7LHJsMOO UUcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20221208.gappssmtp.com header.s=20221208 header.b="jF5QOH/c"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l5-20020a170903244500b001adb600d4dcsi9275160pls.607.2023.06.07.08.02.32; Wed, 07 Jun 2023 08:02:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20221208.gappssmtp.com header.s=20221208 header.b="jF5QOH/c"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241140AbjFGOjo (ORCPT + 99 others); Wed, 7 Jun 2023 10:39:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241132AbjFGOjm (ORCPT ); Wed, 7 Jun 2023 10:39:42 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B705C19BB for ; Wed, 7 Jun 2023 07:39:40 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-3f7f543fe2fso1519875e9.2 for ; Wed, 07 Jun 2023 07:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1686148779; x=1688740779; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Oi5cyxzC3+NP4WFp104cxanaFNMsvwaBhA2yhJz87ao=; b=jF5QOH/c0RKGOEfIu11USF776tOYIYXFGaBlQIhRPL2IOSHTJekY/Gez2+3VXfbQYv hdKKqjipP0jMEkIKs+E8RkE9x8VbHGl4+qDQZ/3yr64skVCEx4QTCE/WD5xFL83/4/lh cM0hwG3Ely6lSnYH7uMjqdBrn9BjL3kwjwEuWwrbzUDxW/J1oyKbw4O2ndog6eUvsYY/ 27uDixAcZF5Yj/eEyW7WeEPJeoSBuiWjAUD9M6QzdjYLF9R2jUQs/nDrVaZTC5dvXgT7 q25QsVpo1Sgx0UJlXJLnWEGQlOMudqL4xczYj0PTmmvx6nVmoY0v/VnHqLI75R1NDG5O pK0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686148779; x=1688740779; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Oi5cyxzC3+NP4WFp104cxanaFNMsvwaBhA2yhJz87ao=; b=gZ8+E7XosxFycWEr0LKclLxyoFBSRR7YpynOlIOhCQEu3ZzgClj2QR5beSDDFBnhbI NUf6uQOSYm9iB0ckYm15BA4raRrg1f9YJlhqGsl6Au+l1MT3hZBASXsMP1qmfx06eukH Tj8Io4PLhRT3ishCvXCIi5sEM12w+ooLQeeC/J5TBHjYYHXUjwPF/qfksTGnXukd/BBi nvgGdl5+VsI0KiZNquAahhhgrrC9PZ65OVs6OtK7Pt0rtBmMJ6cy+INwN4ML8WZzUtHl mTWG6CmoP22ThoyU0yeyQSTf7gXniCkRfL5fR7lxl2/+64Acq5NL99VE5lg8sY7ekXcc gifQ== X-Gm-Message-State: AC+VfDwCyJlFUXGy62HGZGL4mDTpebuEmQsUI+UA3G1a41bJUn2mRZYY 3DJc1AuboNfSdq3vCrKIh3oey+TFJ1ywSQDpq1AMiU/h X-Received: by 2002:a1c:741a:0:b0:3f7:3991:e12e with SMTP id p26-20020a1c741a000000b003f73991e12emr5015351wmc.1.1686148778884; Wed, 07 Jun 2023 07:39:38 -0700 (PDT) Received: from [127.0.1.1] (192.201.68.85.rev.sfr.net. [85.68.201.192]) by smtp.gmail.com with ESMTPSA id 24-20020a05600c021800b003f7ea771b5dsm2380720wmi.1.2023.06.07.07.39.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 07:39:38 -0700 (PDT) From: Jerome Neanne Date: Wed, 07 Jun 2023 16:39:32 +0200 Subject: [PATCH v5 2/2] mfd: tps65219: Add gpio cell instance MIME-Version: 1.0 Message-Id: <20230511-tps65219-add-gpio-support-v5-2-ebb94281c854@baylibre.com> References: <20230511-tps65219-add-gpio-support-v5-0-ebb94281c854@baylibre.com> In-Reply-To: <20230511-tps65219-add-gpio-support-v5-0-ebb94281c854@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Tony Lindgren , Lee Jones Cc: khilman@baylibre.com, msp@baylibre.com, francesco@dolcini.it, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org, Jonathan Cormier , Jerome Neanne X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1686148775; l=1009; i=jneanne@baylibre.com; s=20230511; h=from:subject:message-id; bh=nMeCcxVhE7+un5EdrNfRU6JWVC4UNE7togljBBNu77I=; b=/dkXVwKJ7qs6DQUwT8EiQ60yjyGUeQyRgvgLRQ/YulBHyErsjPLZHe7kyZKxjMdnPVYYnPz6c xQeN3TTb5D7DdHtDxTbMUaHZW1ZLIrWq27WjrgyX30qgeNoFTbb4wlI X-Developer-Key: i=jneanne@baylibre.com; a=ed25519; pk=5rvbqNoG+28jQjC9/50ToY7TgKWf9rJukuCI8b6jkUo= X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768056599205777940?= X-GMAIL-MSGID: =?utf-8?q?1768056599205777940?= tps65219 PMIC GPIOs are exposed in a standard way: gpiodetect gpiochip0 [tps65219-gpio] (3 lines) tps65219-gpios is incorrect cell name (plural): Changed to tps65219-gpio (singular) Co-developed-by: Jonathan Cormier Signed-off-by: Jonathan Cormier Reviewed-by: Linus Walleij Signed-off-by: Jerome Neanne --- drivers/mfd/tps65219.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/tps65219.c b/drivers/mfd/tps65219.c index 0e402fda206b..e1d090ba4258 100644 --- a/drivers/mfd/tps65219.c +++ b/drivers/mfd/tps65219.c @@ -106,7 +106,7 @@ static const struct mfd_cell tps65219_cells[] = { .resources = tps65219_regulator_resources, .num_resources = ARRAY_SIZE(tps65219_regulator_resources), }, - { .name = "tps65219-gpios", }, + { .name = "tps65219-gpio", }, }; static const struct mfd_cell tps65219_pwrbutton_cell = {