From patchwork Tue Jun 6 08:15:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 103629 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3235917vqr; Tue, 6 Jun 2023 01:30:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7m+y1tMIoCwvFp9UNTJC2kwe2vy+JQX1J91u9KeP0woq/NyczzKQxMfZ78guKKPkSrXTdP X-Received: by 2002:a17:90a:2c85:b0:24d:f59a:d331 with SMTP id n5-20020a17090a2c8500b0024df59ad331mr1246209pjd.26.1686040250517; Tue, 06 Jun 2023 01:30:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686040250; cv=none; d=google.com; s=arc-20160816; b=lSj0hXBwrDiAYZ5AFWK9aKFSUCxDv1sg9qwMShjXRyan3fJaQESp2jGxnw+Ng3SiN3 YY7vtYuAgXrzYC/oHTfKM072rWvBzJcLkGFtZj7YaCWBpNfKr5xLH6PHeitKtlp5ozV7 kC4/HBqyB2F+CYY4kJlgDAYbh5LjmWtsDqzpA0pfgl2bW0PgO3MhdjsKMP4DTCfRr5nz qMpcxz2nMIvWRvgOLueWfAX/TfCnfCk1mwE41OwM6JFASA3PXKSSZKvgi1fqqEGft0yT 5uyueTt3dDMoCaYoR3mGsm3fbyUlvxD1q4XgNbuepVOjhORYQZN5kSmtQ+u+8qyxI6WF O90Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:date:from:dkim-signature; bh=r1ogFYOCyCFggyVGMppR34+8UlfrkJd0gNAyYus2c7g=; b=BvTQxtLTdNlny+J9bR4SVSjJxTpunQ5OWU/LtJMkLCF/s9oZlTNa/Fal/yrsSj7JkB OOKLH83Q2DYrxxFgh5OkLk7tUQktZ4M52UgQq8xvFykvDylT8mLEQPqiytVOaesEyHiP XawjFq0HFGttF+pM9nSsIBDkZ10+BIAMn/UZRZ9rFG0hEuVd9YB+Fx85lQpcF+GdcI6U pYt7jVMUHmLz1ZPh52BsuCVia1ScPP9tN9ivBbTpZS1BOJUV6RV5IAlpXRZHu1lbpE/y fhe+rE5JTlOKgsFenVzCAXM0SiF4kAtmqpOlC2MtsUAYj67br/OdyAnxXXgkFJd7Zcyi +xzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="GaG1+A/1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t19-20020a17090ad51300b0025042fae398si6912184pju.45.2023.06.06.01.30.37; Tue, 06 Jun 2023 01:30:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="GaG1+A/1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236223AbjFFITB (ORCPT + 99 others); Tue, 6 Jun 2023 04:19:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236108AbjFFISr (ORCPT ); Tue, 6 Jun 2023 04:18:47 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69F27E4B for ; Tue, 6 Jun 2023 01:18:45 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-30ae141785bso5717967f8f.3 for ; Tue, 06 Jun 2023 01:18:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686039524; x=1688631524; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :from:to:cc:subject:date:message-id:reply-to; bh=r1ogFYOCyCFggyVGMppR34+8UlfrkJd0gNAyYus2c7g=; b=GaG1+A/1fqB4K0sbQ53AXMdJkSekcvvdxU93FR0Sl4ZGcV9BC4YC12z984o5xqeIg5 wph71hndT/zbGpnrzvhxtJF+EGGdYGwnJ2xPdlRWVAs/rYBKj+97rqjEhYmGkQO9MKJk seJY5gu0yPutMel+ZkqF+QmP4JdVFKcwrLdRkn+CipWJpfwAP9siotUlyUwgSJaXnZoA x6ut+oNptwIz5G6D77TRLkYrrly8eFrnTyzTrdGVTD3u3XfH9U5lwRCzDzvbXcGxkk5P 5KqHgpiSgdUJPCRWP5NaGPOO134PrNqn//fEebmipori8S8WYYue8qHd2zUpbw3i4Oa+ vzhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686039524; x=1688631524; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r1ogFYOCyCFggyVGMppR34+8UlfrkJd0gNAyYus2c7g=; b=kbkIQBAsiSvWkWOvUnT9s8bpHgaLl66dEZBEwNs3poBNjU8gLtbspm/OdN21Bqi1HE zHJuPTQN6rbz30Gf29Csx2WW5N2b769XGc33o+ePv0SKIveICdqvI+Fm1NTx3RgpFs9p 2tbYE/e/EFerxTRlxRkJsx825py9KfFWi6jefdCXGf/ipGYP9N/3HO0GYJlpLLWqBsSB 4ubLrEa6YlM3t8nZAr/bYq21HpMzjm2sIHzS/2XrEBTGQC2ngeVjeA4PD5YoWiHe4LB+ JqIuL0YkP3ahlj2behRxTqgdJauXLLqfRqUzbMRZhOhGHR1UWWXS4CPZehuMKEkLKVd/ lF3g== X-Gm-Message-State: AC+VfDzT0VLnVedze0AQaY1iPSbUWorGxGRTUoHrnECHDdmI9ycROoRP eZKtPz0CpLN/ne0sEQIBsNWRBg== X-Received: by 2002:a5d:40cd:0:b0:30a:eac4:26a0 with SMTP id b13-20020a5d40cd000000b0030aeac426a0mr1150739wrq.18.1686039524012; Tue, 06 Jun 2023 01:18:44 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id m25-20020a7bca59000000b003f7e62d38d4sm4263267wml.25.2023.06.06.01.18.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jun 2023 01:18:42 -0700 (PDT) From: Dan Carpenter X-Google-Original-From: Dan Carpenter Date: Tue, 6 Jun 2023 11:15:46 +0300 To: Michal Simek Cc: Daniel Lezcano , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] clocksource/drivers/timer-cadence-ttc: fix a signedness bug in probe() Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767941341885662112?= X-GMAIL-MSGID: =?utf-8?q?1767941341885662112?= Make the "irq" variable signed so the error handling can work. Fixes: e932900a3279 ("arm: zynq: Use standard timer binding") Signed-off-by: Dan Carpenter --- From static analysis. Untested. Presumably if probe fails the system is unbootable so I didn't bother looking at the resource leaks. drivers/clocksource/timer-cadence-ttc.c:377 ttc_setup_clocksource() warn: 'clk' from clk_prepare_enable() not released on lines: 370. drivers/clocksource/timer-cadence-ttc.c:466 ttc_setup_clockevent() warn: 'clk' from clk_prepare_enable() not released on lines: 466. drivers/clocksource/timer-cadence-ttc.c:529 ttc_timer_probe() warn: 'irq' from irq_of_parse_and_map() not released on lines: 508,516,521,525. drivers/clocksource/timer-cadence-ttc.c:529 ttc_timer_probe() warn: 'timer_baseaddr' from of_iomap() not released on lines: 498,508,516,521,525. --- drivers/clocksource/timer-cadence-ttc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clocksource/timer-cadence-ttc.c b/drivers/clocksource/timer-cadence-ttc.c index 4efd0cf3b602d..8ba1f5c2d7992 100644 --- a/drivers/clocksource/timer-cadence-ttc.c +++ b/drivers/clocksource/timer-cadence-ttc.c @@ -468,13 +468,13 @@ static int __init ttc_setup_clockevent(struct clk *clk, static int __init ttc_timer_probe(struct platform_device *pdev) { - unsigned int irq; void __iomem *timer_baseaddr; struct clk *clk_cs, *clk_ce; static int initialized; int clksel, ret; u32 timer_width = 16; struct device_node *timer = pdev->dev.of_node; + int irq; if (initialized) return 0;