From patchwork Mon Jun 5 18:30:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hamza Mahfooz X-Patchwork-Id: 103438 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2885948vqr; Mon, 5 Jun 2023 11:48:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5sVChAEikWu0eUom4TSs7+p0rcO3Ugualg5wtwjEW8UbqKBpBxFtwWQp+WlcsG0pyPF8qK X-Received: by 2002:a05:620a:271a:b0:75b:23a1:421 with SMTP id b26-20020a05620a271a00b0075b23a10421mr653611qkp.55.1685990937975; Mon, 05 Jun 2023 11:48:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1685990937; cv=pass; d=google.com; s=arc-20160816; b=G3cSG5m24AfuwNWjBWvkbrq8NJolkRDdyR9Er6ewWEr0KGchCaYm8i0FuS7XLRJ8Cs TtKiWIXCHgaMWurRvmnh9UX9g26xh501exEY6Y/Ps+i3dv4NEr7Kvo2JXOyZqmiXuFKZ 9E539CAd/bRdvYZHQnCkx2juSySTNXfYPCJ7xbPb9e2YafjM6obEXg2kxPjbmDCIqQNh V31pxRHNpmaR6sOJq9QudrdljPpP18OH3KnceS08hfKty2xLuZ937K5pGLVnX8LWRhcm Y+HWkJZ0LGjlEhtoF72b94ZGfzHt6BRQgIg1bHaSro7Pmu9ecTR6X8fdVqh12l5updwj d5Dg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=3kzE+nv2w3IJ6pA6dosaCMc5GFlUjjXxgTDlJ4osg6E=; b=p2Q4LbXQzPVrswrNW1gUPKAS+FxfuJYoj1ujBs1nV5mZgGdklLljT5iljWr4yGruXa uAcjroUR0NipXvGeEyqbt5kvPQh/jyuyhHWzARpIyYj7woV+66J7I3dikCf2oI0a8IwX pIK+2BPRukmuEcW3F0Z7HYKbd+r4MIyYlSV72nxEwGzT05dyURg9YVjHaCcOoxkqnPqG kHU5d5uZvixZW1dycKV/VWDjtSJ0joYXDe/1HT4lb7/wjn3DCErmD1f4KymB0KqbBtFb VukKzL2NfYFOzbQyRMsX6LwJgiFJ+zT2qpkiUTHPCh3cwxJ3TTmE30KKnOxFOwFiau59 7PsA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=nCJHIYQ2; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g22-20020a05620a109600b0075ebbd6077bsi1048072qkk.381.2023.06.05.11.48.42; Mon, 05 Jun 2023 11:48:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=nCJHIYQ2; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235153AbjFESat (ORCPT + 99 others); Mon, 5 Jun 2023 14:30:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233756AbjFESaq (ORCPT ); Mon, 5 Jun 2023 14:30:46 -0400 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2045.outbound.protection.outlook.com [40.107.244.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62CC9D3 for ; Mon, 5 Jun 2023 11:30:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MvGkE3yjVtsOfLUuJ/Xzk9+cWcw07fIUS4coOB8r3e9gn6W9KnHkV2F1QLC+okQOabcC+fUZGYYXs+ZsvsycRWgBjaYwTzgn6esoknm4cufEC1pqKrMyycei28FKTw4m/HS+njxWLyQtkzbAiluJ0Tap3bGrNQM09T7eiHZbuXq7iCelZ0dHjkR9NXgZaWY6UOddW0PvQ2TRCUQ073CmYUbnhl6fHNt2I1THamiYFOw1g/lCkY+5EYQYBqmgqTy0P/sctciB7uEJUQUAC9c6BuufZhYD0WikTD7VyVZau0wev2L7vpm7Lb/kemMFN7Z2QX3y1N00IUeqUYytDJs8Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3kzE+nv2w3IJ6pA6dosaCMc5GFlUjjXxgTDlJ4osg6E=; b=anGjcpRaUMTkR5kj7IXJV0zSXiXj410k83RySphuA6eXSB4bJa3Tw02j9Cx9AtYGogncyRghkucxwRMW576X8zXtHtZfpa4ykxizdGpoLla5QKsSm4RjTq2lCE6GLqsrPsf8+zCJV7Mh3UDHJ/VjiwwbeGY1Pc+8eqTI/pCNubDnBwGmEpbJn/kwaf0oUOsvLDg1ZRYAdk8vUSH8UnrfrvLEe9m337OIGEn5QobLjS6RbtAcNr2lQAZFP37QdpkN2Zz6G53HBsuwOPsApG0r5RZ842IKxi4Qmv872TUddiu2dcnlIZJz+J1kcEiSC5rRz1HXlJgeOoUiSfDfdhycUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.freedesktop.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3kzE+nv2w3IJ6pA6dosaCMc5GFlUjjXxgTDlJ4osg6E=; b=nCJHIYQ2GcshyeLwttoewaJcvkbDWPFBHrsftS+jQM5Eu1N3oHKLcm6l5J0RP9tAtdb6vscU383M4vl5lIZfwmQFpl5kGld57LIFTpBtYk6cp/7pH9pNQQF8DenJDVtX65OtpWWFP1JNZQkCAzxIKz+aGaoHTsJVbMiufRFl/DQ= Received: from DS7PR03CA0072.namprd03.prod.outlook.com (2603:10b6:5:3bb::17) by CYYPR12MB8921.namprd12.prod.outlook.com (2603:10b6:930:c7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Mon, 5 Jun 2023 18:30:42 +0000 Received: from DM6NAM11FT038.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3bb:cafe::2e) by DS7PR03CA0072.outlook.office365.com (2603:10b6:5:3bb::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33 via Frontend Transport; Mon, 5 Jun 2023 18:30:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT038.mail.protection.outlook.com (10.13.173.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6455.33 via Frontend Transport; Mon, 5 Jun 2023 18:30:42 +0000 Received: from hamza-pc.localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 5 Jun 2023 13:30:36 -0500 From: Hamza Mahfooz To: CC: Hamza Mahfooz , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , Nathan Chancellor , Nick Desaulniers , Tom Rix , Charlene Liu , Dmytro Laktyushkin , "Paul Hsieh" , Yang Li , =?utf-8?q?Ma=C3=ADra_Canal?= , Nicholas Kazlauskas , Jun Lei , Pavle Kotarac , , , Subject: [PATCH 1/2] drm/amd/display: mark dml31's UseMinimumDCFCLK() as noinline_for_stack Date: Mon, 5 Jun 2023 14:30:04 -0400 Message-ID: <20230605183007.204399-1-hamza.mahfooz@amd.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT038:EE_|CYYPR12MB8921:EE_ X-MS-Office365-Filtering-Correlation-Id: 81f05a18-d0ed-488f-b125-08db65f2f841 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EvTBFpUG9ZGfEMneAAX0da6Wzm/hVhPT4XWRhY12dU5l6BeB0Ujcyg76MjRpszsh+tdkZGoGcNvR7M8wU2zO/0Q3va3/HNM/9SwhamycHUSGZc3PAP3gROtkUMP3dEM+BQ04GWsGwsVa6YydOmL3gf4XBqR/5RlzawVzZrAhv6SNpO1hXKlzt0jB3WoHlSGkcFw8z7gKXuNRm0sJuHpdxANf1DBdnSZeyVJKsIOBvfJXph332SXUEqcF1f5XNec2fVep4T2PFrK5DG/q0wuFvBPA69tiJ5oUMKzZ3ZODXtP6ifRWMMyG6CS17gXSxTfRB18SRHgmhfDbUdZCaMPwVXrKI7DOMFYZ16PnpIfIhmQaOxgvXzpmnYPHTWG+hN0ryQiu9nNRTRCvzvlWFMAJujpxK/TGrJAWNzgO6KGbxUgxiL0s0AHHhmHijFRdZ91TiOHcY55zQb+cu1nfSEZsl0PmuuPSqA5WnHKL9oeAc1/m/aaHKVbEB9KyMNSA8fRofeVv3V+JYnmwQNL1RqvgWVlno4D/OJEZXecMTQzOA3ID7PrO//dc43YzLZm2/0U6ElB8wKAEX18Fwmmy4oZbu+Rx0Jzdrfp2EzIeuihWtVHseeKUPho8WI82xDFeV1KZjTPEKMIh/oOpqANJfax25dmYQKs9YDosf/lL0cYVWzIanFn9Z+rHvsov7fAw4o+J3kwu1iX4EiusMI013xe2Rsi6c/ujI5MbUGcFY+YfKv20brbi8OIMbiqKC3aqJQaTFi42ZX6BmBR6MxGxfLNc2ji6URr+2eUMTznsoueo/A0Ob+WEIvSxpnC+LXUIwOGj X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(39860400002)(376002)(396003)(451199021)(46966006)(40470700004)(36840700001)(8936002)(8676002)(478600001)(54906003)(41300700001)(5660300002)(6666004)(316002)(1076003)(16526019)(26005)(44832011)(7416002)(186003)(4326008)(70206006)(70586007)(6916009)(2616005)(83380400001)(40460700003)(2906002)(47076005)(336012)(426003)(81166007)(356005)(82740400003)(40480700001)(36860700001)(82310400005)(86362001)(36756003)(16060500005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2023 18:30:42.3821 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 81f05a18-d0ed-488f-b125-08db65f2f841 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT038.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8921 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767889633768262753?= X-GMAIL-MSGID: =?utf-8?q?1767889633768262753?= clang reports: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_mode_vba_31.c:3797:6: error: stack frame size (2632) exceeds limit (2048) in 'dml31_ModeSupportAndSystemConfigurationFull' [-Werror,-Wframe-larger-than] 3797 | void dml31_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_lib) | ^ 1 error generated. So, since UseMinimumDCFCLK() consumes a lot of stack space, mark it as noinline_for_stack to prevent it from blowing up dml31_ModeSupportAndSystemConfigurationFull()'s stack size. Signed-off-by: Hamza Mahfooz --- drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c index 01603abd75bb..43016c462251 100644 --- a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c @@ -7032,7 +7032,7 @@ static double CalculateUrgentLatency( return ret; } -static void UseMinimumDCFCLK( +static noinline_for_stack void UseMinimumDCFCLK( struct display_mode_lib *mode_lib, int MaxPrefetchMode, int ReorderingBytes) From patchwork Mon Jun 5 18:30:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hamza Mahfooz X-Patchwork-Id: 103437 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2885868vqr; Mon, 5 Jun 2023 11:48:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ52k46XbbdMbwUR21yYQKLRSQkmaAVNizsbGN3F8QB9yf2PsaVal4tkyA8trvKQm4FjGiGT X-Received: by 2002:a05:6214:528f:b0:5ef:46a9:15d2 with SMTP id kj15-20020a056214528f00b005ef46a915d2mr8622594qvb.7.1685990927740; Mon, 05 Jun 2023 11:48:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1685990927; cv=pass; d=google.com; s=arc-20160816; b=XAXiSFmowS6MUEYwCFcHznHAgsb4XijBsCvpLTXOAGCF7xcofMQ+iS7eVVmpELz7qr P5uDhx9Md5BuPwHfNfOf0VPDV6HFSJL9Apkkf3jTxVenB+EJbVu8bXQOU4cE7YR7BQrF k8MHPuQc2tiFvS8msX1Zx0gguIz+H1br1S+kYNUKTqKWu9xRFKcWIE9iLbNbilSjEErx 2cwDrN6nTnzmCOCBzebQJsIUF5LtIffA1aB5mbtZmaHMENlhWF1aYu5OcOP4Tsdq38Mr vMNtQNevFGaQ3yUR2J/LPBs8whTfgrBOwO14xFVZvjcbWwvefFtEnlSGHqc+fO6Slikm ucUQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=pppZ9m01uGrkWk8pix1ay+7Y+tLg7NlvaxtIw9LKlVw=; b=CG5xeBe8pgN2B0Wqm6E8vFH1dAYeMsosoEhaHwj8QqF/lHjnLus0L9bSB+phuYOtrM BrLgxWYekm/o3z4SlOAwpfjLTxpS1T2kxCJN1HoiAoax/5j9BIpMj4XTElgVKbs3YJm+ s5orvYGcdX+hPc2nN+tdJUptbsYjorQoZEOJqgDk4BK9Y6Ey1mjc9YdwpYkccbW/VfYE mz1aThlI4qnxFt42pDegPdZVQ4jC1veTYCmAHX4Wk6F89MqtzVi17+w+heQ3fHPaNHNI AiwvE1Eqqx+1/7ggP4WaOas9XTanPUyl3mghIBmYCvJNqE+7P66CwhAo+LUXJO1Q3q+B oyYA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=2KHgmpty; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id iv7-20020ad45ce7000000b0062164c72375si5452783qvb.267.2023.06.05.11.48.33; Mon, 05 Jun 2023 11:48:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=2KHgmpty; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234860AbjFESa5 (ORCPT + 99 others); Mon, 5 Jun 2023 14:30:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234931AbjFESar (ORCPT ); Mon, 5 Jun 2023 14:30:47 -0400 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2046.outbound.protection.outlook.com [40.107.100.46]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACECBCD for ; Mon, 5 Jun 2023 11:30:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O+9NnUvFL0EoW9tjtoDo4IV/fFjEcjbxQ4ZXZgWv2xgf3plVQMvVRcUC8paNgnwJxWVMWUYDqpEe7svVc+dvQeSxwR/4noyUNJcUxsfaHnAm6vdP1Qbtcpfjg8YHcsrq51IM+51DhR+1r93ncIu8FAS/bHLfZlJg+tVEpeDEDEjg7vrQZNBzx4DWlEdBOiEzgZw6pEy5cPb2yb9gzCCJiG5XokKTnoB1fT15guSN2bPhODYEJLLFQdsorGOvJB5BhbXzwS4BGZd7xdTBIn/8/bMLAmcXv9MMVVmfVJVIzh4dBtr9x6emH6oU9QTXPALmUFPmdM8afw2eiCk4JOVZDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pppZ9m01uGrkWk8pix1ay+7Y+tLg7NlvaxtIw9LKlVw=; b=QvvVe0ZHyof6FcciGDfVOeoqJzYXp8mn80fXDw0cVcRQYSKTPvkOgvLHXwwwfPYDYUeRYleOR+oFP1Us/vEQF9jneFTWSqnP3j8oCCRpgAv4SI29Fkzm4x1vRO4Zsdw9egAX5W9ZE4FAAjcpVBaYW/znfScG6/EmjYLlsH7C5h9W823KuwoD1nh3V4bK0JlDpyPaTuNEdWzvB0OxX91BdklzKQqxAJu1R0/wx0Uo+c6cjGXomOH0XPHLRdiS/ZpSLRgtjyiPf8eyeb7bwr9+7v3chzOCRAw+c8/T4kqluGLlNcvnM/S6X2IVfkKJAyruARogs3NHLqC59DIeGhM8Pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.freedesktop.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pppZ9m01uGrkWk8pix1ay+7Y+tLg7NlvaxtIw9LKlVw=; b=2KHgmptyNE8yN4+ff/ZDz4ZI5759KkQmljzKTDXtEFA1PirTLJFepdi2kLH1T4fH55Mp/43YygPA/h6WqhQBcO2bHIxw3v8oVKWjCMhgpCYN2pnRrkaeFEFLgVWqcU8OkZpz0G7hjvp91dIhI/J8bPkkoxWJMzF8PR00S7fm6xE= Received: from DM6PR06CA0019.namprd06.prod.outlook.com (2603:10b6:5:120::32) by DM4PR12MB6062.namprd12.prod.outlook.com (2603:10b6:8:b2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Mon, 5 Jun 2023 18:30:43 +0000 Received: from DM6NAM11FT113.eop-nam11.prod.protection.outlook.com (2603:10b6:5:120:cafe::cb) by DM6PR06CA0019.outlook.office365.com (2603:10b6:5:120::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33 via Frontend Transport; Mon, 5 Jun 2023 18:30:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT113.mail.protection.outlook.com (10.13.173.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6455.33 via Frontend Transport; Mon, 5 Jun 2023 18:30:43 +0000 Received: from hamza-pc.localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 5 Jun 2023 13:30:41 -0500 From: Hamza Mahfooz To: CC: Hamza Mahfooz , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , Nathan Chancellor , Nick Desaulniers , Tom Rix , Charlene Liu , Dmytro Laktyushkin , "Paul Hsieh" , Aric Cyr , =?utf-8?q?M?= =?utf-8?q?a=C3=ADra_Canal?= , Nicholas Kazlauskas , Jun Lei , Qingqing Zhuo , , , Subject: [PATCH 2/2] drm/amd/display: mark dml314's UseMinimumDCFCLK() as noinline_for_stack Date: Mon, 5 Jun 2023 14:30:05 -0400 Message-ID: <20230605183007.204399-2-hamza.mahfooz@amd.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230605183007.204399-1-hamza.mahfooz@amd.com> References: <20230605183007.204399-1-hamza.mahfooz@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT113:EE_|DM4PR12MB6062:EE_ X-MS-Office365-Filtering-Correlation-Id: e407c002-ce7e-4afc-5c13-08db65f2f8ed X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eGLibnA3SNv38TYgXc9CR/CbnCnLXNTC5fwvBRo60CVfht3+xvAVDnlGDe2YzXgWki45KVnnvxDwrn4sKhhhyMC1zRiw+CqVVKOo4SgRtwvs0HwdDUQ5ASiSASDRXKHsEW4GjcT1qTTJCW5zSwCqG85dcia+c2i4HKT+sK8/3gHH3s67/A6oMLkqQkjkWZm51/rc2zZnhe3Q10bVALlO8Ef7oTPXEjpRghEl25lRbxFh5sFVbhUPogSDyWmTpapkzIdh3wsIi1MtsGekV2ntiOC5ag7joPyvnbp8EF2DI2XEbkK0bbh8O4F4BobpR/iOPscNJ1FWh2mFGNDR2mAZFPC0IJGbkGdUhsf7jMOHmjuDFF2EIOQODSrhQ7ShPlsxvh3ff8+3EHBgiPxbLWCS5837ifIC3GPElUa3xZunF3j8/KpCa7qKY22K19utt+dxsThB34WKAHt8alt3buc1XLPkTwHePwuCsvcLVivhZOrf7sEk5MZZGP+y3wWo63WUHN2Kaa5gUbG3LH/V+5qUV9r3bcPmrQWiZDLtMx22NxTbkNlSusi9zgziIStHDP7B4VdloQN7SEGeIWJ3Rc2dftWlnv/rnRgVHCAtiEH0oDd60AkIlzqAteIoEQof3rNd5oGo+IHtwOu+JSW4lWSA5cYTp0adyNXsW+kQzxvzzpnLzu+jmHjrr8/DaVyzrlYZPWnyt2eJdU9MKpeopYnPenrsn4L7GNLa7u4PA1W1sDyshSUU/p4TQD5WgRCEtdhsBj9rMZCOFnDlHAJ4zPnlmpNvsyJEklBFZgElr6gAtSqY9X8g7f/cAY9gsNm5Xkod X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(376002)(346002)(396003)(451199021)(40470700004)(46966006)(36840700001)(83380400001)(186003)(40460700003)(47076005)(336012)(426003)(2906002)(2616005)(36756003)(86362001)(82310400005)(81166007)(356005)(82740400003)(36860700001)(40480700001)(316002)(41300700001)(6666004)(5660300002)(8936002)(8676002)(54906003)(478600001)(6916009)(4326008)(70586007)(70206006)(26005)(1076003)(16526019)(7416002)(44832011)(36900700001)(16060500005);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2023 18:30:43.5072 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e407c002-ce7e-4afc-5c13-08db65f2f8ed X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT113.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6062 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767889622942992078?= X-GMAIL-MSGID: =?utf-8?q?1767889622942992078?= clang reports: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_mode_vba_314.c:3892:6: error: stack frame size (2632) exceeds limit (2048) in 'dml314_ModeSupportAndSystemConfigurationFull' [-Werror,-Wframe-larger-than] 3892 | void dml314_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_lib) | ^ 1 error generated. So, since UseMinimumDCFCLK() consumes a lot of stack space, mark it as noinline_for_stack to prevent it from blowing up dml314_ModeSupportAndSystemConfigurationFull()'s stack size. Signed-off-by: Hamza Mahfooz Acked-by: Alex Deucher --- .../gpu/drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c index 27b83162ae45..1532a7e0ed6c 100644 --- a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c @@ -7061,7 +7061,7 @@ static double CalculateUrgentLatency( return ret; } -static void UseMinimumDCFCLK( +static noinline_for_stack void UseMinimumDCFCLK( struct display_mode_lib *mode_lib, int MaxPrefetchMode, int ReorderingBytes)