From patchwork Fri Jun 2 13:50:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102573 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1057840vqr; Fri, 2 Jun 2023 07:12:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4XrIYAvOZpqG8k+QnAWEcEO99KcVQ2W0Y2ogby+KwRb/wi3Wb9IMmbBJuETAvZVRg3IWR6 X-Received: by 2002:a17:902:f68a:b0:1a6:71b1:a0b9 with SMTP id l10-20020a170902f68a00b001a671b1a0b9mr66742plg.47.1685715137175; Fri, 02 Jun 2023 07:12:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685715137; cv=none; d=google.com; s=arc-20160816; b=aNDLNZsPNLfFvQ2E9O3qHAmfqL+ExGW3lMtfijSLkXdjHJjVgRv+n25JC+IDJltDrZ p5rM+B83tesmh5KybSqqF+m6NdKPEReI6AARDIFbaMBG+QeSBCqdz8x0s8W+6idyI10k dJO9lKtxQE16IKsiAaAu+2qKNsaTidWPW1cYpWLs0sFe+V3wAnGNHzVs3mGGt4UwI6oB 5BFlF3q2gKsdtyVNKeEDkWEk1sKQjJeA7SyRvYgyXAtGH58kapSdDuM4zFXEzIV660uP 6n8Wkn2FZz7um54+TrY7tKih/dVHhHk80YIPQAW2aS8idUTzebGRLBErkIk904ANacoR Aeig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=y7pqZuXb/bgwaJTja55aeHuQtUDrvAB4eTr+2EXEou0=; b=otA+TC6vRfMs7KWf+E5Jo+YGFL5iQTJ5lNi3m0XVYKwIYQ4pCENJB4NVf/M8I+u/ta r7Ix/ymZJEghZQ2QeyQibJsWUbERunUh0frN8qX/V78OTM0E/Bnq2Bal8Pve76UDmR4R D9+E5Cr/RSSZFlc6f2z0ToJuiNr6XQWZyK+iqxSBHiJfbu2ErrFUp04LKOfCxTLJq3Hr ig7SniATi+Y4I/8qMKX7Aoi8nNLecvZrfCS1NiU0KW39Lo6ri0cY0wBrvtI5vafU1L5l 48s+fYidzANpsX62Onqrge55QX4FxMAWDScGDe5LHVywAxYgR3G0BW5NsVKbVji7RBS5 Obtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ImH0SK4x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c10-20020a170903234a00b001ac47a1578asi1015045plh.232.2023.06.02.07.11.54; Fri, 02 Jun 2023 07:12:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ImH0SK4x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235885AbjFBNvk (ORCPT + 99 others); Fri, 2 Jun 2023 09:51:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232213AbjFBNvi (ORCPT ); Fri, 2 Jun 2023 09:51:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 060D1137 for ; Fri, 2 Jun 2023 06:51:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 97DD26100A for ; Fri, 2 Jun 2023 13:51:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1BA4C433D2; Fri, 2 Jun 2023 13:51:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685713897; bh=+FsSpx9RH7B04NclB3EiDSdjh3wRRkb9YV3Jl0GU0lc=; h=From:To:Cc:Subject:Date:From; b=ImH0SK4xMGhP5BS50S2vxwDTc+bpUVKnvvZjh7vAUdBlhNZMJysg3FXiYW8H6EkN/ UgkvcuTKbQqVz4wvwQ3QO8S6g9oVMGJSyyvWTGmlUOLe/0/dE+18ECounmjtPb4diM mRHFBW5qp2ooJ2KsVn7pbkE+867c5SoCklzFvLUpKQV/tB/dXZloj6Kf5hf6Occ6mw Zb1mGaUEITebvwkKJ9px3QU6VoCROvvl0mTAgxRbUgkAdsFxG2Qc9zlL20muWFexkn aFAc/sr/8x5vtC5yCu2zBulNEG0XNwTUZxPakRGMIa9OtNDsR7GMzjgGGFXiOoMHTN qSHCZ4+FSD2MA== From: Arnd Bergmann To: Yonghong Song , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko Cc: Arnd Bergmann , John Fastabend , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , "Jason A. Donenfeld" , bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] [v3] bpf: hide unused bpf_patch_call_args Date: Fri, 2 Jun 2023 15:50:18 +0200 Message-Id: <20230602135128.1498362-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767600435936767425?= X-GMAIL-MSGID: =?utf-8?q?1767600435936767425?= From: Arnd Bergmann This function is only used when CONFIG_BPF_JIT_ALWAYS_ON is disabled, but CONFIG_BPF_SYSCALL is enabled. When both are turned off, the prototype is missing but the unused function is still compiled, as seen from this W=1 warning: kernel/bpf/core.c:2075:6: error: no previous prototype for 'bpf_patch_call_args' [-Werror=missing-prototypes] Add a matching #ifdef for the definition to leave it out. Signed-off-by: Arnd Bergmann Acked-by: Yonghong Song --- v3: fix incorrect changelog text v2: change indentation to align arguments better. Still not great as the line is just too long --- kernel/bpf/core.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c index 7421487422d48..0926714641eb5 100644 --- a/kernel/bpf/core.c +++ b/kernel/bpf/core.c @@ -2064,14 +2064,16 @@ EVAL4(PROG_NAME_LIST, 416, 448, 480, 512) }; #undef PROG_NAME_LIST #define PROG_NAME_LIST(stack_size) PROG_NAME_ARGS(stack_size), -static u64 (*interpreters_args[])(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5, - const struct bpf_insn *insn) = { +static __maybe_unused +u64 (*interpreters_args[])(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5, + const struct bpf_insn *insn) = { EVAL6(PROG_NAME_LIST, 32, 64, 96, 128, 160, 192) EVAL6(PROG_NAME_LIST, 224, 256, 288, 320, 352, 384) EVAL4(PROG_NAME_LIST, 416, 448, 480, 512) }; #undef PROG_NAME_LIST +#ifdef CONFIG_BPF_SYSCALL void bpf_patch_call_args(struct bpf_insn *insn, u32 stack_depth) { stack_depth = max_t(u32, stack_depth, 1); @@ -2080,6 +2082,7 @@ void bpf_patch_call_args(struct bpf_insn *insn, u32 stack_depth) __bpf_call_base_args; insn->code = BPF_JMP | BPF_CALL_ARGS; } +#endif #else static unsigned int __bpf_prog_ret0_warn(const void *ctx, From patchwork Fri Jun 2 13:50:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102572 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1054343vqr; Fri, 2 Jun 2023 07:07:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4ba9NlwUELL9p7h0Yr9DH/jTXKj1CSs8yEYzAAsTGob3AM95tznO3exOipou+fNjQlgeVq X-Received: by 2002:a05:6a20:550:b0:110:f66c:a0f0 with SMTP id 16-20020a056a20055000b00110f66ca0f0mr10643512pzq.10.1685714864025; Fri, 02 Jun 2023 07:07:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685714864; cv=none; d=google.com; s=arc-20160816; b=WQrYgA1aMgblTc9kAQCql59yl6PC3XqpReW+DAI/SAqnPNCjpBg+DTnAJIRGXJHiKf sVMLaAPhLNSfgJeDJpDVTW6KQmu4EGWwB8ebhw4TakN7TrfnqDhmzHzh1NTpiGLk1fiT o89+o5CvVXYnHygPcIOSv5h1FwA6gRbMMSR5cmXzWqyIrOkzGlBr+DUpyHWK+VQYwsz/ XRQV59fksV0FcRLOq0EjNfMuGkQ3GWgCx7dWpqJQq/5ec8JLRikCwDrd7NyCz8HcvM54 m/ivDEpWsjDZmTo2H2sXkCVXfhHx6yod/CRjFPv2LwCpZlOFxq/VHuvAzWz0e+stYPvj zlSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=nS76LflZoCsRPpoWomz1tsHOnbwa0vyBLre9ZzXScRs=; b=ZN3KdvQGfsC5REvkOTB0bjwHOwdMUxPC0X7MBZXhWXwBxnVNMTlPBrHR9AWg7e1Yh6 BrSg9kfzxZD0o4KhseO9TdmTIXvxmA2++96qZhLBbyXFWz6nH0Q9luZ6GwR8JCXW680u Ed7LUsopR3AXZpyP9h9RsIjlF9p0/BUumGjRp0QGdOS7QxMy13gIB/rWKT8erZIfWMzo PrfZXqF6NC3HATV4s4GCgZvzywF5bo7Ems7TpUKMRHtw6iB4TeQjnFSu8lrEmCjBhrm2 fUpvDqwzqCZGv+oxg8YrFY6HGE1T+0EsDuGmnZjrFLP6DFkaZ9tWemQQjVqVjqaRMDbu KHiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iftz4zlb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q15-20020a638c4f000000b0050bf22172d3si808021pgn.490.2023.06.02.07.07.23; Fri, 02 Jun 2023 07:07:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iftz4zlb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235929AbjFBNwB (ORCPT + 99 others); Fri, 2 Jun 2023 09:52:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235912AbjFBNv7 (ORCPT ); Fri, 2 Jun 2023 09:51:59 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 640C31BB; Fri, 2 Jun 2023 06:51:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E609F650A4; Fri, 2 Jun 2023 13:51:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 239A4C433D2; Fri, 2 Jun 2023 13:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685713916; bh=8hDakrUZAZcYTZfGnQ3DNtCp7igSQOT1sESi2A5X7JQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iftz4zlbGT83MJweTTJpH3wQdggzYX6b+QAx9Koo1cv+16rmDoY0nvXO6m3xj06gj lFhzkTunQOpyko5GnC4nfOhIHj0SkwImYV4qStyONP6+MJKD0dulfUFetxSZe67aM7 OPzMQ8lUQagZ5mhexu5mPM8oUZ4Hw5WftHXsVwsRSapgjTRKvcG0sUatLogGT9Gndk GsEKI6E55mt4WjfPQBgknPAfxt6v2njHB9PZzPFQ1nhCz+KZYC939jBFpWEAJ2q3Ib W/rzdigetrW5OnLbh9inqnOBhVFXERpFmS/veBTt+MblQ1zwbPw7WBODQVTgySSLp4 LV91jautrX54g== From: Arnd Bergmann To: Yonghong Song , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Song Liu , Steven Rostedt , Masami Hiramatsu Cc: Arnd Bergmann , stable@vger.kernel.org, John Fastabend , Martin KaFai Lau , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Kumar Kartikeya Dwivedi , Dave Marchevsky , Delyan Kratunov , Joanne Koong , Peter Zijlstra , "Jason A. Donenfeld" , Roberto Sassu , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH 2/2] [v3] bpf: fix bpf_probe_read_kernel prototype mismatch Date: Fri, 2 Jun 2023 15:50:19 +0200 Message-Id: <20230602135128.1498362-2-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230602135128.1498362-1-arnd@kernel.org> References: <20230602135128.1498362-1-arnd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767600149218771218?= X-GMAIL-MSGID: =?utf-8?q?1767600149218771218?= From: Arnd Bergmann bpf_probe_read_kernel() has a __weak definition in core.c and another definition with an incompatible prototype in kernel/trace/bpf_trace.c, when CONFIG_BPF_EVENTS is enabled. Since the two are incompatible, there cannot be a shared declaration in a header file, but the lack of a prototype causes a W=1 warning: kernel/bpf/core.c:1638:12: error: no previous prototype for 'bpf_probe_read_kernel' [-Werror=missing-prototypes] On 32-bit architectures, the local prototype u64 __weak bpf_probe_read_kernel(void *dst, u32 size, const void *unsafe_ptr) passes arguments in other registers as the one in bpf_trace.c BPF_CALL_3(bpf_probe_read_kernel, void *, dst, u32, size, const void *, unsafe_ptr) which uses 64-bit arguments in pairs of registers. Change the core.c file to only reference the inner bpf_probe_read_kernel_common() helper and provide a prototype for that, to ensure this is compatible with both definitions. Cc: stable@vger.kernel.org Signed-off-by: Arnd Bergmann Acked-by: Yonghong Song --- v3: clarify changelog text further. v2: rewrite completely to fix the mismatch. --- include/linux/bpf.h | 2 ++ kernel/bpf/core.c | 9 ++++++--- kernel/trace/bpf_trace.c | 3 +-- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/include/linux/bpf.h b/include/linux/bpf.h index f58895830adae..55826398acfba 100644 --- a/include/linux/bpf.h +++ b/include/linux/bpf.h @@ -2619,6 +2619,8 @@ static inline void bpf_dynptr_set_rdonly(struct bpf_dynptr_kern *ptr) } #endif /* CONFIG_BPF_SYSCALL */ +int bpf_probe_read_kernel_common(void *dst, u32 size, const void *unsafe_ptr); + void __bpf_free_used_btfs(struct bpf_prog_aux *aux, struct btf_mod_pair *used_btfs, u32 len); diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c index 0926714641eb5..565ef6950c7a8 100644 --- a/kernel/bpf/core.c +++ b/kernel/bpf/core.c @@ -35,6 +35,7 @@ #include #include #include +#include #include #include @@ -1635,11 +1636,13 @@ bool bpf_opcode_in_insntable(u8 code) } #ifndef CONFIG_BPF_JIT_ALWAYS_ON -u64 __weak bpf_probe_read_kernel(void *dst, u32 size, const void *unsafe_ptr) +#ifndef CONFIG_BPF_EVENTS +int bpf_probe_read_kernel_common(void *dst, u32 size, const void *unsafe_ptr) { memset(dst, 0, size); return -EFAULT; } +#endif /** * ___bpf_prog_run - run eBPF program on a given context @@ -1931,8 +1934,8 @@ static u64 ___bpf_prog_run(u64 *regs, const struct bpf_insn *insn) DST = *(SIZE *)(unsigned long) (SRC + insn->off); \ CONT; \ LDX_PROBE_MEM_##SIZEOP: \ - bpf_probe_read_kernel(&DST, sizeof(SIZE), \ - (const void *)(long) (SRC + insn->off)); \ + bpf_probe_read_kernel_common(&DST, sizeof(SIZE), \ + (const void *)(long) (SRC + insn->off)); \ DST = *((SIZE *)&DST); \ CONT; diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c index 2bc41e6ac9fe0..290fdce2ce535 100644 --- a/kernel/trace/bpf_trace.c +++ b/kernel/trace/bpf_trace.c @@ -223,8 +223,7 @@ const struct bpf_func_proto bpf_probe_read_user_str_proto = { .arg3_type = ARG_ANYTHING, }; -static __always_inline int -bpf_probe_read_kernel_common(void *dst, u32 size, const void *unsafe_ptr) +int bpf_probe_read_kernel_common(void *dst, u32 size, const void *unsafe_ptr) { int ret;