From patchwork Fri Jun 2 11:52:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Schiffer X-Patchwork-Id: 102517 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp971265vqr; Fri, 2 Jun 2023 05:00:32 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4V8DGM9lWBAMfqmz2omYwSNZWNRZx2bPL0hCFH1XzsSuj0aOQ8o+R7kf2Z8YmSX8ORne3R X-Received: by 2002:a05:6a00:10c4:b0:646:663a:9d60 with SMTP id d4-20020a056a0010c400b00646663a9d60mr9360396pfu.10.1685707231620; Fri, 02 Jun 2023 05:00:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685707231; cv=none; d=google.com; s=arc-20160816; b=Id7zuLqg3KZ2NmrFE7C+a6yeRPfWQCr31c4RGsrvu0qhGLjl+ds0/X1A5HBj+oRtHZ njxjsGVzxzGJTKEsgq3mC4PulKTfBhNj1vlTYjWDJZW3UP4+4DWHvaFLT+vW6S1qMwyo fsswPx3MIEDvxqZyDRQD3XvZ4waLxA/PLXOobNVF44+Tl//1aqFgNF4N7pjmuX8j9Bk9 B6XcFrIXuY35tcpGlNx/hJOz9caqy0hBNU9GdhYJdVC7yHm10Mav6z87vHR3jefAi25O sCIdXZKq2FwE6CXeO+X/+rUokKAGRCCqEi3nOc5ILzW28c8PRB8u7+d0M4rgPIjXG3EY NxHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-signature; bh=LABoMO8CCV2HXsLiDgIjvxsb0uweZP5XENgJqsudm+M=; b=F+TgH6G/6kgC5YHEZ/TwgpGrnk3DjFX3J7cxMyd5rPTuFfnvdr1yIduQesu5oC6oq5 SScXkc7g51jI3ISeUvI3CObrDtPH2n6ywwhOw4BWTgU/K05petqA4WHNI6Gu7ZvClNBm uIb2Eio1JgQMSCCd/jG1/xKN6Ge0IyyFaeEqrIk65gOEKUgys5EEgYa02wD1lvftY342 5R4ZuEoGyy9Ao2ibML2zLSgps1IkIuULuYEZ+WjUHb0pXdtuIlRXOH6Ydn2SRcMJjaZm EjlGzcFsMNOnMffUPFJXuB17UJ7IsRNW6igxqSYgjdDM1nqHqIpjU+gVLBFRDaX6W1Yf 9J8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tq-group.com header.s=key1 header.b=CwLTX5Bo; dkim=pass header.i=@tq-group.com header.s=key1 header.b=aTqFSHMR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=tq-group.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p16-20020aa79e90000000b0064cce871b49si659877pfq.137.2023.06.02.05.00.13; Fri, 02 Jun 2023 05:00:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@tq-group.com header.s=key1 header.b=CwLTX5Bo; dkim=pass header.i=@tq-group.com header.s=key1 header.b=aTqFSHMR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=tq-group.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235266AbjFBLyi (ORCPT + 99 others); Fri, 2 Jun 2023 07:54:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234587AbjFBLyh (ORCPT ); Fri, 2 Jun 2023 07:54:37 -0400 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D53E41BB; Fri, 2 Jun 2023 04:54:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1685706843; x=1717242843; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=LABoMO8CCV2HXsLiDgIjvxsb0uweZP5XENgJqsudm+M=; b=CwLTX5Bof1On4jMTpMzQCh0KwHFrTHV0KI3gJXCwKSCjKyLMoD6XZRJH ocWJqbeWSWAR2E5QJg7HWK4jNqzghCAPevqUd1j78tPLI2FiGY8JWvfa+ ALaS4uT2+2ROK/Ji7u1RIkfzZzSxAwRBQFrdqA9SacTeQi39NP4bl+ZW7 Sul80Oj5TnG+gXSkcI+Dpb90V2inwQlgTmu2jd8nmha6Y5ew9H2IcqsLN 01+ejvfz2+mC9yTJ52efJjGgiqKA63hdkLrKo4WPG+rS+EMTUB1eCrfVp prd8u1PGVAhnN7ER6A3IbvnVzYfCTb351lGgYvLA0u9RP0crf/Hl5uQHJ A==; X-IronPort-AV: E=Sophos;i="6.00,212,1681164000"; d="scan'208";a="31246992" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 02 Jun 2023 13:52:40 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 02 Jun 2023 13:52:40 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 02 Jun 2023 13:52:40 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1685706760; x=1717242760; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=LABoMO8CCV2HXsLiDgIjvxsb0uweZP5XENgJqsudm+M=; b=aTqFSHMRk3De/cHHxAvUPin7+/VybecWvYZ4dpNbElfpKMxbfpFWLyT6 130G6ZGi+hgqKgacfp8pka2AL8UsqyJJiJgEJSfjh+5kNdgirut8/rohF v9iS43h1/Lo3XZNgw1hOFTZiy1+JJKYWVKkRn74f+mJABPm+ujG84sxHE yoDVAy2M1GrSPP1uKydl1O39GqVKb0k4Xtpf/aaAIIjS7w7XfxgcdzMLx qoHipIotnKeCYqNL1qjxp1420RrQpKXJKGu+p5S/eG3W7zNBvE62P0ko1 mDcLBzMum9nwBgKUmXzqtUW0eLIJEK9zHFrLelmwa/fnaYY3Bcg2W+Y1X A==; X-IronPort-AV: E=Sophos;i="6.00,212,1681164000"; d="scan'208";a="31246991" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 02 Jun 2023 13:52:40 +0200 Received: from localhost.localdomain (unknown [192.168.66.223]) by vtuxmail01.tq-net.de (Postfix) with ESMTPA id DA2F4280087; Fri, 2 Jun 2023 13:52:39 +0200 (CEST) X-CheckPoint: {6479D7FA-2C-AA2CB662-E129E996} X-MAIL-CPID: AA5DA1E75EDCD4A6141B319D63173EDC_3 X-Control-Analysis: str=0001.0A782F1E.6479D808.0020,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 From: Matthias Schiffer To: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij Cc: linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux@ew.tq-group.com, Matthias Schiffer Subject: [PATCH 1/2] spi: dt-bindings: introduce linux,use-rt-queue flag Date: Fri, 2 Jun 2023 13:52:00 +0200 Message-Id: <20230602115201.415718-1-matthias.schiffer@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767592145737130957?= X-GMAIL-MSGID: =?utf-8?q?1767592145737130957?= We have seen a number of downstream patches that allow enabling the realtime feature of the SPI subsystem to reduce latency. These were usually implemented for a specific SPI driver, even though the actual handling of the rt flag is happening in the generic SPI controller code. Introduce a generic linux,use-rt-queue flag that can be used with any controller driver. The now redundant driver-specific pl022,rt flag is marked as deprecated. Signed-off-by: Matthias Schiffer --- Documentation/devicetree/bindings/spi/spi-controller.yaml | 6 ++++++ Documentation/devicetree/bindings/spi/spi-pl022.yaml | 4 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/spi/spi-controller.yaml b/Documentation/devicetree/bindings/spi/spi-controller.yaml index 524f6fe8c27b4..a24b4ea87443b 100644 --- a/Documentation/devicetree/bindings/spi/spi-controller.yaml +++ b/Documentation/devicetree/bindings/spi/spi-controller.yaml @@ -79,6 +79,12 @@ properties: description: The SPI controller acts as a slave, instead of a master. + linux,use-rt-queue: + $ref: /schemas/types.yaml#/definitions/flag + description: + Indicates that the controller should run the message pump with realtime + priority to minimise the transfer latency on the bus. + slave: type: object diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml index 91e540a92fafe..3c43fcc007e1f 100644 --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml @@ -49,8 +49,10 @@ properties: pl022,rt: description: indicates the controller should run the message pump with realtime - priority to minimise the transfer latency on the bus (boolean) + priority to minimise the transfer latency on the bus (deprecated, use the + generic linux,use-rt-queue property) type: boolean + deprecated: true dmas: description: From patchwork Fri Jun 2 11:52:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Schiffer X-Patchwork-Id: 102526 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp982378vqr; Fri, 2 Jun 2023 05:16:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4BqC7ikyv8IUmOjo0bO3+aMhMnLBj2/m12Qjo/W1ISgrd+Ze4m6A2puhkgk5b3sXASZXy3 X-Received: by 2002:a05:6a20:5484:b0:102:a593:a161 with SMTP id i4-20020a056a20548400b00102a593a161mr9857167pzk.57.1685708166949; Fri, 02 Jun 2023 05:16:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685708166; cv=none; d=google.com; s=arc-20160816; b=G4Nxorgka16010CZDrTRE8frWwR3H5IO6PY42vfg6DIC9hcP2a32BF7hBbt3qp2CfG AEwQtymNNX8A2sWeL1tVDWinpj2GjoUiUTaoeaLORaboZMT+5kU9/h4D2bTg1Yk9qPfr tMHAdcsH9LqPz6rnKrdWp+yESrREzHABwvFiSCFjjKrepMEo1tTyJEAhjqfhiL1jQyC9 XaiGhzbZfXofEWE6IB4lTf6FYKZI29iIs0cB4XDj1VAYV9qn3Fs2BMLEc6pfIOD1rRqk cKXwrAziD9aWooNdZYKMAuC5w7MMIFRfZJUItDBKON5QGNsYXLy/7XKW+6lAA9I/bW4x 1x3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=0NfMqRU9yhxmvM+iGSJczBKuYku1/L+ddjdiE0oaavY=; b=INjH8So9GFdLBExRgGLSYRJekt7U/hCjJbwyEUj8aCwzNMUFODM1C8sOZ+KkpVzZNg 10FFkAmr0XXr/KgF2wY/fgUTdQ3tUsmcG5VWlwGF87ftd8Vnvrz9AvTp11i6cwr0nyuu 1ZWS4SiRUHDVRN7S2LkmzfxYtGYWYGCvXvv70hJ5CuvvBgaC3fOwqD91pZTnj1JhLAso KcmtL2EUEFOYdx3rXfNGV5BNenhK7W+VQVYhvfWB3CGmdD3iqzW0wZ4BWJ67fqsw1zwN p4IJiChzFcSCiZdvVC0TDKTRofayQ4ZrS9+qE/W98a/KxfWtjGrSoWR+3gIeZpbcc6Yp +Pbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tq-group.com header.s=key1 header.b=kBJCcR+W; dkim=pass header.i=@tq-group.com header.s=key1 header.b=RY2yUqKp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=tq-group.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r1-20020aa79881000000b0064fa2ffb2c1si175106pfl.16.2023.06.02.05.15.46; Fri, 02 Jun 2023 05:16:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@tq-group.com header.s=key1 header.b=kBJCcR+W; dkim=pass header.i=@tq-group.com header.s=key1 header.b=RY2yUqKp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=tq-group.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235495AbjFBLzK (ORCPT + 99 others); Fri, 2 Jun 2023 07:55:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235391AbjFBLzG (ORCPT ); Fri, 2 Jun 2023 07:55:06 -0400 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D1BF1A8; Fri, 2 Jun 2023 04:54:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1685706878; x=1717242878; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0NfMqRU9yhxmvM+iGSJczBKuYku1/L+ddjdiE0oaavY=; b=kBJCcR+WDLzY/y9dySo8AF5JjisvR2IdjM4Ha2DtzqOkTdXqpYizQN05 DeYuatT1GQF6n0gZMvqLtV11HeFQLz4hygWc0/Zf7hJ4yzuK9OyquLBPu mlkl/AZgZ68l2f2G0dwf0KlGtGxY2nc+0k6dsY/ipMFruUV50Ud5nHhwR 5pSMFRpvVxqbEPfimkaWDst3IOUWFQW66GUc6Q/ybmjHFF/NKCnjSKi6I bCE5DZCckFOosiRWK3/VJ9NnmNi/nIR08EwNIZXQKZ5WxvWn5Xu8Js6NG HmypEHCwoU2THMLtGN86ciJ6DmQ0FgZxpu45LrnTUyLVwcuGHyqnsJO6i w==; X-IronPort-AV: E=Sophos;i="6.00,212,1681164000"; d="scan'208";a="31246994" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 02 Jun 2023 13:52:41 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 02 Jun 2023 13:52:41 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 02 Jun 2023 13:52:41 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1685706761; x=1717242761; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0NfMqRU9yhxmvM+iGSJczBKuYku1/L+ddjdiE0oaavY=; b=RY2yUqKp7kCCBJXzxw8QUxLDnUU1bcO6HELiHEcoOMFLf0/t6jeLJ1Zd o4G+30SJgbUQc4hPI0D2izEMvl92qbeEDhtKgEtMIufZnE5QNXPHxwTXA GSCxx+0YGXOzKNudMXcZq8X0VaEBbJ/1QhF7roMipDSaRtV6cUwSuq5gX GlhU+I4zy6In0fRKS/HhUvH3UL6wO2lnDNGQsF3nXBwn+KkJzb4BQedem qwAceopcXaVAIwd0wUTKm/aKHiFRCOKyk8eUgqQKM7wlvzqOUJDm+s4+p Uq3siTP5slXDcmDo08JqZSau3tkoxhfxUa5SBBYa9qjDi5x+tovX5nKyC A==; X-IronPort-AV: E=Sophos;i="6.00,212,1681164000"; d="scan'208";a="31246993" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 02 Jun 2023 13:52:41 +0200 Received: from localhost.localdomain (unknown [192.168.66.223]) by vtuxmail01.tq-net.de (Postfix) with ESMTPA id 8B52F280088; Fri, 2 Jun 2023 13:52:40 +0200 (CEST) X-CheckPoint: {6479D7FA-2C-AA2CB662-E129E996} X-MAIL-CPID: 2E05E409D839B4ED1AB3D8DA2C10A9CF_3 X-Control-Analysis: str=0001.0A782F1E.6479D809.0001,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 From: Matthias Schiffer To: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij Cc: linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux@ew.tq-group.com, Matthias Schiffer Subject: [PATCH 2/2] spi: add support for generic linux,use-rt-queue flag Date: Fri, 2 Jun 2023 13:52:01 +0200 Message-Id: <20230602115201.415718-2-matthias.schiffer@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230602115201.415718-1-matthias.schiffer@ew.tq-group.com> References: <20230602115201.415718-1-matthias.schiffer@ew.tq-group.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767593126688602496?= X-GMAIL-MSGID: =?utf-8?q?1767593126688602496?= Instead of requiring per-driver support to handle the message queue with realtime priority, add handling for a linux,use-rt-queue DT flag to the generic SPI controller initialization. Signed-off-by: Matthias Schiffer --- drivers/spi/spi.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 9291b2a0e8871..f069f1aef5378 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -3185,6 +3185,11 @@ int spi_register_controller(struct spi_controller *ctlr) ctlr->mode_bits |= SPI_CS_HIGH; } + /* Run message pump with realtime priority */ + if (ctlr->dev.of_node && + of_property_read_bool(ctlr->dev.of_node, "linux,use-rt-queue")) + ctlr->rt = true; + /* * Even if it's just one always-selected device, there must * be at least one chipselect.