From patchwork Fri Jun 2 09:11:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 102410 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp897477vqr; Fri, 2 Jun 2023 02:25:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7r2GkX3vqh340/Qgsm8jKQ5mbbxvihhEZtMMYJzopketbdg/mPTIjPJBj4Wxmjo1HiS70Y X-Received: by 2002:a05:6870:5155:b0:19a:25c2:3f0a with SMTP id z21-20020a056870515500b0019a25c23f0amr1353759oak.31.1685697957075; Fri, 02 Jun 2023 02:25:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685697957; cv=none; d=google.com; s=arc-20160816; b=MHuecT2h9s0cxdnmB1lneUQ8NSFXFSdB8jFjSbucbMt6kpwaPv3ppXJpsyF9ZtGt0Y q+0tzaYUU4f/rqK5HxCcOb3l3d9GtbokXY39fFdHwPOgUlCIqt8OfFZnmFl/B+0cKVRV w57J5a8YDj1I+xG59v6UAt9evakneAvGd2lvkM3so/32D2ftRSVx22aG+rpz7DXMG+So VjOnk+tr5YlkaKoAiC8EI2LJmaxpIB02X9WhHz7h3qdBBVIxI9nYjwBrO6LVPlQO+kBu gSmDT7sFex/380XHrxl1NDRUnp6VA6usPrcBGzMsN5qj7RwJoh0Ydn/ntNW/18hHWswD GZKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=4rYCWHMHLbwy7OoyqYFa0Pp5uDoqhOuA/QlIh79NQR4=; b=CyjbSi8OVEjpescS033BQbdAICeH7yRYI84Wvh6hmwsQTEWpYu2OWzRuvGrElJ/gVg B1CyT0BaowZ3AUs3gB6fXQpHWQpwJbAUnH3IpDlXPWWdaitRYPBi94JrF60rUX3GFCf2 CCrjfAJT2ZfQQstJ4d53xQ1ZY6GPfKvNNVpBgpaffia3QjKNoikXfs3PZZDGTIBnQCxp TKdFZ9MlakDSMisdezasrqY67v31iyPmqjHfMnSeFOe5sDier5JLrPLvb29F+t0UEs9x czI9lv1IkOxuJmh+NT8v6d7yrrbbAGHYykrbqC2UIGf5BMumtANHRt5Fd4v5f2VfD4pA FGWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w4-20020a63b744000000b0051b13a071a8si690458pgt.575.2023.06.02.02.25.42; Fri, 02 Jun 2023 02:25:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234635AbjFBJNQ (ORCPT + 99 others); Fri, 2 Jun 2023 05:13:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235097AbjFBJMo (ORCPT ); Fri, 2 Jun 2023 05:12:44 -0400 Received: from andre.telenet-ops.be (andre.telenet-ops.be [IPv6:2a02:1800:120:4::f00:15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00CAE1703 for ; Fri, 2 Jun 2023 02:11:47 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed30:158c:2ccf:1f70:e136]) by andre.telenet-ops.be with bizsmtp id 49Bg2A0061tRZS8019BgaW; Fri, 02 Jun 2023 11:11:46 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1q50ob-00BvaL-2W; Fri, 02 Jun 2023 11:11:40 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1q50ou-00ASIJ-6O; Fri, 02 Jun 2023 11:11:40 +0200 From: Geert Uytterhoeven To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jonathan Corbet , Jyri Sarha , Tomi Valkeinen , Laurent Pinchart , Biju Das Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH 1/3] drm/todo: Add atomic modesetting references Date: Fri, 2 Jun 2023 11:11:34 +0200 Message-Id: <7cea42cd09540657875a210cd16421125497d690.1685696114.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767582421337044145?= X-GMAIL-MSGID: =?utf-8?q?1767582421337044145?= The section about converting existing KMS drivers to atomic modesetting mentions the existence of a conversion guide, but does not reference it. While the guide is old and rusty, it still contains useful information, so add a link to it. Also link to the LWN.net articles that give an overview about the atomic mode setting design. Signed-off-by: Geert Uytterhoeven Reviewed-by: Javier Martinez Canillas Reviewed-by: Laurent Pinchart --- Documentation/gpu/todo.rst | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 68bdafa0284f55f6..51eb67f5268c5ec1 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -49,14 +49,19 @@ converted over. Modern compositors like Wayland or Surfaceflinger on Android really want an atomic modeset interface, so this is all about the bright future. -There is a conversion guide for atomic and all you need is a GPU for a +There is a conversion guide for atomic[1] and all you need is a GPU for a non-converted driver (again virtual HW drivers for KVM are still all -suitable). +suitable). The "Atomic mode setting design overview" series [2][3] at +LWN.net can also be helpful. As part of this drivers also need to convert to universal plane (which means exposing primary & cursor as proper plane objects). But that's much easier to do by directly using the new atomic helper driver callbacks. + - [1] https://blog.ffwll.ch/2014/11/atomic-modeset-support-for-kms-drivers.html + - [2] https://lwn.net/Articles/653071/ + - [3] https://lwn.net/Articles/653466/ + Contact: Daniel Vetter, respective driver maintainers Level: Advanced From patchwork Fri Jun 2 09:11:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 102418 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp905216vqr; Fri, 2 Jun 2023 02:45:33 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7YVdqzr1t1gATM3PU5TomdfOc1KuNTs9J0XA8/qB+GtUamNUTi1wypkbSBufFCKWdT2BQN X-Received: by 2002:a9d:65d3:0:b0:6b0:c9c2:51a0 with SMTP id z19-20020a9d65d3000000b006b0c9c251a0mr2298517oth.16.1685699133013; Fri, 02 Jun 2023 02:45:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685699132; cv=none; d=google.com; s=arc-20160816; b=VzUjH7Xr+c9EGsSq9LqNVyNhuU4Ci0N3jMfg5tPkpx4+5s1aOlequK+sP8qwkuC4Um vRdY736VojcDZ/EO+q6jo/g3OF/xsiDr6Y4SFQb+hVKjwJQs+dLJnw/9GJnAAYjzCkmD TSCJojWhCu83LO5Ltkh8/lZysXt/DVwiUM/3dTW58uQwx2kD8uV1ZXVTBaDKtsOKi+hw 5gP9J5dFbm2idebgJ0p8ZpxXyGD7B+O6rYv45QyQ8uU8t6Lu0sIy0K6FqyI0FHGdv9QF 8SGEfddVHoMujRwKZ2QOYxpvhoum/9pb0cSZcJZ1gsw7LVSWPnyfW6FaQYWMKULhwjfP /RAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=lTxO/ZW29S8v0CwnL5Yr0rjISNMeNxrvyLiCqveLec4=; b=lK6QIJE0w68B/kti4ViFTmQcuD/5GgWyz6n1Ofqh7AZfy1g3QSPnO7U5zi5Gne1+u5 ekWLppmWbCKw7zoX90mCzyTR2YjIK1PEzSXU6qlm57Sk3Sbh76TDQlBFpCQmCCg9KJUs l3LCTW3ng/c9smmR4Q0iGkjPcEbGCWqrCUBmlv0dvS7t64evXOV338NqEviLUBpVMRQU JNQoLUJ8RDm1NLEVuqeqaHQ1xrmaYnWVDRTwErHg3YN0sEYkNMJhjZdkxmqOFUkIUZo3 ZaVKnxwXx2vRxSaUeMbpD1/wzX2EPv1wrp+A+5t6oiek7mAqj02oT4ftnR0DkfeC2VOU C9FA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y7-20020aa78f27000000b0064f33d8954csi476472pfr.203.2023.06.02.02.45.13; Fri, 02 Jun 2023 02:45:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235158AbjFBJNZ (ORCPT + 99 others); Fri, 2 Jun 2023 05:13:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235080AbjFBJMs (ORCPT ); Fri, 2 Jun 2023 05:12:48 -0400 Received: from andre.telenet-ops.be (andre.telenet-ops.be [IPv6:2a02:1800:120:4::f00:15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17EB31706 for ; Fri, 2 Jun 2023 02:11:47 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed30:158c:2ccf:1f70:e136]) by andre.telenet-ops.be with bizsmtp id 49Bg2A0071tRZS8019BgaX; Fri, 02 Jun 2023 11:11:46 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1q50ob-00BvaM-3Q; Fri, 02 Jun 2023 11:11:40 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1q50ou-00ASIM-7I; Fri, 02 Jun 2023 11:11:40 +0200 From: Geert Uytterhoeven To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jonathan Corbet , Jyri Sarha , Tomi Valkeinen , Laurent Pinchart , Biju Das Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH 2/3] drm: Remove references to removed transitional helpers Date: Fri, 2 Jun 2023 11:11:35 +0200 Message-Id: <14e091fc522aa63a3e33bda1016e5fa946d47d18.1685696114.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767583654260675884?= X-GMAIL-MSGID: =?utf-8?q?1767583654260675884?= The transitional helpers were removed a long time ago, but some references stuck. Remove them. Fixes: 21ebe615c16994f3 ("drm: Remove transitional helpers") Signed-off-by: Geert Uytterhoeven --- It doesn't look like the drm_encoder_helper_funcs were ever used by the transitional plane helpers? --- drivers/gpu/drm/drm_plane_helper.c | 8 ---- include/drm/drm_crtc.h | 5 --- include/drm/drm_modeset_helper_vtables.h | 48 +++++++++++------------- 3 files changed, 21 insertions(+), 40 deletions(-) diff --git a/drivers/gpu/drm/drm_plane_helper.c b/drivers/gpu/drm/drm_plane_helper.c index c91e454eba097942..be45bdb58d849653 100644 --- a/drivers/gpu/drm/drm_plane_helper.c +++ b/drivers/gpu/drm/drm_plane_helper.c @@ -51,14 +51,6 @@ * planes, and newly merged drivers must not rely upon these transitional * helpers. * - * The second part also implements transitional helpers which allow drivers to - * gradually switch to the atomic helper infrastructure for plane updates. Once - * that switch is complete drivers shouldn't use these any longer, instead using - * the proper legacy implementations for update and disable plane hooks provided - * by the atomic helpers. - * - * Again drivers are strongly urged to switch to the new interfaces. - * * The plane helpers share the function table structures with other helpers, * specifically also the atomic helpers. See &struct drm_plane_helper_funcs for * the details. diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 8e1cbc75143ef216..8b48a1974da3143c 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -77,11 +77,6 @@ struct drm_plane_helper_funcs; * intended to indicate whether a full modeset is needed, rather than strictly * describing what has changed in a commit. See also: * drm_atomic_crtc_needs_modeset() - * - * WARNING: Transitional helpers (like drm_helper_crtc_mode_set() or - * drm_helper_crtc_mode_set_base()) do not maintain many of the derived control - * state like @plane_mask so drivers not converted over to atomic helpers should - * not rely on these being accurate! */ struct drm_crtc_state { /** @crtc: backpointer to the CRTC */ diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_modeset_helper_vtables.h index 965faf082a6d1acb..e3c3ac615909474b 100644 --- a/include/drm/drm_modeset_helper_vtables.h +++ b/include/drm/drm_modeset_helper_vtables.h @@ -59,8 +59,8 @@ enum mode_set_atomic { /** * struct drm_crtc_helper_funcs - helper operations for CRTCs * - * These hooks are used by the legacy CRTC helpers, the transitional plane - * helpers and the new atomic modesetting helpers. + * These hooks are used by the legacy CRTC helpers and the new atomic + * modesetting helpers. */ struct drm_crtc_helper_funcs { /** @@ -216,9 +216,7 @@ struct drm_crtc_helper_funcs { * * This callback is used to update the display mode of a CRTC without * changing anything of the primary plane configuration. This fits the - * requirement of atomic and hence is used by the atomic helpers. It is - * also used by the transitional plane helpers to implement a - * @mode_set hook in drm_helper_crtc_mode_set(). + * requirement of atomic and hence is used by the atomic helpers. * * Note that the display pipe is completely off when this function is * called. Atomic drivers which need hardware to be running before they @@ -333,8 +331,8 @@ struct drm_crtc_helper_funcs { * all updated. Again the recommendation is to just call check helpers * until a maximal configuration is reached. * - * This callback is used by the atomic modeset helpers and by the - * transitional plane helpers, but it is optional. + * This callback is used by the atomic modeset helpers, but it is + * optional. * * NOTE: * @@ -373,8 +371,8 @@ struct drm_crtc_helper_funcs { * has picked. See drm_atomic_helper_commit_planes() for a discussion of * the tradeoffs and variants of plane commit helpers. * - * This callback is used by the atomic modeset helpers and by the - * transitional plane helpers, but it is optional. + * This callback is used by the atomic modeset helpers, but it is + * optional. */ void (*atomic_begin)(struct drm_crtc *crtc, struct drm_atomic_state *state); @@ -397,8 +395,8 @@ struct drm_crtc_helper_funcs { * has picked. See drm_atomic_helper_commit_planes() for a discussion of * the tradeoffs and variants of plane commit helpers. * - * This callback is used by the atomic modeset helpers and by the - * transitional plane helpers, but it is optional. + * This callback is used by the atomic modeset helpers, but it is + * optional. */ void (*atomic_flush)(struct drm_crtc *crtc, struct drm_atomic_state *state); @@ -507,8 +505,8 @@ static inline void drm_crtc_helper_add(struct drm_crtc *crtc, /** * struct drm_encoder_helper_funcs - helper operations for encoders * - * These hooks are used by the legacy CRTC helpers, the transitional plane - * helpers and the new atomic modesetting helpers. + * These hooks are used by the legacy CRTC helpers and the new atomic + * modesetting helpers. */ struct drm_encoder_helper_funcs { /** @@ -1185,8 +1183,7 @@ static inline void drm_connector_helper_add(struct drm_connector *connector, /** * struct drm_plane_helper_funcs - helper operations for planes * - * These functions are used by the atomic helpers and by the transitional plane - * helpers. + * These functions are used by the atomic helpers. */ struct drm_plane_helper_funcs { /** @@ -1221,9 +1218,8 @@ struct drm_plane_helper_funcs { * The helpers will call @cleanup_fb with matching arguments for every * successful call to this hook. * - * This callback is used by the atomic modeset helpers and by the - * transitional plane helpers, but it is optional. See @begin_fb_access - * for preparing per-commit resources. + * This callback is used by the atomic modeset helpers, but it is + * optional. See @begin_fb_access for preparing per-commit resources. * * RETURNS: * @@ -1240,8 +1236,8 @@ struct drm_plane_helper_funcs { * This hook is called to clean up any resources allocated for the given * framebuffer and plane configuration in @prepare_fb. * - * This callback is used by the atomic modeset helpers and by the - * transitional plane helpers, but it is optional. + * This callback is used by the atomic modeset helpers, but it is + * optional. */ void (*cleanup_fb)(struct drm_plane *plane, struct drm_plane_state *old_state); @@ -1295,8 +1291,8 @@ struct drm_plane_helper_funcs { * all updated. Again the recommendation is to just call check helpers * until a maximal configuration is reached. * - * This callback is used by the atomic modeset helpers and by the - * transitional plane helpers, but it is optional. + * This callback is used by the atomic modeset helpers, but it is + * optional. * * NOTE: * @@ -1326,8 +1322,7 @@ struct drm_plane_helper_funcs { * has picked. See drm_atomic_helper_commit_planes() for a discussion of * the tradeoffs and variants of plane commit helpers. * - * This callback is used by the atomic modeset helpers and by the - * transitional plane helpers, but it is optional. + * This callback is used by the atomic modeset helpers, but it is optional. */ void (*atomic_update)(struct drm_plane *plane, struct drm_atomic_state *state); @@ -1376,9 +1371,8 @@ struct drm_plane_helper_funcs { * has picked. See drm_atomic_helper_commit_planes() for a discussion of * the tradeoffs and variants of plane commit helpers. * - * This callback is used by the atomic modeset helpers and by the - * transitional plane helpers, but it is optional. It's intended to - * reverse the effects of @atomic_enable. + * This callback is used by the atomic modeset helpers, but it is + * optional. It's intended to reverse the effects of @atomic_enable. */ void (*atomic_disable)(struct drm_plane *plane, struct drm_atomic_state *state); From patchwork Fri Jun 2 09:11:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 102406 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp896914vqr; Fri, 2 Jun 2023 02:24:31 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5xnqj9q24uWq0YAfc6eDmTmiLhVoeVrsriuc1X1X5VwShDd07TJmw6san6mK8qz7JtGCRn X-Received: by 2002:aca:1a14:0:b0:398:5b13:e481 with SMTP id a20-20020aca1a14000000b003985b13e481mr2217177oia.7.1685697871100; Fri, 02 Jun 2023 02:24:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685697871; cv=none; d=google.com; s=arc-20160816; b=jE7Hk7mvrMUdMCYLd1Znlw94wdQ8ceLIe4QswbkA2sKV7+iIGAZsrW7K7+eIX7725Y bhn7sQWvJA+Ye0QEm4L9UzloHei3eAAGZr608AX+zcMC8yR0umwc5X7X3ABdaIG8evpS gRQCmQwpi3mr5AF+8ro+a1I0RwPM3JPbsIr5VbMPwiQutbx8jgX+Je6Mo85gr+GKHjE+ x1X+yc0Ooc6S0jvcsUVQZryNAB/DnNazMgRboFhiKFQXRYjS1v4G0TqZoNL7e/6sF36q 27kWQgsTNqv6zXvZamkyQqF9ioCKEbJfio93zrU7f/6JjfS+VTkQYHvqF5ql7UvzH8Fo cDhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=puApSLuzbGZPuuN0tB+i3mKSOnl8CKAd+7JXzMbT2Dc=; b=aFq3F/sqRRoqpz0JYQu3zCulzyqWFYgHlq6opCjoKhJCmlYKX9cd1ptad/x9813PXP T+B2tanJGwthjXAQs4zUglUZbh26qqE3izFzZXY/kQ6wLVedUmJWhG7rOqci3v8f5RRj JAg1/5Q0HQmNzmHtQ24pL2M8WkWanqB0FSMCZnD0gTyN8uids8grVNHGOCGKCHMFE+G8 ZCwEvsv6W/0Skhvk4ZdZIhPNHfosn5aZuBaH8caBqqE0WZVG4oU40rmcPquzlDjChC9n uO4n1KJWW2m4qDdWxQSzngfWV3zapOVYEsWsMHaEMJYr47xlPei+0c89SxlWvXYDe2f5 1rVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u2-20020a17090a400200b00256917c7851si2438258pjc.107.2023.06.02.02.24.16; Fri, 02 Jun 2023 02:24:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235145AbjFBJNV (ORCPT + 99 others); Fri, 2 Jun 2023 05:13:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234759AbjFBJMr (ORCPT ); Fri, 2 Jun 2023 05:12:47 -0400 Received: from baptiste.telenet-ops.be (baptiste.telenet-ops.be [IPv6:2a02:1800:120:4::f00:13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1885170F for ; Fri, 2 Jun 2023 02:11:48 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed30:158c:2ccf:1f70:e136]) by baptiste.telenet-ops.be with bizsmtp id 49Bg2A00L1tRZS8019BgSY; Fri, 02 Jun 2023 11:11:46 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1q50ob-00BvaU-4t; Fri, 02 Jun 2023 11:11:40 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1q50ou-00ASIR-8C; Fri, 02 Jun 2023 11:11:40 +0200 From: Geert Uytterhoeven To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jonathan Corbet , Jyri Sarha , Tomi Valkeinen , Laurent Pinchart , Biju Das Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH 3/3] drm: Fix references to drm_plane_helper_check_state() Date: Fri, 2 Jun 2023 11:11:36 +0200 Message-Id: <2408d7841c91e98e9a2b24b1b4df9b2b865519a6.1685696114.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767582330732119794?= X-GMAIL-MSGID: =?utf-8?q?1767582330732119794?= As of commit a01cb8ba3f628293 ("drm: Move drm_plane_helper_check_state() into drm_atomic_helper.c"), drm_plane_helper_check_state() no longer exists, but is part of drm_atomic_helper_check_plane_state(). Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart --- Interestingly, all these comments appeared only after the commit that removed the function... This is against next-20230602, which does not have the drivers/gpu/drm/{ => renesas}/rcar-du move yet. Biju: you're adding a new copy in drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c --- drivers/gpu/drm/rcar-du/rcar_du_plane.c | 3 ++- drivers/gpu/drm/tidss/tidss_plane.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c b/drivers/gpu/drm/rcar-du/rcar_du_plane.c index d759e019218181ce..e445fac8e0b46c21 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c @@ -600,7 +600,8 @@ int __rcar_du_plane_atomic_check(struct drm_plane *plane, if (!state->crtc) { /* * The visible field is not reset by the DRM core but only - * updated by drm_plane_helper_check_state(), set it manually. + * updated by drm_atomic_helper_check_plane_state(), set it + * manually. */ state->visible = false; *format = NULL; diff --git a/drivers/gpu/drm/tidss/tidss_plane.c b/drivers/gpu/drm/tidss/tidss_plane.c index 6bdd6e4a955ab3cc..e1c0ef0c3894c855 100644 --- a/drivers/gpu/drm/tidss/tidss_plane.c +++ b/drivers/gpu/drm/tidss/tidss_plane.c @@ -38,7 +38,8 @@ static int tidss_plane_atomic_check(struct drm_plane *plane, if (!new_plane_state->crtc) { /* * The visible field is not reset by the DRM core but only - * updated by drm_plane_helper_check_state(), set it manually. + * updated by drm_atomic_helper_check_plane_state(), set it + * manually. */ new_plane_state->visible = false; return 0;