From patchwork Wed Oct 26 12:39:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaron Lawrence X-Patchwork-Id: 11235 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp243924wru; Wed, 26 Oct 2022 05:43:29 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4zKh/iRPsbwjc8DmaLJkEX1z8iEgEv6Z3bQxCtUH5ir/kUxxhShKrL+YkDKvQdYhuvYGoX X-Received: by 2002:a17:907:a06b:b0:78d:d25f:b726 with SMTP id ia11-20020a170907a06b00b0078dd25fb726mr37425849ejc.203.1666788209596; Wed, 26 Oct 2022 05:43:29 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1666788209; cv=pass; d=google.com; s=arc-20160816; b=EyQr61iA9XW9xxpzGaeEqIu3Ru/dL0fdBpO0a3Indi4Tb+p2kKsVFV7ofiyVEjyU7R c4tACDzTyRvsXGB99z3zDbqKbLaHzUFUI6zywBBS4I9AYovdNi0WYga2j5QoJ33P7NQB UFH5fX4IkXs3CAk5zmTpS2QUqr90FlrIIqmZdnHQyiNffrj+S7XUlc4DkETUp82uK5zI QtSPT7/HHhmwEahKOT8ztSCPJ9ZopRRzhMsXOnhsds1pvyE+e+Jxfq+Un7H1nx0xtJ2B QICkzNQLcIsBDFrLVo+ChjJ0IepwuNTa441eYjRFX1WbHFOF7b8qkQ4e/GOSk1xxsnJl SYZQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0LLkN2jkAwe4zdgwogVVzq5cDse5Taypry86b9Wf73s=; b=jHooAgbnCN3qsfHNA9tNkFbmJ0HkXcL9SgBJnuKgbHVQZFCD+/AzDnG6Ht4HSE1LmP 6ccQwHiJh86lR6vgNegxZNzch645uU+PhvI/yzK4xQCIOiubiwg5QYDMhJWDRHaC9Qvo 5VA8srsPwBJuXy9eQpoWgcMa2pL3IU8htD5tSjSebPxLYUOyG+F+OQcbtXb1NynpuWG6 jTzdZN/etB1BMbQblwrWM6IZAP1ESrC7QgvvJElA5uXTmdQFWQfiZ4BEiDUDpfkc8Tpl Dbst/wDl0widP1IBEhqTScML9b3TzjqmMKyRJb9RF4tbYYi0UUcrfYDXIjfsFj9wLAEO 0P7w== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@zohomail.com header.s=zm2022 header.b=XEShc9ch; arc=pass (i=1 spf=pass spfdomain=zohomail.com dkim=pass dkdomain=zohomail.com dmarc=pass fromdomain=zohomail.com>); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=zohomail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qo14-20020a170907874e00b0078dc5c888f1si3830466ejc.135.2022.10.26.05.43.05; Wed, 26 Oct 2022 05:43:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zohomail.com header.s=zm2022 header.b=XEShc9ch; arc=pass (i=1 spf=pass spfdomain=zohomail.com dkim=pass dkdomain=zohomail.com dmarc=pass fromdomain=zohomail.com>); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=zohomail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233923AbiJZMkg (ORCPT + 99 others); Wed, 26 Oct 2022 08:40:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233758AbiJZMjs (ORCPT ); Wed, 26 Oct 2022 08:39:48 -0400 Received: from sender4-pp-o95.zoho.com (sender4-pp-o95.zoho.com [136.143.188.95]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0DDA240A1 for ; Wed, 26 Oct 2022 05:39:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666787978; cv=none; d=zohomail.com; s=zohoarc; b=NQLOs/sNpkyQaEw+Uv1jlWXuOVJLnh65dxGlU9ZSgeYq/3WUOe9+PVQDkWYKs8KuzVi6ih8Jghg6BE8IEtFhisS7aBjHHhWG4kk+3FVsQvdwJ2gnvEzA6bGk3Tvu3QFFbdcJopDcZDzJ5W5c9v4fqjHgfFtUSU+oOiSRYQU4vww= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666787978; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=0LLkN2jkAwe4zdgwogVVzq5cDse5Taypry86b9Wf73s=; b=WxE2LOx9gTfazoCajhtmBpGYBNP5+KJ+n7OhWPBJqyUX+LFHzFaWumclNDBca6/Z1r5w2THlLY6mN3UK69t1MXJgtyWXktUfefj8D/8F7fBSU3xb7VJh/M32rR/L/bSq9wW0UnzU3AG26zKw62g6a3XQo2nzTBEs0Ouqe+FU5go= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zohomail.com; spf=pass smtp.mailfrom=t4rmin@zohomail.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1666787978; s=zm2022; d=zohomail.com; i=t4rmin@zohomail.com; h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To:Message-Id:Reply-To; bh=0LLkN2jkAwe4zdgwogVVzq5cDse5Taypry86b9Wf73s=; b=XEShc9chnvCdq0ib0zLpbi3H+RUk49h7HsKz47lcxh+jEpNGkYhnlX+NZECWnRk8 /eGdUBh3DWMu2TyVy2LH3b69y2UUxosYSk2Rwc4TO66u6Y9f1NadbjkjpPhft3va37d hCSPbbcId87rc6IC/ZhppI5Y6AmiK7b4tm5uXAYs= Received: from plymouth (103.47.132.7 [103.47.132.7]) by mx.zohomail.com with SMTPS id 1666787977517374.34762759246007; Wed, 26 Oct 2022 05:39:37 -0700 (PDT) Date: Wed, 26 Oct 2022 19:39:28 +0700 From: Aaron Lawrence To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/6] staging: rtl8192e: rtllib_crypt_tkip: multiple blank lines removal Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-ZohoMailClient: External X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747754113324740369?= X-GMAIL-MSGID: =?utf-8?q?1747754113324740369?= Removed multiple unnecessary blank lines in accordance with the Linux kernel coding-style regulations. The issues were reported by the checkpatch script. Signed-off-by: Aaron Lawrence --- drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 24 -------------------- 1 file changed, 24 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c index 8bc95651e384..468f28f48eba 100644 --- a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c +++ b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c @@ -91,7 +91,6 @@ static void *rtllib_tkip_init(int key_idx) return NULL; } - static void rtllib_tkip_deinit(void *priv) { struct rtllib_tkip_data *_priv = priv; @@ -103,49 +102,41 @@ static void rtllib_tkip_deinit(void *priv) kfree_sensitive(priv); } - static inline u16 RotR1(u16 val) { return (val >> 1) | (val << 15); } - static inline u8 Lo8(u16 val) { return val & 0xff; } - static inline u8 Hi8(u16 val) { return val >> 8; } - static inline u16 Lo16(u32 val) { return val & 0xffff; } - static inline u16 Hi16(u32 val) { return val >> 16; } - static inline u16 Mk16(u8 hi, u8 lo) { return lo | (hi << 8); } - static inline u16 Mk16_le(u16 *v) { return *v; } - static const u16 Sbox[256] = { 0xC6A5, 0xF884, 0xEE99, 0xF68D, 0xFF0D, 0xD6BD, 0xDEB1, 0x9154, 0x6050, 0x0203, 0xCEA9, 0x567D, 0xE719, 0xB562, 0x4DE6, 0xEC9A, @@ -181,17 +172,14 @@ static const u16 Sbox[256] = { 0x82C3, 0x29B0, 0x5A77, 0x1E11, 0x7BCB, 0xA8FC, 0x6DD6, 0x2C3A, }; - static inline u16 _S_(u16 v) { u16 t = Sbox[Hi8(v)]; return Sbox[Lo8(v)] ^ ((t << 8) | (t >> 8)); } - #define PHASE1_LOOP_COUNT 8 - static void tkip_mixing_phase1(u16 *TTAK, const u8 *TK, const u8 *TA, u32 IV32) { int i, j; @@ -213,7 +201,6 @@ static void tkip_mixing_phase1(u16 *TTAK, const u8 *TK, const u8 *TA, u32 IV32) } } - static void tkip_mixing_phase2(u8 *WEPSeed, const u8 *TK, const u16 *TTAK, u16 IV16) { @@ -263,7 +250,6 @@ static void tkip_mixing_phase2(u8 *WEPSeed, const u8 *TK, const u16 *TTAK, #endif } - static int rtllib_tkip_encrypt(struct sk_buff *skb, int hdr_len, void *priv) { struct rtllib_tkip_data *tkey = priv; @@ -293,7 +279,6 @@ static int rtllib_tkip_encrypt(struct sk_buff *skb, int hdr_len, void *priv) } else tkey->tx_phase1_done = 1; - len = skb->len - hdr_len; pos = skb_push(skb, 8); memmove(pos, pos + 8, hdr_len); @@ -337,7 +322,6 @@ static int rtllib_tkip_encrypt(struct sk_buff *skb, int hdr_len, void *priv) return ret; return 0; - } static int rtllib_tkip_decrypt(struct sk_buff *skb, int hdr_len, void *priv) @@ -453,7 +437,6 @@ static int rtllib_tkip_decrypt(struct sk_buff *skb, int hdr_len, void *priv) return keyidx; } - static int michael_mic(struct crypto_shash *tfm_michael, u8 *key, u8 *hdr, u8 *data, size_t data_len, u8 *mic) { @@ -511,7 +494,6 @@ static void michael_mic_hdr(struct sk_buff *skb, u8 *hdr) hdr[13] = hdr[14] = hdr[15] = 0; /* reserved */ } - static int rtllib_michael_mic_add(struct sk_buff *skb, int hdr_len, void *priv) { struct rtllib_tkip_data *tkey = priv; @@ -539,7 +521,6 @@ static int rtllib_michael_mic_add(struct sk_buff *skb, int hdr_len, void *priv) return 0; } - static void rtllib_michael_mic_failure(struct net_device *dev, struct rtllib_hdr_4addr *hdr, int keyidx) @@ -609,7 +590,6 @@ static int rtllib_michael_mic_verify(struct sk_buff *skb, int keyidx, return 0; } - static int rtllib_tkip_set_key(void *key, int len, u8 *seq, void *priv) { struct rtllib_tkip_data *tkey = priv; @@ -640,7 +620,6 @@ static int rtllib_tkip_set_key(void *key, int len, u8 *seq, void *priv) return 0; } - static int rtllib_tkip_get_key(void *key, int len, u8 *seq, void *priv) { struct rtllib_tkip_data *tkey = priv; @@ -671,7 +650,6 @@ static int rtllib_tkip_get_key(void *key, int len, u8 *seq, void *priv) return TKIP_KEY_LEN; } - static void rtllib_tkip_print_stats(struct seq_file *m, void *priv) { struct rtllib_tkip_data *tkip = priv; @@ -713,13 +691,11 @@ static struct lib80211_crypto_ops rtllib_crypt_tkip = { .owner = THIS_MODULE, }; - static int __init rtllib_crypto_tkip_init(void) { return lib80211_register_crypto_ops(&rtllib_crypt_tkip); } - static void __exit rtllib_crypto_tkip_exit(void) { lib80211_unregister_crypto_ops(&rtllib_crypt_tkip); From patchwork Wed Oct 26 12:40:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaron Lawrence X-Patchwork-Id: 11236 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp243972wru; Wed, 26 Oct 2022 05:43:37 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5uhOLUQPeMIqeND0JsLvEfotctrGFiHRcfqwE6zAkRH1uoMtpxC7mjeYndj73c9Ndw1d8+ X-Received: by 2002:a05:6402:370c:b0:453:9fab:1b53 with SMTP id ek12-20020a056402370c00b004539fab1b53mr41893665edb.28.1666788217096; Wed, 26 Oct 2022 05:43:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1666788217; cv=pass; d=google.com; s=arc-20160816; b=EpJ/OnutcNgEq8clhia7vTaiSXPgJET4TitCZ0Ef4P7YrwBeSGGTeAWh01IelTf4w0 v7vsBUQ150DycgcZTUH8wYHi3+56DUrNXY76PYBAUNQoaRjYEmMuMeqDrIPj6VKy0PCk RHyJit4guEF74syYJUA4N4UfK4286XUK71pt/LBYjhTbbVgERworx3YMgCdkdqrBzpOE sAye+DnDC5CEGbJI1zuapxNVYuInM7m1RXhcUBtjcDffleEmm45V+rprm7DYVJAxXgBo tyT+6pPqjRFPDvLhUqKzX2vrUp6pYYi3qT26fxxX53BzKOQtKqqmSJg4Og5KbqHWvvGV KWmw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=OfyJwTiWx+2RzcwoDlVjx0+DSd/U0Zg3cQSdnUzsHwg=; b=JIKugaBGS2pR2HhnWOHAtvTB+MGISLMYM/Oua+cZHfXfwGWuZUOPGLxJx6Dnl4IF/L biILmOxNZRkH4qtxd2sNe3cDR10UC6adgTtqCx6aHAJDQrsJ5VlRUsLTXi5qNIROWeT2 vZus1uRNc4QIDWuZJ1gU+yRI7nAON/tHvEPFnMEpif9a31DArwoaXF5cVRve5IfDyGbK GTvGXZCK+HOrJCYncwsvEn36rMpKt8I5CrRAHOG9i2i+qIOADjCjdsKzqPrCWxbIqurr XMz2+p9JfUKaK1dJnYzeiHtDaSWU9NnBjNXz6696Oe8mFXtFMw1JsY0z/4WLDHdzg55f zCrg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@zohomail.com header.s=zm2022 header.b=Jy0qaeRp; arc=pass (i=1 spf=pass spfdomain=zohomail.com dkim=pass dkdomain=zohomail.com dmarc=pass fromdomain=zohomail.com>); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=zohomail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i18-20020a05640242d200b004616aff8436si7634606edc.83.2022.10.26.05.43.12; Wed, 26 Oct 2022 05:43:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zohomail.com header.s=zm2022 header.b=Jy0qaeRp; arc=pass (i=1 spf=pass spfdomain=zohomail.com dkim=pass dkdomain=zohomail.com dmarc=pass fromdomain=zohomail.com>); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=zohomail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233155AbiJZMli (ORCPT + 99 others); Wed, 26 Oct 2022 08:41:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233954AbiJZMlQ (ORCPT ); Wed, 26 Oct 2022 08:41:16 -0400 Received: from sender4-pp-o95.zoho.com (sender4-pp-o95.zoho.com [136.143.188.95]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D966E9AC0D for ; Wed, 26 Oct 2022 05:40:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666788024; cv=none; d=zohomail.com; s=zohoarc; b=YUPFAJcWa6doiWlEPxdAbuwGVJWZQg9mj3RUNUfd9GODZ9w9rqpkucik9lhIcCvahAepgWezYyiQTIA+I3BVw2FGcLDIkjbYDPZW2zIX8T1NlA6zVr628VFFFs+4EFykTHtO6Z3xMSgQY69dQOzDZF+vZxj2T4gNuGjT2G+UnlA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666788024; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=OfyJwTiWx+2RzcwoDlVjx0+DSd/U0Zg3cQSdnUzsHwg=; b=D7wuEhzQ8x16XKtmu1ErUvZMjd14cHGVjKZ8s9kHPloBqb518GO3m96Or0Rta/n9B6UCR7hfi71MGYhaQdcQtOlIyjBkZ2TQRPq47PL+1rQxJPQpylS0dlruPvypGL7OF1GfcOl61TW/g8MVkzU5GfI9Bn4dROJrcJXTIUH+tGc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zohomail.com; spf=pass smtp.mailfrom=t4rmin@zohomail.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1666788024; s=zm2022; d=zohomail.com; i=t4rmin@zohomail.com; h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To:Message-Id:Reply-To; bh=OfyJwTiWx+2RzcwoDlVjx0+DSd/U0Zg3cQSdnUzsHwg=; b=Jy0qaeRp51aucJVBZr40t+MbHbVvcF6GskRQuAtJ0/cotM0VO/yVCPaed7Uoc8QD xCYn+WJeFyjMFNuzkZknHQ6a10XX+l9O7KLWpRbFDP/fCoLubfjtWwrhPU3IIY/TKPL asfEyWXhXJFI9RNdgDRtMcMEFqSGBkI7kZvWbUAw= Received: from plymouth (103.47.132.27 [103.47.132.27]) by mx.zohomail.com with SMTPS id 1666788022817369.81207230669327; Wed, 26 Oct 2022 05:40:22 -0700 (PDT) Date: Wed, 26 Oct 2022 19:40:15 +0700 From: Aaron Lawrence To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 2/6] staging: rtl8192e: rtllib_crypt_tkip: blank line before close brace removal Message-ID: <1ba11754f1b1e39b1525a837b8493ba8434d5e3b.1666787061.git.t4rmin@zohomail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-ZohoMailClient: External X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747754121269106609?= X-GMAIL-MSGID: =?utf-8?q?1747754121269106609?= Removed multiple blank lines that are not necessary before a closing brace. The issues were found with the checkpatch script and were dealt with in accordance with the Linux kernel coding-style guidelines. Signed-off-by: Aaron Lawrence --- drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c index 468f28f48eba..40930c9b0017 100644 --- a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c +++ b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c @@ -321,7 +321,6 @@ static int rtllib_tkip_encrypt(struct sk_buff *skb, int hdr_len, void *priv) if (!tcb_desc->bHwSec) return ret; return 0; - } static int rtllib_tkip_decrypt(struct sk_buff *skb, int hdr_len, void *priv) @@ -420,7 +419,6 @@ static int rtllib_tkip_decrypt(struct sk_buff *skb, int hdr_len, void *priv) tkey->dot11RSNAStatsTKIPICVErrors++; return -5; } - } /* Update real counters only after Michael MIC verification has From patchwork Wed Oct 26 12:41:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaron Lawrence X-Patchwork-Id: 11237 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp244044wru; Wed, 26 Oct 2022 05:43:47 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6btXc2CN8Zbkv9FeKqgNjrtCf0ySLwBN32HAWPrMYA1lNY30SJ2LVDkEBeYpVzQh0a+HiY X-Received: by 2002:a17:907:7b86:b0:78d:cb21:da0c with SMTP id ne6-20020a1709077b8600b0078dcb21da0cmr38482018ejc.24.1666788227650; Wed, 26 Oct 2022 05:43:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1666788227; cv=pass; d=google.com; s=arc-20160816; b=SACofB4bgTgLAJ2yzCvdjVf9EyOC5aVJPh5K/fGD6XN2Uli+O2ecKKnN7UlBD3U9r/ mj2+wyoS0yj6EEX9zk0rOerwxvZAk0YGqNwYzmHmTrpjDKPnET6uZldbsKnWK8sZaE2H eYb1NyGMuSkK2YKnUKXTBQNSXe3MfXDKEtMVBkempXnK0sPtSFWHCPcMXW0Sp8SVTCc8 INvfzfydqTAi0Fpr/4hpySkK5+6Kjh4kykWYMIb3WnXzdt0yppbNwVrYmWi5A6I7sFd0 80YPLgLiQBdmKKp0L6yRmuJClw3dkYQ/2kwD928gz5YJutuz+NxLNaUzmstgV4YqGFCc L8JA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=EnEvUgX/cg7EkNND7kN2OeHnLSvX3S1JlCRvtSnaMjE=; b=Va0LP36/v7VDAVhWQ4mwFku2mtKrnGgtRBthKnKJnYJaR914ZKpv1koYqmVS0M4aS2 24GA38FI0fok4uNfrO5aZdbDAV/vL90bosnu+/+9MH1PyoIFP3TqPHJJOQ3AHnvz+2jQ 7+jua9Z7oz7ZOMWnp8WlLFvdOdZMd89ZgBfzk/6XkEfSllxowMkyUXogc07v3dXWPWxn uQQc9PTJuqf2nso/h4RcWjpAIAf/BAKpj4dBCLpLvQ6sFVZPGBJm/vDJS4n6PljEXzfk cxSLwiKd0z1fe1kLVgqhbdal+hFDg836zYT66cJF7yGQ4LZTirBMd9+62tg2VfeiWMTS jdxQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@zohomail.com header.s=zm2022 header.b=OyyNlnwQ; arc=pass (i=1 spf=pass spfdomain=zohomail.com dkim=pass dkdomain=zohomail.com dmarc=pass fromdomain=zohomail.com>); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=zohomail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h12-20020a05640250cc00b00454599abf52si6740646edb.92.2022.10.26.05.43.23; Wed, 26 Oct 2022 05:43:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zohomail.com header.s=zm2022 header.b=OyyNlnwQ; arc=pass (i=1 spf=pass spfdomain=zohomail.com dkim=pass dkdomain=zohomail.com dmarc=pass fromdomain=zohomail.com>); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=zohomail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233917AbiJZMmb (ORCPT + 99 others); Wed, 26 Oct 2022 08:42:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233688AbiJZMmQ (ORCPT ); Wed, 26 Oct 2022 08:42:16 -0400 Received: from sender4-pp-o95.zoho.com (sender4-pp-o95.zoho.com [136.143.188.95]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D148CEC1E9 for ; Wed, 26 Oct 2022 05:41:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666788082; cv=none; d=zohomail.com; s=zohoarc; b=nR587+sAzj/nSGmJKUbHMJtXGauiUY93OQ0xneYGgdnwLiw3Vc7EqCZu3VJwzG5N+sRGE/lhhcXYXPy318tdN2HiC2lZelteZ7xSucIlY27rHrupNsKiVm6JhmbBhC6+x4l94710O3hGY4hgYYHuxAVrGtZn0+SMhfqzua4Rt9I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666788082; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=EnEvUgX/cg7EkNND7kN2OeHnLSvX3S1JlCRvtSnaMjE=; b=Lu9QhhTe1wpgKAbZ3KOo2oUPkxV7PcMKzOuWChnwYmBkrO20j4iT1I6bIw1QvXqdQ5kgCoJ8zUQFbivace9Dyx+hc2pIyMTmHmTwfyIsIn7K7X/AM03PNNs0Ri8sk4kvKEBEkJJ5lQs2HW5CR7REIcMjL/uAMoGrauewH++hE0k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zohomail.com; spf=pass smtp.mailfrom=t4rmin@zohomail.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1666788082; s=zm2022; d=zohomail.com; i=t4rmin@zohomail.com; h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To:Message-Id:Reply-To; bh=EnEvUgX/cg7EkNND7kN2OeHnLSvX3S1JlCRvtSnaMjE=; b=OyyNlnwQjaMQrcc193eKi32nfmS+6a18V32WoVAqV+SHAaPshbPWpy/nWFR+dMnC 7qZRDU3S4mteTPLUPjQRa6NR62nf8VQLC9tDtgNYWd0HkmraxlGKZKHrYI+w9bQgZ/3 ptLrXVfVmCxuagwiIy0+bENE8yjcDtwuYMNYjLhA= Received: from plymouth (103.47.132.43 [103.47.132.43]) by mx.zohomail.com with SMTPS id 1666788081516748.8350874300916; Wed, 26 Oct 2022 05:41:21 -0700 (PDT) Date: Wed, 26 Oct 2022 19:41:08 +0700 From: Aaron Lawrence To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 3/6] staging: rtl8192e: rtllib_crypt_tkip: fixed alignment matching open parentheses Message-ID: <4253b94d6b7d94713afb02fa63d0a98686e77cc1.1666787061.git.t4rmin@zohomail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-ZohoMailClient: External X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747754132835191296?= X-GMAIL-MSGID: =?utf-8?q?1747754132835191296?= Aligned multiple lines to be at the same indentation of open parentheses before it in accordance with the Linux kernel coding-style regulations. The issues were found by running the checkpatch script on the file. Signed-off-by: Aaron Lawrence --- drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c index 40930c9b0017..6c98f43f967e 100644 --- a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c +++ b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c @@ -271,7 +271,7 @@ static int rtllib_tkip_encrypt(struct sk_buff *skb, int hdr_len, void *priv) if (!tcb_desc->bHwSec) { if (!tkey->tx_phase1_done) { tkip_mixing_phase1(tkey->tx_ttak, tkey->key, hdr->addr2, - tkey->tx_iv32); + tkey->tx_iv32); tkey->tx_phase1_done = 1; } tkip_mixing_phase2(rc4key, tkey->key, tkey->tx_ttak, @@ -372,8 +372,8 @@ static int rtllib_tkip_decrypt(struct sk_buff *skb, int hdr_len, void *priv) if (!tcb_desc->bHwSec || (skb->cb[0] == 1)) { if ((iv32 < tkey->rx_iv32 || - (iv32 == tkey->rx_iv32 && iv16 <= tkey->rx_iv16)) && - tkey->initialized) { + (iv32 == tkey->rx_iv32 && iv16 <= tkey->rx_iv16)) && + tkey->initialized) { if (net_ratelimit()) { netdev_dbg(skb->dev, "Replay detected: STA= %pM previous TSC %08x%04x received TSC %08x%04x\n", @@ -513,7 +513,7 @@ static int rtllib_michael_mic_add(struct sk_buff *skb, int hdr_len, void *priv) tkey->tx_hdr[12] = *(skb->data + hdr_len - 2) & 0x07; pos = skb_put(skb, 8); if (michael_mic(tkey->tx_tfm_michael, &tkey->key[16], tkey->tx_hdr, - skb->data + hdr_len, skb->len - 8 - hdr_len, pos)) + skb->data + hdr_len, skb->len - 8 - hdr_len, pos)) return -1; return 0; From patchwork Wed Oct 26 12:41:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaron Lawrence X-Patchwork-Id: 11242 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp255995wru; Wed, 26 Oct 2022 06:07:45 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6wJ7IkFA0hTcJwtHdsY0SG0qcu8/+B7jGVF5yZiss8OT7fV6kl2BddvM3vMNmQSsHSJhAh X-Received: by 2002:a17:90b:38c3:b0:20d:6790:19fa with SMTP id nn3-20020a17090b38c300b0020d679019famr4185815pjb.68.1666789664893; Wed, 26 Oct 2022 06:07:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1666789664; cv=pass; d=google.com; s=arc-20160816; b=BnbPtP3s/me4xZlle3j36e4LhHn5BRXVM531H2Bhk5hKahiBwZi2oRwT7Rg6Ht7LR9 n5syuRcAhis7XEuX5OZEhlVjhDNtWDJxEDiaTfX1Q+rk57xRRv+ud+/mA6osPWlFqqaA pBV3rZCdhs2msssmCdbpm1657ZtFy4SblarbWBLtQGbPJWgp8yPo8UnBd64JWFclVcJk K5nNuYhrMoQKbPX2UZ7IRA8+xTx58W5J4v020Xj/WHycXvesNSypQBL6aTU+FL5d+X+8 GqJi/n9tFDqFmWzUNZFr96TfoSL41p+5GR8clBuDoPBs9hrnYJn3xBZPSNGkb7sSagLp js4Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=df0mW1Jb9+xh3ALWnyLN9NgJphOGqTv2a+4jnuo89gU=; b=PPNJUaG6bdGJP4YirgiRktkvv3JD4lhnB1sH3bw+iKPxwpRXoh4zTf7VsbR4SX4Psi YrpsVpGp+Z7oCu0Wtpb0IWQCN5tp4ztZYA0MtUfDSw3raMqOBbbEN/MiB8u4qIBmeMjB odCFSFgUV90t8KGG9RtnKBCAFz4gcdsawLCAwoWUt5PJRXXquRIOf2aeFx+8Q5WdCbAx cx0Nb9WW0pyiplEx0HYol4afR5LgOk3XqAJ0MZaGyKqtP2el3UCaW9PnIsFIxQJCCJ+v nAKmw7T4rmazsi33GKiOXmw/CLTJYL5Pji7hDqoe1TTMiZQn/8SofUJ4lSfpENrpacoX xfFA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@zohomail.com header.s=zm2022 header.b=CcKEerF9; arc=pass (i=1 spf=pass spfdomain=zohomail.com dkim=pass dkdomain=zohomail.com dmarc=pass fromdomain=zohomail.com>); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=zohomail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u2-20020a170902e5c200b00182631bdf78si7900326plf.222.2022.10.26.06.07.31; Wed, 26 Oct 2022 06:07:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zohomail.com header.s=zm2022 header.b=CcKEerF9; arc=pass (i=1 spf=pass spfdomain=zohomail.com dkim=pass dkdomain=zohomail.com dmarc=pass fromdomain=zohomail.com>); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=zohomail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233718AbiJZMmx (ORCPT + 99 others); Wed, 26 Oct 2022 08:42:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233859AbiJZMmb (ORCPT ); Wed, 26 Oct 2022 08:42:31 -0400 Received: from sender4-pp-o95.zoho.com (sender4-pp-o95.zoho.com [136.143.188.95]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF09FA6C1B for ; Wed, 26 Oct 2022 05:42:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666788125; cv=none; d=zohomail.com; s=zohoarc; b=HXV0FMfZ6oUW3z1xoYEwmViemlJbzBwYB6VvaT0neiL0/hNyEUcE1d1KX3uifMPg6d1n2LX9eGg74GYJ/95SuYPymlTjpJfk/+1+snbT9aarNKHUfIN/fBrGX4ef+pqGgq03v8qyEMQqdk9+P/SW4DRJvnG0c2OogrQHk39YJdk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666788125; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=df0mW1Jb9+xh3ALWnyLN9NgJphOGqTv2a+4jnuo89gU=; b=dFnxp/Zyu9EKmRD7xUphKtGQ1RkJmcxH3VuxGUwLDb4hgqySck8QW6RSGULjmeMc99Pg5z/VMDLutS+ZfMY87Ww8QeJxgqd1XpWNVHsn4jgCPvV+nnSNN/3W5tn7azPFJh+AuVf7W0VWHdPo1uzN7t8M2RRRANDkjmJdzZCpE9k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zohomail.com; spf=pass smtp.mailfrom=t4rmin@zohomail.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1666788125; s=zm2022; d=zohomail.com; i=t4rmin@zohomail.com; h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To:Message-Id:Reply-To; bh=df0mW1Jb9+xh3ALWnyLN9NgJphOGqTv2a+4jnuo89gU=; b=CcKEerF9AuW+vc2kCRSI+4W2BjFuq3FCqvr0GFP3HDwCOR7OTlb5Ay7a/CLr0Mc3 4AURTkp5t8RDx8mc+dj77n3vjZCeNEwsU5utecsIU9QmOTJULHGXUes5NGfbS8zFTJU YGoZnzV9QavQv7RLWRrEB0RCiMuJoJnp7fkGBrGQ= Received: from plymouth (103.47.132.31 [103.47.132.31]) by mx.zohomail.com with SMTPS id 1666788124753190.8868367598759; Wed, 26 Oct 2022 05:42:04 -0700 (PDT) Date: Wed, 26 Oct 2022 19:41:56 +0700 From: Aaron Lawrence To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 4/6] staging: rtl8192e: rtllib_crypt_tkip: fixes on unbalanced braces Message-ID: <641d8360c5f86b54efc96d7f8ef70be1371db480.1666787061.git.t4rmin@zohomail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-ZohoMailClient: External X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747755639854235677?= X-GMAIL-MSGID: =?utf-8?q?1747755639854235677?= Added braces around needed arms of statements which needs them in accordance with the Linux kernel coding-style regulations. The issues were found with the help of the checkpatch script. Signed-off-by: Aaron Lawrence --- drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c index 6c98f43f967e..d1b86de76eb2 100644 --- a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c +++ b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c @@ -276,8 +276,9 @@ static int rtllib_tkip_encrypt(struct sk_buff *skb, int hdr_len, void *priv) } tkip_mixing_phase2(rc4key, tkey->key, tkey->tx_ttak, tkey->tx_iv16); - } else + } else { tkey->tx_phase1_done = 1; + } len = skb->len - hdr_len; pos = skb_push(skb, 8); @@ -610,10 +611,11 @@ static int rtllib_tkip_set_key(void *key, int len, u8 *seq, void *priv) (seq[3] << 8) | seq[2]; tkey->rx_iv16 = (seq[1] << 8) | seq[0]; } - } else if (len == 0) + } else if (len == 0) { tkey->key_set = 0; - else + } else { return -1; + } return 0; } From patchwork Wed Oct 26 12:42:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaron Lawrence X-Patchwork-Id: 11240 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp253911wru; Wed, 26 Oct 2022 06:04:37 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7VN3utUcD4CPlrXxYlihz0MrN2sV1EuqMuNuDN5LSsHMGyoNRUKrOe5ZmdO10Vl5nqJtF0 X-Received: by 2002:a17:906:9bc8:b0:7ad:7e6a:50ac with SMTP id de8-20020a1709069bc800b007ad7e6a50acmr2358602ejc.66.1666789476812; Wed, 26 Oct 2022 06:04:36 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1666789476; cv=pass; d=google.com; s=arc-20160816; b=H32knKg6esQmWap90qhMINlZn6eyURvRtzkylo0et513KSJ7uSHCxMVaKlaehkKb3D Pm1KukJG236QbwEmLlPq+P71rg0KL25A4tdt6hwj6fneV3uDmPurV7hqdgIPbFyEaWnI deFv/8YbERunlNxZMfwgDfkZDxLk/ZAThFe0x++8+v/VgfTdU8YYmJJ9nKOFMWQkvnh0 uU7N9rqmWSDXThBZVNH9aBx53rx7kGr5Wn4gQQO+ULQFWcZya3c9fL8VoCysmk3/txf9 NkE+D/RT75mV0a0w/mQwzZEPgpjupqfSKQQ8v+sMSxsUuclg+TrfTuvMEsFJhkrD2rmJ n/zg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gn9CWmy4W7rmZ/rwXWSEgHAWya2y6DKl9JZAkcJcx+8=; b=WL7umxvrCVCCao/retpVXL4SB5nQ6el0FFZ2y7PzSN8oV7GaBx/yvTUN5NSFOfXGL5 9gos0sXwvHB6xlZlcOM4qFA3rHQrrRt3/N06yZFVdV0ZnPSlndk0E64mkGPuNYQIfZH/ lg8Z1YsG0IZabwCTfcDaTUTvKNZjC4aGP2CT/LrMt0RzxdUkkuRbJ+m+rmTjRCLUZNK5 nODjiqVBJ1YXs7dOcVFaQRVf+mM4SmsnVbHBhqo3i41Dh+UfytoRSlveYvqP3BjWl5pE EoJC5hbqzN2cHk+xiI0R6fLsBXtIHdFZwW0Lq2MsNpUw6zLxUFYAgeh7WiEDTj6Uly0J 5dLQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@zohomail.com header.s=zm2022 header.b=OlIEGgpf; arc=pass (i=1 spf=pass spfdomain=zohomail.com dkim=pass dkdomain=zohomail.com dmarc=pass fromdomain=zohomail.com>); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=zohomail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qw38-20020a1709066a2600b0073d9c412570si5336479ejc.785.2022.10.26.06.03.52; Wed, 26 Oct 2022 06:04:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zohomail.com header.s=zm2022 header.b=OlIEGgpf; arc=pass (i=1 spf=pass spfdomain=zohomail.com dkim=pass dkdomain=zohomail.com dmarc=pass fromdomain=zohomail.com>); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=zohomail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233757AbiJZMnL (ORCPT + 99 others); Wed, 26 Oct 2022 08:43:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233641AbiJZMnK (ORCPT ); Wed, 26 Oct 2022 08:43:10 -0400 Received: from sender4-pp-o95.zoho.com (sender4-pp-o95.zoho.com [136.143.188.95]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D7F81A209 for ; Wed, 26 Oct 2022 05:43:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666788185; cv=none; d=zohomail.com; s=zohoarc; b=VhtDcv9QqQmhe/+i5FaDmjXoI0uKRy68wpAEUQRBht5dkLyf3K5uAzW1kJPHgDBLkDTZw7Yn+4v+patub59VWkqJHG8TP1ai9Q+4MRZlSfOAVLtCiHcO1W83SHAtm+YtxNfbxicqurQhRxRNEfXOwR15iBO4ZKHBq3GlXloxEGA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666788185; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=gn9CWmy4W7rmZ/rwXWSEgHAWya2y6DKl9JZAkcJcx+8=; b=BcpmUA4XhoyhPWGwznGP6pqWGJhg9xzD4iVpNj0vlqnLslAhqZsSvOdt7oOn9O05obyRzEE/ZHjCcg+9PwH7qdOuscOAmuO+AG2FrE10VAA524eA7moNzDnbJawrzEPyOiUY+4WiZV9+/j/tOVWCzd5s/6uCJAFWn7mk95Kq1I4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zohomail.com; spf=pass smtp.mailfrom=t4rmin@zohomail.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1666788185; s=zm2022; d=zohomail.com; i=t4rmin@zohomail.com; h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To:Message-Id:Reply-To; bh=gn9CWmy4W7rmZ/rwXWSEgHAWya2y6DKl9JZAkcJcx+8=; b=OlIEGgpfjt8ftu+jBMfBvsLDv6mv06kzsJ82KAy3RBNwKnWDb814hQO7FBLP4u9A Nx/vsnJJ9WOkGAtHfMc5qWZmsCblatKWL3vHIvkIxsv5t6i+G2iCGa9q6s06jqC9/Bp eIaVC2+4ftbSehWN/LJNYrX4Mqcmr/OA6VKkrJqE= Received: from plymouth (103.47.132.34 [103.47.132.34]) by mx.zohomail.com with SMTPS id 1666788184977888.9014581744829; Wed, 26 Oct 2022 05:43:04 -0700 (PDT) Date: Wed, 26 Oct 2022 19:42:55 +0700 From: Aaron Lawrence To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 5/6] staging: rtl8192e: rtllib_crypt_tkip: split multiple assignments Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-ZohoMailClient: External X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747755442126338419?= X-GMAIL-MSGID: =?utf-8?q?1747755442126338419?= Split a multiple assignments statement to individual assignments on different lines in accordance with the Linux kernel coding-style regulations. Also repositioned comments on it and the statement before for increased legibility. The multiple assignments issue was found by the checkpatch script, with the comments legibility issue were through direct observation. Signed-off-by: Aaron Lawrence --- drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c index d1b86de76eb2..b8a52b9f9d07 100644 --- a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c +++ b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c @@ -488,9 +488,13 @@ static void michael_mic_hdr(struct sk_buff *skb, u8 *hdr) break; } - hdr[12] = 0; /* priority */ + /* priority */ + hdr[12] = 0; - hdr[13] = hdr[14] = hdr[15] = 0; /* reserved */ + /* reserved */ + hdr[13] = 0; + hdr[14] = 0; + hdr[15] = 0; } static int rtllib_michael_mic_add(struct sk_buff *skb, int hdr_len, void *priv) From patchwork Wed Oct 26 12:43:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaron Lawrence X-Patchwork-Id: 11241 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp255943wru; Wed, 26 Oct 2022 06:07:41 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6IjWrD/UzL9b/H74xlQdO/lqrJpzt49MRCvWVp/KAbNZXLWue5wN4lRV1id+V4FPHCEBx6 X-Received: by 2002:a17:902:e9cc:b0:186:8816:88d4 with SMTP id 12-20020a170902e9cc00b00186881688d4mr24175070plk.59.1666789660938; Wed, 26 Oct 2022 06:07:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1666789660; cv=pass; d=google.com; s=arc-20160816; b=BEmUEFNp0Q8+caIxlTQCQDEUTcvKrHkrv9A3WIfVuM1B6lwdattb/iPtVA2GrqUzXp 10/Uu/VNWtODmwrb1pkhrHo8UwtxytJaAZKj7ceI22niAd4VdNQCsKX8E9vuOUQpsiRb 6sUFAExcI1Irh20HMB7RnSI6Xq3aPrj9cgwxTYfBJLVllgirmmoW7J/yofyYevy0xQQL nexlLoY+6fxef8odzZlK4WNkwSm3E9dQmnpLXmf751AFa6TS5HNXnWbKeOXLO0hmMyi9 Oc3y9lggtjsj329/z0WqUA+lVvligCEBf3Czrcy294Sd/dewZPk015+7Er0hxVn7qPyv TfzA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=NhEnCBIWiWhW0byYC8XES1kb52GQs7ocwSW0WqCzYhU=; b=fSPKZNd8/QtzgzWGmzMzNftXwKmjCyrSCV7+tSMCIVKzzm2dkXUP5qR/teeLTql1Wz cOyyGKhy4mYYaUAkrSrxcW7U6PZ8OjgQiRk+EU6EY0vCcGWLvFySb9p0weOgq+kcPvE9 ik+/C6AW7jwl6LgRZDy+wgREc/U/+atnR2U2dwPW87ECqzffrVBi8ZIfad530FnnmRw2 wjSH1yXkyBfKTQDNJ018+iMA+k32HIyzyGQpnlnw4ECsxau/apzMqq/dkVADwFnNJ8i6 elf4rZwnvXKpIPZ9GUhvf3ormblIKWGeMqLxJjNO7Pul+bcbKf5RZZEhMwAr26EDOmql mRZw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@zohomail.com header.s=zm2022 header.b=KREsLJTu; arc=pass (i=1 spf=pass spfdomain=zohomail.com dkim=pass dkdomain=zohomail.com dmarc=pass fromdomain=zohomail.com>); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=zohomail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o6-20020a170902d4c600b0017a0d1d072dsi5315707plg.336.2022.10.26.06.07.26; Wed, 26 Oct 2022 06:07:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zohomail.com header.s=zm2022 header.b=KREsLJTu; arc=pass (i=1 spf=pass spfdomain=zohomail.com dkim=pass dkdomain=zohomail.com dmarc=pass fromdomain=zohomail.com>); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=zohomail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233067AbiJZMoM (ORCPT + 99 others); Wed, 26 Oct 2022 08:44:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233884AbiJZMoF (ORCPT ); Wed, 26 Oct 2022 08:44:05 -0400 Received: from sender4-pp-o95.zoho.com (sender4-pp-o95.zoho.com [136.143.188.95]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3834F95B2 for ; Wed, 26 Oct 2022 05:44:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666788241; cv=none; d=zohomail.com; s=zohoarc; b=QN5FgsdNhFnCRS91LIc1akmaEeCbcgyHzXjErDezIqawzV0F+aaazgd79hi41Y73rHxyqkYU02iTRcsPBx4/aD06+yhV7AP9aKy50I8vJcU9nyfKjMQ3zk2DaIo1z3V+uSxsC2xT3nsbzNpDWe3+fg0FKWyn8xJmGGhlJHHYf/I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666788241; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=NhEnCBIWiWhW0byYC8XES1kb52GQs7ocwSW0WqCzYhU=; b=dky9QHdmNKDaZRvMGqvVSC0P9sT8h8h98WHNxHqJ6+4ioBbuCQc8z9Scgc7ymzcr3+vHTz/bLrxk1M9fOGSeg/Z20PZuHOx+dC+RgtEHWbvoR008mRrf9iL9bkpBlYQrD5wmFiT9NuJdiepvT110Jh15eKYLHZQbv9Rj2ICJHo4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zohomail.com; spf=pass smtp.mailfrom=t4rmin@zohomail.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1666788241; s=zm2022; d=zohomail.com; i=t4rmin@zohomail.com; h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To:Message-Id:Reply-To; bh=NhEnCBIWiWhW0byYC8XES1kb52GQs7ocwSW0WqCzYhU=; b=KREsLJTuBSGqOnc1o8WLJhi4ND33J/qKx8k2x3pg9Q/TQ8AyZFRSh4rXbc8tAcmT GJ1JTXY/+F4PDQ6I600+rcppd5k9cmYs42bqlVUHlP7JTB6yvaAJky/DHlahGLUq6YC DyoH9iVJooVktIgqsI5pU5IIQqSt1r2ckOFE2VEI= Received: from plymouth (103.47.132.12 [103.47.132.12]) by mx.zohomail.com with SMTPS id 1666788239134352.55749610584144; Wed, 26 Oct 2022 05:43:59 -0700 (PDT) Date: Wed, 26 Oct 2022 19:43:51 +0700 From: Aaron Lawrence To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 6/6] staging: rtl8192e: rtllib_crypt_tkip: rewritten comparison to NULL Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-ZohoMailClient: External X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747755635494865709?= X-GMAIL-MSGID: =?utf-8?q?1747755635494865709?= Rewritten a comparison to NULL with a negation operator in accordance with the Linux kernel coding-style regulations. The fix was directly recommended by the checkpatch script. Signed-off-by: Aaron Lawrence --- drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c index b8a52b9f9d07..9fdfcc017ee6 100644 --- a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c +++ b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c @@ -62,7 +62,7 @@ static void *rtllib_tkip_init(int key_idx) return NULL; priv = kzalloc(sizeof(*priv), GFP_ATOMIC); - if (priv == NULL) + if (!priv) goto fail; priv->key_idx = key_idx;