From patchwork Wed Oct 26 03:27:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 11181 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp180978wru; Wed, 26 Oct 2022 03:41:52 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Pv08mBU9sCC58GLs5QmkgGECePRTeU7mIyanHORxNVxp8aQpozNVayuFSiKCf2U0p7Ahf X-Received: by 2002:a17:90b:4ac5:b0:20d:ae54:f08b with SMTP id mh5-20020a17090b4ac500b0020dae54f08bmr3535733pjb.174.1666780912480; Wed, 26 Oct 2022 03:41:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666780912; cv=none; d=google.com; s=arc-20160816; b=pjXI/z37ruTpTJNuVB3JV5jaeq9ExqaPwArxCPErYSBMYdtnvQGh3uEh8pL7lsJHew 1ACYmx84Y76ScI24lrCqe8fNFQvdZC7gveyUxQgAT88OHMm0fPHd+TadD5sN4Tx1kr0K eIzKPKnDJwW8Ifipskzx2R/Q1uafneA8wBdKsxs0uVs/R8YNF5pPZrkQRhqYwlUaHG+o LjPGwfkU0d8KKsS+iciqrCZSfJUY4M/3la7v/gbvRH1JYK4Vf6dMDQNrQ2UUPOynyU8A SpR0vGdftaDCeWeKRHKkG2Ih2P0LuSKgXzzKc2S/4EtyIpHs7+6MddojwuiEMWgZw4am 2xGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=UFudnzS+bNCvZ7hhB1VC5Wsev4Zye6ff5kGsWvMTUE4=; b=MDVrnl6N5MgOy8cCUYTZWjJG3A2cbTETYHKVfw3Tf6zwuHntsdmenaMQ8Zt83WxoBm WtiXnk2X7u8B/NzAi6HrZbf0/sD2q7ghosfo0nOUeqUEPoxaEI45Whva06oT4jfAr9zP MkdtZSqEYQghwicfMoTvkxX4wwK4AlfuqEOtWnuUDY0sp1gUWd5IEW6vJNmhaO6PNKeu iygTQh/jwbLmks7uNrWd9thTzhPKTSiiVks+airhvVxxBjFTFRAh0SlraFPR3OXoLAqb RdxK0n5Ep+NyogQCuNEGTgioS+R0BybTf6KfzYudCjRziAFEcikl+4W3gk+ji/9RM3QY wiqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=hzqCngcJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c17-20020a170902f31100b0017811e3927bsi4614761ple.622.2022.10.26.03.41.38; Wed, 26 Oct 2022 03:41:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=hzqCngcJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233159AbiJZKgk (ORCPT + 99 others); Wed, 26 Oct 2022 06:36:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231877AbiJZKgj (ORCPT ); Wed, 26 Oct 2022 06:36:39 -0400 Received: from msg-4.mailo.com (msg-4.mailo.com [213.182.54.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 001477AB36 for ; Wed, 26 Oct 2022 03:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1666780585; bh=Nu1SWNtGRTsJcwbwP/PERGl+2UsXTpRN4McY4HN8/lU=; h=X-EA-Auth:Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=hzqCngcJ3D74gZj2HTKcDVabu5ff2OFAjuk8kImoZz+jEtFE+iwW1IBX3K423H1Bx cweHeqCgkWRRqyj4jAdN04YoI2ECGCtYm/0mCjWlnZe8g4pCHpJS2dU6UypT96UwVZ 7lzzs2Qn5/qLLLrDACdUuZglS3sOqS1ByrhaqdTE= Received: by b-2.in.mailobj.net [192.168.90.12] with ESMTP via [213.182.55.206] Wed, 26 Oct 2022 12:36:25 +0200 (CEST) X-EA-Auth: y/mb8iDgGK/LUCLB3d9Yyf+f8YvHkDUOK07o/RseykjYFs9uRR5y5S+zFb7fRulsBZmvsdLjVduxZR90zqY1ubUqOpWVaCBA Date: Wed, 26 Oct 2022 08:57:48 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] staging: rtl8192u: remove unnecessary function implementation Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DATE_IN_PAST_06_12, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747746461859214761?= X-GMAIL-MSGID: =?utf-8?q?1747746461859214761?= Current implementation of function ieee80211_tkip_null simply returns back to the caller without any useful instruction executions. This makes the function call and its implementation unnecessary and should be removed. Signed-off-by: Deepak R Varma --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 3 --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 6 ------ drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 --- 3 files changed, 12 deletions(-) -- 2.30.2 diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h index 9cd4b1896745..00c07455cbb3 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h @@ -232,8 +232,6 @@ struct cb_desc { #define ieee80211_ccmp_null ieee80211_ccmp_null_rsl -#define ieee80211_tkip_null ieee80211_tkip_null_rsl - #define free_ieee80211 free_ieee80211_rsl #define alloc_ieee80211 alloc_ieee80211_rsl @@ -2256,7 +2254,6 @@ void ieee80211_ps_tx_ack(struct ieee80211_device *ieee, short success); void softmac_mgmt_xmit(struct sk_buff *skb, struct ieee80211_device *ieee); /* ieee80211_crypt_ccmp&tkip&wep.c */ -void ieee80211_tkip_null(void); int ieee80211_crypto_init(void); void ieee80211_crypto_deinit(void); diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c index 7b120b8cb982..9bfd24ad46b6 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c @@ -716,9 +716,3 @@ void ieee80211_crypto_tkip_exit(void) { ieee80211_unregister_crypto_ops(&ieee80211_crypt_tkip); } - -void ieee80211_tkip_null(void) -{ -// printk("============>%s()\n", __func__); - return; -} diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c index b94fe9b449b6..3f93939bc4ee 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c @@ -159,9 +159,6 @@ struct net_device *alloc_ieee80211(int sizeof_priv) ieee->last_packet_time[i] = 0; } -/* These function were added to load crypte module autoly */ - ieee80211_tkip_null(); - return dev; failed: From patchwork Wed Oct 26 03:28:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 11182 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp181434wru; Wed, 26 Oct 2022 03:43:10 -0700 (PDT) X-Google-Smtp-Source: AMsMyM68vNROlLFKBIbXtSNwvTj2u1kQL1MbG/Zm4iRuvskuzI2xchHyubYRJohkZ5PRBelaw3mc X-Received: by 2002:a63:5950:0:b0:459:35df:3014 with SMTP id j16-20020a635950000000b0045935df3014mr36544842pgm.325.1666780990247; Wed, 26 Oct 2022 03:43:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666780990; cv=none; d=google.com; s=arc-20160816; b=foH4z+/HCEifNTtg/Eq8hitxJJ4r+6PH6t4pfwv47Hlz7RTScktPcTMqRVAus+vc9q EdSgzegmOZOeivGTz9Fzqj+wA0Bl5S/7iDH0eCf6Ul3yXjFVNFgGCLLhj5ip6jC01hVF euekCkyzBnhoYSAASew3/G5U8IFfiUSWHTeJjNeYlvvX+fZJjB9f4jpkw2ULdbhAm5Dn w8AdDAkgrli4Z/JVPdgEc28G8lP46K+zWSm9o0FUKbd3YyqFsQk9TvhWBvOuOTeR3BXj HWvdxPBIiL+qTLt5XGkRtojOUIgicLhfZPbp65Jzzg33pVekHzb4+BI9XIeyJJ+4/KYL u+NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=ecBY38ARrvZ8Rk4pVLNDMk2mHsnyvAaOR8Gw3uIs2+E=; b=OTOjNjCTU/FCGGM25ZIGXYPN5SyDDZwFXcwuOdkTugLdetpSXzwWB/WWaxjJKvdz3A CjYhfroYAUJN8c2qy4svUR3YiqRDcj+Nycuoe9vPuQgrsyByn6kOkdYTkiybliP+jZHR MmK7i9Dqwy+x9KgPOUhjDQYmWffJQpemTpiFO4/94UEeSboW1yBvyFkMoR0gpv+EfPHx 2T9ra9waDWu0Jio5otbLwovB2UIOuRsX8D4Me4DNg5C3JAHgeYaaA6wT6giwdusqdtQ+ HurIozDImsIdeY6nLBp8tBzU+zO3BCllkVZ8OfL5vqAKhLneGV/1pC5MJki9sBCrvFs1 ey0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=n9MF0KHe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c2-20020a63ea02000000b00438806c7b2bsi5601561pgi.154.2022.10.26.03.42.54; Wed, 26 Oct 2022 03:43:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=n9MF0KHe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233356AbiJZKjq (ORCPT + 99 others); Wed, 26 Oct 2022 06:39:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbiJZKjp (ORCPT ); Wed, 26 Oct 2022 06:39:45 -0400 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E06C34D4C9 for ; Wed, 26 Oct 2022 03:39:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1666780641; bh=2o2vObTUWUB0Kdk6K5kLMVJ/u7FvQKx9DpX0JHVrhzY=; h=X-EA-Auth:Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=n9MF0KHexYUfDnyDE20lf405Xu6eQgg5AD5PItaKVVcUlo/0pSqv2Uo8X9GKspeLF kIQHC/9qfA8NkdVphP9gpGmrjfwXyXJgkE0cfHw0ToeWMZHAGe1rSE8zlb0NOCrEd3 8Py/EIBBA+0A8igYR+rev85Ac5ZXBOYREYl3lbPs= Received: by b-5.in.mailobj.net [192.168.90.15] with ESMTP via [213.182.55.206] Wed, 26 Oct 2022 12:37:21 +0200 (CEST) X-EA-Auth: H2CtVnUc+erUdiJhAzCjTta69U9/k8Kq8sa4I6xa+4zRi0CNntGfIIw5oc42fnlqqx4kU74pVOSz5wALBQUyjFZB9nU7T7yB Date: Wed, 26 Oct 2022 08:58:44 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] staging: rtl8192u: remove unused macro definition Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DATE_IN_PAST_06_12, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747746543763418161?= X-GMAIL-MSGID: =?utf-8?q?1747746543763418161?= Pre-processor macros that are defined but are never used should be cleaned up to avoid unexpected usage. Signed-off-by: Deepak R Varma --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 2 -- 1 file changed, 2 deletions(-) -- 2.30.2 diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h index 00c07455cbb3..0b3dda59d7c0 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h @@ -230,8 +230,6 @@ struct cb_desc { #define ieee80211_unregister_crypto_ops ieee80211_unregister_crypto_ops_rsl #define ieee80211_get_crypto_ops ieee80211_get_crypto_ops_rsl -#define ieee80211_ccmp_null ieee80211_ccmp_null_rsl - #define free_ieee80211 free_ieee80211_rsl #define alloc_ieee80211 alloc_ieee80211_rsl