From patchwork Tue May 30 21:32:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Marko X-Patchwork-Id: 101125 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2477337vqr; Tue, 30 May 2023 14:41:26 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ68qYI2pQJ78JQ1Emk1JiDayvPXJ3rlenu3hDN54Hz6aXtFvBmKxRtZJryCukH5rv/wwstf X-Received: by 2002:a05:6a20:6a25:b0:106:4197:b7ff with SMTP id p37-20020a056a206a2500b001064197b7ffmr4279909pzk.30.1685482886464; Tue, 30 May 2023 14:41:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685482886; cv=none; d=google.com; s=arc-20160816; b=jpJA/aIjn9QBKN6Klr1tntcG8myDhtLmMLiX6OeXjt3YZVGRN7BhhMhkEQ6tE4KonA uJ8khvzwSR0IyKgtQoyhJutsc0LFF/PLEb0FhmiE+T/Eg+44V4izhUtNhTdm0AmIrRaF SnsyclHLddUx32V/l2S9XN4hDCCyzcGRLQR82anSH4lF4jHcNIORR2NL9JzILnZJeIOi w2xUXqyn1Mt1/yP3fcYZ+0XGF1tFlNk3CmM0A6RhgTX2+Jjw26d6JrxlQGK0E3gwDQv4 kOftceI1j/zu8iwMndV7DolkXMY1fYeCUbiRlUxrJS+VO2CxtKNPlDCrAnSmIgPPzryw yWAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=p4thltDnvTnlkXvabi6DDHwtW6w1tP1Qc9yaZzyE2MQ=; b=GcyMy1RljF+uyPud6Orh9R7W6UIlMI3Rg+FHEjYPT/znQQZqa5Vf52y87j9+a7sYcJ W+vZr6XQZpF9/FQHbbfSy16DlmfGHY+xgTdbDHAJzIi35w/MJkR+BtiO3UJW2YVn8nAk GbY58zc8IL9qlb/918UCZGm8ldcFz0lPhLyHqS6/AFAhLhM6YG4J0vOOFhVq4f/uSj1M ylHi+APh8dcGBWylGtMTiOL6WouRx39uXqc/6B8NGrls9hJF12u9hNM5OTDzsKeejwlD GtOPuwH2FZpIlEBMk2DMVxppXthwu+T4wG6MHTgXxR/s9TpJqf9S6j3hfPfZ2WbLVK8k 8SeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="U8KP4kB/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y13-20020a637d0d000000b0053ef5472644si7154855pgc.482.2023.05.30.14.41.13; Tue, 30 May 2023 14:41:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="U8KP4kB/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233534AbjE3VdI (ORCPT + 99 others); Tue, 30 May 2023 17:33:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbjE3VdF (ORCPT ); Tue, 30 May 2023 17:33:05 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE767C7; Tue, 30 May 2023 14:33:03 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-96fd3a658eeso718620566b.1; Tue, 30 May 2023 14:33:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685482382; x=1688074382; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=p4thltDnvTnlkXvabi6DDHwtW6w1tP1Qc9yaZzyE2MQ=; b=U8KP4kB/s7nu+wU162TLn0eIBYFn/6Jk1IGiotrCuctoVw3pToCkDkzwQLIbuNbxBa lSz460Y7M9tIr4/aGlZX/eChDnU+qXgOTZjHq+fsLHZdHJhqQPdiHpKKSpcJzba8hkep i8c/pvQMP8AatGGBDBgc1Ge3SAMDMdvy+Th5/yGu3OUHvJ+Auwm6LVNlAm0p3Wbvye9Y 10JOp27Jx2wQ9BVYttdCoxoVEAu1QG4q3hBCg+6k7VIOY2QUkb4EofO6v9Ma2cH0caTE K7oHz7zpCjELKHhjqjnM+GEaCXPQ1Y3v6rRCRWeVNPOPDQXVl7LGXAbY6NXTFgcDBB2f Ce2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685482382; x=1688074382; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=p4thltDnvTnlkXvabi6DDHwtW6w1tP1Qc9yaZzyE2MQ=; b=BiVvqjKetaxNPmS0/bawaBwxYYaDWZdnmnZGdCyVJNnASrqv4yt95wyU5YKI/GXMuu UGD1ghKfo5pmJOK8mFd6PIHWFGf0s0230awnDnstIOZZYpxUtTXs8tjytkjGpE0XIi0e cDRoNeH8UjAOF5i0i7bp9xziYuTJNL9i6UDyIs8Kl2XjfCGv2MWSUEo4tt9QuFoBLUuW XO4iZv5uMk5ftDhZEtTsPsRgrGFwtZaPs7OF6I1qTGEb/nNNyS4rCRFg1ZBpaW2YvBuE c1o4tLTp4p60euYTCFbB8+iJirjln4NOKmjfxbNSoUtLG+HKikeXtRx4XVDkvZ2Nul6H ydCw== X-Gm-Message-State: AC+VfDxeATk7910ogVVJS9W7d7Z/8cQHfDnGr2IkXIvAXWEtPayWuDKL YiRB2jUMQIdadlTM65EEbYJgOOuw6/vp7w== X-Received: by 2002:a17:907:72cc:b0:96f:baa4:cda7 with SMTP id du12-20020a17090772cc00b0096fbaa4cda7mr3341540ejc.68.1685482382070; Tue, 30 May 2023 14:33:02 -0700 (PDT) Received: from fedora.. (dh207-97-232.xnet.hr. [88.207.97.232]) by smtp.googlemail.com with ESMTPSA id oq27-20020a170906cc9b00b009662c57b4ffsm7882319ejb.96.2023.05.30.14.33.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 14:33:01 -0700 (PDT) From: Robert Marko To: ulf.hansson@linaro.org, windhl@126.com, avri.altman@wdc.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Robert Marko Subject: [PATCH] mmc: core: disable TRIM on Micron MTFC4GACAJCN-1M Date: Tue, 30 May 2023 23:32:59 +0200 Message-Id: <20230530213259.1776512-1-robimarko@gmail.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767356902917148773?= X-GMAIL-MSGID: =?utf-8?q?1767356902917148773?= It seems that Micron MTFC4GACAJCN-1M despite advertising TRIM support does not work when the core is trying to use REQ_OP_WRITE_ZEROES. We are seeing the following errors in OpenWrt under 6.1 on Qnap Qhora 301W that we did not previously have and tracked it down to REQ_OP_WRITE_ZEROES: [ 18.085950] I/O error, dev loop0, sector 596 op 0x9:(WRITE_ZEROES) flags 0x800 phys_seg 0 prio class 2 Disabling TRIM makes the error go away, so lets add a quirk for this eMMC to disable TRIM. Signed-off-by: Robert Marko --- drivers/mmc/core/quirks.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h index 29b9497936df..77caa0c903f8 100644 --- a/drivers/mmc/core/quirks.h +++ b/drivers/mmc/core/quirks.h @@ -100,6 +100,13 @@ static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = { MMC_FIXUP("V10016", CID_MANFID_KINGSTON, CID_OEMID_ANY, add_quirk_mmc, MMC_QUIRK_TRIM_BROKEN), + /* + * Micron MTFC4GACAJCN-1M advertises TRIM but it does not seems to + * support being used to offload WRITE_ZEROES. + */ + MMC_FIXUP("Q2J54A", CID_MANFID_MICRON, 0x014e, add_quirk_mmc, + MMC_QUIRK_TRIM_BROKEN), + /* * Some SD cards reports discard support while they don't */