From patchwork Tue May 30 14:00:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 100870 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2200925vqr; Tue, 30 May 2023 07:01:19 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4IU2dypPp8xBkhC0JqZgt5eaomvd15tlTBBk7M545aQTuVW8T2fgPPqCc0IDyJjKIxRlyg X-Received: by 2002:a17:906:4789:b0:966:5a6c:7549 with SMTP id cw9-20020a170906478900b009665a6c7549mr2604592ejc.14.1685455279443; Tue, 30 May 2023 07:01:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685455279; cv=none; d=google.com; s=arc-20160816; b=z601Zzc7skr+xYVJ698bn9tMsqihCe+3YfUT282QKHYq8/GmGQtiOKCqYXyquRFaHb GiRNnF+fgPlwTgdG83YLSUSCpAalOp/LqbjkAHbdjdcoME+vhXSji536gKR8ouzjxUBV ybXaoRF2BFdW0++ntlAoB6XXsxDyiyfLx6S0yl+YZryAen9OOrgLhrIVG7GytRmUS6YC j3dKYyxAbwS2MJoavujNgP3h/C8KMn+o5Xj9GOvKGnEOolpWS2Zm+o106F1DNJfeZzfQ 7iJ3uBTO9upx2EHJwtwzRoWtboo8LEmUttVinXYEwAgEI0AN5BM9nFjxv+A0RH0QybYD 3f0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=4JLpAzy0juXy4uPEW9+KbXrgS4Tos8zyTS+ZKw3ITKg=; b=oktWJuHd9fOUqIquI8JSXPNK2qWDLV4XXljDz264lONOjWravQNdqVdME6Z/woPqXW H6RS1WhtqzSAJYqwgZvfc//qZXyhZb8vLl56Fma+zvyjv39JaECh8ny1zH8Gxzlw5d7Q rRKuxIKMcPYFvnUZyCJM0tfek7+b6Uaiwk/+z+yD+BtC86KEkd+c3T4tRFM/WhIATrK2 McghpqpGiYc0bvzs/wQqWdPo5l9ajFKSsMg5A8JrKX2m5JPO0ebayNa1w1GAlCNQbLNW 4wqKA3b39cxvrueTF3ugcJ4puCP7gcoitQw3/P5e39cKNfFytzSwbdkXhUF+ljyO4PHu g9TQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=QiiAN3gJ; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id h19-20020a170906261300b0096f69a2f32asi6242399ejc.657.2023.05.30.07.01.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 07:01:19 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=QiiAN3gJ; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4D01F3858431 for ; Tue, 30 May 2023 14:01:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4D01F3858431 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1685455278; bh=4JLpAzy0juXy4uPEW9+KbXrgS4Tos8zyTS+ZKw3ITKg=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=QiiAN3gJQLH+Zhx0rM5VWE8lfnyD0yyKklmqOmbnXUPlJI3BnE0UWmmz0pvObZxV0 9Gx4VydTnOziW60jFXUS50bba2cPxiy/4iFe7v0kyIJcMvZl0lwijs5TGHwtjyeHY/ UCM8JOB9OagV2Vo6JkpiEl4K8GSVMUnn+UcE3Efg= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-oa1-x2c.google.com (mail-oa1-x2c.google.com [IPv6:2001:4860:4864:20::2c]) by sourceware.org (Postfix) with ESMTPS id DF4AC3858D20 for ; Tue, 30 May 2023 14:00:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DF4AC3858D20 Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-19f7f41d9dcso1284796fac.2 for ; Tue, 30 May 2023 07:00:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685455233; x=1688047233; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4JLpAzy0juXy4uPEW9+KbXrgS4Tos8zyTS+ZKw3ITKg=; b=I4BENbKmotPTujhUErbNAxOlRHvXAdvGDzn4otrre0OEEg2mtATEbdDN1BXXdB/xhL O3BYAds3IP5buWoezzTmNyqPZb3o2kKj5W3CQe6f2Oi6s80zig3QjE6pPrJJVerBZsKL N6DWVpAxCXn40IfshafPlbZ1bKAGSj5hcRcP7sfgjCPEhNoq1ddsDR7kEQesR3LUH4a5 9qnEVhGbxN78fMeosntcL9P/MzcQqJO296myR1gDgjVjDBgWddg944y+YJeQG7RuHqkE kA/EBAsm/ByIPjTJu54BE4XAf64lDMgJ/uoDFnRw2h06SqpNo3s1F815N245hYyuKbiW IAtQ== X-Gm-Message-State: AC+VfDwuRZc724ci60a3fLnaeUuwewTw7ve1qA/7M35M9GG7KPUFOhcD PGO63ODIFXVatMbkVeEj0Q8hy4/wvrullnlx+VUgcQ== X-Received: by 2002:a05:6870:b6a5:b0:18f:57b0:a952 with SMTP id cy37-20020a056870b6a500b0018f57b0a952mr1299982oab.15.1685455232757; Tue, 30 May 2023 07:00:32 -0700 (PDT) Received: from localhost.localdomain ([139.178.84.207]) by smtp.gmail.com with ESMTPSA id g4-20020a056870340400b001718e65a5d0sm5774521oah.57.2023.05.30.07.00.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 07:00:32 -0700 (PDT) To: gcc-patches@gcc.gnu.org, Kyrylo.Tkachov@arm.com, chris.sidebottom@arm.com Cc: Christophe Lyon Subject: [PATCH] [arm][testsuite]: Fix ACLE data-intrinsics testcases Date: Tue, 30 May 2023 14:00:20 +0000 Message-Id: <20230530140020.1108499-1-christophe.lyon@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christophe Lyon via Gcc-patches From: Christophe Lyon Reply-To: Christophe Lyon Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767327955222711787?= X-GMAIL-MSGID: =?utf-8?q?1767327955222711787?= data-intrinsics-assembly.c forces -march=armv6 using dg-add-options arm_arch_v6, which implicitly adds -mfloat-abi=softfp. However, for a toolchain configured for arm-linux-gnueabihf and --with-arch=armv7-a, the testcase will fail when including arm_acle.h (which includes stdint.h, which will fail to include the non-existing gnu/stubs-soft.h). Other effective-targets related to arm_acle.h would also pass because they first try without -mfloat-abi=softfp, so it seems the simplest/safest is to add { dg-require-effective-target arm_softfp_ok } to make sure arm_arch_v6_ok's assumption is valid. The patch also fixes what seems to be an oversight in data-intrinsics-armv6.c: it requires arm_arch_v6_ok, but uses arm_arch_v6t2: the patch makes it require arm_arch_v6t2_ok. 2023-05-30 Christophe Lyon gcc/testsuite/ * gcc.target/arm/acle/data-intrinsics-armv6.c: Fix typo. * gcc.target/arm/acle/data-intrinsics-assembly.c Require arm_softfp_ok. --- gcc/testsuite/gcc.target/arm/acle/data-intrinsics-armv6.c | 2 +- gcc/testsuite/gcc.target/arm/acle/data-intrinsics-assembly.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.target/arm/acle/data-intrinsics-armv6.c b/gcc/testsuite/gcc.target/arm/acle/data-intrinsics-armv6.c index aafdff35cee..988ecac3787 100644 --- a/gcc/testsuite/gcc.target/arm/acle/data-intrinsics-armv6.c +++ b/gcc/testsuite/gcc.target/arm/acle/data-intrinsics-armv6.c @@ -1,5 +1,5 @@ /* { dg-do run } */ -/* { dg-require-effective-target arm_arch_v6_ok } */ +/* { dg-require-effective-target arm_arch_v6t2_ok } */ /* { dg-add-options arm_arch_v6t2 } */ #include "arm_acle.h" diff --git a/gcc/testsuite/gcc.target/arm/acle/data-intrinsics-assembly.c b/gcc/testsuite/gcc.target/arm/acle/data-intrinsics-assembly.c index 3e066877a70..478cbde1600 100644 --- a/gcc/testsuite/gcc.target/arm/acle/data-intrinsics-assembly.c +++ b/gcc/testsuite/gcc.target/arm/acle/data-intrinsics-assembly.c @@ -1,5 +1,6 @@ /* Test the ACLE data intrinsics get expanded to the correct instructions on a specific architecture */ /* { dg-do assemble } */ +/* { dg-require-effective-target arm_softfp_ok } */ /* { dg-require-effective-target arm_arch_v6_ok } */ /* { dg-additional-options "--save-temps -O1" } */ /* { dg-add-options arm_arch_v6 } */