From patchwork Wed Oct 26 05:08:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 11063 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp62196wru; Tue, 25 Oct 2022 22:08:43 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7e922gGQZLyw+XnT/EU70UnQEPhBpFQVVf0TM8w2U5Pdw6cgjZPeyoiPanAxRkGktGcF4X X-Received: by 2002:a05:6402:e9b:b0:454:351c:c222 with SMTP id h27-20020a0564020e9b00b00454351cc222mr39302782eda.216.1666760923787; Tue, 25 Oct 2022 22:08:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666760923; cv=none; d=google.com; s=arc-20160816; b=sALoa4EGIESq71SeHWtVH9vDyHExmdFUNUix/aGauCV2FKf1U3HBopVMAXPWNQkx6X nU2nkkUYfIV1pVlcP59eGEqNg6xoQ4UvdJJJn/NCtyHM1p14CNBdtmrKTEQshBPorR/R T1UAbkS5DvRB6HkJWRXHwMTEGJyagoUNs4iWrdXk3CyBjFKVxCXvAE+htbSJxZ2/IyXk 5xep/T5piOSSymO9644JOsUJ26X9GKcTH/Bqy104Z7ov6MXaFVEdm8IACpkhhaznW8jg uL1Pfh6+wZv6Rtpwud/9wNK2lLgfAiIuyszo6eL2sg8a1KHyxqLPH5E77fgu1KfMihhM IxWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=a3DIIyrhPBqfWwN9NoGTb5YEauU1PkW0JkmP7h6Yv5E=; b=RMmE64wdWytmuuC9CgTMQYzHea8MWfkEgB9EVotu5JWO/+5SndnRNtNrv0RFbPk4Kh fM+sODhdpPo/PLyFh5Dh8sYvK++ysDbm3kpMHtPvr3/EZwCt6F/R2sP5xK7T5EOadk7L X253E0OFU8ntgPhZYvmFrhCvoxcza1mgPugDDF35Bbbr81QRKMFkFAgCIm7Q4/qXCZLp lUYQcJZUT5u4jZ26XIWFTfCdanZhtIFVfWSk2iZnU1THWzm/64GZLb/gvDRist5lYLal t9HVNDrHTcxd7UiivEFbsnxJXArOcKIHxReinKYHCxDqVN0/Rle0VooqPJ2ULHVKUjDf wPyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=bWxd1axi; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id dd3-20020a1709069b8300b007707aab3171si5120816ejc.848.2022.10.25.22.08.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 22:08:43 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=bWxd1axi; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CA1D1384BC11 for ; Wed, 26 Oct 2022 05:08:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CA1D1384BC11 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666760918; bh=a3DIIyrhPBqfWwN9NoGTb5YEauU1PkW0JkmP7h6Yv5E=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=bWxd1axi5qasKZT0m+OdagParyZzyj1yF5dALwtOfjNfqOhsPfYtUX0NsphVEU1D9 cm4bxXiiVlNJ5NUY8KE23kjGFsZ7V+IHSC6keIfcrRHC95YF5/T+4ckng5VqelAWtv C+UDakFjjEBpzQkFanZjunjG6B9piKjJWvISclYA= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by sourceware.org (Postfix) with ESMTPS id 829A9384B82E for ; Wed, 26 Oct 2022 05:08:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 829A9384B82E Received: by mail-pj1-x102b.google.com with SMTP id q9-20020a17090a178900b00212fe7c6bbeso1131492pja.4 for ; Tue, 25 Oct 2022 22:08:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a3DIIyrhPBqfWwN9NoGTb5YEauU1PkW0JkmP7h6Yv5E=; b=DWjzCuUIc0AAJNdO660LpjbJ7XM8bivyU0Di90YjiwKP9DLzdLa44kGmpp87q48PW8 Xj+HUNkAsudfRk1Al28RV+HUFglABARyuQuAQbfohbXj8ynxd+MNY17LrqG+wMPQpiCI 8fTBzCsEPIsdsh+F4UEG0zm7FQ11xk5ELqbNaT+mOSPvlRPREhd7ca4llrXeGsmb3LNp UYc+fq8TbXWGJ7Bp5j29gjaxsVX3+06NUKzdQ1AqdLUjZakErfClkc1wM8NckSisuY6k DLaW8sOMiJEJmUWd3fTTN2Rpd9mdEvaBuKYxtzSObEOObhHkfTBlKiBYldrEIA/1zEQ/ 9l5g== X-Gm-Message-State: ACrzQf1M6IEY/wnpTmg5JeAQSJdKyvnj6OlvFF+HpbJ7xcgAJf0qswiO T6bzsQvryqOHUFaOWb0FQ8RjLYJTSe8= X-Received: by 2002:a17:902:db0e:b0:186:9b38:ad26 with SMTP id m14-20020a170902db0e00b001869b38ad26mr17643902plx.43.1666760904224; Tue, 25 Oct 2022 22:08:24 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:a3ea:1d22:1394:10bb]) by smtp.gmail.com with ESMTPSA id a64-20020a624d43000000b005632c49693asm2200835pfb.202.2022.10.25.22.08.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 22:08:23 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id CE8751142D9C; Wed, 26 Oct 2022 15:38:20 +1030 (ACDT) Date: Wed, 26 Oct 2022 15:38:20 +1030 To: binutils@sourceware.org Subject: som.c buffer overflow Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3035.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747725502794719127?= X-GMAIL-MSGID: =?utf-8?q?1747725502794719127?= Fuzzed object files can put random values in bfd_reloc->address, leading to large som_reloc_skip output. * som.c (som_write_fixups): Allow for maximal som_reloc_skip. diff --git a/bfd/som.c b/bfd/som.c index 9b0a5513209..b9114e630fe 100644 --- a/bfd/som.c +++ b/bfd/som.c @@ -3005,10 +3005,12 @@ som_write_fixups (bfd *abfd, then dump the current buffer contents now. Also reinitialize the relocation queue. - No single BFD relocation could ever translate into more - than 100 bytes of SOM relocations (20bytes is probably the - upper limit, but leave lots of space for growth). */ - if (p - tmp_space + 100 > SOM_TMP_BUFSIZE) + A single BFD relocation would probably only ever + translate into at most 20 bytes of SOM relocations. + However with fuzzed object files and resulting silly + values for "skip" below, som_reloc_skip can emit 262 + bytes. Leave lots of space for growth. */ + if (p - tmp_space + 512 > SOM_TMP_BUFSIZE) { amt = p - tmp_space; if (bfd_bwrite ((void *) tmp_space, amt, abfd) != amt)