From patchwork Sun May 28 14:01:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 99899 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp977357vqr; Sun, 28 May 2023 07:13:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ54jBz73loEo86Y0aJadzm5B7aw1fhqV+bxMoXZFokQ5rA6cQtaMN9pfkXcQ7mnW+SomZNj X-Received: by 2002:a17:903:22cb:b0:1ac:a88a:70b6 with SMTP id y11-20020a17090322cb00b001aca88a70b6mr5389256plg.31.1685283202309; Sun, 28 May 2023 07:13:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685283202; cv=none; d=google.com; s=arc-20160816; b=ZXFGjmCKts8SI/D8OgexF4SZbRex744EAjWllmXRVJNWFM1fgyVaDRinNd4+eaEB6D ApvjgIYBJSZAcoojggPVVycriclj0dEStq60F1Nyamr/XKKoNQQiQmbqDiMduXevNJKs p23HArsfV15SoFtRzKX0Ltj1MqtxE1RKwymi271b1OE1eQ2/7sb6YfkM7OUTjlmnRiKt I+gfysbrMKdq6CeRO6Wxt7kOmvIqTerC5CE5I8dCo0Ta38p2JWt9qBzQaplNGPVWersy /BG6jNUpoNnSXB4hcvgbEuyCGlqZrEg5038iP9WK6ObXHEeR47x2hlmZR2ez3x2+sHIQ AjSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=TTsyPieoykfFDGt3dR8ADBeteK4LBvSR9SkhNW6yvaQ=; b=zY03T2YrrrfCAhBgoVVfyUJuCniGA44sgeXcC9hD53d42qZx9bWTvgCKFr1QZ82zMS 6cA/EAiJWbnAi61LCLVC0WVej1HhS+AWoZAg873sw+IlVncRnyvpc66/LNdZ90Z7r+UO EMiTL8YCI1g8rGn7M2Vnp8nRfvbWtCrmC2+CHEdqqHt7WGyQ/o5ANzKJkrLymDwhjbKu zFHEz69jTtVC1O1VOBqpogrdHlxu/L9ejSgo5VK4o3kXZV4beaIc8I1WjPQ6Y3dIX1Bo lop66QfoBZrcdD8y4rNRVpBg5AdAV5E85gmyCtXkeBmfCbZs03xSQS5MT58JgOHnEAuL 0T7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=H5byMC1M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u12-20020a170903124c00b001ae1bb70a41si2820682plh.168.2023.05.28.07.13.09; Sun, 28 May 2023 07:13:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=H5byMC1M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229563AbjE1OCy (ORCPT + 99 others); Sun, 28 May 2023 10:02:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbjE1OCx (ORCPT ); Sun, 28 May 2023 10:02:53 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 996C4BE for ; Sun, 28 May 2023 07:02:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685282570; x=1716818570; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=350Cmgc4YVBwpCeqyLZSZ8GMu5rkS/HADedpO+GTm18=; b=H5byMC1Mj6O/ILDpAhXBkoYqIc2vjLsTzscjiJfqRm2/hg5Zthh6EAdW o/sPZsvBouDiGcmVRKVJ88iY7yA5J0EIxbwP37SpyVwco5dxqVtzRoA6y g4j8pJHBoeR9hLROU43JDTLhrunB+939ey4aaDDvl603GnIuBFrjGy5q6 nPR7vTOgeJzB8OLUqhxzaAwCdvm24myQBz4Hnte0MseODl7wHiP/2CeA0 9+jjj36a1SmxHJnhBcwAVqY0wQbpP0e5TuEhMFn9lcqKumQEWhcpTLwqe G5/h9EDctQqQ+gkMPIcN2fTnxUAbbepZ1uofOxaFMJ9dm0YuW4TztGpCa w==; X-IronPort-AV: E=McAfee;i="6600,9927,10724"; a="344019080" X-IronPort-AV: E=Sophos;i="6.00,198,1681196400"; d="scan'208";a="344019080" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2023 07:02:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10724"; a="1035911171" X-IronPort-AV: E=Sophos;i="6.00,198,1681196400"; d="scan'208";a="1035911171" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 28 May 2023 07:02:48 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 571E624F; Sun, 28 May 2023 17:02:53 +0300 (EEST) From: Andy Shevchenko To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Andy Shevchenko Subject: [PATCH v1 1/1] staging: pi433: Remove stray gpiod_unexport() call Date: Sun, 28 May 2023 17:01:47 +0300 Message-Id: <20230528140147.32427-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767147519193711753?= X-GMAIL-MSGID: =?utf-8?q?1767147519193711753?= There is no gpiod_export() and gpiod_unexport() looks pretty much stray. If user space tools somehow belong to that, they should be fixed, the gpiod_export() and gpiod_unexport() shouldn't be used in a new code, GPIO sysfs is deprecated. That said, and taking into account staging state of the driver, simply drop the stray call. Signed-off-by: Andy Shevchenko --- drivers/staging/pi433/pi433_if.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index f08fdf06d566..220e157d4a5e 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -1019,7 +1019,6 @@ static int setup_gpio(struct pi433_device *device) } /* configure the pin */ - gpiod_unexport(device->gpiod[i]); retval = gpiod_direction_input(device->gpiod[i]); if (retval) return retval;