From patchwork Fri May 26 12:01:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 99468 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp426251vqr; Fri, 26 May 2023 05:18:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ45TujQDz8UDbWEwVXs15vf9M1lqFAt1t6bXIAtSV78IlIw9piSvR5kV4WbpTXhJCTpJ7Ln X-Received: by 2002:a05:6a00:1254:b0:643:b37d:d350 with SMTP id u20-20020a056a00125400b00643b37dd350mr3183224pfi.31.1685103514661; Fri, 26 May 2023 05:18:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685103514; cv=none; d=google.com; s=arc-20160816; b=IZLZp8+iK/o2mLaorSbFh7JHg2fq1Om6rJjNMtjAvn1PK+v9hjyHtI36u1fiVtg+U9 RHFXIIUxhSFI2lrOxLKFYGHRImbXQGQeizByshj95GSZF2hCzEmAK2HUFjU5qOzk2NTK Yal1/8mcbA1XEOBWWwVKqQT0fyaLm7wIgWHKnaNI7CRgparl+f1h+cVvKO4l4U0keRMl HEMFQMjO+B/7RIdOOXHvgPuh4nBAWdFLnrAgWE2wl+1HqsGC6j5Qu5a9/II9/w8qiDe9 RWyhYqTxGyDeSN79K4nDnIDebE03hLW2bPvuMo642TK183p6k7OH90KPZg2EpxBwkcZ2 7ttA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=yND35ais/ukG+uTh3KH7a9De2YZqNP7mXDsC69SJnlM=; b=bcUXpQnWcUctJMuYY/TxjVzhs88OWG0cpRjJo8JR/C0XDC+Q/ueI+R8dFzoq2ovu99 U4W3gpi1h9iGDCkiwEXG3szcWqTDYNTp3ylaB30HHJS988BbInVWK6tSQ7KXxwVhWN8a CC4AjPUlyMrDxafrT2tdd9bqJo6SP5DTthoPYYB3w8BgQXY7y88XQG/A13tMsOqo4Rbk 5auTceM9e31hqMg7K1tLNA4gm3ZBlVXlwFP1xk0BnvadJNrpRZ1udEnEmNnNA19gPL/A t8LtZkeRICVzsyqFsH3XSqDjbXU4rGFDMZtwMLUNdmi6dMHHiweImG88CgExAHHU8tYA E8hw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zndeBKmy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z4-20020aa79e44000000b0064d65c58e82si2420524pfq.57.2023.05.26.05.18.19; Fri, 26 May 2023 05:18:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zndeBKmy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230064AbjEZMBp (ORCPT + 99 others); Fri, 26 May 2023 08:01:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229610AbjEZMBn (ORCPT ); Fri, 26 May 2023 08:01:43 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6329895 for ; Fri, 26 May 2023 05:01:39 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-30a8fa6e6fcso397426f8f.1 for ; Fri, 26 May 2023 05:01:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685102498; x=1687694498; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=yND35ais/ukG+uTh3KH7a9De2YZqNP7mXDsC69SJnlM=; b=zndeBKmy7vQdUTShwT7eFAF2WU52kDQMUlI0H12GCJW6/ahrt9Il9Hh+H+SrXRFzHj XrLC0QNjJcyxx8a72Ot+6CHWW7I1Dgeyl1zIi5z9zeIGyChZBJouAnD4Fi2R6nJEwAGI HrZ8UVsuxNUjSwLLB66hGTKSYOnum68DamLumhQbIxpWuWi67/be+NBFqfslwKkYFlWQ F1P2EGpD4GumkJVXl9TPChj97/Ymunj9GEqDPKaP7x4fuSZLytOrUTMMk89XsxeHG5wN WsEeBwX9dEFV3m9jO64u3e1FaJjm867hwl+D3FNMFVWyNMwvzhN1PXuVxu+r2JrS5CXU /qBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685102498; x=1687694498; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yND35ais/ukG+uTh3KH7a9De2YZqNP7mXDsC69SJnlM=; b=QFVpUX9ZHP4wsflPpzfrs+JL8Dlwe6qn9LJfAImAA6Mum0qjIdmn4XVqugjE0Jgz9v sGzt9N9I3Qr5T6+eE2jqRg1y8RpDwBqpePJfZhgKe1N4lhhJxj4bvDOh4umuXO5eLISV rfPOYfh8FxOJoBlkJQlbNQ9usvzzkGbofv3Jsf4nXlDrpFsqbNa/tWiXz5lrIAJYW1yg U+Vv3XXCYhUOgWJBsuI5Ek3QmmmZbPAncZ/3Pm2Slkt1VKaFEOxHms7hWgWXFYYC2tbd dqkhLPG+eTeHrMrzHM6oW2+nG0+mgqv7LcYCMzJBGZLNL/F3aMy0Pm1os4nRMiWj9ZMs 35vQ== X-Gm-Message-State: AC+VfDw5xgO+X0BH50J1ggS139hsD2qINW8kBrgr6fPON5KwMkdNhvvi EpukHcaUvpwpQgJyQV7WYPuYmw== X-Received: by 2002:a5d:404b:0:b0:306:2c16:8359 with SMTP id w11-20020a5d404b000000b003062c168359mr1339056wrp.39.1685102497818; Fri, 26 May 2023 05:01:37 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id e21-20020a05600c219500b003f604ca479esm8609669wme.3.2023.05.26.05.01.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 May 2023 05:01:36 -0700 (PDT) Date: Fri, 26 May 2023 15:01:33 +0300 From: Dan Carpenter To: Steve French Cc: Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] smb: delete an unnecessary statement Message-ID: <077d93ae-adbf-4425-9cc4-eea5163b050c@kili.mountain> MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766959103273422731?= X-GMAIL-MSGID: =?utf-8?q?1766959103273422731?= We don't need to set the list iterators to NULL before a list_for_each_entry() loop because they are assigned inside the macro. Signed-off-by: Dan Carpenter Reviewed-by: Mukesh Ojha --- fs/smb/client/smb2ops.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c index 5065398665f1..6e3be58cfe49 100644 --- a/fs/smb/client/smb2ops.c +++ b/fs/smb/client/smb2ops.c @@ -618,7 +618,6 @@ parse_server_interfaces(struct network_interface_info_ioctl_rsp *buf, * Add a new one instead */ spin_lock(&ses->iface_lock); - iface = niface = NULL; list_for_each_entry_safe(iface, niface, &ses->iface_list, iface_head) { ret = iface_cmp(iface, &tmp_iface);