From patchwork Tue Oct 25 17:36:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 10908 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1132248wru; Tue, 25 Oct 2022 10:38:21 -0700 (PDT) X-Google-Smtp-Source: AMsMyM60pRN1/yGdOfsFTsw29BKS1DrOJPggEtIg07no2jM9v20MTykgx6SM/Cshw7Oo4COubEQE X-Received: by 2002:a17:902:d682:b0:186:9ecf:94c2 with SMTP id v2-20020a170902d68200b001869ecf94c2mr13606247ply.54.1666719501553; Tue, 25 Oct 2022 10:38:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666719501; cv=none; d=google.com; s=arc-20160816; b=Vhyf8N7F3upNqL1Zq0Sir/dwi8GeksBB/CKei5KRD1JV/8XAGg3cZAkSocoH366Ooz VHzr1gpuRMwLqXGIZYAzgHwGdryWDrz5egmIJfNbsgb17FzOa4vTl1WUfTMKGbnVYdfb 1G6nt77Ujp+PIGBeXKPwgwrdSzul9p3pIQjuAj6NVmOjSOHTquZTNOK/2mpaJguQsuAa znRu/UA9PAu8Yxc/SoFcpjnIKy4xdSIanNI5iigAMH3+ejIlrN8AETGwZALV7Yc6tOw2 DMzir8y3dgKlCiKtBH3r+Z1Ec/KigceC9mSb8O0ltOv0ereZ4xEjZ4MyKNcKJ7tEfqfy JGjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0ChRdX5rstA7UElwcv4YrRM23R4l3kY/dKBFCEVe6Lw=; b=amYerVJAtUmwGpCp71hVCmmZtJYXY8rQhubSIFS3uwoak9cskX4aDh+ORBFFVazYV5 ewNRGNPfnsrXMmuOPxwbfDoE4VFlW8I2uQtnMpWtVkV2uTUGNsLxueKKEdXwGz5jcQAq AIMD9nv1yEfUx5zWzKVqpYzDnm54xLHIkYrgqZA5wOJwFBymxqw7r7RnyE1NdDzmRlrg vZ2uqiqd/9mjcLgNDACNARM7IWCQDF+dUiNW/Z5JjUNyyZsvHPAJwIiWEHqqxuc4cUU+ AGKGakmW5blgdRJAtoWn8agk6EP3oXP/1h6KthsRWOqpM3/kwgI5+wnrY1FINJqPLxVT ZVVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bKpdkSIr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h6-20020a170902f70600b001783d4945b9si3465680plo.602.2022.10.25.10.38.08; Tue, 25 Oct 2022 10:38:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bKpdkSIr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231714AbiJYRhG (ORCPT + 99 others); Tue, 25 Oct 2022 13:37:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231375AbiJYRg7 (ORCPT ); Tue, 25 Oct 2022 13:36:59 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB16510C1 for ; Tue, 25 Oct 2022 10:36:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 63ACE61A2F for ; Tue, 25 Oct 2022 17:36:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59972C433D7; Tue, 25 Oct 2022 17:36:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666719415; bh=TdXFXcgq2EM24y0mmvXtXkdjHMEmMaCZawqMFxCOKU8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bKpdkSIrpvAqCeR5vix1iWp5kJrdJW19Utrml/Ra41U7LQX2zLCZqhdbJQieGIepi HFNsWZm4WYDd3CYCDDOoe0suLK4DFct0N9bLT4XHzDy8tJnastMR7kQxduDavDmJ0Z iX7W9T4FUObqrP/8Ah67Uo0elgleXvQzhWQjv1y7rKwhSgK3cTmAsUck/bWI4M1L2G mrOSA8PWFFXUkJaPZ+y2a1WyTpJ1cAW5hXFoQ0/AMtHdNYuNax116Muy19KAgRftt5 0dCmyY8FBeMHh95i2iQdvHFC5TAo94VHGcO7aFZOJk9F29zCuEti4Xke78jyL30PxH oNQeEqFD0KNZw== From: SeongJae Park To: Andrew Morton Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, SeongJae Park Subject: [PATCH 1/4] mm/damon/reclaim: enable and disable synchronously Date: Tue, 25 Oct 2022 17:36:47 +0000 Message-Id: <20221025173650.90624-2-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221025173650.90624-1-sj@kernel.org> References: <20221025173650.90624-1-sj@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747682068267292834?= X-GMAIL-MSGID: =?utf-8?q?1747682068267292834?= Writing a value to DAMON_RECLAIM's 'enabled' parameter turns on or off DAMON in an ansychronous way. This means the parameter cannot be used to read the current status of DAMON_RECLAIM. 'kdamond_pid' parameter should be used instead for the purpose. The documentation is easy to be read as it works in a synchronous way, so it is a little bit confusing. It also makes the user space tooling dirty. There's no real reason to have the asynchronous behavior, though. Simply make the parameter works synchronously, rather than updating the document. Signed-off-by: SeongJae Park --- mm/damon/reclaim.c | 53 ++++++++++++++++++++-------------------------- 1 file changed, 23 insertions(+), 30 deletions(-) diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c index e14eb30c01f4..e57604bec06d 100644 --- a/mm/damon/reclaim.c +++ b/mm/damon/reclaim.c @@ -9,7 +9,6 @@ #include #include -#include #include "modules-common.h" @@ -181,38 +180,31 @@ static int damon_reclaim_turn(bool on) return 0; } -static struct delayed_work damon_reclaim_timer; -static void damon_reclaim_timer_fn(struct work_struct *work) -{ - static bool last_enabled; - bool now_enabled; - - now_enabled = enabled; - if (last_enabled != now_enabled) { - if (!damon_reclaim_turn(now_enabled)) - last_enabled = now_enabled; - else - enabled = last_enabled; - } -} -static DECLARE_DELAYED_WORK(damon_reclaim_timer, damon_reclaim_timer_fn); - -static bool damon_reclaim_initialized; - static int damon_reclaim_enabled_store(const char *val, const struct kernel_param *kp) { - int rc = param_set_bool(val, kp); + bool is_enabled = enabled; + bool enable; + int err; - if (rc < 0) - return rc; + err = strtobool(val, &enable); + if (err) + return err; - /* system_wq might not initialized yet */ - if (!damon_reclaim_initialized) - return rc; + if (is_enabled == enable) + return 0; - schedule_delayed_work(&damon_reclaim_timer, 0); - return 0; + /* Called before init function. The function will handle this. */ + if (!ctx) + goto set_param_out; + + err = damon_reclaim_turn(enable); + if (err) + return err; + +set_param_out: + enabled = enable; + return err; } static const struct kernel_param_ops enabled_param_ops = { @@ -262,10 +254,11 @@ static int __init damon_reclaim_init(void) ctx->callback.after_wmarks_check = damon_reclaim_after_wmarks_check; ctx->callback.after_aggregation = damon_reclaim_after_aggregation; - schedule_delayed_work(&damon_reclaim_timer, 0); + /* 'enabled' has set before this function, probably via command line */ + if (enabled) + err = damon_reclaim_turn(true); - damon_reclaim_initialized = true; - return 0; + return err; } module_init(damon_reclaim_init); From patchwork Tue Oct 25 17:36:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 10909 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1132442wru; Tue, 25 Oct 2022 10:38:49 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5Rlx1395fKdVl+zFErCa3Etjpc/cgFaqaQkODbhqrnPakj4gZK2Izn6O75bYIHjeZZveRz X-Received: by 2002:a17:90b:4c0d:b0:20d:43db:cc14 with SMTP id na13-20020a17090b4c0d00b0020d43dbcc14mr46434591pjb.119.1666719529484; Tue, 25 Oct 2022 10:38:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666719529; cv=none; d=google.com; s=arc-20160816; b=hUmeQ3tK7dQK1Kz3YAAxtWOlCx6+lkAb7JLZig7nqTQg3WNUUF8SJYjRsdwgh4pgk/ 2j5vlinS8f6pT2OYhZK0EWj+PvcX3Vn3uERy1B0izEv/AH+89jjHMhVI6wjRwGY2PL6J 77O0ATuaFCJYW+lE286AK92qDaxMeluS7fxhjszxNB8EMiUpYtfbUMoYS0LgualqriYd vrnFDZsaR3XtlQe5Tn9+RHtV8tqWqpeO9S5+hGC9IMVH7rMobUtjcm5Svs8T2d7ed/tz au7e+2UGPlAl//YHtkZJdxec5XfAFezS4dVEmuHNgSWMmRWabQKjw1dQOUb/XacqCUAy mvZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=moRksDtfjES9Xxm+Vwb591fHii3lcZv05YN65M1agTQ=; b=tvXiMieYjConrIaYQeoVT0W1Qhyih0ZJ/dFOTII0nWO5zyt2gz48xuGJGH/YAjkBva XvxuXUn2QBkwbyBfrNWcaXIrCaDNMOGIT1otnzhHjGo5ZRDTdxaXcFWe+vS9tAwqERXi FoSmunvTWy1Up3l//j1iQBMlSyVrakUI2mn2JeFZxcLMZFbfzhpG0H7E4+HeOmurS3j/ WMxbiitE6gjOw3E1XxrY1QBSaD/IKJZBBYVJb6riDQrkvWI6wGPG5hSh4Rwj6RhhfTsi iUT+98u+kxrUFqHMZ17t/l7qTLX+NHMnQPA1nP6gUCtHKzfee0YEUt7BC5slzWPS/iSP EemA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=D13bipI5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pg16-20020a17090b1e1000b0020dbd4207fasi16637038pjb.46.2022.10.25.10.38.26; Tue, 25 Oct 2022 10:38:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=D13bipI5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231903AbiJYRhM (ORCPT + 99 others); Tue, 25 Oct 2022 13:37:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231429AbiJYRg7 (ORCPT ); Tue, 25 Oct 2022 13:36:59 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34EC3D64; Tue, 25 Oct 2022 10:36:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D9D7BB81E5A; Tue, 25 Oct 2022 17:36:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 046A2C43141; Tue, 25 Oct 2022 17:36:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666719416; bh=4NBEQVWjkZzG2RZ0IZhDEcaAZKCJsWQ5ei6FDrh1eE4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D13bipI5+ZFOlmA3P+OZjs7yvhTB1CxtPiSEjR/7eMpoGmFaJlnmC1ahl0M6VzJ2b jzRwMLGRPLeeuI1mE/u6kGnFuKsmODPXEkwnOJ2p3h7moHkT+/Is837OF5KYofdczS N7NQXo1Sipv9kc4PzBgnOGGPh1ce/xZFIxI83TXJj3DSyT8+z0pkWXOHGdDXNpA7J6 jyYdXgaYBRg6mtgKKzq22VwxIA76VBnvpnAJEO/j2ps/61WVED1Su5fagGUzlO/mZd PvCuTm5s7xP/RTRQPcjCc3+h/+7qY1/4fvqSrOpkUUHcyfFSN3HTT8MO/qpgHGY6tP SQ+BW/725/C5Q== From: SeongJae Park To: Andrew Morton Cc: Shuah Khan , linux-kernel@vger.kernel.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, SeongJae Park Subject: [PATCH 2/4] selftests/damon: add tests for DAMON_RECLAIM's enabled parameter Date: Tue, 25 Oct 2022 17:36:48 +0000 Message-Id: <20221025173650.90624-3-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221025173650.90624-1-sj@kernel.org> References: <20221025173650.90624-1-sj@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747682097755036762?= X-GMAIL-MSGID: =?utf-8?q?1747682097755036762?= Adds simple test cases for DAMON_RECLAIM's 'enabled' parameter. Those tests are focusing on the synchronous behavior of DAMON_RECLAIM enabling and disabling. Signed-off-by: SeongJae Park --- tools/testing/selftests/damon/Makefile | 1 + tools/testing/selftests/damon/reclaim.sh | 42 ++++++++++++++++++++++++ 2 files changed, 43 insertions(+) create mode 100755 tools/testing/selftests/damon/reclaim.sh diff --git a/tools/testing/selftests/damon/Makefile b/tools/testing/selftests/damon/Makefile index a1fa2eff8192..dbbf18cb3e6b 100644 --- a/tools/testing/selftests/damon/Makefile +++ b/tools/testing/selftests/damon/Makefile @@ -8,5 +8,6 @@ TEST_PROGS = debugfs_attrs.sh debugfs_schemes.sh debugfs_target_ids.sh TEST_PROGS += debugfs_empty_targets.sh debugfs_huge_count_read_write.sh TEST_PROGS += debugfs_duplicate_context_creation.sh TEST_PROGS += sysfs.sh +TEST_PROGS += reclaim.sh include ../lib.mk diff --git a/tools/testing/selftests/damon/reclaim.sh b/tools/testing/selftests/damon/reclaim.sh new file mode 100755 index 000000000000..78dbc2334cbe --- /dev/null +++ b/tools/testing/selftests/damon/reclaim.sh @@ -0,0 +1,42 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0 + +# Kselftest framework requirement - SKIP code is 4. +ksft_skip=4 + +if [ $EUID -ne 0 ] +then + echo "Run as root" + exit $ksft_skip +fi + +damon_reclaim_enabled="/sys/module/damon_reclaim/parameters/enabled" +if [ ! -f "$damon_reclaim_enabled" ] +then + echo "No 'enabled' file. Maybe DAMON_RECLAIM not built" + exit $ksft_skip +fi + +nr_kdamonds=$(pgrep kdamond | wc -l) +if [ "$nr_kdamonds" -ne 0 ] +then + echo "Another kdamond is running" + exit $ksft_skip +fi + +echo Y > "$damon_reclaim_enabled" + +nr_kdamonds=$(pgrep kdamond | wc -l) +if [ "$nr_kdamonds" -ne 1 ] +then + echo "kdamond is not turned on" + exit 1 +fi + +echo N > "$damon_reclaim_enabled" +nr_kdamonds=$(pgrep kdamond | wc -l) +if [ "$nr_kdamonds" -ne 0 ] +then + echo "kdamond is not turned off" + exit 1 +fi From patchwork Tue Oct 25 17:36:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 10907 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1132202wru; Tue, 25 Oct 2022 10:38:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4V4aArkk4SauQ+Pr9eURX2o1lowAPbaDHLAAIU5ERqrJUSpbHpc4tdzQ630Lt/Kbmy/WMc X-Received: by 2002:a17:907:160e:b0:791:8ae7:4fb8 with SMTP id hb14-20020a170907160e00b007918ae74fb8mr34960061ejc.271.1666719495868; Tue, 25 Oct 2022 10:38:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666719495; cv=none; d=google.com; s=arc-20160816; b=pH6DasL04fh+39mInJLATgn8hNUryhuLOyHJEqIvzSFXxqqYq0BHJNTE2dyGzbIuRN KghwY88lmlKAhLwL8G/rzvj/YFKMXyC7NksTwvzE2gV2DbMrUrGXMPUJBdXb+urviy0Q hHLGUgSb0MBvGsAgDRsNVMhlq+8My0dt7SFjUEpUB/9IE/AAoVvAqsDEtBwwDsPRs5tg g9pgA32OsPtwZ2GMym6DV5//ouvcWF3gVoJKO7FksGIvO7q/oAoo5unFch27THJn7jPX bWAkJESzY2qzldyG1OEw1B3LWswO52vLU9lzUtUp2TErco6WlNLa9CURlpblq/69S0i/ 4Q1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oW+7IOTOdA637IP5PZ3N5aUu6DIPxOg3LiG1qxAeuyc=; b=dmlhoZTSgiQojsvJXQOGVyxJCraV7jSbTAfH4EHDvTA38CrieDk32dJY8gLiThupY1 dAkXe300GmzS1rogK1LwManZJ+8u71wFj5jfgmdtMQgMMEZz+M+hG9Fs5t1FVcpPMm7E f4EOBEm0ZMpm0WRzflgSTxy8S54lh9NBikDnrMhzVXLBegLMFfUYYUhtSmUBQeSTfkcf GOnTSVWw4UFYjwc+MVNYPASfpH1A3uHVGlrB0IETcPqenaolNTn6wxIxeOaWoiRqr6+7 DwhyTM+eMA8U+xuPPwJlHaqsdMWHuPdkbE1wvue4QQmEtdKFQ57S3LugA3ZfJoHBcml3 g3tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VrvuZF1r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v4-20020a056402348400b0045c0c18dde7si3921708edc.524.2022.10.25.10.37.51; Tue, 25 Oct 2022 10:38:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VrvuZF1r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231872AbiJYRhJ (ORCPT + 99 others); Tue, 25 Oct 2022 13:37:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231259AbiJYRg7 (ORCPT ); Tue, 25 Oct 2022 13:36:59 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B437E0DD for ; Tue, 25 Oct 2022 10:36:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CA21A61A90 for ; Tue, 25 Oct 2022 17:36:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3774C433C1; Tue, 25 Oct 2022 17:36:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666719417; bh=+caf26+jd72lruUI8kvmUSn/EY6APaB7dnve/Z0xjuA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VrvuZF1rz0yy76gaafEWaleR/CkM5YsNrvrCOFv6/E/w/seFIqYB3UP9+6l4nkUTG ZvaeD6LBqntTUHJSQYSR8rE458QNlCE4yoc5sowKYsyMG68vZ5Hfx+1Tk5RzBwZDjn En713epPu9yRhZ/GWV1RvdxH7xh1lnwvRF+yUwj18v7h3FaEoskB39vXx82qym80d0 0FlNhjJ58O79R1P46X9E5ZPNQmfjaMLSyaeVFQogOnq+so/lHveaSACm4ezDf/7u29 hIZBH9Ax7ptOX8LFis2l27TqE0j+wh3OOxDcxTBbVrZGJx14i+gIJ3el2R+euIju8M seP77KD02p9tQ== From: SeongJae Park To: Andrew Morton Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, SeongJae Park Subject: [PATCH 3/4] mm/damon/lru_sort: enable and disable synchronously Date: Tue, 25 Oct 2022 17:36:49 +0000 Message-Id: <20221025173650.90624-4-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221025173650.90624-1-sj@kernel.org> References: <20221025173650.90624-1-sj@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747682062082727553?= X-GMAIL-MSGID: =?utf-8?q?1747682062082727553?= Writing a value to DAMON_RECLAIM's 'enabled' parameter turns on or off DAMON in an ansychronous way. This means the parameter cannot be used to read the current status of DAMON_RECLAIM. 'kdamond_pid' parameter should be used instead for the purpose. The documentation is easy to be read as it works in a synchronous way, so it is a little bit confusing. It also makes the user space tooling dirty. There's no real reason to have the asynchronous behavior, though. Simply make the parameter works synchronously, rather than updating the document. Signed-off-by: SeongJae Park --- mm/damon/lru_sort.c | 51 +++++++++++++++++++-------------------------- 1 file changed, 22 insertions(+), 29 deletions(-) diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c index 5c60163e556c..2a532e3983df 100644 --- a/mm/damon/lru_sort.c +++ b/mm/damon/lru_sort.c @@ -9,7 +9,6 @@ #include #include -#include #include "modules-common.h" @@ -235,38 +234,31 @@ static int damon_lru_sort_turn(bool on) return 0; } -static struct delayed_work damon_lru_sort_timer; -static void damon_lru_sort_timer_fn(struct work_struct *work) -{ - static bool last_enabled; - bool now_enabled; - - now_enabled = enabled; - if (last_enabled != now_enabled) { - if (!damon_lru_sort_turn(now_enabled)) - last_enabled = now_enabled; - else - enabled = last_enabled; - } -} -static DECLARE_DELAYED_WORK(damon_lru_sort_timer, damon_lru_sort_timer_fn); - -static bool damon_lru_sort_initialized; - static int damon_lru_sort_enabled_store(const char *val, const struct kernel_param *kp) { - int rc = param_set_bool(val, kp); + bool is_enabled = enabled; + bool enable; + int err; + + err = strtobool(val, &enable); + if (err) + return err; - if (rc < 0) - return rc; + if (is_enabled == enable) + return 0; - if (!damon_lru_sort_initialized) - return rc; + /* Called before init function. The function will handle this. */ + if (!ctx) + goto set_param_out; - schedule_delayed_work(&damon_lru_sort_timer, 0); + err = damon_lru_sort_turn(enable); + if (err) + return err; - return 0; +set_param_out: + enabled = enable; + return err; } static const struct kernel_param_ops enabled_param_ops = { @@ -320,10 +312,11 @@ static int __init damon_lru_sort_init(void) ctx->callback.after_wmarks_check = damon_lru_sort_after_wmarks_check; ctx->callback.after_aggregation = damon_lru_sort_after_aggregation; - schedule_delayed_work(&damon_lru_sort_timer, 0); + /* 'enabled' has set before this function, probably via command line */ + if (enabled) + err = damon_lru_sort_turn(true); - damon_lru_sort_initialized = true; - return 0; + return err; } module_init(damon_lru_sort_init); From patchwork Tue Oct 25 17:36:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 10910 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1132454wru; Tue, 25 Oct 2022 10:38:51 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4OFx3q0S3sPPQqqdI4KzghZZ0rPrOf7oysvV/JclIL6klCXujvBIoTKBuYrA5R/IRQ1CVu X-Received: by 2002:a65:6bc4:0:b0:439:8ff8:e2e1 with SMTP id e4-20020a656bc4000000b004398ff8e2e1mr33919155pgw.91.1666719530705; Tue, 25 Oct 2022 10:38:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666719530; cv=none; d=google.com; s=arc-20160816; b=tVUR3twBPySwGOSFMATiN14+h36+/nscMjTBzhwhvYzTjGmN8NdNcz+Eujv4pjUalt +EjOWwj8Hpzfe3uTXfgF9Pb7kfty3XHIhE5+hMGCiGVWQi81GAzLeXs7WUCaqqNMzI1z zfxlxQ+5P1CWZCYDLLlDS4a+cbsWGDEJQdqxzKrmacZIgYMUAFLQf/rV1+nKqsK5UrI0 ezpQNBKy2qQ+hjGLzCbANXXACS92a9Q0NroYkfkkMueRmEBNeKsoFsqa6YEOtCMZV/8R LmsXvTayqhGk+1eh8AHCFJVkELxYHx9MtZ1ac+TJ4QLcAHsFXIIv40gqUW7zSU6jR9fr 7JCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2wKGoxKdaq1OYo2G77Vhp+AG9/JOTHIXaym/ZbHlTDc=; b=mjErR3U7dJpzSzD2P0XDmAANrDbwoGLwtmxjCuhNsQVLAVtat+upeyE3q8P2JtkpPi R225LrKqtc8xnRiYzePPfplzPbjDaom3LL4b+tCw/ixlupDz9/yA6K5ZScFaGZBOvnWp 4y9a5UZHKgqOxjyFZ8JrrQTcK9XG4keux5HlLJWgl+bIcmz8HQn2dzOg90BPBs3OXCSn 12SXVDBBU9UTxbMIKqylVG4kiuwI7w0q97K/dbo162h9iTazePDjC7tAQE7LVG3HUyzg cUcXVcbadI+ioKACPmk4deE4MwcdoknGafWyzQIKg8VlFNu3FdJJ6eC+Iok+c8/P7b3r AKjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OkdC3Pae; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x3-20020a1709027c0300b00186a45f4e8asi3483836pll.274.2022.10.25.10.38.27; Tue, 25 Oct 2022 10:38:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OkdC3Pae; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232041AbiJYRhS (ORCPT + 99 others); Tue, 25 Oct 2022 13:37:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231455AbiJYRg7 (ORCPT ); Tue, 25 Oct 2022 13:36:59 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D7C8101D2; Tue, 25 Oct 2022 10:36:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2647161A94; Tue, 25 Oct 2022 17:36:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D997C433D6; Tue, 25 Oct 2022 17:36:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666719418; bh=zeB8cawVzfOV+gbJUOEQJ5p17R71STbXoreipmlZFTk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OkdC3Pae44Lo+tzDZU5ZqUGPIRcR8H7h0UL4JIPf3l/+1SJBAIwYIN5kpodxDhGCb K4isG0kLPGg82hLpEYWbjZTmiYeMI0X7N9G1AEs8ADtPwpvnYhxUW2YJaPP/R1w7fK wWaYIjpO1rxbPbYrSjPMKYsE3RdYeQCvRai7TzKwAQyHzn99okFHcdGOHs2eDE1ubT lFpWPXQsz+UUPb8FGDteoPbcjbnidXr8B+aDAgoL9NnPJAWHzJiqNl96M2WWDxQNyi /3K09Ik3vPGIfj+mqhw3T5J5bm0PU5jzMpx7Juh+ygmAJTK+xAHl0/a5NR3Ums0Ag6 6tsQRbsBPUA4Q== From: SeongJae Park To: Andrew Morton Cc: Shuah Khan , linux-kernel@vger.kernel.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, SeongJae Park Subject: [PATCH 4/4] selftests/damon: add tests for DAMON_LRU_SORT's enabled parameter Date: Tue, 25 Oct 2022 17:36:50 +0000 Message-Id: <20221025173650.90624-5-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221025173650.90624-1-sj@kernel.org> References: <20221025173650.90624-1-sj@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747682098927566029?= X-GMAIL-MSGID: =?utf-8?q?1747682098927566029?= Adds simple test cases for DAMON_LRU_SORT's 'enabled' parameter. Those tests are focusing on the synchronous behavior of DAMON_RECLAIM enabling and disabling. Signed-off-by: SeongJae Park --- tools/testing/selftests/damon/Makefile | 2 +- tools/testing/selftests/damon/lru_sort.sh | 41 +++++++++++++++++++++++ 2 files changed, 42 insertions(+), 1 deletion(-) create mode 100755 tools/testing/selftests/damon/lru_sort.sh diff --git a/tools/testing/selftests/damon/Makefile b/tools/testing/selftests/damon/Makefile index dbbf18cb3e6b..af490acc5348 100644 --- a/tools/testing/selftests/damon/Makefile +++ b/tools/testing/selftests/damon/Makefile @@ -8,6 +8,6 @@ TEST_PROGS = debugfs_attrs.sh debugfs_schemes.sh debugfs_target_ids.sh TEST_PROGS += debugfs_empty_targets.sh debugfs_huge_count_read_write.sh TEST_PROGS += debugfs_duplicate_context_creation.sh TEST_PROGS += sysfs.sh -TEST_PROGS += reclaim.sh +TEST_PROGS += reclaim.sh lru_sort.sh include ../lib.mk diff --git a/tools/testing/selftests/damon/lru_sort.sh b/tools/testing/selftests/damon/lru_sort.sh new file mode 100755 index 000000000000..61b80197c896 --- /dev/null +++ b/tools/testing/selftests/damon/lru_sort.sh @@ -0,0 +1,41 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0 + +# Kselftest framework requirement - SKIP code is 4. +ksft_skip=4 + +if [ $EUID -ne 0 ] +then + echo "Run as root" + exit $ksft_skip +fi + +damon_lru_sort_enabled="/sys/module/damon_lru_sort/parameters/enabled" +if [ ! -f "$damon_lru_sort_enabled" ] +then + echo "No 'enabled' file. Maybe DAMON_LRU_SORT not built" + exit $ksft_skip +fi + +nr_kdamonds=$(pgrep kdamond | wc -l) +if [ "$nr_kdamonds" -ne 0 ] +then + echo "Another kdamond is running" + exit $ksft_skip +fi + +echo Y > "$damon_lru_sort_enabled" +nr_kdamonds=$(pgrep kdamond | wc -l) +if [ "$nr_kdamonds" -ne 1 ] +then + echo "kdamond is not turned on" + exit 1 +fi + +echo N > "$damon_lru_sort_enabled" +nr_kdamonds=$(pgrep kdamond | wc -l) +if [ "$nr_kdamonds" -ne 0 ] +then + echo "kdamond is not turned off" + exit 1 +fi