From patchwork Thu May 25 08:05:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Marc_Poulhi=C3=A8s?= X-Patchwork-Id: 98836 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp192410vqr; Thu, 25 May 2023 01:07:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Tur2vHtLrkVcOZVkyNOqox011EGsm3CG/IjM7SkibvlH871lnwwqf2kBNMSJnOMv0s64+ X-Received: by 2002:a17:907:6e26:b0:973:93e3:bc9a with SMTP id sd38-20020a1709076e2600b0097393e3bc9amr784610ejc.6.1685002020355; Thu, 25 May 2023 01:07:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685002020; cv=none; d=google.com; s=arc-20160816; b=c7J908Y2SadGcHFYVc8RyqCcghwwiHSk5kURQKx98rjLQ9AwKsKysm/OJTEpTc8ZVt 9ylVjPvUes+4dilUYDhfPWK75KIoIX2fl6awn93N/OFpMVEEURJbx8CJA99yhxtaPGo2 LcchD8izUBYymeLtxjBfltah4dSRGWQP/R/jYK+2bETj43raSBNCElSKvIoFj6rlRoM/ zCK3dZ85B2qPsNmuxdfZjAFh1mIfZR3fnuKzBDmu9l/16Fu0g+nKwH72OwlXKuPoH3du 3HqL8T8/Orm+NX66/LYr92axRq35so1eSo8R5IpN+Hz43x8YXGyvitVdWyqB73xGCpSF +wyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=ierbfo9S1U8SZsxA9NATxEUE9hmq1JhTu1lnK9wkY6E=; b=gMHJSqT6J1XOyqhal/PGAUjzdhDdJA1AU+6VLWp9UsYkihsij0Ft9U1EMfjIGF1BG9 x6T+JjD53Z/0AbcDvMN0AQDokcIftS1lkd8WWPRCjd3FDzuSy3v/vEw5uk4b5zp2Vh4g Mz2nZVXtgDEYJFDw7jSKxc1yIUnAaJnktRzp4A/+VGL81bOFxCmx394B2uSmLHzxBoW8 Zck60rvQBnXwM0VV9Hzuld4sMvQGKmIs4xb150I2yIly7SuXHwnSYs9CVUvmQlkt+/aW 6lX2sgnvsyX2Y2I8wSH6TlMpIWlfAsuNk8oZH/PhsOAJ1xoWcc5w7Qq0k5ocgpUFnjD6 AH0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=Nq4FP0B+; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id bp13-20020a170907918d00b00970e011476fsi620217ejb.242.2023.05.25.01.07.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 May 2023 01:07:00 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=Nq4FP0B+; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C2D9138323D3 for ; Thu, 25 May 2023 08:06:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C2D9138323D3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1685001977; bh=ierbfo9S1U8SZsxA9NATxEUE9hmq1JhTu1lnK9wkY6E=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=Nq4FP0B+VL/U2b/z5CULXMC4apGJXCqy9xg3NTFgR7eKSZXIN+u+EgSb0ikpnmY4j 5icuB6Vm3um7RosH/kXpMKo+cVrNqWBEzFDh9UmmEsEn0ocpVfomTz9eT0uLMo4xgn WiFuGkAqy9laBFhoO+ICCaK0RH3h/LTztgWCybgo= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id 3E8213857710 for ; Thu, 25 May 2023 08:05:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3E8213857710 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-3f606a80d34so2048165e9.0 for ; Thu, 25 May 2023 01:05:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685001926; x=1687593926; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ierbfo9S1U8SZsxA9NATxEUE9hmq1JhTu1lnK9wkY6E=; b=BAkpV8QS0/BDSPgupiSoBXNybfjnVDBZEYXIKGEZYq4Hj1aX4LCvZeiXRkneWVJJJk c71O2bc+0G3NvFR7op+XtcIZdm7gWBsVCqzYid80ok0uEocb/tIe1JQOnU7VuaJrJIbc tVVfAieHRXViDhHv2YZ64xLILGygJlwW23YnPQUHhOoxcJ66+lxXSiy8CiosE0t5MP/4 FO1y2lA4viSx/mFVUvHBUfQnDz5BiHNi1zOkrbxyKkIkfYBUPGKQ+wb691DEek3UztKP hOSWff/Ut+Metb67FNTIzbGmD1zRLLQmg2kkrB2/7BDTAc/pjG5rWuMnxSqMCqTIsEli Ok+w== X-Gm-Message-State: AC+VfDztA7Xeyffs2l6kvxOf4NArcMk5s0BSSeh12/3NhbRaMDVsfQ50 5+8hVYAiWDuzhx6TVzyrMfFcygsyh5mmrb/q6ncfbQ== X-Received: by 2002:a05:600c:213:b0:3f4:2365:e5ac with SMTP id 19-20020a05600c021300b003f42365e5acmr1376030wmi.13.1685001926048; Thu, 25 May 2023 01:05:26 -0700 (PDT) Received: from poulhies-Precision-5550.telnowedge.local (lmontsouris-659-1-24-67.w81-250.abo.wanadoo.fr. [81.250.175.67]) by smtp.gmail.com with ESMTPSA id 13-20020a05600c24cd00b003f4dde07956sm4784361wmu.42.2023.05.25.01.05.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 May 2023 01:05:25 -0700 (PDT) To: gcc-patches@gcc.gnu.org Cc: Piotr Trojanek Subject: [COMMITTED] ada: Accept aliased parameters in Exceptional_Cases Date: Thu, 25 May 2023 10:05:24 +0200 Message-Id: <20230525080524.1955610-1-poulhies@adacore.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: =?utf-8?q?Marc_Poulhi=C3=A8s_via_Gcc-patches?= From: =?utf-8?q?Marc_Poulhi=C3=A8s?= Reply-To: =?utf-8?q?Marc_Poulhi=C3=A8s?= Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766852678066672569?= X-GMAIL-MSGID: =?utf-8?q?1766852678066672569?= From: Piotr Trojanek Aliased parameters, just like parameters by-reference types, can safely appear in consequences of Exceptional_Cases aspect. gcc/ada/ * sem_res.adb (Resolve_Entity_Name): Allow aliased parameters; tune error message. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/sem_res.adb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/ada/sem_res.adb b/gcc/ada/sem_res.adb index 4e49a0a1473..17228689364 100644 --- a/gcc/ada/sem_res.adb +++ b/gcc/ada/sem_res.adb @@ -8087,6 +8087,7 @@ package body Sem_Res is and then Within_Exceptional_Cases_Consequence (N) and then not Is_Attribute_Old (Parent (N)) and then not Is_By_Reference_Type (Etype (E)) + and then not Is_Aliased (E) then if Ekind (E) = E_Out_Parameter then Error_Msg_N @@ -8098,7 +8099,7 @@ package body Sem_Res is "in consequence of Exceptional_Cases", N); end if; Error_Msg_N - ("\only parameters of by-reference types are allowed", N); + ("\only parameters passed by reference are allowed", N); end if; -- Check for possible elaboration issues with respect to reads of