From patchwork Thu May 25 05:35:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 98784 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp129794vqr; Wed, 24 May 2023 22:36:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4JZNR1xQs+GJi/LfMwqJJhrNfphE+9ux2kP0MmCx5MLWEMftAGm8q2kwfSKZKBu2tyX3Ii X-Received: by 2002:a17:907:da1:b0:96f:a891:36cb with SMTP id go33-20020a1709070da100b0096fa89136cbmr417818ejc.0.1684993003792; Wed, 24 May 2023 22:36:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684993003; cv=none; d=google.com; s=arc-20160816; b=XH2Fc5rLTnsdF9UsjvhEbyXEOBBpUixT5MdFI9IhQfsGY7qA+PVNgknzNzdopZdOUM mvlCXfVFcEy1j1FqG3ccuYBClDHfpG19R1WEAIXGNrA+tEBiRlmfsxS3ZT7edo/AgoBE uIMRxPSnFYKt4WttMIOsMNLHTImEO2964h3rAJ18TvHZ5wApTXI4eaprjOT+xW//HlwS mRsUDJJQSN7BCN/PXFur4VN7GBqlvzXalo4lECbkeQTsDZWtn3Iw+yXxk0Mmw7ZOoomC oc5MXCO8S8he6qjuRfEuukG9ZyQE6jfX6LqVx5wHQB9DMPabQ6iKzUc31o76U49P2H4M 6MWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=wFffVv322eOKeXj42oV33TouzBLYe9Z7Uf7AwIRQYKo=; b=KjzqP8q/tIa3AoehgxikPG96o1BG0X2JO2cl/eKK2LNAIl/FuUaazzMGR7/3IUVX7a xOk5qGzWubt5Rp0OJaHEp0ubOMxTfOl6Hou+45prvYwcdiJz2ZSYt/bq/bc7CBCTjSyM 3iykW7pbLBuK0NzpfMMh65nXj0bw9neSBQOxOF/MBm33wOylZ44v3FOTRBtGtcjt32Si W0YrEwytSWhCr5PzHT/JhJ1gQHUYirm428cXQCRa4jd+rxhxHNJiiicpJFvaFOC1e2Ea pnYk8SpusMJ282RYB5eD7+SQhvx2cOLMR+CxCIinZ5ryeDPydU6uM8StecuOVEzBFn7+ Eyaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=w0XTQyNU; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id n3-20020aa7c443000000b0050bcd68af88si331711edr.441.2023.05.24.22.36.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 22:36:43 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=w0XTQyNU; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CE36838555B9 for ; Thu, 25 May 2023 05:36:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CE36838555B9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1684992972; bh=wFffVv322eOKeXj42oV33TouzBLYe9Z7Uf7AwIRQYKo=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=w0XTQyNUWwRDatsBau2dsVmpHlmatAPfNpoFtIiiXiqMkzAE2pfwzuanr9X2X88M1 oK3v+RabZNvzn2IPb2YNH7xjVcHQgX8a2FHKnjXCjglIBtYLZ3mZ/bheOOkiAMuTDT 2B7Jpn5tF2jTdS7mDoMsfNhiT74A0QbRsWV+t4ZY= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id DC2B13858D37 for ; Thu, 25 May 2023 05:35:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DC2B13858D37 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-593-EsFuJAbuN4qgiCzFjDHDWQ-1; Thu, 25 May 2023 01:35:26 -0400 X-MC-Unique: EsFuJAbuN4qgiCzFjDHDWQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BBC773C0CEFF for ; Thu, 25 May 2023 05:35:25 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.192.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 53EBD9D73; Thu, 25 May 2023 05:35:25 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.17.1/8.17.1) with ESMTPS id 34P5ZN80244698 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 25 May 2023 07:35:23 +0200 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.17.1/8.17.1/Submit) id 34P5ZN3T244697; Thu, 25 May 2023 07:35:23 +0200 To: GCC patches Cc: Andrew MacLeod , Aldy Hernandez Subject: [COMMITTED] Hash known NANs correctly for franges. Date: Thu, 25 May 2023 07:35:18 +0200 Message-Id: <20230525053520.244673-2-aldyh@redhat.com> In-Reply-To: <20230525053520.244673-1-aldyh@redhat.com> References: <20230525053520.244673-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Aldy Hernandez via Gcc-patches From: Aldy Hernandez Reply-To: Aldy Hernandez Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766843223706174733?= X-GMAIL-MSGID: =?utf-8?q?1766843223706174733?= We're ICEing when trying to hash a known NAN. This is unnoticeable because the only user would be IPA, and even so, it currently doesn't handle floats. However, handling floats is a flip of a switch, so it's best to handle them already. gcc/ChangeLog: * value-range.cc (add_vrange): Handle known NANs. --- gcc/value-range.cc | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/gcc/value-range.cc b/gcc/value-range.cc index 874a1843ebf..2f37ff3e58e 100644 --- a/gcc/value-range.cc +++ b/gcc/value-range.cc @@ -269,14 +269,14 @@ add_vrange (const vrange &v, inchash::hash &hstate, if (is_a (v)) { const frange &r = as_a (v); - if (r.varying_p ()) - hstate.add_int (VR_VARYING); + if (r.known_isnan ()) + hstate.add_int (VR_NAN); else - hstate.add_int (VR_RANGE); - - hstate.add_real_value (r.lower_bound ()); - hstate.add_real_value (r.upper_bound ()); - + { + hstate.add_int (r.varying_p () ? VR_VARYING : VR_RANGE); + hstate.add_real_value (r.lower_bound ()); + hstate.add_real_value (r.upper_bound ()); + } nan_state nan = r.get_nan_state (); hstate.add_int (nan.pos_p ()); hstate.add_int (nan.neg_p ());