From patchwork Tue Oct 25 17:06:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kang Minchul X-Patchwork-Id: 10897 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1125308wru; Tue, 25 Oct 2022 10:22:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7cPi63XTsHOaCb1n8chQ5kqYh4KmbslXoqOegbD+kGLLXI6ZLZZ1sCQHU0E7eXY+A3+IVo X-Received: by 2002:a05:6402:27cf:b0:462:317a:dfe9 with SMTP id c15-20020a05640227cf00b00462317adfe9mr2252266ede.370.1666718549950; Tue, 25 Oct 2022 10:22:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666718549; cv=none; d=google.com; s=arc-20160816; b=rhXffmWTD9aYnXEHyn7q5LNG3oXN52USfddI7j73t6OIe103kZnXcwBVSNlJms8bJx NEpd56AWI7HxEfMkygueJYL6VXGLOM+VeqFWgCk6hTrlWH8QggdRrE4WNFI1RPmyoAZP TVy+nFdQ7f6HV2EStPcJf9u+VjX+36f9/LMjhs2b2sU5vPXSz39WinnM+MeXIy4K+lb7 Fb1KLgl0RSfUZ6z2rVpHDZ0yD15Bo58zpUMuq4y7s8Pnxz0xx39lElB58V4FLwN+Y+XJ 3tLkMe9mCdUSNVGugg2doMg0idZIJbZvg1aGCRQG3dmOQzyxT1o/s68od6JLo4Ru87bt e6nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dikvD5+bFGXRs81xXMLBNykCJfKHBwW8mLASTTcU7RI=; b=fQTRluQ+lOXWuKGK9IL6DRsrQe39/FtJ4apKINDVUxsZKdNJIGHFI5d3miLhRHEt/5 Nk0XOXMIjDGRNAzTCzxwFgADfPOFLbc3WzDdFEshblryxGUkyGtJOjgWidT8Jox5H1wl bqdC3SDDL6Byt0PzChfEvmfMa6oyY7IuU1PBtlzxBXCcfsu/deTC86EFDu8SqHFUHvR/ M+3QcqGlSYoB2TKUPRoqjkPDQRDbtOcgK0VpUHW7/zCDaudanrBuzOvX9AJ2TLgS62C0 ZMqIzEf8cjQDDDxo9moHhNe2L/6E6vEiRylGUlLpQbcJDCkKUXWGo70QQDFbobHiDEUw pMuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=CP3R2Vht; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y9-20020a056402270900b00461d9b46883si1108748edd.519.2022.10.25.10.22.05; Tue, 25 Oct 2022 10:22:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=CP3R2Vht; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231357AbiJYRGg (ORCPT + 99 others); Tue, 25 Oct 2022 13:06:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230428AbiJYRGe (ORCPT ); Tue, 25 Oct 2022 13:06:34 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EABB7FFAB for ; Tue, 25 Oct 2022 10:06:33 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id v4-20020a17090a088400b00212cb0ed97eso12420137pjc.5 for ; Tue, 25 Oct 2022 10:06:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dikvD5+bFGXRs81xXMLBNykCJfKHBwW8mLASTTcU7RI=; b=CP3R2VhtIikUhX0CQe63EEcuRzJ05+zBsyTaRfWVdRBk7wtsCdIuihqashVO2NtBz/ N3a0L8frBYFIVcNbhdAEaQQOQwMJGJREBXiGzBijaWfti6fgC+l/nIbknU4I6PAyio/f 95uR6K0cVqO4SgDrwkG83t8D8YFRI8qhfr1LuwB7M6RdlR7tWee1Y1OTn2aWEEmZNZ30 ArIdMgygY7iCcK8h8eecjlO1UgUFTS3C5yA9G8mVzGgw0nFVJQ36qzvXPQ8yKaBKq8yC eotE1K4MTp2NIC58s+dhNagJz/I3aQ0nrUCStYVMTqmbug33r7NS9JU6MZCLVI6TWpqB HMkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dikvD5+bFGXRs81xXMLBNykCJfKHBwW8mLASTTcU7RI=; b=e5gXsbbhr94DNcZn6cmbquObGVxGioHTkiw9xDyddCxJccBqchSwWu8GmhdIYnR6uc 1skqHdIQwhwOanS42D76aadKNQNsKJRRt5p1AuOgwS7Y94Qa1BWvmxr7LhQJBCnAnSoH rQf35bpa1xsZSDpQVOmgvPekyZVVEpSmiOX66a7CBmbW7X0T0gS3lmoqR6qKngww9FKP mZDfFPbIUpsGU1TSLMLwAlCw5Di4mcHUBnfuTPjFMqA/xjs9lGGCGFQMfgNKl5McPWbp nED9X6eRb0VUPcqcCOxIadsEUpZda6aDTjdX1pOhhxO9fIVDG11A01sKA4BagwHYaR24 X8jA== X-Gm-Message-State: ACrzQf2cukMwQaFRt4oMTd60ab6+TJvh5/EfBJrCzGFU3g0nSPw6pJuF RcFrXhkB2FkohDFgisKo1HM= X-Received: by 2002:a17:902:7296:b0:180:1330:b3c0 with SMTP id d22-20020a170902729600b001801330b3c0mr38689617pll.170.1666717592599; Tue, 25 Oct 2022 10:06:32 -0700 (PDT) Received: from uftrace.. ([14.5.161.231]) by smtp.gmail.com with ESMTPSA id a1-20020aa794a1000000b0056bcf0dd175sm1592373pfl.215.2022.10.25.10.06.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 10:06:32 -0700 (PDT) From: Kang Minchul To: Larry Finger , Phillip Potter , Pavel Skripkin Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Kang Minchul Subject: [PATCH v3 1/4] staging: r8188eu: remove unnecessary variable in ioctl_linux Date: Wed, 26 Oct 2022 02:06:18 +0900 Message-Id: <20221025170621.271903-2-tegongkang@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221025170621.271903-1-tegongkang@gmail.com> References: <20221025170621.271903-1-tegongkang@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747681070296827696?= X-GMAIL-MSGID: =?utf-8?q?1747681070296827696?= Returning value 0 directly instead of storing it in variable ret. This commit can prevent cocci warning as follows: Unneeded variable: "ret". Return "0" on line 3030 Signed-off-by: Kang Minchul --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c index 2de2e1e32738..5e1ad7733127 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -2979,8 +2979,6 @@ static int rtw_p2p_set(struct net_device *dev, struct iw_request_info *info, union iwreq_data *wrqu, char *extra) { - int ret = 0; - if (!memcmp(extra, "enable =", 7)) { rtw_wext_p2p_enable(dev, info, wrqu, &extra[7]); } else if (!memcmp(extra, "setDN =", 6)) { @@ -3027,7 +3025,7 @@ static int rtw_p2p_set(struct net_device *dev, rtw_p2p_set_persistent(dev, info, wrqu, &extra[11]); } - return ret; + return 0; } static int rtw_p2p_get2(struct net_device *dev, From patchwork Tue Oct 25 17:06:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kang Minchul X-Patchwork-Id: 10894 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1124540wru; Tue, 25 Oct 2022 10:20:47 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4FyNIB0tWRFo2IT0rIO4Exb75yQCzV2yveehZzc6HuHWuyRq9lv9vW8thNrgScqvEUyK2J X-Received: by 2002:a17:907:1c01:b0:78d:eb6e:3807 with SMTP id nc1-20020a1709071c0100b0078deb6e3807mr33686623ejc.481.1666718447327; Tue, 25 Oct 2022 10:20:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666718447; cv=none; d=google.com; s=arc-20160816; b=g9GSuZuoCqvE/QlQ3gEXtgix61sJE6x33+SRWZnsaKvyc7+TIizS7NHBzo0nJ/GdnK /viWp+trU0SINaIjTjEofwSah0FMVqRtoinV2imLtvYNkrVz+Xl0AEB93tctlASHip02 tK2wy9YeDomiRNnVvZWPCVknJXnYyAsZiEHRAa2dh1XkC8IlREZp0faHLbhHORhO+Zrg VGPZleeiO8K7HpAhS71QXdkeb9EELQeV+81GYZDmfo2pkCF6DLV6XjE9GbJAxrW66Zsj nF2bVygtKSP2nE9kdNg0gMDBR91/2s8tMEwpExNuYtTI7z1nkmxY+z2q8g5cOXiQL4CG 2fQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hiKyw0R3gnXw2JRFe0MILoD1CNInLwVAP+DIRRMQdcA=; b=AnFokQ5xqmEiY0UrBayfujJjSGNe48ZmL20VVwbuDBhEgQvYrENJloyTHbu3Wnvcmg q8i42QDCloOuuIn5PlOQRoseR6EXeWrqbOj2xT2OUr8iVSyYJaIIMXBOExpDU6z70ZCV VqTUeTlOCT8IBoZrD+amalB44ScR+Tl2Zofne3SI1XmBJsg6UNWZea8kxodjTUBg9Xw/ zeSBwzdkJFTFdIuCrHccOZtc7sHEMvQZFEKGnRjypZImETu2s8ZjyoIN07hhFDT1aGaB M+KmoK8k8MJ6FwYO/rYaI+gyleLFqzDgg4P+kxe1xUNC3mJE7D30zo7PfYOqolVA7af4 8M/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="Z7vGHc/R"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l26-20020aa7d95a000000b0045d25cf222csi3077274eds.362.2022.10.25.10.20.23; Tue, 25 Oct 2022 10:20:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="Z7vGHc/R"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231845AbiJYRGi (ORCPT + 99 others); Tue, 25 Oct 2022 13:06:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231608AbiJYRGh (ORCPT ); Tue, 25 Oct 2022 13:06:37 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FEB17FFAB for ; Tue, 25 Oct 2022 10:06:36 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id r61-20020a17090a43c300b00212f4e9cccdso7935495pjg.5 for ; Tue, 25 Oct 2022 10:06:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hiKyw0R3gnXw2JRFe0MILoD1CNInLwVAP+DIRRMQdcA=; b=Z7vGHc/RsXVHwy7Ey6NTTNIp8n1OPafSnE3d8E5xjPk9UHoIDKbAzQsIH+L0HPB1CG JVeAZhvibSS2rM1cfyIkte/VDA0Gob21awPRJ4gh+fNCbopbdU8Rokphv889+p3+cdTi Q00weE1M/4V7W8SWmGb+uhxOzb4TLqsG7gmI+d89rgmlt7ypEN52LF02rqpg6pDOzUH8 kqCg1VM2ReCt04f+NxeuyGtXS8cuH1Mjlk3KDRTNVEeYIaN1aYtxjewE+GbkuO8nW12u bxlC6GySaycF/qvT+8rrZTOcOxy46CAdUEhJwGdPlf2E0lkbqMyofZe0zKo2AoiybTrK 2iBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hiKyw0R3gnXw2JRFe0MILoD1CNInLwVAP+DIRRMQdcA=; b=fyPzIE3bxx94bG6tbqJzg0T3znRigZRV7aj/RlvG7SoiZQma87EEwGqnb1mNOMXsx/ qALlHtcSBzXpZEG0d7iy4CXCwF3+PxJ4nxI97Y5EN+xBmTBdfVu8SyBsCWhjWL4QU04K C4YUhDb6eNoebicUQ7IBbnHg/jSp/uBznD0+yMn3+omO/gf42bszCKBHvuHGkm2qZCjF HXPitcAQJsD1n4dzB5PmW62iTk5Uvhneynp1wVIAQJVu56xqM/GTbYvl4Cy8NArNnrni JGAzzq1vervo8iHRlrOF2CMHlqRtACXpCbX1AxzmGG4vTVnxHjsFvv8aDS3npHGpYTWx KWuw== X-Gm-Message-State: ACrzQf3lcgR1n8Bbn9+qw8PPmOaCt4w14AESJQzOTOk9hk+cqs9aZNsM 1FvYjw2PmeJATZTZJ2V56f8= X-Received: by 2002:a17:90a:1b44:b0:213:1035:f913 with SMTP id q62-20020a17090a1b4400b002131035f913mr12926951pjq.133.1666717595494; Tue, 25 Oct 2022 10:06:35 -0700 (PDT) Received: from uftrace.. ([14.5.161.231]) by smtp.gmail.com with ESMTPSA id a1-20020aa794a1000000b0056bcf0dd175sm1592373pfl.215.2022.10.25.10.06.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 10:06:35 -0700 (PDT) From: Kang Minchul To: Larry Finger , Phillip Potter , Pavel Skripkin Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Kang Minchul Subject: [PATCH v3 2/4] staging: r8188eu: remove unnecessary vaiable in rtw_recv Date: Wed, 26 Oct 2022 02:06:19 +0900 Message-Id: <20221025170621.271903-3-tegongkang@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221025170621.271903-1-tegongkang@gmail.com> References: <20221025170621.271903-1-tegongkang@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747680962652740126?= X-GMAIL-MSGID: =?utf-8?q?1747680962652740126?= Return _SUCCESS directly instead of storing it in a variable. This can prevent cocci warning as follows: Unneeded variable: "ret". Return "_SUCCESS" on line 1516 Signed-off-by: Kang Minchul --- v2 -> v3: rollback to v1 because v2 caused error by kernel test robot v1 -> v2: made amsdu_to_msdu into void function drivers/staging/r8188eu/core/rtw_recv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c index bb5c3b3888e0..9e98aea09583 100644 --- a/drivers/staging/r8188eu/core/rtw_recv.c +++ b/drivers/staging/r8188eu/core/rtw_recv.c @@ -1415,7 +1415,6 @@ static int amsdu_to_msdu(struct adapter *padapter, struct recv_frame *prframe) struct recv_priv *precvpriv = &padapter->recvpriv; struct __queue *pfree_recv_queue = &precvpriv->free_recv_queue; - int ret = _SUCCESS; nr_subframes = 0; @@ -1513,7 +1512,7 @@ static int amsdu_to_msdu(struct adapter *padapter, struct recv_frame *prframe) prframe->len = 0; rtw_free_recvframe(prframe, pfree_recv_queue);/* free this recv_frame */ - return ret; + return _SUCCESS; } static bool check_indicate_seq(struct recv_reorder_ctrl *preorder_ctrl, u16 seq_num) From patchwork Tue Oct 25 17:06:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kang Minchul X-Patchwork-Id: 10895 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1124904wru; Tue, 25 Oct 2022 10:21:36 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6iv/VsqjskmndavemAVRuTWxtJMyhs8Ai/YoxGXXksnnCTFhKZZRYRXzf+EP8As5YpBqnC X-Received: by 2002:aa7:c78d:0:b0:454:fe1d:8eb1 with SMTP id n13-20020aa7c78d000000b00454fe1d8eb1mr36699140eds.59.1666718496414; Tue, 25 Oct 2022 10:21:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666718496; cv=none; d=google.com; s=arc-20160816; b=inoh8m+M9THMQlXQdPClnO0OntDVRt3Atnl/AGshdY3RPuNUtahzPuH2sy/HhR0QZ2 H0iOlUPOaOqg3KAGI5969pYPFoXcIAfiha/iWC0gEB6FL251PC5weG6hEKCUk35nFWr2 4XjyPT7Hxr65D6q5ASx3RenNoT63FJNuhrnPdPWZlye+lQa95O4uJFrW5PM+bAr4TTD7 BalVUaJ1Fm5YyB713jTeNlm4sYnzqHnFOBZNV4AQijAyDKV2BfgNNUOPS1EVs2+G+F3u GgeXd+14jaVLnfkfy4seCPFuH9++FyRs5eSkJoHRLBLqWD5ZS4VeYbo/JB5MKXAun5Lf Jlhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NnolCiMBjl8qX8ASTYaNnJALNGKZaQCXHfWumAnTsTM=; b=VPkNYWiioDS8Lz3WUfx5iK8SaeC5nRuoyBB60dnqyfn4qj2UNF/SIJGedzKzfnEaF9 q5Md78HumzPiUiRzvy3Na8BzrjIWIG5xoDsxk+QJmH+F15ED4jwz0DHounPBsj3Nhnoo UKewVlV8A+yveoyJpTNn6W3ME/SEietq8q4K69xEjrPh6x0YcazL49aLHRBBX/fRxkn/ oiQ4PZ9YXl7XDyXvDiFb2lRWJhPEg5xpIUrcfC476leTpgalU7LSTYihIeRTDph9MBZo i79/X1Kj2SRuLbCSWmzd6st+jbul8P43VoYh/pLXVmAd8ZEdxxHJibG1mw+DrUEOXQsX vwjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="lVs5bh8/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t21-20020a170906065500b00787796077a0si1215845ejb.429.2022.10.25.10.21.12; Tue, 25 Oct 2022 10:21:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="lVs5bh8/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232327AbiJYRGq (ORCPT + 99 others); Tue, 25 Oct 2022 13:06:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232128AbiJYRGj (ORCPT ); Tue, 25 Oct 2022 13:06:39 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23ADB110B0B for ; Tue, 25 Oct 2022 10:06:38 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id v4-20020a17090a088400b00212cb0ed97eso12420407pjc.5 for ; Tue, 25 Oct 2022 10:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NnolCiMBjl8qX8ASTYaNnJALNGKZaQCXHfWumAnTsTM=; b=lVs5bh8/oQHRESDcFisg9lo7D0bWmjFZK7WMEzSUE/Wupu20lHGa8ZZ0swCrET1kp6 EUESeWrnWtmUczokeCku2Lr6VYmVHBfWvEb9AjdujPeP5FWQz/wfPM1mBxqBFLyp+zG3 tLdkucVzgvsuzHpY21/fbkCzppL7mgsVOKUNs8QShrobxdhOxu+aP3I3Z5M8EzJzeR8r ufvTd81wt8hru+wiQ9PiTEVDHyq0MsvGHh+lRCkGiwaODf9MwuD4t5GpQzt4khykYs9R Do8MaGZ+PJfMrwCItQMoDnjkQR7/Mwga5iEScE7wceQzXWKw+U7Iiv0DTJ0N0G6pXXAd PlMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NnolCiMBjl8qX8ASTYaNnJALNGKZaQCXHfWumAnTsTM=; b=ezfrdI8Ar6gC4LogflQW6auW2Q+Y6jfBxd4k9pqjvksBFh+Uo0scIrqPFeccx3zoFw 1wJeJqmZV/1TY9XDWiIVaWY0qXGkHPw/CAGpq+95kV97dh5esXz0XfJDJo+C+CQCp2UP eFcUMrD0SzRsCTyzBTkxrgDAxWZmIrzXc/wwTORyOluTggSnrjTUt39s0QWqe9qVnSVn MeMAeKLMO2wJEPH3nmwNhVC9nZznOlDD4hpeFP9ibDveV5ZorCzbfuYE5YxkGHt4clBx nExtLK2nMhEQS2hiUP6fQn1KrdA+FOMoEU+sRK2mojE/z7OJKuHvvorSKklyMSEs7YBI S9ng== X-Gm-Message-State: ACrzQf1YITnX9HRIYsXbwD1GfZCg/xkdBOmPGCsFzeRZ5jxwRXSbERNj M8RpW6qI/Fj2d+VrtuBF2iY= X-Received: by 2002:a17:902:e750:b0:17f:71fa:d695 with SMTP id p16-20020a170902e75000b0017f71fad695mr39684804plf.105.1666717598588; Tue, 25 Oct 2022 10:06:38 -0700 (PDT) Received: from uftrace.. ([14.5.161.231]) by smtp.gmail.com with ESMTPSA id a1-20020aa794a1000000b0056bcf0dd175sm1592373pfl.215.2022.10.25.10.06.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 10:06:37 -0700 (PDT) From: Kang Minchul To: Larry Finger , Phillip Potter , Pavel Skripkin Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Kang Minchul Subject: [PATCH v3 3/4] staging: r8188eu: remove unnecessary variable in rtl8188eu_xmit Date: Wed, 26 Oct 2022 02:06:20 +0900 Message-Id: <20221025170621.271903-4-tegongkang@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221025170621.271903-1-tegongkang@gmail.com> References: <20221025170621.271903-1-tegongkang@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747681013941655774?= X-GMAIL-MSGID: =?utf-8?q?1747681013941655774?= Return 0 directly instead of storing it in a variable. This can prevent cocci warning as follows: Unneeded variable: "pull". Return "0" on line 298 Signed-off-by: Kang Minchul --- drivers/staging/r8188eu/hal/rtl8188eu_xmit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c index 8e4a5acc0b18..6d1f56d1f9d7 100644 --- a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c +++ b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c @@ -149,7 +149,6 @@ static void fill_txdesc_phy(struct pkt_attrib *pattrib, __le32 *pdw) static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz, u8 bagg_pkt) { - int pull = 0; uint qsel; u8 data_rate, pwr_status, offset; struct adapter *adapt = pxmitframe->padapter; @@ -295,7 +294,7 @@ static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz, u8 bag ODM_SetTxAntByTxInfo_88E(&haldata->odmpriv, pmem, pattrib->mac_id); rtl8188eu_cal_txdesc_chksum(ptxdesc); - return pull; + return 0; } /* for non-agg data frame or management frame */ From patchwork Tue Oct 25 17:06:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kang Minchul X-Patchwork-Id: 10896 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1125232wru; Tue, 25 Oct 2022 10:22:20 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5y84kXEQezHM1wnnJmmqJeIhr1nBaoWF47UQvGIzO8P+a/oTn2W9++acZg2prgKRFbFhkm X-Received: by 2002:a17:906:5a4b:b0:78d:8790:d4a1 with SMTP id my11-20020a1709065a4b00b0078d8790d4a1mr33517953ejc.329.1666718540790; Tue, 25 Oct 2022 10:22:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666718540; cv=none; d=google.com; s=arc-20160816; b=PZn54JOlR2tPfo6WPr01STCozmzl24se2l3j1R7KqHOtwmoVtORveoJom5R6TjjxTF jmxqnQ1FNhI3NRfufaXYIDRfxx7WNJi1e//Mpxv+vyNIbaypL0K5Sgt6TdzsS/5iIECW Hh2Iq3ACzIBkoX+C4fasGj24RoD24gboe5fwEFUWuuZ2tzWxR427jVlK06+m52OXZ9wk krNG8bYfGzYQKm74rMZH6+BDlyrLrkjLejQVp0IJwmAYosVpQskdx3lGvAkbGm6wYTpv 2zpmvDYVJsaYLcwTMGn0cH7jKzMlkU81gX3SCc9JgHf8YR+zGlMN5/BDSNdEdhhTsiF4 nm2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1C3nf306oEfMsyZ7A/6P43aOoOgNlqhI8zKR7LmGgzA=; b=RZwBDELyj5DuMl4iP0DfTu8Dg3BCX+gSGi81l/AjSXEPqKnZuh3vedRTIzduLohC94 BRY5dTJHT2iKR6IqaI0FmlZTov5bHgvgJxadTxuFZdpUzhPhg+M64pi13txFtqcFsFfX BpGRyG8sYUp7XiVNfAPf2UftaZnLdL43/HCdtnRg4W6HSaV6wKIxD42IV+BdVC9NqUks mytnaE6GqZ3rLsNSuBN+peDzWyvW5SrONTQwJ6vMkR0MR3+ED5ag+iUa9etgqwcRnLmY 74wRCTILBvf8mRSQuQ8Ls3h7KJrmHbwcucXvNyH94psB3/LxC1d86tPhuq6sWhZM821l SORA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=YH5a7Qf7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e9-20020a056402190900b00461d375794csi3998785edz.608.2022.10.25.10.21.57; Tue, 25 Oct 2022 10:22:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=YH5a7Qf7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232380AbiJYRG4 (ORCPT + 99 others); Tue, 25 Oct 2022 13:06:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231889AbiJYRGm (ORCPT ); Tue, 25 Oct 2022 13:06:42 -0400 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47649111B81 for ; Tue, 25 Oct 2022 10:06:42 -0700 (PDT) Received: by mail-pf1-x429.google.com with SMTP id k22so755277pfd.3 for ; Tue, 25 Oct 2022 10:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1C3nf306oEfMsyZ7A/6P43aOoOgNlqhI8zKR7LmGgzA=; b=YH5a7Qf7bHqiUjamMDYDR4fYo3/lUlFVkLQzAby/DSDXbs61FsJcGUTuYr0CsEeAQl nribGEDcxzKJjIrLikwWrkn3XFPKHeTq9WhZMLwGKUl3gTpvEZcvSD6YeX12pKiPOsBN Te1Nt9UwnpYWqqPngotKBzn4EJ7KngORvCr6iOGvXuZJ4cJ+7PD2HbdUvCyxn8/uM0V4 ml9fHAYBG/rsQy3GeMz90vj1FV/Xg6YqLtSdJRqedYKsA1YqqtV6oY270UKORZfjGkiy FPpfMtiVTjI/JlF8NfhzI/S0QrHNETwDjh9ybJYOTcz7lWBT1gJlI3DW+LrIZ2rJOy6c Fwcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1C3nf306oEfMsyZ7A/6P43aOoOgNlqhI8zKR7LmGgzA=; b=x8H1HcgeDWqXfdDVXUY3G4aIpcxJHLrGc9xu7w0pjCoZ5pq/8SCxtTUJkyf0wmO/Yu n1GcHt20u83SdTqg3yVkaHD/Lo2HrjEVxKbX4j6PJ/UpNw5lTHOJRwXgxtQV8yGTZrh8 AiJF2KgTHtUL9luA9k++p3IuOKu6F1tUsP3aE44a/BYw3/F+ecMiNOq0pX1RXPAcZf9N 4ZhzkvxVIUyvyvEb0KJ2ELRLpX4qcBoX3z3eSTVnIooUfkHi4pnnuMD5VUPDj6VyUrZ3 hPLU6S0k2A5d4HV0IRV7fXlBfrhPkrHvAAuM+LKRNma1vucmQQf2sO7dk4bnRckKKDkW kwsg== X-Gm-Message-State: ACrzQf2Lv2C3pfBEJarX/OHttn4km7jgbjGiIxwy7v6jVSMaPEZdWAC1 tXiinJg1uT60QaQ3sj5ubQ4= X-Received: by 2002:aa7:8299:0:b0:562:4c48:a0cb with SMTP id s25-20020aa78299000000b005624c48a0cbmr40291105pfm.66.1666717601709; Tue, 25 Oct 2022 10:06:41 -0700 (PDT) Received: from uftrace.. ([14.5.161.231]) by smtp.gmail.com with ESMTPSA id a1-20020aa794a1000000b0056bcf0dd175sm1592373pfl.215.2022.10.25.10.06.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 10:06:41 -0700 (PDT) From: Kang Minchul To: Larry Finger , Phillip Potter , Pavel Skripkin Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Kang Minchul Subject: [PATCH v3 4/4] staging: r8188eu: make rtw_sta_flush to void Date: Wed, 26 Oct 2022 02:06:21 +0900 Message-Id: <20221025170621.271903-5-tegongkang@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221025170621.271903-1-tegongkang@gmail.com> References: <20221025170621.271903-1-tegongkang@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747681060433971986?= X-GMAIL-MSGID: =?utf-8?q?1747681060433971986?= Make function rtw_sta_flush to void in order to prevent cocci warning as follows: Unneeded variable: "ret". Return "0" on line 1031 Signed-off-by: Kang Minchul --- v2 -> v3: made rtw_sta_flush into void function drivers/staging/r8188eu/core/rtw_ap.c | 7 ++----- drivers/staging/r8188eu/include/rtw_ap.h | 2 +- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_ap.c b/drivers/staging/r8188eu/core/rtw_ap.c index 24eb8dce9bfe..e0ca4b6e17cc 100644 --- a/drivers/staging/r8188eu/core/rtw_ap.c +++ b/drivers/staging/r8188eu/core/rtw_ap.c @@ -1017,10 +1017,9 @@ u8 ap_free_sta(struct adapter *padapter, struct sta_info *psta, return beacon_updated; } -int rtw_sta_flush(struct adapter *padapter) +void rtw_sta_flush(struct adapter *padapter) { struct list_head *phead, *plist; - int ret = 0; struct sta_info *psta = NULL; struct sta_priv *pstapriv = &padapter->stapriv; struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv; @@ -1028,7 +1027,7 @@ int rtw_sta_flush(struct adapter *padapter) u8 bc_addr[ETH_ALEN] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff}; if ((pmlmeinfo->state & 0x03) != WIFI_FW_AP_STATE) - return ret; + return; spin_lock_bh(&pstapriv->asoc_list_lock); phead = &pstapriv->asoc_list; @@ -1050,8 +1049,6 @@ int rtw_sta_flush(struct adapter *padapter) issue_deauth(padapter, bc_addr, WLAN_REASON_DEAUTH_LEAVING); associated_clients_update(padapter, true); - - return ret; } /* called > TSR LEVEL for USB or SDIO Interface*/ diff --git a/drivers/staging/r8188eu/include/rtw_ap.h b/drivers/staging/r8188eu/include/rtw_ap.h index 8b4134eb3095..89b02c97e041 100644 --- a/drivers/staging/r8188eu/include/rtw_ap.h +++ b/drivers/staging/r8188eu/include/rtw_ap.h @@ -26,7 +26,7 @@ u8 bss_cap_update_on_sta_leave(struct adapter *padapter, struct sta_info *psta); void sta_info_update(struct adapter *padapter, struct sta_info *psta); u8 ap_free_sta(struct adapter *padapter, struct sta_info *psta, bool active, u16 reason); -int rtw_sta_flush(struct adapter *padapter); +void rtw_sta_flush(struct adapter *padapter); void start_ap_mode(struct adapter *padapter); void stop_ap_mode(struct adapter *padapter); void update_bmc_sta(struct adapter *padapter);