From patchwork Wed May 24 15:26:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Helge Deller X-Patchwork-Id: 98553 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6358:3046:b0:115:7a1d:dabb with SMTP id p6csp2908737rwl; Wed, 24 May 2023 08:32:51 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ47U9gVY6qFjoChAdpCXJFznLKugQCMBnEKijIUA+ZmxsvZLEeTMrc50E0QB+/pLMLFO/l6 X-Received: by 2002:a05:6a21:796:b0:10d:b160:3d4f with SMTP id mg22-20020a056a21079600b0010db1603d4fmr1591940pzb.38.1684942371028; Wed, 24 May 2023 08:32:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684942371; cv=none; d=google.com; s=arc-20160816; b=dT8RfamE1HIXFIX7Bj5O9JXh6J2XIGTm7FaM8ZVeNoZpOvJCTLJfd9fFIONnJEjXY4 YhlS0l58F8RSnfL11NdvGrfkC7NteEGQa6oVTuYb0nsJlzN1mYqXiLXgacDxRfSPIfPg 0dEToUek0SJdWhGR3CHsC0lMGv5hgIkkiBg5N7eFg8DXr8+jKq/PlHLTbtaKNLykYwtg rfYmZqpsu5wp0XDJpj5HLSLnpregeq1suMZew9SGFNGjsOtAHhcQDpGDVrv9Gc+TCGhN m997v7IH3/sPXxfCdP073fUXhA0DfLCkAO3PH+/oxJsZoJFACG6fmdFhH9teQO60oCe3 fYbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:ui-outboundreport:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=2fK/FaNL8tdqPMr1dJgjjCH4zFpVshe/EqSIVKSH4MI=; b=RNTZ7DzsQSD8OPZg6fy3fTAEBdMm+R3DymSEBzcS1s9wCXFcYQQ0lsrZK7MsI53V6d THzHYbz3DSTyGZ/zsQNK9pvc32yl8gGymqzxDHVfsqSv27LuqCgocvL2d86akYMzv983 kLY7jNhK5DwUDy6ROWXBuahrwXmQRwayrpNjuV6F6DlK2dBI0/UEN7EGsGivSI5QwLcS bNPQwcH4nH+QAYKSTdelb4wfn7vL/HD9KusW+gmCRCTKtIgRGDvIh0tHUgjoHrSc4UX+ dUDvR3kijoLVLA356T3F6US51sPNaNAmvpfMHR22imRzpQM/PrXHXb/KI15vwNgIPRLz vaBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=VUgJ0nXp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmx.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q5-20020a637505000000b00524d1d335bbsi3017892pgc.56.2023.05.24.08.32.35; Wed, 24 May 2023 08:32:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=VUgJ0nXp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmx.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235820AbjEXP1B (ORCPT + 99 others); Wed, 24 May 2023 11:27:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235805AbjEXP06 (ORCPT ); Wed, 24 May 2023 11:26:58 -0400 Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09D3D10B; Wed, 24 May 2023 08:26:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1684941998; i=deller@gmx.de; bh=+7ESBTMnHGzg+BKexPIHQjMLlUGjKMaqw4IK8630UvE=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=VUgJ0nXppL2cSoQPfPaZ9sFoxXNPq3sAWnlS2eRSnwHoGM5lbpghuqTKcBqWr9TDX RUsG/RFliWFIYSrqEI05t/eIeRWNPqVyrZAwx7GxnoLF3fVr6lvlCthH4DJZ/Jhb16 669t/7BzI8s69lwdGSilAdF6c/JFoe+j3AmbP7hUwxdxd3hJMkd932eketQdzP9NY5 GTWCklCGS+Wuiu3nbXe4y25H6BVN8GkQXkvVxr8sgJXYEQXm8cgWhNN2AIpbAYEotr HjdIl7dnTtbp8S72+y+7QGsAZt2Czp3J9+AE0y2dMQFVN+NHtJBvFPjvDKmU77XqSi HYRkvFP580uLA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from p100.fritz.box ([94.134.145.4]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mlw7f-1qS4a526J1-00j47c; Wed, 24 May 2023 17:26:38 +0200 From: Helge Deller To: linux@armlinux.org.uk, dinguyen@kernel.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org Cc: Helge Deller , Arnd Bergmann , linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/3] arm: Fix flush_dcache_page() for usage from irq context Date: Wed, 24 May 2023 17:26:31 +0200 Message-Id: <20230524152633.203927-2-deller@gmx.de> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230524152633.203927-1-deller@gmx.de> References: <20230524152633.203927-1-deller@gmx.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:tUOwkAD2Hwce0F7HpGXdFvczL1Vky+pJRPAudFb5SqpMeggqADn B/fQ3hYtCFp2le+aYewHIkulKDk774tIryq4+2qkyw3mjaF0HIG659O24ZDTrNfPlyMck6t dO6+9pQO60addIt/pr8QsTme9dFEhBQBJSZ3/xQRtY8INuwR+D0OVhig/RM7AWJKaCTkUjk zXnUkLghltylQ/1QDAHXA== UI-OutboundReport: notjunk:1;M01:P0:x5fMiYGFG/Y=;QxAs8oUyx99ZIokWpAiA7fEQnee mG3XQQGTRp0m0H8wQATcLxS6FSwRgYHVbRC7IahhpHsH0eToisxnnlA/6blF72C7sWn+lemem 9S7u2P4gKqzJnKVw2SifzUlVrKyPsXC3YP1p04CZGvjVZ1HeUJLrDZFkohNFfS6q/NbpD2kFT p8V6sRTxxqJ6RslEGOssl56LSUxpFNQiGWpc/t4ausZGt5jc4dC/7OKL9FNsPoejR4tVu31Qd 06+Sgd2jzwXfNi1rST8rzNDaXfRbJ4iqK32ctzf5GWJfT1BKtQ7RSWPntt5I64DaUk99d4vt1 SInwnAqiXHonKeEOB7B/hqS9ZvQA/BYtLF+cGf1YJm56ZLEV/G8UVTDZo+eQkKyjai+OxP1AS ZmWWQP6PT4BaQ1pDffWQ4Hd2/XE8Sr0LoOr5USvmzUbhaxJv35Hw+2Wb3Ov40d8dZTYFgeBen cTlNnyalUGAt3R+uNeFsXsYCSliyCb8AtMRrbZ0BB5fi2nLUetg3xIHccqLgR+Y7v+CIgCW9S aAOSWzjX2XZ5wwKRKfEpJirlsEyDg8KJBud3VfSB60QP7JsDQyoKDhcQNDSxNzIAe9Mf1CzRp hbks40j1tb/w4bZ665MgamCQr1GNdllwUtOISrD2uKpczgm+cJ3Fwuvji+yfX00+YqgiZVk60 GGkGOeR7z2fOa43Y6nRrXVoDpotPHPIRs4RpLwoEqXURg75iCHsIwryEbOPyko/bkyXZpZwPl S0f6O8GTTrgSe+DSd258j5WNIjxczc1XtsP62zkiO2bfWDYgbrXseHRRIuWBgmxLqYCEho5ZQ 8D7MCYvCRF+ygs+4f5sB2h5QUCyeZfNP4hFA3+lhEE/jpj0JW9IZUvZbsJNWbZhb6nh5fWldN BVMdtXDy+hURct4nW5J+dP2pJAkzNEirnzmL/krZZRQH4+kG3eoiHRRj1fOh1yWItxVY0QKHy fYBNzn82UH+cn1smT46PEofvVmM= X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766790131949954837?= X-GMAIL-MSGID: =?utf-8?q?1766790131949954837?= Since at least kernel 6.1, flush_dcache_page() is called with IRQs disabled, e.g. from aio_complete(). But the current implementation for flush_dcache_page() on ARM unintentionally re-enables IRQs, which may lead to deadlocks. Fix it by using xa_lock_irqsave() and xa_unlock_irqrestore() for the flush_dcache_mmap_*lock() macros instead. Cc: Russell King (Oracle) Cc: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Helge Deller Reviewed-by: Arnd Bergmann --- arch/arm/include/asm/cacheflush.h | 4 ++++ arch/arm/mm/flush.c | 5 +++-- 2 files changed, 7 insertions(+), 2 deletions(-) -- 2.38.1 diff --git a/arch/arm/include/asm/cacheflush.h b/arch/arm/include/asm/cacheflush.h index a094f964c869..5b8a1ef0dc50 100644 --- a/arch/arm/include/asm/cacheflush.h +++ b/arch/arm/include/asm/cacheflush.h @@ -315,6 +315,10 @@ static inline void flush_anon_page(struct vm_area_struct *vma, #define flush_dcache_mmap_lock(mapping) xa_lock_irq(&mapping->i_pages) #define flush_dcache_mmap_unlock(mapping) xa_unlock_irq(&mapping->i_pages) +#define flush_dcache_mmap_lock_irqsave(mapping, flags) \ + xa_lock_irqsave(&mapping->i_pages, flags) +#define flush_dcache_mmap_unlock_irqrestore(mapping, flags) \ + xa_unlock_irqrestore(&mapping->i_pages, flags) /* * We don't appear to need to do anything here. In fact, if we did, we'd diff --git a/arch/arm/mm/flush.c b/arch/arm/mm/flush.c index 7ff9feea13a6..d57ec9165520 100644 --- a/arch/arm/mm/flush.c +++ b/arch/arm/mm/flush.c @@ -238,6 +238,7 @@ static void __flush_dcache_aliases(struct address_space *mapping, struct page *p { struct mm_struct *mm = current->active_mm; struct vm_area_struct *mpnt; + unsigned long flags; pgoff_t pgoff; /* @@ -248,7 +249,7 @@ static void __flush_dcache_aliases(struct address_space *mapping, struct page *p */ pgoff = page->index; - flush_dcache_mmap_lock(mapping); + flush_dcache_mmap_lock_irqsave(mapping, flags); vma_interval_tree_foreach(mpnt, &mapping->i_mmap, pgoff, pgoff) { unsigned long offset; @@ -262,7 +263,7 @@ static void __flush_dcache_aliases(struct address_space *mapping, struct page *p offset = (pgoff - mpnt->vm_pgoff) << PAGE_SHIFT; flush_cache_page(mpnt, mpnt->vm_start + offset, page_to_pfn(page)); } - flush_dcache_mmap_unlock(mapping); + flush_dcache_mmap_unlock_irqrestore(mapping, flags); } #if __LINUX_ARM_ARCH__ >= 6 From patchwork Wed May 24 15:26:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Helge Deller X-Patchwork-Id: 98554 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6358:3046:b0:115:7a1d:dabb with SMTP id p6csp2909483rwl; Wed, 24 May 2023 08:33:56 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4slwuQ9xY7K/2rJ0763bCcR3elaoK0nZuVc7pM8NQCYPnoYfzlpwK+493GD8uXiwznJAMC X-Received: by 2002:a05:6a20:840b:b0:10b:b401:8435 with SMTP id c11-20020a056a20840b00b0010bb4018435mr11422594pzd.16.1684942435700; Wed, 24 May 2023 08:33:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684942435; cv=none; d=google.com; s=arc-20160816; b=tH06n21l51U6VrPfMYQUD0J6PZrguNIrVXm6FrqBKHx5WFX3Wi1dgHdcw7KEsh1DUM JGARcr0n6zHGfENiJ8gSDMRXIB1vB0mtTRp1yb4qJW+d6MNSdEB/Ko0sZitab7WfTnhL Wl6h59rSlvb1+uxANSkma9OVklIP8rqJ9gO4en7lG0Sdv45BCmOf/3bRcH+xBI4/cCQi 1BdcdrPCUOalXpsR2IrCPQGFVoGQS0lj/H2XgD+YYxCpd9NESL1yv69nPT5Gj7z8BGhd SqJ2+PbyyAkktwQN+qAgx4uppTY1uCdBdy57RBzH7Jyk2FnTxcncckZ1q9jI3jhlBgYt IJUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:ui-outboundreport:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=VE2sDTJ058+1pijeQGQ2OhjinAhFkQ5yLRT9Xvradzs=; b=Hmac24MyWDhBOQ8I7QeMEb0sPP+9+mG3wWYtM9qdgXkaLZ4J6INaJnm3MV58IdMKAC I90XnKTpyle2ObqpwhloSVtyEUdkjPGtDB3o0Jf+XdWmCHjyig5qWVDpUdM998tkprEC GfP98o0xW8u00Y88Rb4vLjPVhsOzRtr5ce/Oza4HIzIpeLQiEjfjKI9HslnFAPFcIYeO OGjxnnVWENs6q/N7OmqQVDp48ebUuvVcThfnha29JmzhngpxDui5bKpfim8TneaTsz0y 9NrgkEM8GOARD7+H4CDgnIxoJYkmSX1avCYgPEaFfiwcCew3rDqgFFf6+hMq7lH0Q0/r amiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=hZZAhGz1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmx.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j11-20020a633c0b000000b005340840c0c0si3262009pga.11.2023.05.24.08.33.41; Wed, 24 May 2023 08:33:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=hZZAhGz1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmx.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235402AbjEXP0t (ORCPT + 99 others); Wed, 24 May 2023 11:26:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234306AbjEXP0q (ORCPT ); Wed, 24 May 2023 11:26:46 -0400 Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F7DD119; Wed, 24 May 2023 08:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1684941998; i=deller@gmx.de; bh=lapEzOcX0STqTt0KmKBhtPzemZ35g1ecV7VM6duHiTw=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=hZZAhGz1sczisgM/+s2NHhe0zQZMv9rY+98uxQlySChUAYyXqSpBTJY1mHhr2e4JG WtV4Dr1dYxuG12zH0uzGXnFVt4tygu8cfk0eae70buOBrPO9cX+Yp5m7oLM6m5JgIs YzFDOewJUhZnnpRVYgYKv/+FvNPDLV6krnPDRuiIlRSZRyDbgO5q4sjfHM/MMbE4li 4XHmoQhP7yWFfhmRKo8qxTaxAfEpNtEMzmGaNryxpOsjCEGysTRYhgh3eFjYeJpJD1 BxMYMaiirHtVPfvP8GWzWVW7YMozKTnErCUnInHYOlhqTpuIkXvGn3nOBMfpovSQ/L szijpurACVAXA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from p100.fritz.box ([94.134.145.4]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Md6R1-1qauHl2mzD-00aEQy; Wed, 24 May 2023 17:26:38 +0200 From: Helge Deller To: linux@armlinux.org.uk, dinguyen@kernel.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org Cc: Helge Deller Subject: [PATCH 2/3] nios2: Fix flush_dcache_page() for usage from irq context Date: Wed, 24 May 2023 17:26:32 +0200 Message-Id: <20230524152633.203927-3-deller@gmx.de> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230524152633.203927-1-deller@gmx.de> References: <20230524152633.203927-1-deller@gmx.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:QLHFTCIICHSorhJDOatdKxoLujOmIrGuhR+nU+2cO2Tj/+9N1+U sdfGNkXhs84pGZ8IYSv8Oftaz+5ZVFPaHHYms9/Yw54FGkOkCbIjet876UBKlxSJDDVpV5x 0pnQF306dPo02Y1cRDhq8prqXAsDhIFw2Ax3XvoHqPwcF+6bBK92XXV43/3pLS/ag2+4Muh ONcSqjEkiIb1J48NuPaPg== UI-OutboundReport: notjunk:1;M01:P0:n11iHDnCaMg=;Z0dNwCBAlxUepCgQC5fSPrKhciR MtbyPa8KjyDmG+FSfa+A/Lhf58F5POAGhLIziU4sUG6N/s2mGTaonOnHzYyHQLRjTDLoxLtGb fzD9/y6h+kFJgLX5uq8Ln7IZXI+xM4rqV79G1DKiEol4GhlEvwnII0p4nTYYTPQfqI4cxJxAu 6/usoOSDBhpGS3aktfdxW8lzoZ/lhEU+fTG1H5nHvwPENVFTTPWLv5gDQfW+/E9txUvu9UlZ2 IGYUEqZuEpvLTKklDfJRNpUNGN9txPH8nUNFASdy9bBnznSgA2ZC1K1+JLBLMArdgqcCsdQ2E 5YG5JduZaA5ENMICJbYRLuwdlSQAF7nTPam76fcpIAvJNkGjwaT3LCSbm4UocvYa8oWb2R0Bw Hl7MJyEm/oCgAvaJ2R80+O86vmlBdwMzDO+qX+HtGFIWDAcWqxxMCICstMvxJT87WbCaQGbyQ J1rMCCHNfSVG+i63RNbFXO9OYLxfz5gg4VFD5wyQkDBRTBrvVrfRA4p74QV7xPwi8pjmxeXey A7nAYqB20EgP6VVchbsenQXiip0v4+arOaT1E5T51vCIesVhrwRQFCQjaW+CUOyaxOTJirTHL eTVdc7mIteUXNWCZiJCd/Re0Damrj+rgX0YI/pbtRrZHAfMaCYj2kkIOH+XmOOYX07T+YqnE6 XPmHry5qC8g/PLq9JyAUeqWS4m/okg25Gelx4CtSDMEkcwVUYH1elyTEKSTOnj4XM96lamd21 gdBL98vM02WmY/q9x103JOt0Iiyer3FOwC0VHUmLjwjv+yW8kjFUC43IruXB/+RFq2HWoE1hh +WfV+UgNKVtAP3mluVNqtUEWoAQpYz6PkMU9VgiuqWntDUdVBIOzIcwjvHrRjXK8IBL4meZMw z1vWPKL/+1rLG84oDsJa4jIDYwmb9e9mvl4UJxEIOM8fu2QxtAGaCKzKvKb8Uqw/aUMWdvGEE OYdnIg== X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766790199373861394?= X-GMAIL-MSGID: =?utf-8?q?1766790199373861394?= Since at least kernel 6.1, flush_dcache_page() is called with IRQs disabled, e.g. from aio_complete(). But the current implementation for flush_dcache_page() on NIOS2 unintentionally re-enables IRQs, which may lead to deadlocks. Fix it by using xa_lock_irqsave() and xa_unlock_irqrestore() for the flush_dcache_mmap_*lock() macros instead. Cc: Dinh Nguyen Signed-off-by: Helge Deller --- arch/nios2/include/asm/cacheflush.h | 4 ++++ arch/nios2/mm/cacheflush.c | 5 +++-- 2 files changed, 7 insertions(+), 2 deletions(-) -- 2.38.1 diff --git a/arch/nios2/include/asm/cacheflush.h b/arch/nios2/include/asm/cacheflush.h index d0b71dd71287..a37242662809 100644 --- a/arch/nios2/include/asm/cacheflush.h +++ b/arch/nios2/include/asm/cacheflush.h @@ -48,5 +48,9 @@ extern void invalidate_dcache_range(unsigned long start, unsigned long end); #define flush_dcache_mmap_lock(mapping) xa_lock_irq(&mapping->i_pages) #define flush_dcache_mmap_unlock(mapping) xa_unlock_irq(&mapping->i_pages) +#define flush_dcache_mmap_lock_irqsave(mapping, flags) \ + xa_lock_irqsave(&mapping->i_pages, flags) +#define flush_dcache_mmap_unlock_irqrestore(mapping, flags) \ + xa_unlock_irqrestore(&mapping->i_pages, flags) #endif /* _ASM_NIOS2_CACHEFLUSH_H */ diff --git a/arch/nios2/mm/cacheflush.c b/arch/nios2/mm/cacheflush.c index 6aa9257c3ede..35f3b599187f 100644 --- a/arch/nios2/mm/cacheflush.c +++ b/arch/nios2/mm/cacheflush.c @@ -75,11 +75,12 @@ static void flush_aliases(struct address_space *mapping, struct page *page) { struct mm_struct *mm = current->active_mm; struct vm_area_struct *mpnt; + unsigned long flags; pgoff_t pgoff; pgoff = page->index; - flush_dcache_mmap_lock(mapping); + flush_dcache_mmap_lock_irqsave(mapping, flags); vma_interval_tree_foreach(mpnt, &mapping->i_mmap, pgoff, pgoff) { unsigned long offset; @@ -92,7 +93,7 @@ static void flush_aliases(struct address_space *mapping, struct page *page) flush_cache_page(mpnt, mpnt->vm_start + offset, page_to_pfn(page)); } - flush_dcache_mmap_unlock(mapping); + flush_dcache_mmap_unlock_irqrestore(mapping, flags); } void flush_cache_all(void) From patchwork Wed May 24 15:26:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Helge Deller X-Patchwork-Id: 98555 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6358:3046:b0:115:7a1d:dabb with SMTP id p6csp2910113rwl; Wed, 24 May 2023 08:34:51 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4UJ994B+jd41dehfQCZuy27Bh2Waj3b+PkHBptFkrtbXzdM2IBqr1Vwhf/ShkYR5GGudjf X-Received: by 2002:a05:6a21:339d:b0:10b:4a5d:87e with SMTP id yy29-20020a056a21339d00b0010b4a5d087emr13000041pzb.53.1684942490980; Wed, 24 May 2023 08:34:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684942490; cv=none; d=google.com; s=arc-20160816; b=FUY8WhiUoUsSSz2RcO/w4onzENSBAqFKbW99fFOhqfGr8+1n6arxzpC0cqN9bBJU12 Mkhf7/uq435E4q8p8Uo+RNtPfXbBiWMP2h3YemnZ5Ttt1mMjCORqfEVzrYlI9SqcFETH +gNIRjZ0N3mjrt2zS2T1gshkR14vjgvdLM/5olfvjHg6sRNopcZTANut91BjIGI3ge6b lgNdyOpmLOKKwKOOw2J8aqyCTJ9y0QfZ0bcLfcKDHiwmgxGU+n/1kZzx40SRtFZ5fRhB 5N/U2PZxjjtLF7K+xMrskyKwR/l/+aibIS0dDe60gR8FEeDRCYhsTTrSFilEuIlcb+Ho 9G4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:ui-outboundreport:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pqhCABXI16XnCw8UxTLi0hAnYA7Z7fzMfO6p251N+1I=; b=jH36Gp6SNm2itfPExC8E+v6X6kBdkO2vkMAqW7f6baeeE6lWCV8WtqOnDZB4X3Gkuw BnsK04uDh40yG8OgsddKyYlA/OhJN9aUxvIk48Fjv8p3gBUY5bEdLpoUW3dWt596VoBM 1QaHM/yDFZNaHkcqWaEvj+0N0LvrzlzqQBBklh46y10xM849Bd9LVcX6RGGmXDD+TBvU /hO37ZMZ9cfsHm+8+vdN1/6jY7qPmV4o44UQtuxft5cyyEbGIgprmusUts2mhLjpiW7a j4HikvEg1Txlp4Y84F3exGcKuosmG5MNJ0zfFjOWNKTCFedpaL4Zpekwhld6rpgpBvpO 4+Zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=tgq8Qwky; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmx.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q3-20020a656a83000000b0053071414c3asi8539560pgu.562.2023.05.24.08.34.35; Wed, 24 May 2023 08:34:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=tgq8Qwky; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmx.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235582AbjEXP0v (ORCPT + 99 others); Wed, 24 May 2023 11:26:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234883AbjEXP0q (ORCPT ); Wed, 24 May 2023 11:26:46 -0400 Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12702122; Wed, 24 May 2023 08:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1684941999; i=deller@gmx.de; bh=+u+YPRciweWPPguaxEgTzruDX0igJ4dkk2Wtadt6QVA=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=tgq8QwkypsPRETeu+19MR6ZTBDZejuyxcvDSAhNK6C9kPDFZoR+sLoUmYrLp2v0qQ Oo+R6oMG/ZhVh9nYB0o6ro85A/Xo8KQNLZvQL4nEvq+lrObnYr5+lObF8oGxIPXJsO KrwsLQ8A6uxnCygqj5B8dz2XFfHHfzU7addqr6c0kFUZACz7xFiCyHB8Kxp/ERPjg7 SqxDyZ6Xly9UkoUTsoAvLoxekB4JFUzsjbgAnBk/dL2E7J1QkVNa2fDDVZsaYIUfSe oXNS3i2IQaAIyyKqYQIV/hFGfBwd4eBAbR6jiNv/07fDPECCeq2iD3Qk5ptDn1LqBK iBOsESCtXF0rg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from p100.fritz.box ([94.134.145.4]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N7R1J-1qCC9r3QFB-017m18; Wed, 24 May 2023 17:26:38 +0200 From: Helge Deller To: linux@armlinux.org.uk, dinguyen@kernel.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org Cc: Helge Deller Subject: [PATCH 3/3] parisc: Fix flush_dcache_page() for usage from irq context Date: Wed, 24 May 2023 17:26:33 +0200 Message-Id: <20230524152633.203927-4-deller@gmx.de> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230524152633.203927-1-deller@gmx.de> References: <20230524152633.203927-1-deller@gmx.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:1nlE0hasgl6gijxKoEdYfyHTI6vIMSOKaK+RqkKBabLx7UsK7Xo npxRasd38wBp+V4q8fJGGVe6hCTQhHravYda1JFL6bI2UYwo7iwgzUnZI624CMkgi1y9ue+ DMb4jU4oy7QsTpmV/pY1WrN/dhtRBMyXkX+fMTt93HK/7yj+1uyp8VTelCIFyk84EKJo4c8 wlcGYzf8BJ56dyHSvi44A== UI-OutboundReport: notjunk:1;M01:P0:E+j+R85yQko=;gNHlAFRU0+wZJTeqYwEDvCqffmo 2TQXCFebAzwn7rcTvYSRGbe7rcv2TP1t59xR9J2ZnolsYc8GYpPMZUrshiTcnz9zt6/hVSTXW y/9mX0vPvgIVYE4lN3GZkAbuQaIZo8Qas2zo9VWhsbApwseyT/CM9zuXBqaWUiKCwIVkAeCOL lkaSJazdaicSv6XhNQdQii8XiQYwZgDD9ns5STZtIhsia81lXB+B6EBNcIgV0TQroeBzsNQKI eVZgI/EcYFw0D4DBOlgbtQWY72Ih8c9g9OnINFZPl/8iUIm8HkrT/doQv7FIFuPP7VdSH7k5I 1Chk2mTF32RbdNqrd9B7nJsRhWJS+Ve1w9cm0K/JK6oGkXri9fEsra8N8Rb7Um1rAWjXamwDb XXrS1eoCMouD60VgjyGlyp+XO7bGHTKLUzA7vcWt6bNJttzIG9uF/LWrmGtn/StjKIhT6K41E l3Dv8I07vR1dcXDWf7XQEa/0WJ2XLDxf8uDeYL4FW2PhgD5LgXvU2p7kL+Eo+blOu99AeuLvx iIOU85Hm6+wV+XeK5pc4/HAZ+U0LMLTSFuufIiXSPKi8vk39PkdVcA7Z/pMwkfTu7FMXfU+mu 8qZ1EC++r4mCfgu57JLk91Kj6IS0+mIgwIlzyHZyNjHXFe4Xek5UtgyAtAMk0chC3I8bAWrll 3L3gAa4B+4288Msyps2+tKmvEie+whjbZgWWuGw5rB+bdlpltrH30NPTR/CIqjhqmkIXpOx73 s4Cfgfl0WPNKBT9tGJFhlwy12WDrlbYbOiMUx56IoZnDRu8GRlU6yPF/bZU+4Z2qpmy+YiKAw uf0VHIK2wgO6WM5qfVq109o/NhPBNGklqaPgWliDRfYKr7EkJ+9iRO77CX6A2tRnMC2oZheGS Km7EqyPsRg3GfDa+KuSY27joemHpvNIq02DsOprnqF3ZkH1LAkmwm3CCpHB7otzVkHGyYTiro URbiTZsabGRmQoQ30FXhqVpJ8mE= X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766790257486840825?= X-GMAIL-MSGID: =?utf-8?q?1766790257486840825?= Since at least kernel 6.1, flush_dcache_page() is called with IRQs disabled, e.g. from aio_complete(). But the current implementation for flush_dcache_page() on parisc unintentionally re-enables IRQs, which may lead to deadlocks. Fix it by using xa_lock_irqsave() and xa_unlock_irqrestore() for the flush_dcache_mmap_*lock() macros instead. Cc: linux-parisc@vger.kernel.org Signed-off-by: Helge Deller --- arch/parisc/include/asm/cacheflush.h | 4 ++++ arch/parisc/kernel/cache.c | 5 +++-- 2 files changed, 7 insertions(+), 2 deletions(-) -- 2.38.1 diff --git a/arch/parisc/include/asm/cacheflush.h b/arch/parisc/include/asm/cacheflush.h index 0bdee6724132..c8b6928cee1e 100644 --- a/arch/parisc/include/asm/cacheflush.h +++ b/arch/parisc/include/asm/cacheflush.h @@ -48,6 +48,10 @@ void flush_dcache_page(struct page *page); #define flush_dcache_mmap_lock(mapping) xa_lock_irq(&mapping->i_pages) #define flush_dcache_mmap_unlock(mapping) xa_unlock_irq(&mapping->i_pages) +#define flush_dcache_mmap_lock_irqsave(mapping, flags) \ + xa_lock_irqsave(&mapping->i_pages, flags) +#define flush_dcache_mmap_unlock_irqrestore(mapping, flags) \ + xa_unlock_irqrestore(&mapping->i_pages, flags) #define flush_icache_page(vma,page) do { \ flush_kernel_dcache_page_addr(page_address(page)); \ diff --git a/arch/parisc/kernel/cache.c b/arch/parisc/kernel/cache.c index 1d3b8bc8a623..ca4a302d4365 100644 --- a/arch/parisc/kernel/cache.c +++ b/arch/parisc/kernel/cache.c @@ -399,6 +399,7 @@ void flush_dcache_page(struct page *page) unsigned long offset; unsigned long addr, old_addr = 0; unsigned long count = 0; + unsigned long flags; pgoff_t pgoff; if (mapping && !mapping_mapped(mapping)) { @@ -420,7 +421,7 @@ void flush_dcache_page(struct page *page) * to flush one address here for them all to become coherent * on machines that support equivalent aliasing */ - flush_dcache_mmap_lock(mapping); + flush_dcache_mmap_lock_irqsave(mapping, flags); vma_interval_tree_foreach(mpnt, &mapping->i_mmap, pgoff, pgoff) { offset = (pgoff - mpnt->vm_pgoff) << PAGE_SHIFT; addr = mpnt->vm_start + offset; @@ -460,7 +461,7 @@ void flush_dcache_page(struct page *page) } WARN_ON(++count == 4096); } - flush_dcache_mmap_unlock(mapping); + flush_dcache_mmap_unlock_irqrestore(mapping, flags); } EXPORT_SYMBOL(flush_dcache_page);