From patchwork Tue May 23 15:40:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 98076 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2259540vqo; Tue, 23 May 2023 09:15:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6CiVHAH6onmklNWcp136sJJoB8kVWu1vA0V6Dc0ipiU/oN+C3H+7id017NXqI74Yn6p2ji X-Received: by 2002:a05:6a20:3c93:b0:100:809b:d6b6 with SMTP id b19-20020a056a203c9300b00100809bd6b6mr16986006pzj.26.1684858508147; Tue, 23 May 2023 09:15:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684858508; cv=none; d=google.com; s=arc-20160816; b=svV4nmaMnSH0cQP1u+STvjwsA+NZJ7EvO7T0OLkizRrkoYR5qjw/52j9c8PkLjyjv7 QaDB+Q/A9qqyJtjFfqZLPdbrCY35YfbaAzMpULJ1r83g692FGsCbqeKCiwWaell4Wvwr RpenN0jymkqnHxwyM6n3jW+KgjiDNxiYz3rpUmqd7NcY3K7MT8H71DZnWfgerLjCS0j/ 0kleJq86mIs7o5aBm8uGcXdRpZeHmaLHoWA/H1mrmbZaraLFeKf2fyL0oCbsDtVt+/dn fuySHapAAb+di2w46WM5knE74mz1GMDR4C6NRVkBzl1EsfWQ6j6psuqJzmtxdQaBf+xK 5vKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=FCX6QySVYWCQOF9493nlQvHi4d8l2/AYZfNxTvvVZH8=; b=05XzRkQESJ9HpOX7u9crjGgJ09HU+YlNHDMufjIy71vK++5yDvTjR+3mC8Zd3HSKFU wChuES3HYeq8xNA2wLIiaScidt8P1Sa/VmnKpDh+hlqIIy+OkCldnuIgpq8HcBvsLEku DiWU6ECxlsjtAzD4e6bGmy4PzsKz6KHWOl/mjTEDG3i+wkle07hVUmuNjKdIQUr23GB8 A0hKImWAaFNXP+C8yVpULO/cyds3ha4HG+tsDLT5jIPoKeiBwTxxtBhOGDgQj+lRWDD6 ZBOTGhirWHDQ0i33igjw9taLVXD0Tgxc7BWtZCvHvJE1acTB5h5JoA1SC/B5A3qn5Ozh zlCw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x24-20020a63db58000000b0053007fe33aesi4893957pgi.409.2023.05.23.09.14.54; Tue, 23 May 2023 09:15:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237423AbjEWPkw (ORCPT + 99 others); Tue, 23 May 2023 11:40:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237019AbjEWPkt (ORCPT ); Tue, 23 May 2023 11:40:49 -0400 Received: from laurent.telenet-ops.be (laurent.telenet-ops.be [IPv6:2a02:1800:110:4::f00:19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC0A8129 for ; Tue, 23 May 2023 08:40:47 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed30:b0ac:7afd:272:4cff]) by laurent.telenet-ops.be with bizsmtp id 0Fgi2A00U0Jkz7G01Fgi8n; Tue, 23 May 2023 17:40:46 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1q1U7g-002t5B-8n; Tue, 23 May 2023 17:40:42 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1q1U7u-00CkiL-KO; Tue, 23 May 2023 17:40:42 +0200 From: Geert Uytterhoeven To: Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6n?= =?utf-8?q?ig?= , Lee Jones , Daniel Thompson , Jingoo Han , Linus Walleij , Bartosz Golaszewski Cc: linux-pwm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH] backlight: pwm_bl: Remove unneeded checks for valid GPIOs Date: Tue, 23 May 2023 17:40:41 +0200 Message-Id: <00be8237e0e2bc9b179177b5490f175d657261a2.1684856337.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766702194664684781?= X-GMAIL-MSGID: =?utf-8?q?1766702194664684781?= All of gpiod_set_value_cansleep() and gpiod_direction_output() handle NULL GPIO pointers just fine, so there is no need to check for that in the caller. Signed-off-by: Geert Uytterhoeven --- drivers/video/backlight/pwm_bl.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c index fce412234d10399a..a51fbab96368053b 100644 --- a/drivers/video/backlight/pwm_bl.c +++ b/drivers/video/backlight/pwm_bl.c @@ -54,8 +54,7 @@ static void pwm_backlight_power_on(struct pwm_bl_data *pb) if (pb->post_pwm_on_delay) msleep(pb->post_pwm_on_delay); - if (pb->enable_gpio) - gpiod_set_value_cansleep(pb->enable_gpio, 1); + gpiod_set_value_cansleep(pb->enable_gpio, 1); pb->enabled = true; } @@ -65,8 +64,7 @@ static void pwm_backlight_power_off(struct pwm_bl_data *pb) if (!pb->enabled) return; - if (pb->enable_gpio) - gpiod_set_value_cansleep(pb->enable_gpio, 0); + gpiod_set_value_cansleep(pb->enable_gpio, 0); if (pb->pwm_off_delay) msleep(pb->pwm_off_delay); @@ -429,8 +427,7 @@ static int pwm_backlight_initial_power_state(const struct pwm_bl_data *pb) * Synchronize the enable_gpio with the observed state of the * hardware. */ - if (pb->enable_gpio) - gpiod_direction_output(pb->enable_gpio, active); + gpiod_direction_output(pb->enable_gpio, active); /* * Do not change pb->enabled here! pb->enabled essentially