From patchwork Tue May 23 15:46:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 98074 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2251093vqo; Tue, 23 May 2023 09:04:32 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5+MbBmNDrXoVnwW2SYS32Oy1/YcegcQ6E9tcvIQ/cFRigkGiXKWV/cJk1TW3kckg7FGnGU X-Received: by 2002:a17:90a:cb09:b0:250:78d0:f78c with SMTP id z9-20020a17090acb0900b0025078d0f78cmr16048300pjt.9.1684857871966; Tue, 23 May 2023 09:04:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684857871; cv=none; d=google.com; s=arc-20160816; b=oOnfhSaNnQJNUX7ohhvuz8Fgk3OouBxkAxIZbaXiNwfm+dlnLXD3YPClFrfdpAkcOH +1e0X3fpvhgDNQmjVOwSqAQ7KfhZL1lC75hzw4udz6e1kG4O/u1jRAineFPXAdcvfduH +JYcvykwdE2KwpxIXOqEstH2OMnRZ8GZbM7b8zNyzZdQo5csb+TAtkqvNLapLM/O00fx Y8xH04s1A52ZCGoAmNZ6HsLpMQxtcEWMdkklCgBNA3ufFG/P8uG/UI4CgUbiIxZYWeqs 4bDMRGDnp3XexWrw4pbd9hWTc9ks0lowDHlUo+RLrHFYPGX6Xyk1S2D8DfY1X+oaeoBb /Itg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=PfRw2ALokx9vLy8rQUgzg1qNBvtdQEE/4htl4GPyFIo=; b=REOqTWXaJmdITfxlc5HlCZNBhEELhkB+cpHeKFVcBtm9hpNjtbWm36bF2XRw1FyOy+ t3gIbIfHhBUZxN6yfv2/D3/hzq9LDfK1ZD1idqbmZ4XM8rkQizqqPmFMD2kyHFpWErZM tYZqZJIWQKJ2TqW20wwXUkDXoDXgfFKRgRGAGFjwE6yDSohC7zxEO9g0sdtzz1EghmXN 9oDFzhmqWESIaroC1ZE5/vUQUragW9pL5WYQ2y242aoBf6lrGdy9xBcz/1mONUC9sZ/w S2PwRhc2E1FfBPRMmN7SpJt9jl+rusbienu56sV6Pu1eS5rc0/w94mWQbgKIIMj4vSQe QyNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nWNoA6Sj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e4-20020a17090a4a0400b002537224e05esi8524003pjh.62.2023.05.23.09.04.16; Tue, 23 May 2023 09:04:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nWNoA6Sj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230207AbjEWPq3 (ORCPT + 99 others); Tue, 23 May 2023 11:46:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237029AbjEWPq2 (ORCPT ); Tue, 23 May 2023 11:46:28 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09A0F126 for ; Tue, 23 May 2023 08:46:25 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-3f6042d60b5so26592645e9.2 for ; Tue, 23 May 2023 08:46:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684856783; x=1687448783; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PfRw2ALokx9vLy8rQUgzg1qNBvtdQEE/4htl4GPyFIo=; b=nWNoA6Sjt7sar6bT5Wo7aS7Yc7m34FIb/IPgWD81u2XmfxqZy8KlLpQjOWv16/jon5 r9ollhVW6YH7NfbuUpGGiFI2PoQsBLoeInpaFEAFlbMtNr/hC+EMEAcNhtOpzJEyLd54 7C+AXOqYLclUAvF/sNsb2Bph/vJoPsj+7wFJnrV9n36DSEjRrJ5DivQ7lCMZJVhG2E+x osQRnx+JV6XS7XazzwU6kFsLuDGgV0o3IEblDcwD6iDseVAZKJZb3xcMuuydJ0O53+D/ 1kAnyuwPYstnRQs46f5u26CXhFu20A3z+IeYSdm+azQaZs3NGE6eO/K3Ila8h2n5Gpqw TGZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684856783; x=1687448783; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PfRw2ALokx9vLy8rQUgzg1qNBvtdQEE/4htl4GPyFIo=; b=D4XUvtloPLKjl2q/JBCf70HeDGaZ+DMeUAGMtyGBHnUeIwTilw2UXjqGGMp1SXjEpo v4L4W7+Ls4T0peGpUNutVGQUxPCV2nRtIhIuoFnpdlXuzVTAvs16q6eRmky2Jo/C2xeC keiwg3VheIH3z8Cs4HK4JtsRfOM+bFY1iExEB8RYj7560+1xAO0BOLn5a2MO9hkNqAVV mBBeQ6cjO20lQQLKSRlyPG22SaAjkA3BY/1TxBLJD5qs5UBlCCEyErml5sOd0xuZuc3Z JVVw5oMNqZE4jtagRoBY/oRQK7nXmtELumrSUDiQyaLwo3hyglc5RKDlgBwLCsh0ANTq sMrQ== X-Gm-Message-State: AC+VfDyh29ZCHj0oLyTbk8lFw35WizHBDaY8JJNlX0R9a6PKJQ9vsXI/ AcPVWl+jBCJ+HNTFn6uqKbVTgg== X-Received: by 2002:a1c:e905:0:b0:3f5:fbd0:94ab with SMTP id q5-20020a1ce905000000b003f5fbd094abmr7809138wmc.3.1684856783483; Tue, 23 May 2023 08:46:23 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id f4-20020a1c6a04000000b003f1978bbcd6sm3374063wmc.3.2023.05.23.08.46.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 08:46:22 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org Cc: perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com, ckeepax@opensource.cirrus.com, kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org, Srinivas Kandagatla Subject: [PATCH 1/2] ASoC: codecs: wsa883x: do not set can_multi_write flag Date: Tue, 23 May 2023 16:46:04 +0100 Message-Id: <20230523154605.4284-1-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-Spam-Status: No, score=1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766701527881404111?= X-GMAIL-MSGID: =?utf-8?q?1766701527881404111?= regmap-sdw does not support multi register writes, so there is no point in setting this flag. This also leads to incorrect programming of WSA codecs with regmap_multi_reg_write() call. This invalid configuration should have been rejected by regmap-sdw. Fixes: 43b8c7dc85a1 ("ASoC: codecs: add wsa883x amplifier support") Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/wsa883x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/wsa883x.c b/sound/soc/codecs/wsa883x.c index b83b5b0d4bab..2faf66c60703 100644 --- a/sound/soc/codecs/wsa883x.c +++ b/sound/soc/codecs/wsa883x.c @@ -946,7 +946,6 @@ static struct regmap_config wsa883x_regmap_config = { .writeable_reg = wsa883x_writeable_register, .reg_format_endian = REGMAP_ENDIAN_NATIVE, .val_format_endian = REGMAP_ENDIAN_NATIVE, - .can_multi_write = true, .use_single_read = true, }; From patchwork Tue May 23 15:46:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 98071 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2245829vqo; Tue, 23 May 2023 08:58:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5cLi6WfNoN/zhvLum4H6uga0Mn3fFqPZgSff8T2HmTdulijALT8CZcE/ymjCiej+xctOPt X-Received: by 2002:a05:6a20:1448:b0:10b:9dc1:c5db with SMTP id a8-20020a056a20144800b0010b9dc1c5dbmr8155932pzi.28.1684857492572; Tue, 23 May 2023 08:58:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684857492; cv=none; d=google.com; s=arc-20160816; b=inTWMN77pMrf2lO8SSCYH7uERmt5pG92PgprspWvX0iwdCrOZtBlGPnBHqHM7MTy0c NFjLSNl6fcfyX1NRff3bIwQjr+yA4TfD7QLvqj7qDuPVwNodPbuTG9psGk2+VajZrkcl H51cWYA8TNnovdtaerDYnkHquP1n2yAhCzE0SEn6QoyV+lZ4kcVRxrh1jSeYoy9m3dYc l57UCwADFEUiWV9CzmFssCWSFWFoWRO9gcdkEK/me+ZMges1VVzquU6+ne90SuArChnM LO0RArmtU6wfLhmCkQB6QFXDJBryHa1wGKWR9zatysT4/f/2Z/0AlOf81Hj2aaq0fBvk 0xvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HY78bpvovATO4WTiWWCs/PyinwWE+HdEDWAOWfiu7IY=; b=WTLN9cc1wzNoKgZNuXl9oJTmIqen9GiVdJs5YJOLYLkChKw+yklA7Tgd4Y5S0HCuYx mBJBhBAjnMPq6DHSuuUMaOA2jeGvyzK+OGouTROM8gNyTRMwC6vyHlfRsTfZNbUJbWl9 1Ka1Omz94kg/ShZXCqXlDB0WhxC5vtwOAJaYDU8el66I5OCXrPiAvEPxVGe5xLU4nJlZ pN6OGjn76zB2vXiOzMMvErGIGJU3keaR4HgtGZok2STUDw7k0YNiJ4hsrV97UJc62WiW h98Z0t2Gk5RPGCMtmkaRyC6p2GmAFG9q7zZ12qrQDIQDzQH5Ls7nE/axex+m73N+/zeE aThA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qzXoE7KK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s189-20020a6377c6000000b004fc257265cfsi6715536pgc.267.2023.05.23.08.57.57; Tue, 23 May 2023 08:58:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qzXoE7KK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237602AbjEWPqb (ORCPT + 99 others); Tue, 23 May 2023 11:46:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237109AbjEWPq2 (ORCPT ); Tue, 23 May 2023 11:46:28 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51134DD for ; Tue, 23 May 2023 08:46:26 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-3f601c57d8dso202475e9.0 for ; Tue, 23 May 2023 08:46:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684856785; x=1687448785; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HY78bpvovATO4WTiWWCs/PyinwWE+HdEDWAOWfiu7IY=; b=qzXoE7KKxl8W7e9Ja/36EZNThJM8rZx06KxNTz3pu/jWCjkNW83xPrSo87iAGb5eod tYOi1jkZbAiEFgKV594n50+88hyF1C9ftpmv8HxaiYgOAr0mRStKnWG+cwq6WqGzPBy+ OG0Fj1AxfEX3J2sgJB/WYBzgD3A3lm+Iauu5wrSl7fbwLIGt/Y8q202YcqU71xBs7rg8 exjOndDRf3smAaxgYEkP67pAQ2MP+1JSlYAj4IJkNJWH3Fms6lP5Ntt7CNXklyrsFbPz x70ZRlAc4zhIbWw7zEW6a+yRuEpQJ3pvYuXGBsuieV5suQ5IyViTHuX6eTk44TSxkqVG vE7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684856785; x=1687448785; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HY78bpvovATO4WTiWWCs/PyinwWE+HdEDWAOWfiu7IY=; b=froFlziAqHrnBfmhxZbVPsub1Qmuv7eTCRe2l8o+lui4qgWQe3+yJE6Qm/TCRcq/vJ NVe9sjA/h0XuKIizFi2vvc7FCLxL9nme5SWrrTURx0x4fRKwHzGqTa3GtBsN8sxcP6MQ vLYRPXMs8pY2Gppr2IrLwfO1oamqSHlCj1AP1On1zfxxwahlRQqFLzTkS/g8PdiXSjeg RMEaTZTtxmCJCa8M1TRBpAs8Ve5ZsfdGmrdp8xiqxL3NQMzyxb3Dr2mL45aESWfiL1B1 6Bmc+GpPCYdAjwngFyx3vCwJA6UGR+DWlltnvyqGP+ouFWiaG++ORXJPNdaGfUOi5mLM zq1w== X-Gm-Message-State: AC+VfDyr2eZabcMT+agtSNT8O2MPKKC9PDv0zlaxseqkWfg6HGo6vTqA bN0Qs/N7sOImwBjMxYZh4RtWdQ== X-Received: by 2002:a05:600c:3549:b0:3f5:a54:9f97 with SMTP id i9-20020a05600c354900b003f50a549f97mr11115515wmq.0.1684856784731; Tue, 23 May 2023 08:46:24 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id f4-20020a1c6a04000000b003f1978bbcd6sm3374063wmc.3.2023.05.23.08.46.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 08:46:23 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org Cc: perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com, ckeepax@opensource.cirrus.com, kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org, Srinivas Kandagatla Subject: [PATCH 2/2] ASoC: codecs: wsa881x: do not set can_multi_write flag Date: Tue, 23 May 2023 16:46:05 +0100 Message-Id: <20230523154605.4284-2-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20230523154605.4284-1-srinivas.kandagatla@linaro.org> References: <20230523154605.4284-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766701130158551355?= X-GMAIL-MSGID: =?utf-8?q?1766701130158551355?= regmap-sdw does not support multi register writes, so there is no point in setting this flag. This also leads to incorrect programming of WSA codecs with regmap_multi_reg_write() call. This invalid configuration should have been rejected by regmap-sdw. Fixes: a0aab9e1404a ("ASoC: codecs: add wsa881x amplifier support") Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/wsa881x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/wsa881x.c b/sound/soc/codecs/wsa881x.c index 4ce72a7f01b6..211b154bc514 100644 --- a/sound/soc/codecs/wsa881x.c +++ b/sound/soc/codecs/wsa881x.c @@ -645,7 +645,6 @@ static struct regmap_config wsa881x_regmap_config = { .readable_reg = wsa881x_readable_register, .reg_format_endian = REGMAP_ENDIAN_NATIVE, .val_format_endian = REGMAP_ENDIAN_NATIVE, - .can_multi_write = true, }; enum {