From patchwork Tue May 23 11:49:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 97966 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2083904vqo; Tue, 23 May 2023 05:03:59 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4nMxwEBWiXC9R/bjaPUlvpgmxHYHkQmiuLVRaDkhGb3DrGDvF3mpqIo9I528b2Jmvf2Djd X-Received: by 2002:a17:902:e746:b0:1af:bbfd:1c07 with SMTP id p6-20020a170902e74600b001afbbfd1c07mr5146249plf.57.1684843438838; Tue, 23 May 2023 05:03:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684843438; cv=none; d=google.com; s=arc-20160816; b=P6WakD+z9shs3yaNixj6uYFQvSSj0Sfkv3XhIL65VzsjN38lKCVM4eY9m6KnALZmFy 9vHsG4ntebvdhAPgmOoTnkxQu2ZlEx9YCZp3sLHPIacxze9Jrm1CJOkvUJirpqdsAqiu HeBlfF6dpUvrpu0gvJiVt8IQzEtxTGGOFqZ+dbHmjxXriDNLOuIDsJKhE4AnTsXLZVox HbCiIYTYHz085LQfbmUExs8Q2yBchy1/QuQhLBgh6Wx8cmETxpDI4Q7niWgM9CWvCZw/ ksQpdpMtT2ftYd21GunA1Mq5f5u3mFJIVb1+SZ81ukUmqkxyfaAWn7dUo8sIrJT0bIa5 7p3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ehkOIFzpHbRExxwyu097KqZWDTX7tEk3jO5IBFhFU3Y=; b=Wm3ykhw6SUHeKKdEhdxAXK4Tblu1aTxbOTSFgcHXohdCbRP4aMwSnz/cYLgRy7yI1y W/WQ/6ooNX2708dfYwsHKScUGemo+H8OoOWAh+zXKqliBrN/NlvIEGfj4HQ8p6/JG4EX K0Rjy7EwCKwC+Fh0rHccbJ+eoxnO5KCSxRQ2HOTRpeLfOUZNjBPzx3yOVWYvZ+z/iusZ bMOAm6ZcEdHyznTLc2JEhpjkI7RsdO3DiR7gI4Ro6AQBLv7DU9uDWj++evZVQHfXj7ty urgzbUb3R2QTGMxw5QkawRVAwxOshH2bQIrMvXO2MypqIy6GM+cXlnB7mtWQ7HTn8gBr tbZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WHikG8kY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l16-20020a170903245000b001aaec5cffb2si3140690pls.280.2023.05.23.05.03.32; Tue, 23 May 2023 05:03:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WHikG8kY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236265AbjEWLua (ORCPT + 99 others); Tue, 23 May 2023 07:50:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231846AbjEWLu3 (ORCPT ); Tue, 23 May 2023 07:50:29 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 917B9FE for ; Tue, 23 May 2023 04:49:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684842582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ehkOIFzpHbRExxwyu097KqZWDTX7tEk3jO5IBFhFU3Y=; b=WHikG8kY2UHRbexUkCLzwsIbOrBPhvhWqBF51aoHUdr23LDsMdOWOkwAg1nTJ5kLJsPsZQ JIjCmmU+yj0veLfba3MHSboOE1sblBcIyjeG6A2eKIZ/G0gUHS7IKq8Faa14KSvuXGixGn lh12PcJ+IO4Z+ryzHTQpWoPb8MSHi5E= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-381-krHN9inzMt-5EVUX6eODAQ-1; Tue, 23 May 2023 07:49:41 -0400 X-MC-Unique: krHN9inzMt-5EVUX6eODAQ-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-75af7f030a8so254341385a.3 for ; Tue, 23 May 2023 04:49:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684842581; x=1687434581; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ehkOIFzpHbRExxwyu097KqZWDTX7tEk3jO5IBFhFU3Y=; b=eF+uncxzkCgBXZaqXXwzDLLwH3AAkFZh6v1OpdASNd5Mcuxu//od6S5TYABiYKdZlf dKa5+/lWBE2IEojhzEc5SZ/CfmZ91kkH8zOh4fld+HeNPcnXpepqAVz+rkfexgxXElRs iMNYAl9Z8We7JdL6XgZvfoJthVLYzUOh+NhfNW4Kn5ee4x8PB2RuziKmn06jBicr6Org n3iOMnIdptgrXoTRSsDTQ1ROM2JVf4HzjZbA3f9UA0vlHPyZxG8SLx/FGG4zcP74MFFU 9BbWl/HwhBJclkILFc4wImainZ8QYe9p/g6exE/E264XghOwaJEv9t3JeH+GPaVothda mD7g== X-Gm-Message-State: AC+VfDw31pI8bGKfbHWkTIbpmbgoQ0v/gm4dkMsqRk5/Fo0hjlJisR+S zfeJLLsioStwa7nnr6QuWwnaTbl5vYnTtveWszRhbxZ0IQo/tK/INfq5Vj7qmE6M/736uehLqSz aFh5XyOQ63LU3aciBqhFDa7ii X-Received: by 2002:a05:620a:4729:b0:75b:23a1:8e61 with SMTP id bs41-20020a05620a472900b0075b23a18e61mr4404062qkb.50.1684842581142; Tue, 23 May 2023 04:49:41 -0700 (PDT) X-Received: by 2002:a05:620a:4729:b0:75b:23a1:8e61 with SMTP id bs41-20020a05620a472900b0075b23a18e61mr4404055qkb.50.1684842580930; Tue, 23 May 2023 04:49:40 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id j9-20020a37c249000000b0074e0e6aae1csm2451529qkm.36.2023.05.23.04.49.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 04:49:40 -0700 (PDT) From: Tom Rix To: harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, qingqing.zhuo@amd.com, wenjing.liu@amd.com, aurabindo.pillai@amd.com, Samson.Tam@amd.com, gpiccoli@igalia.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] drm/amd/display: remove unused variables res_create_maximus_funcs and debug_defaults_diags Date: Tue, 23 May 2023 07:49:37 -0400 Message-Id: <20230523114937.1080767-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766686393778227654?= X-GMAIL-MSGID: =?utf-8?q?1766686393778227654?= gcc with W=1 reports drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:1069:43: error: ‘res_create_maximus_funcs’ defined but not used [-Werror=unused-const-variable=] 1069 | static const struct resource_create_funcs res_create_maximus_funcs = { | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:727:38: error: ‘debug_defaults_diags’ defined but not used [-Werror=unused-const-variable=] 727 | static const struct dc_debug_options debug_defaults_diags = { | ^~~~~~~~~~~~~~~~~~~~ These variables are not used so remove them. Signed-off-by: Tom Rix --- .../drm/amd/display/dc/dcn20/dcn20_resource.c | 23 ------------------- 1 file changed, 23 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c index 7dcae3183e07..6ef7e2634991 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c +++ b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c @@ -724,22 +724,6 @@ static const struct dc_debug_options debug_defaults_drv = { .underflow_assert_delay_us = 0xFFFFFFFF, }; -static const struct dc_debug_options debug_defaults_diags = { - .disable_dmcu = false, - .force_abm_enable = false, - .timing_trace = true, - .clock_trace = true, - .disable_dpp_power_gate = true, - .disable_hubp_power_gate = true, - .disable_clock_gate = true, - .disable_pplib_clock_request = true, - .disable_pplib_wm_range = true, - .disable_stutter = true, - .scl_reset_length10 = true, - .underflow_assert_delay_us = 0xFFFFFFFF, - .enable_tri_buf = true, -}; - void dcn20_dpp_destroy(struct dpp **dpp) { kfree(TO_DCN20_DPP(*dpp)); @@ -1066,13 +1050,6 @@ static const struct resource_create_funcs res_create_funcs = { .create_hwseq = dcn20_hwseq_create, }; -static const struct resource_create_funcs res_create_maximus_funcs = { - .read_dce_straps = NULL, - .create_audio = NULL, - .create_stream_encoder = NULL, - .create_hwseq = dcn20_hwseq_create, -}; - static void dcn20_pp_smu_destroy(struct pp_smu_funcs **pp_smu); void dcn20_clock_source_destroy(struct clock_source **clk_src)