From patchwork Tue May 23 09:34:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 97934 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2008821vqo; Tue, 23 May 2023 02:35:05 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ54Ai/6KT9anCtMphBhhAvWKq+bzqU487h0RXwR9b9ykNDVcLnNnAU6DHvoTVldfD4hLB0v X-Received: by 2002:a17:907:2d90:b0:96f:a935:8998 with SMTP id gt16-20020a1709072d9000b0096fa9358998mr10531825ejc.39.1684834505254; Tue, 23 May 2023 02:35:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684834505; cv=none; d=google.com; s=arc-20160816; b=Ydaa1UBnsKvzM/Lqt+M4R7QMX/I1te5DAn0kb0fczBf2yYL5Xkee0smLAMhhJeIvxo rDy3/LGn8d7tzjfxbuVOBH73IiPSt+6NPQ8nYlsPo1mdWXd0839PhCcvEkJYW8TlyFAE ueCbr3nF6nkBG447EkmI3rgJ0p9pd4NofUrppAE88QlTwmvw/OLmBa95NiIqTZYx3Fym 7V2OyGQdtRj5w157xSO0xhXnUhjl8VUOMLESuNEqwQ+Y3CJEgfMYGcJ2Py32rrrTMeZh PB5DkJxNfqxbkvZgcSLMZmYhJ8Md56x6vuOWF5fgYlVOS8pM5b/YWykRolkJaCrkwv++ nAIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=Xf4IfsDi7VF9xehY7QEBB5fls9gnbkDw0G5GsC+jNoU=; b=EY9UThloBMfSPp0njOVSlqbrDhBwF687QVm4QyJdzdh/rY4ifqQKD7IXqV3TwZwGpy RXOrWSLziZ1M+GDWPeNc9IXpZG5ZFuQW3T75iMfzRPspCT28RN7hw89bijt8sCf1BlV7 qPkX4uadQNbkZwdJYcp2kBI7kpQAZKWO/bhPi6AqIyj2zn7NDm6HoHZ8R7vUHIDT2txF pWlJ2f6pOo7L3uOzUj45nEgKgkQZzz4koq6ODl+ir/OFyqJ2XrfghK/cB95DEXd0n6CE duVyz1Mer+gggTwNq1o7PPFGSp08v0GmhZinac3oTX37kopF0oxhUx+qCjk8C5NWnW3g yV5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=EIoXcpU9; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id f12-20020a170906138c00b0096f6945e712si1532503ejc.1011.2023.05.23.02.35.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 02:35:05 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=EIoXcpU9; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5C913385771E for ; Tue, 23 May 2023 09:35:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5C913385771E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1684834503; bh=Xf4IfsDi7VF9xehY7QEBB5fls9gnbkDw0G5GsC+jNoU=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=EIoXcpU9xlPMdKbNCpUs9qRw+vvCweh3segcfoo7ge4nmmzANg2N8/9o+7I1L1KsL nWJm6FC0DTXXX6vhDf3JYGBOGzL6lNdiigVdP/ASYyD4EXxWET/aI4QAG1dljpHJ57 nsBD9Iw/rfARMOGNYBSoAY8xWwAKUXb1dkx70jV8= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by sourceware.org (Postfix) with ESMTPS id 08EF23858C5E for ; Tue, 23 May 2023 09:34:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 08EF23858C5E Received: by mail-oi1-x229.google.com with SMTP id 5614622812f47-38c35975545so5043749b6e.1 for ; Tue, 23 May 2023 02:34:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684834457; x=1687426457; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Xf4IfsDi7VF9xehY7QEBB5fls9gnbkDw0G5GsC+jNoU=; b=W4dbgKu8OsgeajVvw4Ig++mcPMY3NI7mop4XsztJXEMgunsp0O/JaR4GvI/c/DVEw/ 5mzjy5WCt3GLTlObPMSZCK2G1HzYFUKlTwu3uA86ym7Mqfw0tkqIXLerxVjJWfbGFaZI ksec2PUt8ITT/5m5JRh4Vs+Isf5IqR0NgQ1tEjX2RRU1sQzEeiBA3IuHQe6TJnsbZcLj 99TfO6Su4XH9pdf1HFRdhegRkRCsM0UHI78MGAPF8vyGNvNh4KUdO2WbslvgOipVpCZ2 xJSrkXsTGJvjf9j9ipL+G5poGIOc1HOO9HtHtlkf1auG5GAZNwoKM7ZZ0oCNLqzYQvc3 +g2A== X-Gm-Message-State: AC+VfDyRlkJiujyl1qbuE18aBYF/gZpv+1JJFEy67+BSVdhhEe7iwr8y HE7Un7P81TDcMl6LOcT8GQ1lOA5WnqqYjY4cn+L/iA== X-Received: by 2002:a05:6808:8e8:b0:396:cd:829c with SMTP id d8-20020a05680808e800b0039600cd829cmr6700343oic.3.1684834456938; Tue, 23 May 2023 02:34:16 -0700 (PDT) Received: from localhost.localdomain ([139.178.84.207]) by smtp.gmail.com with ESMTPSA id r184-20020acaf3c1000000b003982a8a1e3fsm934340oih.51.2023.05.23.02.34.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 02:34:16 -0700 (PDT) To: gcc-patches@gcc.gnu.org, dmalcolm@redhat.com Cc: Christophe Lyon Subject: [PATCH] testsuite, analyzer: Fix testcases with fclose Date: Tue, 23 May 2023 09:34:07 +0000 Message-Id: <20230523093407.3501163-1-christophe.lyon@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christophe Lyon via Gcc-patches From: Christophe Lyon Reply-To: Christophe Lyon Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766677026370526547?= X-GMAIL-MSGID: =?utf-8?q?1766677026370526547?= The gcc.dg/analyzer/data-model-4.c and gcc.dg/analyzer/torture/conftest-1.c fail with recent glibc headers and succeed with older headers. The new error message is: warning: use of possibly-NULL 'f' where non-null expected [CWE-690] [-Wanalyzer-possible-null-argument] Like similar previous fixes in this area, this patch updates the testcase so that this warning isn't reported. 2023-05-23 Christophe Lyon gcc/testsuite/ * gcc.dg/analyzer/data-model-4.c: Exit if fopen returns NULL. * gcc.dg/analyzer/torture/conftest-1.c: Likewise. --- gcc/testsuite/gcc.dg/analyzer/data-model-4.c | 2 ++ gcc/testsuite/gcc.dg/analyzer/torture/conftest-1.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/gcc/testsuite/gcc.dg/analyzer/data-model-4.c b/gcc/testsuite/gcc.dg/analyzer/data-model-4.c index 33f90871dfb..d41868d6dbc 100644 --- a/gcc/testsuite/gcc.dg/analyzer/data-model-4.c +++ b/gcc/testsuite/gcc.dg/analyzer/data-model-4.c @@ -8,6 +8,8 @@ int main () { FILE *f = fopen ("conftest.out", "w"); + if (f == NULL) + return 1; return ferror (f) || fclose (f) != 0; ; diff --git a/gcc/testsuite/gcc.dg/analyzer/torture/conftest-1.c b/gcc/testsuite/gcc.dg/analyzer/torture/conftest-1.c index 0cf85f0ebe1..9631bcf73e0 100644 --- a/gcc/testsuite/gcc.dg/analyzer/torture/conftest-1.c +++ b/gcc/testsuite/gcc.dg/analyzer/torture/conftest-1.c @@ -3,6 +3,8 @@ int main () { FILE *f = fopen ("conftest.out", "w"); + if (f == NULL) + return 1; return ferror (f) || fclose (f) != 0; ;