From patchwork Mon May 22 19:50:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 97578 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1692654vqo; Mon, 22 May 2023 13:13:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4+gL4nwgYGuv1FDPsIPTHWtyGXVXx6ErjKpTlKz3VfEgYSu78YhD7RkKWI7wixOv0Ra5KD X-Received: by 2002:a17:903:124a:b0:1ad:e198:c4f2 with SMTP id u10-20020a170903124a00b001ade198c4f2mr14586028plh.18.1684786394046; Mon, 22 May 2023 13:13:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684786394; cv=none; d=google.com; s=arc-20160816; b=X22+fof5Zt78ObQ8pPUdZPIvuEa3yjydiGoL+y9DODVv/vasHi4CwD9i/PBbzRsdSF tKCMf2IHBgaIXIEzTI+zRYw8YCZzPpVwFzx+jPqyPvf0IB8/R5MPZlNWydjjW2RRzrX3 zeYnr6yA4VXw9rkZneogc9O6qkGMo5+G96BWl4EfGq/+OXRiyseetZRh3H12FPhf+BtU KA3bDCmwwwS7/bd8qI08yYfox8S1CLTNW/SNTix/Guf3pKPXRXXexOIGE5X7qGNmOrfs /ROm83smaiVQrU5N9Uw+oSIo1nErix9LXNET9n2+UTbPAjj6i9x+jSdd22C1rGCobwVQ CKWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4TV2blp8SU24hPHKp9o7KoTwdyRJXfAYgkCs+yiDCko=; b=QuoN78J8XETfNhHtmsWqBlJMlBvu/13c+lOXQeirQfH2xG1n3pAaRulbh0/RP1CoD4 c8zMx8YjSMvEmC6rCdXSYhMVdgJ0JOYgz1Lp4Vr0vn5nxKpWxW+njOHrucSPMUJW/4pi IG1sd08SrPUubHd8ZtPAVh44gHQ5FRaCZ5zk38iKp8FYPbwBxVuFP1tW0yN65s/D85dq b205yf+LV7f7V1Qrds2EQwU/4XCm32pOeH33ePIYw5RUY1s445qdSw/sXqx40+eaExkZ cukR1NCNbtxPSq7zr0qW5PAm2HA1N2/wOp4MfPWrel45dgLA2Z1H87cu2MvMcVyulLMT IpTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=crnD9m0k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jf10-20020a170903268a00b001a92a507187si527392plb.80.2023.05.22.13.12.59; Mon, 22 May 2023 13:13:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=crnD9m0k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235410AbjEVTuo (ORCPT + 99 others); Mon, 22 May 2023 15:50:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235402AbjEVTuj (ORCPT ); Mon, 22 May 2023 15:50:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F93BCF for ; Mon, 22 May 2023 12:50:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0066962AF3 for ; Mon, 22 May 2023 19:50:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D58A8C433EF; Mon, 22 May 2023 19:50:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684785035; bh=n3hkm02LXOePQNQAyKjmIwhyEzCueusGC98dUMzLcs0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=crnD9m0k8IK17T1hRcrALDIZrL2EZaxdKR6l3kSP9Sc6qK6RjlP+rnDSjK8su+7gY qLQ39mynAkbAdU554KNuGFPS4gpTofqUIUje1UTpXRXzfZSh0/i38G9ukA6du0PVv4 XtxmOpbdisIh/b5flVzP0OGOIbuUFMG9w8U+Hcpe+ZPymTX2XqqS6KcHVEnbEa8Lua 3Wlcd335L0P/WFlSdcuCjRAu2LVLKD4xC8qZ6W0tz/+sprXb865bayP075BDmJmZaA FUWK+9471aAPy7W3pj5VAtG0aoZrIZwG3QsH4LoJaVfiqdRTB6B6BUijwqEx+qvL8n ub8rfSp9miAwA== From: Arnd Bergmann To: Ingo Molnar , Peter Zijlstra Cc: Arnd Bergmann , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , linux-kernel@vger.kernel.org Subject: [PATCH 1/5] sched: hide unused sched_update_scaling() Date: Mon, 22 May 2023 21:50:17 +0200 Message-Id: <20230522195021.3456768-2-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230522195021.3456768-1-arnd@kernel.org> References: <20230522195021.3456768-1-arnd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766626577713077442?= X-GMAIL-MSGID: =?utf-8?q?1766626577713077442?= From: Arnd Bergmann This function is only used when CONFIG_SMP is enabled, without that there is no caller and no prototype: kernel/sched/fair.c:688:5: error: no previous prototype for 'sched_update_scaling' [-Werror=missing-prototypes Hide the definition in the same #ifdef check as the declaration. Fixes: 8a99b6833c88 ("sched: Move SCHED_DEBUG sysctl to debugfs") Signed-off-by: Arnd Bergmann Reviewed-by: Mukesh Ojha --- kernel/sched/fair.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 48b6f0ca13ac..2c1b345c3b8d 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -684,7 +684,7 @@ struct sched_entity *__pick_last_entity(struct cfs_rq *cfs_rq) /************************************************************** * Scheduling class statistics methods: */ - +#ifdef CONFIG_SMP int sched_update_scaling(void) { unsigned int factor = get_update_sysctl_factor(); @@ -702,6 +702,7 @@ int sched_update_scaling(void) return 0; } #endif +#endif /* * delta /= w From patchwork Mon May 22 19:50:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 97585 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1694591vqo; Mon, 22 May 2023 13:16:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7fW6uAHT4EojXYiZzIJyVVb1Gb892Vp8OlN6GXWIOJ6dO/XVajI6QVSnuBH62GuU35Y0ne X-Received: by 2002:a05:6a20:3ca7:b0:101:47d8:ff80 with SMTP id b39-20020a056a203ca700b0010147d8ff80mr13667252pzj.41.1684786603245; Mon, 22 May 2023 13:16:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684786603; cv=none; d=google.com; s=arc-20160816; b=UN2OE+1uRyXWXtGoQXIX3Szxur6iwIPGM6+PxcS6Io0zdsljMCuNZKtDhyRT+/4onA nRVXBJo19ZZP6m8hSWiRSCljDytUx1w0Yhqg/0DeKswwi7pjUC1DXsAmDXoEVaIM3Xgj ZQOLZFIknNUwaExkp8EJOJxa5NnGFzN7uS5JXDPD7EhfAjcUOvot913CbDjZXw+Oidnf RJ9zZAIlfyK0jO01RmRnkW2bf12QVnkf3P953FC/q0+5IPEvfWxZXpWOjP1nClsjGnB+ 2BjS9j/OijPCzaLKKGLHUHjNb4DuuWnXLEmtHf3OEwMbsemCX+mcrROSTePCIo6nHYfR N3nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=XgFtbm7TMd6ilpOpBS3tazIEh11eUZvWj9tfGhpYSbE=; b=kgSBd59hzYcWxyy30Tp2WlT/+WEw62udG6hZxbmnXgoAEw5N6u1+0k/bUYvB17UxBS uIoGpDCG+rflxl5tcogWTDunl4bc5CLtfrpYDns1QRwaGNzFrNoBTzHxttxK88I4bmH7 3CU3b29PO7MK0DC0Z8FjOG5Oz0PDrOw0jRrvHywXvzOfXZYB0eIRixHiEkkCgjV57/Z8 IHeM6/l0EfSo+kRekaa/4A5jZ25ZUjvq60HisCMMczHp7cYekVpOej/sWlDldyf57eiQ yP2GcBxLgEb0ymzSRtkfPG2f3em7k/evJEsgh5Lt0tJEdcB1/DIiSLUB+hevkcAV9kkZ XwKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=H0g6emV7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m14-20020a638c0e000000b005349008e6basi5108206pgd.439.2023.05.22.13.16.23; Mon, 22 May 2023 13:16:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=H0g6emV7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235401AbjEVTur (ORCPT + 99 others); Mon, 22 May 2023 15:50:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235430AbjEVTun (ORCPT ); Mon, 22 May 2023 15:50:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87F18C1 for ; Mon, 22 May 2023 12:50:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0705762AF9 for ; Mon, 22 May 2023 19:50:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7C3AC4339E; Mon, 22 May 2023 19:50:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684785038; bh=xhwlEoX8rvC3pCtoLzeLS25zj8ad4FOpCspq2DY7aWI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H0g6emV7k8lIQO10fs31Pa3A6GG17bxFC7XyWvUpir4bw6I6i/d70RJ1Pkgwtk/T1 FbVMh9yvJ+ZnGTW0TwlGJr9rQes/RycjA8oq0E0NWL4GA1/rZ07QrLEgRCxpjlu5Ks +WLT2bZyHOmq2V466tVtudS5Czsf52q69hisuTaKSM6JWjhkqJMwXhiphxC1cxGmXx Wk2CEcBTsekqSWbUArAq7H6oZT3HazUU+6R7ayMt3zhQHy3zVJvMyd0XAbeBqdDqA1 32UZAzdt4Xpq4PoGvivUzuU6rjwb1Gp9YblXAGUM/1gzKCNosw9js5KqhyX6WaZCYk 4f7qhEqUJPocw== From: Arnd Bergmann To: Ingo Molnar , Peter Zijlstra Cc: Arnd Bergmann , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , linux-kernel@vger.kernel.org Subject: [PATCH 2/5] sched: add schedule_user() declaration Date: Mon, 22 May 2023 21:50:18 +0200 Message-Id: <20230522195021.3456768-3-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230522195021.3456768-1-arnd@kernel.org> References: <20230522195021.3456768-1-arnd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766626797499143587?= X-GMAIL-MSGID: =?utf-8?q?1766626797499143587?= From: Arnd Bergmann The schedule_user() function is used on powerpc and sparc architectures, but only ever called from assembler, so it has no prototype, causing a harmless W=1 warning: kernel/sched/core.c:6730:35: error: no previous prototype for 'schedule_user' [-Werror=missing-prototypes] Add a prototype in sched/sched.h to shut up the warning. Signed-off-by: Arnd Bergmann --- kernel/sched/sched.h | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 1704763897d0..44b34836bb60 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -2376,6 +2376,7 @@ static inline struct cpuidle_state *idle_get_state(struct rq *rq) #endif extern void schedule_idle(void); +asmlinkage void schedule_user(void); extern void sysrq_sched_debug_show(void); extern void sched_init_granularity(void); From patchwork Mon May 22 19:50:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 97586 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1694659vqo; Mon, 22 May 2023 13:16:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6qb+EdoXrR4NEZgkfZ/Yhf9P5v3ChuN9JqVeyECzNDllMGwyOjaXLa4cZ8UnUHQk+nJCn2 X-Received: by 2002:a05:6a20:8f1e:b0:10a:e8b1:34bb with SMTP id b30-20020a056a208f1e00b0010ae8b134bbmr7717397pzk.56.1684786610226; Mon, 22 May 2023 13:16:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684786610; cv=none; d=google.com; s=arc-20160816; b=dXfV+xGWdze1lFjT+pH1csxR7x5c7Km3J0zHUsGt94eWv88aOb8fHCpOicva4t2Orf LAUGhC9M7xlneD0dWqcGmpSv0FmoOnLqipP/fKFlO+TWqDALvGe7r9UdPzgyZc9Hx0rx TdJByKZBUtTXIICE1s237PmoFdtgBhwYO9lYXFh2U35UqTDnJJ1dfdyC0cnTlpZImyFr expb2o30VZPTSMcypO+sXf0TLprlRkRa1pP3+96JSTiLXNtAsMfSsBithnOoVpwBLmTj qsYMa6NoDRxHYJVOx+TqcrPUaX0ltq1OzORikfuY1rofy9Xf4J5AQFmepIuoCXFnPYsp BrOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dDpYhysHGQNaBObSHi9x6ZTvlS1fc+j5yI8iYZ/uPw8=; b=0sI3E92eQcIEqNkMSPLJGi0fd/YnlRMAof+lGv4EigEe3VSD76fLSTbg6pYl4iMUeS 136obzekygilj7K6x52c/h1bT6/EQ9QSXA6PP3oYNJJ/dWXkhG6TaVPmFTW6d4vM2B9d tRmeO/kDJeDU9WGMKgWYBqdKIT5jKCFyOuvSOCQmpbfHdNcvRyOdBKuIwGiB2IQQy3Np XaR/HwYQzFhJDW6YAulVsiJIVOdjOPYFq0+LjemjjyRDs05wTRD7mwthdV2ZOgx3EY65 7qO3oLBH7JjpRmvbozUIlf3SbIjoulD0Rrmpl+uNq6kxBPlChRauw1r+D51Fx1L210yJ sQuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PYEj2zOl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q14-20020a63750e000000b0053eee173732si213734pgc.161.2023.05.22.13.16.34; Mon, 22 May 2023 13:16:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PYEj2zOl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235457AbjEVTuv (ORCPT + 99 others); Mon, 22 May 2023 15:50:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235422AbjEVTup (ORCPT ); Mon, 22 May 2023 15:50:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97D44184 for ; Mon, 22 May 2023 12:50:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 162C062B04 for ; Mon, 22 May 2023 19:50:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0258C433EF; Mon, 22 May 2023 19:50:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684785041; bh=DfCIKMSnSbVddp/C9i9OSpp88I+LZk39yiHKdmQAty0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PYEj2zOl4sr+IPXQ2IhzxhmUaEl68mRHT68KXDtpvG03OJsbvAgC5n6lsQ2UKyVqb YtWkwMdy73DW6kHmOJ2ZF+BajlBadfaHhEUz0kqYkOx9aPM0kgGM8xEps1mWqJCOwe 8bvQFdtDtsar4Yuqhr1mnhAidLPWxM85+HVmq7bMCmCGK5ohb4rbZ5igCRn1TITVgJ C8EGEv+tf3AsEX3fI+eQ3XaBeMjCqMb1JXpDK+PwcX60ZJzwUTjD7YBldQWaS03jF2 L6p74B5L3bAfBP/VrDwvQzxCHY9U9rifoc1zjWri3YqPBRTYAQo7sCDFw5GATkfLpv QhmQ9g+2h/Glw== From: Arnd Bergmann To: Ingo Molnar , Peter Zijlstra Cc: Arnd Bergmann , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , linux-kernel@vger.kernel.org Subject: [PATCH 3/5] sched: fair: hide unused init_cfs_bandwidth() stub Date: Mon, 22 May 2023 21:50:19 +0200 Message-Id: <20230522195021.3456768-4-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230522195021.3456768-1-arnd@kernel.org> References: <20230522195021.3456768-1-arnd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766626804745232214?= X-GMAIL-MSGID: =?utf-8?q?1766626804745232214?= From: Arnd Bergmann init_cfs_bandwidth() is only used when CONFIG_FAIR_GROUP_SCHED is enabled, and without this causes a W=1 warning for the missing prototype: kernel/sched/fair.c:6131:6: error: no previous prototype for 'init_cfs_bandwidth' The normal implementation is only defined for CONFIG_CFS_BANDWIDTH, so the stub exists when CFS_BANDWIDTH is disabled but FAIR_GROUP_SCHED is enabled. Signed-off-by: Arnd Bergmann Reviewed-by: Mukesh Ojha --- kernel/sched/fair.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 2c1b345c3b8d..a7a8ccde3bd7 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -6169,9 +6169,8 @@ static inline int throttled_lb_pair(struct task_group *tg, return 0; } -void init_cfs_bandwidth(struct cfs_bandwidth *cfs_b) {} - #ifdef CONFIG_FAIR_GROUP_SCHED +void init_cfs_bandwidth(struct cfs_bandwidth *cfs_b) {} static void init_cfs_rq_runtime(struct cfs_rq *cfs_rq) {} #endif From patchwork Mon May 22 19:50:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 97583 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1694003vqo; Mon, 22 May 2023 13:15:42 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4DNl1Do17O5ewFy54Xo1Z3rDXhwjYtabgtwQdTOZxxwLYNdmhiiHPCmNIt0rY6g1JIEnw/ X-Received: by 2002:a17:903:18b:b0:1ad:d995:54a with SMTP id z11-20020a170903018b00b001add995054amr13044675plg.46.1684786542323; Mon, 22 May 2023 13:15:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684786542; cv=none; d=google.com; s=arc-20160816; b=usUk3HRQ7mtqxixUt85POLQ+8rweJWaTCH5wnfE25KwB/bOOCuhKTjsrbni2VP6DvX JNbmbqtTQj5X+KmWmJWrO318VpipuEgEgpZb8nn0JchjvxtHX6Mp+ShAoKYzEfGvwmXl Z1eL3FuNU9lvhkpN1Dh+bXxFQmOgUeY5HQtklki+L0Omz8tPQz05UGWzS8I5C6gDV3Ol xj7GYXg5BMnaE2WFUFlGCU7W+LDr0pLDF/n73Z26L36X12M+2MXQy2nLVQLjLYxSs95T R1S6yG18j7zfKsAVspm7EfAU+rLMfKVPxod12RrS5H79Ba0QUf2YijD/EFf9fK5+cL+T y5Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WgHhOacVrxc6HGxdFM6k0YTyCIMBmDtAEJ1yeJMrcnc=; b=chLCPEvQ+eirdIyoXf1MS/B8iB6aQICiSHQvtRzJaueOZxyeUf9e34I6Dm7BtlJzgF 1uk1s3bnRSzhqGpieW1Y3WheY4BjsddJIAV2S2oxDR32PWEkt1yjtQd1VJYxwC/KihtB w+Vx2vRVnzjYhotSla5biRWuJSDpzFHwnu9nyPwbcLGdXY9Mkslyu4nDv1EL1LeiDGtH gKymHIPYONRUh9C+TvfNekNoJRECWny8I3BNsrILulNbZ5zHwb0d3DqCsQxgTQKjw58M uAXOWF02vbhAufFXjlQFZHZoKJ+YFtD3ME6WyMySlOfke7OjaCAd3E9RqoIH4GzVxx9h U/Ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LTCRW8mv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c8-20020a170903234800b001a923bc3af0si4755941plh.544.2023.05.22.13.15.27; Mon, 22 May 2023 13:15:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LTCRW8mv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235451AbjEVTvA (ORCPT + 99 others); Mon, 22 May 2023 15:51:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235391AbjEVTur (ORCPT ); Mon, 22 May 2023 15:50:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A3D1C1 for ; Mon, 22 May 2023 12:50:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 21DA362AF9 for ; Mon, 22 May 2023 19:50:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBC0FC4339B; Mon, 22 May 2023 19:50:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684785044; bh=DHB3E3whHUuZqeuu1DX7URmHv9V7oPFeShT/zXTe+DA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LTCRW8mvE+v+Qu9tfP6jNx3wcAib4AscGGz4Yi3vX0P6du6+fNQkfijJ4gOBxUEKV ZtPnFk9Dp7WlkzMvR/pj6r+WRzYXOpj6du4PA9p1dNnC21g4h5MhBqQF18eMM/otmD a6XRLVpIfXIsOvU3jIU0timMeTB/HBUDeNhW4OxfyQKctWeMgQD52yYGU7L3NGVUgI eZOXGbIiXYSC7Bn/CxAkj1A8L7FM754F756W9iiwwRdDOUpC86ogUwrTw/a83Bb0cS zpBzW+Ge7GZOtaQTDxMdtUE0NsMQ+M5JCA7WQvAlIzIVqJGiPW7JJdtaCRUkFKyKDW 9W56i/cl8X8Iw== From: Arnd Bergmann To: Ingo Molnar , Peter Zijlstra Cc: Arnd Bergmann , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , linux-kernel@vger.kernel.org Subject: [PATCH 4/5] sched: make task_vruntime_update() prototype visible Date: Mon, 22 May 2023 21:50:20 +0200 Message-Id: <20230522195021.3456768-5-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230522195021.3456768-1-arnd@kernel.org> References: <20230522195021.3456768-1-arnd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766626733660183373?= X-GMAIL-MSGID: =?utf-8?q?1766626733660183373?= From: Arnd Bergmann Having the prototype next to the caller but not visible to the callee causes a W=1 warning: kernel/sched/fair.c:11985:6: error: no previous prototype for 'task_vruntime_update' [-Werror=missing-prototypes] Move this to a header, as we do for all other function declarations. Signed-off-by: Arnd Bergmann Reviewed-by: Mukesh Ojha --- kernel/sched/core.c | 2 -- kernel/sched/sched.h | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 044bcdf4181a..aae6ff717c55 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -6030,8 +6030,6 @@ static inline struct task_struct *pick_task(struct rq *rq) BUG(); /* The idle class should always have a runnable task. */ } -extern void task_vruntime_update(struct rq *rq, struct task_struct *p, bool in_fi); - static void queue_core_balance(struct rq *rq); static struct task_struct * diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 44b34836bb60..d5ac0af1eede 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -1245,6 +1245,7 @@ static inline raw_spinlock_t *__rq_lockp(struct rq *rq) bool cfs_prio_less(const struct task_struct *a, const struct task_struct *b, bool fi); +void task_vruntime_update(struct rq *rq, struct task_struct *p, bool in_fi); /* * Helpers to check if the CPU's core cookie matches with the task's cookie From patchwork Mon May 22 19:50:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 97574 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1689307vqo; Mon, 22 May 2023 13:06:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6nwHGVeQ+mrYWpSKKNnnIKTSl+jGxi5TbGSTlfNDA2kWqWei3z/MQiWfgdj3AH07OA4mij X-Received: by 2002:a17:902:daca:b0:1ae:5752:aa51 with SMTP id q10-20020a170902daca00b001ae5752aa51mr14877900plx.36.1684786000560; Mon, 22 May 2023 13:06:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684786000; cv=none; d=google.com; s=arc-20160816; b=ZM6p/aCIQsw3Li5q2IJdrgR4AAXnaWFSi5xwZWjocWB5XWd/H0+LWnsqi4y8MQB3U0 wkkLanosvppI6PYQ0Ziwiw9opqxdkVLf8+qIBFU+/rmTGhxduH/uVLR1/OMdERiE5RjF aCmVtAqu0DvWqRsmE+zRFdxcI3WOEU3YyOI9G8DXC+CKIMdXuWdwP5O1vzMeRj/seT5C tmChd3JxgLUnWqlZGVE6sYEqdJRvwY7n76EinvMMuTp7QnIE7/n+9WV6r0N+Iwof1FHt YMg1riwpC/IWqsYIWtlVXyKU6y3YVKzGbUPL/BPn5DFwZFpI5eHy3UiUIxaxdZgvafcv 2keg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EAu/Xn0qw/JXp0et7tDk90/IiF07HD9MrRXPCnBlyIs=; b=I5Thdjt0VI7BN4SjRRdZdF8R96D0/0Rgjqi3KsAyPiQBkUmtLgjePrxftMiUKmTK4a 1bLFJkmTRf2X7+ZpWbxdRYPojzR9D1X5JZlM8OXB6pglvJvx6CbS9irR+BuZaioi68jE qMhS/LezZCns4gv0tFHOlEHQGHGzE3GlIY1dge6PbIGfLBWnzABANzGwBpKg+FYCt6cW r8Aju31DrjJrG8oFNmtuHDMLIwlLMskDzZ890gBNDT917unGd+zuZp+MTrFIRe0CvxWO /uJNdw0rOuss6dInqYxMUYeNBDy6B1RvLoJJ2kImPEU4KdsgblWcpqR9Xtq9rQZ8rMr+ 8dkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HNu10Gzq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c9-20020a170902724900b0019d038765f6si4910398pll.449.2023.05.22.13.06.25; Mon, 22 May 2023 13:06:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HNu10Gzq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235501AbjEVTvF (ORCPT + 99 others); Mon, 22 May 2023 15:51:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235464AbjEVTu4 (ORCPT ); Mon, 22 May 2023 15:50:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73ECD186 for ; Mon, 22 May 2023 12:50:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2D99B62B11 for ; Mon, 22 May 2023 19:50:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07C60C4339C; Mon, 22 May 2023 19:50:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684785047; bh=HMrD03u6K+/VHY9xLyPNlLoBBgFtU0+LXebB+R5ntic=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HNu10GzquFi3F4cNVyQ1jrCdEeHnO6oQz6W7NEDY7Zexxuma26WWwjKScT2y5r3gM 8WsSXdHyHdKtReVJHbcwXGRWG2KdH3Pi11K4jC37/lg22XdEBuLaaGvsp/4JIHdNt4 092IEA1A311rNFqt1q15Va0jBoFf/JfpYyukqK/chrbCP44M6q57SFcUb9ptS97AKg 2dnRww6uM1CtyJlz5pXVBAlcY46/bKd44rCJ+gmdsmsiyu/IlaWRZvfUt7TptpNTux trWOOmDVhJoXtJ7DVc9Fp0BewdU2zK45qipleGrWesGm0WHUFWbI7skAi+i0CAZZoq NC5p/CLXv9pRw== From: Arnd Bergmann To: Ingo Molnar , Peter Zijlstra Cc: Arnd Bergmann , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , linux-kernel@vger.kernel.org Subject: [PATCH 5/5] sched: fair: move unused stub functions to header Date: Mon, 22 May 2023 21:50:21 +0200 Message-Id: <20230522195021.3456768-6-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230522195021.3456768-1-arnd@kernel.org> References: <20230522195021.3456768-1-arnd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766626165321780788?= X-GMAIL-MSGID: =?utf-8?q?1766626165321780788?= From: Arnd Bergmann These four functions have a normal definition for CONFIG_FAIR_GROUP_SCHED, and empty one that is only referenced when FAIR_GROUP_SCHED is disabled but CGROUP_SCHED is still enabled. If both are turned off, the functions are still defined but the misisng prototype causes a W=1 warning: kernel/sched/fair.c:12544:6: error: no previous prototype for 'free_fair_sched_group' kernel/sched/fair.c:12546:5: error: no previous prototype for 'alloc_fair_sched_group' kernel/sched/fair.c:12553:6: error: no previous prototype for 'online_fair_sched_group' kernel/sched/fair.c:12555:6: error: no previous prototype for 'unregister_fair_sched_group' Move the alternatives into the header as static inline functions with the correct combination of #ifdef checks to avoid the warning without adding even more complexity. Signed-off-by: Arnd Bergmann Reviewed-by: Mukesh Ojha --- kernel/sched/fair.c | 13 ------------- kernel/sched/sched.h | 11 +++++++++++ 2 files changed, 11 insertions(+), 13 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index a7a8ccde3bd7..bae8907c1635 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -12602,19 +12602,6 @@ int sched_group_set_idle(struct task_group *tg, long idle) return 0; } -#else /* CONFIG_FAIR_GROUP_SCHED */ - -void free_fair_sched_group(struct task_group *tg) { } - -int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent) -{ - return 1; -} - -void online_fair_sched_group(struct task_group *tg) { } - -void unregister_fair_sched_group(struct task_group *tg) { } - #endif /* CONFIG_FAIR_GROUP_SCHED */ diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index d5ac0af1eede..0584fa15ffeb 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -453,10 +453,21 @@ static inline int walk_tg_tree(tg_visitor down, tg_visitor up, void *data) extern int tg_nop(struct task_group *tg, void *data); +#ifdef CONFIG_FAIR_GROUP_SCHED extern void free_fair_sched_group(struct task_group *tg); extern int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent); extern void online_fair_sched_group(struct task_group *tg); extern void unregister_fair_sched_group(struct task_group *tg); +#else +static inline void free_fair_sched_group(struct task_group *tg) { } +static inline int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent) +{ + return 1; +} +static inline void online_fair_sched_group(struct task_group *tg) { } +static inline void unregister_fair_sched_group(struct task_group *tg) { } +#endif + extern void init_tg_cfs_entry(struct task_group *tg, struct cfs_rq *cfs_rq, struct sched_entity *se, int cpu, struct sched_entity *parent);