From patchwork Sun May 21 22:57:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 96937 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1090795vqo; Sun, 21 May 2023 16:02:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6UF7911pMlnt9EBe8et6oo2TVbOOixRtIYwxX7qAGyxyWkjVxFDqI9pjX/NMuzTvDQEXc4 X-Received: by 2002:a05:6a00:23cc:b0:63d:368b:76b4 with SMTP id g12-20020a056a0023cc00b0063d368b76b4mr13385346pfc.17.1684710129962; Sun, 21 May 2023 16:02:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684710129; cv=none; d=google.com; s=arc-20160816; b=JZzIjJqRyGtB9Bw2lIhRswR1z33d+tpSB8T5rpsyUnUumbfUA1GckuKYxJhlTB4vy8 J1T7IG6hXnX5HsYUWGLX/IMeTNO2WAQwCn3lc1bQm9ftK3HbrZ9X9vQHHqBnTAdd1D4u wV4uQsTpzhXWaerlZzrZg4B8eYIq3HkSvJUDF0aHc4w5EkESoeQnceykNRzxk3b+BisT fSxDRmvAJ6ebuOgoxUbYItcpQAn1WlI5+H1OpfNEaKfLHlVWCiFJxrQM0auMYPnNetvq O+yVU9gqw/5KGSkeoSSczsVixNEX8tBISy84qjkZ8Grfub3b0ZldEoSQYSja2Pw8Yl3T tgXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=vgnEmcsn/vdxwW+Wgs9nj2+PsYmZXDs2hNecCx7a6R8=; b=MmSfyLuIvm93dG3AnwdEp+7r3YrvCOU1aeINmujIxHdRRJK+JNDLzOdRlHKs/4T0x+ rRQ45F25tzWHMFIHdgvZWeSymEYaSaKEExf6mBelvVdxwGe/GgKhPd4Xq5TSv6OtmyGu Z8Jcvgi0L1nl0HkwZAu0Bc8+TuIw64/URSS8JgKDDcM9DnD/hutM06o993F/jRXGsxuR Z0bFdEBpjcKPD/aJkV0nwZqsRELma2d6zQQ8tpVn/SnX5j7VBKJg+69HF0wJcenUPygJ hhdTFJSjT3bEUs0KH6firt0eT2ewMrQQ1ipo7+9v3qqAr01QeQPGGDsXCv3ryWFmm6Mh Rqcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=WOwGfCog; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h4-20020aa79f44000000b006281ec442absi3797736pfr.309.2023.05.21.16.01.58; Sun, 21 May 2023 16:02:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=WOwGfCog; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230216AbjEUW5I (ORCPT + 99 others); Sun, 21 May 2023 18:57:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjEUW5G (ORCPT ); Sun, 21 May 2023 18:57:06 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A53B9BE for ; Sun, 21 May 2023 15:57:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=vgnEmcsn/vdxwW+Wgs9nj2+PsYmZXDs2hNecCx7a6R8=; b=WOwGfCog1wQ+I6YMalK9qZfuYC 1R7vptRIeip+Ffkd7pVoZsLhGEaDC8KEdBj9jrBgIMMQ4Mfvhx3xY3BQAZAQ9TEQ3qTL78oGO99T3 AJMfW+nXBiTwd+vgiBouEoqflMeoLA2kujnSp8pWRAZs1NyAua//Ve9Rq4BFcPGEyx42N++S5VDZV WNfozb2VveEu8fQ1wqoRIJXnKfY+sMGEHNHifo7UXwJNjvw03AfArieJ59mLrbtIENr9TfT9yd6kA JyBT1QzKBwr5PmnpvijQ1mpV9LBpv/koIv0Dy7Er0qRwyCbzszbE3dms8ZUUdawUARcGtqTI79LtE gJZgl43g==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1q0rz5-004o6u-0t; Sun, 21 May 2023 22:57:03 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Grant Likely , Mark Brown , Liam Girdwood , Shengjiu Wang , Xiubo Li , alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, Jaroslav Kysela , Takashi Iwai Subject: [PATCH v2 RESEND] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM Date: Sun, 21 May 2023 15:57:02 -0700 Message-Id: <20230521225702.1608-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766546609180734744?= X-GMAIL-MSGID: =?utf-8?q?1766546609180734744?= Both SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA select SND_SOC_MPC5200_AC97. The latter symbol depends on PPC_BESTCOMM, so the 2 former symbols should also depend on PPC_BESTCOMM since "select" does not follow any dependency chains. This prevents a kconfig warning and build errors: WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97 Depends on [n]: SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC52xx [=y] && PPC_BESTCOMM [=n] Selected by [m]: - SND_MPC52xx_SOC_PCM030 [=m] && SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC5200_SIMPLE [=y] - SND_MPC52xx_SOC_EFIKA [=m] && SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_EFIKA [=y] ERROR: modpost: "mpc5200_audio_dma_destroy" [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined! ERROR: modpost: "mpc5200_audio_dma_create" [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined! Fixes: 40d9ec14e7e1 ("ASoC: remove BROKEN from Efika and pcm030 fabric drivers") Signed-off-by: Randy Dunlap Cc: Grant Likely Cc: Mark Brown Cc: Liam Girdwood Cc: Shengjiu Wang Cc: Xiubo Li Cc: alsa-devel@alsa-project.org Cc: linuxppc-dev@lists.ozlabs.org Cc: Jaroslav Kysela Cc: Takashi Iwai --- v2: use correct email address for Mark Brown. sound/soc/fsl/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97 config SND_MPC52xx_SOC_PCM030 tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712" - depends on PPC_MPC5200_SIMPLE + depends on PPC_MPC5200_SIMPLE && PPC_BESTCOMM select SND_SOC_MPC5200_AC97 select SND_SOC_WM9712 help @@ -252,7 +252,7 @@ config SND_MPC52xx_SOC_PCM030 config SND_MPC52xx_SOC_EFIKA tristate "SoC AC97 Audio support for bbplan Efika and STAC9766" - depends on PPC_EFIKA + depends on PPC_EFIKA && PPC_BESTCOMM select SND_SOC_MPC5200_AC97 select SND_SOC_STAC9766 help