From patchwork Sun May 21 22:52:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 96933 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1089707vqo; Sun, 21 May 2023 16:00:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5/OVmiLcjBz7R0yD1mO4uqQyxJ4OJZm4V2KjQpLLoNMY4NoZ2RBwVP9H9d6iDRWfBVHU6Q X-Received: by 2002:a05:6a00:23d5:b0:646:421f:500b with SMTP id g21-20020a056a0023d500b00646421f500bmr11373097pfc.10.1684710024829; Sun, 21 May 2023 16:00:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684710024; cv=none; d=google.com; s=arc-20160816; b=KXbbugf12jc/sW5dId0VNH1LVNWSSU0Tf/raxx/rORwEHk2oA+sOQfpwpJhtjWa76B ZPGlbYVhzUnNKDkxzxeESMuQhSnbTQZqGEVfkQ4ZLRBbzuZk+GrVGuj04o7MC6guQXt9 bkhAAF1XHK5vKvm7wehjPm99rtAirinNPuScK/tbl001eoLzsOgHZmxIg4HUkruk7A8r xIcQ9ykRdVyKIKdGbRZDJ1xhIsK8hbH0pksH7e3nLOYg+hrguKke4hgfen74ivQu/H5d 8bjE6E10lzY6BOJqZFBmS2DyMcpfW+oYL12pftFPF7kHQzCveo1v7sEhN+apGWjN9ZA+ PYIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=5ZqyIo2yPozy9BK+WevZ7XbxMmk32DVp4jnPgiud1w8=; b=YvDwYL/JWIcPCZRSFjFO30DUJ5TMttkGPrGFj54c80nCymKchEvHhcnRgTN4uYx92c i90yyzx1y2l2TIQbwnmQ1ViahHT1dLUI9MiUx0yrpUenCc9WFnti2fjud+HkaJfCY7EL xywR0RqXV6tSYl3dSpqce+kycFRQKpGlpvi9D98bbNtR5uafBxYknyCYzRaWTHQ6Tj6T iTj5Ivg/OcTXCJD4CP5OrI24kOMKBUbJlgd9nyFaeqPKpb3GrZDVtlaVKprtYoXXaReH Fu83AD1uuiiBSUJoVdafjOAIf8ZXcqgh/CgxtfNpUy4AJtTHE+yLM5YE6gImb4VxxcUC Ywng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="RLz/unVI"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f12-20020a63380c000000b0052c54de0299si3701411pga.637.2023.05.21.16.00.12; Sun, 21 May 2023 16:00:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="RLz/unVI"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231521AbjEUWw1 (ORCPT + 99 others); Sun, 21 May 2023 18:52:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229999AbjEUWwZ (ORCPT ); Sun, 21 May 2023 18:52:25 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B78ABF for ; Sun, 21 May 2023 15:52:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=5ZqyIo2yPozy9BK+WevZ7XbxMmk32DVp4jnPgiud1w8=; b=RLz/unVIGHd026f+9ZJXZg3KNe 5bQPjNbNIkA0r4a64+ptkEVQDA7YiH0OO+aSfRY0NbXGY/9Osua6ieyFOHq2LhzyDWkVN8i2vUf4H p72YZcujI+E4wDAdxWuQvoXfqJ2cx9oWKJsNOWsqivsSioi1hwwdvsn0MHcmIoT5bNnfVfrxWPomh 6GWYMENY2ITT4mp38zrfu0tsy0vfHL8TKj2BHhQtvtoVfbg2qr8EBhPBvgW/tPzXujJ6J4B3uXtnU OEhVuHIhE4dy2VEPu7EP3z8J8yEU2/7w1fWzXm9ziw4M7jE+cXsn7znj2rXw3BFVxPVpuf2gU50Qa 8jxTsIBw==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1q0ruT-004nQW-1b; Sun, 21 May 2023 22:52:17 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , kernel test robot , Michael Ellerman , Christophe Leroy , Leo Li , Masahiro Yamada , Nicolas Schier , Qiang Zhao , linuxppc-dev , linux-arm-kernel@lists.infradead.org, Kumar Gala Subject: [PATCH v2 RESEND] soc/fsl/qe: fix usb.c build errors Date: Sun, 21 May 2023 15:52:16 -0700 Message-Id: <20230521225216.21795-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766546499019832431?= X-GMAIL-MSGID: =?utf-8?q?1766546499019832431?= Fix build errors in soc/fsl/qe/usb.c when QUICC_ENGINE is not set. This happens when PPC_EP88XC is set, which selects CPM1 & CPM. When CPM is set, USB_FSL_QE can be set without QUICC_ENGINE being set. When USB_FSL_QE is set, QE_USB deafults to y, which causes build errors when QUICC_ENGINE is not set. Making QE_USB depend on QUICC_ENGINE prevents QE_USB from defaulting to y. Fixes these build errors: drivers/soc/fsl/qe/usb.o: in function `qe_usb_clock_set': usb.c:(.text+0x1e): undefined reference to `qe_immr' powerpc-linux-ld: usb.c:(.text+0x2a): undefined reference to `qe_immr' powerpc-linux-ld: usb.c:(.text+0xbc): undefined reference to `qe_setbrg' powerpc-linux-ld: usb.c:(.text+0xca): undefined reference to `cmxgcr_lock' powerpc-linux-ld: usb.c:(.text+0xce): undefined reference to `cmxgcr_lock' Fixes: 5e41486c408e ("powerpc/QE: add support for QE USB clocks routing") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Link: https://lore.kernel.org/all/202301101500.pillNv6R-lkp@intel.com/ Suggested-by: Michael Ellerman Cc: Christophe Leroy Cc: Leo Li Cc: Masahiro Yamada Cc: Nicolas Schier Cc: Qiang Zhao Cc: linuxppc-dev Cc: linux-arm-kernel@lists.infradead.org Cc: Kumar Gala Acked-by: Nicolas Schier --- v2: drop Anton Vorontsov ; rebase/resend drivers/soc/fsl/qe/Kconfig | 1 + 1 file changed, 1 insertion(+) diff -- a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig --- a/drivers/soc/fsl/qe/Kconfig +++ b/drivers/soc/fsl/qe/Kconfig @@ -62,6 +62,7 @@ config QE_TDM config QE_USB bool + depends on QUICC_ENGINE default y if USB_FSL_QE help QE USB Controller support