From patchwork Sun May 21 22:51:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 96932 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1089699vqo; Sun, 21 May 2023 16:00:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7w7bqZxNigwIZ3ZfooGAr1hLTw07dTepAwN7uqVOVNY0NbbB+yfRQi99QEZj7jZJPp59jz X-Received: by 2002:a05:6a00:986:b0:64a:7723:fe04 with SMTP id u6-20020a056a00098600b0064a7723fe04mr13297761pfg.4.1684710024136; Sun, 21 May 2023 16:00:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684710024; cv=none; d=google.com; s=arc-20160816; b=HFhg6GEIrrp3LMNbWmIFbQeDZqvr07wGygG0u6AJ1rB75mdUsvRgna4sXoJcoIk7zi 32PtyvVR8iRNLjIv5x6Ujv09CgFZF7qlN5F0JBOlfbXDq91QFfmvH50PuLtlWGVYwjFp gM3y75qApHX8A5DMu/luNgRDApW6N9/lqqRLe7z5Otj7JwLWTy2ZJoxi6Da48X23lo54 58kKJW7sO6x7pstqPJegxOZ5Z9zdybrpPb7GqZME1738XzueRx+7fKE3303U2N4qci0V 2lV7yDKKLBB/2H5t7v9ajxaOrUuWu0QPGer6eN4fy3vg6V+f424JIaSJ3qT13tPYSjS3 AyXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=9Xg26FQraBSMG0MMhYiyu1iEgUv/WTNcURfydXNCXls=; b=E7ltOHQv4jv8KGzgbs3Pns0URUnQ7FkP05TbqdIxgzmHFL8Q7Snb9pVlYEfn8vU2H1 uLSAg0roITo4B2xinZEJ6mGpQG6+F0GpiQMZ3loci0NwD8wwmoPbVHHL00r+ZmF6rlTp MwG9eKi5IhswKvqZ5oDfY3WWzt4q9Q8UD1+7R2aS+IvMjNHklVr9aG1a0Z2AXfWEVfQo B3N4TX+fZXcSkkbFohdYI0fCAOeNie2xI+82S6OvPCTtw835wE7oyT3r4TlMmzHLy+S6 lptJb30q3i091MA5x1tajO9nUysUnEv8jPlwkG04WOcu+/4bUlWP2TVlu6puq2v7aZA3 bFEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=er+YPaEL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h4-20020aa79f44000000b006281ec442absi3797736pfr.309.2023.05.21.16.00.12; Sun, 21 May 2023 16:00:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=er+YPaEL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231517AbjEUWvH (ORCPT + 99 others); Sun, 21 May 2023 18:51:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231387AbjEUWvF (ORCPT ); Sun, 21 May 2023 18:51:05 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDD59BA for ; Sun, 21 May 2023 15:51:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=9Xg26FQraBSMG0MMhYiyu1iEgUv/WTNcURfydXNCXls=; b=er+YPaELPWlGuad6wTFYsecX8Z QBJz2NjluoMfBU6qJYrXY8RJyc9xdFKuxRIXnxHAUlLDHPuJfG27PKrxlFc7pG7YIooFKefhbq6oY HYrdn+FSmb9aaCU2EvDhvSTH1EN3ZsfXpGcAKQ296tFWdRNDPzShzzfRPPszFBqQmPjc3xFCO/XUt e3obSLcE28vJSAzamSjLrBPoXBkHedq1HxsKfdNJ9jnd1yWyLHAeUu81bk+YQrPzpiXXHGTVZJcMF iAD2M6ZFCVnKgAkCh19H8jtNHl2eUFDnSELAF+PxjIxcy4wtkm4nLjguELFlQG5u0+/+HzoY7XjhA eKCG3ISA==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1q0rtI-004nEw-1c; Sun, 21 May 2023 22:51:04 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Michael Ellerman , Nicholas Piggin , Christophe Leroy , linuxppc-dev@lists.ozlabs.org Subject: [PATCH v2 RESEND] powerpc/embedded6xx: select MPC10X_BRIDGE only if PCI is set Date: Sun, 21 May 2023 15:51:03 -0700 Message-Id: <20230521225103.19197-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766546498287278070?= X-GMAIL-MSGID: =?utf-8?q?1766546498287278070?= When CONFIG_SMP is not set, CONFIG_BROKEN_ON_SMP is set, and CONFIG_PCI is not set, there can be a kconfig warning: WARNING: unmet direct dependencies detected for PPC_INDIRECT_PCI Depends on [n]: PCI [=n] Selected by [y]: - MPC10X_BRIDGE [=y] To fix that, make the selects of MPC10X_BRIDGE be conditional on PCI and use "imply" instead of "select". Signed-off-by: Randy Dunlap Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Cc: linuxppc-dev@lists.ozlabs.org Suggested-by: Michael Ellerman # use "imply" --- v2: use imply instead of select (mpe) arch/powerpc/platforms/embedded6xx/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/arch/powerpc/platforms/embedded6xx/Kconfig b/arch/powerpc/platforms/embedded6xx/Kconfig --- a/arch/powerpc/platforms/embedded6xx/Kconfig +++ b/arch/powerpc/platforms/embedded6xx/Kconfig @@ -10,7 +10,7 @@ config LINKSTATION select FSL_SOC select PPC_UDBG_16550 if SERIAL_8250 select DEFAULT_UIMAGE - select MPC10X_BRIDGE + imply MPC10X_BRIDGE if PCI help Select LINKSTATION if configuring for one of PPC- (MPC8241) based NAS systems from Buffalo Technology. So far only @@ -24,7 +24,7 @@ config STORCENTER select MPIC select FSL_SOC select PPC_UDBG_16550 if SERIAL_8250 - select MPC10X_BRIDGE + imply MPC10X_BRIDGE if PCI help Select STORCENTER if configuring for the iomega StorCenter with an 8241 CPU in it.