From patchwork Tue Oct 25 09:15:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 10640 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp895186wru; Tue, 25 Oct 2022 02:15:55 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4PocLkfqYBq1Qb+96I1g+jryuO1cfnNYk18tfDJvX2retdDgag/GrbnevSC+GMehnyqX5r X-Received: by 2002:a17:907:a04f:b0:7a9:ec45:1699 with SMTP id gz15-20020a170907a04f00b007a9ec451699mr6345834ejc.247.1666689355899; Tue, 25 Oct 2022 02:15:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666689355; cv=none; d=google.com; s=arc-20160816; b=BP2wOBkz49d/Vp9/9kiOque1rPMfARtL5VqCIUu4CmnrSZe4Fl5eLDim8kFs4R7w3R WnEnEXMov1tmWKMYcCi6hAgVaiGcvGbovPYCwE5kLiOs4AfMsmt5EDVcSJWHKvTGj9ii SxR8P0LOmkHBbxpk+aWxq62gtwfOxKS0b+GGWdXSAABJVGRbr9SrwCdEPeCdbCrbOjoT fVCKZLHS2ClduY6/d5697attaXBPNaZnrECZ/TQ41UIIvKnzsYt33QT35+DJTJ1bkmxK CYZAY1p4LYvmProxB8vrNrfsnc9Ow9H/y008HaOvd6QfuZQTslO4eg0BicTxq7jidBPS IYnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:message-id :mime-version:subject:to:date:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=d1pGRJTseKnPaR6jR5Wb7Pd77mPWd2gqNYiN34bEpy8=; b=oXImK3V/B8hnCmo9T+pX/4F1WLL0jCShXKAkAYaj7W/Zs0VR3+Sh389PuNyfGEmcOr 5sTi3qyHGoOLnNzAcsVISfEM1hD/nO+I99A/OGk/UkOwrQqro6RVj/WVcC6lmXNWaI4l yJxcrGQlQC5omLsJtTvjQQWgCmwasit8gG5QT2mK5GHKbL7Kj53rbEWeFTTbYFNWtRqN WMju1elGH6V2bmHWiM55SZl4ut+3ZJiVUAZyeDgiArtTX8BSFCxbUdrk6LhM41lxw/RR 48WQ+0a6jhVAbb2xpRqg9wG8UkpxluqU23/Ux1/9FsACwn5avW5gIrzPxCdJhRoUufQE Eh8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=CgjHkE8v; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id y19-20020a056402441300b0043d54ba0a4dsi2958439eda.327.2022.10.25.02.15.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 02:15:55 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=CgjHkE8v; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AE3E83857C4C for ; Tue, 25 Oct 2022 09:15:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AE3E83857C4C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1666689354; bh=d1pGRJTseKnPaR6jR5Wb7Pd77mPWd2gqNYiN34bEpy8=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=CgjHkE8vz5O54N539OFCl03mCnYUzy7VN422NwZYj3uOWwn/Wx2QYDsu2i19fJLWp 1rb3V8MGSJuSfPY+n9c+xOj8mAYR3UQwT/rKGr4hxkb3PYWS0KA+L8BztZIOB8ceWB PaMVOD7txYXLSW1mFNanoUw5LQQ+X/AOoZc1j5n4= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id C5C463858011 for ; Tue, 25 Oct 2022 09:15:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C5C463858011 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B80571FB3E for ; Tue, 25 Oct 2022 09:15:09 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A7EBC134CA for ; Tue, 25 Oct 2022 09:15:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id V8gbKB2pV2PLOQAAMHmgww (envelope-from ) for ; Tue, 25 Oct 2022 09:15:09 +0000 Date: Tue, 25 Oct 2022 11:15:09 +0200 (CEST) To: gcc-patches@gcc.gnu.org Subject: [PATCH] Move NOP stripping in SCEV analysis MIME-Version: 1.0 Message-Id: <20221025091509.A7EBC134CA@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747650458281119779?= X-GMAIL-MSGID: =?utf-8?q?1747650458281119779?= The following moves a pair of STRIP_USELESS_TYPE_CONVERSIONS to where it belongs and adds a comment on why we handle GENERIC there at all. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. * tree-scalar-evolution.cc (follow_ssa_edge_expr): Move STRIP_USELESS_TYPE_CONVERSIONS to where it matters. --- gcc/tree-scalar-evolution.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gcc/tree-scalar-evolution.cc b/gcc/tree-scalar-evolution.cc index 9f30f78cb5d..8b927094324 100644 --- a/gcc/tree-scalar-evolution.cc +++ b/gcc/tree-scalar-evolution.cc @@ -1214,6 +1214,8 @@ tail_recurse: { code = TREE_CODE (expr); type = TREE_TYPE (expr); + /* Via follow_ssa_edge_inner_loop_phi we arrive here with the + GENERIC scalar evolution of the inner loop. */ switch (code) { CASE_CONVERT: @@ -1224,6 +1226,8 @@ tail_recurse: case MINUS_EXPR: rhs0 = TREE_OPERAND (expr, 0); rhs1 = TREE_OPERAND (expr, 1); + STRIP_USELESS_TYPE_CONVERSION (rhs0); + STRIP_USELESS_TYPE_CONVERSION (rhs1); break; default: rhs0 = expr; @@ -1260,8 +1264,6 @@ tail_recurse: case PLUS_EXPR: case MINUS_EXPR: /* This case is under the form "rhs0 +- rhs1". */ - STRIP_USELESS_TYPE_CONVERSION (rhs0); - STRIP_USELESS_TYPE_CONVERSION (rhs1); if (TREE_CODE (rhs0) == SSA_NAME && (TREE_CODE (rhs1) != SSA_NAME || code == MINUS_EXPR)) {