From patchwork Fri May 19 14:31:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 96457 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1282329vqo; Fri, 19 May 2023 07:33:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4ftxo9oG4xAlj0s/O00fZIxTh0Wzm54OU65Y53XY8uAeVGbIq1QYCoxIPe5B0PKNDWSloi X-Received: by 2002:a17:902:efd3:b0:1ad:164:74ee with SMTP id ja19-20020a170902efd300b001ad016474eemr2650164plb.15.1684506801036; Fri, 19 May 2023 07:33:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684506801; cv=none; d=google.com; s=arc-20160816; b=zdSKXQXPBEBCXsPj24XllaJdRmpbehyPeH2NYPjmnS7H0vBmLt0DukwSKw8pkmEd/4 yV5JXIpRVXE1iWpDlHZs72B9ShcEijRlGj6DGIgzv63110Sn5GS85iaEvcSTqVdMhtcV pSEhZjurc78MrRBK+hou0jWekaZ3s9Zg8LXSmjqXX/CvOluDujQiAVixTXuvyHMTvdqm tnEbjf/M7hup2nO9iGBKdvxkisHD3sIlmOlwGqgAGHv5v2n0e34rlR/KckR/zbm3sMqq HLIQ+tC+f9mXmVeatVeIAy4P47RqdCAT/GQCLAN1nqoGcq2+an97IiKqbulkc+nF1sjx 1A3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1Bi50f5L0jGxtEOM93kXczyai8aQgRkFZvqXAKgUqmc=; b=uhvd2A/gwMMXiXdweWjJuXkkU8RKboe6c7VlDdODKJBBy200pnoh1+M+N5+AEE3Hn1 03ZkQ/ERIZktpiY8jjP9SYQA+kndykbrUqPXT8ESYlmXTJ9ulnN3zOM839V45/AAXZjv uUmC8YYEATMFARnLHGnqHpeVQaCgErtQ/dqi+ezPcLUvJMh2zmSjWCgAkulEFMHGzXbm b4tCqOeJbncKQ4epwinG0iVJ54pzeeGzq5K6J3WNwDqWDLOApxU16TVXktjC/88N5Vu3 38GBiqvx4I3+C/hLyktB0FKz2sAmqfxmHgP8aQkVQOxiPl6H9/JuA4SN2Sk/9o07vLIU 1l+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yD3mO6K0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s5-20020a639245000000b00530b70aac49si3705863pgn.45.2023.05.19.07.32.58; Fri, 19 May 2023 07:33:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yD3mO6K0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232093AbjESObj (ORCPT + 99 others); Fri, 19 May 2023 10:31:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232053AbjESObe (ORCPT ); Fri, 19 May 2023 10:31:34 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AFB7187 for ; Fri, 19 May 2023 07:31:32 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-25343f0c693so2348368a91.3 for ; Fri, 19 May 2023 07:31:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684506692; x=1687098692; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1Bi50f5L0jGxtEOM93kXczyai8aQgRkFZvqXAKgUqmc=; b=yD3mO6K0EvTiN4Naa/DozA6hIjtQTgHVgQt4moGa/KGv4v5B63GeIvO3qDECQj/Gme gyBHMnT+sI+6shkU+wskP589SVzXNmHQwE/Fu27oqrNjhmrzj5n84BntMgAhLxXSgb/d ZclSZiikp/D5So6irRhaQ4jklC9n6VbRwYLy2lAsEL+8JXPk1ymjyxfGQtpyj8yGk8Xd KdYQp71QqLNu0yNbSbHcqGA0auRz9hK8lf7znPt/dgW2kUMMZJne6vrAlDGm2Z+fu+PY xnLY1AetghCOMpToI1lmshVOFFeymuy48iTcrdG1ToCqATGaUytHG6dK7buSziwJ2jAA FhjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684506692; x=1687098692; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1Bi50f5L0jGxtEOM93kXczyai8aQgRkFZvqXAKgUqmc=; b=FLJAYT09GOaivL60xxtJ+8Q7uFBryaVDPj11jP/kEYP4uu+cEBEm5AgoIDFkwggbQw ebdCgaDBsIE+u0FZDqvkAIXwmR3HzlouhzaPY5z79wD2b8Qj6e2jqfz17RxkJMTXjCqK YPQCJmdY8hrg1qRIjV3SdP0BB2g2A8wIJNK1jwYg5xTcZdz7as0NvpULt00hHvQRTFRB JRlXt9fNTAsFCrbZcVZDIesLTC15+OTM8/tNX6yxpeVyNlmdTBLvH360uYUzMqpGMx2k qj9AT79qPUoeWRyrJSs6jg885eCQAqReMrZIaxf1K4uWV5DefMNkw3UIpe+12OA5A/Dh 8hvQ== X-Gm-Message-State: AC+VfDxXnkHG9MHv/Oy0hcZSzhJnD6zirrskGa2vwp9w352G/bu7pKls LSr3MRbY/2P0tv2aYYB6Sigb X-Received: by 2002:a17:90a:bf8b:b0:253:727e:4b41 with SMTP id d11-20020a17090abf8b00b00253727e4b41mr2278226pjs.34.1684506692003; Fri, 19 May 2023 07:31:32 -0700 (PDT) Received: from localhost.localdomain ([117.202.184.13]) by smtp.gmail.com with ESMTPSA id 30-20020a17090a09a100b00250d908a771sm1634845pjo.50.2023.05.19.07.31.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 May 2023 07:31:31 -0700 (PDT) From: Manivannan Sadhasivam To: lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com Cc: robh@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, steev@kali.org, quic_srichara@quicinc.com, dmitry.baryshkov@linaro.org, Manivannan Sadhasivam , Dmitry Baryshkov Subject: [PATCH v2 1/8] PCI: qcom: Use DWC helpers for modifying the read-only DBI registers Date: Fri, 19 May 2023 20:01:10 +0530 Message-Id: <20230519143117.23875-2-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230519143117.23875-1-manivannan.sadhasivam@linaro.org> References: <20230519143117.23875-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766333403194175953?= X-GMAIL-MSGID: =?utf-8?q?1766333403194175953?= DWC core already exposes dw_pcie_dbi_ro_wr_{en/dis} helper APIs for enabling and disabling the write access to read only DBI registers. So let's use them instead of doing it manually. Also, the existing code doesn't disable the write access when it's done. This is also fixed now. Fixes: 5d76117f070d ("PCI: qcom: Add support for IPQ8074 PCIe controller") Signed-off-by: Manivannan Sadhasivam Reviewed-by: Dmitry Baryshkov Reviewed-by: Dmitry Baryshkov Signed-off-by: Manivannan Sadhasivam --- drivers/pci/controller/dwc/pcie-qcom.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index 4ab30892f6ef..01795ee7ce45 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -61,7 +61,6 @@ /* DBI registers */ #define AXI_MSTR_RESP_COMP_CTRL0 0x818 #define AXI_MSTR_RESP_COMP_CTRL1 0x81c -#define MISC_CONTROL_1_REG 0x8bc /* MHI registers */ #define PARF_DEBUG_CNT_PM_LINKST_IN_L2 0xc04 @@ -132,9 +131,6 @@ /* AXI_MSTR_RESP_COMP_CTRL1 register fields */ #define CFG_BRIDGE_SB_INIT BIT(0) -/* MISC_CONTROL_1_REG register fields */ -#define DBI_RO_WR_EN 1 - /* PCI_EXP_SLTCAP register fields */ #define PCIE_CAP_SLOT_POWER_LIMIT_VAL FIELD_PREP(PCI_EXP_SLTCAP_SPLV, 250) #define PCIE_CAP_SLOT_POWER_LIMIT_SCALE FIELD_PREP(PCI_EXP_SLTCAP_SPLS, 1) @@ -826,7 +822,9 @@ static int qcom_pcie_post_init_2_3_3(struct qcom_pcie *pcie) writel(0, pcie->parf + PARF_Q2A_FLUSH); writel(PCI_COMMAND_MASTER, pci->dbi_base + PCI_COMMAND); - writel(DBI_RO_WR_EN, pci->dbi_base + MISC_CONTROL_1_REG); + + dw_pcie_dbi_ro_wr_en(pci); + writel(PCIE_CAP_SLOT_VAL, pci->dbi_base + offset + PCI_EXP_SLTCAP); val = readl(pci->dbi_base + offset + PCI_EXP_LNKCAP); @@ -836,6 +834,8 @@ static int qcom_pcie_post_init_2_3_3(struct qcom_pcie *pcie) writel(PCI_EXP_DEVCTL2_COMP_TMOUT_DIS, pci->dbi_base + offset + PCI_EXP_DEVCTL2); + dw_pcie_dbi_ro_wr_dis(pci); + return 0; } From patchwork Fri May 19 14:31:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 96461 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1285038vqo; Fri, 19 May 2023 07:37:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6wiBYRPQFsuy6CXs3KnyTNm48IajVjpggfSCxJPwwERhooKh534DH8UNFv85b56/unfTn1 X-Received: by 2002:a17:90a:f40a:b0:253:3d00:a55a with SMTP id ch10-20020a17090af40a00b002533d00a55amr2331763pjb.34.1684507033049; Fri, 19 May 2023 07:37:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684507033; cv=none; d=google.com; s=arc-20160816; b=pQL50y+ndaiveV88S2pfOEhg6FVbUwMtyLblN4CYt7nKGubxzQJLap548vFBejOaUp moq1KEhnEhHk886aOr3hPfx56QNPgXQDhL0WAeR+O//FzkCW6f0yepUhkxnwlxCTfruh lcNZeyJ93H59XefTguoJM9I4nvcMeAn2bNRg7DkWqNzQwnjdiNC4HJQFpDWNckgrryiI R2ix2hTQzUcdZBhtQyjEO4m/cmGwtLXac/Z4iJfk+/3FSZH2JyNR4V87nYGqZe69RpQs CRHVB83gzemXYYtymX1JH22ALQiA7XhGgeepOyx/8F1Gw9M6tyh5T5frcJArTgWn5qUM xHTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5zLG4dTgi3xTplGTrfZB0o1fFz0ivS0ryK10HN6uoQ0=; b=YVZDERvb+S919wiXH3wwdIL5JdWTfnMDfG3a0yFEliFlZzksX8gJhF/db9zrVFjLvz 0yPiG0GBHcOHCuUv1PaL25CDGVfnHn1e0txXSZ0gn3t4hUZbmpMVoFgLp/I0NM8OlF4I QBxuS88JqOsreg2HZxky7/Hr38PjwVYwFTvu6ytK4Yx5Lrw2xLjKgo80Dl27z4/DGDQ0 KDnIg0vLdu9+6hKWVS2f7HIjf60qExZYQIuZqXhCFhZlrw5jO1DG6oVMguMPuEW1eCSU 0JL8E4usPp1bDpogM5OWutLXRdjbkBC/Yt9bcdAOu22wAeZ2eyNp2SIZy2rTNxKX4Vz4 8MUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qGdwPEmy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fa2-20020a17090af0c200b0024e1a6c7f82si1821829pjb.80.2023.05.19.07.37.00; Fri, 19 May 2023 07:37:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qGdwPEmy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232080AbjESObm (ORCPT + 99 others); Fri, 19 May 2023 10:31:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232088AbjESObi (ORCPT ); Fri, 19 May 2023 10:31:38 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60B11187 for ; Fri, 19 May 2023 07:31:37 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-25332b3915bso2672073a91.2 for ; Fri, 19 May 2023 07:31:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684506697; x=1687098697; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5zLG4dTgi3xTplGTrfZB0o1fFz0ivS0ryK10HN6uoQ0=; b=qGdwPEmy69hz5bwluW7Fq1zj0cnJ763Juy1Q9I0nI60SqhiOMAI8IPYFfjjUoKmMh7 Z9rFHOxQmXWKEMJcqr9ebxI6WhpQLQxaMvFD6YkvQW1txWwTE+0341WLdr4r0AfmFlbp cCcsBAwjjNgAqRCKPBpIvyEMoZh666Jzw2ZPnL6epW++0h/lWQozK6G9CyBihIo6HK7s x7IM+fG1ck6w6IWX3LXHo/VTTEKXIYw7pR1AHukHHugbm5I04nkIkC9Goj/fqaS9nxuI 9eD6O0dt/eCA+q07GH2Nuaob+YogjGYjEjt0JXz90qDzXSG4dAtug95Hl/APgOpxoeFn 1pqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684506697; x=1687098697; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5zLG4dTgi3xTplGTrfZB0o1fFz0ivS0ryK10HN6uoQ0=; b=QaQfrnPoC8F3jq0gZQwRR7scSJMNmHZx1tIpeiWcLFdC6mMdRIFMzs1RUvEFlhEMjG 75BJwfgSmr/ckx2DLVQmah9+/9apGmI8Vt5D9SDJbzn7kfykHdmkslsHC5ZQMjd0qTgO jMJskJz9D3vGN/xEZlo/M+u5fitfn7TvpPXEDRm68cLq1y5TQ64n2sQOY5UAmmueLYpP aDy4rm2e8YOToR623E2PjgSWDAZzhkOGw4JGFTU9UaUdIxi6lZgV3mXhqEjPpl8F7qWT IyfHWqlYUCUAXjQ4JBNar6jblZzSlpnqLwXV2WOG7z+yDIFEsbh9R7I0RkrlfOVyq6yM oe2w== X-Gm-Message-State: AC+VfDxlGQUnanb5RuTXRcFQv6g7ytz5iZ1PaSy/fHrwDEKy6J7WrcKw EkYsXAOyarFwWYRupoCVTo0/ X-Received: by 2002:a17:90b:3648:b0:253:927d:6a36 with SMTP id nh8-20020a17090b364800b00253927d6a36mr716888pjb.18.1684506696910; Fri, 19 May 2023 07:31:36 -0700 (PDT) Received: from localhost.localdomain ([117.202.184.13]) by smtp.gmail.com with ESMTPSA id 30-20020a17090a09a100b00250d908a771sm1634845pjo.50.2023.05.19.07.31.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 May 2023 07:31:36 -0700 (PDT) From: Manivannan Sadhasivam To: lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com Cc: robh@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, steev@kali.org, quic_srichara@quicinc.com, dmitry.baryshkov@linaro.org, Manivannan Sadhasivam , Dmitry Baryshkov Subject: [PATCH v2 2/8] PCI: qcom: Disable write access to read only registers for IP v2.9.0 Date: Fri, 19 May 2023 20:01:11 +0530 Message-Id: <20230519143117.23875-3-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230519143117.23875-1-manivannan.sadhasivam@linaro.org> References: <20230519143117.23875-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766333646377268139?= X-GMAIL-MSGID: =?utf-8?q?1766333646377268139?= In the post init sequence of v2.9.0, write access to read only registers are not disabled after updating the registers. Fix it by disabling the access after register update. Fixes: 0cf7c2efe8ac ("PCI: qcom: Add IPQ60xx support") Signed-off-by: Manivannan Sadhasivam Reviewed-by: Dmitry Baryshkov Reviewed-by: Dmitry Baryshkov Signed-off-by: Manivannan Sadhasivam --- drivers/pci/controller/dwc/pcie-qcom.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index 01795ee7ce45..391a45d1e70a 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -1136,6 +1136,7 @@ static int qcom_pcie_post_init_2_9_0(struct qcom_pcie *pcie) writel(0, pcie->parf + PARF_Q2A_FLUSH); dw_pcie_dbi_ro_wr_en(pci); + writel(PCIE_CAP_SLOT_VAL, pci->dbi_base + offset + PCI_EXP_SLTCAP); val = readl(pci->dbi_base + offset + PCI_EXP_LNKCAP); @@ -1145,6 +1146,8 @@ static int qcom_pcie_post_init_2_9_0(struct qcom_pcie *pcie) writel(PCI_EXP_DEVCTL2_COMP_TMOUT_DIS, pci->dbi_base + offset + PCI_EXP_DEVCTL2); + dw_pcie_dbi_ro_wr_dis(pci); + for (i = 0; i < 256; i++) writel(0, pcie->parf + PARF_BDF_TO_SID_TABLE_N + (4 * i)); From patchwork Fri May 19 14:31:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 96458 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1282811vqo; Fri, 19 May 2023 07:33:59 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5zNeAf0v1k1r82hMRsRNq3Cal+jBz9Kk6gOWUnkqmWjWjz/oVaDd1VhqnFB9pS4AEjKtQ2 X-Received: by 2002:a17:902:6bc2:b0:1ae:6003:2de0 with SMTP id m2-20020a1709026bc200b001ae60032de0mr2363715plt.68.1684506839285; Fri, 19 May 2023 07:33:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684506839; cv=none; d=google.com; s=arc-20160816; b=o1ReLjjBVneq9W7nk+CoSiYmAqDVTENS7TIMBS1lQG21Vir4EOdfSuPiDQstgQQbUP j+mb52x7JFmU1Np2abu3IVXpJK8C7T+v0JCiFdphl+3s12gZMYnjCEoOfbW49vrHOUU6 t+VGjn4O8y1+i2Y4ljnmbF79JJQOLcgAnxKdfA6rOucGcEj3ts+aht4TJ3bfW0Zh67Xu BWC9fin3xmFa9/CSXfDI9bnmjubiPZ30kCRp3g3wtxyswk3Off+pT1HoIvGGi+XZ1+JK LN0Wl5z71tNnTKE2K+Wk6zyPvJuTIxFRrCzm6fEIzdQW0roUSD2IqU7qtZ3VAGMPY9jB IxXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WOZDrOTir9e0F4bCVCZsnAsCgh/6hBvQB7yeRVQtUHA=; b=RHfph04yYwVtuUPeQfFEK033NBeVOzQ5qQBpqkuNsp9DPvsDpSnfle2nO/jgj/9+WY yCtag2nx+bmEqxUA7OdQRFL+4s4Xt85eTvD1N/VcrpIpWtQuK4FZ/1zBjErXo9KW2dRv 2iHDkRAg33Z9Ek598t3Wl3Hl6yuQ/Gy8/ji/m9/h3gtEQSE0v0p8lXvnGPCiYX1JkrQw Imat0P3hMOk3TV0TrY5Vh41wLUJu/htvAu5r8tvSIYh890ZUgqRnH0La1VNooCoE2ZQv AYd/uFUFbmTx0b5B/1UYGMFm50N7YO5YkNQDgffHEnSBn+wduqkoFVs1d/beUtcyRXp0 rp2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=we37beDb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i16-20020a17090332d000b001ab197cb503si3933578plr.355.2023.05.19.07.33.43; Fri, 19 May 2023 07:33:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=we37beDb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230443AbjESObu (ORCPT + 99 others); Fri, 19 May 2023 10:31:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232095AbjESObq (ORCPT ); Fri, 19 May 2023 10:31:46 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30871E4C for ; Fri, 19 May 2023 07:31:42 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-64d1e96c082so1402405b3a.1 for ; Fri, 19 May 2023 07:31:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684506701; x=1687098701; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WOZDrOTir9e0F4bCVCZsnAsCgh/6hBvQB7yeRVQtUHA=; b=we37beDbxdZzher8V9DchuGEl11SJRpngPit9XLRgi3rTJwIZkIk60AT6f8eWHJEnx 9psGkdAb/ZNpOiy7/BpBMf6rVM0ZCXHa9Rd7+WzBb6M/P+AU1zozVZ5sgRM2kM92pUsp EY7d35qecwpZlpr3Vi3I7bAJKxMItsV2oZOxBQEHfn5cPMk1WjesqEzbtjRK0ETNL8kg 1bugU5bel6VYOgyX11W4bH2ps+b2e0UJtWD2KjRBLoN7ki/scD3bm2QPAapGgBvn7Jrz 30xhxDt6V/0Xpmh+L74Tsy4gmDDCPvyMN7tLbcaPWfu/KF2fVa1uNNeIoSFzGcZnb7Xl dzdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684506701; x=1687098701; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WOZDrOTir9e0F4bCVCZsnAsCgh/6hBvQB7yeRVQtUHA=; b=JIRBCKIjp+0uZorb44MSDqZHVufy6jbZ0/NS4rc8EdC8Nr3cvDOrxH+wsKjFM9Szh+ 7XlVyIcOa/tx/iR6dY0LnfKH+Bo04xdwzMdpRSJm6OFtnantlL2dwS8WgKM5x8Ud0jUs 2D0ydyDFJi8mU4zG97d2e+uts5If+IMhZ2K0wRBjYzuyPkRnYVjiBQZgDgUNDPQqPOdi vML8T5sGeleGdUeVNv9P4E1IMLLHR2s6rC9bsv+5rEjAkOtE7MZN8mSGxtF7cvh29E4q DNuEuqExjBt9WiqCH/57l5HbtGdyHo1GsSd4NoFpYjTMm6UNQ1CO0xsnCT6jp2BSAuIc Ic1g== X-Gm-Message-State: AC+VfDw+EMenGRaYbOEqPiudZqyZiUDKNEau0CmqQfbrIcbdWQ0XP+LF GdjG6wYVtpz8otG7+C/Y7SRP X-Received: by 2002:a05:6a20:d809:b0:109:f5f2:69a6 with SMTP id iv9-20020a056a20d80900b00109f5f269a6mr2282436pzb.5.1684506701321; Fri, 19 May 2023 07:31:41 -0700 (PDT) Received: from localhost.localdomain ([117.202.184.13]) by smtp.gmail.com with ESMTPSA id 30-20020a17090a09a100b00250d908a771sm1634845pjo.50.2023.05.19.07.31.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 May 2023 07:31:40 -0700 (PDT) From: Manivannan Sadhasivam To: lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com Cc: robh@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, steev@kali.org, quic_srichara@quicinc.com, dmitry.baryshkov@linaro.org, Manivannan Sadhasivam , Dmitry Baryshkov Subject: [PATCH v2 3/8] PCI: qcom: Do not advertise hotplug capability for IPs v2.7.0 and v1.9.0 Date: Fri, 19 May 2023 20:01:12 +0530 Message-Id: <20230519143117.23875-4-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230519143117.23875-1-manivannan.sadhasivam@linaro.org> References: <20230519143117.23875-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766333443781444808?= X-GMAIL-MSGID: =?utf-8?q?1766333443781444808?= SoCs making use of Qcom PCIe controller IPs v2.7.0 and v1.9.0 do not support hotplug functionality. But the hotplug capability bit is set by default in the hardware. This causes the kernel PCI core to register hotplug service for the controller and send hotplug commands to it. But those commands will timeout generating messages as below during boot and suspend/resume. [ 5.782159] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x03c0 (issued 2020 msec ago) [ 5.810161] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x03c0 (issued 2048 msec ago) [ 7.838162] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x07c0 (issued 2020 msec ago) [ 7.870159] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x07c0 (issued 2052 msec ago) This not only spams the console output but also induces a delay of a couple of seconds. To fix this issue, let's clear the HPC bit in PCI_EXP_SLTCAP register as a part of the post init sequence to not advertise the hotplug capability for the controller. Signed-off-by: Manivannan Sadhasivam Reviewed-by: Dmitry Baryshkov Reviewed-by: Dmitry Baryshkov Signed-off-by: Manivannan Sadhasivam --- drivers/pci/controller/dwc/pcie-qcom.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index 391a45d1e70a..8f448156eccc 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -270,6 +270,20 @@ static int qcom_pcie_start_link(struct dw_pcie *pci) return 0; } +static void qcom_pcie_clear_hpc(struct dw_pcie *pci) +{ + u16 offset = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP); + u32 val; + + dw_pcie_dbi_ro_wr_en(pci); + + val = readl(pci->dbi_base + offset + PCI_EXP_SLTCAP); + val &= ~PCI_EXP_SLTCAP_HPC; + writel(val, pci->dbi_base + offset + PCI_EXP_SLTCAP); + + dw_pcie_dbi_ro_wr_dis(pci); +} + static void qcom_pcie_2_1_0_ltssm_enable(struct qcom_pcie *pcie) { u32 val; @@ -966,6 +980,13 @@ static int qcom_pcie_init_2_7_0(struct qcom_pcie *pcie) return ret; } +static int qcom_pcie_post_init_2_7_0(struct qcom_pcie *pcie) +{ + qcom_pcie_clear_hpc(pcie->pci); + + return 0; +} + static void qcom_pcie_deinit_2_7_0(struct qcom_pcie *pcie) { struct qcom_pcie_resources_2_7_0 *res = &pcie->res.v2_7_0; @@ -1272,6 +1293,7 @@ static const struct qcom_pcie_ops ops_2_3_3 = { static const struct qcom_pcie_ops ops_2_7_0 = { .get_resources = qcom_pcie_get_resources_2_7_0, .init = qcom_pcie_init_2_7_0, + .post_init = qcom_pcie_post_init_2_7_0, .deinit = qcom_pcie_deinit_2_7_0, .ltssm_enable = qcom_pcie_2_3_2_ltssm_enable, }; @@ -1280,6 +1302,7 @@ static const struct qcom_pcie_ops ops_2_7_0 = { static const struct qcom_pcie_ops ops_1_9_0 = { .get_resources = qcom_pcie_get_resources_2_7_0, .init = qcom_pcie_init_2_7_0, + .post_init = qcom_pcie_post_init_2_7_0, .deinit = qcom_pcie_deinit_2_7_0, .ltssm_enable = qcom_pcie_2_3_2_ltssm_enable, .config_sid = qcom_pcie_config_sid_1_9_0, From patchwork Fri May 19 14:31:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 96466 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1288872vqo; Fri, 19 May 2023 07:43:54 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4ZYySyKeLHjgho9VtwrqKA0mhKo6x3So+El+NRbTGYcUptAcnanCLkWLc4Rkov84nYB6BH X-Received: by 2002:a05:6a21:9201:b0:ff:b564:c532 with SMTP id tl1-20020a056a21920100b000ffb564c532mr2156991pzb.43.1684507433848; Fri, 19 May 2023 07:43:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684507433; cv=none; d=google.com; s=arc-20160816; b=ILhsQNUCXrLBIV6PMBEwiGZy8TIvrsA+gsxcXXyp9p7qvcPXYVrtw4rKSefBLOjeAp iH5/UxVLzF2Wxcu676YDxVzxiXPEMRY1DT0eSOaLVbw+zluXMakWsvmoc7p27Yv8H7Rq PPKqEzjmHyZlHS0HTB1MJ9ymlXAPuq+IN05EgwRFAiyGtaPStvue5dvH8OguJ7dQGyLn aBDiL+bMroxX+fh5OO8ukx16q/Jcx0fK91aLegG+VwNveflONblHihp9bs2BfIyLB8tL SF4Qdz7Bvhai9ar60Xzcxw51YnEnoOtS3D0I450lG8aAkhyjvDbVp9w6YT7HjOOvvGFz nanQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=XrAhSKm9IAEYF8Oyjbiqm3Kr+qbE8wWoowYF4lezkew=; b=GONPxQMtNUY56Th2G/Vd0H8FlGyxOTSCM4EOMbtRdRvY6WHeU5PmUDRIxlnWFPDxxs LJIztt0rdZqbHuivs9gGwJrar9vaitECAJXDrrLDTEtVURWrRdtOTnz/cDk/MO9SgBY+ aGLz2q9uWdFO+fbPzD0jT+wT24XIbiQXMU6A5o3CQxOJnL/XiSqk4KUJeQoDVoN7D5f5 9/zI99vap7hSoZXsHwCFl/Mraqyv1tc9EFmRf7a+D77tP76vg51X1/P+di2Da85Lg8JN YbRtMKZiU+RAFFeFXDxIvW5lgEjRQIFa4BSTsokyDZ+B0ut3osP4K/o/mUxY2d++t5QG aHxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KrcnnE6W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u7-20020a637907000000b0052868a865d8si3618303pgc.430.2023.05.19.07.43.37; Fri, 19 May 2023 07:43:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KrcnnE6W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232110AbjESObz (ORCPT + 99 others); Fri, 19 May 2023 10:31:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231270AbjESObv (ORCPT ); Fri, 19 May 2023 10:31:51 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 400E8E6E for ; Fri, 19 May 2023 07:31:46 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-2537a79b9acso740526a91.3 for ; Fri, 19 May 2023 07:31:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684506706; x=1687098706; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XrAhSKm9IAEYF8Oyjbiqm3Kr+qbE8wWoowYF4lezkew=; b=KrcnnE6Wy/j+Lu+0KD+I+VhZ7oQ96BPjFWTBQRcrDn0wqWCgVq//p5S6asE3gSyO2g PR9PzAxR8EcT8dAX+TNlWf9A9j6imlLIkibmMF3TJKRUE7bQ6/HBFaU4W14WzoRE6cd0 cMEFO5chTTYJzeMcGVJfSygLu1gBxSBkMk3V3o3WovOM9ZbkAo8xUbfT1AeBAjYBpQVj XFsdWFMIUSWnwbzr4F4kydFnSFnQmY84QIah/oi0ogLjxvwRtIt3VwDhvBLuCm+Z6Csv Uz2Ca5Qt80eeyEjfAXvxSrBr+dInUR+GSUC6qk15B53QtJrxniNtZiqQyVXbUg202R3P LctQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684506706; x=1687098706; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XrAhSKm9IAEYF8Oyjbiqm3Kr+qbE8wWoowYF4lezkew=; b=HwxBpozKopy5IBoxe33FO9RmgTGP8+QzUCdiO3sDEUd4R1nA24vtkjYjjxOkCds9E1 kApZXIM3yZ0OSnCKHic8HIFDcYJAbpKTDcCo992vGnT17P5T2Ftq6//p4rzsG9+QOoxu 8H/RFLMzjiKnm9MbYNyYCWAsiU73cbO8y5xEjUuZRx/S6AUkkIlsMxg5UAEdxQnWChsQ tQuXBcsLJYzs8Y5l9BVOChtkZpe9OzkhdaDE6JBho6dKTVnV4ZUHbsseNejAXVn0PISG 6qXa+n/12sJfMn8SI7K3ekpeVuF/+t5WW321mopHn/PV/7b4/CHceJfHygJm0OhJaqnt Gyjg== X-Gm-Message-State: AC+VfDx1F72+lcegzVomuwdWrX/spEYag5iM8uzpY8snykMaccjqEEn1 naWBI0hahZtEiLNyucZ8v3+4 X-Received: by 2002:a17:90b:615:b0:253:4799:75de with SMTP id gb21-20020a17090b061500b00253479975demr2282602pjb.37.1684506705919; Fri, 19 May 2023 07:31:45 -0700 (PDT) Received: from localhost.localdomain ([117.202.184.13]) by smtp.gmail.com with ESMTPSA id 30-20020a17090a09a100b00250d908a771sm1634845pjo.50.2023.05.19.07.31.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 May 2023 07:31:45 -0700 (PDT) From: Manivannan Sadhasivam To: lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com Cc: robh@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, steev@kali.org, quic_srichara@quicinc.com, dmitry.baryshkov@linaro.org, Manivannan Sadhasivam , Dmitry Baryshkov Subject: [PATCH v2 4/8] PCI: qcom: Do not advertise hotplug capability for IPs v2.3.3 and v2.9.0 Date: Fri, 19 May 2023 20:01:13 +0530 Message-Id: <20230519143117.23875-5-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230519143117.23875-1-manivannan.sadhasivam@linaro.org> References: <20230519143117.23875-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766334066913473900?= X-GMAIL-MSGID: =?utf-8?q?1766334066913473900?= SoCs making use of Qcom PCIe controller IPs v2.3.3 and v2.9.0 do not support hotplug functionality. But the hotplug capability bit is set by default in the hardware. This causes the kernel PCI core to register hotplug service for the controller and send hotplug commands to it. But those commands will timeout generating messages as below during boot and suspend/resume. [ 5.782159] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x03c0 (issued 2020 msec ago) [ 5.810161] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x03c0 (issued 2048 msec ago) [ 7.838162] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x07c0 (issued 2020 msec ago) [ 7.870159] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x07c0 (issued 2052 msec ago) This not only spams the console output but also induces a delay of a couple of seconds. To fix this issue, let's not set the HPC bit in PCI_EXP_SLTCAP register as a part of the post init sequence to not advertise the hotplug capability for the controller. Signed-off-by: Manivannan Sadhasivam Reviewed-by: Dmitry Baryshkov Tested-by: Sricharan Ramabadhran Reviewed-by: Dmitry Baryshkov Signed-off-by: Manivannan Sadhasivam --- drivers/pci/controller/dwc/pcie-qcom.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index 8f448156eccc..64b6a8c6a99d 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -140,7 +140,6 @@ PCI_EXP_SLTCAP_AIP | \ PCI_EXP_SLTCAP_PIP | \ PCI_EXP_SLTCAP_HPS | \ - PCI_EXP_SLTCAP_HPC | \ PCI_EXP_SLTCAP_EIP | \ PCIE_CAP_SLOT_POWER_LIMIT_VAL | \ PCIE_CAP_SLOT_POWER_LIMIT_SCALE) From patchwork Fri May 19 14:31:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 96459 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1283080vqo; Fri, 19 May 2023 07:34:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6KU0Y3fJBX1k0E3ova68tsYZPTkjg4X3l3TQKSCEv2CuPv3YuD/0KRyPttcatWqBqgyrMu X-Received: by 2002:a17:902:ab14:b0:1ae:50cc:45b with SMTP id ik20-20020a170902ab1400b001ae50cc045bmr2917792plb.36.1684506861278; Fri, 19 May 2023 07:34:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684506861; cv=none; d=google.com; s=arc-20160816; b=avUyIg+Ei1Pu5HcWHn2QcfD58RuCl2L1e1IGw9yZiw6JKmou1/ruG3y/yg2+FgR1tx ioLI78eVRAAVPn2BruWp9kam16infCM9DMksZdA3iGgYY+aaYfMXNC363EO5KngjLHF9 +41B4m918Pp/Q3XVw0/TZBUoCF0DefLm6MrWqYyCMDxe1TtJxKROEDMOoYOy0gN7KwJA GfMrmiYbC7Byq2hqfULCjqNyLDabyyAN2d5FKdbTspvFKbwCs3U20knv+aUXZx6pgJcR iyvWKwa/pdwltT0/QaskIJ+ghbRTm0El2OdJopVqgotmfoKzcMSyHUEnVZ+i/WtMB/tK YrgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ltCiTsDOD5ydUGLVe1beQMJS2WLXn803YOi09x8rHPs=; b=qNUPwlRluKNLK/j4S3lL/P7uokZQvVl15M/WZIXhAfQPe6e1bx3JIscKP5g1Jpz8/3 b9iDNzSiaegK/bsPF7U8ZKy7S4tsiiW222RU5A14Vj6wA98XJWob2ZVO3BOjs8bTLiMv AwF47TEJ7TSCtOJgOuWeysH3SWlkfIoaym3w4U8swtu4O4RjMMXnqM7RgciVfhQFPRZa ziRXSYOqF9arRhCYdQsHUtDzP0RrxQsGLaeXjRIt7eOqkKdAiVF9YUtc9jVq7n/KH77u E1gUA2F8fT/3UY2d8aapCSPvZfpieA4eudXIBnRShMUauUXiImdkkR+x+C+GMLkZCNgD hPXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gQWUuVaD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c9-20020a170902d48900b001aafecaa768si3707670plg.641.2023.05.19.07.34.05; Fri, 19 May 2023 07:34:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gQWUuVaD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232119AbjESOcK (ORCPT + 99 others); Fri, 19 May 2023 10:32:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231605AbjESOcG (ORCPT ); Fri, 19 May 2023 10:32:06 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CC4210C6 for ; Fri, 19 May 2023 07:31:51 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-253570deb8dso1882521a91.1 for ; Fri, 19 May 2023 07:31:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684506710; x=1687098710; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ltCiTsDOD5ydUGLVe1beQMJS2WLXn803YOi09x8rHPs=; b=gQWUuVaDxxDTizHCkkO1/6gcVHEDp/mB5yqDC3TfWP7Fy3j5eOoKhO9nUnfQftuVUW glEciq+vVyZOr+muKVCJDD6rsrEjdL0T7IfXdTNgIJQdZDkrpkXIEkMXoC2dEUX4gscv M1p+6xA2fz3U3C7hBiGQawUHl3ZEz80VP1kF/48p+1gLzdujCycYixiFFoblrT/xvuqM 0CHCS/fWvyQs+6GeCDlN+no4+5p3e2kVcwRgHZRXF1MTlmPvDa4Rwc8xUaxezckaFZCd zMLl77GFhg15MpgG0luVujSn7dtDGisw+dm1F3AWCraB4nS2WD7b4AK2YY6s2CAVQTIH vFqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684506710; x=1687098710; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ltCiTsDOD5ydUGLVe1beQMJS2WLXn803YOi09x8rHPs=; b=ATI10h9LwhJun5OTHyIMK2nXA8BdRxZiRqTKJXBg8rX5c4xd7Dd3nD7FrUSRgnbgkl DZddzkN5yOvUKmeHC4Jq4565vLhI1fKkGFVj4EwiwokBdJ4DfI8UjrMKLJXwioxyTSCE XmtnH/ga+ZoS4UpmWwvsHsBh3rSCqfTWO+LgJhGlKnN9figGq0NpHQRhiHIyG5CHu84e M8DdgOFhRmaSMMVu3W3sBBCST+SXSVrvZ084dvGSKBLK+qkapHOC1HaWm40Yt8oUc1m4 3eVIGjk14clOOfzeP92LuNTXyK6lYGqavbitw3GM6/VD38YkT3ydYn5hk9vfETCG3i71 jF4w== X-Gm-Message-State: AC+VfDxTOwKJ1O9EYD9QxSDrAKDbveXOXuEHUdCVO/wBJ7sD6R5fK4EW kJ0sIHlJmtqmG6k+9U5beJa3 X-Received: by 2002:a17:90a:64c4:b0:253:749d:205 with SMTP id i4-20020a17090a64c400b00253749d0205mr2020724pjm.35.1684506710307; Fri, 19 May 2023 07:31:50 -0700 (PDT) Received: from localhost.localdomain ([117.202.184.13]) by smtp.gmail.com with ESMTPSA id 30-20020a17090a09a100b00250d908a771sm1634845pjo.50.2023.05.19.07.31.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 May 2023 07:31:49 -0700 (PDT) From: Manivannan Sadhasivam To: lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com Cc: robh@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, steev@kali.org, quic_srichara@quicinc.com, dmitry.baryshkov@linaro.org, Manivannan Sadhasivam Subject: [PATCH v2 5/8] PCI: qcom: Do not advertise hotplug capability for IP v2.3.2 Date: Fri, 19 May 2023 20:01:14 +0530 Message-Id: <20230519143117.23875-6-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230519143117.23875-1-manivannan.sadhasivam@linaro.org> References: <20230519143117.23875-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766333466369879913?= X-GMAIL-MSGID: =?utf-8?q?1766333466369879913?= SoCs making use of Qcom PCIe controller IP v2.3.2 do not support hotplug functionality. But the hotplug capability bit is set by default in the hardware. This causes the kernel PCI core to register hotplug service for the controller and send hotplug commands to it. But those commands will timeout generating messages as below during boot and suspend/resume. [ 5.782159] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x03c0 (issued 2020 msec ago) [ 5.810161] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x03c0 (issued 2048 msec ago) [ 7.838162] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x07c0 (issued 2020 msec ago) [ 7.870159] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x07c0 (issued 2052 msec ago) This not only spams the console output but also induces a delay of a couple of seconds. To fix this issue, let's clear the HPC bit in PCI_EXP_SLTCAP register as a part of the post init sequence to not advertise the hotplug capability for the controller. Signed-off-by: Manivannan Sadhasivam --- drivers/pci/controller/dwc/pcie-qcom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index 64b6a8c6a99d..9c8dfd224e6e 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -616,6 +616,8 @@ static int qcom_pcie_post_init_2_3_2(struct qcom_pcie *pcie) val |= EN; writel(val, pcie->parf + PARF_AXI_MSTR_WR_ADDR_HALT_V2); + qcom_pcie_clear_hpc(pcie->pci); + return 0; } From patchwork Fri May 19 14:31:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 96462 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1286226vqo; Fri, 19 May 2023 07:39:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7RA0X7Xyfnn5hVbp4AAihOgowsZ1JyKc0JvTq+O+JpvBzmTcTPF7db5iPS8FX9VhR4d/1x X-Received: by 2002:a17:90a:6484:b0:253:971b:dd1a with SMTP id h4-20020a17090a648400b00253971bdd1amr362693pjj.9.1684507160992; Fri, 19 May 2023 07:39:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684507160; cv=none; d=google.com; s=arc-20160816; b=0lJxILD4DUId+GEi70qh0ctBgAXRBJP58i5m6Vj/erq6idoANG8oSX5Klgr7e5OyEo Jx395b2H2jvAtWtKAHJrCe7tXLEU4YlgU4/0UcUJ0222MI+PrHqTCWNxNCEv4OV4Hh45 UTqFem3zE2WOpT0t4afGeJ4oaUwTqSmS+WExKf5fsxsuVJOPuPP1+XdPLUXtWy5+nRTU 6joOBpQr8YDr/LmRsJsfN6vBDuF3a88gUwPUMMvgJ7naBnJ/qVi8tEVNU/u1TsTI5nU/ 5Z79L+qBm26t3w5ZxtaS9XKQSwjQfKrJ3F8odS/6pgkoiqPIa4sQ9cxnQA7VQiDD/6a4 gfZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dvVFJ4eRpjyBD7o1HP/7PTjD9zFytoFdbjvNe70Jf18=; b=Mhj9fTh1KFcpnoYLUqwYuUfK1jw0uRn7NBUc9SRawxNUZoN7NgyiqhCsElHHjJulgm uzwKzQsHMtIGolh69lOXZ6ADa/SriMWx0jMsZdyDVQKqxsoozY7pVOwOMpMCdRyEKQP8 kvYdgkRN9J2Zsfsh2+7ioDVK8Zxx+xwbjBsqYJW9s6XroHSls8qeUTEazcccaeT+aoPj mspSW/Ureyj9z5a+em8itLA34ivIUrHSRnJYelxuYRa+HPRPuYbOBJZbxpmk1ICcwEGt Teu8PWFp4CAljGR1Uunl4/XD0IUcaDYAdbK0ZM67pzmxiLpraE7xyIWSUpl0zCkCwgbh h4Ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AdxIfjDB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w190-20020a6382c7000000b00517a9e737c6si3934939pgd.311.2023.05.19.07.39.07; Fri, 19 May 2023 07:39:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AdxIfjDB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232146AbjESOcZ (ORCPT + 99 others); Fri, 19 May 2023 10:32:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232114AbjESOcP (ORCPT ); Fri, 19 May 2023 10:32:15 -0400 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6F3A10F9 for ; Fri, 19 May 2023 07:31:55 -0700 (PDT) Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-51b33c72686so2280505a12.1 for ; Fri, 19 May 2023 07:31:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684506714; x=1687098714; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dvVFJ4eRpjyBD7o1HP/7PTjD9zFytoFdbjvNe70Jf18=; b=AdxIfjDB8oHYMT8BNQcI8I8vVWjb1AfM/+816qqd/x0qvfPR2KXnBKApE6Q+FBrr0U r37dmu4filLwW+pM9i1TioIViH5fShG18gOY65UmdFI8igf//YL/9C1KoORjmUqINm0S zx4OCwg7YHS+5CRb7SBwRaT0VWuHBCYNJPPCn8TPhJcQTb3ERTAZnM2OOYUFp2jhW4j6 TbPljLSL6rU/vToH98Y7X5O5Aag/trWty75RKQYIpm8ip3B4ruUNdQdP8LKQoWWg3d1O 1BxEP/RIjvo8J1aKZgHfbTbZ7FbbZLggU5FHxT4928Y2qiBB4WtkENX2IBSi0MWHfzlS tl8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684506714; x=1687098714; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dvVFJ4eRpjyBD7o1HP/7PTjD9zFytoFdbjvNe70Jf18=; b=SQZ1/qamiiLTAq1O6POFpUEn3EMI/g5/x1Tp/SCqubRW1lQNSN0lDcNaWiUQCI1BFM 7EPTGYCmZU0+yUVbkigl6V7S/Wc8z7zETqoFlQlS8OB71R5A4rSJXrgDDaHdJyVF9Qdu hroTHieqLwt1+poaC+1sRMk4i/80szZqv8u9hug1qAhDBXb7wTu4KaKlRd5FClQoY1W3 xpUS+fhet2aOQV7upAMCXAbsnIwNaJcBzr3HIwnqLFAx3SOsygf0zTrn8keTa7dBmdFs 8BkVdzN8V43j4UrBtbehnlxhhcjXzrfyObwhIW2AoNQPA9tGS2Xy2id2lFYe5Yb5k5/h Tw/w== X-Gm-Message-State: AC+VfDzJSt+HdL2Fnp4P1Wrum9JtSyc16wWiE/uy7FOhnoTyX+O2LQAk vwvysdYhqbZcP15YiNyCggX+ X-Received: by 2002:a17:90b:3d6:b0:24f:13ec:ecac with SMTP id go22-20020a17090b03d600b0024f13ececacmr2383045pjb.26.1684506714700; Fri, 19 May 2023 07:31:54 -0700 (PDT) Received: from localhost.localdomain ([117.202.184.13]) by smtp.gmail.com with ESMTPSA id 30-20020a17090a09a100b00250d908a771sm1634845pjo.50.2023.05.19.07.31.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 May 2023 07:31:54 -0700 (PDT) From: Manivannan Sadhasivam To: lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com Cc: robh@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, steev@kali.org, quic_srichara@quicinc.com, dmitry.baryshkov@linaro.org, Manivannan Sadhasivam Subject: [PATCH v2 6/8] PCI: qcom: Use post init sequence of IP v2.3.2 for v2.4.0 Date: Fri, 19 May 2023 20:01:15 +0530 Message-Id: <20230519143117.23875-7-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230519143117.23875-1-manivannan.sadhasivam@linaro.org> References: <20230519143117.23875-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766333780757636462?= X-GMAIL-MSGID: =?utf-8?q?1766333780757636462?= The post init sequence of IP v2.4.0 is same as v2.3.2. So let's reuse the v2.3.2 sequence which now also disables hotplug capability of the controller as it is not at all supported on any SoCs making use of this IP. Signed-off-by: Manivannan Sadhasivam Reviewed-by: Dmitry Baryshkov Signed-off-by: Manivannan Sadhasivam --- drivers/pci/controller/dwc/pcie-qcom.c | 30 +------------------------- 1 file changed, 1 insertion(+), 29 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index 9c8dfd224e6e..e6db9e551752 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -703,34 +703,6 @@ static int qcom_pcie_init_2_4_0(struct qcom_pcie *pcie) return 0; } -static int qcom_pcie_post_init_2_4_0(struct qcom_pcie *pcie) -{ - u32 val; - - /* enable PCIe clocks and resets */ - val = readl(pcie->parf + PARF_PHY_CTRL); - val &= ~PHY_TEST_PWR_DOWN; - writel(val, pcie->parf + PARF_PHY_CTRL); - - /* change DBI base address */ - writel(0, pcie->parf + PARF_DBI_BASE_ADDR); - - /* MAC PHY_POWERDOWN MUX DISABLE */ - val = readl(pcie->parf + PARF_SYS_CTRL); - val &= ~MAC_PHY_POWERDOWN_IN_P2_D_MUX_EN; - writel(val, pcie->parf + PARF_SYS_CTRL); - - val = readl(pcie->parf + PARF_MHI_CLOCK_RESET_CTRL); - val |= BYPASS; - writel(val, pcie->parf + PARF_MHI_CLOCK_RESET_CTRL); - - val = readl(pcie->parf + PARF_AXI_MSTR_WR_ADDR_HALT_V2); - val |= EN; - writel(val, pcie->parf + PARF_AXI_MSTR_WR_ADDR_HALT_V2); - - return 0; -} - static int qcom_pcie_get_resources_2_3_3(struct qcom_pcie *pcie) { struct qcom_pcie_resources_2_3_3 *res = &pcie->res.v2_3_3; @@ -1276,7 +1248,7 @@ static const struct qcom_pcie_ops ops_2_3_2 = { static const struct qcom_pcie_ops ops_2_4_0 = { .get_resources = qcom_pcie_get_resources_2_4_0, .init = qcom_pcie_init_2_4_0, - .post_init = qcom_pcie_post_init_2_4_0, + .post_init = qcom_pcie_post_init_2_3_2, .deinit = qcom_pcie_deinit_2_4_0, .ltssm_enable = qcom_pcie_2_3_2_ltssm_enable, }; From patchwork Fri May 19 14:31:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 96464 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1288159vqo; Fri, 19 May 2023 07:42:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7ZDh40H70xLCChghZ7A4PZ6e8h5J0/9OcDzbC9LMNDLgNBfdasjMHx2GzQn9D4vjLK513N X-Received: by 2002:a05:6a20:440e:b0:101:2ad0:134c with SMTP id ce14-20020a056a20440e00b001012ad0134cmr2838180pzb.45.1684507360166; Fri, 19 May 2023 07:42:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684507360; cv=none; d=google.com; s=arc-20160816; b=JPsY0j75PC9VGzTaiixRl/v8nhAas5dpIxXf54rQe4+VkmYQl3ZC/3cdiO4J01o4mu 9H9NyaOH0GCcPlLvcAC4DD1lPhXAToJd53EkdO8jt5lYDdthycP96QqhtqfWC4TN16bl Lft/YWmS73uSYD2nemYps5qdGUEyfpctVKGtLbBSjThuQF4nOAFTICf9leMr41lO2GCI eKG7TlDuCBHJJi0/+Oj9LSVHw5rEMLFZwK7wmpW+z99PE0QQl3nqdkJDnf0dial4HQAW eitMVyGFgQYw1Vdrk4IlPQfMBE3z6zWDFJZSTzaEYFT5Gk0TUAX/2Cz4bGWAO7yRSWS8 IyjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bkQkFXSrqR5MDMbqBcH7Nxin9P2rGGa9soJkqC/yxfY=; b=aIrWQf6EgG7OCQw2NCAkBHIBJJocPw0rDI/+1+lVJCvITAcFOlHoSsaangF6evRLX0 Pj6SmsXRwWF2OJY9w7aY9OTE/1ksmR9KehfmCaFwVbMHyU4NRYdL0AeJGyiIoJ8snPRu Ae1P1ZxzkVOA6z+x3koqW51ckjQ23FJuCGrZiGa+f/ER7YoSPbsDCMubhlC1eUd+Knuq O5S3fqM+UJh2ZQrdg2eqmLoUsNFrAeDnaJCL7y9cRLma3I8ofqRGvNDcj2ZNuyr0RsvX HNVvZKC6pcXebPvFJZKpy1Bb4IjOYgMlig1RFxVoLfk18DkLYJxYdTTGnfkHEfRMqHKj z6KA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="bwm/X4pM"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f28-20020a63755c000000b005342480fcd2si3813988pgn.282.2023.05.19.07.42.27; Fri, 19 May 2023 07:42:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="bwm/X4pM"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229933AbjESOce (ORCPT + 99 others); Fri, 19 May 2023 10:32:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232127AbjESOc1 (ORCPT ); Fri, 19 May 2023 10:32:27 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 579811727 for ; Fri, 19 May 2023 07:32:00 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-2536b4b3398so1522389a91.3 for ; Fri, 19 May 2023 07:32:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684506719; x=1687098719; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bkQkFXSrqR5MDMbqBcH7Nxin9P2rGGa9soJkqC/yxfY=; b=bwm/X4pMr8MwYBpFxgbtrdPEnQVZlktmQcTkB5+TrS8zlCJkEN8VDgewXp8Ju/XmsW mobigOKrqd9SV8PvXBlhoPTyVhviDEV/X5tvPoZcG7SQSDEtVrB5SKFi50u+ATW1k61k oLdabeZhinepamdwCimBMJjcOVb0DTPdK3R0eVrNpt4M8hQ8DZVhwz3gAq3Jwxle6E6/ KUTsDj3ReTi0IVug0CTJxF3n+zApxOsazseIcWr30rl4JA4KzXosl6O57j7B1JKTL0Zf A0U9p9GQ3P5mosV8zHs6YZO8DrMqALXEybry6CV0Ad1eLs5h2UjgqZf7twHncsie+rTn RCnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684506719; x=1687098719; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bkQkFXSrqR5MDMbqBcH7Nxin9P2rGGa9soJkqC/yxfY=; b=jefzzTjuL/pUqN2Wo8K2YporCCkVhqZK7mIuYU7hNp49cpCSMlE19pzyjN1Dg6sboE 0yb3KVZK6joADXSZAdY1ZzBQOsLtH29IfwrMfvY4rgXhXupOx/ZAGMUNWRen2fTdgL6a G3PR6i6AdbEz65jzGCJHRFZSJnBuyJOpNSXT+60VNJEIzPB5NRLA/N5ldQM0ev89uZGo CNe+WlEE8H6NgwqhvJs9uIkHPVHaRjMcN5/fZyh4HkknZFvRHFCVRLd47q4TKVyudixn R+uMw2l06TVJUWgHsu4+0oMwwTz2UWqVwMmC8zK4nCgHFUK0Up6f0a/0BfnktOTkKJxO 6gNQ== X-Gm-Message-State: AC+VfDzf7rJ7Se8mADHQurBbnVExwtSJjfwPSxnMXEmr9uATBVgTl7x0 hJ39e1hnz+kA3H2ZMfAHGOc0 X-Received: by 2002:a17:90b:46c1:b0:250:4847:426a with SMTP id jx1-20020a17090b46c100b002504847426amr2284620pjb.11.1684506719250; Fri, 19 May 2023 07:31:59 -0700 (PDT) Received: from localhost.localdomain ([117.202.184.13]) by smtp.gmail.com with ESMTPSA id 30-20020a17090a09a100b00250d908a771sm1634845pjo.50.2023.05.19.07.31.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 May 2023 07:31:58 -0700 (PDT) From: Manivannan Sadhasivam To: lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com Cc: robh@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, steev@kali.org, quic_srichara@quicinc.com, dmitry.baryshkov@linaro.org, Manivannan Sadhasivam Subject: [PATCH v2 7/8] PCI: qcom: Do not advertise hotplug capability for IP v1.0.0 Date: Fri, 19 May 2023 20:01:16 +0530 Message-Id: <20230519143117.23875-8-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230519143117.23875-1-manivannan.sadhasivam@linaro.org> References: <20230519143117.23875-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766333989486010976?= X-GMAIL-MSGID: =?utf-8?q?1766333989486010976?= SoCs making use of Qcom PCIe controller IP v1.0.0 do not support hotplug functionality. But the hotplug capability bit is set by default in the hardware. This causes the kernel PCI core to register hotplug service for the controller and send hotplug commands to it. But those commands will timeout generating messages as below during boot and suspend/resume. [ 5.782159] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x03c0 (issued 2020 msec ago) [ 5.810161] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x03c0 (issued 2048 msec ago) [ 7.838162] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x07c0 (issued 2020 msec ago) [ 7.870159] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x07c0 (issued 2052 msec ago) This not only spams the console output but also induces a delay of a couple of seconds. To fix this issue, let's clear the HPC bit in PCI_EXP_SLTCAP register as a part of the post init sequence to not advertise the hotplug capability for the controller. Signed-off-by: Manivannan Sadhasivam --- drivers/pci/controller/dwc/pcie-qcom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index e6db9e551752..612266fb849a 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -521,6 +521,8 @@ static int qcom_pcie_post_init_1_0_0(struct qcom_pcie *pcie) writel(val, pcie->parf + PARF_AXI_MSTR_WR_ADDR_HALT); } + qcom_pcie_clear_hpc(pcie->pci); + return 0; } From patchwork Fri May 19 14:31:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 96465 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1288748vqo; Fri, 19 May 2023 07:43:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5l6qPrgJqPr5KXHFOnXoNtOvpnZGo5+dzetIBhGreBt9gbymCkP3a5KBpxRGxR7YyzioYh X-Received: by 2002:a17:902:ee8d:b0:1ac:8ad0:1707 with SMTP id a13-20020a170902ee8d00b001ac8ad01707mr3362334pld.1.1684507419067; Fri, 19 May 2023 07:43:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684507419; cv=none; d=google.com; s=arc-20160816; b=b7e8YJCqOuTxhyXjTdvFPuoiu4RxSMAfcDLxfV5tsCk+VBfrAfkzcm1X47AQiD4PXx qOpx94VbbrBMvCWjDX5ifg2MZKh1zj/raDYkCxeBKu8nbtGvZL9BQJZWqsjamwvUG5rL 5DatpN7dif+iSXtP+dAcyc2T/ey5sPC3PA6CWl7hkTRVXJnaOtLFuUBVrfujFyeEZ4Zm YcHjlIrV7aa/pMRyUMDsnSbM0OAne6a87y9mGrda/EQbzm+Qc7FJMgrW5uj0RCWpRihA IE16IKbeSAsUINcHQ/1SaoZFiKtB4a+39lYpxJaY7AC0y0GmYIdqRjirVnmIPD5vjG6R qnPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=BAHgbKUGLDFGyzp+XWYZ2sseIunYBsYQIO/Xldf05CU=; b=ZXY4YCRroYLfY+gKcMXp3ieu/nPp6v/2tTv9fH+5MO6Tm3B4FQ+ExEPGj+KjgqPqvT jJMCRL3NyyzRHJP1+P6+058MCpNOmC/V2v0cLJT0+7WRLj18++wY8/5JMByzPWRz8Rq5 TVjNfVOWbNY7LBxk31AfnF/o8eh049Gi0QZ0tJ+m0eFNBrWwqQnUz2whZsmuAZyyLuwa bCqwB3RdSrbjSVRCodQ60kmlqHq1J0vy7XkhJcvPRXziAmocwYtXKmfKtcaGkUv2nSNM V5WATMYbp1Unw/1OQoLL9KeTJcqz5Ui3Ln9a/W/vpfMp8O6k0VhOGey5aRxHBOMPhQxf 7GhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GvXGvNsa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l7-20020a170903120700b001a96b39bb35si3841410plh.439.2023.05.19.07.43.24; Fri, 19 May 2023 07:43:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GvXGvNsa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231837AbjESOco (ORCPT + 99 others); Fri, 19 May 2023 10:32:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231906AbjESOck (ORCPT ); Fri, 19 May 2023 10:32:40 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39C64E60 for ; Fri, 19 May 2023 07:32:11 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id 98e67ed59e1d1-2537909d28cso777896a91.0 for ; Fri, 19 May 2023 07:32:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684506723; x=1687098723; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BAHgbKUGLDFGyzp+XWYZ2sseIunYBsYQIO/Xldf05CU=; b=GvXGvNsaT7/5inshDPfJkzj0LWRNaGcBA3Ja8kveCoTlHDPcoyIo62P2bRx/jlufmp 5ND1hfWqZ7qMQbxbjvT19uSrYM0qycwqu++VsvfHja0ofRz2g7WzSIH++lohamsrwWPb Br1/35TWmItJVR+41jgSKnCl3ru/XHdzFuDiK5bDf6mnriLKSA1rb9+65F539O96rYE7 P1ke++e4vMO58Phpz29rS6is6e3cq/pWnWpDOy0OcoBJF/VIZ18TEawpwD99DUmfJ0qn F05QWqEXVVDUhjJjK2pS8vHBlekfiChQhY6Tnoh1M09SlNCw6pWJqsoChpm5ggulP3wY 82Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684506723; x=1687098723; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BAHgbKUGLDFGyzp+XWYZ2sseIunYBsYQIO/Xldf05CU=; b=OFMirUBNDFYXt8gsp5jtyGQQJygao3pjjjFZApI1Itq/Rt87USGGra5sJ7kGlo9yKq dN72hPhCh1V1GgPLSe+uQjjvIFD8/ei+ML6gwCrxpHs0L/YWKS4DjL7Ia1mh0HdrpIxK FoE0EXQQzc0hExiKPg3A1TMRJ0wsE5G8/PtR2W9vJ1nCfJnQgVVoYItUMbebQQ4xR2wz cPzgCETPpDz8GG+q01+MRH/jLEIqwvfALQk/9IIqUKi9qNy3e46munn5HfJsxH28PY6R 2FKAinf2LGgF9SfnHLp0z2mfDf7y6xt9xdbzzOWk4pl5pSO/LGrgDrC9tF1hKxdz2Elj W2wg== X-Gm-Message-State: AC+VfDxAPWhY0/1CcSUJxC88h8OWfbmYFti6T2PUNvQt/T8D7aeLqdiK dqm6276R9MMp3Uk/2AjDdtcy X-Received: by 2002:a17:90a:aa92:b0:253:3662:9825 with SMTP id l18-20020a17090aaa9200b0025336629825mr2387535pjq.8.1684506723555; Fri, 19 May 2023 07:32:03 -0700 (PDT) Received: from localhost.localdomain ([117.202.184.13]) by smtp.gmail.com with ESMTPSA id 30-20020a17090a09a100b00250d908a771sm1634845pjo.50.2023.05.19.07.31.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 May 2023 07:32:03 -0700 (PDT) From: Manivannan Sadhasivam To: lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com Cc: robh@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, steev@kali.org, quic_srichara@quicinc.com, dmitry.baryshkov@linaro.org, Manivannan Sadhasivam Subject: [PATCH v2 8/8] PCI: qcom: Do not advertise hotplug capability for IP v2.1.0 Date: Fri, 19 May 2023 20:01:17 +0530 Message-Id: <20230519143117.23875-9-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230519143117.23875-1-manivannan.sadhasivam@linaro.org> References: <20230519143117.23875-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766334051382962967?= X-GMAIL-MSGID: =?utf-8?q?1766334051382962967?= SoCs making use of Qcom PCIe controller IP v2.1.0 do not support hotplug functionality. But the hotplug capability bit is set by default in the hardware. This causes the kernel PCI core to register hotplug service for the controller and send hotplug commands to it. But those commands will timeout generating messages as below during boot and suspend/resume. [ 5.782159] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x03c0 (issued 2020 msec ago) [ 5.810161] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x03c0 (issued 2048 msec ago) [ 7.838162] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x07c0 (issued 2020 msec ago) [ 7.870159] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x07c0 (issued 2052 msec ago) This not only spams the console output but also induces a delay of a couple of seconds. To fix this issue, let's clear the HPC bit in PCI_EXP_SLTCAP register as a part of the post init sequence to not advertise the hotplug capability for the controller. Signed-off-by: Manivannan Sadhasivam --- drivers/pci/controller/dwc/pcie-qcom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index 612266fb849a..7a87a47eb7ed 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -438,6 +438,8 @@ static int qcom_pcie_post_init_2_1_0(struct qcom_pcie *pcie) writel(CFG_BRIDGE_SB_INIT, pci->dbi_base + AXI_MSTR_RESP_COMP_CTRL1); + qcom_pcie_clear_hpc(pcie->pci); + return 0; }