From patchwork Fri May 19 02:14:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Pinski X-Patchwork-Id: 96165 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp930506vqo; Thu, 18 May 2023 19:15:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6iV7SCktLtCo28yJIyPiBvcEv7bNflMfEFT0pZHpaoaF0QxA4KMm9xjhyVBXx5Wb5jMQNB X-Received: by 2002:a05:6402:31e7:b0:50b:d23c:deb4 with SMTP id dy7-20020a05640231e700b0050bd23cdeb4mr326363edb.42.1684462529142; Thu, 18 May 2023 19:15:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684462529; cv=none; d=google.com; s=arc-20160816; b=N5WxC8BnR2W1U8DDbHhxdYbuE+pGIY2IEolbNgqv2kqL7cre6Yqym9zsQizJESgwIM ov8DbWJX1Dpr5Cw28dsYdAV9Eq+3RYLbRnBUd+N2bpakNq+ngvGbm0a5s9aEID8vcrCH 2GaQKrwfQp6DBMZ5VTl+cdG8plTlKG7u6uuzf67wBBxO17gWfAbaJQdbeLwoUAfIePAv VNKG9GeQ4uWjTl1gSF+y9QDjb4Q5lLB1XbEQbdB9SPBMXTnpXMAq4RAmmBbD36YPpcNF 7ulVFIcfSi4Qq1DX1IyiwFf6nwPEwAM6WhYqPECm7FSkhGA4Kckfo3Qpp2oQDWh8jqjR 5ZUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=MUHWxZWG8M+zuZ1PMjKF9Je4fxEOYOlqTpgCiLCDejY=; b=fCQCt5VdPW7gVoAO77ojcA9BX+7yGpQhjYnBL2XlXWj06sAbn52mWgqj4CxCs0jBec CyVE4HEZJoqTbQECU96Vh1JRMnRu1/FTTgheE+TnxKjowUNxSJybxqaNF6wG2X2H4Rgn GKiQ/hVMkQqC1wUgyO4NUXz1VfDlqL3VcuRlKi/NXb3U3D5MhckXTLW+SjA0fwnJXqtD SRUUh6q4YjETGiOGi/rx6osOd9tPQuq++eW57qfZO1JtVjEOSyv1h5feSDDaWuVEXVj6 +/+I0MWD/stia54sOn19XHMh2XAzWvjZaFJhScfYLk7cFwRW1DLwjre7e0qaGf66hEBr FlGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=QHIkolUY; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id l2-20020aa7c302000000b005048d1f1e3csi2164514edq.158.2023.05.18.19.15.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 19:15:29 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=QHIkolUY; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0E5763846055 for ; Fri, 19 May 2023 02:15:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0E5763846055 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1684462511; bh=MUHWxZWG8M+zuZ1PMjKF9Je4fxEOYOlqTpgCiLCDejY=; h=To:CC:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=QHIkolUY9SnwLpSuYj+p6QU/2QPj3eXmypuO5zDM0MycSD8oFWpyxCsoNrmwNNY4i EgOgLqZqYSIeIk05eeZCgU7BXXZu+E+TUXwIfXZCEjRTnKI/jgMAEsdkXcGMkRGMl9 RZBKvrvkk23a1yiuiIk3gMoqaPbEHX0kCmYyXbiY= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by sourceware.org (Postfix) with ESMTPS id 5A3513858D39 for ; Fri, 19 May 2023 02:14:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5A3513858D39 Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34IHoIQK012879 for ; Thu, 18 May 2023 19:14:22 -0700 Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3qn7jbe58g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Thu, 18 May 2023 19:14:22 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Thu, 18 May 2023 19:14:20 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Thu, 18 May 2023 19:14:20 -0700 Received: from vpnclient.wrightpinski.org.com (unknown [10.69.242.187]) by maili.marvell.com (Postfix) with ESMTP id 0AD903F706F; Thu, 18 May 2023 19:14:18 -0700 (PDT) To: CC: Andrew Pinski Subject: [PATCH 1/2] Improve do_store_flag for single bit comparison against 0 Date: Thu, 18 May 2023 19:14:09 -0700 Message-ID: <20230519021410.1841811-1-apinski@marvell.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Proofpoint-GUID: 0pxFlMTJ-GibSIeqONj1Hpt6IY-4wf4g X-Proofpoint-ORIG-GUID: 0pxFlMTJ-GibSIeqONj1Hpt6IY-4wf4g X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-18_17,2023-05-17_02,2023-02-09_01 X-Spam-Status: No, score=-14.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Pinski via Gcc-patches From: Andrew Pinski Reply-To: Andrew Pinski Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766286981089505507?= X-GMAIL-MSGID: =?utf-8?q?1766286981089505507?= While working something else, I noticed we could improve the following function code generation: ``` unsigned f(unsigned t) { if (t & ~(1<<30)) __builtin_unreachable(); return t != 0; } ``` Right know we just emit a comparison against 0 instead of just a shift right by 30. There is code in do_store_flag which already optimizes `(t & 1<<30) != 0` to `(t >> 30) & 1`. This patch extends it to handle the case where we know t has a nonzero of just one bit set. OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. gcc/ChangeLog: * expr.cc (do_store_flag): Extend the one bit checking case to handle the case where we don't have an and but rather still one bit is known to be non-zero. --- gcc/expr.cc | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/gcc/expr.cc b/gcc/expr.cc index 5ede094e705..91528e734e7 100644 --- a/gcc/expr.cc +++ b/gcc/expr.cc @@ -13083,15 +13083,30 @@ do_store_flag (sepops ops, rtx target, machine_mode mode) && integer_zerop (arg1) && (TYPE_PRECISION (ops->type) != 1 || TYPE_UNSIGNED (ops->type))) { - gimple *srcstmt = get_def_for_expr (arg0, BIT_AND_EXPR); - if (srcstmt - && integer_pow2p (gimple_assign_rhs2 (srcstmt))) + wide_int nz = tree_nonzero_bits (arg0); + + if (wi::popcount (nz) == 1) { + tree op0; + tree op1; + gimple *srcstmt = get_def_for_expr (arg0, BIT_AND_EXPR); + /* If the defining statement was (x & POW2), then remove the and + as we are going to add it back. */ + if (srcstmt + && integer_pow2p (gimple_assign_rhs2 (srcstmt))) + { + op0 = gimple_assign_rhs1 (srcstmt); + op1 = gimple_assign_rhs2 (srcstmt); + } + else + { + op0 = arg0; + op1 = wide_int_to_tree (TREE_TYPE (op0), nz); + } enum tree_code tcode = code == NE ? NE_EXPR : EQ_EXPR; type = lang_hooks.types.type_for_mode (mode, unsignedp); - tree temp = fold_build2_loc (loc, BIT_AND_EXPR, TREE_TYPE (arg1), - gimple_assign_rhs1 (srcstmt), - gimple_assign_rhs2 (srcstmt)); + tree temp = fold_build2_loc (loc, BIT_AND_EXPR, TREE_TYPE (op0), + op0, op1); temp = fold_single_bit_test (loc, tcode, temp, arg1, type); if (temp) return expand_expr (temp, target, VOIDmode, EXPAND_NORMAL); From patchwork Fri May 19 02:14:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Pinski X-Patchwork-Id: 96166 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp930508vqo; Thu, 18 May 2023 19:15:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7F0XspRl68qtVFXIBSozaXEJNT9yR2gcIqMCTVQFV6pOBkIX6eQTIPwt+PS42/yn7UybhR X-Received: by 2002:a17:907:60ce:b0:94e:cbfb:5fab with SMTP id hv14-20020a17090760ce00b0094ecbfb5fabmr121345ejc.75.1684462529145; Thu, 18 May 2023 19:15:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684462529; cv=none; d=google.com; s=arc-20160816; b=Z6sqmc7KjFEtri1EmX9reTvqW6MbSV/WQtLuFsVa7fxp38EGubh6nue9mS91clOMxU q28a7MF6kn3A29FaECkbC1UAhIjByTmnY5MOM3iUXY3gAo0dR/0rQtbNtecd+5ocX2X0 Vl6kVDUQVeB4KuokiDZVFubZEmwr4VEO7DpCrCMRz2ZNdsI2Ae4rTMc9MDeXIhTGrHk0 30oyaaV6iQl5BdPRqSHeHJbD9nI/mpzx/q3ZG8vuOND51oB2NOMNVsUUK4kybWDqXIlL IT6iVPr6naEVjX4dVH5w8hQ77YFdlY/iH68Qqknoqn/Tc5PkdzLUK66pmamcJ0E5ovp8 i/0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=DyLmkzSTF41dgyiRh8wQyX74aBwjEKk/CJS0WiRYf6E=; b=vdO1TMEjINooMp/dAC3+OjvhxErqi0z3jHBjhqXMjSKTG6tUSJCat6UqxxP6CBaQZE RG707XQU7lu49rXfD9lZHlvwN2jLC9hR4VtmnujJ+Pntb1+BKkQf2dZLpFRjYWRu3rOB wJ8NVKcmEUpx8Xlv6X8u6/PyR59R+dWcLJz53GWr7jaMXpSz626+zV0cZvUlosgDd9Ha SMZCfPTtImF8mfTho1CV5vqdHL/k5KWClgQLcX/UArcdILUS30G95e4Q+Rf6/iEv8oDf Gtqlzx6ODcrFY++zBQQqdtYwr0jpUZ7PwfhoX+odH0C8n8QPKpiOH72BuFqjcZ6SwfR7 4jTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=XoyaB6W0; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id k17-20020a170906159100b0095727b08140si2456224ejd.239.2023.05.18.19.15.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 19:15:29 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=XoyaB6W0; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 39FD83846446 for ; Fri, 19 May 2023 02:15:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 39FD83846446 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1684462511; bh=DyLmkzSTF41dgyiRh8wQyX74aBwjEKk/CJS0WiRYf6E=; h=To:CC:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=XoyaB6W01QpuQSvJgcd65Rn3AlE9Zejzg69GBTju8f/ssJa/4MIQ2jVOMgEHJ+jT0 R4fcmonVu9yFN2RURfNKsuOyCurmdadxvVWK16jLLLLX6JnFfFTvoxd0rFzkk3SZH1 r3wrmeLx9qAWIEjIOdD8mewgP54Ib87kaM2miVo4= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by sourceware.org (Postfix) with ESMTPS id 769D93858CDB for ; Fri, 19 May 2023 02:14:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 769D93858CDB Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34IHoG8Q012878 for ; Thu, 18 May 2023 19:14:22 -0700 Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3qn7jbe58k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Thu, 18 May 2023 19:14:22 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Thu, 18 May 2023 19:14:21 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Thu, 18 May 2023 19:14:20 -0700 Received: from vpnclient.wrightpinski.org.com (unknown [10.69.242.187]) by maili.marvell.com (Postfix) with ESMTP id 7BFD63F704C; Thu, 18 May 2023 19:14:19 -0700 (PDT) To: CC: Andrew Pinski Subject: [PATCH 2/2] Improve do_store_flag for comparing single bit against that bit Date: Thu, 18 May 2023 19:14:10 -0700 Message-ID: <20230519021410.1841811-2-apinski@marvell.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20230519021410.1841811-1-apinski@marvell.com> References: <20230519021410.1841811-1-apinski@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: wf1XBG21uDVyOTWLqDGnelS3DrguBdYM X-Proofpoint-ORIG-GUID: wf1XBG21uDVyOTWLqDGnelS3DrguBdYM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-18_17,2023-05-17_02,2023-02-09_01 X-Spam-Status: No, score=-14.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Pinski via Gcc-patches From: Andrew Pinski Reply-To: Andrew Pinski Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766286981156638552?= X-GMAIL-MSGID: =?utf-8?q?1766286981156638552?= This is a case which I noticed while working on the previous patch. Sometimes we end up with `a == CST` instead of comparing against 0. This happens in the following code: ``` unsigned f(unsigned t) { if (t & ~(1<<30)) __builtin_unreachable(); t ^= (1<<30); return t != 0; } ``` We should handle the case where the nonzero bits is the same as the comparison operand. OK? Bootstrapped and tested on x86_64-linux-gnu. gcc/ChangeLog: * expr.cc (do_store_flag): Improve for single bit testing not against zero but against that single bit. --- gcc/expr.cc | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/gcc/expr.cc b/gcc/expr.cc index 91528e734e7..a4628c51c0c 100644 --- a/gcc/expr.cc +++ b/gcc/expr.cc @@ -13080,12 +13080,15 @@ do_store_flag (sepops ops, rtx target, machine_mode mode) so we just call into the folder and expand its result. */ if ((code == NE || code == EQ) - && integer_zerop (arg1) + && (integer_zerop (arg1) + || integer_pow2p (arg1)) && (TYPE_PRECISION (ops->type) != 1 || TYPE_UNSIGNED (ops->type))) { wide_int nz = tree_nonzero_bits (arg0); - if (wi::popcount (nz) == 1) + if (wi::popcount (nz) == 1 + && (integer_zerop (arg1) + || wi::to_wide (arg1) == nz)) { tree op0; tree op1; @@ -13103,11 +13106,13 @@ do_store_flag (sepops ops, rtx target, machine_mode mode) op0 = arg0; op1 = wide_int_to_tree (TREE_TYPE (op0), nz); } - enum tree_code tcode = code == NE ? NE_EXPR : EQ_EXPR; + enum tree_code tcode = EQ_EXPR; + if ((code == NE) ^ !integer_zerop (arg1)) + tcode = NE_EXPR; type = lang_hooks.types.type_for_mode (mode, unsignedp); tree temp = fold_build2_loc (loc, BIT_AND_EXPR, TREE_TYPE (op0), op0, op1); - temp = fold_single_bit_test (loc, tcode, temp, arg1, type); + temp = fold_single_bit_test (loc, tcode, temp, build_zero_cst (type), type); if (temp) return expand_expr (temp, target, VOIDmode, EXPAND_NORMAL); }