From patchwork Thu May 18 12:38:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 95848 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp461717vqo; Thu, 18 May 2023 05:43:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Lwxs8qkqng13TiRAhS1dmebiZg77NJvjhSgz75PxB11eDaP+UCwKM+3W5VJjpWcbQDs9P X-Received: by 2002:a05:6a00:139b:b0:643:59cd:6cad with SMTP id t27-20020a056a00139b00b0064359cd6cadmr5005773pfg.24.1684413809133; Thu, 18 May 2023 05:43:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684413809; cv=none; d=google.com; s=arc-20160816; b=PvP2+JNg6PHiwo2ousf7bJRz8egZyT/C+ktclPSREkmTayInDY1n77Meea8d/xL/ht ps+8Gb4xdNYKzakEOyLvgbYpBA4HUViABwal2sQK8l7eHuhTDhlQyn1z+W60di3dW4s1 dhcztGOSDYWXBqFiU6eW4BqQX4una+uMdbix0fxrIVg2umkFuN/pbiTkSTnB7FLtW20A 3P75uFKEEYktfB/878gCWk3qwU4FKpZAuNmfqgHfZxcRydAUxM+PAE14OWBpFFA4VOga qADN9tbCTR2xreXmtd2P3cWmgQgnRogIEHJgsGQ+tdMzXH41BpqQ6H7OS/bPbIsFy32l bABQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=iXttdsHRrBGhxoXcQIavREPe5niy9TzGkhXZVV3/EiI=; b=FKJEM44UBt95VknJTURVZIhOI1FVm8oD8AWIqYRFU6Uqeq8VvwXCcQE5hHG3kMxC3v zojqH2nyzDd+nENKyUOSw9vZZvKFGx9n1fpf3zNvLQjL2iUYsp4NLXZ3KazNC5xgFUnA melrB/9lTyV0gHbwY6PL2catxSc3avqaWOGALijMhQ2E9Uqb6S/9EhMJ93OQvCf2tj5+ ckYOTloaB3a/rW8W6kDR3LeZGD3Ww8qjGrtbFX69FUIYQ5xOXbi9rsEH9seoEdrZPZl3 +HG/f/f3K0isfAjn2KbTwjoJCMuZC/IQ6i/9rmZSg83PU2HcNrOOCT5zB3MXWAbHVb4k WB2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MCZJcd9M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 7-20020a630207000000b00530743695d6si1343862pgc.725.2023.05.18.05.43.16; Thu, 18 May 2023 05:43:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MCZJcd9M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230160AbjERMjU (ORCPT + 99 others); Thu, 18 May 2023 08:39:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230020AbjERMjT (ORCPT ); Thu, 18 May 2023 08:39:19 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A882C10D0 for ; Thu, 18 May 2023 05:38:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684413511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=iXttdsHRrBGhxoXcQIavREPe5niy9TzGkhXZVV3/EiI=; b=MCZJcd9MjngkglQ/JAliLZGT3VPn4zZFZRfgIeKsVimij7Xst7/HNwSEVaZrjR9F9ZTeGa 3KiCyiEwqQMdJpyXnmFNgmGL88MGrr1DkKZ/ZJ6/QcfVME33IOXeAAV9tRIUJScXyPPhSH TgFJCnbhnl8lCFdKQZ18DH038v/0JHs= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-353-5GhDtE6lPMCc-9wwGUNinw-1; Thu, 18 May 2023 08:38:30 -0400 X-MC-Unique: 5GhDtE6lPMCc-9wwGUNinw-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-5eee6742285so22612186d6.2 for ; Thu, 18 May 2023 05:38:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684413510; x=1687005510; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iXttdsHRrBGhxoXcQIavREPe5niy9TzGkhXZVV3/EiI=; b=H28j5oBCF+nRaYb/ePBIlbQISm2mS2OgokYMwnB+ga9m4aYeJmo6hVt0qc185mAYei qSj5TzqpHA0SFtA+cQ5Tk9GKMGifi+Rc+NGbjJWpeFhnDD2CU44iPRCd1lsTF2PYXrAg P+NqLJb7bbLZn1tREZoazkQijQBS5Ls3DctzOS//FHVf8yvEL9awMiYJBuGUu7yffoVc DS4NzO3lM/bvZQPZRsWuriVp5Nnw6YUB6lUN5vwF30/4hY+6NWlEwymoXP2dxoE7tlXJ Ybna4CdxtUha7Ye4Q4V7D9X7/Lr3lOqsWxvNLUto2GuT0MrAftChMg2oD2UPG+UbMbJP bDzQ== X-Gm-Message-State: AC+VfDxfmec4MsIMyYG4itcLp4/ziU/EcuyyGSzqJ5De8V/VYzJZ4kTd VuaaMeEj+28Yh82IYej4BwtrUD2oD/mHFJ+culOPRViz+MymwfdZ8lClvk56SSSyE0HSIt237B6 BJp4B6WFdZQ1tMkNSwDFyUTpj X-Received: by 2002:a05:6214:202b:b0:61b:6e43:b20 with SMTP id 11-20020a056214202b00b0061b6e430b20mr5362266qvf.42.1684413509948; Thu, 18 May 2023 05:38:29 -0700 (PDT) X-Received: by 2002:a05:6214:202b:b0:61b:6e43:b20 with SMTP id 11-20020a056214202b00b0061b6e430b20mr5362245qvf.42.1684413509712; Thu, 18 May 2023 05:38:29 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id m10-20020ae9e00a000000b0074e21136a77sm358162qkk.127.2023.05.18.05.38.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 05:38:29 -0700 (PDT) From: Tom Rix To: perex@perex.cz, tiwai@suse.com, oswald.buddenhagen@gmx.de Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] ALSA: emu10k1: set variables emu1010_routing_info and emu1010_pads_info storage-class-specifier to static Date: Thu, 18 May 2023 08:38:26 -0400 Message-Id: <20230518123826.925752-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766235894156278613?= X-GMAIL-MSGID: =?utf-8?q?1766235894156278613?= smatch reports sound/pci/emu10k1/emumixer.c:519:39: warning: symbol 'emu1010_routing_info' was not declared. Should it be static? sound/pci/emu10k1/emumixer.c:859:36: warning: symbol 'emu1010_pads_info' was not declared. Should it be static? These variables are only used in their defining file, so it should be static Signed-off-by: Tom Rix Reviewed-by: Oswald Buddenhagen --- sound/pci/emu10k1/emumixer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/pci/emu10k1/emumixer.c b/sound/pci/emu10k1/emumixer.c index 3a7f25f81504..26ed7e2fe053 100644 --- a/sound/pci/emu10k1/emumixer.c +++ b/sound/pci/emu10k1/emumixer.c @@ -516,7 +516,7 @@ struct snd_emu1010_routing_info { unsigned n_ins; }; -const struct snd_emu1010_routing_info emu1010_routing_info[] = { +static const struct snd_emu1010_routing_info emu1010_routing_info[] = { { /* rev1 1010 */ .src_regs = emu1010_src_regs, @@ -856,7 +856,7 @@ struct snd_emu1010_pads_info { unsigned n_adc_ctls, n_dac_ctls; }; -const struct snd_emu1010_pads_info emu1010_pads_info[] = { +static const struct snd_emu1010_pads_info emu1010_pads_info[] = { { /* rev1 1010 */ .adc_ctls = snd_emu1010_adc_pads,