From patchwork Thu May 18 07:27:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95679 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp302616vqo; Thu, 18 May 2023 00:29:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7EbVh8u0r/WzAR9RzRtVEi3orP1/NwRk+20m4Sa5WsYZRNG69WvZiNcaiJDDw23T0kbpBt X-Received: by 2002:a05:6a21:7899:b0:101:90e:c0cb with SMTP id bf25-20020a056a21789900b00101090ec0cbmr1289209pzc.59.1684394980127; Thu, 18 May 2023 00:29:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684394980; cv=none; d=google.com; s=arc-20160816; b=ZSRrKkFZX+AiUhSb9eQfmgKzpKOkDoF081qo+GtaEVLlEvCoJhDuV1AyvUUbmSngZD 4WWSrR2pGwLNKnlD9XIjZO4ygG6pSyWHG9nFPeeisQyF4L69T3AYbpsXoeBxEGeY0yTO AX5/PktMmwHQf/1txXf6w8LL8p93RoEcUIP+tTlD+cjHt2xGnUuqOft36L0D7MV9MMEH UDRaidSBGUTWgEMT3ERM7CCbO2ep6iVw/XwQYsdl6+34eS76AwcFAxrT4Xxk9AOMl6rh TmCcmvQbNlq+/Ec0A+ndTdHps0TcOWpOSaaUFjEHk8jxDuOtZ6JyUhiKE56HYJsRah4i 65VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xY4US8j109ap8g7iJPTxaqGh/0KFUvHJ6e/HWa50JR0=; b=rc06H3Hnyt5nN0H6i5j/kVHT+0hz4aTnQB38BYEw6QliNihnQCQpj5n0M0mdbSjbwf 6clC8+VrMHTSN4BrjgJZtzud4f4knMlIf4aCaXVigzrqi0oh+VF0uiiOLmNGvznzSH+x B68d+XAlzGuUB0LHvWtOiHskJLHUMhLSlY1PqfYsc+NM2rBBpxAN5nhH6kKPMd52yw5e CsNZeeJ4iu3uijQ2fksP8OC4qGdNyP67iYXCjJGzpgmEKxrO9yT+wlDSj/nAG2CCXvUJ qHWP74/uS4fxGjvhx9m6PLrKOMhDTeipy9tDKPK6F9qcgWPcfishEKVulcIQjTHocgI3 24Yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VdCXcIJz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v190-20020a6389c7000000b0052c6c5bc1e6si894482pgd.247.2023.05.18.00.29.25; Thu, 18 May 2023 00:29:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VdCXcIJz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230119AbjERH2K (ORCPT + 99 others); Thu, 18 May 2023 03:28:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229527AbjERH2A (ORCPT ); Thu, 18 May 2023 03:28:00 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C9D519BB for ; Thu, 18 May 2023 00:27:59 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-510ddeab704so1210579a12.3 for ; Thu, 18 May 2023 00:27:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684394878; x=1686986878; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xY4US8j109ap8g7iJPTxaqGh/0KFUvHJ6e/HWa50JR0=; b=VdCXcIJz3zJr+Z194kctgRAjtWQyZ8oKgT3cqsKr2mbtExnmGXiP6sq1k6ff7pm/cB /2TbXgKWQfA5/hdwYF5YeQPaNdZAM6GBNHvIztoou8hegf3uUbCwiCQxBQX7becb0J6M lSzA5ZWORuBJMzq9QGt1+2CoYD/6tUMsrMb+62zbEZTlWDdZp4urjE1QejdtIqapndS6 J/0dwAFwWXC1PxLwiryYg76queLaMNfzQKhH1j10QGIqdXI/u+qvtIS2ObSyuWofmM4x Rj4fm6iHvvf27XCjbs63mUYGm8d37NdEiWizcFIZBEva1cii+s7v/DLYuB2hA1gu/0bl GaEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684394878; x=1686986878; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xY4US8j109ap8g7iJPTxaqGh/0KFUvHJ6e/HWa50JR0=; b=jzvEjT9scgvkrCk9hWUAP8UeZ0qA+Fh6DsUMyVPN9ihUBLY/lseCtq/bY+ZaXgt6SB Os4yZqrA21KMwAUvRIAqLYJ/NBEgSzHBYxY+1h3D1bDLTrN4b3PifB2JZ9Idcu6KhMdj YFYj/PusOljJab0VmoUutH7YPrmwR3/F5UW8jowaSwfys7pVJKiD5jfOab8GkE7qfQCB lHBLRuiMEvffuS8aMr+2qIm9hgObhIMhzuSoDdnDWrNQ2rD8fjIj0rkrsHuTfdWO1858 p9NNJJ4O00oB3AksgqFT8tBz9cdF7yyfY2doXQZhag8REdwjGlcgqWRMap2pWrHVLmGI BY2Q== X-Gm-Message-State: AC+VfDxftscLBdyNsAJbKkTvZOW+9nz9VJgZ8Fkr2DH/V0M2AxOaJdip reLsqLHi2fOB7RDHlYH4jDjHvA== X-Received: by 2002:a17:907:1ca8:b0:96a:bfc:7342 with SMTP id nb40-20020a1709071ca800b0096a0bfc7342mr32079981ejc.62.1684394878057; Thu, 18 May 2023 00:27:58 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a2b:c408:5834:f48e]) by smtp.gmail.com with ESMTPSA id g17-20020a17090669d100b00965aee5be9asm594241ejs.170.2023.05.18.00.27.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 00:27:57 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Pierre-Louis Bossart Subject: [RESEND PATCH 01/12] ASoC: codecs: rt1308: do not store status in state container Date: Thu, 18 May 2023 09:27:42 +0200 Message-Id: <20230518072753.7361-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> References: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766216150814877988?= X-GMAIL-MSGID: =?utf-8?q?1766216150814877988?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Pierre-Louis Bossart --- sound/soc/codecs/rt1308-sdw.c | 5 +---- sound/soc/codecs/rt1308-sdw.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt1308-sdw.c b/sound/soc/codecs/rt1308-sdw.c index 1797af824f60..313e97c94532 100644 --- a/sound/soc/codecs/rt1308-sdw.c +++ b/sound/soc/codecs/rt1308-sdw.c @@ -304,9 +304,6 @@ static int rt1308_update_status(struct sdw_slave *slave, { struct rt1308_sdw_priv *rt1308 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt1308->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt1308->hw_init = false; @@ -314,7 +311,7 @@ static int rt1308_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt1308->hw_init || rt1308->status != SDW_SLAVE_ATTACHED) + if (rt1308->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt1308-sdw.h b/sound/soc/codecs/rt1308-sdw.h index 04ff18fa18e2..f816c73e247e 100644 --- a/sound/soc/codecs/rt1308-sdw.h +++ b/sound/soc/codecs/rt1308-sdw.h @@ -159,7 +159,6 @@ struct rt1308_sdw_priv { struct snd_soc_component *component; struct regmap *regmap; struct sdw_slave *sdw_slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Thu May 18 07:27:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95690 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp306796vqo; Thu, 18 May 2023 00:39:41 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6dLTffOAEmJDbCu/0NewPm2wnlaQZi1yUlxrm5/aXNR0lhX2iY7qMdfnUMWPtONRNGiMnN X-Received: by 2002:a17:90a:c287:b0:24b:2f97:9208 with SMTP id f7-20020a17090ac28700b0024b2f979208mr1652766pjt.0.1684395581191; Thu, 18 May 2023 00:39:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684395581; cv=none; d=google.com; s=arc-20160816; b=YTbL81MEm6HRLgzRP6An/H/isS9A4sCvzuCzsyFnBr2GXo2M/zFqduOvAdogD7HfO5 HKzyOKYNtcgkwpSc7O3KHAdx9VdtkSPb7KuYekPkz2ZDEm43EeRWP9M6gA4iSD1ABGyI 6kdKnW/YdRwQyDQhLSDoxAaQ/E2AzXC9nU61z9kxl4+ASd8GoEX09XeuuE2QSw+EFRtO ME73yyQ8wBSu4BeASAIV3oEm2Bkf926DuEhMj1TwRC24YpG09FKNMYAxrmh7eIWGRi5w y63GWrXdwx8JcbwtsABtbsryL8Nhl1+A2noGfJ6i61DJZRCmyv8kdQBOReSBnxKZWabw QOxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=LC/zIc8X+SN3v3HkNtTVdt1UL4xSDxpH+q1cQ2DHdvs=; b=jEFiesxOdidTBfW6wSUM994vIoeCPHPN2yzTOMQCvUPvMNk4Wuozzp1BjDMeyR04jO Ltn0+HRK1QXLnTbAK8E5CoYDGMPm9yx/JMeV7F/612Awu81A1oBUpsvNiX+VVQ1/Q5NW ECBaCgBgDfLsD82ICF2qXFguq6xgjijnAyAUO4DSJNCWkoaddbvf8A0/W65dRg/eQoT7 TfsF4p0tPxDVVWP2uezsIbGdkRy2I3axjnyGF87378iou1/Fz1etcjdneuwiweVdckvj Xdecohgxi680/behFVOrtJEOceNq2oz8T+a7nnrxtu488eh63cKsoiK/fDQjdtgNs0s1 3rDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WP+J1VwS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j15-20020a637a4f000000b0050be067284bsi822712pgn.556.2023.05.18.00.39.28; Thu, 18 May 2023 00:39:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WP+J1VwS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230124AbjERH2O (ORCPT + 99 others); Thu, 18 May 2023 03:28:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230092AbjERH2C (ORCPT ); Thu, 18 May 2023 03:28:02 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEB842133 for ; Thu, 18 May 2023 00:28:00 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-94a342f7c4cso318844766b.0 for ; Thu, 18 May 2023 00:28:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684394879; x=1686986879; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LC/zIc8X+SN3v3HkNtTVdt1UL4xSDxpH+q1cQ2DHdvs=; b=WP+J1VwSUrjRPf0WUHV5s4C8tvmBJHGuOzF1k5aWgcB+Mw3xKYuBhbCXu364BdOCwP 2VDyyUqIYQB2hGqLRmtrHJqOENQpwdUYXOiEui9j2ebQGU1cL5VjZ0FTb1/kbr24Q6Np 0kAN0HTBxFawRRBs36ejvFCGYOCWC14xl/3tSjX/YRbONRJgr4+2Aa3/W7ELX3uVPddk FACbZtF5IlbdDmQldf6ObNjB9PAe5niHMcjTthzN4iZCtNhmLie3vFqFlArzytN5XBp9 vM+hvr9BLbJWMNy5YnSAybjVHoq8ftywfjwUrE7QTdpVYMawZcEQgVKEWoYor4GE53ci wyKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684394879; x=1686986879; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LC/zIc8X+SN3v3HkNtTVdt1UL4xSDxpH+q1cQ2DHdvs=; b=HwbfgLY5REV8ldYXzk827lwIljMfNmqBEaG4PdXRyrVmk7Hf7ZOp4s8SXdu4osIIMt 59CN9msDaJZrCRZXfey9Pm9ky1byNTMi8+DKUCMaSptFWeHayns1fzFAkj9VouPqPwrZ y5py9gZUXnrlSTqZ0uvSBSlUUZ2F730KGFXzkKJOPB1mA6H5KaEfVAsdND10HjWheKwt 7VzuCGLlslOSxAKWHLFHv6c49YFlgfqeNZC44MiyE6jWnSPhwvlJs4T5j+VyeqQ06XIB Y/qC1JANr8x7Wc7KQEB7fO8RnPQzBgLz+yMCL6yIGUphV1jJO//Lnc4D+ZDWUX6DrWW5 L+sA== X-Gm-Message-State: AC+VfDxcbb6AF97ikvsWhEYMSTqXVsQMmP6HO4S1LEeoAJQQUftz8oVU 2Z7PfnIMutuYCXUldsf4g9Wpar2K1Dzpc+SQaxkBuA== X-Received: by 2002:a17:906:d54b:b0:94f:3980:bf91 with SMTP id cr11-20020a170906d54b00b0094f3980bf91mr46254817ejc.19.1684394879305; Thu, 18 May 2023 00:27:59 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a2b:c408:5834:f48e]) by smtp.gmail.com with ESMTPSA id g17-20020a17090669d100b00965aee5be9asm594241ejs.170.2023.05.18.00.27.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 00:27:58 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Pierre-Louis Bossart Subject: [RESEND PATCH 02/12] ASoC: codecs: rt1316: do not store status in state container Date: Thu, 18 May 2023 09:27:43 +0200 Message-Id: <20230518072753.7361-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> References: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766216780896555562?= X-GMAIL-MSGID: =?utf-8?q?1766216780896555562?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Pierre-Louis Bossart --- sound/soc/codecs/rt1316-sdw.c | 5 +---- sound/soc/codecs/rt1316-sdw.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt1316-sdw.c b/sound/soc/codecs/rt1316-sdw.c index 2ee5e763e345..601b76320124 100644 --- a/sound/soc/codecs/rt1316-sdw.c +++ b/sound/soc/codecs/rt1316-sdw.c @@ -323,9 +323,6 @@ static int rt1316_update_status(struct sdw_slave *slave, { struct rt1316_sdw_priv *rt1316 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt1316->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt1316->hw_init = false; @@ -333,7 +330,7 @@ static int rt1316_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt1316->hw_init || rt1316->status != SDW_SLAVE_ATTACHED) + if (rt1316->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt1316-sdw.h b/sound/soc/codecs/rt1316-sdw.h index e37121655bc1..dc1bfe40edd3 100644 --- a/sound/soc/codecs/rt1316-sdw.h +++ b/sound/soc/codecs/rt1316-sdw.h @@ -42,7 +42,6 @@ struct rt1316_sdw_priv { struct snd_soc_component *component; struct regmap *regmap; struct sdw_slave *sdw_slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Thu May 18 07:27:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95680 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp302634vqo; Thu, 18 May 2023 00:29:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4W0NuqCwuTS8WScMgAN4QxyxRgqIZEaIoIClqF2PYO+YRuv1gt4+V349bDxcZQERdwhk0s X-Received: by 2002:a05:6a00:1ac8:b0:643:b8c2:b577 with SMTP id f8-20020a056a001ac800b00643b8c2b577mr3631450pfv.22.1684394982653; Thu, 18 May 2023 00:29:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684394982; cv=none; d=google.com; s=arc-20160816; b=SrZNp3Nx2zbOcFuggGvq3rIs1q4EFKzSGB5LhaFRKE/F6A+lXlqs0dHY3DFEmzuorg jt1uUI/Y4ABquv1s74AuirzD0dhmxZeYAf4nwQ09KizO+lGQopzNg0qzdz2aN6lAGcnM VrSLb1EHWNFYYE46FaGfqEOb3EcJ7UDhQ23oQwqQtPLDX+z8fGHXSiPZKpDluMNtePEg Pt8WvXMRd0TRPfKxoe58r18s1jvfs92dA9R6uRiTGvh37rDST1Agq2vUKRh8oKdvJeLF RbPqzPcT+Ndt1yiAo13vOLGVyzgDL0DwKD8aZsi7myYFxk11IMfjYRzLFxJBQIBVMW1r MKmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=jJY+f/kyvGT80qDu/2YzrWbFWrXecvsPv92RJrnC6oM=; b=P7d/vQxCNsgSjRSLh4tf4WZywr2B/QpxJDDaYmvou/JtMCLp7T7KGp52SKansWI/q4 GQPQ/LToTa0bbKfYbmjEJrXM9A7tYXc4K+a2rMRe6e6oQ3HUahwwjTMF6UTX40uM7ZpZ xSh35BZ542WCYi3AgZ2i0PSIjeGSQlcM1xDNLoy4i5s5KYtAs/+vWl1Y9e2A+6SXANB6 BI1sSn2ABprRx4T+gdhxptLOTrzevaKacIcu5BBVKyiVO4Se8t6+sNf7rbPMdpvIiDRG CWkwoVF7sKNxmbmhih5FQebbZPJl7ARuxg5GmfxuYKnMgP8+BMAc7mnGTkrJjrxkXmD4 1qxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=O9ourAIq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p124-20020a625b82000000b0062a450c329dsi1065056pfb.93.2023.05.18.00.29.27; Thu, 18 May 2023 00:29:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=O9ourAIq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230137AbjERH2S (ORCPT + 99 others); Thu, 18 May 2023 03:28:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230097AbjERH2D (ORCPT ); Thu, 18 May 2023 03:28:03 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F27BC19BB for ; Thu, 18 May 2023 00:28:01 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-96622bca286so320664666b.1 for ; Thu, 18 May 2023 00:28:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684394880; x=1686986880; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jJY+f/kyvGT80qDu/2YzrWbFWrXecvsPv92RJrnC6oM=; b=O9ourAIqiWUoA66Do64H+sF3x/mqeWBFY1RLtuUwyPqlqUUj+RaoCyPjATbGFzY6uP vv0n+QcH0YiWtYMVbl1DtrxKnskNmlVpnXcM2bELSuVYkIkwQyakVQiDdim2G6qCuZ1b LTF2tCNi+KHuG/hw6oFjAiK8qNLZebZYgeBnKvMH41x6m4T1LBtpxQF/ljm3QFHyRiHL lwwJMfNpG9gK6QGBkGC0iebrnNFhiQk8ThPZ+PMDWSxHwb1c5tpfQ6dsDevIxJgPybVS artNLQuSEdRZ6dsivfMk0624OjTfKDz7aKmjWmcOYrWkAVkDK0TrwPjDrlc42proM92w ofEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684394880; x=1686986880; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jJY+f/kyvGT80qDu/2YzrWbFWrXecvsPv92RJrnC6oM=; b=VO5W5YW0rmw8QPVOfqC+Sj26FZbZAE3HL7KmZizRrbLEH57V94aIdE5zf1okBrIxpo e585xNyIEoVQ8fGk7Y3OGwvkuBZ3xb+mPkcjkBEFS11YLB3YtSOh54eho5m5r2gh3a3f ZCJFdGXfLdScEZZsNMPXYxhbgoxf+b10SAb+yQKsuDfv0+ZHedBGRWNdAxZ2DLvSpr9f CJH0phB3q13wD5gyISTzhOTNGJbxxpDiJ/Aovj2byDJ7yM75Ae/9H3gUWY7ag/fop94Y yT3hTpSpxkSOYj2mAGjc4wGcwf8Xpg1VPszt3Pt0/lSrvqvoi9X8BH5E3DYw0fZXbMkl mzJQ== X-Gm-Message-State: AC+VfDwOKr/+hl074cSWAKDcHpbWgGH0cf4HlimzQXbyvkitEhe2wFKC rep3YUSHWd4dVJ2oq8Hvw1UJfA== X-Received: by 2002:a17:906:ee82:b0:94f:1a23:2f1c with SMTP id wt2-20020a170906ee8200b0094f1a232f1cmr36770723ejb.50.1684394880586; Thu, 18 May 2023 00:28:00 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a2b:c408:5834:f48e]) by smtp.gmail.com with ESMTPSA id g17-20020a17090669d100b00965aee5be9asm594241ejs.170.2023.05.18.00.27.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 00:28:00 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Pierre-Louis Bossart Subject: [RESEND PATCH 03/12] ASoC: codecs: rt1318: do not store status in state container Date: Thu, 18 May 2023 09:27:44 +0200 Message-Id: <20230518072753.7361-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> References: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766216153502019019?= X-GMAIL-MSGID: =?utf-8?q?1766216153502019019?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Pierre-Louis Bossart --- sound/soc/codecs/rt1318-sdw.c | 5 +---- sound/soc/codecs/rt1318-sdw.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt1318-sdw.c b/sound/soc/codecs/rt1318-sdw.c index 795accedc22c..3751d923611c 100644 --- a/sound/soc/codecs/rt1318-sdw.c +++ b/sound/soc/codecs/rt1318-sdw.c @@ -456,9 +456,6 @@ static int rt1318_update_status(struct sdw_slave *slave, { struct rt1318_sdw_priv *rt1318 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt1318->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt1318->hw_init = false; @@ -466,7 +463,7 @@ static int rt1318_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt1318->hw_init || rt1318->status != SDW_SLAVE_ATTACHED) + if (rt1318->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt1318-sdw.h b/sound/soc/codecs/rt1318-sdw.h index 85918c184f16..86e83d63a017 100644 --- a/sound/soc/codecs/rt1318-sdw.h +++ b/sound/soc/codecs/rt1318-sdw.h @@ -88,7 +88,6 @@ struct rt1318_sdw_priv { struct snd_soc_component *component; struct regmap *regmap; struct sdw_slave *sdw_slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Thu May 18 07:27:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95681 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp302678vqo; Thu, 18 May 2023 00:29:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6Ved5HziiHS6hn88zpTOrcAgJjoNb5chSrsdD1u4eL8GvCEEx9w5CixdLFLj8qLWiKXzqT X-Received: by 2002:a17:90a:ee94:b0:247:6022:9595 with SMTP id i20-20020a17090aee9400b0024760229595mr1457705pjz.45.1684394989581; Thu, 18 May 2023 00:29:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684394989; cv=none; d=google.com; s=arc-20160816; b=Y8VBQp0dq8gpTgaZz1CSbu+NlAQMvuZ1OBfwbXITGWz2NjDkeqvqsfOp73ekUlVvSo PLd0YWd1vSo5bTlwaB+Ya9RUgALb2SDiPlbWpmwRfzrHgKkcprJjSGw7fWVHH7b2uEfw DPMGKPE8QyONi+c6cpskhI6vjMsh6+utcjykScGS2An6RHv7X1UI0nJ7Es7wg72SMUAO RsX9YHoNllw44RBxsewf/K3H9qVhzNMUZk/ZISo5Fp8PpjNQJ9ALxowg8EF5BeWBiExn B57m9VS7CgLShws1w9alr/Hd3KO56v/QVTERRZ590zfg8dLZ+4x5Apl51hI5wbGq4hjS TDDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=w7CXEP7TWtcrBNlAfURzS7ZFy4jvErEzkp1RHuGj8Jo=; b=x2OBQ77xdYTA/M5LYPEMNT8bAAGudXoq1qVfuJVa8BuspRuhBDt7jwpBAG1nGaEoGp 6iBinv7eLQ0tMb3T7FjKF10y0fkg8fmhIcBS2NC1L7PqWzmdCqRSmLGU46YbPAOq2qPY gv+UbTgQlq6auY0ryohZf/1aCv2YnEgyX6gpqCinDvAFEjFn80Q97WXGOsVkV3JxZP99 OLfdmzjXrf+hGGC0ngJSxOCRu9TjK8EdmqywEDqnUKMvKtzQ8IpwccG5SOW9ayii1mbh rj/8cYO9ASBgsEZPniaGVp3yH3+64X/GgsfKzZhpXiiuVkLb8hBqtQPoCVSBavuiCJ62 mw6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zNNOgZ+A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s1-20020a17090a440100b0024df7c1b9e7si3441622pjg.151.2023.05.18.00.29.35; Thu, 18 May 2023 00:29:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zNNOgZ+A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230141AbjERH2U (ORCPT + 99 others); Thu, 18 May 2023 03:28:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230103AbjERH2E (ORCPT ); Thu, 18 May 2023 03:28:04 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33B8C2101 for ; Thu, 18 May 2023 00:28:03 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-510eb3dbaaeso285832a12.1 for ; Thu, 18 May 2023 00:28:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684394881; x=1686986881; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w7CXEP7TWtcrBNlAfURzS7ZFy4jvErEzkp1RHuGj8Jo=; b=zNNOgZ+A7E64Nl/R3Y706ivhMQUe0MZ6cSd3utBHP+wuuEm+nHd0T7bOehTUAg4M6Z 1s/Wd/s+mlBNQv+MZwjIwsSdULFtvLqfHzEbPZ84qOA4mQmjwr0vEJSBLjLgoBtxRXUw QZ0JpYoizjZeN3450GpOd+ZtxLEaQRM1aUPFDIkw49zFz9c16FMD9TB+SJO5lepqBbUF BI7rFyrPYi7BudVocZzJuDletVdEKHlxPrY2qj4XCsbPTLeDrUe9gfEFCtpvtNZikuJh DJd+0Iuj4CSQwRnUgnzKJ5I2K2zu46WEt6Eq0/3x+EagoXEp/DUZlnsvpKWzPUk9ATn9 Ll3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684394881; x=1686986881; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w7CXEP7TWtcrBNlAfURzS7ZFy4jvErEzkp1RHuGj8Jo=; b=d6B3rT2qZgQ7kN73nDzs2lmHWf8yjiCt/ibnsEQdrcwrm1J2m559nt/62GiPBY3xm4 +B8eK13VjO0FjBl9oK1N3O+oEp2jbTwkZSMJC7s8hi6iLf6GJxtogmVOogY+Xa6s70Uj xl5V8Cg7IIyE/XDo3YlJm+qmP+ti8QZCV9DFwJgRGac19BxkePVkofrxYGMOhMp0lGgB opOWmGkVPDAwLgi/vomAGttKOxhjXkRHOM5njWMEXSvuHJlodWHRqkC1gQ7W5JmXd1YP ah3fSuUDiP2QEKvn4pfPhcVJWSv1ToTEN135fjuQPnRXlDi7zkBqrIyWuzTO+WZ1jn7F BnwQ== X-Gm-Message-State: AC+VfDwMaGR6FiBpA3j/uCKv6hsV4PdGzm/4Jv3IX14B9wtWlMJtyaqm FeDFosFNQAV8q8kK2X2aOoZk9Q== X-Received: by 2002:a17:906:6a1f:b0:968:a237:f955 with SMTP id qw31-20020a1709066a1f00b00968a237f955mr33784630ejc.64.1684394881605; Thu, 18 May 2023 00:28:01 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a2b:c408:5834:f48e]) by smtp.gmail.com with ESMTPSA id g17-20020a17090669d100b00965aee5be9asm594241ejs.170.2023.05.18.00.28.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 00:28:01 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Pierre-Louis Bossart Subject: [RESEND PATCH 04/12] ASoC: codecs: rt5682: do not store status in state container Date: Thu, 18 May 2023 09:27:45 +0200 Message-Id: <20230518072753.7361-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> References: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766216160305991129?= X-GMAIL-MSGID: =?utf-8?q?1766216160305991129?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Pierre-Louis Bossart --- sound/soc/codecs/rt5682-sdw.c | 5 +---- sound/soc/codecs/rt5682.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt5682-sdw.c b/sound/soc/codecs/rt5682-sdw.c index 6e3b5c5eced1..67404f45389f 100644 --- a/sound/soc/codecs/rt5682-sdw.c +++ b/sound/soc/codecs/rt5682-sdw.c @@ -500,9 +500,6 @@ static int rt5682_update_status(struct sdw_slave *slave, { struct rt5682_priv *rt5682 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt5682->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt5682->hw_init = false; @@ -510,7 +507,7 @@ static int rt5682_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt5682->hw_init || rt5682->status != SDW_SLAVE_ATTACHED) + if (rt5682->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt5682.h b/sound/soc/codecs/rt5682.h index d568c6993c33..301d1817f8f1 100644 --- a/sound/soc/codecs/rt5682.h +++ b/sound/soc/codecs/rt5682.h @@ -1440,7 +1440,6 @@ struct rt5682_priv { bool disable_irq; struct mutex calibrate_mutex; struct sdw_slave *slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Thu May 18 07:27:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95682 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp302705vqo; Thu, 18 May 2023 00:29:54 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Kp6eKxgxuNG61JA2gVMN/OUWiwp/VFzjCCJoQzaqG1EJbt8rCGObPnmVgDhwOjqlLpYG9 X-Received: by 2002:a17:902:c203:b0:1ae:52ea:5fa6 with SMTP id 3-20020a170902c20300b001ae52ea5fa6mr1737305pll.8.1684394994598; Thu, 18 May 2023 00:29:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684394994; cv=none; d=google.com; s=arc-20160816; b=aQVYZw87M0G12obGTXqzeZIWswBTDcXgrTG9IeqXV1m6pGGhn7kzDu+bO2rYYKd6r0 Fm35DDLKpjNjMJDI7cUmW3I2TJsX0i0EJh9JvKDtVxiCiII0bx8JJmC4S1LPLBStbNeS 9aj5G9aZ+Ljukih1uZuqR+YnpntQ7srYMqdAmcD4oP/SLKKlTNTS6rTv49g6rsmDylXh +TcY1ss3AG6V4nNa6SP6+JUvk5dG7hoLqHafp5BWVCxH2J5xQAiYuuGS8Hs3bShl81t+ QPeR5pxJ1vxGe/5fnXAFDYKtceDOuburGHYI0xqeX+zgt3YGVs4laGulCJGArPBP04Cr ccIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=C1eT2t6FyxP9v83v8PrBLX9IzlgvVZW+pMXaKU/JtJI=; b=U74taYo4l0fTtoU92qwZfLr7ZdpmUTdbJ53AQBi3jAsdgmRmtLFsa6W7IC++P5VRoz CM3AI82bZJPHTzY5Nf/51oQuWNtK1rY1zWoEo8kVRqm5US41KuFLbQbJORIWmHtWZAkt v7txcy8z71rQOoZx2D/6o2zjogeac5BNQq3HlCq8vNtX+J/ZCidpZOrBbG76Ei/5elMl jg0nWCXz9IOUKEKCrpMedzj1I6F4MnOJxOJgeNZiap6ONJUawfh/qDOeVxxLvbPTegCv mWsM1olrLhmcdQfpr6WgmgzQhUSPgmZUB3He1zszDyvHfIj+Kf6wKHaLhF66c8fT12eK hN1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=M8Z6vWY0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bf6-20020a170902b90600b001a97e24eb34si668664plb.201.2023.05.18.00.29.39; Thu, 18 May 2023 00:29:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=M8Z6vWY0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230148AbjERH2X (ORCPT + 99 others); Thu, 18 May 2023 03:28:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230088AbjERH2F (ORCPT ); Thu, 18 May 2023 03:28:05 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3430F2115 for ; Thu, 18 May 2023 00:28:04 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-510b6a24946so3165038a12.0 for ; Thu, 18 May 2023 00:28:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684394882; x=1686986882; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=C1eT2t6FyxP9v83v8PrBLX9IzlgvVZW+pMXaKU/JtJI=; b=M8Z6vWY0wCGKAcqY9LaP8M36odcIRn0KCyKWNrqM5ddKXkyrIU91p680g/kzWZJm2w 09b4ex46qbjwZSYSqaACstpD+I9r8FxtvIOG1XjHF+EETJZmimB0gy8lziYy3wmWV4ql viZEV65VAOX4zkrD/hQnwsW0GPCcMaqQ4h32e2qTlqsHBJ3smGTN38fbiGQfqkDthQ/H oUcxO2J04xq+u6rPLfZfVH9wO/byS1P5SNfQOBflWeKZo/WjWtkoZnV33IdBu2iVmxZP BhFufBFLBwHrli6CC+Mpz0HEzlIjFupoepTi6k1k9Wr+V2llmRdxJJJm4xDlGWhe2KIY KiHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684394882; x=1686986882; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C1eT2t6FyxP9v83v8PrBLX9IzlgvVZW+pMXaKU/JtJI=; b=i53zL6B6+aJM1H41inT27zNkfSm/lonvOv3uK+7uRFNIdwMocTgadmyCz9uH5cKl48 Kj3yjhRXEnYb1yFAzbmAucpmkj4pCKUr77MvdqkH931laSj4DLkm24LpaTf06Y8mNGkt JOw4IQBQAloCyNmB+pvpzUkluQcBkhhi5Jonuk2Vr7Sox16nk+KD9okFoX9/KfHaP9iZ 1RFW/wNWXKfwgI2lkwhhtnn1E5sJTnRi8CN8xzT9P8q+fZA+nSt7IoE+HGwMiMeUb5GP S+9wrmcCZATUOyQmRciHKl8RFQYeuien13Jvmx8KjO8kXPWUn8O1j9Wen/KQwdO9XmW/ LBTg== X-Gm-Message-State: AC+VfDzeI4TGNNbaEDfV/m3DHYCP57Ku3rSMSciW2xCAYzaO3upU9F+S 1B7Rl0nL8thDXTbZm2qUQYG0CA== X-Received: by 2002:a17:907:a424:b0:96a:246b:c65d with SMTP id sg36-20020a170907a42400b0096a246bc65dmr27786016ejc.12.1684394882778; Thu, 18 May 2023 00:28:02 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a2b:c408:5834:f48e]) by smtp.gmail.com with ESMTPSA id g17-20020a17090669d100b00965aee5be9asm594241ejs.170.2023.05.18.00.28.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 00:28:02 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Pierre-Louis Bossart Subject: [RESEND PATCH 05/12] ASoC: codecs: rt700: do not store status in state container Date: Thu, 18 May 2023 09:27:46 +0200 Message-Id: <20230518072753.7361-6-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> References: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766216165895296114?= X-GMAIL-MSGID: =?utf-8?q?1766216165895296114?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Pierre-Louis Bossart --- sound/soc/codecs/rt700-sdw.c | 5 +---- sound/soc/codecs/rt700.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt700-sdw.c b/sound/soc/codecs/rt700-sdw.c index 96fc5f36d0d0..ba7767bee07c 100644 --- a/sound/soc/codecs/rt700-sdw.c +++ b/sound/soc/codecs/rt700-sdw.c @@ -315,9 +315,6 @@ static int rt700_update_status(struct sdw_slave *slave, { struct rt700_priv *rt700 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt700->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt700->hw_init = false; @@ -325,7 +322,7 @@ static int rt700_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt700->hw_init || rt700->status != SDW_SLAVE_ATTACHED) + if (rt700->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt700.h b/sound/soc/codecs/rt700.h index 93c44005d38c..491774d207de 100644 --- a/sound/soc/codecs/rt700.h +++ b/sound/soc/codecs/rt700.h @@ -15,7 +15,6 @@ struct rt700_priv { struct regmap *regmap; struct regmap *sdw_regmap; struct sdw_slave *slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Thu May 18 07:27:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95683 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp302784vqo; Thu, 18 May 2023 00:30:04 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ635VY+WoBxFIHJ60IgcKlsv6TBuly5upsz0lCDrMAaEdmf9K6E64wEi0UJB/Y4nR5a4a/l X-Received: by 2002:a05:6a00:8ca:b0:646:c30d:e9c2 with SMTP id s10-20020a056a0008ca00b00646c30de9c2mr3258670pfu.28.1684395003932; Thu, 18 May 2023 00:30:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684395003; cv=none; d=google.com; s=arc-20160816; b=ZCtMrJ4i5kKEdoXx9CoI1L2tj6L/TxqdsJYePyLVYDRpbelHyk+NAYc0WJN2liJog+ BI7r0Ny4pmFRpZuLVDqF/4wAzYuaz+yKyo/92/0fMO/dxI2rBd7xTSmlMVhrnFwRGB/Z Jb1Ii1JxTE6AtPAn/ZuUway9swntBUKqqmdiDauoNhZyeUwD72SRvVu2abbkn9yBdDul IeFVYCGoZp7s8mUPru00DJCqU8iWTrwJuF4tJfJnqXjpCaUwyDUGEAyE9Dj9ZljSimvo wOy/px+5pxKNhMjFuVqdzQjVgr26z8+Fp08uWNwMXisSthTzQvJeRzBBrCMzjCMB+nH6 +KQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fXL5o5qPvph6Jym30uHyOqMAZEOM4W+jtVScVxTiDlk=; b=pmWByqT8BvlrssouPOCUTwALx8DLwZShjOSzWKXwXiSzGo+Kz7xGdTCfp9XsSpC4IP Wdb/N560IiJuVs/mO3qqoK/ZJEiWgIhuZykC6RXk/r9+cqPOjayzVMXToKIZdOANZxkF 8qSAbryVVB4Ur8rgNKbYYB0mfSQ0Lc7yi8zoEUvfO6IksOaZbkUirNMfc20MQe7aXOxx eCOhJRjmwLMNpoaudKqSpvo7BIN10bwY9UuOwaEna1jAyDDXFvK8B3opkmaVnn6VNqyg 39reXa8fVJ/sRDOCWJbqPWtJC+SGYQGHhttTIiGugiP5q6Hm2tmmN5Kwh0LqqEcB3IJt ISlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ryT3oII2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x24-20020a63db58000000b00521075bf591si748925pgi.534.2023.05.18.00.29.48; Thu, 18 May 2023 00:30:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ryT3oII2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230155AbjERH20 (ORCPT + 99 others); Thu, 18 May 2023 03:28:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230108AbjERH2G (ORCPT ); Thu, 18 May 2023 03:28:06 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 711D4213A for ; Thu, 18 May 2023 00:28:05 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-965b5f3b9ffso177815466b.0 for ; Thu, 18 May 2023 00:28:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684394884; x=1686986884; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fXL5o5qPvph6Jym30uHyOqMAZEOM4W+jtVScVxTiDlk=; b=ryT3oII2qDSHvEnNd8R3Sxowcji9SoTEbJkcGp19IIs+FWqR5+MsE+p0x5qh15PDQd i6kTbi07i9WT+RjRbfYWccwFP297hTr1IW9+vIW4y4ldZsySI2GacVMRsOWHWD8vRcXw fCCnIuBKoI3pQB7+fpAmk5rlAASAmGvL26SC0XR8c6iX5K3N3H6oIawvpL+EHYoS3M5v HIx3FfeqyJLxmgdWEtMNZpAKwrdmlAmTdwGVSFpHRDWy8/1qpho/tf2ePrHktnIReFPK 3viszkD0I3ZkFL5h9H4v05K/ZzLF1WRU3TmaQZb8h16t18DKTxcZ8XTnXie3BvMdrFJf PcHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684394884; x=1686986884; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fXL5o5qPvph6Jym30uHyOqMAZEOM4W+jtVScVxTiDlk=; b=lr+UQ7Pl69eovTjKnbMf/15cXcvBURrlAV6UG78n9Swaba5YWF7cvfMzA5QXNmuHg/ 59wpYqCaOGMm82oCOpYc2ybriDulOwE5O/t6V1EMWG71KSv6d8M5RyYwO7qR3vAwXHjH jWtwbORsk8U0BJkMI4paRMNB3qzTuM3vZt66zdmRx5cJwL05HRCTYgggGQxUAnBBz0Do Hu0RMPw9ywYIDCA6Q5op30W9zjKquinOEWrI+j8/nB0q8/K35ngMFshv6TpC5lM8owlK 4JbxKTrZhDrvD1sPJtQtxneLr3/skyKqKwDKDZCJ1VBGnEcrgH9gTYfgUOcRMzFLR0qo 113Q== X-Gm-Message-State: AC+VfDx47ZV41pe3imoujVFBtP7U9v7AIC/GC4jK78KjESsoZh7f3Jsv TEL1QnCe3BY+aj3weu2BhpTT+fliXd37WVZjVrVvJA== X-Received: by 2002:a17:907:3d93:b0:94a:4739:bed9 with SMTP id he19-20020a1709073d9300b0094a4739bed9mr5233414ejc.13.1684394883911; Thu, 18 May 2023 00:28:03 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a2b:c408:5834:f48e]) by smtp.gmail.com with ESMTPSA id g17-20020a17090669d100b00965aee5be9asm594241ejs.170.2023.05.18.00.28.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 00:28:03 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Pierre-Louis Bossart Subject: [RESEND PATCH 06/12] ASoC: codecs: rt711-sdca: do not store status in state container Date: Thu, 18 May 2023 09:27:47 +0200 Message-Id: <20230518072753.7361-7-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> References: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766216175764018516?= X-GMAIL-MSGID: =?utf-8?q?1766216175764018516?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Pierre-Louis Bossart --- sound/soc/codecs/rt711-sdca-sdw.c | 5 +---- sound/soc/codecs/rt711-sdca.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt711-sdca-sdw.c b/sound/soc/codecs/rt711-sdca-sdw.c index 51f3335343e0..2c5eb28259dc 100644 --- a/sound/soc/codecs/rt711-sdca-sdw.c +++ b/sound/soc/codecs/rt711-sdca-sdw.c @@ -143,9 +143,6 @@ static int rt711_sdca_update_status(struct sdw_slave *slave, { struct rt711_sdca_priv *rt711 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt711->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt711->hw_init = false; @@ -168,7 +165,7 @@ static int rt711_sdca_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt711->hw_init || rt711->status != SDW_SLAVE_ATTACHED) + if (rt711->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt711-sdca.h b/sound/soc/codecs/rt711-sdca.h index 22076f268577..11d421e8ab2b 100644 --- a/sound/soc/codecs/rt711-sdca.h +++ b/sound/soc/codecs/rt711-sdca.h @@ -19,7 +19,6 @@ struct rt711_sdca_priv { struct regmap *regmap, *mbq_regmap; struct snd_soc_component *component; struct sdw_slave *slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Thu May 18 07:27:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95684 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp302820vqo; Thu, 18 May 2023 00:30:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5a6I3YLcFQd3imMs1tml+UUzyXMYEOySrZihP4eaCsSd0PNuUzu30IhENs8atMTr0Mg4Zu X-Received: by 2002:a17:90a:1181:b0:24e:4a1a:3994 with SMTP id e1-20020a17090a118100b0024e4a1a3994mr1649101pja.3.1684395008560; Thu, 18 May 2023 00:30:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684395008; cv=none; d=google.com; s=arc-20160816; b=htSDq4e9zJxO5V6Kp5Av9atp/6wshi9+tSXG2MTsbglvf7u4edsjFTqYgUtpNYdFQy 2zD6wRFKIFg5O6R4pNy2o2DyhVVChSSUirMapxnp1I3kJ05zH2vij3ASMUnPBqN4xqXP Po3R47AYqieooOMPBbU5L20M+RdWP/CK5TBLqchrF8/tej8S6PLi/dL0ZHGwa8GcRTI+ LPsXKPUjtptoEROAH2hcJgJaCcf8OlIO9msUg9H/QV8nn6yK4Ku4j15QWhIM4glJ/hnV PFWXPar4SiyO7Iv14/26qO55MKdwynCD5XTHYDbxTQSIi0jxd+RF4SVl8227z8h+kTVj KinQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=XZcG0tmVXg695NcraCbh92aOOhRlMkU+haSPEq2t8Oc=; b=SZI8zWjeenw31qhAQct1EpGp5lItJhlI5lunvDinp6CpEkhwVABN2jWsdryGXvAgpn qR64fo+cSDbbOOi3iGva9CNdPtRE346lus1ziVvwqeAgkqQcpRuNvY29Tj+VDkekboTH Eysc1+C9Gv+p5rVhu0Tbnb+lFKtOwTEjP/3AMqmtMCqMSOjdNLZAKh5RydG+n0O3ztcj fW0tbKVu3s+3UYaEffkmG6vI0qX5ik7HSRglwJpAlK1dknuhS1fWFUj5Oxhqnyfu2CBM NzmAnxjlzFBPghE9O7+UG5WnrhwfXQT3VgV65Oc0OD+yVv1wvbtnMJibUGBamjjF5fQl 1mhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kqlVceO0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h2-20020a17090acf0200b0024e1ae3fb36si3550953pju.128.2023.05.18.00.29.53; Thu, 18 May 2023 00:30:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kqlVceO0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230160AbjERH2b (ORCPT + 99 others); Thu, 18 May 2023 03:28:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230109AbjERH2H (ORCPT ); Thu, 18 May 2023 03:28:07 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A34A519BB for ; Thu, 18 May 2023 00:28:06 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-96b0235c10bso308531166b.3 for ; Thu, 18 May 2023 00:28:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684394885; x=1686986885; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XZcG0tmVXg695NcraCbh92aOOhRlMkU+haSPEq2t8Oc=; b=kqlVceO0GYGYsCRODhYZpkuyquIG9tGnV+eKMqZNHFtn5bmjaMeQNDmIEqV0/Srk4J qJh6FxhAkoM/SFU4Z6Vn3DviBh6qiMGUMcmO0yhXb7904wb7AsJwj9qdDcAI0sj6G7Tk rkz1/gHrydVt9UQsmYxqM9fnoPZzxZ2bbw77m2s1NFmbTpwIgq4C1ofrJFtY+6TD0CVY 53l4rvZ741mvTSAubv2RZuEtlXizhMLlHnuAMUFyN6C1NxdTCB5ILVcXRhpy5B9wvhGL QJGpb3ruBj9ZST7urHEaiU24IU0IAFqBZbmUBZNo4+xHihGhTZ8zd8L+tJZ+mML264E7 aP9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684394885; x=1686986885; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XZcG0tmVXg695NcraCbh92aOOhRlMkU+haSPEq2t8Oc=; b=LU7DR6tEz8DfUJuhfrm8i5bhZWra2tYl+mC1o7IMxLdzV6kfQ5mbgXq9hRb2c8x330 B+GOa9syw1oA1Vt5C5DqNKgcV6Lj4+Fn60O5TBkcd7S4C8EJe3O37CQ+eD6TaO3wUEnB tMwZ/emgpCzefR5T99PC4Uc1rZJo4ur1rpDPinGgYCGwwSGDaHUtG3X6vfzNzsOFPiAO CbG26cCSk8J9iLbE+fjZbtB/z2UZa4eYVbKZhPN6osFRwoUirUJ+VHaUl5UpmGxzrAG8 W7i47DPZAaqQ/HSQKtveFT2ac6e1CexhW5EVMEcqysG/Zf2X+juVAgZ0iUsVc6EI+/ZB aFSA== X-Gm-Message-State: AC+VfDzW1MTyFqDIwDnCDbR8bY9uQyO0r2fF/8b6R/yqO0uSTeaZse8m Y3BDIE/hN+A0M0RnKc+bBjjUcQ== X-Received: by 2002:a17:907:9405:b0:957:12a6:a00f with SMTP id dk5-20020a170907940500b0095712a6a00fmr38215544ejc.21.1684394885268; Thu, 18 May 2023 00:28:05 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a2b:c408:5834:f48e]) by smtp.gmail.com with ESMTPSA id g17-20020a17090669d100b00965aee5be9asm594241ejs.170.2023.05.18.00.28.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 00:28:04 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Pierre-Louis Bossart Subject: [RESEND PATCH 07/12] ASoC: codecs: rt711: do not store status in state container Date: Thu, 18 May 2023 09:27:48 +0200 Message-Id: <20230518072753.7361-8-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> References: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766216180498257890?= X-GMAIL-MSGID: =?utf-8?q?1766216180498257890?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Pierre-Louis Bossart --- sound/soc/codecs/rt711-sdw.c | 5 +---- sound/soc/codecs/rt711.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt711-sdw.c b/sound/soc/codecs/rt711-sdw.c index 4fe68bcf2a7c..b8ed3c6236d8 100644 --- a/sound/soc/codecs/rt711-sdw.c +++ b/sound/soc/codecs/rt711-sdw.c @@ -319,9 +319,6 @@ static int rt711_update_status(struct sdw_slave *slave, { struct rt711_priv *rt711 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt711->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt711->hw_init = false; @@ -329,7 +326,7 @@ static int rt711_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt711->hw_init || rt711->status != SDW_SLAVE_ATTACHED) + if (rt711->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt711.h b/sound/soc/codecs/rt711.h index b31351f11df9..491e357191f9 100644 --- a/sound/soc/codecs/rt711.h +++ b/sound/soc/codecs/rt711.h @@ -15,7 +15,6 @@ struct rt711_priv { struct regmap *sdw_regmap; struct snd_soc_component *component; struct sdw_slave *slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Thu May 18 07:27:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95685 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp302957vqo; Thu, 18 May 2023 00:30:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6HAnQ/XDhZAzrxUz7Wd7uvuRsTs0YqLQ7b8rWvchTg1SLQEeL8MJw0CJL7jlzo72ZCr8FB X-Received: by 2002:a17:90a:bd94:b0:23f:962e:825d with SMTP id z20-20020a17090abd9400b0023f962e825dmr1538512pjr.1.1684395019697; Thu, 18 May 2023 00:30:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684395019; cv=none; d=google.com; s=arc-20160816; b=kKSVFawyEf0Bv5aCDtkXp0q9YmYAiORC58pbJmQGQn9ytBpwFLRcpsuQdMvBOstm2r QFlcjQsujPjZX98jgMWVGowZkeGHFM1Sd3+ssJYyw28dGCWLdUEm3qhgp617GMmDtvrs I/vjBMGB1AE4J1VGYxsjO3hQ8EMs/2bpiDWz0IHhaHadt+ndgCHzBG7fccL5TlYj8PK0 OW5s03igqjB3nVBupK+FJjY9vy8EYb5x0YvXl8gl0rCjft0Sv2A6tl8LL4TCoem/jwwB ajlWgtI7N7j8kGBeKerjV0byxIfNMaep9KFeG4I2cU67IPsr44EqQ+IS9otclclW6HEW +wZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=YAnyusDSWoWYoHl8ExRyZExxONPzTQENQiwitAy+Yow=; b=halBPRa/Ek+86/oA9U+ntu3V+b4iMe0EKprYJ4OzUfUpCLBKxCa9Dtar802JDQRrDd HeAswCkDhTMJ/R+P+XPrUWBXjDHchPI73A8pzY8E/nqfBEwZUsNOK2E6aD0+DoEEcwzC /D15bfzTgvS1LJ5gk0BAUOrDgiG1+Iakd4YQpE3hCDu8/yMxutk+QTr70AF8SjiCC8Wl 4i1dSsKewGTUxk/LoUW3KLG+IJOi5dVSqCu8Qm3GGvLzmIjZuq8UOwcxxLEVAl+xsz0P 39KQFSCJoR15K/HPRMhJREIQcf33NLRjRglrGyWFVXmO08v1UDqZj5FFtu3t5mLT8xxQ /FJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fGc0R2lA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l197-20020a633ece000000b0051b85b5a3d1si776410pga.127.2023.05.18.00.30.02; Thu, 18 May 2023 00:30:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fGc0R2lA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230165AbjERH2e (ORCPT + 99 others); Thu, 18 May 2023 03:28:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230111AbjERH2I (ORCPT ); Thu, 18 May 2023 03:28:08 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D91EA2101 for ; Thu, 18 May 2023 00:28:07 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-96a9c44ec4bso177403666b.1 for ; Thu, 18 May 2023 00:28:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684394886; x=1686986886; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YAnyusDSWoWYoHl8ExRyZExxONPzTQENQiwitAy+Yow=; b=fGc0R2lAtf83BfVI6TvwcDj2bdZJTVJZqt4QHboCsxtKA0NQJfBqJqUxxJDCmQfDql VSahfgrHD3mnGLxahg7xk8X1YbExxhcUrrUW5INaUyBgR74rNCJBZqO9i0Sc93LZeXlF V8YFqCJzT/ulYdMA/4oqonmaURd3fn96NaHWKQkzNHj3o+Y+Yovm01/Is22QDfnv2Xxv +mxn/yVHYCknBOQFhLTivV5OP7w8wUsSB7npWly5VaKDSsoSIIKF+sK2JnVpJfhudJ0f 55/vf049iXJOBbjzw+10+Xsfwj/gP5WpRR8lOyYqV0q++J2sJGDarPcLSHPr3S3epPbk CBsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684394886; x=1686986886; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YAnyusDSWoWYoHl8ExRyZExxONPzTQENQiwitAy+Yow=; b=ZM2yuskNlQ0LMx3otV00oLnC+LWrCdUvZFYFUPekEC7FMRy5/CoeD2J/md7mW785BU 7Ie5dSjrAYifetmbKhAcKL+wFcRl3Lyb3SfezXm0R8xYOAfKMwIFSptagznwbTZvR9HP TjeAU+9+hfjCb6pZDwgwqrDtLAAfWQArBMlGehWpZg27khm7AICpUfS7uUIV8j7lPL9z LLCuSpti77nUo637X+eS3zk5HMCN9cONfybkNE/+EVDlpraXNVy/0FCUQ+5lpZqM2Mwl k16gmu7nd5OSdIoKl3SFzrI8GKFB5EGPPgiPMG4rrdOtUmnblTgazzakFyAiudNjnkCy GEIA== X-Gm-Message-State: AC+VfDximMcYGSwUks9lGAE7O4xk+OJzmRj5y71CfVP3LmnCN9+zHMDH h6FUrhvhGUbqoc2yNtjcZ30KXA== X-Received: by 2002:a17:907:96a1:b0:94f:236b:9e3a with SMTP id hd33-20020a17090796a100b0094f236b9e3amr4762971ejc.3.1684394886350; Thu, 18 May 2023 00:28:06 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a2b:c408:5834:f48e]) by smtp.gmail.com with ESMTPSA id g17-20020a17090669d100b00965aee5be9asm594241ejs.170.2023.05.18.00.28.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 00:28:05 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Pierre-Louis Bossart Subject: [RESEND PATCH 08/12] ASoC: codecs: rt712-sdca-dmic: do not store status in state container Date: Thu, 18 May 2023 09:27:49 +0200 Message-Id: <20230518072753.7361-9-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> References: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766216191974117494?= X-GMAIL-MSGID: =?utf-8?q?1766216191974117494?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Pierre-Louis Bossart --- sound/soc/codecs/rt712-sdca-dmic.c | 5 +---- sound/soc/codecs/rt712-sdca-dmic.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt712-sdca-dmic.c b/sound/soc/codecs/rt712-sdca-dmic.c index 09807b6d6353..847198e6c07e 100644 --- a/sound/soc/codecs/rt712-sdca-dmic.c +++ b/sound/soc/codecs/rt712-sdca-dmic.c @@ -803,9 +803,6 @@ static int rt712_sdca_dmic_update_status(struct sdw_slave *slave, { struct rt712_sdca_dmic_priv *rt712 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt712->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt712->hw_init = false; @@ -813,7 +810,7 @@ static int rt712_sdca_dmic_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt712->hw_init || rt712->status != SDW_SLAVE_ATTACHED) + if (rt712->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt712-sdca-dmic.h b/sound/soc/codecs/rt712-sdca-dmic.h index 74c29677c251..110154e74efe 100644 --- a/sound/soc/codecs/rt712-sdca-dmic.h +++ b/sound/soc/codecs/rt712-sdca-dmic.h @@ -16,7 +16,6 @@ struct rt712_sdca_dmic_priv { struct regmap *mbq_regmap; struct snd_soc_component *component; struct sdw_slave *slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Thu May 18 07:27:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95689 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp306030vqo; Thu, 18 May 2023 00:37:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7PpXxGyXTXBiy12066dsdr5vO3FThsYzt1k8G3RZMfreknPQCfcyYmbE2COzHXL0s6/tE4 X-Received: by 2002:a05:6a20:8e1d:b0:100:47a5:d754 with SMTP id y29-20020a056a208e1d00b0010047a5d754mr1257256pzj.23.1684395458706; Thu, 18 May 2023 00:37:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684395458; cv=none; d=google.com; s=arc-20160816; b=pWY88Osg41mpcUBvXFh33yGg5dLyeP3aNffzI4QNXZmsgpnof04bJT3Zwca2jnOJ6N 13v7RRTEmC+qC9VnFAYta7YGZaa4hU2OqFVQbQKj/0Y4OOBt1A6oTe4+3ORc93yrcf3a Vi9Og15wWnYGf7m8e0ZM9SDrLiMSOPH+2W7QayQpE0lYfiFQ0DcXo46eaKN2uSjxesbt /I0Obe0+C7mmBIoCpjnXltnuWIhV5zJH03vEZnT0LokCysRp4jbko8rQPf9CdJZnyAk7 RaOgoq9Cedm4TtCKiIl8ukThwQZLG+YFEcerbT/WQ3Ob/YYK4+MVcpra7INbeRARlxIv 3f2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qojvzkxpai9FaVqu5a3rsXDeVwEMlNrj9bbWfn2RUs4=; b=n0wnnZnlSgdXiceQEiGxlVdyjL4uuFccKUUUeDd9Zqi1mWmADKLitGY9YHvTRwxULt oGaHWIIcYDw9hajR2CKzqhZI5Y7svA6/B1iZIwsaWI/TNdjKJFmYKJSpoJxiJX01biTz s8dZP/hucbbENyVlSkkiXkTd4cT8at+tGyf7918tudIKWVgv/n4Zzum84R+UQG+BqIyh go5dKVBhxnGloGGv0GU4WxIf+SFIs7qVf+ewE3cpiJeWWYRYVk3BlPf2qYtfOz7++hJA rEusxErGmJmhp8b18m5fYVOhEPIl6OlX140PYSNq8sjICjydZIGMyBaGKTsfrjjL7XuT KmtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ekpuCluP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ce13-20020a17090aff0d00b0024e3527e8f1si1058344pjb.60.2023.05.18.00.37.26; Thu, 18 May 2023 00:37:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ekpuCluP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230127AbjERH2g (ORCPT + 99 others); Thu, 18 May 2023 03:28:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230117AbjERH2K (ORCPT ); Thu, 18 May 2023 03:28:10 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AA4F2686 for ; Thu, 18 May 2023 00:28:09 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-510b6a249a8so2980969a12.0 for ; Thu, 18 May 2023 00:28:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684394887; x=1686986887; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qojvzkxpai9FaVqu5a3rsXDeVwEMlNrj9bbWfn2RUs4=; b=ekpuCluPIWtdcF+DlLdXQuBzWj2T3yqpK1eo5JOW9J+oC2TnU4Cu1/c3Qnl+cfxOMw QBDnMXqS5j84+cx64RCXvTyFPrrcphblozW0EG3ZzG2JV1guL8LrjNwOtLCGCRsvPZ8S OuE6Binws0/Z/JuQXY+w2aI57UE1CxV3oiLNa2MzgQJ+3uHfPm+vH/1bl6BXXzLkK2B4 dNDXzwm6LPn9xO7B/LrYtwYKooOXnDsoQ89EboL03MI+GbDcdrNKo5x8aoUVPY0YphO2 n+f3oAlZzVl0enXvl953TFLLYHfNmW0zKDx2Zi2aAEcCyaSPpaWJIiuvpWghqsooIe6l Ppxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684394887; x=1686986887; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qojvzkxpai9FaVqu5a3rsXDeVwEMlNrj9bbWfn2RUs4=; b=hyNTmDCNfYTMNySdAtkfgXgsq+SHACnaQUcEzzBNLDuvR28315+Du058vyQ1vq+ULn hGp8n2t9Od8YGC6ym8nygn3rgfgzCkMWuuaqKVVrZ9jisCisgbp/zrQT/ZXq9id/XWaE S/NWCimkx573yg/uEW4rUeP5F6ck4k8uTSxazDHUuXYJ78w2DLjMOZ2YNxIS6jobXiCT nkXxc1IuzVGumu+CtdB89pk4Z4iQvZZdoC3/mTdjsq0O0rdYe+l4BqsCIDDLSWGVVT/i zTRd9JLdTPqQCKBc3X/h2MVqGVAJ0qIdsIE0C36y68myTM4nlcbPQcBsJ11ab6f/aT+e qYkg== X-Gm-Message-State: AC+VfDz4p0mnMgruYzYPJgjaaEgHOGyzXtplVs5cU7d5+FFLf/+ziDgI YXBiUQij3MfKZ/JEYEksPEpW4A== X-Received: by 2002:a17:907:31cb:b0:95e:ce3b:a471 with SMTP id xf11-20020a17090731cb00b0095ece3ba471mr42167358ejb.55.1684394887570; Thu, 18 May 2023 00:28:07 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a2b:c408:5834:f48e]) by smtp.gmail.com with ESMTPSA id g17-20020a17090669d100b00965aee5be9asm594241ejs.170.2023.05.18.00.28.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 00:28:07 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Pierre-Louis Bossart Subject: [RESEND PATCH 09/12] ASoC: codecs: rt712-sdca: do not store status in state container Date: Thu, 18 May 2023 09:27:50 +0200 Message-Id: <20230518072753.7361-10-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> References: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766216652794497902?= X-GMAIL-MSGID: =?utf-8?q?1766216652794497902?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Pierre-Louis Bossart --- sound/soc/codecs/rt712-sdca-sdw.c | 5 +---- sound/soc/codecs/rt712-sdca.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt712-sdca-sdw.c b/sound/soc/codecs/rt712-sdca-sdw.c index 3f319459dfec..8f65516e7562 100644 --- a/sound/soc/codecs/rt712-sdca-sdw.c +++ b/sound/soc/codecs/rt712-sdca-sdw.c @@ -140,9 +140,6 @@ static int rt712_sdca_update_status(struct sdw_slave *slave, { struct rt712_sdca_priv *rt712 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt712->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt712->hw_init = false; @@ -165,7 +162,7 @@ static int rt712_sdca_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt712->hw_init || rt712->status != SDW_SLAVE_ATTACHED) + if (rt712->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt712-sdca.h b/sound/soc/codecs/rt712-sdca.h index c6a94a23f46e..ff79e03118ce 100644 --- a/sound/soc/codecs/rt712-sdca.h +++ b/sound/soc/codecs/rt712-sdca.h @@ -20,7 +20,6 @@ struct rt712_sdca_priv { struct regmap *mbq_regmap; struct snd_soc_component *component; struct sdw_slave *slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Thu May 18 07:27:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95686 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp303190vqo; Thu, 18 May 2023 00:30:46 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4LVBxciX2M/+oUtQ+Oq5+JkRBGPt/q1rClYSLeJe4gz9cMxvVIvaNxc6lfRG83bxKS/VI4 X-Received: by 2002:a17:903:32c1:b0:1aa:e5cd:647a with SMTP id i1-20020a17090332c100b001aae5cd647amr2090702plr.23.1684395045786; Thu, 18 May 2023 00:30:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684395045; cv=none; d=google.com; s=arc-20160816; b=o/jfgYqcvfpYtIEznJ4B1N6lHUodVfD/vzkpNW3QZnexLGLpNTxgixKBLaqkISYRdx aMN2bkRYzTEaaeoLjfhkW5qdkXizaaDfCTkOPJn8UBxTiuidc7Uv92fFLOOCvfFwYuXK qeoydvyxcAVzYNESRrjd8OCZOPcLNXTC7ARgKnUKHq9VhebD5HKaO2A/sJlhnCyLCeRw RLmLBPYOkB6jjpyZmdbzRu2bL9E50ybmLsADigM5/kd2sgvHC6NxsWYaGQeEdwnw9PRJ TcMcRCjEZzie8l9XqCdZ/iXuRg7pYMfgLlAdYVHU6KOGEXKwldIA08DS8UuyhINZPZxh 4euA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WSuhjZFmCIUit+haslyLLFjLlYcrxcE4KHcrJzAwJBY=; b=e7YiU9OhFN+AfEuei4nP9BUu3fTQIWz3bxx4Y1LN1gPUmR32RKAcKmVGi0IsSu2KDh 0M5xCyNzA54nw2GE0JCgnI6KaUfnUrj4WG76rmLDtOJ8VhAsSnqB+gS+foik0tdWJIYt t+AGM70kWSkGLdL3T2QmiXzf7LkXww30H/Q6Q4pNJBnhjEEi7p/iWaxaIPBNUFYAhO9J PjF9AeVmF6HJW6tMZQ9JGZ2BpMjKSVlYXZf9i+T1oNXdF3iZLQ1JL7KUnjI6g6S3kIgn iGAUpVkrI7o1bkBNkZTD61Ica0wKDQvv3ZD5QHqk6QG52HfS/KuCKwJaAgr4ZlmfdWMP Jx8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TznhBWZE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l7-20020a17090270c700b001ab19e023a1si634507plt.375.2023.05.18.00.30.26; Thu, 18 May 2023 00:30:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TznhBWZE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230188AbjERH2s (ORCPT + 99 others); Thu, 18 May 2023 03:28:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230136AbjERH2S (ORCPT ); Thu, 18 May 2023 03:28:18 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A45A12D41 for ; Thu, 18 May 2023 00:28:10 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-965c3f9af2aso252795066b.0 for ; Thu, 18 May 2023 00:28:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684394889; x=1686986889; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WSuhjZFmCIUit+haslyLLFjLlYcrxcE4KHcrJzAwJBY=; b=TznhBWZE03vv3t6BYxwUACwueYgrs1Ep3am2yskk4mEYGRjuema9R0bhklB/A4EYwq xq/kh/yu/4rwL9VhJPMfJS0lEVnKKv1az7+D9EicsrG+MicaTGHQFqn3+JEg2DI/X7Fb C+qzU/kJAFGbXFHTHMMYV8g6qAusfkex407LywnkHKTONWMAX7lqCi/piOOmH3amTtuS ZkOf57RBU9nd12mJzy1DZpOD7RQvNhZOxMq2r4452BSN7mjw+j28ELcvKSNmmtTT+nPg hMxwfQIAv5NlxIp8w+yqPqay10dOLP70vMRa5pncT+r8uYjN7/mf8UfaB6m5XfjjjKTE vriQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684394889; x=1686986889; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WSuhjZFmCIUit+haslyLLFjLlYcrxcE4KHcrJzAwJBY=; b=Ev+Qul4pospSYrCrqX7VuYidN41hn1ZeHPzdTSn21Y4aCEsJ778Qwk9LAUS2ILpCh4 ocjC7Gc6uHzMyu9w/X909esumtWnzBve0Iqm4JhOV0j6ZJHXdA7uNUZpjZm/SF/1Z0CX yr/F7s151MAUG/eGNSt2NDBgFavb+0NHg41XYL06zgmREZqOMOFbfjOr9QlAUjO2n631 7Dm4Sfr6hEYS4YF4mOC7IkB8TEwfrmsxMNu5z+dfYnJwSvVB0+9dWrAucf5qGQygERRr zwgi8nZbEfdO0ol07nZRmPfh/41CKYuK7SOocTQn49fQRaKwltB9c0BSKdHn6qjmAXKv otTg== X-Gm-Message-State: AC+VfDzNRn08IsyTNL1ptZ2Uz/Nyxm76uO4g76YRxSQ+WcV5lTEVyK8a HYJsPDUdW4GM/0147SDC2Tr+SQ== X-Received: by 2002:a17:907:7293:b0:969:dda1:38a4 with SMTP id dt19-20020a170907729300b00969dda138a4mr32698956ejc.38.1684394888689; Thu, 18 May 2023 00:28:08 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a2b:c408:5834:f48e]) by smtp.gmail.com with ESMTPSA id g17-20020a17090669d100b00965aee5be9asm594241ejs.170.2023.05.18.00.28.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 00:28:08 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Pierre-Louis Bossart Subject: [RESEND PATCH 10/12] ASoC: codecs: rt715-sdca: do not store status in state container Date: Thu, 18 May 2023 09:27:51 +0200 Message-Id: <20230518072753.7361-11-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> References: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766216219393788172?= X-GMAIL-MSGID: =?utf-8?q?1766216219393788172?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Pierre-Louis Bossart --- sound/soc/codecs/rt715-sdca-sdw.c | 5 +---- sound/soc/codecs/rt715-sdca.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt715-sdca-sdw.c b/sound/soc/codecs/rt715-sdca-sdw.c index 38a82e4e2f95..7e5ddce8097d 100644 --- a/sound/soc/codecs/rt715-sdca-sdw.c +++ b/sound/soc/codecs/rt715-sdca-sdw.c @@ -121,14 +121,11 @@ static int rt715_sdca_update_status(struct sdw_slave *slave, { struct rt715_sdca_priv *rt715 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt715->status = status; - /* * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt715->hw_init || rt715->status != SDW_SLAVE_ATTACHED) + if (rt715->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt715-sdca.h b/sound/soc/codecs/rt715-sdca.h index 7577f3151934..e5d6928ecaba 100644 --- a/sound/soc/codecs/rt715-sdca.h +++ b/sound/soc/codecs/rt715-sdca.h @@ -24,7 +24,6 @@ struct rt715_sdca_priv { int dbg_nid; int dbg_vid; int dbg_payload; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Thu May 18 07:27:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95688 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp305536vqo; Thu, 18 May 2023 00:36:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7CBi+qT0ay9rKWdJ7o06y2l/xM9mLvlAVhNRbeWjzHPXX5+9VVqKJwUXGSH1r14Vfw+9ks X-Received: by 2002:a05:6a00:15c2:b0:645:cfb0:2779 with SMTP id o2-20020a056a0015c200b00645cfb02779mr3613635pfu.26.1684395381665; Thu, 18 May 2023 00:36:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684395381; cv=none; d=google.com; s=arc-20160816; b=sq/vbIF2pw2bponFuHtHUP/lpXhGuV+Q/AoG0vK6Ccd3u39UGGl7Y/Hh5aY2LSrusd TR7F+yhVyZRj/KLNcKRcwhTdL7xyhlXnKFN2Ll6LINHgRJuFvUJDRPQjoDZwyMdP9pfN FbO6CnvmnjhubvnGYb3bHZkppLLNPoFxINOGfN0EGxwotKedF1lCpmfn+Md4Hcd64Pvq 53T+VEldKXPWfJf564VCIX88sVTwkQV7VZFoKka8ISKL46pUWMvBUtU+sOUV3YvUtpq5 WbtbeldnfThHoCrT36t1ItsUU0GCXrR/lMUqkCKS/6Z3YwZIVvH3I7iAgb2m5sUNzSM7 95ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=XVXk2J0zDtxw+0Qou5QUMtzlXSrHNQ48trwuAxglr6Q=; b=bGlO2WRenF0sM9gen9lFnY3+3r5/N79i3ZO84ss8B+hnEP6uqv1bAp7GmRmWBMCpHL rEZi3BShjTQ88P9Vk4uC9S3zCRSObMBE/ZQws2Rqq9hnQWdrxJE0paYrw1iOL4vW9Aqz LlLStr+ngG0Yv6QjonLe7bCIRnWJcQr+X8tvLk4JE305H1UmZ6/Ha05GOR85z5G3GzFE H+HWWM0DhJM8F/VHSE7JyJYy3GYSDoe6csY8/ZZMftCuAF6HZHrxVE3qSCz995/6jMRL 5DwNJYdUdq79RlZjfeienRtV210PGQ22Ha4WdR4iowLtG7cd4RgRTNgb+WgYtz1zmQtF EylQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="SY4zlhD/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q3-20020aa79823000000b00644c38feecfsi1087713pfl.68.2023.05.18.00.36.08; Thu, 18 May 2023 00:36:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="SY4zlhD/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230156AbjERH2u (ORCPT + 99 others); Thu, 18 May 2023 03:28:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230088AbjERH2Z (ORCPT ); Thu, 18 May 2023 03:28:25 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D3D22D55 for ; Thu, 18 May 2023 00:28:11 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-96f0678de80so292210766b.3 for ; Thu, 18 May 2023 00:28:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684394890; x=1686986890; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XVXk2J0zDtxw+0Qou5QUMtzlXSrHNQ48trwuAxglr6Q=; b=SY4zlhD/Ae3NqKWMgCYMmnInKUuz8aaW8w1LrZj140mUYU5ssSsPDI2EaABgQV9yap Ernl5l+MQeuF813vs5dgtI3WN3/XEiNudVVFA0hkaEZ04MQ1bZCxFSWxvUdn6kImX9+V IgVBEGaTPpfiGrTgAqGxD32MVO3InaXImAWE2u9wbz7HoXqOsm+0equhQfc5EpKrAtEO stmHcBuSxYTR4GnFSv0T6INTHLSjpLcWbXQOs/KvYprUoPnIioiimgAKeyhBOhy+brFc tR0btKWih37xTmEtBAEVCjy5nGMy4zD622zLbnzNYpyK4K6T85rxfEQtxaaLr7X45K6F 9nGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684394890; x=1686986890; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XVXk2J0zDtxw+0Qou5QUMtzlXSrHNQ48trwuAxglr6Q=; b=Rhe/6vI2sEsTum8W/KyI4SB4/ITbEqP7ks2nHhONax+6GVT/jaMFXSjh4Zq14Jc11q /++A9as9AsdZsBAUYT+jm7AeUzKY/7IXDk/LOv53FQsw+VdcLucrB5AEZ1Neb7qUK/A5 lACszwa8/VmEJgeuQm933IW/hDhJtU+jO6jkbf9OJok+ha0NJ86ykWwQQq9EiHGp7T6Y P+BQJFPJWnFevD5PvtUPhUcjZRv9CQb3YHw+pr7rwqBRBbJoEEgf59PTHSNgLUmyiTCQ Kz2cqYYdxIBJd4XmPXEz6fLKLIl6rfTvpvT0FMjII1Lu5AqV7DByqL4Gm5EuA4alBKBf lqAw== X-Gm-Message-State: AC+VfDx2M5Kvu5NLjmE7ONHEy4E6OJ87kBnf3WtbWHEVcG9Xpn8X3DSi QIrt/sgz/DXrBVPQ1mEHHhkaNDJnOKqpyTGGF9epHw== X-Received: by 2002:a17:907:80e:b0:94e:9a73:1637 with SMTP id wv14-20020a170907080e00b0094e9a731637mr36831708ejb.75.1684394889884; Thu, 18 May 2023 00:28:09 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a2b:c408:5834:f48e]) by smtp.gmail.com with ESMTPSA id g17-20020a17090669d100b00965aee5be9asm594241ejs.170.2023.05.18.00.28.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 00:28:09 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Pierre-Louis Bossart Subject: [RESEND PATCH 11/12] ASoC: codecs: rt715: do not store status in state container Date: Thu, 18 May 2023 09:27:52 +0200 Message-Id: <20230518072753.7361-12-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> References: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766216571814450408?= X-GMAIL-MSGID: =?utf-8?q?1766216571814450408?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Pierre-Louis Bossart --- sound/soc/codecs/rt715-sdw.c | 4 +--- sound/soc/codecs/rt715.h | 1 - 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/sound/soc/codecs/rt715-sdw.c b/sound/soc/codecs/rt715-sdw.c index 5ffe9a00dfd8..6db87442b783 100644 --- a/sound/soc/codecs/rt715-sdw.c +++ b/sound/soc/codecs/rt715-sdw.c @@ -417,13 +417,11 @@ static int rt715_update_status(struct sdw_slave *slave, { struct rt715_priv *rt715 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt715->status = status; /* * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt715->hw_init || rt715->status != SDW_SLAVE_ATTACHED) + if (rt715->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt715.h b/sound/soc/codecs/rt715.h index 17a8d041c1c3..12a0ae656d09 100644 --- a/sound/soc/codecs/rt715.h +++ b/sound/soc/codecs/rt715.h @@ -18,7 +18,6 @@ struct rt715_priv { int dbg_nid; int dbg_vid; int dbg_payload; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Thu May 18 07:27:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95687 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp303393vqo; Thu, 18 May 2023 00:31:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6OtZolTAQ4f/PQ3KOADJDuEQIkTNAk4iJiSU05xW327+hF4EMOAx2cvYjc7v00/hLXL7jR X-Received: by 2002:a17:90a:158f:b0:252:98ca:e7ac with SMTP id m15-20020a17090a158f00b0025298cae7acmr1602826pja.44.1684395072274; Thu, 18 May 2023 00:31:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684395072; cv=none; d=google.com; s=arc-20160816; b=bFjXKK/ML4DdxIQrseZRNDPaQwytwdSI9emloThNkrkQ703TbXeE2ayHhaJjF3g4O9 1MVZwj+HBw5L4xos1pamsoYEzyM0b23gkLgHc7rxgtmFu+eFzomP4LWjIMokVS7Mv0hE y4ZN5+PAP6uMH40ZlylF0C7isNAF9vHFlRX6B737aguv0McVs6VQS3GNn+jYjx8bZY23 lCTDwOmDQFgsibgbmnzmpJf2f9CQAT8/CFWaubUPxzCM+IjeVu8pBtk/4JjuZcxG69wV 9vKcFT2oxbwnapQzOqAHeYEAoI/XMTr3nYI9IoH0q0i0dN/JEMlhnceObtgtBaKsRx8o aYIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=aIwJNTzxhNUSrbT0TXBGuXZECsHlorjZtBHAk3OzfKw=; b=P1DyqWeQizSKp+Sw44TTqoljfQxRVjCV3eVSyGDY1DHb6M8r5Zr823DicCe1zMYQxz yuJrud8IR9306dhOGbkTNnTDDnoBW4WKCnCOI2MLv/f/VRxGs2piY3KWdRd19CmQfhv7 UOJd8XbDcDmoK1rJQJZK7cA0wdOhG7y5DBm2i/kBVhNYnsFfj3/LH0EC87p9pgBWkBJE GBAV2SgByPZwumoa3ec4YE3BnVjG9A11FWu78nrrG+O9vTYFvqnuVck5zLai+keHKEho v774FXQ32J0zPF7PRgwfNIoUbLm2clEDU+9e83JYsIuhYU0AudbTRv1ei3kpK61ExlHQ kk9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oM+RXRYe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w28-20020a637b1c000000b005303c3dedc2si812166pgc.419.2023.05.18.00.30.57; Thu, 18 May 2023 00:31:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oM+RXRYe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230209AbjERH27 (ORCPT + 99 others); Thu, 18 May 2023 03:28:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230168AbjERH2f (ORCPT ); Thu, 18 May 2023 03:28:35 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 709BB2D70 for ; Thu, 18 May 2023 00:28:12 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-965fc25f009so300513566b.3 for ; Thu, 18 May 2023 00:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684394891; x=1686986891; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aIwJNTzxhNUSrbT0TXBGuXZECsHlorjZtBHAk3OzfKw=; b=oM+RXRYewHu4bLBr2ElIoV0dqPvtWyZM0qOHY/GFfmSdVrPTj24HiN13Hh7N8TAeni J5WYZxY71PrQQyURr3ZcPaKy25fwgtH9gFwJn5xRfVV+YN7j8Yg1IIVxxp/wI9aXf5Y8 n2GPRztj+HYrJ4tRS4qSrFvEZytlLMWMzvtkAIU4+gnpOMjkrAzXJUiw8D3OFvqdXkOp Y9C4Mjs64P8/DSnrbXzRNoMWa7x8uyymebiZANZSmRclRig3M6WKiWX9Mfv3q1gq3q16 ZpCP+MgXPKH2V0022YfM/aj/MxtPC8Jv9fMliQBdeYJP4QhbMx7ox+z3jhylUoAfhJZn fbOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684394891; x=1686986891; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aIwJNTzxhNUSrbT0TXBGuXZECsHlorjZtBHAk3OzfKw=; b=NR767v+Tc0kJp6bpDyb0TAfKvNvZLUBxtjdnzJRzCbVHGtNOxMY6cw6t0EiZjSlNwP 28fjWPvySwyxnXyVIqeB4koeMI08by/Bx49ppXXzaoxI4XX5lEpUxgi0POJtr3fDnDqL 3utEPG4iITiSahTGjtOIeK6C3x7mmdh3fcaorqhkjdVjhB/FCzlJ7/VQAE/2UkbufBtu bxwDFhD2Y9fLdp41BEHKeBeyiXyy7uR9Bv0hL5W5C5OYuRI3YDWJKGHtDWbCJOlepM0x FfMv49lhgOAGME9FhuYRYsKwxRSMIhhOAOqAzxS2nKSaNlug0sDi5kmxGNrJIkqU/yjG Qkew== X-Gm-Message-State: AC+VfDxArXNZFIrdXOAg9rJWhxpehYOrjUBBbaIyMmadZWH0z0tEn7H3 p3QtT/Rwc92LZjNB1JQ9C899Jw== X-Received: by 2002:a17:906:58d5:b0:969:9fd0:7cee with SMTP id e21-20020a17090658d500b009699fd07ceemr33147092ejs.10.1684394890980; Thu, 18 May 2023 00:28:10 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a2b:c408:5834:f48e]) by smtp.gmail.com with ESMTPSA id g17-20020a17090669d100b00965aee5be9asm594241ejs.170.2023.05.18.00.28.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 00:28:10 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Pierre-Louis Bossart Subject: [RESEND PATCH 12/12] ASoC: codecs: rt722-sdca: do not store status in state container Date: Thu, 18 May 2023 09:27:53 +0200 Message-Id: <20230518072753.7361-13-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> References: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766216247353685587?= X-GMAIL-MSGID: =?utf-8?q?1766216247353685587?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Pierre-Louis Bossart --- sound/soc/codecs/rt722-sdca-sdw.c | 5 +---- sound/soc/codecs/rt722-sdca.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt722-sdca-sdw.c b/sound/soc/codecs/rt722-sdca-sdw.c index 0a791a14215e..bfb2dac6bfee 100644 --- a/sound/soc/codecs/rt722-sdca-sdw.c +++ b/sound/soc/codecs/rt722-sdca-sdw.c @@ -163,9 +163,6 @@ static int rt722_sdca_update_status(struct sdw_slave *slave, { struct rt722_sdca_priv *rt722 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt722->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt722->hw_init = false; @@ -188,7 +185,7 @@ static int rt722_sdca_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt722->hw_init || rt722->status != SDW_SLAVE_ATTACHED) + if (rt722->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt722-sdca.h b/sound/soc/codecs/rt722-sdca.h index 5bc6184d09aa..44af8901352e 100644 --- a/sound/soc/codecs/rt722-sdca.h +++ b/sound/soc/codecs/rt722-sdca.h @@ -20,7 +20,6 @@ struct rt722_sdca_priv { struct regmap *mbq_regmap; struct snd_soc_component *component; struct sdw_slave *slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init;