From patchwork Thu May 18 07:10:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 95678 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp299755vqo; Thu, 18 May 2023 00:22:51 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7Wgw00npdnEamWrITHi4cgLErWLCtRTns/2t/n0cNXqCKpoRAuA+UAWA4uyqjPhYLuTCMD X-Received: by 2002:a17:902:f809:b0:1ad:dd21:2691 with SMTP id ix9-20020a170902f80900b001addd212691mr1711146plb.10.1684394571212; Thu, 18 May 2023 00:22:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684394571; cv=none; d=google.com; s=arc-20160816; b=og+8yrMRTwY/t1SlxyYowoOWojEFG3rdBvQeFsVJmK3OSFGGaXjPdZie7pGIpv84Iw VwPgKD6c+To3OqyUyV6jQui1rsN4ayVj5j0b6LJDDq/a8cILyBiP/8ptCnPfguSjxW8I 3PPu4ZuN7Rjnu94hQV6PyY/mSJIN5UcYhj5xjgQ0Qy6nHqzP9kvX4+BtbuNd/0MJuoWL 5qNwELLlx2xsMMWfy1lWYic3Tc67so4mrHs1k54tENfGA4C8W+Q24qCl1fV0vJeS3EH0 hLzaUXXwvgj7MW2TZG29WsDp++rAjOXtPCcuA4HIlJh/6at64SAZGahyBjicOUrJUA2M N3fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=F+zInelYRTBn1Bc3nl++TZglWSkvYGCgphkwfxYXGUI=; b=UsT3sFY2HkxmTMKIIpcsrprrFLMjw6z8MmzYnNSslwPnDfoZAA4ibXayac5Ai2HGCW 7XpNW0hvUXNhfZeCbQqHgbwSWhZCbMRFx7EpFZr6KEZfxRcO6NFcrPIGgZQUoI5YHY+c hWggnNFh6KRht1cO2F7FqgYeSdN57RodLWUMcduPKNUSv6mKfI+csHUL0dH2Ms428xE6 hHJN1l5k6lwYDvIIrNFGg4ypJ4nbk/9NKrdxvt6CiN9K3k2rfuYrIL2bx9GLvS4xvZdb UJbEL/8rElLPvF0aAU9fTP979Lz6SqDLMHWQ29NdlB8/Mae0UgtRgCs/TehnpnxlHYDd /ubA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@wanadoo.fr header.s=t20230301 header.b=jj5h5i+U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y20-20020a170902ed5400b001ac311fefa3si685081plb.115.2023.05.18.00.22.38; Thu, 18 May 2023 00:22:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@wanadoo.fr header.s=t20230301 header.b=jj5h5i+U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230049AbjERHKx (ORCPT + 99 others); Thu, 18 May 2023 03:10:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229917AbjERHKv (ORCPT ); Thu, 18 May 2023 03:10:51 -0400 Received: from smtp.smtpout.orange.fr (smtp-14.smtpout.orange.fr [80.12.242.14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 922CC10D9 for ; Thu, 18 May 2023 00:10:46 -0700 (PDT) Received: from pop-os.home ([86.243.2.178]) by smtp.orange.fr with ESMTPA id zXmapJCyDEQ0YzXmbpoAuZ; Thu, 18 May 2023 09:10:44 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1684393844; bh=F+zInelYRTBn1Bc3nl++TZglWSkvYGCgphkwfxYXGUI=; h=From:To:Cc:Subject:Date; b=jj5h5i+UBg8mXjxtMytCz3rOb/3ZuplCgQI7Qtmube/kc/QQnYDVSVNeRw4htK//5 JtCtXmMUqbJq96EQ2dpuiOHjg3Is7ZG3zDKWOUrK+ko4kGTcuDsrPINQ6qhP5Q0q70 yCn5VgPnQDvFvZ/NgNCMuopUozdGtPGJWiSWC+634Ft55qDtM1WNMC+fpjx/BEnGQ/ GTzk4kULOfnMzjSEIk14pCoEN08qbs9IO0TWBuIvrauEetjnYGh36xT/pXmczco7lV 6obaf4B7UzFX1Vln9AD8XW0fvSx3pgLG21OZTLdYyeIWjG0M4m4dIHHhdVnU2JUzOb AkY+DDx1mDgkA== X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Thu, 18 May 2023 09:10:44 +0200 X-ME-IP: 86.243.2.178 From: Christophe JAILLET To: Pavel Pisa , Ondrej Ille , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] can: ctucanfd: Remove a useless netif_napi_del() call Date: Thu, 18 May 2023 09:10:39 +0200 Message-Id: <58500052a6740806e8af199ece45e97cb5eeb1b8.1684393811.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766215721581954599?= X-GMAIL-MSGID: =?utf-8?q?1766215721581954599?= free_candev() already calls netif_napi_del(), so there is no need to call it explicitly. It is harmless, but useless. This makes the code mode consistent with the error handling path of ctucan_probe_common(). While at it, remove a wrong comment about the return value of this function. Signed-off-by: Christophe JAILLET --- The comment went wrong after 45413bf75919 ("can: ctucanfd: Convert to platform remove callback returning void") --- drivers/net/can/ctucanfd/ctucanfd_platform.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/can/ctucanfd/ctucanfd_platform.c b/drivers/net/can/ctucanfd/ctucanfd_platform.c index 55bb10b157b4..8fe224b8dac0 100644 --- a/drivers/net/can/ctucanfd/ctucanfd_platform.c +++ b/drivers/net/can/ctucanfd/ctucanfd_platform.c @@ -84,7 +84,6 @@ static int ctucan_platform_probe(struct platform_device *pdev) * @pdev: Handle to the platform device structure * * This function frees all the resources allocated to the device. - * Return: 0 always */ static void ctucan_platform_remove(struct platform_device *pdev) { @@ -95,7 +94,6 @@ static void ctucan_platform_remove(struct platform_device *pdev) unregister_candev(ndev); pm_runtime_disable(&pdev->dev); - netif_napi_del(&priv->napi); free_candev(ndev); }