From patchwork Wed May 17 11:14:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95183 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1050394vqo; Wed, 17 May 2023 04:15:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ57E4Ys69XABEP9oDRmNbzC5w2UFx07SV464fjFF8cq13utfRCviH19gHpPZP1lfRc0iCi3 X-Received: by 2002:a17:902:e888:b0:1ad:d500:19d3 with SMTP id w8-20020a170902e88800b001add50019d3mr25366916plg.23.1684322143007; Wed, 17 May 2023 04:15:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684322142; cv=none; d=google.com; s=arc-20160816; b=xQQEqtOp+AZ5J7hGP/CXou7uAcRuhHG8MiG8BRsrDWUBAnS+xHZE/mXF5TCmQ56qF5 Mm45sqlR9EDb0BHIUG+UJHnKUWiTjaHKx4sbSrH2l7Ydnm6/6v9G2VT1X7vNWMCs//dT XQ7JLcFoURtK6z3zDw9OqkFwl+4795RwC0XpvnRin2tY0flhdmqvTvPJvOuNo4H2hjce alDDqJKhP1QklqDM8EgG8dO7X4mS0rwAArIse8QcNzKY7mO+nCDEd8kZgRbIuyjjWAjq a5/Yyu9wY3elRxPTUfu4L2P28+rzTPORLHFq91pDjnZtyQAD1ETYf4kkqEq5D0DIfEXT 09dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=8f/Ov+L9lgAMMtQvsESvWR48vQlBSC6eGHRApShSvK4=; b=IlsQ1sHZbLBhGmIN8EevayA/PwSvYmtPOHmSfa2OVLTKctRMgSZ9tvBm0K/b0hD4pD eRu03ljF4XXz0G8Qflflz/RaU5msp5IkxcnMMFsKVkwIKrL7TpWs6IrBYqcBab77cLiM jKb0zIBv/5pyMQgq+ESjrqR7Szz4iBspkZLgTTBMU5HaOdp8+ngeL9hBz9MXPH49bIjP ZwmgjbU+zSMQ5lq7hQYX8PziVQNTwKpn4ROsFlkfrgael2SzHA2Xnd5d7/UCFXP93EWF fyiz9JXiGDEvZMh7PyC9vIDLvN9F1GMvtaPG/dJUOV1dyHz45jwHcaTjtv4ZnC9X2akx 0z5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sIfEiJbF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b17-20020a170902ed1100b001ab18eb1764si8637671pld.131.2023.05.17.04.15.27; Wed, 17 May 2023 04:15:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sIfEiJbF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230389AbjEQLO5 (ORCPT + 99 others); Wed, 17 May 2023 07:14:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230125AbjEQLOm (ORCPT ); Wed, 17 May 2023 07:14:42 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8434626AA for ; Wed, 17 May 2023 04:14:40 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-965f7bdab6bso111872466b.3 for ; Wed, 17 May 2023 04:14:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322079; x=1686914079; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8f/Ov+L9lgAMMtQvsESvWR48vQlBSC6eGHRApShSvK4=; b=sIfEiJbFesnboqrvDwg/JbxitCUki5aOESmQeTg6BQTaFmpQel55ARJNOzBd8Mm4FZ fL+tqM9jp+I4U1fmvk7eAQehUtyk/TO+AAf9RFsKbKkkeNL6LvaF4LYZf9tyVKUlhdHG i/DH2lMxWzJ7WPE4l4CfVfUWeP2GrHWEytoP6jrQX7Zkda97O0tWivR4CwTB9QHVEG1K rBrCq0Y2omMSb5Z4kuCIJMQcJtoef5ryB9wcSy0/JXqX6taG1+ccb7qg58us2ne/Zb0p 7V10XrAmSJFkQZ4ZLTGvktUpzOfMUh1Q3cz8HYSdwZJS0JiMw8iiZs2Yq8MuIiFD1/N1 tN3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322079; x=1686914079; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8f/Ov+L9lgAMMtQvsESvWR48vQlBSC6eGHRApShSvK4=; b=USG+B8m8dFBtOuwW1VlAu7vVzzRGDDTWrpReOjqyg5GXQ2w/pbZyOb9txGN4elu/nJ 6yLxBu0n1qtPjNZnpQFxUQebk033Oaaudk2FvpsVFUtpneyYgbv5a0ra2KAr7UniQPJ2 GjhxuBkTe8NyHRsSke2yW8HoNTb24FX/IUCtZFRtDLAKYeqbeAGoFeq2CJjSaFNgpEzZ MaJpdNwFZ3z4ZqrPAZEeC3Ph/GeLgfFvdT/jHo8LQFZYTb+4Yx7dXI5kEVUaVwTtfZ+s RZzMAgDWY+Q0MaWqe8EReVBvRNO8nTms7PaJRoJ5ra7Co4/XBilu55i7Eokl7cYi3gKy /4qg== X-Gm-Message-State: AC+VfDwhgfWiF3m4OwbuJLe+chvfdaIKtu5Kr1TS7umhTidl/9s4JfoL YsKlchlb2P/Wm0jNwNKdOx6Db52ndYFZmVFhe4s= X-Received: by 2002:a17:906:9c83:b0:95f:4889:412a with SMTP id fj3-20020a1709069c8300b0095f4889412amr39964429ejc.33.1684322078958; Wed, 17 May 2023 04:14:38 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:38 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 01/12] ASoC: codecs: rt1308: do not store status in state container Date: Wed, 17 May 2023 13:14:05 +0200 Message-Id: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766139775392597793?= X-GMAIL-MSGID: =?utf-8?q?1766139775392597793?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Pierre-Louis Bossart --- sound/soc/codecs/rt1308-sdw.c | 5 +---- sound/soc/codecs/rt1308-sdw.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt1308-sdw.c b/sound/soc/codecs/rt1308-sdw.c index 1797af824f60..313e97c94532 100644 --- a/sound/soc/codecs/rt1308-sdw.c +++ b/sound/soc/codecs/rt1308-sdw.c @@ -304,9 +304,6 @@ static int rt1308_update_status(struct sdw_slave *slave, { struct rt1308_sdw_priv *rt1308 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt1308->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt1308->hw_init = false; @@ -314,7 +311,7 @@ static int rt1308_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt1308->hw_init || rt1308->status != SDW_SLAVE_ATTACHED) + if (rt1308->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt1308-sdw.h b/sound/soc/codecs/rt1308-sdw.h index 04ff18fa18e2..f816c73e247e 100644 --- a/sound/soc/codecs/rt1308-sdw.h +++ b/sound/soc/codecs/rt1308-sdw.h @@ -159,7 +159,6 @@ struct rt1308_sdw_priv { struct snd_soc_component *component; struct regmap *regmap; struct sdw_slave *sdw_slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Wed May 17 11:14:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95182 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1050391vqo; Wed, 17 May 2023 04:15:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5F81bYFZbAhoJdEQRFqiPl77oIYqWfpRNOLRlQPX9O4iwSjyo/MSfawvknHpSdR8UV2jYf X-Received: by 2002:a17:902:a706:b0:1ae:1751:159 with SMTP id w6-20020a170902a70600b001ae17510159mr10844817plq.23.1684322143013; Wed, 17 May 2023 04:15:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684322142; cv=none; d=google.com; s=arc-20160816; b=DKeWJeCIJraL45TJvq1mDC2Zeh0QMZtbOVt1/CkM1VgNQBaC2PyNbywqIMeMMFB1Xi JORriMkBF30XV48eXwO4Gr0EjqJ4EfCwZPYuhhM6Mh7RT61k8qtUxspYCDZrADxT6JHz 7nFZX9CD6/TwjMft0rKxi2q4BXSjop35TvNWL9y2ZZiB4KMYxe1ns2uTHnoihuA5fmrz HB3vhZsKCP7lzRMRJHLtwgx0kIiRT9LWKmYjYaJ89z+X58pZvbXRgWHYh2foH8M3mqZk ndjsRVpZhYC1Pqcr8YyT3YhnZzhZuKxeozYklFZpLu2PEglCUwV/OPeIgLGYfmaa2tGp XwjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=MAqmALiwc11sAnAJSge5XtvJDOci8R9bv0tfhhHhu0U=; b=vXIVkP1CSpVqDRwh/An2QuRhk3+1MKZ/JrY56nxtQMtI8d2xJni3+0jmVydxt3Siv4 1NucNrJ13c/I3d4WE1wh1Apz9k80/2G4mtj2P9EA3b3PEbYO6bUdSDlnjxNvnH+DRBs1 B+mP/BUeG7vWEwhpEa7yzm9OsGqk+4bZU4PZQ877R4km3Qs9V22+8ZmeVQra20IWIZH4 FVc4lqNVCry+OjGpgLac0ltlQj3MjSCRP6RPlkGyQBMr93so7OpU7Yb487h8dkDf/N+H YMhLxZSS0wzLIiIudR12K0lQvK80Qsua67AnoN9EWWdB7jDttX4VJYB41z4VH65lgVxK tWHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Xtqjci4X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 13-20020a170902c20d00b001ab259969e7si20459477pll.31.2023.05.17.04.15.26; Wed, 17 May 2023 04:15:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Xtqjci4X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230469AbjEQLO7 (ORCPT + 99 others); Wed, 17 May 2023 07:14:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230334AbjEQLOn (ORCPT ); Wed, 17 May 2023 07:14:43 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7555A46BC for ; Wed, 17 May 2023 04:14:41 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-9659e9bbff5so105167766b.1 for ; Wed, 17 May 2023 04:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322080; x=1686914080; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MAqmALiwc11sAnAJSge5XtvJDOci8R9bv0tfhhHhu0U=; b=Xtqjci4XXLDyaSfLmoL3GH9a66Wn20m9qX10IAhmV5YCbC9FqW/gSQhxvp8mMTJpNE OeovLhwFZuK2cGjdqe0dZkA9Ub46RgWo31XNE4W8793NsgsxRjrvggmNki0sdcC711fF f4VYa5bA9X8UtiOddbUZ+4s80EGBHLCOYPLlv7FjFz++siY4Rfl+xFnUnRq5tDfWMf88 AcFqRubiMXgUBXyoKYD71Q1lzNzWT1TNX/S9RO0oqx8xKSTXTVnILq8W6YCY/mTaNHVz fV3YGEd2vKyHx/ryBmYY5Q105wjikO7EQ32VB9OLbL2lkz05+s6dOtVtyoXpk67lVD61 iSaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322080; x=1686914080; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MAqmALiwc11sAnAJSge5XtvJDOci8R9bv0tfhhHhu0U=; b=ZeUpT5VZO5wc1IAFq1OUPGyCe9IevMK+kHH0IyQkZ5TTdKVQywwIdLbUVRcOY/xI0i FrcmGl6He55jmI5LEoltIUt+Q07iMgJzuhS8BB8oOHnYYLljfwiLuV4YIk+XIq6RVfwL zTUiWwfEGUNTfvgvqcWBBEgjCU3WzGnYwwKo8RLFXBy5t4DBMFVk34WnjZHJIX+9maj3 PY4Ci2YaDEDDnmUnM5Zhlo5jAyzp5rCNOCl9ArcUKXARRdrZ3q5Y5hujitF6mvEFaMQ0 bk7V4VqJVhq7ufO0RHUJN4jLMr4XK3R8Qx4hexbTlSyi33vBKJ4iuTaRezVGuq9yAn6Q J69g== X-Gm-Message-State: AC+VfDwjvPtodLJvAqb4MWe6R7tcpGEyl3EjMedaRcOe4kx+5wkHuRAo hEFAyvVs8xkcg1mFwEwnysar5Q== X-Received: by 2002:a17:907:1614:b0:8a5:8620:575 with SMTP id hb20-20020a170907161400b008a586200575mr38600206ejc.3.1684322079941; Wed, 17 May 2023 04:14:39 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:39 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 02/12] ASoC: codecs: rt1316: do not store status in state container Date: Wed, 17 May 2023 13:14:06 +0200 Message-Id: <20230517111416.424420-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> References: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766139775344285960?= X-GMAIL-MSGID: =?utf-8?q?1766139775344285960?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/rt1316-sdw.c | 5 +---- sound/soc/codecs/rt1316-sdw.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt1316-sdw.c b/sound/soc/codecs/rt1316-sdw.c index 2ee5e763e345..601b76320124 100644 --- a/sound/soc/codecs/rt1316-sdw.c +++ b/sound/soc/codecs/rt1316-sdw.c @@ -323,9 +323,6 @@ static int rt1316_update_status(struct sdw_slave *slave, { struct rt1316_sdw_priv *rt1316 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt1316->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt1316->hw_init = false; @@ -333,7 +330,7 @@ static int rt1316_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt1316->hw_init || rt1316->status != SDW_SLAVE_ATTACHED) + if (rt1316->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt1316-sdw.h b/sound/soc/codecs/rt1316-sdw.h index e37121655bc1..dc1bfe40edd3 100644 --- a/sound/soc/codecs/rt1316-sdw.h +++ b/sound/soc/codecs/rt1316-sdw.h @@ -42,7 +42,6 @@ struct rt1316_sdw_priv { struct snd_soc_component *component; struct regmap *regmap; struct sdw_slave *sdw_slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Wed May 17 11:14:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95187 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1053049vqo; Wed, 17 May 2023 04:19:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Uoi+Tj66cURbk1VwXaJwO6K0e9Gavfbxl2EsrqL6sxxXtWnyw82v3XP/SPA+pYUvOcNKa X-Received: by 2002:a05:6a20:1048:b0:ff:1df3:51dd with SMTP id gt8-20020a056a20104800b000ff1df351ddmr43021817pzc.37.1684322398373; Wed, 17 May 2023 04:19:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684322398; cv=none; d=google.com; s=arc-20160816; b=OdTw+zq7dFCX7sOk19vihzrM6p8XepqG/q7D9R+clsQ9Y5PdLMmGKw3L3PRhVSnYz7 WcdjrMm7pP6EC4fUAVKnrJihkbnonZFV6p/WhuzKf9gQig1/5YWr04rDEtOSVZVJMELb mYYmfMbFQVhyZBTdSbgmL1UKLjomoGn9T/GvRMBuDAu2jWpbt58LLWt4WIvk5v+QyL5E /CkHbjTzcm+w3kAZIgrsvbWlLn/aEEqtMMQZ10zpPwlml0UFUrvQl8fFec33QmUneco4 zQYz92He2m1g1z2wnhJIInZWop7AOUsolckjalPMA3TDTMrgBk15UaLFeZi/CFXiFjVs zGxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=if7YQ3Jqyx8UU5QrJc7rocl2hzsm+T3skIrYgPJcbZ8=; b=Y/a0f9MChG6VVTr3BqQAfeHcdEd86mCyhinW//fPxkadYSyWhqc8cYh4/ktqAmIlTg 8VEBbdg57WMfoUif+k6dCeM/b2Hw5nrVLG0GrlrxDoXMSU+cknk9/sN8tSMO7dRu+FPr z6aIx0R+CXKYU7LliDK/GcuLlGj3T9nbt3+EwI+y9Qf9vfwgWnMYsfY+Vu6FULnVQVtW NClpV3J4m6UxrdRFjzi0l8COehhCoh35UObQDx0K8lFON7ZpI4KfxLB72tua6rThUvXi tjPxIQZlG+GCFoJXm7BOs+MgSo+RoGFDaQ7iZKfnCD+n8zsw4qd57X+FZnYMCOznylEM SXdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZZNYO7Tc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w21-20020a63af15000000b0050bd8dd1b5asi20820665pge.43.2023.05.17.04.19.43; Wed, 17 May 2023 04:19:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZZNYO7Tc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230123AbjEQLPC (ORCPT + 99 others); Wed, 17 May 2023 07:15:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229866AbjEQLOo (ORCPT ); Wed, 17 May 2023 07:14:44 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 886FE59FA for ; Wed, 17 May 2023 04:14:42 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-965ac4dd11bso112376666b.2 for ; Wed, 17 May 2023 04:14:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322081; x=1686914081; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=if7YQ3Jqyx8UU5QrJc7rocl2hzsm+T3skIrYgPJcbZ8=; b=ZZNYO7TcWQf/4w4gaLWDpyEDeka0OZxVnDIc5sRFsbyL/9iZbbCbx8vZeGO60WRFhB YLphCf2UBV/33sliiaI7pZOZcIbc4EdrzIGyc1D2yJtr5YqERyrQU6BHQw7geeHsJMgi A+7VlGTrw60J1oVPDJM1snYMD83sN+QavQAzljMoYOar3YRW+z75gZmjxEhfoGggEpyk iRtTJBOWA3sqG0ZOyMgr1A9JmnQySodh9VbOmIl2ePjKQol4vaxxWXB2+jg+lFNtGEpC P0iYa3Fh1tOvll/kwkHI+dcf6CvViL7HlLsqo05a+Pd7MhA4g2mCWbXJlRTm80zUD3yL zezQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322081; x=1686914081; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=if7YQ3Jqyx8UU5QrJc7rocl2hzsm+T3skIrYgPJcbZ8=; b=VR26/+onVy0uVKXgSuKd0PguzASaOvV5IutFcBCqdA+tTPKfI8WBFxCuqz9KkzVo1+ 1TMpm7+o7hu5tlG5i1D/kiwqEFBMvq7YqJlAm4EFEm/knp0LrtlAzWnczTZxoauEVmWu bb3fjwTEYY8xLs2O2KAayJ18sRMsLDqJCiSgHPmd0O5wqGrPnjGyJUjW8CMIogSK/ock 66iXbtjN+kd++wrJEj9SjSJ1ZInR+SoL/ljwoyAXdYD6flR5wbDmR9EzXGGwaes8AZu/ 8atAAjQlIDVMkqwB2ea22IH3G1fd0ufd9Ek8IchwDbaib5/p7D6f2M0MA5Ck+Ke+0v+8 pxCA== X-Gm-Message-State: AC+VfDyUUvrsjH7H9lDGCWc8j0yNNugdOvQhiXznN22aSqhHO5bvtAGr gADHhe8j+lpElnrs2T26FgVe9w== X-Received: by 2002:a17:906:5d11:b0:96f:181b:87da with SMTP id g17-20020a1709065d1100b0096f181b87damr66787ejt.69.1684322081001; Wed, 17 May 2023 04:14:41 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:40 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 03/12] ASoC: codecs: rt1318: do not store status in state container Date: Wed, 17 May 2023 13:14:07 +0200 Message-Id: <20230517111416.424420-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> References: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766140043191698213?= X-GMAIL-MSGID: =?utf-8?q?1766140043191698213?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/rt1318-sdw.c | 5 +---- sound/soc/codecs/rt1318-sdw.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt1318-sdw.c b/sound/soc/codecs/rt1318-sdw.c index 795accedc22c..3751d923611c 100644 --- a/sound/soc/codecs/rt1318-sdw.c +++ b/sound/soc/codecs/rt1318-sdw.c @@ -456,9 +456,6 @@ static int rt1318_update_status(struct sdw_slave *slave, { struct rt1318_sdw_priv *rt1318 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt1318->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt1318->hw_init = false; @@ -466,7 +463,7 @@ static int rt1318_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt1318->hw_init || rt1318->status != SDW_SLAVE_ATTACHED) + if (rt1318->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt1318-sdw.h b/sound/soc/codecs/rt1318-sdw.h index 85918c184f16..86e83d63a017 100644 --- a/sound/soc/codecs/rt1318-sdw.h +++ b/sound/soc/codecs/rt1318-sdw.h @@ -88,7 +88,6 @@ struct rt1318_sdw_priv { struct snd_soc_component *component; struct regmap *regmap; struct sdw_slave *sdw_slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Wed May 17 11:14:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95184 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1050450vqo; Wed, 17 May 2023 04:15:47 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5A/SkC6dZoVZFZfcLwlnVT5CV8onrIdkExi6oyW+FIELog0f8WorZHWCwradykwWsoKwon X-Received: by 2002:a05:6a00:2e87:b0:635:7fb2:2ab4 with SMTP id fd7-20020a056a002e8700b006357fb22ab4mr258723pfb.6.1684322147280; Wed, 17 May 2023 04:15:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684322147; cv=none; d=google.com; s=arc-20160816; b=XUdrsKfDE/z3FRtgqXB064+WpqS7AVvt6bMQ/MrS8VKA0Z+uiU8N+Vy6SPfVZ8yg5d vc7KdFM7gMO5C2Fs8X6jS6BA1e8hkDZ3gSFyOVv18pYrxP1/aGF5+u9BQ9PxPr98H9At V06iHOyYb1m945jZnPRufwGGqE7ogytbMloEPA97jp1JF5QUJFwast64sl3Imik9s9pQ RsEtjPxBpn1jBELwDp9gzCHa8vYb1yLERkKdpwXJvFM3Mt6fO3zSi46fLFfiC7ezS/Wf 6P5VcAvx6dv2pPhI8kbsvlHskhv+pi1uKw+29L+j19JHABuEL5qmroilyU30G+3dRDC4 /FKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HEOOEjR671HfmOXPgQqMUHzrdAM2unOi/T1lUcVo2j0=; b=KCy/7r9WMfHBfsaZP5HNjo02JB7Sh6nv+qaH+DM+5yg/AsWw49fEGUVQp5ugbjOdmL HSM1HpYXom5TORkOdAAt+H7f0aT4NnZkoLu/PnEfXAszI8sQJe1XpU7aRUdVWdWS5iie B7uFEoLG/WfeExkV6WyfsiBqgL8Tuki7YqO66IVQc26C1L+CdUN2n/tp51Q5/crY7BfE 4Dnk+VbM4VAL5pocrbzrsp5YpmtMIqgZM+t0jaL4JngBiZ5qheaBggkf+n8IKlu+ZytG Mgz2tbCHvrK5kR3i0mHsY7BZ4l987tpn6zG+LkoMX0S4KQQMkf7XeBSX96YMMmtOtxFP guPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AzaZ4guz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b24-20020aa79518000000b006434a04f2fcsi21738101pfp.297.2023.05.17.04.15.33; Wed, 17 May 2023 04:15:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AzaZ4guz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230440AbjEQLPE (ORCPT + 99 others); Wed, 17 May 2023 07:15:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230456AbjEQLOr (ORCPT ); Wed, 17 May 2023 07:14:47 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDA352D7F for ; Wed, 17 May 2023 04:14:43 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-510bcd2d6b8so5691168a12.0 for ; Wed, 17 May 2023 04:14:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322082; x=1686914082; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HEOOEjR671HfmOXPgQqMUHzrdAM2unOi/T1lUcVo2j0=; b=AzaZ4guzFC7mjzLyKRvNGAUkMMT+3Wa2whIOYVnJeD+QyZ8EBww+DnbNc8pW9F8KvM RoEO4BMABU8T3j9OJeY7RXkgrFJO88Qc3bpF9ewu6lRPm01+JjTV7QXpBSOJo38+G8bp apympiZR1cjbuuKJFlidTumihU9/KGAQLnnSaSrQSiGNyPYssn1XKliSaqWAnHV21pwQ atF8ps54PE8dNWH2cPVxYzif9k97D77l9URcXuo+ehsuiyRzh0F5C97ifI6JIyvQj6w5 SyOurd9nCf0A2D4c4Zw5WLOYPJ79xD5KufmjXXKv+Vzwwnbe+w/A0c4Ay9Jig7OrVISB VBTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322082; x=1686914082; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HEOOEjR671HfmOXPgQqMUHzrdAM2unOi/T1lUcVo2j0=; b=Efh7IC2ohCJtkcO1Aim1buPQGzOCCk336vQzP6xpt7bc66o/TVpbd69LF6uJVrGKGJ Sq7PAtP8ZYCQuuw/uQWJVtM55lZtn671cKXscV0tunmBfGmHWRvmrdgAUpJAAOjFo6r0 hJuoKF/e3JMxhkzwp0gylSyZwB5BlP5cuMMUozAg5vrMijWuU2C98w/phjdf2eoAkudR iB+gvQTFCmvIhO6tJhlfI1ovU+NYzvvlu/HCOUFASINNZRP216iTkuQRhxi/zR7r0O/R 4NotcpVhKIoAGRk7lJ96uGtAti5CBuK1WtGAQ3tJPKGDfU7/0dA3uMByAJnUL7B29GEf 9HSw== X-Gm-Message-State: AC+VfDwklY5aCvM2zRRvKDpx2g8rRjz69RvV/8BdP7tJmVFwLBYNWvHj yKGdRjKO7nSTNCbcXNvJRZoYcg== X-Received: by 2002:a17:907:3e21:b0:94f:2020:b5dd with SMTP id hp33-20020a1709073e2100b0094f2020b5ddmr1773127ejc.24.1684322082024; Wed, 17 May 2023 04:14:42 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:41 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 04/12] ASoC: codecs: rt5682: do not store status in state container Date: Wed, 17 May 2023 13:14:08 +0200 Message-Id: <20230517111416.424420-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> References: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766139779492314665?= X-GMAIL-MSGID: =?utf-8?q?1766139779492314665?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/rt5682-sdw.c | 5 +---- sound/soc/codecs/rt5682.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt5682-sdw.c b/sound/soc/codecs/rt5682-sdw.c index 6e3b5c5eced1..67404f45389f 100644 --- a/sound/soc/codecs/rt5682-sdw.c +++ b/sound/soc/codecs/rt5682-sdw.c @@ -500,9 +500,6 @@ static int rt5682_update_status(struct sdw_slave *slave, { struct rt5682_priv *rt5682 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt5682->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt5682->hw_init = false; @@ -510,7 +507,7 @@ static int rt5682_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt5682->hw_init || rt5682->status != SDW_SLAVE_ATTACHED) + if (rt5682->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt5682.h b/sound/soc/codecs/rt5682.h index d568c6993c33..301d1817f8f1 100644 --- a/sound/soc/codecs/rt5682.h +++ b/sound/soc/codecs/rt5682.h @@ -1440,7 +1440,6 @@ struct rt5682_priv { bool disable_irq; struct mutex calibrate_mutex; struct sdw_slave *slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Wed May 17 11:14:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95189 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1058556vqo; Wed, 17 May 2023 04:29:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6DX5ONjrYFwzU3aOLPaiYVIM57Ok4/MpYMkMdsGjHH+IajNmJ/lGgOb7N9KI2/AM+hJie/ X-Received: by 2002:a05:6a00:a29:b0:647:5409:5d08 with SMTP id p41-20020a056a000a2900b0064754095d08mr639704pfh.17.1684322985418; Wed, 17 May 2023 04:29:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684322985; cv=none; d=google.com; s=arc-20160816; b=Wsaos1ESGxhkiMzvR1m33fUPrNP4VmtNr9Tx4ecx9RkcaHkd70INdGPA5/uhaE4PUd Mvh7f50gkiIVplv/HimCF5dBv3hWTbqrkO8agfMEvm1WcsYJh1kZegjB1P6OnyBHr1fw PTVV4ZfdeLkC9dJUNgT44rRnF4761LeCJZj8MvwRwkrwLruWnBOSUFLRtBJDSDIaBS81 3/r7hYi4Oo+pchiLlZAVuCMkxgSltcjxPjtfSoAtmfQBVcJ4uTnoNZvRDd1D0c9WgmB2 xQ6sbxM4bSWKDc5yO+zJ1quxw+xvf3oS2tPiGIdpMHSmbU2PdrGnEyczdxpz90qRd8Pf nPsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Djo3KigDLCeskb1s75wtfFqne73QM8Ssl3dvuMpTj8I=; b=0agOtgxJuISqdPk/9QHXt3/kvABPIDTfzCFm9wdHSQwGP0G1nJQhdnxwaPrYqQb4y/ ZOaadOvEdISzPnypLCtpouRGTLqrX3jIwz9vyx6znWc8sIfkfCGHb230Pcv8f9DkkMST ZKvI6LlT9fOzlGDo+yYw8gcwU2TZXVseMhg5Ovo9s4gReB3tdWJxBuuyDHaYmc4h+veW yaETgJiLddd0i34AqpL8gv4qCQPA0rZ9DGPBnfNeu3r+qpoOarVeTrK7Yj29R2/IjjE+ +XBlrz7S/z8C4mCPl0jyo+WeVRugYbQde0pXn3oVGl4TMjYVqPToZR/RfpdSvMjlHnfl BUxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jbpNsTPc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z25-20020aa79f99000000b00642ea71f6d9si22708950pfr.336.2023.05.17.04.29.32; Wed, 17 May 2023 04:29:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jbpNsTPc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231208AbjEQLPH (ORCPT + 99 others); Wed, 17 May 2023 07:15:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231173AbjEQLOs (ORCPT ); Wed, 17 May 2023 07:14:48 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C52136189 for ; Wed, 17 May 2023 04:14:44 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-9661a1ff1e9so89016566b.1 for ; Wed, 17 May 2023 04:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322083; x=1686914083; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Djo3KigDLCeskb1s75wtfFqne73QM8Ssl3dvuMpTj8I=; b=jbpNsTPcndoFQHxB+zZE1pvWH6PB3oOk0GGSHncVFq60Pzl6/guO3elUgCzUb1JJ+Q PQViAH4X+DushQPeB5Y5oeEEQEDP3KD/iPA0Ba77Q1ahp2/9sa+QlD2OOprF3UBIrBJ6 34Co2bwv+wutKc8XkhQCkHobGDC9RF38e1IxFFGN4RV19S759tGHdeMOdsqFQ1G9bmcS WMgKTAtKG1OC927Cy8zgj0w2ELDbAcK4InSxId+JgPETgPIQcBnlUrIIJMJ9OC+DHO8p SsFH+tQwFz9uLp9jUA7Jb7HwfnADeDu7jdutszLl1wIveRUC8OV4jK+Iw0uwUZ86jtUx Zl3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322083; x=1686914083; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Djo3KigDLCeskb1s75wtfFqne73QM8Ssl3dvuMpTj8I=; b=XhsXXA/Yr2gcRmY0u0NbnM86Lev0Y1H983JNSyRbpkef22zL6GxYtczZGFXwGeauzp L9V0jIMrXfK70ilOtUTHRqjBghWS7FOTNsgUY1N1RRdNDkc2vhgzG0/Uww9LZf3QbIH1 VGBk061Z2eqDQMIydPjc0ozXTU6vcMUewFQspGqsJWGZdvYwMeEBRdsdVcYBdib2opVQ SG5CQf1nWANi7iAzJ9ERf9phWswPQq2LEqbLYbq/Qk1DdF2lcUToqtMmZvBHkBbenNCx p6gxdbC7YuOljN90DghjzNKs0xPnS91P8IEQD373xgTNxQ9WLUVPY1hXvAZwB0QBKxdB M6vw== X-Gm-Message-State: AC+VfDxsFfe2aXwOa3M9bqGsAdREppkHCXuoXNWqaU8GgRRpcsFOg0Ho v5SUYz4iXOUiNFaqD0vIcSSNtWcml1ZMewrqfaE= X-Received: by 2002:a17:907:940e:b0:94e:e5fe:b54f with SMTP id dk14-20020a170907940e00b0094ee5feb54fmr36761324ejc.23.1684322083094; Wed, 17 May 2023 04:14:43 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:42 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 05/12] ASoC: codecs: rt700: do not store status in state container Date: Wed, 17 May 2023 13:14:09 +0200 Message-Id: <20230517111416.424420-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> References: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766140658446912109?= X-GMAIL-MSGID: =?utf-8?q?1766140658446912109?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/rt700-sdw.c | 5 +---- sound/soc/codecs/rt700.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt700-sdw.c b/sound/soc/codecs/rt700-sdw.c index 96fc5f36d0d0..ba7767bee07c 100644 --- a/sound/soc/codecs/rt700-sdw.c +++ b/sound/soc/codecs/rt700-sdw.c @@ -315,9 +315,6 @@ static int rt700_update_status(struct sdw_slave *slave, { struct rt700_priv *rt700 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt700->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt700->hw_init = false; @@ -325,7 +322,7 @@ static int rt700_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt700->hw_init || rt700->status != SDW_SLAVE_ATTACHED) + if (rt700->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt700.h b/sound/soc/codecs/rt700.h index 93c44005d38c..491774d207de 100644 --- a/sound/soc/codecs/rt700.h +++ b/sound/soc/codecs/rt700.h @@ -15,7 +15,6 @@ struct rt700_priv { struct regmap *regmap; struct regmap *sdw_regmap; struct sdw_slave *slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Wed May 17 11:14:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95190 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1058702vqo; Wed, 17 May 2023 04:30:05 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5xIXm8gDGmzLs3KaqKaBaWb5DVagSKR7jdgF02j0RL8uhNC+CyKnL2RDQAl/Jr5P4Md8l2 X-Received: by 2002:a05:6a20:72a4:b0:100:a201:83dc with SMTP id o36-20020a056a2072a400b00100a20183dcmr42718271pzk.35.1684323005616; Wed, 17 May 2023 04:30:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684323005; cv=none; d=google.com; s=arc-20160816; b=JzCu9WQC4P8KLFrwI7J+SjEDEMMp78HPRjLMVLUOvD2W8eVh0ffwvmiug1F7X+4cNu YsekxDEWKg25nKYeGhRJ/W95QzYkUHTQOE99F1SY2orNQwMr6ENVZ6mv1hiAjaNIcCrl Ns3u5vlr/2DPRmVFcWa5jzHsYjb28wLo0Jy/O7wMhSJHOlCnlGP9Ld23caZWWyzeerI1 8BlegjFMF08DRa2I3rslUZu1SnLy22ZBGv2CPW4pSJ1FChGhwYcLh4JQ4aznsiDwCb3o KNcEjBgZuL+1MC3ch3X4izcQ6FyjQAlxPwt27bHNwriC5d52jE+1NIvuMszcOrWaA6w3 1otw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=zsBtC5TfGJN3p6qkzFAO4W1v8Rx/+dqGizHb8O0Kemg=; b=t9fVodKRs1ixz9h7eJNolM3ZaEF4iYR7UpR6MfAcPF9UAymqB0RxVkIbZwZzARdni9 j4wb7YE6c5iKqOKciLoXHCuFEY97PMRjWVGqbVSg3EqCHpDFjYd9bYa9byuhWEVxeNG+ Hg7qgp+O2Spkx+vpq8SB8LcGLxBTVWXnuqWPx7RCWisTiP7QEvVvapaTgrnEmu14qlE3 AyAOQp5PC3dkmWok3aK5svfGAnxGqb9judseF5SgZyg5k0rVL7EyUD+VgoNNMojLSRh4 pVrc3+LwRIGvSNcmFtEYBzpFQ1EuYoDZEaPgbn8zeEgyczSRcT5ya83dfE9LppxDOjQi 2MNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qT9Hm+vi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a186-20020a6390c3000000b00502f4be647fsi21170044pge.641.2023.05.17.04.29.52; Wed, 17 May 2023 04:30:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qT9Hm+vi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231253AbjEQLPK (ORCPT + 99 others); Wed, 17 May 2023 07:15:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231144AbjEQLOs (ORCPT ); Wed, 17 May 2023 07:14:48 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4DDA61A4 for ; Wed, 17 May 2023 04:14:44 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-9659e9bbff5so105181766b.1 for ; Wed, 17 May 2023 04:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322084; x=1686914084; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zsBtC5TfGJN3p6qkzFAO4W1v8Rx/+dqGizHb8O0Kemg=; b=qT9Hm+viZyjnW7qF9Tzwr3hYeysA5pkm7FIUW8J6gLL8bgZy2Q3yNgT634YhZqiWXt k2MqRXHxAe+PmDwkPQUqE8iTWCPWWgWZ7Wrp9BSGk5BYbqOcg/HArsgi2gSe+eokW/uP iQwAHoCP7iIxVJnUnRHW5XQJz542/vhvdUCwqUSrfLrEQHWEZ5BSbEvKAJPBMGE/8A6f Vc6MBE0s/VAxY6GIBGVXRP+JaPbiASGjXUx4NRGq4FVtjNwFwDg7H+eaoVlSN/ht3ZUJ qubKLdGAGqj8EOn9uTpWMtNq0g5Hruw9Bog2kjlwZ3GWxs/IvHpul99eqw1y/f+zgmr8 Dqbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322084; x=1686914084; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zsBtC5TfGJN3p6qkzFAO4W1v8Rx/+dqGizHb8O0Kemg=; b=GzOR8qelPNWGEPSoSUHqkrUcHO4TxTFBXZTHPnPxqVQGSk5GC2MLBEHX2SIlMnPTpk 2WdjiEhF8HWSQ81ik+9ayC7nUDIy+Fybz5dprCxOYQuapwpp53bb0xDqbrYyuvy04J+s OxqK/ZNKxH4YxSwaehqbJt3WYxVMzxOu0PyATLn8rC5KYkg72QwTdDxJXocVUINRuYQM D8ozC69WH4p5iItLiXOUIfQDWe3l5/egqWjfCvJ5tub3RxTdaCMd0bpkSCm/LzlT2p+w hbr4TDr3VH8gi1mOIN9VG/L1HItaaEv5cdRzrdTWADHdDxF43cZyBD1G7K65/9Bd3i0O W5GA== X-Gm-Message-State: AC+VfDxFxhc/wFV/+kSmFT2UlkLRXM7W5fKwrafDNmNo9oMAEvB80LKn T+LkT5bLscaqT1IJW4F4zyulnw== X-Received: by 2002:a17:907:5c7:b0:961:be96:b0e6 with SMTP id wg7-20020a17090705c700b00961be96b0e6mr34403065ejb.68.1684322084257; Wed, 17 May 2023 04:14:44 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:43 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 06/12] ASoC: codecs: rt711-sdca: do not store status in state container Date: Wed, 17 May 2023 13:14:10 +0200 Message-Id: <20230517111416.424420-6-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> References: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766140679812119879?= X-GMAIL-MSGID: =?utf-8?q?1766140679812119879?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/rt711-sdca-sdw.c | 5 +---- sound/soc/codecs/rt711-sdca.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt711-sdca-sdw.c b/sound/soc/codecs/rt711-sdca-sdw.c index 51f3335343e0..2c5eb28259dc 100644 --- a/sound/soc/codecs/rt711-sdca-sdw.c +++ b/sound/soc/codecs/rt711-sdca-sdw.c @@ -143,9 +143,6 @@ static int rt711_sdca_update_status(struct sdw_slave *slave, { struct rt711_sdca_priv *rt711 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt711->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt711->hw_init = false; @@ -168,7 +165,7 @@ static int rt711_sdca_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt711->hw_init || rt711->status != SDW_SLAVE_ATTACHED) + if (rt711->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt711-sdca.h b/sound/soc/codecs/rt711-sdca.h index 22076f268577..11d421e8ab2b 100644 --- a/sound/soc/codecs/rt711-sdca.h +++ b/sound/soc/codecs/rt711-sdca.h @@ -19,7 +19,6 @@ struct rt711_sdca_priv { struct regmap *regmap, *mbq_regmap; struct snd_soc_component *component; struct sdw_slave *slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Wed May 17 11:14:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95194 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1061474vqo; Wed, 17 May 2023 04:34:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ57u4c+TcHq/mIH+8CsZ7hRVVJK3j+kYTO8SkJwR9uitfHol1qEPLXRvDUWkYGUw0NHBeVu X-Received: by 2002:a05:6a20:d2cb:b0:106:774c:8bc1 with SMTP id ir11-20020a056a20d2cb00b00106774c8bc1mr9741065pzb.48.1684323261456; Wed, 17 May 2023 04:34:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684323261; cv=none; d=google.com; s=arc-20160816; b=GZm+9VoNJOrOAMo78sKg1LHu2/N4Nb1MQwVGEDP70ONHVCnJWhTiNKp85A9nDygSzZ mtruH7DVX0hllHxo0/NdCabRU4gBP3omnK5z1gPz2Y6vUvXtspiyFstTswHJbRch0tyG EnikRiQZA47tWD8T5/eYO0JtQh4N53GvtG650LivhqsU4DQHCp4ztqoTCjS20EXY+MkU BrbkWcdkdz1uh4ro/PLfZCLJ3P++81ynmpBEgfolju8feE/vTHJ8uV6L+xjhvZraS33I NLyEYUxHkEzpTqhy0kGv2NNffeHPpU6ZMEfDwDqpBDgeYcwF+5Ec2Ju0LqPYZs0Ytpaf edGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=orOtZCSMdy0LOUQiF3GDNtFNR/PCT+bEnkKVYg6k6GY=; b=YO7GOLbdWSb9iiaWRI04JQC/v0g3Gv2knrtjVnx3U6Y6ZA/0Pwu6OiSkQBLe+33X4v OBmrnRlqZY7pOATUNPGEg3le+BcoJqMEO0Nw3D45APR3/aV9VXiw528CoITfXJBDBHQF fOS3o2Wsuyy3MLq5VD+PuKk5XLVfDtwsqy3/Z/MufMNBAHIHAD8UEMFyMGGz7tFDNLU0 gxG7OKaqt7VrmImSXX0FQ98dW/kWl/o9YMjzO7IWDQFsGcMv1LwaF/kCWU0IsZUbC/Oo z5SxohEipyNyAvdeHFSpky9xu192lFYXJbenjkQ5CSKYKN8uJPQuKsC/r844INJJn5Ez MlAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hIdANJjD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k74-20020a633d4d000000b005143d5f9ff0si19710852pga.357.2023.05.17.04.34.09; Wed, 17 May 2023 04:34:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hIdANJjD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231236AbjEQLPN (ORCPT + 99 others); Wed, 17 May 2023 07:15:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231218AbjEQLOt (ORCPT ); Wed, 17 May 2023 07:14:49 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9785940C1 for ; Wed, 17 May 2023 04:14:46 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-96b4ed40d97so96283066b.0 for ; Wed, 17 May 2023 04:14:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322085; x=1686914085; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=orOtZCSMdy0LOUQiF3GDNtFNR/PCT+bEnkKVYg6k6GY=; b=hIdANJjDwebuLejzh1gdqt+267DcEVSuEXFFfZttIJwmQVKZZhGt5sC81zWStiXcRj VkXD93TUaA6p5/xnMn+t1KsA2k9XWbfzDLmphIbNyQCMePhqmJwZ0QIctyh5cwm8q4wy jpGo6s5Hd6p6eKRAO0ltyCLM8otD/mS7+HaUb4FFNTthYyMbM30oBOfYkgfq+MXolgz5 OrfMgBCLybw5ytMdkTg+It68qT+icGoIHEi0KynM6uNo5zrHoHcKNS540jcbGu4+XgBj KS6QniH0sv0gGfn4aAtNBHezfiPEI5b6LpAL/hI7ksQoRcMW9Z2nBnGJkQPfI8i5ovSr ydYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322085; x=1686914085; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=orOtZCSMdy0LOUQiF3GDNtFNR/PCT+bEnkKVYg6k6GY=; b=WqHVI0RueI8VsOcDwxKZEypvmCCchHmrO8QfRjZuTROx4XniXtWcizrFf6u0yd+oKI xvoS8wmvGCLVdBJuQl/px2QeSsRbXiEXOKaF8Et0Rf8ni2qASrlgjMwVz6txM9yC2x96 /oZTmWKYEFSATctQTk+oc6cWy5KKipy5yRoYC7ZRg4WsjS3eFav4qkiEFef/F/V/emwS z5cdjDP56Q6Uj3lCPnR/Bs75rcPzkkGZ4FK1T09bF+818i3YP8nDOrqKMNih4KO0M3+1 mD0td0wlV4yFKTwzIEQcQX6h/gcuuk4ko0FdVTGin0Bq6GSAQvv2kw97fvdEW3f72bEN Rr2Q== X-Gm-Message-State: AC+VfDzVxvU2N4Ko6vf/ZnNYNWg72a6273h2etpwZ8zoIEXiLIHMzLWy AIPviKAM9GJ+YT7+s7ZSpXv8Ag== X-Received: by 2002:a17:907:7e86:b0:969:b2e2:4f3b with SMTP id qb6-20020a1709077e8600b00969b2e24f3bmr31186355ejc.51.1684322085181; Wed, 17 May 2023 04:14:45 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:44 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 07/12] ASoC: codecs: rt711: do not store status in state container Date: Wed, 17 May 2023 13:14:11 +0200 Message-Id: <20230517111416.424420-7-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> References: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766140947768720249?= X-GMAIL-MSGID: =?utf-8?q?1766140947768720249?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/rt711-sdw.c | 5 +---- sound/soc/codecs/rt711.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt711-sdw.c b/sound/soc/codecs/rt711-sdw.c index 4fe68bcf2a7c..b8ed3c6236d8 100644 --- a/sound/soc/codecs/rt711-sdw.c +++ b/sound/soc/codecs/rt711-sdw.c @@ -319,9 +319,6 @@ static int rt711_update_status(struct sdw_slave *slave, { struct rt711_priv *rt711 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt711->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt711->hw_init = false; @@ -329,7 +326,7 @@ static int rt711_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt711->hw_init || rt711->status != SDW_SLAVE_ATTACHED) + if (rt711->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt711.h b/sound/soc/codecs/rt711.h index b31351f11df9..491e357191f9 100644 --- a/sound/soc/codecs/rt711.h +++ b/sound/soc/codecs/rt711.h @@ -15,7 +15,6 @@ struct rt711_priv { struct regmap *sdw_regmap; struct snd_soc_component *component; struct sdw_slave *slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Wed May 17 11:14:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95191 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1059702vqo; Wed, 17 May 2023 04:31:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5r47X1Uu8EWYcieX1metcdfeKj2PYv52FHQzrJL5a8qWlulZjUv7tcGvi8pSB1pE/Bvzxd X-Received: by 2002:a05:6a21:3386:b0:101:241d:55fe with SMTP id yy6-20020a056a21338600b00101241d55femr42476172pzb.45.1684323088956; Wed, 17 May 2023 04:31:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684323088; cv=none; d=google.com; s=arc-20160816; b=g//j4WD6/Fn9CHiohSfe9wuB7/C1TxqDF9LTo3mnQKqrelvHcxSZ/ZdicYHcTjogNw PqYzKxVLsAp3QxkRyTlyBE5njaxdYNn5jnJ1efJVYarejO34s/ymVYCGVtYoYfPgodgt WwjrUGYmru/C5Xs/CZOH0p3EK1ATqJ1qBO0R5bZ5uqUI4dhM/AetVFzl2jFjci9DgoC/ W0Ba7rbcT47gb3O/hJTntU1/yvbqX88s2GwVJhQFO3+oO1qw0oTi5j0ZvM5r77ziosKC T9v8mJY4H/HYuFVerwnzLJvulCqlwaIpbkZ49jhAJllUXSiSpJaimbT7NvvEswag3uVk CWXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=QAU6nE7Iv32gPNvrQJaHKSe4IIom2DPSRL0YbepC1JY=; b=jHXEy3T9xHJFQDRRw+9XwDnQLy31jHWo+7+Wu0Fr8mTat1aP0qgq4nb8vkuNvi5OAP tH1FU1/tjA6StQp2fUqU3HgH4EDCn7zZcmZOPSSRxKBR3HzbQykN+tHdqj2FwHgF+v2j 2hLHwcvsl6XjMQKWxbeTxSL1Qn27wvKeYPTzABqc5xauog6nI1FAa+zV4460oteRi78R dF63haWMRBDCMoLs5Evvs6AtjxTCYPM/e1WGzP4c5rA3P1hVEsgyoZWCFsSwlP439dAs 3E+/UnbHyq2iKJnxQo6wdskAxHXMekoHhTlXVKj5AXy04835o9JmjZ2o0bHCR6t/InPc +dQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="dJ/Pmlpb"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 185-20020a6301c2000000b0053048bd0669si18933674pgb.445.2023.05.17.04.31.15; Wed, 17 May 2023 04:31:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="dJ/Pmlpb"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231270AbjEQLPR (ORCPT + 99 others); Wed, 17 May 2023 07:15:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231220AbjEQLOt (ORCPT ); Wed, 17 May 2023 07:14:49 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D683355A6 for ; Wed, 17 May 2023 04:14:46 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-510bcd2d6b8so5691597a12.0 for ; Wed, 17 May 2023 04:14:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322086; x=1686914086; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QAU6nE7Iv32gPNvrQJaHKSe4IIom2DPSRL0YbepC1JY=; b=dJ/PmlpbNmfHmuYdjH3uO1ElApNK26oJ6na+aMD1yfJb05UDsLjz0xzUQTE/abm0yF zbx6naNOO2gKrAAsT5hyVVuz+j8ikJ/doxEQfVfSDF/ljofMQWyaBDeE9u14oK62/Wg/ xSIAetdKH2r59SbWqeWex5CKGvgTBS+G52EYglrZnOGuq2IENBj4Zwqrl/aLWic6zaTR 0NIY3KBh7oR+Z1I6Gxv/gf2kMRHJkoQGBahe4Y8/aVsAb7rBDD9/A+yas/Ild289fXk8 EfK+Znx5j8oBJa9m6rR/Oo4lqtGuzB5qoV2RwqJcdqyxLiOMlxeuo0sWGQY4pjqC/RCT Ro5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322086; x=1686914086; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QAU6nE7Iv32gPNvrQJaHKSe4IIom2DPSRL0YbepC1JY=; b=DKCmTzZvwgJLOamQRHx5dSibh8YXLhs0fbF192+CgLSpujqscSZmMqy3LKeSRmvMf4 5a7Bk+8jgJul3CIdlGTpMFN45QuUQOdemTJApNOvWzU2DCPQghTkyDuWootVCqCTbIC1 iglkpeU0/GaupltGNeLA4ApBDKMf6L5dQx3QLbN5rbzamKPXmG8Na6Gu/+mu7nYLcDG9 BXjYRvURp8HqALnPtdQfKS3VYA09rkikNjfa5vwiv3UpnWaXBW8SFwjlh8q8vNFLk1wa KB036P/1+8nyBXD+jcgBVKdQWsxm6sIIwsL7Qs3KMTSp8zYxsqndQUGo7B5kFEO4zY4D hDwg== X-Gm-Message-State: AC+VfDzcz6P01J4AVqdSNYCDXG7UekOe+2bBH3/8yY6cyrd7BMsh+tAs FBxVg09s9VbG+j3PJ6j0pGe08w== X-Received: by 2002:a17:907:6da0:b0:959:b757:e49 with SMTP id sb32-20020a1709076da000b00959b7570e49mr1997236ejc.1.1684322086159; Wed, 17 May 2023 04:14:46 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:45 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 08/12] ASoC: codecs: rt712-sdca-dmic: do not store status in state container Date: Wed, 17 May 2023 13:14:12 +0200 Message-Id: <20230517111416.424420-8-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> References: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766140767327043082?= X-GMAIL-MSGID: =?utf-8?q?1766140767327043082?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/rt712-sdca-dmic.c | 5 +---- sound/soc/codecs/rt712-sdca-dmic.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt712-sdca-dmic.c b/sound/soc/codecs/rt712-sdca-dmic.c index 09807b6d6353..847198e6c07e 100644 --- a/sound/soc/codecs/rt712-sdca-dmic.c +++ b/sound/soc/codecs/rt712-sdca-dmic.c @@ -803,9 +803,6 @@ static int rt712_sdca_dmic_update_status(struct sdw_slave *slave, { struct rt712_sdca_dmic_priv *rt712 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt712->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt712->hw_init = false; @@ -813,7 +810,7 @@ static int rt712_sdca_dmic_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt712->hw_init || rt712->status != SDW_SLAVE_ATTACHED) + if (rt712->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt712-sdca-dmic.h b/sound/soc/codecs/rt712-sdca-dmic.h index 74c29677c251..110154e74efe 100644 --- a/sound/soc/codecs/rt712-sdca-dmic.h +++ b/sound/soc/codecs/rt712-sdca-dmic.h @@ -16,7 +16,6 @@ struct rt712_sdca_dmic_priv { struct regmap *mbq_regmap; struct snd_soc_component *component; struct sdw_slave *slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Wed May 17 11:14:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95188 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1056302vqo; Wed, 17 May 2023 04:25:44 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6qibpMQpEJ7vnU1tZ4ndJ694LkMshNIE7EzuJvLRBhN9CQdOrPc206eSF0nfOjTVbMNSo3 X-Received: by 2002:a17:902:d505:b0:1ab:1351:979e with SMTP id b5-20020a170902d50500b001ab1351979emr51218735plg.10.1684322743735; Wed, 17 May 2023 04:25:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684322743; cv=none; d=google.com; s=arc-20160816; b=EeSoGUU8ZnNVPrMRLcElujtUxDJKtFXsSgPQKw0bvJEs2TTdw0O7kCM2WvQ7imrCdn Za1jMyvDdVrpekZmrQPsPQvbFqxkatfCW4/2VPx0m9lpWLg2C4G/PtQoCE4JAsctHvUo HuXMhmV7SFf4Y4CZz9pvhcMPTU05f0UPQldnkaIbMdVAxT/aPnw9Q8n61tTGEZgKJPxw /etj7goRyQmEsQ3r27TS6PATYNJGKWZrcaAF/XHJX+IUmRYmjFqAB/puQV2FlJOWKDlR XVVJomXVpwVng5gxBsHlaZLFw4WlxYDNOtglJgi7Ad6zEgZDHBciwW2mtpnyGUVE3mEh 0ZWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7XA3XbezCgMB9jc3ic4kluul6uNj+0DU/xxzeFgKHBE=; b=zsVWug4WQ0//ZxC6DIxm7NxbRt3OmpMTmshNzVWs6zTBhcFmKYcQrBAPHKSPgVao6k JTjtSKxOXTUvI/Hpp/UwX4PoLAt0WZ5mSSID8XpWoBk4fy7GbfB+BvpdfSbeU164ii4n aPDWU0+GIkAfgE+mlsjV7RKxn5IDcknSt9dqTYoq3rXgqWvOViU1XyAoFBQeUC2VjyG3 2GMaho39twuxbdZP2j5QWhsVWbSq60al+g+u7Etjvua6mL4729WZq2DZ3IrMlAYx0OWr dq0dX9Jr5UJe6miyFzskcjzYnmcvEFi8F8kDPE4uxeO0RcmjN7L1CdsIK/39S4UoSUuk IjBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Q18UZ1h8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a13-20020a170902eccd00b001ac5896c746si22350203plh.329.2023.05.17.04.25.30; Wed, 17 May 2023 04:25:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Q18UZ1h8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231337AbjEQLPZ (ORCPT + 99 others); Wed, 17 May 2023 07:15:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231299AbjEQLOw (ORCPT ); Wed, 17 May 2023 07:14:52 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5D102D4E for ; Wed, 17 May 2023 04:14:48 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-965a68abfd4so105666466b.2 for ; Wed, 17 May 2023 04:14:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322087; x=1686914087; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7XA3XbezCgMB9jc3ic4kluul6uNj+0DU/xxzeFgKHBE=; b=Q18UZ1h8k0fFvwih1EOsNVJXAjQsdHXNFlqphn0hwbg48vgVEor0zN78LCEayppAZf ODLE6k/+kOXM86OJ7nPnn6kgKgT3iAVFA/CrP4Ss+joOCpD2pmqp78mGWJ/8Xf8pSCa+ uGZKeHASaKnoKcS+giX3EI1tr2Uj6i15udXE9GApmffv9qgpfeoBg4AZKgU0xbwdRFq0 Cw9uMa+TyjssV2P1Ua1UuJps5Uelyr8p5kM1kTaB8KjBkwyvUlQ7XG0yQUTXHCTLIU3h QxQB0lrj058pFXy6HUFeEHjxwqJE5T6EonVtsO7nM/I1lSYV8orCpoVgQtVisN5rQnI8 JopA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322087; x=1686914087; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7XA3XbezCgMB9jc3ic4kluul6uNj+0DU/xxzeFgKHBE=; b=H3m/SMecfrRRlDg+/DoKSK4/FEaoBfeKW2q1K9ysdYg2XOhg+gQK0cajqSU4A0+t7P EwpYIPeML2TqM4vWvAOkxKo37FfS0zfJClDt9Uq5RQKuDHnoD8zA1X01wS44TNd++utn D9CPpmTh/CW0itIujJdt+rt0bug5fVSsbdjRQcSy/x2NDVnypsxXArD8VizMmvRUEk3Z XgZ+g84tE+PkyFu9/ylquXL+GN26ti6AmxTpQ5xbw9VtaAibCv0U6Qqg7qPKGGyjSeKP P0+3maOyvzDXGx4k+hFMT4+PUso4nbRk50UA86uHfio+nA48rj503Faxjc4Eo/7dPleK 53xQ== X-Gm-Message-State: AC+VfDy6xOaaN8FIXbCXKHnQdMn82UHsc7OeLg6kuI2hsdUK6nJfS0ZK QgGpHWAyxkV2RKqw8AKAircGNw== X-Received: by 2002:a17:907:72c7:b0:969:f677:11c8 with SMTP id du7-20020a17090772c700b00969f67711c8mr25495472ejc.45.1684322087476; Wed, 17 May 2023 04:14:47 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:46 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 09/12] ASoC: codecs: rt712-sdca: do not store status in state container Date: Wed, 17 May 2023 13:14:13 +0200 Message-Id: <20230517111416.424420-9-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> References: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766140404906233892?= X-GMAIL-MSGID: =?utf-8?q?1766140404906233892?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/rt712-sdca-sdw.c | 5 +---- sound/soc/codecs/rt712-sdca.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt712-sdca-sdw.c b/sound/soc/codecs/rt712-sdca-sdw.c index 3f319459dfec..8f65516e7562 100644 --- a/sound/soc/codecs/rt712-sdca-sdw.c +++ b/sound/soc/codecs/rt712-sdca-sdw.c @@ -140,9 +140,6 @@ static int rt712_sdca_update_status(struct sdw_slave *slave, { struct rt712_sdca_priv *rt712 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt712->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt712->hw_init = false; @@ -165,7 +162,7 @@ static int rt712_sdca_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt712->hw_init || rt712->status != SDW_SLAVE_ATTACHED) + if (rt712->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt712-sdca.h b/sound/soc/codecs/rt712-sdca.h index c6a94a23f46e..ff79e03118ce 100644 --- a/sound/soc/codecs/rt712-sdca.h +++ b/sound/soc/codecs/rt712-sdca.h @@ -20,7 +20,6 @@ struct rt712_sdca_priv { struct regmap *mbq_regmap; struct snd_soc_component *component; struct sdw_slave *slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Wed May 17 11:14:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95185 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1052248vqo; Wed, 17 May 2023 04:18:36 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4tZFvZwa3WxdJpfi0mD/Bu4fm3E3qgHm64W0w6TxUSF50GFGiCWABKmln+WkjAgxugDiUM X-Received: by 2002:a05:6a00:1150:b0:647:b071:20c4 with SMTP id b16-20020a056a00115000b00647b07120c4mr553580pfm.1.1684322315968; Wed, 17 May 2023 04:18:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684322315; cv=none; d=google.com; s=arc-20160816; b=CHJMBkRFAijw34SIFVQsk3pbZHEmGvf6Tk0/QXgqM7GwbbN2WULexAcrslncShcKjB SBaN8BYB+K3L1jMy/QQ13+VXh9yBB+sH60JpVt2T1uRnnqvV1Fr3gW7ICMxOF+aRn49z pZtWzmYmklBUMX9kIb0W44JrsaMY2qme88dwbnNzDcQHIHeEwdFGq/K9QkemAoOBAl2G 9Fucvi1n4yAfKA6MOhak2LmkHXaAkJcUA54z/rrEt5s24N3bLqU2ewOo0xSYNrnKmtei KbvUEwbG75w4EU1EGW9cmuMa9ePs1yqxdkukrZTe/Joy0CNUiPHv7rngu+S4rp0jYT8R vlaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Hg++FY7yhGIzwZILizitxUpO+7bfMUehzjto7GaiR9Q=; b=CfJ3gndAhte1pD5RrmoYt1BZPIr8XbgGI/xHE/xu6+8AwyMBEdBtx9DKLw7gdv4tY4 yrnvCBynlFcxsTkuy9sNjpEtdkSM/rEKkeqmC8q0rlyFuWwNBlKnECE2+BPtoWYfgW5D qzbSHJFIjXlNxlUKx7FaUZ5V1Rj0j4zEruFRd8ysIaQ62o214dxtWfzw4RNMgDs5F0c1 Ye9j3UTGcojEElR2mFy7oexj1LLY00alKBVe+UkhKjsLlh9stfOfWq99yzv6bLgTrblm 1E1nqTDP+JOAdJzcqSIUs/CjOgyDKJoz9EAvh59wEik/NTkFRelG7TGT+o/qmDnCvzpm sYAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QqGyQVcP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z2-20020a63ac42000000b00534293eee51si5899981pgn.775.2023.05.17.04.18.21; Wed, 17 May 2023 04:18:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QqGyQVcP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231314AbjEQLPV (ORCPT + 99 others); Wed, 17 May 2023 07:15:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231301AbjEQLOx (ORCPT ); Wed, 17 May 2023 07:14:53 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D5CA420E for ; Wed, 17 May 2023 04:14:49 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-965f7bdab6bso111919766b.3 for ; Wed, 17 May 2023 04:14:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322088; x=1686914088; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Hg++FY7yhGIzwZILizitxUpO+7bfMUehzjto7GaiR9Q=; b=QqGyQVcP+weCBDwAlfPGPZeH7eur+A3XKLVELVFzsWtZeDa7EsfvnyemqYCx8tfCso zOrofL/zOLGID7x8MwR30/XR59YqTg6r/In4AqWvuGtx74kLRZUPGQmL5hE7w4SPgqYJ 0GUTOUkDk82Bb29FXqsk8pfyiH19q8+t5AhX17sBgZe1yZrr4CIrdBj1eN+XHUyYRDBE d4Xh9182yu35iRsGleQ97I/W2rPAftQCyoUARli+pbGhkOf1Ur3sk44FNy+kTqB4tEDj SpE+jAq8Y9nUdeVZqMOafAEPfIociyC8A8fp9Ms6a6Zb47kbcL+bF0yJw9fpE4q+6mD/ nWog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322088; x=1686914088; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hg++FY7yhGIzwZILizitxUpO+7bfMUehzjto7GaiR9Q=; b=fP0IAa4keAbfDgIOd00BjRlkYwPi0GvWCi58V41T48uyLwL4w2wTQsdsE/RZRuBFNK g+5wwswQkUmOY73rGhTA3SIfh/0wrPWwDO3qpJzI9PtyWZUKX4CpbF9vNpn/xLV7DeV5 UUA0Lont8OFlGVifhZcfRO5Ink9X6Xlm0ZBwIsR/CsVe0Cc8h8t30MsHbs/VeycwscJR N2mqTARXnZyiA1BAC0IWxCfJT224NEvdUKBLghv5Ayts5IeJFg4UHKAJeOVmB6927ZiE BzwbD3Wh6mBkmIZRvj5Hc4gil7K+rYtLqnY8DaiLSF0ji+xZigngY+e9HcyXYznpZTnL rXYA== X-Gm-Message-State: AC+VfDxnvvKdS4AlaznNzP0dri4NgZqD8FnxMKMVli3LE2XHk57gCoyL 5rAhpq7G1f4NGdmRfYS8dGlHzA== X-Received: by 2002:a17:907:9496:b0:96a:ff7f:692 with SMTP id dm22-20020a170907949600b0096aff7f0692mr10101998ejc.68.1684322088601; Wed, 17 May 2023 04:14:48 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:48 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 10/12] ASoC: codecs: rt715-sdca: do not store status in state container Date: Wed, 17 May 2023 13:14:14 +0200 Message-Id: <20230517111416.424420-10-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> References: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766139956591448660?= X-GMAIL-MSGID: =?utf-8?q?1766139956591448660?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/rt715-sdca-sdw.c | 5 +---- sound/soc/codecs/rt715-sdca.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt715-sdca-sdw.c b/sound/soc/codecs/rt715-sdca-sdw.c index 38a82e4e2f95..7e5ddce8097d 100644 --- a/sound/soc/codecs/rt715-sdca-sdw.c +++ b/sound/soc/codecs/rt715-sdca-sdw.c @@ -121,14 +121,11 @@ static int rt715_sdca_update_status(struct sdw_slave *slave, { struct rt715_sdca_priv *rt715 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt715->status = status; - /* * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt715->hw_init || rt715->status != SDW_SLAVE_ATTACHED) + if (rt715->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt715-sdca.h b/sound/soc/codecs/rt715-sdca.h index 7577f3151934..e5d6928ecaba 100644 --- a/sound/soc/codecs/rt715-sdca.h +++ b/sound/soc/codecs/rt715-sdca.h @@ -24,7 +24,6 @@ struct rt715_sdca_priv { int dbg_nid; int dbg_vid; int dbg_payload; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Wed May 17 11:14:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95199 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1069420vqo; Wed, 17 May 2023 04:48:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5sAoiZhDYJmyVVWBmKa8IfREWIMBzWVwaYnqjzVsNZnyI50oq+ggA8E1Ddpx00fjsy6n1k X-Received: by 2002:a17:902:c40a:b0:1a5:f9b:27bd with SMTP id k10-20020a170902c40a00b001a50f9b27bdmr56408234plk.34.1684324100360; Wed, 17 May 2023 04:48:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684324100; cv=none; d=google.com; s=arc-20160816; b=flQpZ4UoUzWJHIcGzA+OLYIXKEtorrnthzVu/A1+RqaseHhOnJ6bKxjRAltStXvYtP FeVdFx6O+mnV5Qc0C1QbIvoKdoAzJ6RH0TXiaiMGmWBFEzSg1keaEwQVbk/PD6ECmGYa O1O6RxP+B2edz9BISMqwZIGuEgN0sRZMSpI+xv0GxHAHYg9QTLM0TFTelZEDUCoeIhJo udT+TfUHY+8kXvAoWq5TuEUe2lNFEtX28iihLINdoLu0sStvSOzd0Fn+00wgEFmv4o61 RsvjYnWBY9L1MqLLzz6XjC6hIdFnoelGy5gaLuvETicYjt6VfBjheH/xDxMDNAeO7QTd H/dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ikB2y5rvufm/ROET3UaPHVQf0uJXk4esoL2mDQIzzPA=; b=cwtDnyLQL2p8Uifc9IrpWQEcWELCZ93j1HN7IPP0+MdJ+GAt3SO3zSpZ5eNib1bpTn U1lc2OkHTEDxAso7S8P01sYuNBSX9JzwLm+Ih0f+jXv9E+MaOcL0c0loi3mnYkRjlElg e2RehkVYe3BdykT4W64r5KodD3h+L+cZIaVgY8Ml68RDy34yrmIYJoRttunfZwpElTYJ rH5SxN4w8o4gkb38xsUNQ/wpjKeQUT8ZqeEdOdHSMzFEGwtATzm09XoYucHYq9/BkBMp SwXY5GdPc+jWik0dNj2nuBUfRBsYc83PG0drBP8gPYxFnUmfHgAYoBBl40RL8Dmi1P9x EqBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Mqrza8r6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f18-20020a170902ce9200b001ab0e3e0c1asi22100630plg.553.2023.05.17.04.48.04; Wed, 17 May 2023 04:48:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Mqrza8r6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231245AbjEQLP3 (ORCPT + 99 others); Wed, 17 May 2023 07:15:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230444AbjEQLO7 (ORCPT ); Wed, 17 May 2023 07:14:59 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F7045FE6 for ; Wed, 17 May 2023 04:14:52 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-96aa0cab88dso92614366b.1 for ; Wed, 17 May 2023 04:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322090; x=1686914090; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ikB2y5rvufm/ROET3UaPHVQf0uJXk4esoL2mDQIzzPA=; b=Mqrza8r6L1qVxSOY8tPU3HdOmEKLv1L4y3PLSmB1w5nETDTDauRdLQWLKSc70HZ800 pi7A8pKDIp3UiLkPHkSm2Z9WKbHpPVQqowRRvDdLX9xaXmcZFAqbO+2DgbzQZo92DKPc mfGsvAWTr5zLhsgTVpPH5G7b95kh5eRGV/HhBRsi3O+NGuXyaGLl9tEVU7dTaQROQ9Un HBexjtOtDlBB+58I33xjm/oeXxfhsOTQgIc2wwvKbCqosGiLVZQQHsaMol4RliIown2f KuLWdNzxde/Dr78sqoTvF8zkY//R7v9P+iWX0ABe7GdxGBXLkAz92qty0kQ5+iiERX0c vNtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322090; x=1686914090; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ikB2y5rvufm/ROET3UaPHVQf0uJXk4esoL2mDQIzzPA=; b=aDkhlqqSTJODtdCaQz8iFVutTCuVVg1aaA8+SXTCf4+opU0uu9DJ0Xh13e0+sFAH39 8geLR8WYG81GftZX6heAEYIMFg+G1NxZ3Ffk2Aq9X3dD+SMS/hMoyuAAkM4XdNDRvsdF J4XcwrBtocSbcWS4RczYvejfxZNI8t4ci6eoJ+87YuCfOI5AGaYym6iSXF1WIIwBUydo 91J92jf8bBTIJGVEH86LrrP/+nt7qmIQUU9DDrBlgTds5fc0XhEQWdDQZXDMtjhYefnx 6+Dlaf8I3JyG00yB9BsijBtLiCGA5PLBPLx/RykgoNGuN8R7zNQzkTzh2cyzRYXxxq6y DJqA== X-Gm-Message-State: AC+VfDzN0Gu1uKvm0UuQrVCmGnG0fvULHlILr4jgQmcIOGncz9PFkSOk jI5OaHtZJ87KkZCNQYeLXMA6ow== X-Received: by 2002:a17:907:7fa8:b0:969:8d19:74 with SMTP id qk40-20020a1709077fa800b009698d190074mr35584944ejc.57.1684322090644; Wed, 17 May 2023 04:14:50 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:49 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 11/12] ASoC: codecs: rt715: do not store status in state container Date: Wed, 17 May 2023 13:14:15 +0200 Message-Id: <20230517111416.424420-11-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> References: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766141827801384446?= X-GMAIL-MSGID: =?utf-8?q?1766141827801384446?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/rt715-sdw.c | 4 +--- sound/soc/codecs/rt715.h | 1 - 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/sound/soc/codecs/rt715-sdw.c b/sound/soc/codecs/rt715-sdw.c index 5ffe9a00dfd8..6db87442b783 100644 --- a/sound/soc/codecs/rt715-sdw.c +++ b/sound/soc/codecs/rt715-sdw.c @@ -417,13 +417,11 @@ static int rt715_update_status(struct sdw_slave *slave, { struct rt715_priv *rt715 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt715->status = status; /* * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt715->hw_init || rt715->status != SDW_SLAVE_ATTACHED) + if (rt715->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt715.h b/sound/soc/codecs/rt715.h index 17a8d041c1c3..12a0ae656d09 100644 --- a/sound/soc/codecs/rt715.h +++ b/sound/soc/codecs/rt715.h @@ -18,7 +18,6 @@ struct rt715_priv { int dbg_nid; int dbg_vid; int dbg_payload; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; From patchwork Wed May 17 11:14:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95193 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1060382vqo; Wed, 17 May 2023 04:32:27 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7qmDJLTFKqu+jmvJVLVZJatQKIgiD1WbDmm6N3JNHGLXvn+hTkrmBuNTSD3BRxI735Zhlw X-Received: by 2002:a05:6a00:1a16:b0:64c:ac61:ffdf with SMTP id g22-20020a056a001a1600b0064cac61ffdfmr750100pfv.0.1684323147251; Wed, 17 May 2023 04:32:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684323147; cv=none; d=google.com; s=arc-20160816; b=WwiYm/l3yJCWscd8ReaeEOczcmeY9NgmLmvGCD+cq4T11TaxR8RASXrjTSeM8sRhF1 x7aVRFIeHoRwC0bwVtlPwpPnNsiTfKMgYukG4pS4vg+FH3IIWKVvwMY6bF7T6+vFNVev TCFlsIJFGMK2kNPYo1hYZ1NbaJqsLK9xCAxi9bw9xQ2CU1DibdBnvrRQb3f5v3q6czpy ZgPh0hcKDzdI3T+6sUg62+LpGpY0Br8V8cb+UBLrG8n284mJPLBgSOJc1iht3bjaDuLS wnwWTy3+b57WODCb7LaIlDM7Hg7SWACzn+wRKo8Mq1VldRP18VKIAca+oxaDnyT74lmc 0S8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VnIEpqHICz7MCR44hDCQrdJI2TjC+iEi+weDD/DiHgQ=; b=VwsRFpAWZu61Dv4b6jGZLVvSh9aZ2sNv5RUXxzJtstmVa2v97umrQaC3Eg5GTcsbHo Dmrpe3jvugPWJv5oF4QZO71/dNF2QfvkY+olrI6InGIOp8q2DI45lkLMUJ7R1b5w4Aks Rq/bBjjqD6h91QWqZa0VjdMWqFQM/Y5TRBtQndIEhMOAH4009lkG5VYKQ5BsEkSk9wtF GUnd1pvOhouxJxB3UF9aaorF+2StpPzmqzxCBny3rXYwJC46beK3qrDKxEb8UcAVxx4B /bI35011BLlnfq5QfCCyT4xz3T0My+MsMWKbW7m8UnXBSrn/xIE2z1eSGZV7alCPFfNl kedw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uMpMaqG1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e18-20020a056a0000d200b0064729e5a04dsi21248713pfj.388.2023.05.17.04.32.15; Wed, 17 May 2023 04:32:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uMpMaqG1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231358AbjEQLPc (ORCPT + 99 others); Wed, 17 May 2023 07:15:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231140AbjEQLPA (ORCPT ); Wed, 17 May 2023 07:15:00 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 929EF2D66 for ; Wed, 17 May 2023 04:14:52 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-510bcd2d6b8so5692290a12.0 for ; Wed, 17 May 2023 04:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684322092; x=1686914092; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VnIEpqHICz7MCR44hDCQrdJI2TjC+iEi+weDD/DiHgQ=; b=uMpMaqG1DqCWwx1hCI5PuOhkim7/TDAijWwMpe1ydZKEw+qIhizYVg/cft4VQapzD4 vzRLPboKiuQD0ZoY9vRl7zLw4E7JgW6k5CzgJIlwjvUz6TVW1XPRsfFF2wWQ4R14/pZi pAn7ChTywYn6exjMI1vNn5Ih0jSFSXn7AgpetOMZhQr7x0kzU1k+kk9zfhRC/JIaArDl SvoXQkKGfjFzJnPROvYxvC77bUGONoLXl+YQnBK7TWVdHGzUMY0mmb10gDIlZkXpNXgc VmvfNO4QTLaSiJPS+ROPLbAm2awcyFtVjD0nDsFHebUVzUYXb0H8js0WQ+bS39DRONlF zj1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684322092; x=1686914092; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VnIEpqHICz7MCR44hDCQrdJI2TjC+iEi+weDD/DiHgQ=; b=jMwzy9JlYEuuS+389bhR91niYx2oD2HcveL84P9eR5BTwxn8dKTTPA5ekNBmalA008 Seorr8Q2oNDoIM6ZXpI15sVy2oFA0+lUBaF3V5Vf7ySCiegk/6y65pFJpztE7O2+/qt9 fxXt3X6dTKhAolsf56JUvAM86svB9CcBAkZ+o/pRMENYXRTrAST17PGHRPQ38SeKH527 9fbnosGsCUuVtLcm83wSLenXkNu5Wf+7xXILxV5acGqeQtdCl1+rJL4MIr9S/h8o4AZ+ zarSwcmtFK3K+OCVz4RUubLln+1CFQQ0g29q61z2co9TXsnXo2kCjfE0bOHutoZlgWII jyaw== X-Gm-Message-State: AC+VfDxG5Jj8b9+iygYloWFbgNMKjw6vR8juKahRdvHzM5PkPx4g33I6 k04lFNK8af4023QiswOgYa1Jcw== X-Received: by 2002:a17:907:6d25:b0:965:d7c7:24db with SMTP id sa37-20020a1709076d2500b00965d7c724dbmr1640573ejc.32.1684322091870; Wed, 17 May 2023 04:14:51 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b0094f124a37c4sm12326880ejb.18.2023.05.17.04.14.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:14:51 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 12/12] ASoC: codecs: rt722-sdca: do not store status in state container Date: Wed, 17 May 2023 13:14:16 +0200 Message-Id: <20230517111416.424420-12-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> References: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766140828334558283?= X-GMAIL-MSGID: =?utf-8?q?1766140828334558283?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/rt722-sdca-sdw.c | 5 +---- sound/soc/codecs/rt722-sdca.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt722-sdca-sdw.c b/sound/soc/codecs/rt722-sdca-sdw.c index 0a791a14215e..bfb2dac6bfee 100644 --- a/sound/soc/codecs/rt722-sdca-sdw.c +++ b/sound/soc/codecs/rt722-sdca-sdw.c @@ -163,9 +163,6 @@ static int rt722_sdca_update_status(struct sdw_slave *slave, { struct rt722_sdca_priv *rt722 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt722->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt722->hw_init = false; @@ -188,7 +185,7 @@ static int rt722_sdca_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt722->hw_init || rt722->status != SDW_SLAVE_ATTACHED) + if (rt722->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt722-sdca.h b/sound/soc/codecs/rt722-sdca.h index 5bc6184d09aa..44af8901352e 100644 --- a/sound/soc/codecs/rt722-sdca.h +++ b/sound/soc/codecs/rt722-sdca.h @@ -20,7 +20,6 @@ struct rt722_sdca_priv { struct regmap *mbq_regmap; struct snd_soc_component *component; struct sdw_slave *slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init;