From patchwork Tue May 16 20:05:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 94913 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp678340vqo; Tue, 16 May 2023 13:17:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4tiGfK1O/F81tKIB7qZKjTdGAcYx0FBTUurDYefylLuc20ytyOR3X0hR4GAjXZ5me8g1Fl X-Received: by 2002:a17:902:be0b:b0:1a9:7ffb:5ed0 with SMTP id r11-20020a170902be0b00b001a97ffb5ed0mr33656580pls.59.1684268267840; Tue, 16 May 2023 13:17:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684268267; cv=none; d=google.com; s=arc-20160816; b=zV7sp2H6jsdJYJAKCOKIX2u61KATsojaDciVrVeTuboWk+enLdw50+Tqm9Ur1lEIFH Dx6mqgKF51M38l8QAWnlGiLpaisRYs9vv/2w/ZS1Ck3QzvxMHesTjbyId3K++E370g1S ItExzqZzewpVYzVyfbAkkJ1weI3kzD2GRiL7kZeJzrb63ZNN+Sb07dEys4FEnBS/i/xP kMucck7UL/jegV9kfHekItCwB1xZIYBIsGjD05B+dDcNucnuyGwwZ4AVq+3ipu+jYzei 9Ctt0SJnAM/nInVGdnh76Nso/KXPlqMEcOBsSChlbpX2JXgBh92OTNeLdndbR6ok9MMj mxDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=k2rvViNHJQUn+XEbEn+7oxU+FypjNe7wHMRDsGtj3rE=; b=eUqb2/sKnXXEw576M8XcMj4pl4v+wH3pDiaMmEkV/D1vw14PY7V4uk2sEl7KH8Ar7D /L9rPEUAmlVTCrlAzrCdtm+yWow9OxnfhT2IYyvXgM6jH774rbOJvi3p2D5n5NKYlUCt 6SFQXcVa1tTcGeN2F/HK2k4GHsOJcG/jAEylv504z7PzRx2k/cH721EOdj8ewSPwuT7V BKeO+6GEt+tiyA0gMxQeodqmZkikrolOT5N5WA3tcQNrg3sx8CmtISsAVY3kfzdtfqCi Rl9lfyiulECW2zuA4Bh9eiOiUFFgQObj4s96y0w/lv8MRfNwRI6Jeb4RNAiFbASTSWeh DAbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=J+ZvipnA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q6-20020a170902a3c600b001aade54f986si18354550plb.249.2023.05.16.13.17.33; Tue, 16 May 2023 13:17:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=J+ZvipnA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229680AbjEPUFZ (ORCPT + 99 others); Tue, 16 May 2023 16:05:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229585AbjEPUFX (ORCPT ); Tue, 16 May 2023 16:05:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C14DE5FCA for ; Tue, 16 May 2023 13:05:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5EAA562CEE for ; Tue, 16 May 2023 20:05:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B5A0C433D2; Tue, 16 May 2023 20:05:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684267521; bh=wikSyWqzlAJd2tgFWBBFCVgyU4deM5B+UNmj/wOjPpE=; h=From:To:Cc:Subject:Date:From; b=J+ZvipnA8doCVHcQF1T6olbgyqzzfVEXHSt8VUWUyYvIdCL5M+5RqBS1M93ppRfkQ 77uKZauXRaFZcyf6/Tfe9RONL7pzWQOqC4uIQJk5v+wGF9vy3ZWhZ61hOzoFd/xUuT BC62Kf5s/yTIbQRfaZoWVFLUB7ZHMA1FdcIjaZwx1GGgivVZGWSACminSLUTSCTobE 3XVXVUNUMaYjOjQpP6QLwppgeFfip3nFarr4g5Y1XjPNSM8wXsywSBRrkjosyLF0gS zF9YqmAxaXl6mwjrRTLhsSW+4b5laIDg2/W2VrgYx84hZydrxrv5sTX2urabAhrMeL myrTRJo4kRMdw== From: Arnd Bergmann To: Thomas Gleixner , Marc Zyngier , Linus Walleij Cc: Arnd Bergmann , linux-kernel@vger.kernel.org Subject: [PATCH 1/5] irqchip: ftintc010: mark all function static Date: Tue, 16 May 2023 22:05:04 +0200 Message-Id: <20230516200516.554663-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766083283009196780?= X-GMAIL-MSGID: =?utf-8?q?1766083283009196780?= From: Arnd Bergmann Two functions were always global but never had any callers outside of this file: drivers/irqchip/irq-ftintc010.c:128:39: error: no previous prototype for 'ft010_irqchip_handle_irq' drivers/irqchip/irq-ftintc010.c:165:12: error: no previous prototype for 'ft010_of_init_irq' Fixes: b4d3053c8ce9 ("irqchip: Add a driver for Cortina Gemini") Signed-off-by: Arnd Bergmann Reviewed-by: Linus Walleij --- drivers/irqchip/irq-ftintc010.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-ftintc010.c b/drivers/irqchip/irq-ftintc010.c index 46a3aa60e50e..359efc1d1be7 100644 --- a/drivers/irqchip/irq-ftintc010.c +++ b/drivers/irqchip/irq-ftintc010.c @@ -125,7 +125,7 @@ static struct irq_chip ft010_irq_chip = { /* Local static for the IRQ entry call */ static struct ft010_irq_data firq; -asmlinkage void __exception_irq_entry ft010_irqchip_handle_irq(struct pt_regs *regs) +static asmlinkage void __exception_irq_entry ft010_irqchip_handle_irq(struct pt_regs *regs) { struct ft010_irq_data *f = &firq; int irq; @@ -162,7 +162,7 @@ static const struct irq_domain_ops ft010_irqdomain_ops = { .xlate = irq_domain_xlate_onetwocell, }; -int __init ft010_of_init_irq(struct device_node *node, +static int __init ft010_of_init_irq(struct device_node *node, struct device_node *parent) { struct ft010_irq_data *f = &firq; From patchwork Tue May 16 20:05:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 94906 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp673796vqo; Tue, 16 May 2023 13:09:03 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5/nILEdOdaW0Sd7XsGbBPeqay2fzZlLXCcZjeJHS132P1juYdawmLTb16LQid4aD4IbbIS X-Received: by 2002:a17:902:a584:b0:1aa:f173:2892 with SMTP id az4-20020a170902a58400b001aaf1732892mr2399430plb.57.1684267743123; Tue, 16 May 2023 13:09:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684267743; cv=none; d=google.com; s=arc-20160816; b=odMVran1GPhpo4wLvDPQFIUMD1qnTC5u/BaYu4OzpWnkhRKKk/pnaOinKn1dP5hxOG BUIxUQeAZrJTPrac2uOuxk7rGsUx+lCvki8Ad1P44D9zvlSM8NBU+vpV5fMbE1M3YL1E J13YmfQkeWAYAE0Fx50+K6A6ywCF9e45gTRgs7zTm2sibUZ0WNu5pqYSi652bpHTiZ1m StNxNCbWCKqWMJyXErGtQ9KrUstn4t0N7YFxm75hWvIhVZhi4bRapiUWe72OsWJlFuSl SNo3/oAFvaIHUTj8kE3RE5AxsDCRjbWqJmYOySxcrAhFW6loRmTYdoBUVROpvIn8MZNo 7BZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NjRiDIjQA5mDux1ZqQNNcApCHLib2r3rniGP3v+ooCM=; b=XJQXB3fNHBNtOQq9qWOtxYCbpkUJE0v/aJCdmklu+39e4K9vsWzKLFNawBFB/CF+Ox HlUTW6gEXTGkezPUTHYpkNsld4UDaQ+W0eHU4thBuIG8u7UfFWUJKAEt9cl3WUtVaA1/ OnqhRH84gdp9V+i/R8LV1vuOwICUGk8v/X0NAkvSLX26OkXWtqsqUZnX9foXQFG2KAN1 FiHSH3DJcZjlLOIjO15BCfb/lxkRw8jJGmJcv4sLZ0KocAC2jkJ1x546gVWbdcx1YXdG 7Ra57iRnItD5SA6Fze9sTqSLbLCIFxtwiclfJP6AB4izVyn1mfELT8ZHi7K2ugCfB8ai uLeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Rh94Is4l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g21-20020a170902869500b001a63b045c86si18302352plo.10.2023.05.16.13.08.47; Tue, 16 May 2023 13:09:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Rh94Is4l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229810AbjEPUFf (ORCPT + 99 others); Tue, 16 May 2023 16:05:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229585AbjEPUFe (ORCPT ); Tue, 16 May 2023 16:05:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A0F25FCA for ; Tue, 16 May 2023 13:05:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 05C1063297 for ; Tue, 16 May 2023 20:05:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C759C433D2; Tue, 16 May 2023 20:05:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684267531; bh=C26ece4b4niNCvvb1qP08GjRXSjksKycT9Ijfpwgod4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Rh94Is4ld9AwD+rwDThBnzTSVBiyElsidNrl9ySKDLQRqe1mIrE7X8/URRqlonQr4 5hrSbqKtub2yY2dh7lkfTVeZ5NnqdKeIaWNOCjKlpCNkWfhEknljqJ/A2zKQLmvsjR X8/i4LjAa3zTuj5TJPBCnZwPcAudObRm1vDj7s11rPGNVA2dc4AsCjgMn4CWAisiCh JA57/jxmieVogCW5eSl0PuaV6csVYbtP5GWhhr3ENswHpKE56E4klt4tS93p1dmAC+ kW274DrTm54///5TPhedAhX2upKFCOHpz9RQiQqvNUoGZogiP7e4V5SFH86K+rPb2V JNzon1xp6xu7w== From: Arnd Bergmann To: Thomas Gleixner , Marc Zyngier , Arnd Bergmann Cc: Ben Dooks , linux-kernel@vger.kernel.org Subject: [PATCH 2/5] irqchip: mmp: remove non-DT codepath Date: Tue, 16 May 2023 22:05:05 +0200 Message-Id: <20230516200516.554663-2-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230516200516.554663-1-arnd@kernel.org> References: <20230516200516.554663-1-arnd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766082733012139771?= X-GMAIL-MSGID: =?utf-8?q?1766082733012139771?= From: Arnd Bergmann Building with "W=1" warns about missing declarations for two functions in the mmp irqchip driver: drivers/irqchip/irq-mmp.c:248:13: error: no previous prototype for 'icu_init_irq' drivers/irqchip/irq-mmp.c:271:13: error: no previous prototype for 'mmp2_init_icu' The declarations are present in an unused header, but since there is no caller, it's best to just remove the functions and the header completely, making the driver DT-only to match the state of the platform. Fixes: 77acc85ce797 ("ARM: mmp: remove device definitions") Signed-off-by: Arnd Bergmann --- drivers/irqchip/irq-mmp.c | 127 ------------------------------------ include/linux/irqchip/mmp.h | 10 --- 2 files changed, 137 deletions(-) delete mode 100644 include/linux/irqchip/mmp.h diff --git a/drivers/irqchip/irq-mmp.c b/drivers/irqchip/irq-mmp.c index 83455ca72439..25cf4f80e767 100644 --- a/drivers/irqchip/irq-mmp.c +++ b/drivers/irqchip/irq-mmp.c @@ -244,132 +244,6 @@ static void __exception_irq_entry mmp2_handle_irq(struct pt_regs *regs) generic_handle_domain_irq(icu_data[0].domain, hwirq); } -/* MMP (ARMv5) */ -void __init icu_init_irq(void) -{ - int irq; - - max_icu_nr = 1; - mmp_icu_base = ioremap(0xd4282000, 0x1000); - icu_data[0].conf_enable = mmp_conf.conf_enable; - icu_data[0].conf_disable = mmp_conf.conf_disable; - icu_data[0].conf_mask = mmp_conf.conf_mask; - icu_data[0].nr_irqs = 64; - icu_data[0].virq_base = 0; - icu_data[0].domain = irq_domain_add_legacy(NULL, 64, 0, 0, - &irq_domain_simple_ops, - &icu_data[0]); - for (irq = 0; irq < 64; irq++) { - icu_mask_irq(irq_get_irq_data(irq)); - irq_set_chip_and_handler(irq, &icu_irq_chip, handle_level_irq); - } - irq_set_default_host(icu_data[0].domain); - set_handle_irq(mmp_handle_irq); -} - -/* MMP2 (ARMv7) */ -void __init mmp2_init_icu(void) -{ - int irq, end; - - max_icu_nr = 8; - mmp_icu_base = ioremap(0xd4282000, 0x1000); - icu_data[0].conf_enable = mmp2_conf.conf_enable; - icu_data[0].conf_disable = mmp2_conf.conf_disable; - icu_data[0].conf_mask = mmp2_conf.conf_mask; - icu_data[0].nr_irqs = 64; - icu_data[0].virq_base = 0; - icu_data[0].domain = irq_domain_add_legacy(NULL, 64, 0, 0, - &irq_domain_simple_ops, - &icu_data[0]); - icu_data[1].reg_status = mmp_icu_base + 0x150; - icu_data[1].reg_mask = mmp_icu_base + 0x168; - icu_data[1].clr_mfp_irq_base = icu_data[0].virq_base + - icu_data[0].nr_irqs; - icu_data[1].clr_mfp_hwirq = 1; /* offset to IRQ_MMP2_PMIC_BASE */ - icu_data[1].nr_irqs = 2; - icu_data[1].cascade_irq = 4; - icu_data[1].virq_base = icu_data[0].virq_base + icu_data[0].nr_irqs; - icu_data[1].domain = irq_domain_add_legacy(NULL, icu_data[1].nr_irqs, - icu_data[1].virq_base, 0, - &irq_domain_simple_ops, - &icu_data[1]); - icu_data[2].reg_status = mmp_icu_base + 0x154; - icu_data[2].reg_mask = mmp_icu_base + 0x16c; - icu_data[2].nr_irqs = 2; - icu_data[2].cascade_irq = 5; - icu_data[2].virq_base = icu_data[1].virq_base + icu_data[1].nr_irqs; - icu_data[2].domain = irq_domain_add_legacy(NULL, icu_data[2].nr_irqs, - icu_data[2].virq_base, 0, - &irq_domain_simple_ops, - &icu_data[2]); - icu_data[3].reg_status = mmp_icu_base + 0x180; - icu_data[3].reg_mask = mmp_icu_base + 0x17c; - icu_data[3].nr_irqs = 3; - icu_data[3].cascade_irq = 9; - icu_data[3].virq_base = icu_data[2].virq_base + icu_data[2].nr_irqs; - icu_data[3].domain = irq_domain_add_legacy(NULL, icu_data[3].nr_irqs, - icu_data[3].virq_base, 0, - &irq_domain_simple_ops, - &icu_data[3]); - icu_data[4].reg_status = mmp_icu_base + 0x158; - icu_data[4].reg_mask = mmp_icu_base + 0x170; - icu_data[4].nr_irqs = 5; - icu_data[4].cascade_irq = 17; - icu_data[4].virq_base = icu_data[3].virq_base + icu_data[3].nr_irqs; - icu_data[4].domain = irq_domain_add_legacy(NULL, icu_data[4].nr_irqs, - icu_data[4].virq_base, 0, - &irq_domain_simple_ops, - &icu_data[4]); - icu_data[5].reg_status = mmp_icu_base + 0x15c; - icu_data[5].reg_mask = mmp_icu_base + 0x174; - icu_data[5].nr_irqs = 15; - icu_data[5].cascade_irq = 35; - icu_data[5].virq_base = icu_data[4].virq_base + icu_data[4].nr_irqs; - icu_data[5].domain = irq_domain_add_legacy(NULL, icu_data[5].nr_irqs, - icu_data[5].virq_base, 0, - &irq_domain_simple_ops, - &icu_data[5]); - icu_data[6].reg_status = mmp_icu_base + 0x160; - icu_data[6].reg_mask = mmp_icu_base + 0x178; - icu_data[6].nr_irqs = 2; - icu_data[6].cascade_irq = 51; - icu_data[6].virq_base = icu_data[5].virq_base + icu_data[5].nr_irqs; - icu_data[6].domain = irq_domain_add_legacy(NULL, icu_data[6].nr_irqs, - icu_data[6].virq_base, 0, - &irq_domain_simple_ops, - &icu_data[6]); - icu_data[7].reg_status = mmp_icu_base + 0x188; - icu_data[7].reg_mask = mmp_icu_base + 0x184; - icu_data[7].nr_irqs = 2; - icu_data[7].cascade_irq = 55; - icu_data[7].virq_base = icu_data[6].virq_base + icu_data[6].nr_irqs; - icu_data[7].domain = irq_domain_add_legacy(NULL, icu_data[7].nr_irqs, - icu_data[7].virq_base, 0, - &irq_domain_simple_ops, - &icu_data[7]); - end = icu_data[7].virq_base + icu_data[7].nr_irqs; - for (irq = 0; irq < end; irq++) { - icu_mask_irq(irq_get_irq_data(irq)); - if (irq == icu_data[1].cascade_irq || - irq == icu_data[2].cascade_irq || - irq == icu_data[3].cascade_irq || - irq == icu_data[4].cascade_irq || - irq == icu_data[5].cascade_irq || - irq == icu_data[6].cascade_irq || - irq == icu_data[7].cascade_irq) { - irq_set_chip(irq, &icu_irq_chip); - irq_set_chained_handler(irq, icu_mux_irq_demux); - } else { - irq_set_chip_and_handler(irq, &icu_irq_chip, - handle_level_irq); - } - } - irq_set_default_host(icu_data[0].domain); - set_handle_irq(mmp2_handle_irq); -} - -#ifdef CONFIG_OF static int __init mmp_init_bases(struct device_node *node) { int ret, nr_irqs, irq, i = 0; @@ -548,4 +422,3 @@ static int __init mmp2_mux_of_init(struct device_node *node, return -EINVAL; } IRQCHIP_DECLARE(mmp2_mux_intc, "mrvl,mmp2-mux-intc", mmp2_mux_of_init); -#endif diff --git a/include/linux/irqchip/mmp.h b/include/linux/irqchip/mmp.h deleted file mode 100644 index aa1813749a4f..000000000000 --- a/include/linux/irqchip/mmp.h +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 */ -#ifndef __IRQCHIP_MMP_H -#define __IRQCHIP_MMP_H - -extern struct irq_chip icu_irq_chip; - -extern void icu_init_irq(void); -extern void mmp2_init_icu(void); - -#endif /* __IRQCHIP_MMP_H */ From patchwork Tue May 16 20:05:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 94910 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp677708vqo; Tue, 16 May 2023 13:16:31 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6ONCoJufNSar0k/BeDDPnZfalpj+6B2y5yKTq1jZRl5rQj8ci7kdjkJp6I9R6mV0ObhhEQ X-Received: by 2002:a05:6a00:2d9a:b0:641:d9b:a458 with SMTP id fb26-20020a056a002d9a00b006410d9ba458mr50546632pfb.18.1684268191351; Tue, 16 May 2023 13:16:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684268191; cv=none; d=google.com; s=arc-20160816; b=wPqsfC1gRsPUON+hOILFq/Qtq9GIAQ+DrdagtMTt5GH8LZA7FN8lFdUld/bNPa+ebr 7GkhYW5rBEKDnQ2k8cAsUPFWNpH58RNPYK20epxhbHvqreveZe+2ks9+6h4mwzsfxvog GFur6uvyhqRt4lAKApPQQKEEpTyBZxb0nfaN6OFB+Nm/kT+13RKuU1V4cmK842X+GfNk wGZBr6RLboukdAYo+1KwmurklNxun7iPYogad6nTnkD5+3YDZXW7eXMP1A5C6VKHFEqD /sD9P8lYq8WdM7r4IcHGAX/JTO5MYjsb8NL4RHMlrQKqXCNX6jGoqX/OidiY/9nS19UV +T2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dHISNxMWnDAAL33MvmxADtnXK1fLn4jJ9GL3ljRE478=; b=VFvM0LcYRIb/GNJOG7usv8g6ttb8yby6pB7+Jfd5ifuAKhfnkc5apAtG95osuAPQ+2 +4hvJMh1MFyVMUuYVij3EVL3ObEodq9MXFJ416B6cIAmdoZwQPuNkTgghqMCoGvl6quI jfpmTjxWt5/jDvDZZnDvMAA0RonJUioif0qfzQHW6RUUvpKEy6GBUMUtWZ/k5AcEkfiw iltZxleIP/zMa5JGlX8qWLXcdv6zzkNIMNCDNrD85K9+yg3Se+lZQeWdbh+Q4VfzOlDD ZyXSsIhkpnHUetj11dmqQrHAux41G/zlfkn0QtZExkbwh50TXUo9cgakORGOUZPZMXOh vpPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SRn29TWB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x1-20020aa79561000000b0063b8ab7f91csi20040750pfq.365.2023.05.16.13.16.16; Tue, 16 May 2023 13:16:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SRn29TWB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229666AbjEPUFo (ORCPT + 99 others); Tue, 16 May 2023 16:05:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230109AbjEPUFl (ORCPT ); Tue, 16 May 2023 16:05:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD00493E8 for ; Tue, 16 May 2023 13:05:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5EA7463AEE for ; Tue, 16 May 2023 20:05:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51C02C433EF; Tue, 16 May 2023 20:05:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684267538; bh=jOaCLqt9lfDL0b/jZW2RMI1YYnbfHLOLMiHxnOKfg+I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SRn29TWBolL8E06SvEVXRYmNHxVja3WkTfaclMbTb9FIqPMGNLqkJB4Rf5HPymwET W1yC0qEYh/haNdAOqMlR4HcoM6yVd4S5Y12FaGQ+29LjnGMeSXZGxCL5IVJyaSo9M/ ONyPHcCrbo5Lh8gO3a6T1PJDbj725FwPlWazv/EP6AmQfm0Z/0OjYWq4yNKcC81992 +Ah4gAwS/FIuFXQ0z+dBTTWkPtNr526wiAcuAoMTabLr+5SjGBv2BfViBSgIDWRo3P Vwm4f6aR8vUreKXhzOLKeD+0Qs9L89p5EQOTvyhcl48XArkjUDTcoSPGMUajAQbnb9 OCOwmkVjN1Sfw== From: Arnd Bergmann To: Thomas Gleixner , Marc Zyngier , Alexander Shiyan , Arnd Bergmann Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/5] irqchip: clps711x: remove unused clps711x_intc_init() function Date: Tue, 16 May 2023 22:05:06 +0200 Message-Id: <20230516200516.554663-3-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230516200516.554663-1-arnd@kernel.org> References: <20230516200516.554663-1-arnd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766083203322080346?= X-GMAIL-MSGID: =?utf-8?q?1766083203322080346?= From: Arnd Bergmann This function has no caller or declaration any more: drivers/irqchip/irq-clps711x.c:215:13: error: no previous prototype for 'clps711x_intc_init' The #ifdef check around clps711x_intc_init_dt() is also not needed since the file is only built when that is enabled. Fixes: 4a56f46a7dc6 ("ARM: clps711x: Remove boards support") Signed-off-by: Arnd Bergmann --- drivers/irqchip/irq-clps711x.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/irqchip/irq-clps711x.c b/drivers/irqchip/irq-clps711x.c index 77ebe7e47e0e..e731e0784f7e 100644 --- a/drivers/irqchip/irq-clps711x.c +++ b/drivers/irqchip/irq-clps711x.c @@ -212,12 +212,6 @@ static int __init _clps711x_intc_init(struct device_node *np, return err; } -void __init clps711x_intc_init(phys_addr_t base, resource_size_t size) -{ - BUG_ON(_clps711x_intc_init(NULL, base, size)); -} - -#ifdef CONFIG_IRQCHIP static int __init clps711x_intc_init_dt(struct device_node *np, struct device_node *parent) { @@ -231,4 +225,3 @@ static int __init clps711x_intc_init_dt(struct device_node *np, return _clps711x_intc_init(np, res.start, resource_size(&res)); } IRQCHIP_DECLARE(clps711x, "cirrus,ep7209-intc", clps711x_intc_init_dt); -#endif From patchwork Tue May 16 20:05:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 94907 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp677033vqo; Tue, 16 May 2023 13:15:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5K+Ld3TzDoKCd340eIdAA974IE5Yh9adAXMJCScmy8Q3lKxW21y09y2h2lit00SiPWA5Ml X-Received: by 2002:a05:6a00:15c6:b0:647:7ee8:6251 with SMTP id o6-20020a056a0015c600b006477ee86251mr35906512pfu.21.1684268120638; Tue, 16 May 2023 13:15:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684268120; cv=none; d=google.com; s=arc-20160816; b=Dj7u7gMTOnxMZT2A1ntTqyulcLcomQta3XMa+boxS6jK4W6qn3fY/0C/jKK02iGb0Y 78LnskjL/6qy9ad7B/E8w5ppFC8fH1u/NWC9thr/CMlEl3E8zVfFZKiTwA+TMl4s72Bz qU8dtERYBd+3WRDHKoSDEPxTUOIx3GKHv0toADRy1325bM6EhG9s9VGUBFRiNayPuIm/ tbf2b2+XI1Qfvy/oY/WLm94Ri/w0AsqPib6uikso98YVCRgMhfnx3frtZcmwJ0hA1G7O DxFi00IN4l/aPGQ4sIQNq28KaSZhdOQbxMU3LXZNjgTbWorXwrY/iP1FF8QkHO0YPsIb S0ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=08FNeik9IXQZgUys9Tgce8zqZE2a1ox0AaX9rqlQyts=; b=MUKoVnyjgw55Wx1D80cJUGxUDPIOou9rIHJqAX2iM3liBdNa+GHDP9duN84gSgxDPs iCvzyCfRrzZSSG6CfGDaHVDBXFkCeo9iilIQX7Eq6jgmUuWlMa6pjtQhuRnxVsaZjTWw 6jENBAqnBSWD4f0dkWHyVQ46WnqAufgJsKMahVitLc/PU1ThJRgKgXeBrEWNUlfxx5Zh 7ttOEkUE9enjnzuk8haryoxTS3XdIowydLgeYZJ7mRQJopkgNkV6OF6iNBOMjiJCyLAF Vrs5ikKfKecLJk1FF375AgX2S/kUXVOdL7G0GbBD0fbK9a5Mf0vByppJjPJw2e5+322t V+xg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TbZrs0ab; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h18-20020aa796d2000000b00648628d3104si16111697pfq.390.2023.05.16.13.15.05; Tue, 16 May 2023 13:15:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TbZrs0ab; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229818AbjEPUGB (ORCPT + 99 others); Tue, 16 May 2023 16:06:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229727AbjEPUF6 (ORCPT ); Tue, 16 May 2023 16:05:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77E4E76BE for ; Tue, 16 May 2023 13:05:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E8508618C9 for ; Tue, 16 May 2023 20:05:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 261F9C433EF; Tue, 16 May 2023 20:05:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684267551; bh=qyz4rw56+HC6dOFHzFvmq/eJldRmlY0llGb59kScA4Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TbZrs0abiBjSfYoc4+XApzegdn7g4TvGzFoj2IdvLYklyJIxK2B4DSfLtA0cOQO76 m959uQI/ndPgbQRg5SGtF3Gq/DjFZ3D4159hs+oi5gIgYxzLbYJowbqTrEZ2LYG0no ipZX7jiTlVvE+Xwe81xRUKgSEh3C2gtqTZlBGjU7TUySbB478q7LHa/ieq4PpWEzOn y7XnN01V49l5GngGq8WI2VCqqoEdJOXyRuZhlhDmdTFR4JdCxv6pjfVZkv6ehBIV8o 8xjEE5AfKytxDiHpj601yxGmmfXbYblf9qE37/FOZFOWAyiQjKX9mPzeItbIwylvOh l5DY1GdpB0I0Q== From: Arnd Bergmann To: Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer Cc: Arnd Bergmann , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/5] irqchip: mxs: include linux/irqchip/mxs.h Date: Tue, 16 May 2023 22:05:07 +0200 Message-Id: <20230516200516.554663-4-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230516200516.554663-1-arnd@kernel.org> References: <20230516200516.554663-1-arnd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766083129013735662?= X-GMAIL-MSGID: =?utf-8?q?1766083129013735662?= From: Arnd Bergmann This header contains the definition for icoll_handle_irq(), which is used in arch/arm/mach-mxs/mach-mxs.c, without this we get a warning about a missing prototype when building with W=1. Signed-off-by: Arnd Bergmann Acked-by: Shawn Guo --- drivers/irqchip/irq-mxs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-mxs.c b/drivers/irqchip/irq-mxs.c index 55cb6b5a686e..b3b1fba871c1 100644 --- a/drivers/irqchip/irq-mxs.c +++ b/drivers/irqchip/irq-mxs.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include #include From patchwork Tue May 16 20:05:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 94912 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp678315vqo; Tue, 16 May 2023 13:17:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7BuF3Oqi4Gsl9IpE/k41hil+JHmYNGgUOB9nolnCtpiVyxv61VgO0hCT5J1gTB4JEaW4Ag X-Received: by 2002:a05:6a20:12c2:b0:105:8173:93a0 with SMTP id v2-20020a056a2012c200b00105817393a0mr13420572pzg.5.1684268264880; Tue, 16 May 2023 13:17:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684268264; cv=none; d=google.com; s=arc-20160816; b=nxIcm5NNnD50UGQvPoN6UX4J2tzFqnal2KKQ4ARtBoiSPkB1HGA22Yi+/y0s6TvjBl tbXi4BKXn00gIc9B0B7SR1Ls+f3oT6DJximwZY6wFd7O54VJcPkbCS3KJ6kkyOiGq01W xLCqIOqNbrTa3wRjrtjykcSkVcaYLVADzKBgRTLBpdAnXc4kpeVj124DB/+oxFF9PZhg U3qk1shMogcyCWWj2zoHGF7Fbkb8sWrV0zuJB7bsaoyADHK3omTz9IS+bUJvQ/47CAxG NW8KwfakK5jwQsH6nPp9oqaTl4qTugvthOJxRp7CffaDC7+3GZib4FHpfBnMMISKHSG1 1x5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from :dkim-signature; bh=vA/cABhBVASxvDqgVY8tJtBA1bqQ/h8hODAJc4kq3es=; b=pK+FAgQr76/CIMxaESm8jAbOPbqhH7o1RughRsKcgAdwp+ry6lpAYLF8IB9BuLlJ/U ++MsOMxAHjYZ7eri5aqTtx6Z6fr9JwbWwP0ysONFj3T1ys7D+B4tXVnbDBlCxsJRu8Bh SdDxmKHXfq/f2jiK9EkFT4tMFFuWRTKaU29FY/2iDo282eVgue8tNoyYuvksfnfac4Rw gDsf6zugItQvMVV140GdZ5e6ahazIR+bDpU3k9EhSAkJTBTXZCjWFd1qXHA9vpvaILj8 fqBxHjL1mSINQ1WgH8s3MPk3PFL0TIVtK3C3bOe2/+NoNktn1yj57kD7R6mHM+nwdBpu 0t1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=h9D4f8rC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i66-20020a625445000000b0064caa26723bsi5300886pfb.318.2023.05.16.13.17.30; Tue, 16 May 2023 13:17:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=h9D4f8rC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229635AbjEPUGN (ORCPT + 99 others); Tue, 16 May 2023 16:06:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230050AbjEPUGK (ORCPT ); Tue, 16 May 2023 16:06:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BED56582 for ; Tue, 16 May 2023 13:06:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AD8D4618C9 for ; Tue, 16 May 2023 20:06:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7AD3C433D2; Tue, 16 May 2023 20:05:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684267560; bh=7dX4GIh606KqYGe9dKO1nnlkYackAgVvqWFkxj3MV3c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h9D4f8rCdLfFdDw7qINtml7i1SoNHf4q3RadsfMLORAPy7fjCpDtEOLXrddBoM1hd YSgauh0A1hrL20xIDd8dWKSdcTKkfJ6SwFT9V9nWm2IuFzMa2RuqCQvzpR/HNIh3qq HN1eqL0zUFzObo4wk8Ck90RjbgZUN9LEFpCF6E/S3vNWpHVzxc1rIlmY43hyB3ZeKM r7CfpAAwhsWIDh5jCyrsg4t10D24wDWpUZsAzERYils/hQi+dsxSIvWPfzmCmrT3+H h3C6UBMzjtVaIKlO/ux/MIRZYLZnT4R7dEC6BuOolurl2NDQ5BnZ17OkTfrq8pinzx X5mkIqwUPx1Iw== From: Arnd Bergmann Cc: Arnd Bergmann , Hanjun Guo , Joerg Roedel , Robin Murphy , Shameer Kolothum , linux-kernel@vger.kernel.org Subject: [PATCH 5/5] irqchip: gicv3: add a iort_pmsi_get_dev_id() prototype Date: Tue, 16 May 2023 22:05:08 +0200 Message-Id: <20230516200516.554663-5-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230516200516.554663-1-arnd@kernel.org> References: <20230516200516.554663-1-arnd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766083279666541687?= X-GMAIL-MSGID: =?utf-8?q?1766083279666541687?= From: Arnd Bergmann iort_pmsi_get_dev_id() has a __weak definition in the driver, and an override in arm64 specific code, but the declaration is conditional and not always seen when the copy in the driver gets built: drivers/irqchip/irq-gic-v3-its-platform-msi.c:41:12: error: no previous prototype for 'iort_pmsi_get_dev_id' [-Werror=missing-prototypes] Move the existing declaration out of the #ifdef block to ensure it can be seen in all configurations. Signed-off-by: Arnd Bergmann Reviewed-by: Hanjun Guo --- include/linux/acpi_iort.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/acpi_iort.h b/include/linux/acpi_iort.h index b43be0987b19..6b70d02bc5f9 100644 --- a/include/linux/acpi_iort.h +++ b/include/linux/acpi_iort.h @@ -26,13 +26,14 @@ int iort_register_domain_token(int trans_id, phys_addr_t base, struct fwnode_handle *fw_node); void iort_deregister_domain_token(int trans_id); struct fwnode_handle *iort_find_domain_token(int trans_id); +int iort_pmsi_get_dev_id(struct device *dev, u32 *dev_id); + #ifdef CONFIG_ACPI_IORT void acpi_iort_init(void); u32 iort_msi_map_id(struct device *dev, u32 id); struct irq_domain *iort_get_device_domain(struct device *dev, u32 id, enum irq_domain_bus_token bus_token); void acpi_configure_pmsi_domain(struct device *dev); -int iort_pmsi_get_dev_id(struct device *dev, u32 *dev_id); void iort_get_rmr_sids(struct fwnode_handle *iommu_fwnode, struct list_head *head); void iort_put_rmr_sids(struct fwnode_handle *iommu_fwnode,