From patchwork Mon May 15 08:40:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 93969 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp6763179vqo; Mon, 15 May 2023 01:41:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ70PycAKmQFIJulKHkerdh4ALNwavnRmQOhHwSQQ1D5/gI2dGxyIVo9jYP2x8s4IBN13Gzi X-Received: by 2002:a17:907:7ba3:b0:966:61b3:f638 with SMTP id ne35-20020a1709077ba300b0096661b3f638mr28004344ejc.26.1684140093997; Mon, 15 May 2023 01:41:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684140093; cv=none; d=google.com; s=arc-20160816; b=nYwmojabvcCg5U+bUOh9HJ7djqfMvXuo1ZmLeBRzNQStNDvZMaEtiLSJkBT/Sn7lhX oI06mPyoE+DOq1di5HiIKR077uPX73vfVTU7Ra4huEkcnePh8evK4hO4e7j6vqr0OwNg NzBkZxJkVjakcl2TVXU/uZFBjWFQywv0vqrA/kaXqVn+uLf+aOFzl4nEXW2Zd6c1kOyD IOfM5Iekfh3NwufJ3rPg4Uwmqm2iLAY2PqR4dy716ymZoOjb6ysCHl8ZuZYUxf5O1U5J r25lhqG9YkbadWrja7Noofr/QfS4HVTO2nlOy8kM9cB/VpzykRT7Q4p4Hp0dcyKAW/pr ZFQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:message-id :mime-version:subject:to:date:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=oP7/RMI/CvnBOCH5rbspxU1+UlUMHGeoKJ8uk95mHro=; b=k3bJUXEmwNY/xLz8bKrROioM4HY4v5vUi9x2GQYz3sT1yflKEhvcDCR01KUQ32hqAc y2HXuDy5HOhtxZATuwCpLHiYGfFGlSDd8aeOLZyPM517TjRHWnmP1sfxHRIv6KsbaXV7 eY2nEVtsbA0iVF3KFHLHvxpOoCbPu3nEyLsuAmIkvtFUy1hnP0dwZoe7mrdXAHl4h1UZ I7+lK9l5Q2W7HrE9NeMe6iecedFjcxI+hrxIgO4wjzLHrRpBai1Ke9Zc5nMuEr++F7qj JHZMqdamT02vAdSFBcOLIu2CpA2mO4P88WkAgzzZd60UnTX+A5/1I28hP4gMumAZYjdz TOWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=ivXXYtOq; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id ud14-20020a170907c60e00b0096a24903e7dsi9210696ejc.866.2023.05.15.01.41.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 May 2023 01:41:33 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=ivXXYtOq; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A6B243857340 for ; Mon, 15 May 2023 08:41:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A6B243857340 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1684140092; bh=oP7/RMI/CvnBOCH5rbspxU1+UlUMHGeoKJ8uk95mHro=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=ivXXYtOqcE8J/bom3MXDPzPhoax+LowoUQrOeWB4Gr/r8Dhu0y2kf1yMcOCM8de75 LOzV729H4JB6skgoOW2/edRw7DxtHximJGOra9CcQRBPsfY7WIcBLXVRAr1wSdg/5u PDfHiGZWmBDYvk1bBgfWDOqqnuWD98c6b8MHv4yI= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 246BE385735A for ; Mon, 15 May 2023 08:40:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 246BE385735A Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5BF1B21D4A for ; Mon, 15 May 2023 08:40:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 475AF138E5 for ; Mon, 15 May 2023 08:40:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qktJEA/wYWRDMQAAMHmgww (envelope-from ) for ; Mon, 15 May 2023 08:40:47 +0000 Date: Mon, 15 May 2023 10:40:46 +0200 (CEST) To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/109848 - fix TARGET_MEM_REF store from CTOR simplification MIME-Version: 1.0 Message-Id: <20230515084047.475AF138E5@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765948883544125425?= X-GMAIL-MSGID: =?utf-8?q?1765948883544125425?= I've put the preparation stmt in the wrong place. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/109848 * tree-ssa-forwprop.cc (pass_forwprop::execute): Put the TARGET_MEM_REF address preparation before the store, not before the CTOR. --- gcc/tree-ssa-forwprop.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gcc/tree-ssa-forwprop.cc b/gcc/tree-ssa-forwprop.cc index e63d2ab82c9..06f19868ade 100644 --- a/gcc/tree-ssa-forwprop.cc +++ b/gcc/tree-ssa-forwprop.cc @@ -3841,7 +3841,10 @@ pass_forwprop::execute (function *fun) if (auto_var_p (use_lhs)) DECL_NOT_GIMPLE_REG_P (use_lhs) = 1; else if (TREE_CODE (use_lhs) == TARGET_MEM_REF) - use_lhs = prepare_target_mem_ref_lvalue (use_lhs, &gsi); + { + gimple_stmt_iterator gsi2 = gsi_for_stmt (use_stmt); + use_lhs = prepare_target_mem_ref_lvalue (use_lhs, &gsi2); + } for (unsigned HOST_WIDE_INT bi = 0; bi < n; bi += elt_w) { unsigned HOST_WIDE_INT ci = bi / elt_w;