From patchwork Mon May 15 06:57:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 93940 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp6735398vqo; Mon, 15 May 2023 00:35:26 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6bUTT2L3Qdscpby4nSnKMssPdo7hJb0H6WM3+LbvodK4HvcIA+ZaVVAIQdLwAE7ndryZkp X-Received: by 2002:a17:902:9049:b0:1ab:19db:f2b with SMTP id w9-20020a170902904900b001ab19db0f2bmr35092111plz.36.1684136126340; Mon, 15 May 2023 00:35:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684136126; cv=none; d=google.com; s=arc-20160816; b=LQu0OxgeqC3N3HL+6dC0ud9pksvGbjIh9gcAi/pNkydfMkgYBClWMSkXpV16YcIAaU JhjFzG/HW1jUSEJ6GRTk+MGfVfRjqYNHWtfL1bF3/aBjrxk3hhVhxEMnW7Eiwn1oFx1B AinN9NUFC4+h457PWpDf7Vb31wvDYNqT/DmEyymquq1nWdKUr6iDgw13aM9j7nMVr+Kt UNpHSmQrCj9CX3tKiz3n1SlgkIZ2Ubiy6T4/VYm2JjLYiuYRgmRSWAzY6ycf5YyNDw99 3xiZ9G14I8uN9ubTuEcjzASV4q9YMrrmE8m3G/3yx8qww7M33EVFgOtJo62ipJ4QXc+D N4xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ix5WV7UkkH9a6z85RMsXJaJZKaUHst4giIV77jGFlHw=; b=ba4Yg9vFcy4i67RbWU9+zl0KLWzD7X0sHXZcLSBIQHbUGRuSyD0HpCFZ0sVwUF34v1 kP6vcBZLkpheYmf2hB9pJ/oCYSm3c6d4S4v78rIHk3kJtEYX5SBd0QGkdrmumbu3zrix J9+pWcK0Mi/XEu3CrJloAYoW+p6df/dHsaNa5VofwUHqtgHdmHvhR3+eWRHHmDSUcErA 7bN3JG5mWvD383wZebXlQUxzNFsRuCN4N92XkaAvbSH3SFp7HdZxeXlDXY39CHTDIjQj 8Hr+66tInyvTusDBhhllpU6YwXYxT71K411ukwjmix13O+HvJH0da2h7/qFr7ckZBbse 8aUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p7-20020a170902e74700b001a55571febesi12249468plf.277.2023.05.15.00.35.13; Mon, 15 May 2023 00:35:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240643AbjEOG61 (ORCPT + 99 others); Mon, 15 May 2023 02:58:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240519AbjEOG6I (ORCPT ); Mon, 15 May 2023 02:58:08 -0400 Received: from xavier.telenet-ops.be (xavier.telenet-ops.be [IPv6:2a02:1800:120:4::f00:14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACCF1199F for ; Sun, 14 May 2023 23:57:09 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed30:3f77:5127:1ef7:f210]) by xavier.telenet-ops.be with bizsmtp id wux62900P5WeK8L01ux6o4; Mon, 15 May 2023 08:57:06 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1pyS8e-002Dc8-Gm; Mon, 15 May 2023 08:57:06 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1pyS8o-007EMC-BW; Mon, 15 May 2023 08:57:06 +0200 From: Geert Uytterhoeven To: Greg Kroah-Hartman , Jiri Slaby , Tony Lindgren Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] serial: 8250: omap: Move uart_write() inside PM section Date: Mon, 15 May 2023 08:57:06 +0200 Message-Id: <20230515065706.1723477-1-geert@linux-m68k.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765944722666210205?= X-GMAIL-MSGID: =?utf-8?q?1765944722666210205?= If CONFIG_PM is not set (e.g. m68k/allmodconfig): drivers/tty/serial/8250/8250_omap.c:169:13: error: ‘uart_write’ defined but not used [-Werror=unused-function] 169 | static void uart_write(struct omap8250_priv *priv, u32 reg, u32 val) | ^~~~~~~~~~ Fix tis by moving uart_write() inside the existing section protected by #ifdef CONFIG_PM. Reported-by: noreply@ellerman.id.au Link: http://kisskb.ellerman.id.au/kisskb/buildresult/14925095/ Fixes: 398cecc24846e867 ("serial: 8250: omap: Fix imprecise external abort for omap_8250_pm()") Signed-off-by: Geert Uytterhoeven Reviewed-by: Tony Lindgren --- drivers/tty/serial/8250/8250_omap.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c index 5c093dfcee1d53bb..6bd15089fa67383f 100644 --- a/drivers/tty/serial/8250/8250_omap.c +++ b/drivers/tty/serial/8250/8250_omap.c @@ -166,11 +166,6 @@ static u32 uart_read(struct omap8250_priv *priv, u32 reg) return readl(priv->membase + (reg << OMAP_UART_REGSHIFT)); } -static void uart_write(struct omap8250_priv *priv, u32 reg, u32 val) -{ - writel(val, priv->membase + (reg << OMAP_UART_REGSHIFT)); -} - /* * Called on runtime PM resume path from omap8250_restore_regs(), and * omap8250_set_mctrl(). @@ -1637,6 +1632,11 @@ static int omap8250_lost_context(struct uart_8250_port *up) return 0; } +static void uart_write(struct omap8250_priv *priv, u32 reg, u32 val) +{ + writel(val, priv->membase + (reg << OMAP_UART_REGSHIFT)); +} + /* TODO: in future, this should happen via API in drivers/reset/ */ static int omap8250_soft_reset(struct device *dev) {