From patchwork Sat May 13 11:52:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 93514 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp5742541vqo; Sat, 13 May 2023 05:35:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7iFmnnk1aD+PIwPw2rBKy+Jl0NIyaMoqk7bTucNJBzV1L7zYQpPv4vE4IPvvvanuxu0siD X-Received: by 2002:a17:902:e751:b0:1ab:b120:8efe with SMTP id p17-20020a170902e75100b001abb1208efemr32339122plf.22.1683981307582; Sat, 13 May 2023 05:35:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683981307; cv=none; d=google.com; s=arc-20160816; b=yQ8a3cd8MR4Pisl0iu+DTXITiXZqFuq27d7JVDaKbSlpIk0RfNZ+WcUmriA30KSluK ospbl+zL70XpMbmtUXq+a2DBEzbd4tXdKTvVqD+ljqdFzucZ7kne0EfSRTRHepN+ftm1 SSVjUW0m3ZRbUDXDHo1RaA+ZsPRzbcXStQ/G7LrfVNK2FP7zabP9zndiQ3C1tQuguIL1 T8PU+qjCuOZwMx7K9sPBNelwc3IC76QkEZtkX15uJXVTegxafF4+jpRKRzwrAl4Cxhd8 t/eAdalcS6eYAo76/vrhmAVsb2E7bhe2c+fRDuc/C54SWbSGdX0Ttu6whMrwutajOn4V Kd8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=tPaRCdR9znhCSBNCV7Zh/uxMhVYAfQIv0T/cvc7dHOA=; b=NQnQvBdLiiqPmtQm2fOW3BpQIeEAG6CvxLeKdWKrrnee5DnJAm2mwWR5tUczYa2NJO e2kQqtqQ1NhL9xB1JBARXW+XrI5gSmarUW4A8DANmA5REeUkKLgT9O072gjuYiFncAVN B0+4rOWs9M2DpenJHTVXIFLyVqbtKJ737g5BeHcUURD+chnyOzEBpHLoU1zkgroJdK93 2egKQVWQMkWmP420xakIvqm254O6E6xHZRIFAUPte/rPI0u9VH9cjYDOcqectq6wLWFX 1FLpbm2KNOxXfbKF6dR+7fmcSZ9F3RmPhAA37gCw51mZB04BBlyFAGfUjVpx4ODWjL8I VYtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LJqiQfQM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n8-20020a170902e54800b001a1d78af685si12725811plf.466.2023.05.13.05.34.20; Sat, 13 May 2023 05:35:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LJqiQfQM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238257AbjEMLwK (ORCPT + 99 others); Sat, 13 May 2023 07:52:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238172AbjEMLwJ (ORCPT ); Sat, 13 May 2023 07:52:09 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F2BF2690 for ; Sat, 13 May 2023 04:52:08 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-50bc22805d3so16506096a12.1 for ; Sat, 13 May 2023 04:52:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683978727; x=1686570727; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=tPaRCdR9znhCSBNCV7Zh/uxMhVYAfQIv0T/cvc7dHOA=; b=LJqiQfQMoppCQZsnl7OLFprYP0Kd1l+UkZSnATNGUlYSEx232Hls0lKeCqmD/UEvhf mcXpGlLVAaNqi2/+XMQlOVQibPEt7nEAcpCWFccnXg8O37i3aFMro80yk/fV0nkCcqQy yVMsD+sU3LHl4lSauac8rd9YCggFgoodhsCGbM5Eh2HoLDIosa8gy3u+Thn/EqFjpg/j FDuHuIgel9KC/esPGWsUpObX7QxW5Y1JKUR7PZvb2PQ28zPXzjQngEz42S3ckpPpWuE8 qbKaf2uNxxrUEz0tKdtjhDuxMc8lpHJ3cyX1A5wZxiJiCHY9Gq7nE2LJa7wSG3bVxTg5 JjSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683978727; x=1686570727; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tPaRCdR9znhCSBNCV7Zh/uxMhVYAfQIv0T/cvc7dHOA=; b=ONAcZjbfZwbcH1C9Jy9SWMzZdqjQJeWPUDjedudFhfH5ZnKRckH/vC4eKhIZbF5d9s dE85EGJloG11jBwNMuQzPb8q01XQTYbOwSa2GpvrRsag+SKcYJHyVGVhrbcrd3FX/fb7 eU2zBbYfLJeFNoL+gCg94A57ARYHcRrxrjGbMPwKqXihjBjEpS+M7l+0tGRcW/CP0kMq wGV3QEJaDCfUOS4364P44SpxzwSUt8HxWqTr6zNWlAtBixhWmoLfHso098gGz4dDqAJ9 TK2OH3yjT2deh6FarsFk+edsgbsQ90F6w6usWJTLJFSxr6aqxkYV2kQqqqe/E3Bh8hac cObA== X-Gm-Message-State: AC+VfDztjRfmbD0o05M03QVeqafqd1dv9/TcI9CW4WkZmKaeMzI03vzN /PJkSodDTeaTSNwAwsz9tIrPpw== X-Received: by 2002:a17:907:c1f:b0:961:ba6c:e949 with SMTP id ga31-20020a1709070c1f00b00961ba6ce949mr27914478ejc.68.1683978726791; Sat, 13 May 2023 04:52:06 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3aa:fd4:f432:676b]) by smtp.gmail.com with ESMTPSA id hy25-20020a1709068a7900b0096607baaf19sm6723119ejc.101.2023.05.13.04.52.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 May 2023 04:52:06 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Thierry Escande , Samuel Ortiz , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2] nfc: llcp: fix possible use of uninitialized variable in nfc_llcp_send_connect() Date: Sat, 13 May 2023 13:52:04 +0200 Message-Id: <20230513115204.179437-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765782383655057102?= X-GMAIL-MSGID: =?utf-8?q?1765782383655057102?= If sock->service_name is NULL, the local variable service_name_tlv_length will not be assigned by nfc_llcp_build_tlv(), later leading to using value frmo the stack. Smatch warning: net/nfc/llcp_commands.c:442 nfc_llcp_send_connect() error: uninitialized symbol 'service_name_tlv_length'. Fixes: de9e5aeb4f40 ("NFC: llcp: Fix usage of llcp_add_tlv()") Signed-off-by: Krzysztof Kozlowski --- Changes in v2: 1. Fix typo in subject prefix. --- net/nfc/llcp_commands.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/nfc/llcp_commands.c b/net/nfc/llcp_commands.c index 41e3a20c8935..cdb001de0692 100644 --- a/net/nfc/llcp_commands.c +++ b/net/nfc/llcp_commands.c @@ -390,7 +390,8 @@ int nfc_llcp_send_connect(struct nfc_llcp_sock *sock) const u8 *service_name_tlv = NULL; const u8 *miux_tlv = NULL; const u8 *rw_tlv = NULL; - u8 service_name_tlv_length, miux_tlv_length, rw_tlv_length, rw; + u8 service_name_tlv_length = 0; + u8 miux_tlv_length, rw_tlv_length, rw; int err; u16 size = 0; __be16 miux;