From patchwork Fri May 12 16:43:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uros Bizjak X-Patchwork-Id: 93280 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp5247580vqo; Fri, 12 May 2023 09:44:52 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7mXfRbRhgWECpv02kl2YwyGjfMMBiWGfisVw2KEx6DRg4TsPnaAn3k61SfAeblxewD6to0 X-Received: by 2002:a17:907:3686:b0:94a:56ec:7f12 with SMTP id bi6-20020a170907368600b0094a56ec7f12mr24260625ejc.30.1683909892428; Fri, 12 May 2023 09:44:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683909892; cv=none; d=google.com; s=arc-20160816; b=TVKcTExpMgR1jBbFUrY5fxl/AjDTwg6vRqWp+p/8r39X4QMhwJusVNGzP9ruRzBoRU elZWr+im5rbfH/3RJ6ohpk6jStJv/JhOuJXhBE8NmX3HX2AZ/yfJKsrvgQ0sHs8Pcdtt 2/v4iOOR5EaxLD+1pT30nM+fGdtKRg6fIQPMvIMS3zOe//Zo8Man3bZ9w/d5OTHlaLEs IVvUlcJ2oF/hyNxihqPPEyuAOwudPNhQnpTpGbNpQBOQ6YAKhGbG37ZM3dZ60MRAL1lP p63xWb3aofvSLMtREJLCbWau3XjXW9IEXWLu0tE67T16MGKiELv7XAUnePcG1xK13mCk lZgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:to:subject :message-id:date:mime-version:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=wPUcZnvDv2s/FfRkKnueCcQyZoX0bsq7N04jhGJnBB4=; b=TWgyK4BR6cii61GmXdCXOp2zhBVFuI2bFQTpuNGYdQYFozg+ZcaaNZjxq/t9be6qOM hsoSz3S07qrw5usHE9mS+XD52O/jNjxFEPQWeSFW/KupT++o/xOwoP2Up+27BcUgAQ6e 789cKdNVBdTvOaCkbHPvvbo68yHyK/35AVYh+HZ5vhrG8GFv+1taIJtoEZKZqO4wfOZ6 DOWskX5LlAi8Ki2CnVZD7W02RDmPVMeCw3AXSdF3pL96MVcw9cQimacey1cbrRfTvMRz ZwiEUVPdet0dZs+SlfespCr7ksDpzyIhrdUBzRmXsF3aSGxbaVbL0mpGxjei/Eir6WYP pTOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=XC3gdH1x; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id hx26-20020a170906847a00b00965a46dd290si7772962ejc.199.2023.05.12.09.44.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 May 2023 09:44:52 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=XC3gdH1x; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 570D8385B530 for ; Fri, 12 May 2023 16:44:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 570D8385B530 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1683909891; bh=wPUcZnvDv2s/FfRkKnueCcQyZoX0bsq7N04jhGJnBB4=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=XC3gdH1x/rpPM+j7qOtlunUhLGJYKd4zIvnRrs1Oxd04HeCVLm3JL1dZBZ1VZ+TYU lMJIkvsox/cKzY/Q2mg/4Yf5hcIaK9/COvCMvc2hKqYiqg0ZNM3AqF/cSmY8k01qxR RCSCOY4KLu8CfrQ56xkc7vE6rMbk5fti5Bc/UcRw= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) by sourceware.org (Postfix) with ESMTPS id E9B9B3858C54 for ; Fri, 12 May 2023 16:44:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E9B9B3858C54 Received: by mail-qk1-x736.google.com with SMTP id af79cd13be357-75131c2997bso3489319985a.1 for ; Fri, 12 May 2023 09:44:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683909842; x=1686501842; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=wPUcZnvDv2s/FfRkKnueCcQyZoX0bsq7N04jhGJnBB4=; b=Nu3/JCtovtL/uSBUKV5Bu2eWKLBrfvv7kHjmD4ekhfbKY19e+lyxNG3VDtqhhrigVh /O1dz8Kep1e0jcgEgLftoqF2gVY+ZJ8TlVu54O69rrhl1cSzHPHwDuv9deTyeFC/9gQ9 9BbfLeHQmplslQ9eGw/JZlUdkmWb7PIDMu8JdwqOxFQWPOhJyi6gxbWwfhALIPbzWujF eJTOrl1XzeRcff1b5jL3Y3QEw8bGPBTllaJMhEzSydoe8KezvZdv77QY+Q/f5HiptIQg tupbZLIUnKu3HtowUTZZmtysaVUFgqvA0GEOAzjnPFsW+ikEAN1/ieLupgFtckMZxtel Co6A== X-Gm-Message-State: AC+VfDwmQaXtev6dGdPM6fHqpwiw2Z/QvFQUiNb3H+Ds6ijDRIkssKar fIcSe3Ev17Dmv0CLXQNTggCRn60XazCbNI7mciJYeP8Iuk0kIA== X-Received: by 2002:ad4:5cce:0:b0:5ac:96c3:14d4 with SMTP id iu14-20020ad45cce000000b005ac96c314d4mr37893456qvb.17.1683909841961; Fri, 12 May 2023 09:44:01 -0700 (PDT) MIME-Version: 1.0 Date: Fri, 12 May 2023 18:43:50 +0200 Message-ID: Subject: [PATCH] i386: Remove mulv2si emulated sequence for TARGET_SSE2 [PR109797] To: "gcc-patches@gcc.gnu.org" X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Uros Bizjak via Gcc-patches From: Uros Bizjak Reply-To: Uros Bizjak Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765707499431742622?= X-GMAIL-MSGID: =?utf-8?q?1765707499431742622?= Remove mulv2si emulated sequence for TARGET_SSE2 and enable only native PMULLD instruction for TARGET_SSE4_1. Ideally, the vectorization for TARGET_SSE2 should depend on more precise cost estimation (the PR contains patch for ix86_multiplication_cost), but even with patched cost function the runtime regression was not fixed. PR target/109797 gcc/ChangeLog: * config/i386/mmx.md (mulv2si3): Remove expander. (mulv2si3): Rename insn pattern from *mulv2si. Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Pushed to master. Uros. diff --git a/gcc/config/i386/mmx.md b/gcc/config/i386/mmx.md index e7ca921dd2b..b2954fff8ae 100644 --- a/gcc/config/i386/mmx.md +++ b/gcc/config/i386/mmx.md @@ -2092,39 +2092,7 @@ (define_insn "*3" (set_attr "type" "sseadd") (set_attr "mode" "TI")]) -(define_expand "mulv2si3" - [(set (match_operand:V2SI 0 "register_operand") - (mult:V2SI - (match_operand:V2SI 1 "register_operand") - (match_operand:V2SI 2 "register_operand")))] - "TARGET_MMX_WITH_SSE" -{ - if (!TARGET_SSE4_1) - { - rtx op1 = lowpart_subreg (V4SImode, force_reg (V2SImode, operands[1]), - V2SImode); - rtx op2 = lowpart_subreg (V4SImode, force_reg (V2SImode, operands[2]), - V2SImode); - - rtx tmp1 = gen_reg_rtx (V4SImode); - emit_insn (gen_vec_interleave_lowv4si (tmp1, op1, op1)); - rtx tmp2 = gen_reg_rtx (V4SImode); - emit_insn (gen_vec_interleave_lowv4si (tmp2, op2, op2)); - - rtx res = gen_reg_rtx (V2DImode); - emit_insn (gen_vec_widen_umult_even_v4si (res, tmp1, tmp2)); - - rtx op0 = gen_reg_rtx (V4SImode); - emit_insn (gen_sse2_pshufd_1 (op0, gen_lowpart (V4SImode, res), - const0_rtx, const2_rtx, - const0_rtx, const2_rtx)); - - emit_move_insn (operands[0], lowpart_subreg (V2SImode, op0, V4SImode)); - DONE; - } -}) - -(define_insn "*mulv2si3" +(define_insn "mulv2si3" [(set (match_operand:V2SI 0 "register_operand" "=Yr,*x,v") (mult:V2SI (match_operand:V2SI 1 "register_operand" "%0,0,v")